- 02 Dec, 2019 40 commits
-
-
Rayan Kanso authored
Bug: 1024911 Change-Id: I37b5e4606f982f15a2e30c397de7183027940bea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928772Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#720467}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3af1ae4c5509..3d978726cc5a Created with: gclient setdep -r src-internal@3d978726cc5a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: I1a122d3dc0a53c2c7f87038a1ef0ed019d319ab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946448Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720466}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1743241c4bad..1236f9cb9e83 git log 1743241c4bad..1236f9cb9e83 --date=short --first-parent --format='%ad %ae %s' 2019-12-02 rslawik@google.com Merge "Add all matched packages to process metadata" 2019-12-02 hjd@google.com Merge "fuzzer: Remove bad CHECK on Send" Created with: gclient setdep -r src/third_party/perfetto@1236f9cb9e83 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I6b134ed6cd795dbd18a87e262861b575d7856f91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945917Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720465}
-
Alex Ilin authored
This CL adds a new LiveSignInTest::CancelSync to the suite of live signin tests. The test does the following: - Starts the signin flow from the settings page - Enters test account credentials on the login page - Cancels the sync confirmation dialog - Checks that Sync is disabled and there are no accounts in Chrome and on the web Bug: 1008888 Change-Id: I2480fc7eed0b927048b11894e75e859abb31c917 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946371 Commit-Queue: Alex Ilin <alexilin@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: Alex Ilin <alexilin@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#720464}
-
Guido Urdaneta authored
Bug: 1027481 Change-Id: I7fc1806eada39c58f3f6035736bf9d5c595fbb0b TBR: pwnall@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946331Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#720463}
-
Jan Scheffler authored
This cl depends on crrev.com/c/1934213 Bug: chromium:1016772 Change-Id: I345d99b96dff194400c035d2885973feaca13ea0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936249 Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#720462}
-
Tim van der Lippe authored
The view will be removed from the front_end [1]. [1]: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/1946467 Change-Id: I015491b5070e9eabb9958a21eff488d8082d6f73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946372 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#720461}
-
Guido Urdaneta authored
Disable on Windows because it is flaky. Bug: 1028371 Change-Id: I05e7c3988f8da24417b4f1da4091227f91638bdc TBR: svaldez@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944673Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d4092e36afe4..48c9ef678756 git log d4092e36afe4..48c9ef678756 --date=short --first-parent --format='%ad %ae %s' 2019-12-02 janscheffler@chromium.org Fix background on rows with error network logview 2019-12-02 sigurds@chromium.org [memory] Offer 'Store as variable' in the heap profiler views 2019-12-02 aerotwist@chromium.org Updates manage_node_deps to install missing deps; adds yargs Created with: gclient setdep -r src/third_party/devtools-frontend/src@48c9ef678756 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1029518,chromium:1027519 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I90f1cddca29c16f6e0336e1c0f770d5ce28204f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945916Reviewed-by:
-
Miyoung Shin authored
This CL converts OfflinePageAutoFetcher mojom interface clients in chrome to use BrowserInterfaceBroker. Bug: 936482 Change-Id: Idd3f464cbb13641037a1406bc34199d4a59eb6e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1941727Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
-
Friedrich Horschig authored
TintedDrawables accepts all kinds of resources but renders empty images for VectorDrawables (which is how the linked bug occurred). This CL fixes the missing icon by using UiUtils.getTintedDrawable when loading the permission icons. I'd suggest to either fix TintedDrawable or at least assert that the given drawable is a bitmap to prevent the silent failure. (Adding this in a separate CL that is not a fix might be a good idea, though.) Tested on KitKat and Oreo. Works with dark mode. Screenshots in the linked bug. Bug: 1028925 Change-Id: I9ef6b67bcc8a7e0c02acd5a0b6b0221fafaa6765 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942691Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#720457}
-
Jinfeng Ma authored
CompositedLayerMapping::NeedsRepaint always returned true if the target graphics layer is a scrollable area layer. This can be optimized because we can get paint invalidation flag from the overflow controls. Change-Id: Ie2612794403fabd8dcb8dad7aca41a60dfbb0c69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943501Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#720456}
-
Mia Glaese authored
Screenshots here: https://drive.google.com/open?id=1jqvHaKpi_7gKqnBO7tbOXlBcB_xTLjMQ Bug: 1028491 Change-Id: I854da2f726e0118dde7815f08457fc95e6cf8c95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944530Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Mia Glaese <glamia@chromium.org> Cr-Commit-Position: refs/heads/master@{#720455}
-
Hans Wennborg authored
Ran `tools/clang/scripts/upload_revision.py c2443155a0fb245c8f17f2c1c72b6ea391e86e81`. Bug: 1028108, 1029385 Change-Id: I1222d343130a0c159c1283f20c41f60cb1b6db14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944343 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#720454}
-
Abhijeet Kandalkar authored
This CL has goal to use IsA<SVGFEDropShadowElement>(element) in place of IsSVGFEDropShadowElement(element) Bug: 891908 Change-Id: I01b8c852bb487493847267af2dd5ea7ffeede0d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936575 Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#720453}
-
Marc Treib authored
- Some obsolete TODOs are removed. - Valid TODOs are linked to a bug instead of a username. - Some valid TODOs are also made more specific etc. Bug: 1029479 Change-Id: Ic74475137ba543a8d1f73ab3a524596d722d7468 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945171Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#720452}
-
Gyuyoung Kim authored
This CL removes Create() factory functions in //third_partyb/blink/renderer/modules/webmidi as much as possible, and makes all callers use MakeGarbageCollected<Foo> instead. This CL removes below factory functions, - MIDIAccess::Create - MIDIInput::Create - MIDIMessageEvent::Create - MIDIOutput::Create Bug: 939691 Change-Id: Ic8342bd035c5b52c569bec574878db0e60b6f1af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946172Reviewed-by:
-
Peter E Conn authored
The changes in androidx.browser can be found: https://developer.android.com/jetpack/androidx/releases/browser#1.2.0-alpha09 Most of the binary size increase comes from introducing the first dependency on androidx.concurrent-futures and guava-listenablefutures. This was discussed at: https://groups.google.com/a/google.com/forum/#!topic/chrome-eng-review/CnHi7a4dH5Y Binary-Size: Unavoidable (see above). Bug: 1029011 Change-Id: I7630a4f65fc7c309c97a065154ef143507bcd3e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1940329Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#720450}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8df9e6a2d570..1743241c4bad git log 8df9e6a2d570..1743241c4bad --date=short --first-parent --format='%ad %ae %s' 2019-11-29 tneda@google.com perfetto-ui: Prevent lots of flamegraph queries being queued Created with: gclient setdep -r src/third_party/perfetto@1743241c4bad If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I022c7499841a30a42ca0bde0696635813b7a62c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946447Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7bf8e78da3a8..d4092e36afe4 git log 7bf8e78da3a8..d4092e36afe4 --date=short --first-parent --format='%ad %ae %s' 2019-12-02 szuend@chromium.org Remove top-level await pre-processing Created with: gclient setdep -r src/third_party/devtools-frontend/src@d4092e36afe4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1021921 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I45bb40e0132fa6e644707d90b6893b7456964486 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946416Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium ae2e3478. With Chromium commits locally applied on WPT: 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." a2a91a99 "Allow another touch start happen when there are active touch points" 85b61e6b "[resource-timing] Ensure workerStart is protected by TAO" a75430aa "Fix appcache tests." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I117bbeda1c3346ff93511ad081411b0b02c267b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944382Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#720447}
-
Mia Glaese authored
Bug: 982018 Change-Id: I1adba120b3d1b471dab96e5493d18a9fe64aadfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936849 Commit-Queue: Mia Glaese <glamia@chromium.org> Reviewed-by:
-
Matt Falkenhagen authored
Follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1942900 Bug: 1007635 Change-Id: Ia8e00da415fdf5d470a4d78af3f9a056f3808154 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943780Reviewed-by:
-
Alex Ilin authored
This CL adds a new LiveSigninTest::CancelSyncWithWebAccount to the suite of live signin tests. The test does the following: - Signs in on the web - Goes to the settings page and starts the enable Sync flow - Cancels the sync confirmation dialog - Checks that the account is still signed in but Sync is disabled This CL adds a new method to cancel the sync confirmation dialog to login_ui_test_utils. The CL also fixes a bug in the javascript injected to the sync confirmation dialog from SigninViewControllerTestUtil::TryDismissSyncConfirmationDialog. "document.querySelector('sync-confirmation-app')" may evaluate in null that causes the subsequent attempt to access "shadowRoot" to throw an exception. content::ExecuteScriptAndExtractString(), however, stays blocked because it waits for a message to be sent through "window.domAutomationController.send()". All of this makes the test timeout. Bug: 1008891 Change-Id: I6793e40d400ca62f97ea1d60b99b628aabefb369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944389Reviewed-by:Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#720444}
-
Yuki Shiino authored
LocalDOMWindow::navigator() uses GetFrame() without checking if a frame (still) exists or not. Support the case of frame=nullptr in NavigatorLanguage, etc. Bug: 1026284 Change-Id: I99cae96b9bfe70ff52198e8db84a100fccbda5dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1943653 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<SVGPathElement> and DynamicTo<SVGPathElement> as new downcast helper 2. Use IsA<SVGPathElement>(element) in place of IsSVGPathElement(element) Bug: 891908 Change-Id: Ibbfb1dec739672a3c7a1bf9fc48b4478a4eea604 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936613 Commit-Queue: Abhijeet | Igalia <abhijeet@igalia.com> Reviewed-by:
-
Jérôme Lebel authored
TBR: stkhapugin Bug: 1029709 Change-Id: Ic8d7021777e1977e9071d05853958646b74efc0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944472Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#720441}
-
Guido Urdaneta authored
Mark http/tests/devtools/network/oopif-content.js as Flaky on Linux. It has flaked a lot recently and even caused CQ false rejections. Bug: 1029528 Change-Id: I682559b28e741b956bf413ebc139da6b8e7556ca No-Try: True TBR: caseq@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946330Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d050e5a75e36..d523ce04e70a git log d050e5a75e36..d523ce04e70a --date=short --first-parent --format='%ad %ae %s' 2019-12-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src c8e3617e..8a450048 (272 commits) 2019-12-02 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 bc82fb14aab4..ea0dcd4bda18 (7 commits) Created with: gclient setdep -r src/third_party/skia@d523ce04e70a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC bsalomon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None,chromium:None Tbr: bsalomon@google.com Change-Id: I2e90b8489e2db535f5614b900a4c3d6194c56084 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946087Reviewed-by:
-
Adam Rice authored
TransformStream and TransformStreamNative were separated to support having multiple implementation. Now that the V8 extras implementation has been removed, this division is no longer necessary. The initialisation of TransformStream has changed somewhat because it is no longer delegated. Modify users of TransformStreamDefaultControllerInterface to use TransformStreamDefaultController directly, and remove it. BUG=1029408 Change-Id: Ifd9fc0e71a52174eb33c60d08e93f5e74303eca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1942893 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#720438}
-
Guido Urdaneta authored
Mark external/wpt/cookie-store/cookieStoreManager_getSubscriptions_multiple.tentative.https.any.html as flaky. It has been flaking on all platforms and sometimes causing CQ false rejections. Bug: 1029713 Change-Id: I6069378774bc801902d50e65de8a00fb77ca8faf TBR: jsbell@chromium.org No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944672Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/df12488bf4f8..3af1ae4c5509 Created with: gclient setdep -r src-internal@3af1ae4c5509 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None,chromium:None,chromium:None Tbr: jbudorick@google.com Change-Id: I6134f99682d19dedd9820bc4e49f0405f9adf456 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946410Reviewed-by:
-
Mikel Astiz authored
Crashes have been reported on Beta and and the implementation has been refactored since (base::Value refactoring) so it's safest to just disable the garbage-collection for one milestone. Bug: 1029673,989340 Change-Id: Id2e062ba302a7ffea970964170c492b513a52b73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1945812 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#720435}
-
Juan Antonio Navarro Perez authored
Test is flaky. Bug: 971998 Change-Id: I357c5bf76ca34584c5a97cfd979272d52d88ee94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946369Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#720434}
-
Jan Wilken Dörrie authored
This change contains a small fix to the leak detection toggle when users navigate to the sync settings page from another settings page. Bug: 1029515 Change-Id: I3fbd63ea1e4d65cda43b45f9a1bbcc3639aceee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944174 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#720433}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<SVGMaskElement> as new downcast helper 2. Use IsA<SVGMaskElement>(element) in place of IsSVGMaskElement(element) Bug: 891908 Change-Id: I2781f717a10afb6187228647581b99a864ad851e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1936612Reviewed-by: -
David Roger authored
This fixes a crash introduced by CL https://chromium-review.googlesource.com/c/chromium/src/+/1944387 Sync promos can be shown in incognito, and they used to be non-Dice promos. Dice promos are now used. To match the previous behavior, they use an empty list of accounts. Fixed: 1029634 Change-Id: I5761681517d4cc3af052e9835b347439e528106b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1946328Reviewed-by:
-
Andy Paicu authored
This CL adds a checkbox that will display the current state of the notifications prompt quiet UI, which the user can then enable/disable at will. The quiet UI can be automatically-enabled by embargo-logic. Bug: 1014874 Change-Id: Ia5e68877acf4b4dce82fe4eb1679706c62c7f9de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930820Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Andy Paicu <andypaicu@chromium.org> Cr-Commit-Position: refs/heads/master@{#720430}
-
Hugo Holgersson authored
When a fragmented (line broken) link has focus, we use one of its fragments (not their union) as search origin. Going Left: Start at the beginning of the link (the first fragment). Going Right: Start at the end of the link (the last fragment). This feels more intuitive and is probably a better UX for most users since most texts are written left-to-right. Discussed in: crrev.com/c/1912661 Bug: 1029269 Change-Id: I2ba214a3208ce82d3b6cb6a85b6840b3d9c33961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944169 Commit-Queue: Hugo Holgersson <hholgersson@fb.com> Reviewed-by:
Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#720429}
-
Carlos Caballero authored
MessageLoop is going away soon. This CL was uploaded by git cl split. R=rmcilroy@chromium.org Bug: 891670 Change-Id: I123507e4d4145ab7717729ddb122c6eb990f1827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1944669 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#720428}
-
