- 21 Aug, 2018 40 commits
-
-
Grzegorz Gacek authored
Fix use-after-free which occured when a menu contained an item closing it on a mouse press event. In such case MenuController object was freed during a call of its OnMousePressed() but it continued to modify its member variables. Bug: 871205 Change-Id: Ic2a5dd3a745da6b0c1ef7a87f2cb498cc1a97234 Reviewed-on: https://chromium-review.googlesource.com/1163617Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#584706}
-
David Roger authored
This metric is recorded at startup, and tracks the state of the privacy settings. Bug: 871267 Change-Id: I5c9b53e732d160912c387b770148996f52115dcc Reviewed-on: https://chromium-review.googlesource.com/1179893 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#584705}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ca0cdef06349..f13375c925bf git log ca0cdef06349..f13375c925bf --date=short --no-merges --format='%ad %ae %s' 2018-08-21 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 d20e80b840e4..7a4f6b8c7d5e (2 commits) Created with: gclient setdep -r src/third_party/skia@f13375c925bf The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fmalita@chromium.org Change-Id: I41320545dcd1133a9aff353d61ed3ee395076589 Reviewed-on: https://chromium-review.googlesource.com/1183141Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584704}
-
Armando Miraglia authored
According to the TODOs left in the code and the state of crbug/803102, it is now safe to remove the params.IsValid() from some if-statements. This is so, when the paramters are passed through Mojo, which will already perform the checks. To guarantee that all is working correctly, the check is transfromed into a DCHECK. BUG=803102 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I069a902141d8003f2bb9656f691b5bbbdb69c259 Reviewed-on: https://chromium-review.googlesource.com/1181134Reviewed-by:
Max Morin <maxmorin@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#584703}
-
Matt Falkenhagen authored
This was disabled on Windows and had separate expectations on Linux and Mac. It should be able to run on all platforms with a single expectation file. Attempting that. Bug: 876223, 757165 Change-Id: I5ea603e037373a6c17edc00a1a14177a8be99a1a Reviewed-on: https://chromium-review.googlesource.com/1183049Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#584702}
-
Chromium WPT Sync authored
Using wpt-import in Chromium b2e6da0b. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23112 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: yhirano@chromium.org, mkwst@chromium.org, japhet@chromium.org: external/wpt/fetch NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: Ide65b830ffffea860e3a846154ee7b55c09699af Reviewed-on: https://chromium-review.googlesource.com/1182959 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#584701}
-
Alexander Semashko authored
The test was disabled because switching WindowedNotificationObserver to use base::RunLoop instead of deprecated MessageLoopRunner made it flaky. R=atwilson@chromium.org Bug: 668707, 865453 Change-Id: Ideff2420f51232bb7e590a0f242efaec64f598a0 Reviewed-on: https://chromium-review.googlesource.com/1120494 Commit-Queue: Alexander Semashko <ahest@yandex-team.ru> Reviewed-by:
Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#584700}
-
Yoshifumi Inoue authored
This reverts commit 37bc2e24. Reason for revert: Failed memory.leak_detection/http://www.reverso.net/ https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Leak%20Detection%20Linux/17094 Original change's description: > Reland introduce sharding to memory.leak_detection > > This CL fixes a bug in test_suites.pyl and introduces sharding to memory.leak_detection benchmark. > Original CL: https://chromium-review.googlesource.com/c/chromium/src/+/1180788 > TBR=nednguyen@chromium.org,dpranke@chromium.org > > Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi > Change-Id: Ie1a3be0b3b47a9feb57d77a779a6df8cf8257a3c > Reviewed-on: https://chromium-review.googlesource.com/1182714 > Reviewed-by: Yuzu Saijo <yuzus@chromium.org> > Commit-Queue: Yuzu Saijo <yuzus@chromium.org> > Cr-Commit-Position: refs/heads/master@{#584644} TBR=dpranke@chromium.org,nednguyen@google.com,yuzus@chromium.org Change-Id: I1408b03949cdfe684c0beaaa6444410532cf9891 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Reviewed-on: https://chromium-review.googlesource.com/1182764Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584699}
-
afdo-chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 The AutoRoll server is located here: https://afdo-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: Iccce4c6ce5527f5cde41ec832181317dad7ded5a Reviewed-on: https://chromium-review.googlesource.com/1183024Reviewed-by:
afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: afdo-chromium-autoroll <afdo-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584698}
-
Yuzu Saijo authored
This CL implements v1 OOM intervention for Android Go, which drops ads to reduce memory usage. Change-Id: I64da6a3cc91adaf869fae8fadd8b032c5e8e205f Bug: 776665 Reviewed-on: https://chromium-review.googlesource.com/1055408Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuzu Saijo <yuzus@chromium.org> Cr-Commit-Position: refs/heads/master@{#584697}
-
Thomas Tangl authored
Changes of this CL: - The learn-more link for Sync and Google services is only shown when unified consent is enabled. - The learn-more link is updated and now redirects to https://support.google.com/chrome?p=syncgoogleservices. Bug: 875869, 875748 Change-Id: Ieeffa33da578d5bb22e547246cd12d285c26c390 Reviewed-on: https://chromium-review.googlesource.com/1181428Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#584696}
-
Michael Lippautz authored
Compaction uses overlapping writes which means that the source (from) object may be overwritten by the target (to) object. Since the contents are just copied over the target can be used for reading a slots value. Bug: chromium:875044 Change-Id: I3945fffe4bd1d4f04b57a0964b85d9de7551122e Reviewed-on: https://chromium-review.googlesource.com/1181572 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#584695}
-
Trent Apted authored
Turns a possible UAF when trying to notify a deleted observer into a CHECK(). This is achieved with minimal changes to ObserverList and an adapter that gives WeakPtr-like semantics to an observer interface. base::ObserverList<T>::Unchecked continues to use raw pointers that are unchecked. Bug: 842987, 808318 Change-Id: I8ab20845f4f6e1d2559490287731cea2dbf40d39 Reviewed-on: https://chromium-review.googlesource.com/1053338 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#584694}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d20e80b840e4..4836acc518ab git log d20e80b840e4..4836acc518ab --date=short --no-merges --format='%ad %ae %s' 2018-08-21 oetuaho@nvidia.com Rename and reorganize MultiviewRenderTestBase Created with: gclient setdep -r src/third_party/angle@4836acc518ab The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I11ddf6577b67d912118b6cf2ec4d689abaa262ba Reviewed-on: https://chromium-review.googlesource.com/1182684Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584693}
-
Kazuhiro Inaba authored
Rationales: * Android CTS requires this configuration. https://source.android.com/compatibility/cts/setup#config_device * All the other existing ARC autotest are oblivious to this config. (Moreover, since the default choice of this config when the normal user opts-in to ARC is 'enabled', if we were to choose one, I think we should test the 'enabled' state rather than disabled.) So, it was the easiest way for me to just enable it globaly. Alternatives considered: [Instead of using autotest API, directly modify the config via adb etc.] * Difficult. Only priviledged processes can modify the config with confirmation UI suppressed. ArcIntentHandler who syncs the kArcLocationServiceEnabled pref to ARC can do that, but adb not. * Even if we could, have to deal with race issue between ArcIntentHelper's sync timing for the pref. [Add new autotestPrivate API for this and use in CTS] * As I wrote in the rationales, we aren't gonna need this complexity. BUG=b:111100137 TEST=cheets_CTS_P.9.0_r2.arm.CtsBluetoothTestCases starts passing. TEST=All (otherwise passing) cheets_* tests continues passing. Change-Id: I28047775c9c806d6dd24af852c97271f656bb17b Reviewed-on: https://chromium-review.googlesource.com/1179515 Commit-Queue: Kazuhiro Inaba <kinaba@chromium.org> Reviewed-by:Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Cr-Commit-Position: refs/heads/master@{#584692}
-
Javier Ernesto Flores Robles authored
Creates a new UITableViewCell to show user credentials in a table view. The design is according to the specs for Manual Fallback, which can be found in: https://folio.googleplex.com/ntp/Autofill/Autofill%20Manual%20Fallback Bug: 845472 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Iaa916c36dfb9ca2a567c904c4ab536b037840077 Reviewed-on: https://chromium-review.googlesource.com/1179756 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#584691}
-
Rune Lillesveen authored
We don't have a repro for this, but there are crashes in the wild where we haven't got a ComputedStyle when attaching the layout tree for a UA shadow DOM element inside an HTML input element. Add a NOTREACHED to try to catch it, but fall back to compute the style to avoid crashes when it happens. Bug: 875796 Change-Id: I24ef78183df6faa6bfea88a7e5f8ad0d7f2bf14c Reviewed-on: https://chromium-review.googlesource.com/1182806 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#584690}
-
Eliot Courtney authored
Bug: 841886 Bug: b/69370942 Test: unit test Test: manually tested Android PIP causing Chrome PIP to close and vice-versa Change-Id: Ic524db7d48b31d3351a3a669fc48b769a155d956 Reviewed-on: https://chromium-review.googlesource.com/1145148Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Commit-Queue: Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#584689}
-
Alexandr Ilin authored
The predictor used to set the is_speculative flag and lower the priority of resolve host request. This was missed in the CL https://crrev.com/c/1165550. This CL restores this parameters for the predictor. Bug: 809583 Change-Id: Iebfd2ca28bed1a854b6e3b929441b79cfc178f80 Reviewed-on: https://chromium-review.googlesource.com/1180965Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584688}
-
Keishi Hattori authored
Remove outdated parts related to threads and safe points. Change-Id: I1faa4368e0534440e87de7c2cf0fe2d30b9ad917 Reviewed-on: https://chromium-review.googlesource.com/1181013 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#584687}
-
Yoshifumi Inoue authored
See https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=virtual%2Fvideo-surface-layer%2Fmedia%2Fcontrols%2Ftext-track-menu-pointer-selection.html TBR=mlamouri@chromium.org Bug: 876050 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ic267158a7452484098a039d5fd3da1fbf655d22d Reviewed-on: https://chromium-review.googlesource.com/1183047Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584686}
-
Andreas Haas authored
The flag is passed to V8 via a callback which has already been implemented in V8 in https://crrev.com/c/1163621. Bug: 868844 Change-Id: Ic10c6330ba23a37c5dedd1073a0ea55c6cd86f7c Reviewed-on: https://chromium-review.googlesource.com/1167187Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jason Chase <chasej@chromium.org> Commit-Queue: Andreas Haas <ahaas@chromium.org> Cr-Commit-Position: refs/heads/master@{#584685}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1dc067f0d0f9..ca77050d3e65 git log 1dc067f0d0f9..ca77050d3e65 --date=short --no-merges --format='%ad %ae %s' 2018-08-20 kwekua@google.com Fixing some typos. Created with: gclient setdep -r src/third_party/perfetto@ca77050d3e65 The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:N/A TBR=perfetto-bugs@google.com Change-Id: I5c0f4ed3fd7e956c7bde6f0021b6d19ef9d81af7 Reviewed-on: https://chromium-review.googlesource.com/1182683Reviewed-by:
perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: perfetto-chromium-autoroll <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#584684}
-
Rune Lillesveen authored
The test is not relying on fonts loading, but start using dummy urls instead. Bug: 875805 Change-Id: I4821e9e74fc9383d77ec2afd57652103e72f35c2 Reviewed-on: https://chromium-review.googlesource.com/1182807Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#584683}
-
Trent Apted authored
r584330 updated all annotations on ObserverList declarations to be ::Unchecked, but a few new declarations appeared since that. They need to be ::Unchecked as well in order for https://crrev.com/c/1053338 to land cleanly. TBR=gab@chromium.org Bug: 842987 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I1c6d7ae8e9668438afa8184fd0c3884a21e9732d Reviewed-on: https://chromium-review.googlesource.com/1182712 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#584682}
-
Michael Giuffrida authored
When the SafeSitesFilterBehavior policy is enabled, filter top-level HTTP[S] navigations using Google's SafeSearch API (porn classifier). The SafeSites check is skipped if the URL is blacklisted or whitelisted by policy. This check is added to the existing PolicyBlacklistNavigationThrottle instead of creating a standalone navigation throttle because it depends on the blacklist/whitelist check that's already there, and conceptually serves a similar purpose (determining if a URL should be blocked by policy). Bug: 819405 Change-Id: Ica243fdbf44b06a2fc4148fb68f47a11d9b79a6b Reviewed-on: https://chromium-review.googlesource.com/1119102 Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#584681}
-
iOS Autoroller authored
TBR=smut Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5089280a9cbc663298a85de1223a1bc0f6dfc1d9 Reviewed-on: https://chromium-review.googlesource.com/1182964 Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#584680}
-
Ryan Tseng authored
Bug: 875708 Change-Id: I057668ca809bcd9644c778690997a2ceed11ae8b Reviewed-on: https://chromium-review.googlesource.com/1183021Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#584679}
-
Michael Lippautz authored
The backing table should only be registered when processing the HashTable as otherwise the backing might be black but its fields might not be processed if it gets dropped till the final atomic pause. The registration will still be early enough to announce the slot to compaction. Bug: chromium:875555 Change-Id: Iad97df11f79d95524839fd0377585bc68b2442ea Reviewed-on: https://chromium-review.googlesource.com/1181130Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Keishi Hattori <keishi@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#584678}
-
Raymes Khoury authored
This flag has been enabled by default for several milestones. Change-Id: I54ee103f18d6f377cdf45de58dcee812ddde303b Reviewed-on: https://chromium-review.googlesource.com/1182905Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#584677}
-
Darren Shen authored
The design specs says the virtual keyboard is at +2 elevation instead of +24. Bug: 873327 Change-Id: I2895f149f693c8d4be4e35dc56c9d684cc07bf41 Reviewed-on: https://chromium-review.googlesource.com/1183004Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#584676}
-
Gemene Narcis authored
The code is executed once per profile. As it was introduced 5 months ago, and acording to metric reported users don't need it anymore. It's a manual revert of https://crrev.com/c/951607/ Bug: 817754 Change-Id: Iab2c5dfdb9effb4e2347f174faebeb67f9dd6a3e Reviewed-on: https://chromium-review.googlesource.com/1179151Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Narcis Gemene <gemene@google.com> Cr-Commit-Position: refs/heads/master@{#584675}
-
Lei Zhang authored
Change-Id: I1c3ad2db29d6f5446a045990036f467054d735d8 Reviewed-on: https://chromium-review.googlesource.com/1179307 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584674}
-
Joshua Bell authored
The blink.mojom.LockManager registration is exposed via execution context parameterized binding (frames, dedicated/share/service workers); it does not need to be exposed at the service manager (renderer proces host) level. Change-Id: Idc033a65a9d5646310434d52756333daba68d23e Reviewed-on: https://chromium-review.googlesource.com/1181923 Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#584673}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 24c207be. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23111 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request NOAUTOREVERT=true TBR=foolip No-Export: true Change-Id: I8bcc04662e86ef53394bee5152738cc632affec4 Reviewed-on: https://chromium-review.googlesource.com/1182952 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#584672}
-
Anand K. Mistry authored
BUG=None Change-Id: I897361040b6af091de7f3f8a5b790e08f81d65bd Reviewed-on: https://chromium-review.googlesource.com/1182719 Commit-Queue: Anand Mistry <amistry@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#584671}
-
Sam McNally authored
Currently drive-internals displays a path specific to the current implementation as the Drive mount path. When running with DriveFS enabled, this path is incorrect. Obtain the path from DriveIntegrationService instead so the correct path is displayed. Bug: 829703 Change-Id: Ie0f3a36c742c9476ce18c0cbede83d15ab670c53 Reviewed-on: https://chromium-review.googlesource.com/1182901 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#584670}
-
Kevin Marshall authored
* Fixed webrunner_unittests (tests were not being exercised, so the test code drifted from the impl) * Added webrunner_unittests, webrunner_browsertests to Fuchsia test bot list. Bug: 871594 Change-Id: I3f86f2f1d76534c51236a3dea43dc898d996b121 Reviewed-on: https://chromium-review.googlesource.com/1174868 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#584669}
-
Lei Zhang authored
- Avoid reading files on the UI thread. - Switch to new base::Value API. Change-Id: I5a4fae99d3624103538b62486552ecdb059e6ce9 Reviewed-on: https://chromium-review.googlesource.com/1179064 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#584668}
-
Yuki Yamada authored
Current implementation of DOMArrayBuffer::Wrap() returns a object that is created in current realm because v8::ArrayBuffer::New() does not receive |creation_context|, the relevant realm. (current realm is used here: https://cs.chromium.org/chromium/src/v8/src/heap/factory.cc?sq=package:chromium&g=0&l=3056) We have to create event in the relevant realm of event's target in accord with DOM standard: https://dom.spec.whatwg.org/#firing-events This CL set appropriate realm on creating wrapper. A test for this already exists: https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/external/wpt/websockets/multi-globals/message-received.html Change-Id: Ie225d9e45a0e78fcdbb7d86d04674531f9c745ac Reviewed-on: https://chromium-review.googlesource.com/1182913 Commit-Queue: Yuki Yamada <yukiy@google.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#584667}
-