GitLab

instance, prototype and interface.

There should be no behavioral change.

BUG=43394,516274

Review URL: https://codereview.chromium.org/1322533002

git-svn-id: svn://svn.chromium.org/blink/trunk@201910 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Subtract border and padding when we're calculating the breadth of the
columns in LayoutGrid::computeUsedBreadthOfSpecifiedLength().

Added test to check the behavior for both columns and rows.

BUG=529203
TEST=fast/css-grid-layout/grid-percent-track-margin-border-padding.html

Review URL: https://codereview.chromium.org/1321723008

git-svn-id: svn://svn.chromium.org/blink/trunk@201909 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We skip those access checks when dealing with Location, as V8Location has its own checks in place according to the Location's cross-origin policy (https://html.spec.whatwg.org/multipage/browsers.html#security-location).

BUG=455160

Review URL: https://codereview.chromium.org/1262353002

git-svn-id: svn://svn.chromium.org/blink/trunk@201908 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=oilpan-reviews,yosin
BUG=513568
NOTRY=true

Review URL: https://codereview.chromium.org/1303993005

git-svn-id: svn://svn.chromium.org/blink/trunk@201907 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a partial revert of r201891

BUG=

Review URL: https://codereview.chromium.org/1315443010

git-svn-id: svn://svn.chromium.org/blink/trunk@201906 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Suppress timeout on scrollstate-after-http-equiv-refresh-fragment-identifier.html (patchset #1 id:1 of https://codereview.chromium.org/1326193002/ )

Reason for revert:
The timeout was fixed by https://codereview.chromium.org/1304383004

Original issue's description:
> Suppress timeout on scrollstate-after-http-equiv-refresh-fragment-identifier.html
> 
> This patch suppresses a timeout on [1] likely due to [2]. See:
> http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fnavigation%2Fscrollstate-after-http-equiv-refresh-fragment-identifier.html&testType=layout-tests
> 
> [1] http/tests/navigation/scrollstate-after-http-equiv-refresh-fragment-identifier.html
> [2] https://src.chromium.org/viewvc/blink?view=rev&revision=201780
> 
> NOTRY=true
> BUG=528352
> TBR=alexclarke
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201810

TBR=alexclarke@google.com,pdr@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=528352

Review URL: https://codereview.chromium.org/1324403002

git-svn-id: svn://svn.chromium.org/blink/trunk@201905 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces composed tree version of |isFirstPositionAfterTable()|
by templatizing original |isFirstPositionAfterTable()| to work both DOM tree
position and composed tree position version for introducing composed tree
version of |VisibleSelection| class.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1309963003

git-svn-id: svn://svn.chromium.org/blink/trunk@201904 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://codereview.chromium.org/393823003 added the loop for the purposes
of repeatedly polling the cross-thread-usable free page pool.
As we now take the first page & don't add that to the pool,
the loop looks redundant.

BUG=

Review URL: https://codereview.chromium.org/1319163003

git-svn-id: svn://svn.chromium.org/blink/trunk@201903 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We'll need to access DisplayItemList::newDisplayItems() to update
cacheable flag of BeginSubsequence display items for
https://codereview.chromium.org/1327563003/.

Update layout tests and make some cleanups.

Review URL: https://codereview.chromium.org/1323243011

git-svn-id: svn://svn.chromium.org/blink/trunk@201902 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- Fix function names.
- Use const references as possible.
- Use range-based |for|.

This CL has no behavior changes.

BUG=528840

Review URL: https://codereview.chromium.org/1305063008

git-svn-id: svn://svn.chromium.org/blink/trunk@201901 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These methods are unused, and confusing. Let's remove them.

BUG=494880
R=jochen@chromium.org

Review URL: https://codereview.chromium.org/1321683009

git-svn-id: svn://svn.chromium.org/blink/trunk@201900 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Also, remove FormDataList::setData and setBlob.  This simplifies the code.
This CL has no behavior changes.

BUG=528840

Review URL: https://codereview.chromium.org/1320463010

git-svn-id: svn://svn.chromium.org/blink/trunk@201898 bbb929c8-8fbe-4397-9dbb-9b2b20218538

testharnessreport: Hide elements in tests by removing them from the document tree, instead of visibility:hidden.

This fixes the flakiness of web-platform-tests/webrtc/datachannel-
emptystring.html.

[1] made the test flaky because:
 - It added a chance to invoke onSendChannelOpen()
 - It prints some lines into <div id=msg>.
 - Text dump of visibility:hidden doesn't remove EOLs represented by
   <br>s.

This CL resolves this issue by removing elements completely by
body.textContent = ''.  Setting display:none instead of visibility:hidden
also works, but body.textContent = '' is much simpler.

[1] https://src.chromium.org/viewvc/blink?revision=201628&view=revision
BUG=528120

Review URL: https://codereview.chromium.org/1332523002

git-svn-id: svn://svn.chromium.org/blink/trunk@201897 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces composed tree version of
|firstEditableVisiblePositionAfterPositionInRoot()| for introducing composed
tree version of |VisibleSelection| class.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1311543006

git-svn-id: svn://svn.chromium.org/blink/trunk@201896 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As per the spec
https://html.spec.whatwg.org/multipage/forms.html#input-type-attr-summary
input types date, time, month, week, datetime-local, file, image, reset etc
should ignore placeholder attribute and in-turn should not affect placeholder-shown state.
Adding testcases for the same.

BUG=451120

Review URL: https://codereview.chromium.org/1332543002

git-svn-id: svn://svn.chromium.org/blink/trunk@201895 bbb929c8-8fbe-4397-9dbb-9b2b20218538

WebSearchableFormData.cpp created FormDataList instances.  However DOMFormData,
which is a subclass of FormDataList, is also acceptable, and we can remove
FormDataList factory.

This CL has no behavior changes.

BUG=528840

Review URL: https://codereview.chromium.org/1323023005

git-svn-id: svn://svn.chromium.org/blink/trunk@201894 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This test flakes consistently on the bots:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#showExpectations=true&tests=inspector%2Fsources%2Fdebugger-breakpoints%2Fdebugger-reload-breakpoints-with-source-maps.html

TBR=yurys@chromium.org
BUG=529123

Review URL: https://codereview.chromium.org/1308663006

git-svn-id: svn://svn.chromium.org/blink/trunk@201893 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently we run into an infinite loop when we hit the limit of the number
of mmapped regions OS can support. It is better to have a RELEASE_ASSERT
about it.

BUG=

Review URL: https://codereview.chromium.org/1320493006

git-svn-id: svn://svn.chromium.org/blink/trunk@201892 bbb929c8-8fbe-4397-9dbb-9b2b20218538

All the memory stats should be displayed in memory-infra.
However, some memory stats are too heavy to profile in production builds.
We can use the DETAILED_MEMORY_INFRA flag for them.

BTW, GC_PROFILING flag will be removed soon. All the information in the GC profiler
has been migrated to memory-infra.

BUG=

Review URL: https://codereview.chromium.org/1302183010

git-svn-id: svn://svn.chromium.org/blink/trunk@201891 bbb929c8-8fbe-4397-9dbb-9b2b20218538

We're now hitting a bunch of out-of-virtual-address-spaces in various benchmarks
(e.g., tiny-innerHTML-setter.html, PseudoClassSelectors.html etc) on oilpan Linux builds.

The reason is that a GC is never scheduled during the benchmark because the current
GC heuristic is improper. In short, we're hitting a scenario like this:

- allocatedObjectSize = 3 GB
- markedObjectSizeAtLastCompleteSweep = 5 MB
- partitionAlloc = 1 GB

This doesn't hit the GC condition because (3 GB + 5 MB + 1 GB) / (5 MB + 1 GB)
is not large enough.

(Note: Accurately speaking, the esimated size becomes smaller than (5 MB + 1 GB)
as the number of collected persistent handles increases, but in those benchmarks
persistent handles are not collected so aggressively.)

This is clearly insane and we should have a way to trigger a GC
if the allocatedObjectSize is X% larger than the markedObjectSizeAtLastCompleteSweep.

With that motivation, this CL changes the GC condition as follows:

- Trigger a GC if a growing rate of PartitionAlloc _or_ Oilpan's heap is larger than X%.

BUG=474470

Review URL: https://codereview.chromium.org/1325783007

git-svn-id: svn://svn.chromium.org/blink/trunk@201890 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=522791

Review URL: https://codereview.chromium.org/1305903007

git-svn-id: svn://svn.chromium.org/blink/trunk@201889 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Almost all validations in texImage2DBase() and texSubImage2DBase() have been done in 
their callers. These validations are executed twice. It is not necessary. For example, 
validateTexFuncParameters() is not very cheap. it is called in texImage2DBase(). This 
function is also called by validateTexFunc(). But all variants of texImage2D() calls 
both validateTexFunc() and texImage2DBase(). 

No WebGL 1.0 conformance test regression with this change.

BUG=528180

Review URL: https://codereview.chromium.org/1310003006

git-svn-id: svn://svn.chromium.org/blink/trunk@201886 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch enables additive keyframes in Web Animations element.animate().
"composite: 'add'" keyframe properties and neutral keyframes are now
enabled in experimental only.

This patch removes tests that assert we throw errors when additive
or neutral keyframes are used in element.animate().
The following existing tests ensure that stable behaviour has not changed:
virtual/stable/web-animations-api/additive-animations-unsupported.html
virtual/stable/web-animations-api/partial-keyframes-unsupported.html


BUG=437696

Review URL: https://codereview.chromium.org/1326443003

git-svn-id: svn://svn.chromium.org/blink/trunk@201885 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Support for CSSOM CSSNamespaceRule interface
Spec:http://drafts.csswg.org/cssom/#the-cssnamespacerule-interface
Changes include
1) Exposing CSSNamespaceRule interface
2) Reflecting namespace rules in stylesheet rule list

BUG=389549

Review URL: https://codereview.chromium.org/1321943002

git-svn-id: svn://svn.chromium.org/blink/trunk@201884 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch marks the SPV2 version of [1] as timing out.

[1] non-self-painting-layer-overrides-visibility.html

BUG=529100
TBR=wangxianzhu

Review URL: https://codereview.chromium.org/1314983005

git-svn-id: svn://svn.chromium.org/blink/trunk@201883 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces composed tree version of |characterAfter()|
by templatizing original |characterAfter()| to work both DOM tree
position and composed tree position version for introducing composed tree
version of |VisibleSelection| class.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1328113005

git-svn-id: svn://svn.chromium.org/blink/trunk@201882 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch adds a layout test to ensure that the 'color' property works as
expected when used with `all:unset` or `all:inherit`.

BUG=420781

Review URL: https://codereview.chromium.org/1330573003

git-svn-id: svn://svn.chromium.org/blink/trunk@201881 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The Win10 bot doesn't have baselines for these tests.

BUG=524134
TBR=wangxianzhu

Review URL: https://codereview.chromium.org/1318523010

git-svn-id: svn://svn.chromium.org/blink/trunk@201880 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=oilpan-reviews,yosin
BUG=513568
NOTRY=true

Review URL: https://codereview.chromium.org/1323023004

git-svn-id: svn://svn.chromium.org/blink/trunk@201879 bbb929c8-8fbe-4397-9dbb-9b2b20218538

While adding preconnect, we added a new API call that public that was destined to replace the previous one. This CL deletes calls to the previous API call.

BUG=

Review URL: https://codereview.chromium.org/1321193004

git-svn-id: svn://svn.chromium.org/blink/trunk@201878 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This fixes a bug introduced in https://codereview.chromium.org/1305933007
which replaced a call to startOneShot that takes seconds with a call to
postDelayedTask that takes milliseconds

BUG=497761, 510398, 528666
R=alexclarke@chromium.org
TBR=haraken@chromium.org

Review URL: https://codereview.chromium.org/1304383004

git-svn-id: svn://svn.chromium.org/blink/trunk@201877 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts commit bb5572c1de7405160a32b80c6224477b13eaac14.

Conflicts:
	Source/core/css/resolver/StyleResolver.h

TBR=kochi@chromium.org
BUG=487125

Review URL: https://codereview.chromium.org/1332493002

git-svn-id: svn://svn.chromium.org/blink/trunk@201875 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Simplify parseShadowValue by getting rid of ShadowParseContext.

BUG=404023

Review URL: https://codereview.chromium.org/1318093002

git-svn-id: svn://svn.chromium.org/blink/trunk@201874 bbb929c8-8fbe-4397-9dbb-9b2b20218538

> Reland of moved unused CascadeOrder. (patchset #1 id:1 of https://codereview.chromium.org/1306693007/ )
> 
> Reason for revert:
> I don't think this contributes any of "too many opened files".
> (as is commented bay jianli
> https://code.google.com/p/chromium/issues/detail?id=524248#c7 )
> 
> Will revert and reland the original patch.
> 
> 
> 
> Original issue's description:
> > Revert of Removed unused CascadeOrder. (patchset #1 id:1 of https://codereview.chromium.org/1291873005/ )
> > 
> > Reason for revert:
> > Speculative revert for causing "Too many opened files in the system".
> > 
> > https://code.google.com/p/chromium/issues/detail?id=523598
> > 
> > 
> > Original issue's description:
> > > Removed unused CascadeOrder.
> > > 
> > > CascadeOrder is always ignoreCascadeOrder after [1] and can be removed.
> > > 
> > > [1] https://codereview.chromium.org/1298173004
> > > 
> > > BUG=487125
> > > 
> > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201019
> > 
> > TBR=kochi@chromium.org,rune@opera.com
> > NOPRESUBMIT=true
> > NOTREECHECKS=true
> > NOTRY=true
> > BUG=487125
> > 
> > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201082
> 
> TBR=rune@opera.com,jianli@chromium.org
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=487125
> 
> Review URL: https://codereview.chromium.org/1313713005

TBR=kochi@chromium.org

Review URL: https://codereview.chromium.org/1331573002

git-svn-id: svn://svn.chromium.org/blink/trunk@201871 bbb929c8-8fbe-4397-9dbb-9b2b20218538

'static const' initialization in functions is considered as
thread-unsafe (data race).  Removes 'static const' initialization, and
uses simple 'const' initialization instead.

Note: 'static' keyword in the top-level 'static const' initialization
has no meaning.  'const' implies file-scope, so no need to explicitly
write 'static' in that case.

BUG=526963,526959

Review URL: https://codereview.chromium.org/1324643005

git-svn-id: svn://svn.chromium.org/blink/trunk@201870 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Oilpan: Remove raw pointer to DescendantInvalidationSet from StyleInvalidator::RecursionData (patchset #4 id:60001 of https://codereview.chromium.org/1225233005/ )

Reason for revert:
blink_perf.css regression
https://code.google.com/p/chromium/issues/detail?id=513378#makechanges

Original issue's description:
> Oilpan: Remove raw pointer to DescendantInvalidationSet from StyleInvalidator::RecursionData
> 
> BUG=509911
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199288
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=199294

TBR=haraken@chromium.org,yutak@chromium.org,oilpan-reviews@chromium.org,sigbjornf@opera.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=509911

Review URL: https://codereview.chromium.org/1330763002

git-svn-id: svn://svn.chromium.org/blink/trunk@201869 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces composed tree version of |inSameLine()| for introducing
composed tree version of |VisibleSelection| class.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1310913004

git-svn-id: svn://svn.chromium.org/blink/trunk@201868 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Only block containers that don't establish new formatting contexts are
allowed to ignore (and thus potentially overlap with) floats.

This obviously also applies inside multicol, but we had a check that actively
prevented that. This was some residue from CSS regions support (shared
implementation with multicol), which had a much more sophisticated positioning
implementation, which we've removed ages ago.

BUG=528179
R=jchaffraix@chromium.org

Review URL: https://codereview.chromium.org/1325323002

git-svn-id: svn://svn.chromium.org/blink/trunk@201867 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Before laying out, we try to estimate and set the logical top of the child, but
it may turn out after one layout pass that the estimate was wrong, due to
margin collapsing, float clearance or pagination.

So sometimes we need to reposition and relayout once or even twice inside
layoutBlockChild(). This was done with slightly poorly duplicated code.
Refactor into positionAndLayoutOnceIfNeeded() (and
markDescendantsWithFloatsForLayoutIfNeeded()). One instance of this duplicated
code used to sit in adjustBlockChildForPagination(). Moved it into
layoutBlockChild(), to make it easier to understand what's going on (and to
give adjustBlockChildForPagination() one less thing to worry about - one
parameter removed). Renamed |result| to |newLogicalTop| in
adjustBlockChildForPagination(), and |logicalTopAfterClear| to |newLogicalTop|
in layoutBlockChild().

No behavioral changes were actually intended, but when unifying
almost-duplicated code, some changes are inevitable. Added some tests for
something that now works, and used to fail. In the subsequent layout passes we
forgot to check if the new position changed how we were affected by floats.

R=jchaffraix@chromium.org,leviw@chromium.org

Review URL: https://codereview.chromium.org/1315353005

git-svn-id: svn://svn.chromium.org/blink/trunk@201866 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch introduces composed tree version of |absoluteCaretBoundsOf()|
by templatizing original |absoluteCaretBoundsOf()| to work both DOM tree
position and composed tree position version for introducing composed tree
version of |VisibleSelection| class.

This patch is a preparation of making selection to handle granularity for web
component, http://crrev.com/1277863002

BUG=513568
TEST=n/a; no behavior changes

Review URL: https://codereview.chromium.org/1330743002

git-svn-id: svn://svn.chromium.org/blink/trunk@201865 bbb929c8-8fbe-4397-9dbb-9b2b20218538