- 29 Nov, 2018 40 commits
-
-
Mario Sanchez Prada authored
Implement the following methods at the same time, so that we can also provide decent unit tests that would require of all of them to make sure functionality works as expected: * LegacyStartSigninWithRefreshTokenForPrimaryAccount() * LegacyCompletePendingPrimaryAccountSignin() * LegacyIsPrimaryAccountAuthInProgress() * LegacyPrimaryAccountForAuthInProgress() Also, PrimaryAccountMutatorTests unit tests for each of those methods as part of this CL, based on those from SigninManagerTest, including a new test for ClearPrimaryAccount (i.e. ClearPrimaryAccount_NotSignedIn) to check that it reports FALSE when there is neither a primary account nor an authentication process ongoing (now we can finally implement that). Bug: 906058, 906059, 906063, 906064 Change-Id: I2164c867f35020806225da4e69659364c3429a92 Reviewed-on: https://chromium-review.googlesource.com/c/1342559 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#612159}
-
Vadym Doroshenko authored
Bug: 831123 Change-Id: I95c30a908da22585f632ba63d90cf60244287df6 Reviewed-on: https://chromium-review.googlesource.com/c/1354005 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#612158}
-
Jérôme Lebel authored
kUseMultiloginEndpoint can only be enabled if kWKHTTPSystemCookieStore is enabled. CookieManager::SetCanonicalCookie() fails to store the cookies. Bug: 902584, 892130 Change-Id: If3ba635f031e7de830c87b7a97fd262a9e6e2cee Reviewed-on: https://chromium-review.googlesource.com/c/1352324 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#612157}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/ac71e34d4ad1..813bfbd06112 git log ac71e34d4ad1..813bfbd06112 --date=short --no-merges --format='%ad %ae %s' 2018-11-29 hao.x.li@intel.com Collect device information on Metal Created with: gclient setdep -r src/third_party/dawn@813bfbd06112 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I80c29ac9dca9a474ee22a8f9917dfd2fef3f1cd2 Reviewed-on: https://chromium-review.googlesource.com/c/1354981Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612156}
-
Mike Reed authored
TBR=vmpstr Bug: skia:2664 Change-Id: Ie4d397f2cc3f997abed9c4614a96333f5956c805 Reviewed-on: https://chromium-review.googlesource.com/c/1351819 Commit-Queue: Mike Reed <reed@google.com> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#612155}
-
Greg Thompson authored
BUG=856169 TBR=grt@chromium.org Change-Id: I2e9cf461d6003b2e1a85129ad52b8d2157685b15 Reviewed-on: https://chromium-review.googlesource.com/c/1354449Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#612154}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/275e8750e3d2..e6305f38b584 git log 275e8750e3d2..e6305f38b584 --date=short --no-merges --format='%ad %ae %s' 2018-11-29 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 2c0d6a9404cd..7310da33bc7a (1 commits) Created with: gclient setdep -r src/third_party/skia@e6305f38b584 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: I8cfabd4740f7238ceb47192a9690899b3cd883a5 Reviewed-on: https://chromium-review.googlesource.com/c/1354980Reviewed-by:
-
Arthur Sonzogni authored
This is similar to: * https://chromium-review.googlesource.com/c/chromium/src/+/1323109 * https://chromium-review.googlesource.com/c/chromium/src/+/1329163 * https://chromium-review.googlesource.com/c/chromium/src/+/1323070 * https://chromium-review.googlesource.com/c/chromium/src/+/1323092 On request success, it makes the MimeSniffingURLLoader to always send a response's body datapipe, even when it is empty. It also adds a DCHECK to ensure the |source_url_loader| is also behaving the same way. Bug: 831155,826868 Change-Id: I468a24c31142cb0a8d646cd09928f7b03680d779 Reviewed-on: https://chromium-review.googlesource.com/c/1350874Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#612152}
-
Adam Rice authored
Allow WritableStream objects to be transferred with postMessage(). Add support for serialization and deserialization of WritableStreams. WritableStreams share the stream_ports array with ReadableStreams, using indexes starting after the last ReadableStream in the array. As with ReadableStreams, the functionality is hidden behind the TransferableStreams blink feature, which much be enabled explicitly for it to work. This CL only contains rudimentary tests. In-depth layout tests will be added later. BUG=894838 Change-Id: I237f740e4750faa5976481baa161c85bacd51687 Reviewed-on: https://chromium-review.googlesource.com/c/1353034Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#612151}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7920c70b. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: I57bb9d3b5db64b6914160a8c9d81d1fe35e04936 Reviewed-on: https://chromium-review.googlesource.com/c/1354496 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612150}
-
Noel Gordon authored
util.bytesToString fails with an exception that prevents the file list from drawing for Hindi language users. The exception is due to invalid translation console translations of the SIZE_KB, SIZE_MB strings [1]. Mitigation: process these loadTimeData values before use. Convert them to valid values (prevents the JS exception) and do this once only. [1] The $1 portion of these message strings should not be touched, but translation console is effectively converting them to $one in Hindi. Bug: 908767 Change-Id: Ib5d741e501c3cf00e232b59366050778d732d906 Reviewed-on: https://chromium-review.googlesource.com/c/1353044 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Stuart Langley <slangley@chromium.org> Cr-Commit-Position: refs/heads/master@{#612149}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b313ee575f99..e5027d7b45f8 Created with: gclient setdep -r src-internal@e5027d7b45f8 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I3be0a9ee1a12d27ef167f9447724992dd43da4bb Reviewed-on: https://chromium-review.googlesource.com/c/1354637Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#612148}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/7310da33bc7a..5f01324fb627 git log 7310da33bc7a..5f01324fb627 --date=short --no-merges --format='%ad %ae %s' 2018-11-29 syoussefi@chromium.org Vulkan: Allow descriptor pool to allocate different types Created with: gclient setdep -r src/third_party/angle@5f01324fb627 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: I16d48555a73677772b397b33885274eeb65426af Reviewed-on: https://chromium-review.googlesource.com/c/1354979Reviewed-by:
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: I0ff6ff3fc2c4e01b1148d92ae87d0a031074c039 Reviewed-on: https://chromium-review.googlesource.com/c/1353882Reviewed-by:
-
Greg Thompson authored
This reverts commit 60efce52. Reason for revert: Lots of tests are failing with a segfault in SideSwipeController updateNavigationEdgeSwipeForWebState; e.g., https://chromium-swarm.appspot.com/task?id=4176d009da672b10&refresh=10&show_raw=1 Original change's description: > [ios] Enable WebKit based side swipe with Chrome side swipe. > > Enables WebKit based side swipe, and only enables Chrome side swipe when the > page swiped page is to or from an NTP. > > Change-Id: I892f7074252ee04b2d0b337ebd744f3ba9388e27 > Reviewed-on: https://chromium-review.googlesource.com/c/1350192 > Commit-Queue: Justin Cohen <justincohen@chromium.org> > Reviewed-by: Eugene But <eugenebut@chromium.org> > Reviewed-by: Danyao Wang <danyao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#612042} TBR=justincohen@chromium.org,eugenebut@chromium.org,danyao@chromium.org Change-Id: I00da0d289307497cdc2f49ab4b6336316d345259 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1355039Reviewed-by:
-
Sam McNally authored
Bug: 909056 Change-Id: I285bf68f024899c169b87129f988b7a5f82c1cd3 Reviewed-on: https://chromium-review.googlesource.com/c/1354749 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#612144}
-
Eric Seckler authored
The ETW tracing agent isn't currently used widely. In light of the move towards perfetto, we've decided to remove it until we can replace it with a new data source (which would provide more selective information about the OS's scheduling behavior, e.g. chrome's CPU time slices). Developers can still export chrome's trace events into ETW for the time being. Bug: 900603 Change-Id: Ie482f4377359f54e166636af65a94dac69767b45 Reviewed-on: https://chromium-review.googlesource.com/c/1341989 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#612143}
-
Sam McNally authored
Convert: - open_image_files.js - restore_geometry.js - restore_prefs.js Bug: 909056 Change-Id: Idc4c7636b0192878d62aa455ef096a032afed610 Reviewed-on: https://chromium-review.googlesource.com/c/1353067 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#612142}
-
Sami Kyostila authored
Replace explicit thread usage in ObserverListThreadSafeTest with a number of tasks that run on dedicated worker pool threads. We also replace an instance of MessageLoop in WeakNsObjectTest with a scoped task environment. Bug: 891670 Change-Id: I3b65f9b3ed54a42f40f38e98ef9b890d21003368 Reviewed-on: https://chromium-review.googlesource.com/c/1350914 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#612141}
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: Ic37cec536c71197401e3fcf479b2b810ed9fff39 Reviewed-on: https://chromium-review.googlesource.com/c/1352323Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#612140}
-
Sam McNally authored
Bug: 909056 Change-Id: I0ed854a15d1ba9a2bfdda3be71430a34b808bfc8 Reviewed-on: https://chromium-review.googlesource.com/c/1351978Reviewed-by:
-
Simon Que authored
Bug: 855319 Change-Id: I55e40c2162aff9ad2f127f4728cf8fea315d02e9 Reviewed-on: https://chromium-review.googlesource.com/c/1351324Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Simon Que <sque@chromium.org> Cr-Commit-Position: refs/heads/master@{#612138}
-
Arthur Sonzogni authored
Instead of creating the response's body data pipe during the first call to OnWillRead(), it is now done in OnWillStart(). The data pipe consumer handle is available in OnResponseStarted(). It allows the MojoAsyncResourceHandler to call: * URLLoader::OnReceiveResponse(response_headers) * URLLoader::OnStartLoadingResponseBody(response_body) at the same time. The goal is to guarantee the response's body is always sent, even if it doesn't contains any data. Bug: 831155, 826868 Change-Id: I85d84d05ad3fd362d96394834e14297d550f5f13 Reviewed-on: https://chromium-review.googlesource.com/c/1352254Reviewed-by:
-
Roman Sorokin authored
BUG=chromium:907504 TEST=manual Change-Id: I8b9bad1f16fe539b7e25134b5fdc0d7dd63094a8 Reviewed-on: https://chromium-review.googlesource.com/c/1349323Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#612136}
-
Lukasz Suder authored
Initial screen is shown without the initialization of UIDelegate, that allows postoponing the init of native side. Bug: 806868 Change-Id: I047ec5bf12d454ce7a51b31ad68c758baf10869b Reviewed-on: https://chromium-review.googlesource.com/c/1352163 Commit-Queue: Lukasz Suder <lsuder@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#612135}
-
Vadym Doroshenko authored
The server might make mistake and say that <input type=text is password field. This CL teaches the new parser to ignore such predictions. Bug: 908869, 831123 Change-Id: Ib4cfa715e0746b828be3c2356e8ae5bc60717a69 Reviewed-on: https://chromium-review.googlesource.com/c/1354000 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
-
Daniel Vogelheim authored
Bug: 751996, 901477 Change-Id: Ia150dc83158bae7db8160bddf0377328ff1b2b11 Reviewed-on: https://chromium-review.googlesource.com/c/1344131Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#612133}
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: If6b2d8c4b52f742183b5673cf0ed085b82346133 Reviewed-on: https://chromium-review.googlesource.com/c/1352417Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#612132}
-
Jérôme Lebel authored
Removing "Activity and Interactions" settings. This option is not available anymore after changes on Unity project. Bug: 906727,906680 Change-Id: I4401bbf80d8fac257db0e6ee18cc7a6670e71f44 Reviewed-on: https://chromium-review.googlesource.com/c/1343078 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Tatiana Gornak <melandory@chromium.org> Cr-Commit-Position: refs/heads/master@{#612131}
-
Javier Ernesto Flores Robles authored
This CL only moves the logic from the coordinator to the mediator. It shouldn't change any behavior. And it only moves logic related to the manual fill view controller. Bug: 845472 Change-Id: Id17a14903c50fa63a4a643025ef235256bc2474e Reviewed-on: https://chromium-review.googlesource.com/c/1352185Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#612130}
-
Patrik Höglund authored
Tbr: jbudorick@chromium.org Bug: 877018 Change-Id: Iefdaaffb9a9e84eb57da37ada1688f8af11ac57a Reviewed-on: https://chromium-review.googlesource.com/c/1354001Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Patrik Höglund <phoglund@chromium.org> Cr-Commit-Position: refs/heads/master@{#612129}
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: I56a7b4a0232355696096ae733ecbebc9979ca3b3 Reviewed-on: https://chromium-review.googlesource.com/c/1353880Reviewed-by:
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: Iaf5b03e03f678986e2ac179eff58b780858cf21c Reviewed-on: https://chromium-review.googlesource.com/c/1352776Reviewed-by:
-
Carlos Caballero authored
MessageLoop will go away, eventually. BUG=891670 Change-Id: Ic4527ecbd1e1485a57fe5210db485a839d29f894 Reviewed-on: https://chromium-review.googlesource.com/c/1352757Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Carlos Caballero <carlscab@google.com> Cr-Commit-Position: refs/heads/master@{#612126}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7fda03cb0aab..b313ee575f99 Created with: gclient setdep -r src-internal@b313ee575f99 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Iec8652a38a3ac33551304b6aca09514ec52a7d05 Reviewed-on: https://chromium-review.googlesource.com/c/1354636Reviewed-by:
-
Yuta Kitamura authored
This CL rewrites #include lines of web_task_runner.h, which is now deprecated. Instead of web_task_runner.h, new include lines of post_cancellable_task.h and/or post_cross_thread_task.h are inserted, depending on what's used in each file. This CL only touches #include lines and nothing else. Bug: 826203 Change-Id: Ic69f1c44af50d2ad39cee4d8bc42d8b37cb9b528 Reviewed-on: https://chromium-review.googlesource.com/c/1351207 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#612124}
-
Jan Krcal authored
Previous metrics for wallet data sync were reported in quite different situations. This CL unifies the reporting conditions so that this is easily implementable for both USS and Directory: We newly report the diffs only when both the existing and the new data sets contain a PaymentsCustomerData entity. This boils down to situations when: - the user has synced before (thus excluding initial sync), - the user has a GPay account (diffs for other users are always empty), - we are not wiping the data (which is implemented in USS by storing an empty set). Bug: 908905 Change-Id: I38bc1c12e9407ddc08ff798f69f09ba85fd5848c Reviewed-on: https://chromium-review.googlesource.com/c/1352410Reviewed-by:
Florian Uunk <feuunk@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Florian Uunk <feuunk@chromium.org> Cr-Commit-Position: refs/heads/master@{#612123}
-
Alex Clarke authored
A reland of https://crrev.com/c/1324391 This is necessary because we want content::TestBrowserThreadBundle to own a BrowserUIThreadScheduler, but that also owns a ScopedTaskEnvironment and you can't have two SequenceManagers on the same thread. This patch allows ScopedTaskEnvironment to optionally work with an externally owned SequenceManager solving the problem. This implements https://docs.google.com/document/d/1y08C6JQ9Yta3EQXzwIqqIIKHq9500WV6CWFZzZfDx7I/edit?usp=drivesdk, We now have the ability to mock time on the UI thread. TBR=asvitkine@chromium.org,miu@chromium.org,gab@chromium.org,fdoray@chromium.org Bug: 863341, 891670, 708584 Change-Id: Ia4409b885deb9935e6e5b6d99f4598f164d350db Reviewed-on: https://chromium-review.googlesource.com/c/1354919Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#612122}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/0113b4085f5a..275e8750e3d2 git log 0113b4085f5a..275e8750e3d2 --date=short --no-merges --format='%ad %ae %s' 2018-11-29 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files 2018-11-29 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update go_deps asset Created with: gclient setdep -r src/third_party/skia@275e8750e3d2 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=borenet@chromium.org Change-Id: Ib9c02daa95f01c1aada3aa0ce2ac0b22b2c99294 Reviewed-on: https://chromium-review.googlesource.com/c/1354634Reviewed-by:
-
Colin Blundell authored
When SyncAuthManager receives an OnRefreshTokenUpdatedForAccount() observer callback from IdentityManager, it queries the value of the |is_valid| parameter. However, we are going to be removing that parameter altogether as it is confusing for the common case where consumers *shouldn't* check it. This CL changes SyncAuthManager to compute the validity internally by querying the error state of the refresh token via IdentityManager. There should be no functional change. The logic of the computation of whether the refresh token is valid is taken from the internal computation of the |is_valid| parameter that IdentityManager does. As a followup, we can consider re-hiding that logic inside IdentityManager via a helper method to reduce fragility. Bug: 908412 Change-Id: I4842652dc63bea7169e4e915b5f4382e9291a0ea Reviewed-on: https://chromium-review.googlesource.com/c/1350888 Commit-Queue: Marc Treib <treib@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#612120}
-
