GitLab

Revert of Disable excluding of tested apk's code in test apks (https://codereview.chromium.org/331683005/)

Reason for revert:
We are hitting the issue in https://code.google.com/p/chromium/issues/detail?id=272790 again. So we will have to reenable this fix.

The failing tests are being handled in separate CLs I believe.

Original issue's description:
> The new way of building test APKs loses some
> necessary classes from them, hence causing them to fail with
> "Class not found" errors. 
> 
> Disable this until we have a fix.
> 
> BUG=384537,272790
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=277756

TBR=aberent@chromium.org,cjhopman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=384537,272790

Review URL: https://codereview.chromium.org/341973002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278118 0039d316-1c4b-4281-b951-d872f2087c98

Rename FLAGS_enable_quic_connection_flow_control to FLAGS_enable_quic_connection_flow_control_2, and set it to true.

Merge internal change: 69327440

BUG=

Review URL: https://codereview.chromium.org/324283004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278117 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278116 0039d316-1c4b-4281-b951-d872f2087c98

TBR=jkummerow@chromium.org

Review URL: https://codereview.chromium.org/343583003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278115 0039d316-1c4b-4281-b951-d872f2087c98

Pulls MockNonBlockingTypeProcessor and SimpleMockServer classes out of
the NonBlockingTypeProcessorCore's test harness.

These two new mock classes are currently used in only one place, though
it's probable that they'll be reused elsewhere sooner or later.  Even if
no code is reused, this change is worthwhile because it leads to better
separation of responsibilities and improved documentation.

This is one of serveral follow-ups to the commits that introduced
NonBlockingTypeProcessor and NonBlockingTypeProcessorCore.

BUG=351005

Review URL: https://codereview.chromium.org/330523002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278114 0039d316-1c4b-4281-b951-d872f2087c98

NOTRY=true

Review URL: https://codereview.chromium.org/343473006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278113 0039d316-1c4b-4281-b951-d872f2087c98

The test has passed accidentaly with the new implementation and now fails
with the bufferedAmount change.
The root causes of the failure is not the change and it takes some time to
fix. Hence this CL tentatively disables the test. It should be re-enabled
in the near future.

BUG=159563
R=tyoshino@chromium.org

Review URL: https://codereview.chromium.org/340733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278112 0039d316-1c4b-4281-b951-d872f2087c98

Ensure that chrome suggestions are never served if the user doesn't sync his history on a given machine, even if he syncs it on other machines.

BUG=384913

Review URL: https://codereview.chromium.org/336413006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278111 0039d316-1c4b-4281-b951-d872f2087c98

The bug might have been fixed. Try to remove the suppression to see
result. Will revert if the error still occurs.

NOTRY=true
TBR=rsesek,zhaoqin
BUG=382789

Review URL: https://codereview.chromium.org/339373002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278110 0039d316-1c4b-4281-b951-d872f2087c98

Currently network conditions are applied browser-wide.

To restrict conditions to one tab requests are marked with specific
headers.

Those specific headers are removed before sending headers to network.

BUG=245436

Review URL: https://codereview.chromium.org/342473004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278109 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278108 0039d316-1c4b-4281-b951-d872f2087c98

R=jochen@chromium.org
TBR=jochen

Review URL: https://codereview.chromium.org/338413003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278107 0039d316-1c4b-4281-b951-d872f2087c98

Changes to the visible state of the shelf causes the WorkspaceLayoutManager to change the size of its children. This includes changing the size of the backdrop. In order for the backdrop to cover the entire workspace it needs to be notified of changes to the available area. Such as when the shelf causes the inset regions to update.

TEST=WorkspaceLayoutManagerBackdropTest.ShelfVisibilityChangesBounds
BUG=383383

Review URL: https://codereview.chromium.org/337193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278106 0039d316-1c4b-4281-b951-d872f2087c98

Current packing preserves 4-byte alignment (in practice, 8-byte alignment,
because a whole number of R_ARM_RELATIVE relocations is removed).  However
this is insufficient for some NEON vector instructions.  For example:

  18b0c:       f42c026f        vld1.16 {d0-d3}, [ip :128]

requires a 16-byte alignment, and fails with SIGBUS if not aligned.

The NDK toolchain aligns .text and .data to 256 bytes.  Retain this by
padding the non-packed (non-R_ARM_RELATIVE) relocations with sufficient
R_ARM_NONE entries so that 256 byte alignment is preserved.  Update
test data so that enough R_ARM_RELATIVE entries are present for packing
to reduce file size.

BUG=385553

Review URL: https://codereview.chromium.org/341483002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278105 0039d316-1c4b-4281-b951-d872f2087c98

BUG=376691

Review URL: https://codereview.chromium.org/340053002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278104 0039d316-1c4b-4281-b951-d872f2087c98

TBR=bruening@chromium.org
BUG=NONE

Review URL: https://codereview.chromium.org/341883002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278103 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367896

Review URL: https://codereview.chromium.org/264303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278102 0039d316-1c4b-4281-b951-d872f2087c98

This is mechanical cleanup in preparation for a Label rewrite.
Use simple gfx::ShadowValues setter functions everywhere.
Remove a forbidden static FontList instance.

BUG=240037
TEST=No appearance changes for views text shadows.
R=sky@chromium.org

Review URL: https://codereview.chromium.org/343513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278101 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
NOTRY=true

Review URL: https://codereview.chromium.org/344443009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278100 0039d316-1c4b-4281-b951-d872f2087c98

This is replaced by NACL_IOC_HANDLEMESSAGE.

BUG=none
R=sbc@chromium.org

Review URL: https://codereview.chromium.org/334983007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278099 0039d316-1c4b-4281-b951-d872f2087c98

This patch adds end-to-end testing for the Battery Status API.
Also a small fix in battery_status_service to return default
values if battery_status_manager fails to start (e.g. no battery
or no implementation). That way the promise on the blink side
will resolve with default values as according to the specification.

BUG=122593, 360068

Review URL: https://codereview.chromium.org/334223003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278097 0039d316-1c4b-4281-b951-d872f2087c98

Code extracted from components/dom_distiller/core/dom_distiller_database.*

Slight API change: callers to UpdateEntries now have to pass a vector of (string, proto) as key and value, instead of just a vector of protos where key is derived.

Ran clang-format on the files I touched so you may see some diffs.

Note: Implementations are in proto_database_impl.h and fake_db.h for proper linking.

BUG=385747
TBR=jochen,dgrogan
TEST=DomDistiller*,ProtoDatabaseImplTest

Review URL: https://codereview.chromium.org/330833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278096 0039d316-1c4b-4281-b951-d872f2087c98

After the landing https://codereview.chromium.org/297683004,
enumerate_modules_model_win.cc doesn't need the command line
switch related headers anymore. So we can remove these.

BUG=350921

Review URL: https://codereview.chromium.org/338793002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278095 0039d316-1c4b-4281-b951-d872f2087c98

(And wait_flags_state.h -> handle_signals_state.h.)

Still to do: Java (WaitFlags -> HandleSignals).

R=sky@chromium.org

Review URL: https://codereview.chromium.org/339193005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278094 0039d316-1c4b-4281-b951-d872f2087c98

Split tap allows a user to click while in touch exploration mode by tapping a second finger anywhere on the screen.

*Added TOUCH_EXPL_SECOND_PRESS state and a InTouchExplSecondPress function in the controller
*Added tests for tap and tap hold events, and also tested the case where the user lifts the touch exploration finger first.

BUG= 385151
TEST = TouchExplorationTest.*

Review URL: https://codereview.chromium.org/333623003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278093 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278092 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=176408:176408&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/343633004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278091 0039d316-1c4b-4281-b951-d872f2087c98

With direct_dependent_settings, the flags fail to propagate to certain targets.

BUG=366570
R=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/340583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278090 0039d316-1c4b-4281-b951-d872f2087c98

ExtensionService::PromoteEphemeralApp() now clears the permission
escalation flag as well as enabling the app.

BUG=374018
TEST=browser_tests (EphemeralAppBrowserTest.*)

Review URL: https://codereview.chromium.org/345493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278089 0039d316-1c4b-4281-b951-d872f2087c98

Based on patch 324913004 by johnme@chromium.org who is on holiday now.

BUG=350378

Review URL: https://codereview.chromium.org/338363003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278087 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278086 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=176360:176407&mode=html
TBR=schenney@chromium.org,jamesr@chromium.org
BUG=

Review URL: https://codereview.chromium.org/347533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278085 0039d316-1c4b-4281-b951-d872f2087c98

Still to rename: MojoWaitFlagsState and WaitFlagsState (and
wait_flags_state.*).

Also, remove MOJO_WAIT_FLAG_EVERYTHING. People shouldn't use it (since
they'd get unexpected results if we added flags/signals). Tests can
still use ~MOJO_HANDLE_SIGNAL_NONE.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/336313007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278084 0039d316-1c4b-4281-b951-d872f2087c98

Created new StringMappingListPolicyHandler class to provide general
mapping between policy string lists and generic pref types (int lists,
string lists, etc).

BUG=none

Review URL: https://codereview.chromium.org/341723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278083 0039d316-1c4b-4281-b951-d872f2087c98

This patch fixes various problems in the bisect scripts that were
preventing their use for Chrome for Android. I have only tried these
using run-manual-bisect-test, and there could potentially be
further problems with bisect wrapper scripts.

Also fixes the --use-goma option to actually use Goma, rather than
simply increasing the number of threads.

BUG=none

Review URL: https://codereview.chromium.org/331593007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278082 0039d316-1c4b-4281-b951-d872f2087c98

As noted in https://codereview.chromium.org/10948035, this is not used by anyone in Chromium.

BUG=None
TBR=thakis@chromium.org

Review URL: https://codereview.chromium.org/339343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278081 0039d316-1c4b-4281-b951-d872f2087c98

Adds also a few additional checks.

BUG=385143

Review URL: https://codereview.chromium.org/336423004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278080 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None

Review URL: https://codereview.chromium.org/340033002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278079 0039d316-1c4b-4281-b951-d872f2087c98

BUG=380825
TEST=run the test

Review URL: https://codereview.chromium.org/341783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278078 0039d316-1c4b-4281-b951-d872f2087c98

In the compositor API example gcc 4.9 reports a possible
type narrowing when using fabs call. To fix this use fabsf instead.

BUG=385988
R=dmichael

Review URL: https://codereview.chromium.org/335383003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@278076 0039d316-1c4b-4281-b951-d872f2087c98