GitLab

* Factor out code that can be used for both chrome/app_shell version from athena/extensions/chrome
* Create AppsClient/AppsDelegate for app_shell version.
* Removed CreateAppsClient as it's no longer necessary.

AthenaNativeAppWindow needs more work in order to work properly on athena. I'll address them in separate bug/CLs.

BUG=410448,410448
TBR=ben@chromium.org

Note: This CL depends on https://codereview.chromium.org/576863003/

Review URL: https://codereview.chromium.org/563083003

Cr-Commit-Position: refs/heads/master@{#295583}

R=rjshade@chromium.org, rch@chromium.org, asvitkine@chromium.org, rvargas@chromium.org

Review URL: https://codereview.chromium.org/427313002

Cr-Commit-Position: refs/heads/master@{#295582}

Debug bots became flaky with the notification turned on (crash in the
V8 idle handler). Disabling by default.

NOTRY=True
TBR=zmo@chromium.org,jochen@chromium.org
BUG=414815

Review URL: https://codereview.chromium.org/586523002

Cr-Commit-Position: refs/heads/master@{#295581}

More specifically, add Cmd+A and Cmd+V for making entering the password less sucky.

BUG=394575
TEST=Start Chrome with --enable-new-profile-management. Sign in a profile,
and from the avatar bubble, click on "Lock. In the User Manager that
shows up, Chrome shortcuts like Cmd+N and Cmd+T shouldn't work, but in
the password field of the locked pod things like Cmd+A and Cmd+V should.

Review URL: https://codereview.chromium.org/553133002

Cr-Commit-Position: refs/heads/master@{#295580}

* Add skeleton client-side and service-side MediaRenderer pieces with basic plumbing and connections but no real logic.
* model a media::DemuxerStream in a mojom to clean up MediaRenderer interface and line-up with RendererImpl expectations.
* add DecoderConfig plumbing support
* add a basic unittest verifying things do actually hook up
* consolidate around 'media_mojo_' naming in media.gyp and add media_mojo target to build all this stuff.

BUG=410451

Review URL: https://codereview.chromium.org/551963004

Cr-Commit-Position: refs/heads/master@{#295579}

increase

BUG=408257

Review URL: https://codereview.chromium.org/510943003

Cr-Commit-Position: refs/heads/master@{#295578}

BUG=415742
TBR=danbeam@chromium.org

Review URL: https://codereview.chromium.org/582233002

Cr-Commit-Position: refs/heads/master@{#295577}

BUG=415705

Review URL: https://codereview.chromium.org/582143002

Cr-Commit-Position: refs/heads/master@{#295576}

The following supressions are no longer needed:
bug_101151
bug_101159
bug_101345
bug_101347
bug_101751
bug_101781

BUG=101151,101159,101345,101347,101751,101781
R=timurrrr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/562593004

Cr-Commit-Position: refs/heads/master@{#295575}

This is a partial revert of some of the logic that was
removed by http://crrev.com/262526, but updated with
new logic to only do it when there is a version change
and we didn't generate an initial stability log. Plus,
the list of prefs that are reset is trimmed to only
the ones that need to be (per my auditing of the code).

BUG=409117

Review URL: https://codereview.chromium.org/580093004

Cr-Commit-Position: refs/heads/master@{#295574}

- Don't show access Address Book prompt if user has any Autofill state.
- Eliminate flickering of the access Address Book prompt.

BUG=414359

Review URL: https://codereview.chromium.org/575283003

Cr-Commit-Position: refs/heads/master@{#295573}

Add a global on/off switch for content settings and expose a toggle on the Website Settings options page.

TBR=miguelg@chromium.org
BUG=372607

Review URL: https://codereview.chromium.org/542253003

Cr-Commit-Position: refs/heads/master@{#295572}

The following supressions are no longer needed:
bug_106183a
bug_106183b
bug_106183c
bug_106402
bug_106552

BUG=106183,106402,106552
TBR=groby@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/576033002

Cr-Commit-Position: refs/heads/master@{#295571}

The following supressions are no longer needed:
bug_100043
bug_100133
bug_100330
bug_100647
bug_100777
bug_100916

BUG=100043,100133,100330,100647,100777,100916
R=timurrrr@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/561883005

Cr-Commit-Position: refs/heads/master@{#295570}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/c3a905f..2dc4bc6

TBR=dpranke@chromium.org,apavlov@chromium.org

Review URL: https://codereview.chromium.org/579403002

Cr-Commit-Position: refs/heads/master@{#295569}

Revert of Third attempt to land change to remove NativeViewportService and (patchset #2 id:20001 of https://codereview.chromium.org/578353002/)

Reason for revert:
all these tests are timing out on Win7 Tests (dbg)(4):mojo_view_manager_unittests -
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(dbg)(4)/builds/28279

ViewManagerTest.CantAccessChildrenOfEmbeddedView
ViewManagerTest.SecondEmbedRoot_Service
ViewManagerTest.EmbedWithSameViewId2
ViewManagerTest.EmbedWithSameViewId
ViewManagerTest.ViewsRemovedWhenEmbedding
ViewManagerTest.CantGetViewTreeOfOtherRoots
ViewManagerTest.SetViewVisibilityNotifications
ViewManagerTest.CreateView
ViewManagerTest.ViewHierarchyChangedAddingKnownToUnknown
ViewManagerTest.GetViewTree
ViewManagerTest.ViewHierarchyChangedViews
ViewManagerTest.ReuseDeletedViewId
ViewManagerTest.AddViewWithNoChange
ViewManagerTest.ReorderView
ViewManagerTest.SetViewVisibility
ViewManagerTest.CantModifyChildrenOfEmbeddedView
ViewManagerTest.OnViewInput
ViewManagerTest.CantMoveViewsFromOtherRoot
ViewManagerTest.TwoClientsGetDifferentConnectionIds
ViewManagerTest.SetViewBounds

Original issue's description:
> Third attempt to land change to remove NativeViewportService and
> ViewManager from mojo_shell.
>
> Original cl was https://codereview.chromium.org/477923004/
>
> BUG=
> TBR=ben@chromium.org
>
> Committed: https://crrev.com/9b5afe9fda3e59c856cbfc43367c2719df676af0
> Cr-Commit-Position: refs/heads/master@{#295537}

TBR=davemoore@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=

Review URL: https://codereview.chromium.org/577403002

Cr-Commit-Position: refs/heads/master@{#295568}

Change #294679 was lost in #294932

BUG=None

Review URL: https://codereview.chromium.org/583753002

Cr-Commit-Position: refs/heads/master@{#295567}

The test is flaky.

BUG=415422

Review URL: https://codereview.chromium.org/586443002

Cr-Commit-Position: refs/heads/master@{#295566}

Review URL: https://codereview.chromium.org/578203003

Cr-Commit-Position: refs/heads/master@{#295565}

http://llvm.org/PR20354 was fixed and rolled into Chromium in
the latest Clang roll.

BUG=none

Review URL: https://codereview.chromium.org/582583003

Cr-Commit-Position: refs/heads/master@{#295564}

This flags has the same effect as being part of the enabled
group of the DataCompressionProxyAlternativeConfiguration
field trial.

BUG=415185

Review URL: https://codereview.chromium.org/578883004

Cr-Commit-Position: refs/heads/master@{#295563}

Makes some Skia flags be matched properly.

e.g.

  '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"'
vs
  -DGR_GL_CUSTOM_SETUP_HEADER=\"GrGLConfig_chrome.h\"

Diffs 393202 -> 374424.

It does make the script quite a bit slower unfortunately, I guess the
regular split is native C.

BUG=335824

Review URL: https://codereview.chromium.org/580213003

Cr-Commit-Position: refs/heads/master@{#295562}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/0d276f7..23e280d

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=stephana@google.com

Review URL: https://codereview.chromium.org/580243002

Cr-Commit-Position: refs/heads/master@{#295561}

Enable accessibility tests for history page.
Add aria-label for the history search box.
Add aria-label to Today/Previous/Next.
Add aria-label to all the checkboxes.
Add aria-hidden when list is not visible.

BUG=406150

Review URL: https://codereview.chromium.org/513923003

Cr-Commit-Position: refs/heads/master@{#295560}

Review URL: https://codereview.chromium.org/582783002

Cr-Commit-Position: refs/heads/master@{#295559}

This prevents the power consumption data from accidentally leaking visited websites after clearing browser history.

Review URL: https://codereview.chromium.org/514433002

Cr-Commit-Position: refs/heads/master@{#295558}

linux-release-64/sizes/chrome-data/data: https://chromeperf.appspot.com/report?masters=Chromium&bots=chromium-rel-linux&tests=sizes%2Fchrome-data&checked=all&rev=295451

BUG=415523
TBR=bokan@chromium.org

Review URL: https://codereview.chromium.org/578243005

Cr-Commit-Position: refs/heads/master@{#295557}

Part of extensions refactoring in https://codereview.chromium.org/562273006/

Landing manually because the tryjob patch step cannot handle empty binary files

BUG=none
TEST=none
TBR=yoz@chromium.org

Review URL: https://codereview.chromium.org/580283003

Cr-Commit-Position: refs/heads/master@{#295556}

Changes include:
e0399c7 Fix Regression: Incomplete file loading is seen for multi page pdf files.
9135010 gn: don't remove -fno-exceptions to match gyp
69dcf14 When forcing clear page data, no need to release colorspace when releasing pattern
4481496 Add a boundary check before accessing the table of 'Index to Location'
4cce875 Check Null pointer in CPDF_Dictionary::GetUnicodeText
56ef173 Fix hebrew character highlight issue in a special document

TBR=jam@chromium.org
BUG=

Review URL: https://codereview.chromium.org/580173004

Cr-Commit-Position: refs/heads/master@{#295555}

Necessary with upcoming ChromeVox2 changes.

Review URL: https://codereview.chromium.org/574693003

Cr-Commit-Position: refs/heads/master@{#295554}

BUG=415609,415688
TEST=gpu bots
TBR=kbr@chromium.org

Review URL: https://codereview.chromium.org/580183002

Cr-Commit-Position: refs/heads/master@{#295553}

R=dbeam@chromium.org
BUG=393873
TEST=GYP_GENERATORS=ninja gyp --depth . chrome/browser/resources/options/compiled_resources.gyp && ninja -C out/Default | grep ERROR | wc -l

Review URL: https://codereview.chromium.org/560563004

Cr-Commit-Position: refs/heads/master@{#295552}

- Previously, we had an unguarded bool flag for whether an interface lookup had been logged to UMA. Now each InterfaceInfo has a lock+flag. Should be near-zero contention.
- Previously, PpapiGlobals::GetBrowserSender did lazy creation with no synchronization. Now we create it at process startup and clear it at process shutdown, so there should be no race while the plugin is running.

BUG=413513,414150

Committed: https://crrev.com/d1b2c8f719b0ab471a476bf53911a3657bb4c06a
Cr-Commit-Position: refs/heads/master@{#294715}

Review URL: https://codereview.chromium.org/568793002

Cr-Commit-Position: refs/heads/master@{#295551}

R=darin@chromium.org

Review URL: https://codereview.chromium.org/580123004

Cr-Commit-Position: refs/heads/master@{#295550}

Revert of Add GCMChannelStatusSyncer to schedule requests and enable/disable GCM (patchset #8 id:150001 of https://codereview.chromium.org/561943002/)

Reason for revert:
this CL might be breaking browser_tests and interactive_ui_tests on ChromeOS because it's starting a request on startup.  here's an example:

[15345:15369:0918/132152:ERROR:leak_tracker.h(97)] Leaked 0x11cd70da7cc0 which was allocated by:
[15345:15369:0918/132152:ERROR:leak_tracker.h(98)] #0 0x7f44b584025e base::debug::StackTrace::StackTrace()
#1 0x000000dfc481 base::debug::LeakTracker<>::LeakTracker()
#2 0x000000df3e8d SystemURLRequestContextGetter::SystemURLRequestContextGetter()
#3 0x000000df57f1 IOThread::InitSystemRequestContext()
#4 0x000000df570b IOThread::system_url_request_context_getter()
#5 0x000001443d9e BrowserProcessImpl::system_request_context()
#6 0x000001028a8e SafeBrowsingService::Initialize()
#7 0x0000014462c9 BrowserProcessImpl::CreateSafeBrowsingService()
#8 0x000001446196 BrowserProcessImpl::safe_browsing_service()
#9 0x0000014b9a06 ChromeResourceDispatcherHostDelegate::ChromeResourceDispatcherHostDelegate()
#10 0x0000014466dc BrowserProcessImpl::ResourceDispatcherHostCreated()
#11 0x0000008a88e5 chrome::ChromeContentBrowserClient::ResourceDispatcherHostCreated()
#12 0x7f44be489a2f content::ResourceDispatcherHostImpl::ResourceDispatcherHostImpl()
#13 0x7f44be060f44 content::BrowserMainLoop::BrowserThreadsStarted()
#14 0x7f44be068302 base::internal::RunnableAdapter<>::Run()
#15 0x7f44be06826c base::internal::InvokeHelper<>::MakeItSo()
#16 0x7f44be06821a base::internal::Invoker<>::Run()
#17 0x7f44be54e46e base::Callback<>::Run()
#18 0x7f44be8d223b content::StartupTaskRunner::RunAllTasksNow()
#19 0x7f44be05ff97 content::BrowserMainLoop::CreateStartupTasks()
#20 0x7f44be06b824 content::BrowserMainRunnerImpl::Initialize()
#21 0x7f44be05c7df content::BrowserMain()
#22 0x7f44bdee5f6f content::RunNamedProcessTypeMain()
#23 0x7f44bdee9268 content::ContentMainRunnerImpl::Run()
#24 0x7f44bdee5505 content::ContentMain()
#25 0x0000041aa8cb content::BrowserTestBase::SetUp()
#26 0x00000173e117 InProcessBrowserTest::SetUp()
#27 0x000000671180 ExtensionBrowserTest::SetUp()
#28 0x0000006711b2 ExtensionBrowserTest::SetUp()
#29 0x0000017fb993 testing::internal::HandleSehExceptionsInMethodIfSupported<>()
#30 0x0000017e8bfe testing::internal::HandleExceptionsInMethodIfSupported<>()
#31 0x0000017dd1e3 testing::Test::Run()
#32 0x0000017dd92b testing::TestInfo::Run()
#33 0x0000017ddf1a testing::TestCase::Run()
#34 0x0000017e3413 testing::internal::UnitTestImpl::RunAllTests()
#35 0x0000017f47d3 testing::internal::HandleSehExceptionsInMethodIfSupported<>()
#36 0x0000017ea96e testing::internal::HandleExceptionsInMethodIfSupported<>()
#37 0x0000017e30b1 testing::UnitTest::Run()
#38 0x000004187e41 RUN_ALL_TESTS()
#39 0x000004186e67 base::TestSuite::Run()
#40 0x0000007fcd62 InteractiveUITestSuiteRunner::RunTestSuite()
#41 0x00000173c7b8 (anonymous namespace)::ChromeTestLauncherDelegate::RunTestSuite()
#42 0x0000041bc2fb content::LaunchTests()
#43 0x00000173c6e9 LaunchChromeTests()
#44 0x0000007fccbf main
#45 0x7f44ad8ed76d __libc_start_main
#46 0x000000601389 <unknown>

[15345:15369:0918/132152:FATAL:leak_tracker.h(102)] Check failed: 0u == count (0 vs. 1)
#0 0x7f44b584025e base::debug::StackTrace::StackTrace()
#1 0x7f44b58d7a62 logging::LogMessage::~LogMessage()
#2 0x000000dfdd01 base::debug::LeakTracker<>::CheckForLeaks()
#3 0x000000df8e13 IOThread::CleanUp()
#4 0x7f44be0810b6 content::BrowserThreadImpl::CleanUp()
#5 0x7f44be07e852 content::BrowserProcessSubThread::CleanUp()
#6 0x7f44b59d0601 base::Thread::ThreadMain()
#7 0x7f44b59bba3c base::(anonymous namespace)::ThreadFunc()
#8 0x7f44b1aa9e9a start_thread
#9 0x7f44ad9c03fd clone

Original issue's description:
> Add GCMChannelStatusSyncer to schedule requests and enable/disable GCM
>
> BUG=384041
> TEST=new tests added
>
> Committed: https://crrev.com/3c23f4a188e171998f3042ad62f4aa5717e66d63
> Cr-Commit-Position: refs/heads/master@{#295524}

TBR=zea@chromium.org,fgorski@chromium.org,thestig@chromium.org,bauerb@chromium.org,jianli@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=384041

Review URL: https://codereview.chromium.org/582913003

Cr-Commit-Position: refs/heads/master@{#295549}

This is breaking after r295514 which enforces that every file listed in an isolate file exists.

BUG=414808
R=erg@chromium.org

Review URL: https://codereview.chromium.org/584553006

Cr-Commit-Position: refs/heads/master@{#295548}

This is breaking after r295514 which enforces that every file listed in an isolate file exists.

BUG=414808
R=zmo@chromium.org

Review URL: https://codereview.chromium.org/574903003

Cr-Commit-Position: refs/heads/master@{#295547}

BrowserInstantController calls Reload() if the google url
changes. This triggers closing the session crashed info bar
prematurely. Seems like we want this for all InfoBars, so I've
centralized the ignore.

BUG=401024
TEST=none
R=pkasting@chromium.org

Review URL: https://codereview.chromium.org/553333006

Cr-Commit-Position: refs/heads/master@{#295546}

BUG=383877

Review URL: https://codereview.chromium.org/580203002

Cr-Commit-Position: refs/heads/master@{#295545}

This fixes an issue with missing newlines in stacktraces.

BUG=https://code.google.com/p/address-sanitizer/issues/detail?id=343
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/584693002

Cr-Commit-Position: refs/heads/master@{#295544}