- 29 Jul, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/51f067298563..e9417eb6e06b git log 51f067298563..e9417eb6e06b --date=short --no-merges --format='%ad %ae %s' 2019-07-29 jorgelo@chromium.org usergroup_baseline.py: Add security team as OWNERS. Created with: gclient setdep -r src/third_party/chromite@e9417eb6e06b The AutoRoll server is located here: https://autoroll.skia.org/r/chromite-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ie11ee7e3546c8f5589a2b188de9a8c08d20cd12b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723580Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681933}
-
Matt Simmons authored
R=yusufo@chromium.org Bug: 988095 Change-Id: Ie94e97fc7016f57ac212e402e29c07a208dfee74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722985Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Cr-Commit-Position: refs/heads/master@{#681932}
-
Elly Fong-Jones authored
Bug: 953690 Change-Id: I155609bda62bb9170c543f671bcda85dd90af0b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1708830 Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#681931}
-
Daniel Libby authored
When a scroll gesture sequence is handled on the main thread, the scroll chain is first computed on GestureScrollBegin, then used when handling GestureScrollUpdate. In between these two events, it's possible for the nodes in the scroll chain to be modified. There is handling for cases where layout objects are gone, but there is an invariant in NativeApplyScroll that if there is a layout object, it must be a box. However, script can change the node to display:inline which violates this invariant and causes a security DCHECK on the downcast from LayoutObject to LayoutBox. In practice, I don't believe there is a security issue since the LayoutBox is only used to call a non-virtual LayoutObject method (EnclosingBox()), but we should fix this in case future code starts relying on the invariant. I changed the DCHECK in NativeApplyScroll to be a runtime check, similar to the check for the existence of a LayoutObject. In these cases the scroll will just not be applied to the node. Bug: 988241 Change-Id: Iadb1a3a47054aa291ecc0f79e17b26e0b9518498 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724811Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#681930}
-
Yue Zhang authored
https://crrev.com/c/1722779 This CL uses TabGridDialogResetHandler to cancel dialog animation when tab model selection changes. However, the reset handler can be null when #TabGroupUiImprovement flag is not enabled. This CL fixes this issue. Bug: 988362 Change-Id: Ic5f98ea97778617864f0e92c221a51739837d406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722208Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#681929}
-
Francois Doray authored
This CL adds a RendererScheduler.TimeRunningOtherFramesWhileTaskReady.[frame visibility].[queue type] histogram that records the time spent running tasks from other frames while a frame task was ready to run. A non-delayed task is ready to run when it is posted. A delayed task is ready to run when its delay expires. Bug: 984057 Change-Id: I07a0f02dac1f621613cbde979bdd960ac93826fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1689339 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#681928}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 62d54f30. With Chromium commits locally applied on WPT: 250461b3 "Worker: Register a service worker just once for worker subresource interception tests" bf4ad57e "Experimental CookieStore API: some additional browser-side validation" 14d3a4a1 "Sort tracks by id in MediaStreamAudioSourceNode" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: cbiesinger@chromium.org: external/wpt/css/css-flexbox ericwilligers@chromium.org: external/wpt/css/motion kojii@chromium.org: external/wpt/css/css-writing-modes NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I7af703696daea9db7e0de28e7552836dc9bd2a86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724655Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681927}
-
Hongchan Choi authored
"DidDestroy" was never true because we can't notify anything from the GC-managed object destruction. "WillDestroy" means that it is marked for GC and will go away sometime in the future. This is a preview of the new event pattern for the WebAudio DevTool. A series of CLs to implement the graph event will use this pattern to notify the lifecycle event. There's no functional change in this CL. Bug: 970898 Change-Id: Ic359d4ca5a3c69fd5e85ce135fa2a3de881b83bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724815 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#681926}
-
James Cook authored
This matches a refactor made to browser settings. No visual changes. http://screen/h2nWM4PsdeN Bug: none Change-Id: I76d40b6e0a22ad3d700242ed7108942b8e2265fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724412Reviewed-by:
May Lippert <maybelle@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#681925}
-
Daniel Murphy authored
This patch integrates IndexedDB on top of LevelDB Scopes. It tries to do this as simply as possible, and doesn't have sophisticated iterator invalidation logic. The task for this change is here: https://docs.google.com/document/d/1jX6OOQJ0aLrWAeqYLtARXPFawUlJPbHNIKAK-0vmFHU/edit#heading=h.80ylb2v9t1ff refactoring, as well as an increase needed to implement a feature, and I've already spent a non-trivial amount of time trying to reduce its size. Binary-Size: Increase is temporary due to a "new way" / "old way" Bug: 862456 Change-Id: I03bc400fcc23d4dcfe98c3d8722c2cff2895dd0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1676828 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#681924}
-
Chris Harrelson authored
Also, rename PaintLayer::Location() to be more clear what it returns. There is now no caller of this method outside of the PaintLayer class (though descendant PaintLayers need to ask for the location of ancestors, so the method needs to remain). Change-Id: Iff9df76bcc78a7e1ceedd7f66807f2571156ecce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716062Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#681923}
-
Clark DuVall authored
Network service did not have support for these flags in webview. This matches the functionality from aw_url_request_context_getter.cc. This was causing some webview telemetry tests to fail, see bug for more details. Bug: 987623 Change-Id: I0ae492cd8040e6d6ced7ca505a8f48ed82a0f1f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721451Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#681922}
-
Etienne Pierre-doray authored
This CL exposes new interfaces publicly (under the experimental namespace) for the Jobs API. JobTask: Base interface to implement a job JobDelegate: entry point that's passed to a worker task to communicate with the scheduler. The implementation of JobDelegate is partial. The real implementation, as well as usage assertion is in: https://chromium-review.googlesource.com/c/chromium/src/+/1713146 This CL also refactors MockJobTaskSource and related tests to encompass the new types, and to respect the incoming assertion that max concurrency decreases unless NotifyConcurrencyIncrease() is called. Bug: 839091 Change-Id: I34adeeb046a2aca28288c82dc382ef1cb6717b84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1707100 Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#681921}
-
Steve Kobes authored
This renames Performance::layout_jank_buffer_ and associated objects, as well as WindowPerformance::AddLayoutJankFraction. Also remove some references to "jank" in LayoutShiftTracker unit tests. Bug: 963474 Change-Id: I71877731150008928bf56319bf9631d6326ad0f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720997Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#681920}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/db2b6ca2..b7db8a39 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iaa4444d46fe29f0f548775827cb12d534de82309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724657Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681919}
-
Mathias Bynens authored
Per the July TC39 meeting consensus, we'd like to make the upcoming String.prototype.replaceAll proposal throw for non-global RegExp searchValues. However, String.prototype.matchAll currently does not throw in this case, causing consistency concerns. This patch adds a use counter for String.prototype.matchAll with a non-global RegExp as the searchValue. Hopefully, this pattern isn't too common in real-world code today, in which case we can both a) change matchAll and b) proceed with the desired replaceAll semantics. https://github.com/tc39/proposal-string-replaceall/issues/16 V8 CL: https://chromium-review.googlesource.com/c/v8/v8/+/1718145 Chromium CL: https://chromium-review.googlesource.com/c/chromium/src/+/1718367 BUG=v8:9551 Change-Id: I6b4895e87bb498c0284d2852f1d9f0cafbc087d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718367 Commit-Queue: Mathias Bynens <mathias@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#681918}
-
Justin Donnelly authored
This is basically a re-land of https://crrev.com/c/1273620 which restores the old approach to entity suggestions, which is to never dedupe them with a plain suggestion containing the same query text. By including additional_query_params, entity suggestions will always be considered distinct, even if they have the same query text as another search suggestion. Bug: 806995 Change-Id: If9b5b5f876259a1289e3eb093bd24935a74dba51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1658510Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#681917}
-
Michael Lippautz authored
This allows for avoiding CompleteSweep() whenever a V8 GC is about to start. Previously, this was needed because there may be handles that V8's GC needs to clear out and those areas where poisoned until the destructor runs. Eagerly unpoison those areas to avoid diverging behavior in ASAN builds. This also makes ASAN builds more powerful again as they should always use lazy sweeping. Bug: 843903 Change-Id: I4acad94ad965cc721a457fe5fa1944fe354e8730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722934 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#681916}
-
Michael Liao (WPT) authored
Changes: - Marking console log levels button as a menu button - Labeling unchecked soft context menu items as 'unchecked' Bug: 963183 Change-Id: I4d027ea9c4e5eeca2b4a9a87f10d8ae98b1f8d3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1709389 Commit-Queue: Michael Liao <michael.liao@microsoft.com> Reviewed-by:
Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#681915}
-
John Abd-El-Malek authored
This is in preparation of deleting RDH. Bug: 934009 Change-Id: I148a4cf6935a33ba97faa4ce4c0fbec71f55f1e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724819Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#681914}
-
Istiaque Ahmed authored
When the newly created WebContents through chrome.windows.create doesn't wish to preserve opener relationship, do not specify NavigateParams.source_site_instance as it as it is only required and useful when there is a need to keep two WebContentses in the same BrowsingInstance or SiteInstance. Further, this makes WindowsCreateFunction only use SiteInstances when necessary. Add tests to cover the test cases that also verify that the newly created WebContents has correct origin or not. Bug: 986348 Change-Id: I679354bb77c317c4ecc4aeabfec8799bca69dd25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1712441 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#681913}
-
Oystein Eftevaag authored
This should reduce the number of Mojo messages sent to commit chunks from the SMB by a fair amount. R=ssid@chromium.org Bug: 966098 Change-Id: If242e37d2b368b93cb7e72079b2958083e4ea749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717916 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
ssid <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#681912}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/90836d9a6e45..e4645dda2096 Created with: gclient setdep -r src-internal@e4645dda2096 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None,chromium:None,chromium:None Change-Id: I151486459e5e55d090e09c5931d968413f1fadb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723577Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681911}
-
yilkal authored
This CL corrects settings_private.idl and prefs_util.cc so that it is consistent with the javascript implementation. Bug: 945082 Change-Id: I29777701297057d9cf262fb235ccb4291e4d699e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724814Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Yilkal Abe <yilkal@chromium.org> Cr-Commit-Position: refs/heads/master@{#681910}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/b51a6f0c4638..8cce70e1a7c6 git log b51a6f0c4638..8cce70e1a7c6 --date=short --no-merges --format='%ad %ae %s' 2019-07-29 capn@google.com Fail GLSL compilation if compiler initialization fails Created with: gclient setdep -r src/third_party/swiftshader@8cce70e1a7c6 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/137828018 Change-Id: I250175c1966068bc9f98b824f8a3111bbc207aae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723579Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681909}
-
Istiaque Ahmed authored
This is currently unused, and has been so for quite some time. Bug: None Change-Id: If1504fcec2aee489ce6c53e686ef433d26d4849c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723166Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#681908}
-
sczs authored
Bug: 804656 Change-Id: If64d08303a860f3c67c7e61be254ad1363d93137 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721930 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#681907}
-
Jian Li authored
Reason for revert: Caused crash in ProtoBackgroundTracingTest.ProtoTraceReceived [12270:12270:0729/060351.545777:FATAL:privacy_filtering_check.cc(48)] Unexpected field in TracePacket proto. IDs from root to child : 35 : 10 https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8906596135024273344/+/steps/content_browsertests_on_Ubuntu-14.04/0/logs/Deterministic_failure:_ProtoBackgroundTracingTest.ProtoTraceReceived__status_CRASH_/0 Bug: 988528 Change-Id: Ic79b173cccdd46dc92875d4e1a2e4fe5aa2bd099 Tbr: skyosti@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724125Reviewed-by:
Jian Li <jianli@chromium.org> Commit-Queue: Jian Li <jianli@chromium.org> Cr-Commit-Position: refs/heads/master@{#681906}
-
Jacob DeWitt authored
Now, only XRWebGLLayer is defined by the spec and it does not inherit from XRLayer. Bug: 987023 Change-Id: Iaf4f878b33ef816df1e85a39642dea25f318bfa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721929Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Jacob DeWitt <jacde@chromium.org> Cr-Commit-Position: refs/heads/master@{#681905}
-
Christopher Cameron authored
There exist 3 bugs related to custom UserDataDir and PWAs. 1. If Chrome is launched by the PWA, then the UserDataDir is not specified to Chrome. - Fix this by specifying switches::kUserDataDir on the command line 2. If the PWA attempts to launch Chrome, it does not specify the flag NSWorkspaceLaunchNewInstance, and so any existing instance of Chrome (even one with a different UserDataDir) will be returned. - Fix this by specifying NSWorkspaceLaunchNewInstance 3. When the PWA determines if an instance of Chrome is running, the PWA will find any running Chrome instance, not necessarily the one with the PWA's UserDataDir. - The fix for this is more complicated and described below. Instead of looking up running Chrome instances using +[NSRunningApplication runningApplicationsWithBundleIdentifier:], use the same mechanism that Chrome uses to detect multiple instances running using the same UserDataDir. In particular - Check the chrome::kSingletonLockFilename symlink in the UserDataDir - Parse this to find the pid of the running Chrome instance - If this pid is a valid Chrome instance, use that - Otherwise, launch a new instance of Chrome As before, allow the PWA to wait for up to 60 seconds for Chrome to start. During this polling period: - If the process we found via chrome::kSingletonLockFilename quits, then give up and quit the PWA. - If we launched a Chrome process and it has quit, and we haven't yet found a process via chrome::kSingletonLockFilename, then give up and quit the PWA. Bug: 980099 Change-Id: Id322e30da99fdc72319497ead84948d7aff426f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1693906Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#681904}
-
Jun Mukai authored
My CL r681543 removed the layer for PageSwitcher and reused a new AppsContainerView's layer, but it turned out this was wrong since the opacity of parent layer affects the descendent layer opacities. This CL revives the PageSwitcher layer to recover the original behavior of the opacity when dragging the app-list. Since all of AppsContainerView's children have their own layers, this is okay to be ui::LAYER_NOT_DRAWN and hence it won't affect the drawing performance. Bug: 988494 Test: manually Change-Id: If1913b5fa426b7ee63bb25ac7fef180375cdd30d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722408Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Jun Mukai <mukai@chromium.org> Cr-Commit-Position: refs/heads/master@{#681903}
-
Armando Miraglia authored
BUG=986494, 986500 Change-Id: I9b83632caae4e53c5f7430a01bf27c83ff2a8cbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722937Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Armando Miraglia <armax@chromium.org> Cr-Commit-Position: refs/heads/master@{#681902}
-
Mark Mentovai authored
32475fa2 changed the GPU helper's bundle ID to {org.chromium.Chromium,com.google.Chrome}.helper, omitting the .gpu that used to be there, to solve bug 985486. This helper's bundle ID is also mentioned in the signing script, where it's part of the helper's designated requirement. In order for signing to succeed, .gpu must also be removed from this requirement string. Bug: 985486, 988387, 988506 Change-Id: Ieecae6c82dc38f5a150c0e03e4f750d618ab45fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724661Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#681901}
-
Hiroki Nakagawa authored
In the current implementation, WorkerShadowPage provides DocumentLoader to ApplicationCacheHost for shared workers. This blocks WorkerShadowPage removal (see the issue). To unblock it, this series of CLs reduce dependencies on DocumentLoader from ApplicationCacheHost for shared workers. This CL moves ApplicationCacheHost::NotifyApplicationCache() to ApplicationCacheHostForFrame. That function is called for dispatching DOMEvent related appcache, but it's not necessary for shared workers because shared workers don't have any appcache interfaces. Bug: 982996 Change-Id: I019ee6df5850408b160bd09663be246071bb0c48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722135Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#681900}
-
Steven Bennetts authored
This CL: * Adds ManagedProperties and its many subobjects to network_config.mojom * Adds and implements CrosNetworkConfig.GetManagedProperties for retrieving managed properties. * Uses GetManagedProperties in the chrome://network test UI. Bug: 853953 Change-Id: I11cbef3ffcf814335c4b4cdafda31c0ef19ff4fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1680778 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#681899}
-
Matthew Mourgos authored
- The launcher search box will now only process events when the app list main view can process events. Bug: 985583 Change-Id: I0716a84dece411ede7a905932d70e55ece78e8eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722249 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#681898}
-
Carlos Caballero authored
MessageLoopForUI will go away, eventually. ScopedTaskEnvironment will per default start a ThreadPool, which should be fine in most of the cases. If you believe your test needs to make sure that no ThreadPool runs let me know and I will update the patch. BUG=891670 This CL was uploaded by git cl split. R=sczs@chromium.org Change-Id: Icff05dbcd5ffbea9419cd257203d739e5eb226f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718026 Auto-Submit: Carlos Caballero <carlscab@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#681897}
-
Maksim Ivanov authored
1. Wire up the Chrome OS Lock Screen UI code with the challenge-response authentication (a.k.a. smart card login) bits from the browser process. 2. Add a UI control into the Lock Screen for starting the challenge-response authentication. (The UI control is temporarily an unstyled button, but will be replaced with the real UI in follow-ups.) Bug: 964069 Test: enroll a Chromebook, configure device policies to force-install smart card middleware onto Login Screen, log in using a SAML account that uses smart card authentication, lock the Chromebook, check that "Unlock with smart card" appears, click it, check that the user session gets unlocked Change-Id: Icf0ccc80b6778d318c115f79072fdd6595a034b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720640Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#681896}
-
Caroline Rising authored
Make MenuRunner use the MenuModelAdapter. Bug: 943702 Change-Id: Ia05b47e207b4d1d1cc73b046a7fee54432ae84b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724577Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#681895}
-
Kevin Babbitt authored
With UI Automation enabled, the top-level node for the Chrome window would show most properties as empty. This was happening because our fragment root was mapping values from an empty AXNodeData. UI Automation has a built-in provider for HWNDs. In our implementation, fragment roots do not contain any useful accessibility information beyond what the built-in provider would expose, so we simply return VT_EMPTY for most properties, so that we don't override values returned by the built-in provider. The exceptions are IsControlElement and IsContentElement. We implement these properties to exclude the legacy HWND from the control and content views, because we don't want screen readers to stop on the legacy HWND and announce "Chrome Legacy Window." Other HWNDs are allowed in the control and content views so that, for example, an assistive technology can manipulate the window using WindowPattern. R=iapres@microsoft.com Bug: 928811 Change-Id: If606f399c386109adc3bd56bf081b2e5c2362070 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716010Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Cr-Commit-Position: refs/heads/master@{#681894}
-