- 09 Sep, 2016 40 commits
-
-
chrisha authored
BUG=644608 TBR=sebmarchand@chromium.org Review-Url: https://codereview.chromium.org/2324463005 Cr-Commit-Position: refs/heads/master@{#417587}
-
wjmaclean authored
Presently RenderFrameHostImpl::Send() does not use its own widget's input router when sending message, meaning messages to subframes could be sent to the wrong frame. This was discovered while trying to make InputMsg_SelectRange/InputHostMsg_SelectRange_Ack work properly for messages sent to an out-of-process iframe. Note: this is a re-land of https://codereview.chromium.org/2012933002/ originally committed as https://crrev.com/7a22bf01ea55475b295e40f5bbfd1add2bc73649 Cr-Commit-Position: refs/heads/master@{#396044} TBR=creis@chromium.org BUG=470662 Review-Url: https://codereview.chromium.org/2322233003 Cr-Commit-Position: refs/heads/master@{#417586}
-
lionel.g.landwerlin authored
We're currently starting the synchronization of memory mapped dmabufs only for reading, which means the driver will not flush the CPU cache on DMA_BUF_SYNC_END. As a result we tend to see cache lines on platforms where we don't have an additional cache level like Atom platforms. BUG=475633 TEST=run chrome on chromeos with --enable-native-gpu-memory-buffers and verify we don't have image corruptions when hovering the close/minimize buttons Review-Url: https://codereview.chromium.org/2297783006 Cr-Commit-Position: refs/heads/master@{#417585}
-
zmo authored
https://chromium.googlesource.com/external/khronosgroup/webgl.git/+log/2e13422..afd388c BUG= TEST=bots NOTRY=true TBR=kbr@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2319903004 Cr-Commit-Position: refs/heads/master@{#417584}
-
fdoray authored
Revert of Remove calls to MessageLoop::current() in ios. (patchset #1 id:1 of https://codereview.chromium.org/2079423002/ ) Reason for revert: This causes crashes during browser startup. Original issue's description: > Remove calls to MessageLoop::current() in ios. > > Why? > The fact that there's a MessageLoop on the thread is an > unnecessary implementation detail. When browser threads > are migrated to base/task_scheduler, tasks will no longer > have access to a MessageLoop. > > These changes were generated manually. > > BUG=616447 > R=droger@chromium.org > > Committed: https://crrev.com/c5c127abb5f0d8ba0dd34cfbd6233bbf9209f0f2 > Cr-Commit-Position: refs/heads/master@{#401027} TBR=sdefresne@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=616447 Review-Url: https://codereview.chromium.org/2326053002 Cr-Commit-Position: refs/heads/master@{#417583}
-
mahmadi authored
Review-Url: https://codereview.chromium.org/2324153002 Cr-Commit-Position: refs/heads/master@{#417582}
-
rdevlin.cronin authored
We report events to the activity log on the UI thread, which can involve a thread hop. During this thread hop, it's possible the profile was invalidated. Check the profile before using it. BUG=643012 Review-Url: https://codereview.chromium.org/2326613003 Cr-Commit-Position: refs/heads/master@{#417581}
-
agrieve authored
Revert of Make secondary abi work for component build (patchset #5 id:80001 of https://codereview.chromium.org/2319273002/ ) Reason for revert: Broke v8 roller Original issue's description: > Make secondary abi work for component build > > Add secondary_abi_shared_libraries to pack all the secondary abi > shared libraries into APK. > > BUG=622855 > > Committed: https://crrev.com/3ac692c2e67e8030a30e4ebcd12240352944f898 > Cr-Commit-Position: refs/heads/master@{#417441} TBR=machenbach@chromium.org,michaelbai@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=622855 Review-Url: https://codereview.chromium.org/2327063002 Cr-Commit-Position: refs/heads/master@{#417580}
-
skia-deps-roller authored
https://chromium.googlesource.com/skia.git/+log/426a2459290a..a42405aa522c $ git log 426a24592..a42405aa5 --date=short --no-merges --format='%ad %ae %s' 2016-09-09 borenet Fix issues in assets scripts 2016-09-09 halcanary SkPDF: implement drawTextBlob() CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=caryclark@google.com Review-Url: https://codereview.chromium.org/2321403002 Cr-Commit-Position: refs/heads/master@{#417579}
-
kylechar authored
Add a new mojo interface mojom::DisplayController to allow privileged clients to make changes to the display state. The initial interface contains methods needed by mash to provide display state related keyboard accelerators that exist in cash currently. Have PlatformScreenOzone implement this new interface and provide mostly stub implementations. Right now the interface isn't wired up so that will happen in a subsequent CL. Also adds PlatformScreen::GetInstance() so PlatformScreen doesn't need to be passed so many places. BUG=611475 Review-Url: https://codereview.chromium.org/2310133002 Cr-Commit-Position: refs/heads/master@{#417578}
-
tobiasjs authored
BUG=404831 Review-Url: https://codereview.chromium.org/2326013002 Cr-Commit-Position: refs/heads/master@{#417577}
-
mahmadi authored
Previously, User manager actions were being disabled if no regular (aka custodian) profiles existed (b/c it's not possible to have a supervised profile on its own). Since it's possible for child profiles to exist on their own, this CL changes the behavior so that user manager actions are disabled only if there is at least one regular profile and that all regular profiles are locked. BUG=640885 Review-Url: https://codereview.chromium.org/2325643003 Cr-Commit-Position: refs/heads/master@{#417576}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6ccda2c1..3e7af8dc Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2323913005 Cr-Commit-Position: refs/heads/master@{#417575}
-
keishi authored
Compositor workers do not own the compositor thread so they do not do a cleanup gc on termination. This means objects will be left uncollected once per thread heap is enabled for compositor workers. To make up for that, the LeakDetector should run a GC on the compositor thread explicitly. BUG= Review-Url: https://codereview.chromium.org/2304073002 Cr-Commit-Position: refs/heads/master@{#417574}
-
ellyjones authored
Without this VoiceOver reads the window title, which is "BmbPopUpWindow". BUG=641496 Review-Url: https://codereview.chromium.org/2320723006 Cr-Commit-Position: refs/heads/master@{#417573}
-
ryansturm authored
This UMA measures savings, inflation, content length, etc. BUG=615565 Review-Url: https://codereview.chromium.org/2256603005 Cr-Commit-Position: refs/heads/master@{#417572}
-
foolip authored
Revert of Move HTMLDocument::isCaseSensitiveAttribute into SelectorChecker (patchset #1 id:1 of https://codereview.chromium.org/2313253002/ ) Reason for revert: Possible cause of regression in blink_perf.parser. BUG=645370 Original issue's description: > Move HTMLDocument::isCaseSensitiveAttribute into SelectorChecker > > BUG=238368 > R=esprehn@chromium.org,rune@opera.com > > Committed: https://crrev.com/e912108e9daf83d1bec61e5b78aaacf965a3e2fc > Cr-Commit-Position: refs/heads/master@{#416903} TBR=esprehn@chromium.org,rune@opera.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=238368 Review-Url: https://codereview.chromium.org/2326493004 Cr-Commit-Position: refs/heads/master@{#417571}
-
recipe-roller authored
This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/329e32d57bfbbe73c6163f8e2add947239de010b V8: Prepare switching off gyp in runhooks (machenbach@chromium.org) TBR=martiniss@chromium.org,phajdan.jr@chromium.org BUG=chromium:474921 Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2319093006 Cr-Commit-Position: refs/heads/master@{#417570}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/a2bac5f24b7e..b1c8c53e1d00 $ git log a2bac5f24..b1c8c53e1 --date=short --no-merges --format='%ad %ae %s' 2016-09-09 ulan Add a metric to track the percentage of GC time in V8.Execute tasks. TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2316273005 Cr-Commit-Position: refs/heads/master@{#417569}
-
rego authored
This patch modifies LayoutGrid::gridGapForDirection() because we only need to calculate the available space if the grid gap is a percentage. Otherwise we can skip this operation. BUG=615248 Review-Url: https://codereview.chromium.org/2325573003 Cr-Commit-Position: refs/heads/master@{#417568}
-
eae authored
Update NGLayoutInputText to include further fields for run segmentation. BUG=591099 R=drott@chromium.org Review-Url: https://codereview.chromium.org/2323283002 Cr-Commit-Position: refs/heads/master@{#417567}
-
wjmaclean authored
At present, debug builds of Chrome can crash if your touch scrolling in a cross-site iframe with --site-per-process enabled, and then you tap in the parent frame. This happens when a 'dummy' WebGestureEvent is sent to RenderWidgetHostInputEventRouter::SendGestureScrollEvent() without defining its type. Since the function DCHECKs the type of the input event, this causes a crash. This CL makes sure the event has an appropriate type. BUG=645208 Review-Url: https://codereview.chromium.org/2323093002 Cr-Commit-Position: refs/heads/master@{#417566}
-
pmeenan authored
This fixes the situation where every request is canceled even after it has completed successfully. The cancels were not harming anything and were dropped on the floor but the additional messages were useless. BUG=642172 Review-Url: https://codereview.chromium.org/2303733004 Cr-Commit-Position: refs/heads/master@{#417565}
-
magjed authored
Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/3d67882..c46742b $ git log 3d67882..c46742b --date=short --no-merges --format=%ad %ae %s 2016-09-09 kwiberg@webrtc.org rtc::Optional: Tell sanitizers that unset values aren't OK to access 2016-09-09 philipel@webrtc.org Added ClearTo(seq_num) to RtpFrameReferenceFinder. 2016-09-09 kthelgason@webrtc.org Reland of move all reference to carbon api (patchset #1 id:1 of https://codereview.webrtc.org/2317343003/ ) 2016-09-09 kwiberg@webrtc.org VadCore: Allow signed multiplication overflow that we don't know how to fix 2016-09-09 kjellander@webrtc.org MB: Disable more parts of the GYP build. 2016-09-09 kjellander@webrtc.org Remove references to .isolate files that are no longer needed. 2016-09-09 hbos@webrtc.org Renamed RTCStatsReport to RTCLegacyStatsReport in objc files. 2016-09-09 sakal@webrtc.org Add sakal as an OWNER to some Android files. 2016-09-09 asapersson@webrtc.org Update AvgCounter to have the ability to include last period metric for subsequent intervals without samples (e.g. for non-periodic updated stats). 2016-09-09 sakal@webrtc.org Make UMA stats creation available in the Java interface. 2016-09-08 magjed@webrtc.org Add magjed@ as owner of webrtc/common_video 2016-09-08 kjellander@webrtc.org Revert of Add a DEPS gclient hook to prune corrupt mockito remote. (patchset #1 id:1 of https://codereview.webrtc.org/2326523002/ ) 2016-09-08 kjellander@webrtc.org Revert of Separating video settings in VideoQualityTest. (patchset #2 id:20001 of https://codereview.webrtc.org/2312613003/ ) 2016-09-08 peah@webrtc.org This CL refactors the buffering of the incoming near-end signal inside the AEC. This solves the following issues: -Even though the buffering was previously done using ringbuffers, those were inefficiently used which caused a lot of hidden memcopys. -The ringbuffers wasted a lot of space in the AEC state as they were too long. -The lowest and two upper bands were decoupled in the buffering, which required extra code to handle. -On top of the ringbuffers there was a second linear buffer that was stored in the state which caused even more data to be stored on the state. -The incoming nearend frames were passed to the functions in the form of buffers on the state, which made the code harder to read as it was not immediately clear where the nearend signal was used, and when it was modified. 2016-09-08 henrikg@webrtc.org Change owner of webrtc/test/channel_transport to solenberg@. TBR= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG= Review-Url: https://codereview.chromium.org/2326953004 Cr-Commit-Position: refs/heads/master@{#417564}
-
mstensho authored
The clip rect is visual, so we need to shift each fragmentainer group by its visual translation. This matters for nested multicol. BUG=642325 Review-Url: https://codereview.chromium.org/2321333002 Cr-Commit-Position: refs/heads/master@{#417563}
-
eae authored
Implement exclusion aware layout opportunities algorithm. At the moment it only handles opportunities for a fixed starting point, sorted by the width of the opportunities, widest first. Next step is to recompute for the next exclusion once all current opportunities have been exhausted. BUG=591099 R=ikilpatrick@chromium.org Review-Url: https://codereview.chromium.org/2298273002 Cr-Commit-Position: refs/heads/master@{#417562}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/9a9164a7..6ccda2c1 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2327803002 Cr-Commit-Position: refs/heads/master@{#417561}
-
noyau authored
This is way too chatty. BUG=None Review-Url: https://codereview.chromium.org/2323913004 Cr-Commit-Position: refs/heads/master@{#417560}
-
hayato authored
ElementShadow::m_shadowRoot is always non-nullptr here. BUG=624724 Review-Url: https://codereview.chromium.org/2322223002 Cr-Commit-Position: refs/heads/master@{#417559}
-
hiroshige authored
BUG=645395, 596760 Review-Url: https://codereview.chromium.org/2325093002 Cr-Commit-Position: refs/heads/master@{#417558}
-
kojii authored
When a perf improvements for collapsing whitespace[1] landed, following tests were adjusted to be 12x slower, to match to the test without whitespace collapsing. However, these tests then timeout on reference build. This patch defers the adjust until the reference build is updated. PerformanceTests/Layout/long-line-nowrap-collapse.html PerformanceTests/Layout/long-line-nowrap-spans-collapse.html [1] https://codereview.chromium.org/2285053002 BUG=642884 Review-Url: https://codereview.chromium.org/2323213002 Cr-Commit-Position: refs/heads/master@{#417557}
-
catapult-deps-roller authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/d961ec30c833..a2bac5f24b7e $ git log d961ec30c..a2bac5f24 --date=short --no-merges --format='%ad %ae %s' 2016-09-09 petrcermak [tracing] Add <tr-v-ui-scalar-context-controller> element TBR=catapult-sheriff@chromium.org Review-Url: https://codereview.chromium.org/2324593006 Cr-Commit-Position: refs/heads/master@{#417556}
-
hayato authored
I think Node::shadowHost() is not a good name because it is unclear *which* shadowHost would be returned by its name. Node::ownerShadowHost() might be a better name than Node::shadowHost(). It is similar to Node::ownerDocument(), where it is clear that the owner would be returned. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2327743002 Cr-Commit-Position: refs/heads/master@{#417555}
-
finnur authored
BUG=635846, 614277 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2323693002 Cr-Commit-Position: refs/heads/master@{#417554}
-
hbos authored
webrtc::RTCStats lives in the WebRTC repo and can't be directly accessed from Blink. In content we implement blink::WebRTCStats and friends to bridge this gap. Work split up in smaller CLs. In a follow-up CL we will gather stats in content's rtc_peer_connection_handler.cc using webrtc::RTCStatsCollector and return the resulting stats to Blink using [Web]RTCStats, this will include unittests. BUG=chromium:627816 Review-Url: https://codereview.chromium.org/2319543002 Cr-Commit-Position: refs/heads/master@{#417553}
-
petrcermak authored
This patch adds support for enabling/disabling individual stories on individual platforms using the same approaches as for benchmarks: 1. Disabled/Enabled decorator: @decorators.Disabled('win') class Story(system_health_story.SystemHealthStory): ... 2. ShouldDisable method: class Story(system_health_story.SystemHealthStory): ... @classmethod def ShouldDisable(cls, possible_browser): return possible_browser.platform.GetOSName() == 'win' Note that this patch also enables search:portal:google on all desktop platforms except for Windows. BUG=634331 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.perf:android_s5_perf_cq;master.tryserver.chromium.perf:linux_perf_cq;master.tryserver.chromium.perf:mac_retina_perf_cq;master.tryserver.chromium.perf:winx64_10_perf_cq Review-Url: https://codereview.chromium.org/2228103002 Cr-Commit-Position: refs/heads/master@{#417552}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d87b834b..9a9164a7 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org Review-Url: https://codereview.chromium.org/2328693003 Cr-Commit-Position: refs/heads/master@{#417551}
-
hiroshige authored
- Use EXPECT_.*() where possible instead of ASSERT_.*() - Use the argument order of EXPECT_EQ(expected, actual) - Remove unnecessary casts - Replace EXPECT_EQ/NE(nullptr) with EXPECT_FALSE/TRUE() - Replace EXPECT_STREQ() with EXPECT_EQ() using WTF::String comparison BUG=none Review-Url: https://codereview.chromium.org/2324103002 Cr-Commit-Position: refs/heads/master@{#417550}
-
magjed authored
In the current code, CPU adaptation does not work correctly. It should scale to the adapted resolution, but it crops instead. The result looks like zoomed in video. This bug was introduced in https://codereview.chromium.org/2270723002/. This CL fixes the cropping logic. BUG=chromium:635592 Review-Url: https://codereview.chromium.org/2323573004 Cr-Commit-Position: refs/heads/master@{#417549}
-
yosin authored
This patch simplifies caret color calculation in |CaretBase::paintCaret()| by using |LayoutObject::resolveColor()| for |CSSColorProperty| for specified |Node| object rather than using parent element's layout object, since color value for |Text| node and parent element are same. BUG=n/a TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2322193002 Cr-Commit-Position: refs/heads/master@{#417548}
-