GitLab

BUG=349015
R=mvanouwerkerk@chromium.org

Review URL: https://codereview.chromium.org/183683018

git-svn-id: svn://svn.chromium.org/blink/trunk@168485 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=349392
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/183763036

git-svn-id: svn://svn.chromium.org/blink/trunk@168484 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=loislo@chromium.org

Review URL: https://codereview.chromium.org/187473005

git-svn-id: svn://svn.chromium.org/blink/trunk@168483 bbb929c8-8fbe-4397-9dbb-9b2b20218538

WebInputEventFactory::gestureEvent was added a long time ago but is
not currently used.  Remove the existing unused code and update the
function to support creating GesturePinchUpdate events from Cocoa
NSEventTypeMagnify events.

BUG=289887

Review URL: https://codereview.chromium.org/184983003

git-svn-id: svn://svn.chromium.org/blink/trunk@168482 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Caused assertion failures on debug GPU bots. See Issue 344393 for details.

> WebGL: Transfer ownership of WebGraphicsContext3D from WebGLRenderingContext to DrawingBuffer.
> 
> Currently, the lifecycle of DrawingBuffer is different from it of
> WebGraphicsContext3D, so there is so many checks if the context is valid.
> This complexity is not necessary because DrawingBuffer does not own any
> objects when the context is lost or impossible to be created.
> 
> To be clear the lifecycle, this CL makes DrawingBuffer take ownership of WebGraphicsContext3D.
> 
> The DrawingBuffer creation or resize can fail if the memory is not enough. This
> logic is preserved.
> In detail,
> 1. If it occurs during WebGLRenderingContext creation, we give up creating
> WebGLRenderingContext.
> 2. If it occurs during restoration of lost context, we will try again.
> 3. If it occurs during resizing DrawingBuffer, we slightly ignore, because we
> can reuse different size FBO in this case.
> 
> In addition, this CL fixes two bugs.
> 1. maybeRestoreContext() pretends to success to restore although creating FBO in
> DrawingBuffer fails. As mentioned earlier, we will try again.
> 2. WebGLRenderingContext calls DrawingBuffer::reset() twice during creation,
> because the constructor of DrawingBuffer internally calls reset().
> 
> BUG=344393
> 
> Review URL: https://codereview.chromium.org/163773007

TBR=dongseong.hwang@intel.com

Review URL: https://codereview.chromium.org/184343005

git-svn-id: svn://svn.chromium.org/blink/trunk@168481 bbb929c8-8fbe-4397-9dbb-9b2b20218538

No behavioral changes, architecture only:
  - padding rows are moved back to the datagrid
  - children access are made through Node.allChildren()
  - minor cosmetic changes

BUG=255363
R=yurys@chromium.org

Review URL: https://codereview.chromium.org/187703002

git-svn-id: svn://svn.chromium.org/blink/trunk@168480 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL moves most of the implementation out of RenderSVGModelObject and
into SVGSVGElement (which is the only client). Some notes:

* use the consolidated SVGGraphicsElement::computeCTM() (which is
  accumulating localCoordinateSpaceTransform()s and not
  localToParentTransform()s like the old getElementCTM() did <- root
  cause for the zooming bug)
* only force a layout update once, at the entry point, instead of on each
  getElementCTM() call.
* detect the stopping element on the fly, instead of an additional upfront
  ancestor crawl.
* transforms are now correctly computed relative to the target <svg>
  element instead of the nearest viewport.

BUG=155277
R=pdr@chromium.org,schenney@chromium.org,fs@opera.com,rob.buis@samsung.com

Review URL: https://codereview.chromium.org/185333004

git-svn-id: svn://svn.chromium.org/blink/trunk@168479 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Test scenarios:
http://www.rbyers.net/eventTest.html - scrolling the page or div (has a wheel handler but doesn't call preventDefault)
Loading https://twitter.com/pwnall

BUG=343132

Review URL: https://codereview.chromium.org/180803012

git-svn-id: svn://svn.chromium.org/blink/trunk@168478 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When a shape and box are supplied for a shape-property, the order they
are input should be preserved in output from the CSSOM. This patch parses
the shape and box values as a CSSValueList to preserve that ordering,
and removes the need for BasicShapes to have a sizing box.

BUG=322165

Review URL: https://codereview.chromium.org/144143005

git-svn-id: svn://svn.chromium.org/blink/trunk@168477 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Add FontStretch enum and field to FontDescription and FontTraitsMask.
This is the first step towards supporting the CSS font-stretch
property.

TEST=Source/platform/fonts/FontDescriptionTest.cpp
BUG=347765
R=eseidel@chromium.org

Review URL: https://codereview.chromium.org/183813005

git-svn-id: svn://svn.chromium.org/blink/trunk@168476 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When resetting the animated property value for animations that is applied
as a CSS property always create a new property, or additive animations
will accumulate incorrectly to the underlying value.

BUG=349052

Review URL: https://codereview.chromium.org/183973023

git-svn-id: svn://svn.chromium.org/blink/trunk@168475 bbb929c8-8fbe-4397-9dbb-9b2b20218538

MediaControls::create returns null if any of these would be null.

BUG=341813
R=acolwell@chromium.org

Review URL: https://codereview.chromium.org/182383006

git-svn-id: svn://svn.chromium.org/blink/trunk@168474 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fixed position elements are clipped by CSS clip ancestors,
which may be between the fixed position element and its
containingBlock. So clippingAncestor needs to walk up the
ancestors of a fixed positioned element manually instead
of using containingBlock directly.

I believe this only applies to fixed position elements.
Other elements can use containingBlock because an absolutely
positioned ancestor will never get skipped in the
containingBlock traversal and CSS clip only applies to
absolutely positioned elements.

BUG=347172

Review URL: https://codereview.chromium.org/179833006

git-svn-id: svn://svn.chromium.org/blink/trunk@168473 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It will improve performance when POD types are copied, by providing
a missing implementation of VectorCopier and using it in
two places which were previously always taking the "new" allocation
path even though they could have used VectorCopier and used
memcpy for POD types.

NOTRY=true

Review URL: https://codereview.chromium.org/178313002

git-svn-id: svn://svn.chromium.org/blink/trunk@168472 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch removes support for the legacy WebKit notifications from Blink,
per the following Intent to Remove thread:

https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/8vqyfHa8_dw

BUG=348019

Review URL: https://codereview.chromium.org/184733002

git-svn-id: svn://svn.chromium.org/blink/trunk@168471 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Mostly just remove code: net -190 lines
(also group type classes together, and replace some None with False)

Further simplification is possible, as we no longer need classes for
enums and unions; will do in followup, b/c more involved.

BUG=345137
TBR=haraken

Review URL: https://codereview.chromium.org/185303013

git-svn-id: svn://svn.chromium.org/blink/trunk@168470 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch moves InspectorStyleSheet::ensureSourceData to
ParsedStyleSheet.

BUG=

Review URL: https://codereview.chromium.org/183763029

git-svn-id: svn://svn.chromium.org/blink/trunk@168469 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch removes some dead code from InspectorStyleSheet.

TBR=apavlov
BUG=

Review URL: https://codereview.chromium.org/186823002

git-svn-id: svn://svn.chromium.org/blink/trunk@168468 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This leads to double finalization.

NOTRY=true

Review URL: https://codereview.chromium.org/180273022

git-svn-id: svn://svn.chromium.org/blink/trunk@168467 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Move all RefPtr's to CSSValue to oilpan transition types, except for the one in CSSCursorImageValue.

This change gets rid of all but one RefPtr to CSSValue. I have introduced a few persistents core/animation/..., core/css/StylePropertySet, and ElementStyleResources. I plan to attack the one in CSSCursorImageValue subsequently, and then change CSSValue from RefCountedGarbageCollected to GarbageCollectedFinalized.

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, oilpan-reviews@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=341815
NOTRY=true

Review URL: https://codereview.chromium.org/184313004

git-svn-id: svn://svn.chromium.org/blink/trunk@168466 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As part of the review of https://codereview.chromium.org/171383002/
it was requested that the required static strings for the media features and types will be generated as part of the build system.
This CL implements that request.

BUG=

Review URL: https://codereview.chromium.org/185533012

git-svn-id: svn://svn.chromium.org/blink/trunk@168465 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The code in platform/drm contains minimal functionality now and can
be removed.

BUG=224791
TEST=EME content tests pass

Review URL: https://codereview.chromium.org/186093003

git-svn-id: svn://svn.chromium.org/blink/trunk@168464 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=erik.corry@gmail.com, haraken@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/187483006

git-svn-id: svn://svn.chromium.org/blink/trunk@168463 bbb929c8-8fbe-4397-9dbb-9b2b20218538

ScriptPromise::ScriptPromise(v8::Handle<v8::Value>, v8::Isolate*) expects
that the first parameter is a Promise object, but no one checks that.
This CL fixes that.

Rename ScriptPromise::ScriptPromise(ScriptValue) to ScriptPromise::cast to
avoid the confusion caused by the diferrent behaviors with a non-Promise parameter.

BUG=347047

Review URL: https://codereview.chromium.org/181173002

git-svn-id: svn://svn.chromium.org/blink/trunk@168462 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This method has two logical parts: Advancing the text position and
checking for termination, and computing the metrics for the current
character.
Split this method to better show this. The latter part is put into a
new method, computeMetricsForCurrentCharacter, while the former part is
open-coded in SVGTextMetricsBuilder::measureTextRenderer.
The advance{Simple,Complex}Text methods are renamed to
computeMetricsForCurrentCharacter{Simple,Complex}.

With this change, it becomes easier to see that
SVGTextMetricsBuilder::m_currentMetrics can be trivially removed in favor
of returning it from computeMetricsForCurrentCharacter, and storing it on
the stack in SVGTextMetricsBuilder::measureTextRenderer.
The same is true for SVGTextMetricsBuilder::m_complexStartToCurrentMetrics,
which can be made local to computeMetricsForCurrentCharacterComplex.

Review URL: https://codereview.chromium.org/184103024

git-svn-id: svn://svn.chromium.org/blink/trunk@168461 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This moves the File API and its objects to Oilpan using transition
types.

R=haraken@chromium.org,tkent@chromium.org
BUG=340522

Review URL: https://codereview.chromium.org/176853004

git-svn-id: svn://svn.chromium.org/blink/trunk@168460 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Oilpan: Don't trace the RefPtr for the CSSCursorImageValue workaround. It is trace via the RefCountedGarbageCollected persistent.

We are correctly hitting an UNREACHABLE when tracing a RefPtr with
enable_oilpan=1 on the bots.

R=haraken@chromium.org, wibling@chromium.org, oilpan-reviews@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/177413009

git-svn-id: svn://svn.chromium.org/blink/trunk@168459 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Oilpan: Use weak pointers in StyleSheetContents caches. (https://codereview.chromium.org/185403016/)

Reason for revert:
This patch seems to have made a number of layout tests fail on the oilpan bots. Reverting while I investigate.

Original issue's description:
> Oilpan: Use weak pointers in StyleSheetContents caches.
> 
> This fixes use-after-free that could occur when StyleSheetContents
> dies when an allocation happens during insertion of a new
> StyleSheetContents. Using the built-in weak processing this will
> not happen because the iterator used during insertion will keep
> the StyleSheetContents alive.
> 
> R=erik.corry@gmail.com, haraken@chromium.org, vegorov@chromium.org
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=168444

TBR=erik.corry@gmail.com,haraken@chromium.org,vegorov@chromium.org,zerny@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/187473003

git-svn-id: svn://svn.chromium.org/blink/trunk@168458 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently, the lifecycle of DrawingBuffer is different from it of
WebGraphicsContext3D, so there is so many checks if the context is valid.
This complexity is not necessary because DrawingBuffer does not own any
objects when the context is lost or impossible to be created.

To be clear the lifecycle, this CL makes DrawingBuffer take ownership of WebGraphicsContext3D.

The DrawingBuffer creation or resize can fail if the memory is not enough. This
logic is preserved.
In detail,
1. If it occurs during WebGLRenderingContext creation, we give up creating
WebGLRenderingContext.
2. If it occurs during restoration of lost context, we will try again.
3. If it occurs during resizing DrawingBuffer, we slightly ignore, because we
can reuse different size FBO in this case.

In addition, this CL fixes two bugs.
1. maybeRestoreContext() pretends to success to restore although creating FBO in
DrawingBuffer fails. As mentioned earlier, we will try again.
2. WebGLRenderingContext calls DrawingBuffer::reset() twice during creation,
because the constructor of DrawingBuffer internally calls reset().

BUG=344393

Review URL: https://codereview.chromium.org/163773007

git-svn-id: svn://svn.chromium.org/blink/trunk@168457 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Specifically MediaQuery, MediaQueryExp, MediaQuerySet, MediaQueryResult, and MediaList. Also added a persistent in  CSSStyleSheet and MediaQueryList. Finally changed FontFace to RefCountedGarbageCollected when oilpan is enabled. FontFace require a bit more separate work to move entirely so leaving that for a separate change.

The reason for the test breakage was that I had overlooked a MediaQueryExp that was a part object in MediaQueryResult.  

Finally fixed an incorrect persistent found by Ian's oilpan plugin, yay:)

R=ager@chromium.org, erik.corry@gmail.com, haraken@chromium.org, tkent@chromium.org, vegorov@chromium.org, zerny@chromium.org
BUG=341815
NOTRY=true

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167798

Review URL: https://codereview.chromium.org/170283019

git-svn-id: svn://svn.chromium.org/blink/trunk@168456 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=loislo@chromium.org

Review URL: https://codereview.chromium.org/186833002

git-svn-id: svn://svn.chromium.org/blink/trunk@168455 bbb929c8-8fbe-4397-9dbb-9b2b20218538

c.f. shadow-styling spec:
/shadow-all/: http://dev.w3.org/csswg/shadow-styling/#shadow-all-combinator
/shadow-deep/: http://dev.w3.org/csswg/shadow-styling/#shadow-deep-combinator

BUG=348891
TEST=Replaced all ^ and ^^ with /shadow-all/ and /shadow-deep/ and rebaselined.

Review URL: https://codereview.chromium.org/183803016

git-svn-id: svn://svn.chromium.org/blink/trunk@168454 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL regressed performance of Dromaeo/dom-traverse unacceptably.
https://chromeperf.appspot.com/report?masters=ChromiumPerf&bots=chromium-rel-mac6%2Cchromium-rel-mac8%2Cchromium-rel-win7-dual%2Clinux-release&tests=dromaeo.domcoretraverse%2Fdom&checked=core


> Move popular DOM attributes to prototype chains
> 
> Design document: https://docs.google.com/a/google.com/document/d/1yeHTCHhulVIlrKyx9_gCguAhLfcefVOa9uxxfW2LVG0/edit
> 
> Intent-to-ship-and-implement in blink-dev: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/t0XiZuMey7M/9-5AuhoFyisJ
> 
> This CL moves DOM attributes used in Dromaeo to prototype chains. When I landed the CL two months ago (https://codereview.chromium.org/94403002), it caused 20+% regression in benchmarks. However, now that a V8 side fix is landed, there should be no overhead in moving DOM attributes to prototype chains in theory.
> 
> Dromaeo/dom-attr 1086 runs/sec => 1077 runs/sec (-0.8%)
> Dromaeo/dom-modify 522 runs/sec => 525 runs/sec (+0.5%)
> Dromaeo/dom-query 26150 runs/sec => 26200 runs/sec (+0.2%)
> Dromaeo/dom-traverse 564 runs/sec => 544 runs/sec (-3.6%)
> 
> I don't understand the regression in dom-traverse. The regression is reproducible but I cannot reproduce the regression in a super-micro benchmark that just repeats accessing div.firstChild. Probably the regression might be a noise.
> 
> I'm going to land this CL and see how much regression is observed in perf bots (I'll email to perf-sheriff@). If I find the regression is unacceptable, I'll revert the CL.
> 
> See the design document and the Intent-to-ship email for justification for the regression.
> 
> BUG=43394
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167680
> 
> R=jochen@chromium.org
> 
> Review URL: https://codereview.chromium.org/158713002

TBR=haraken@chromium.org

Review URL: https://codereview.chromium.org/187343006

git-svn-id: svn://svn.chromium.org/blink/trunk@168453 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a remnant from WebKit when there was a volume slider container
that could be shown and hidden. What remains is essentially dead code,
because at most it shows the slider when m_mediaController->hasAudio(),
but MediaControls::reset() already does that.

BUG=341813

Review URL: https://codereview.chromium.org/176883020

git-svn-id: svn://svn.chromium.org/blink/trunk@168452 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=346642

Review URL: https://codereview.chromium.org/180273012

git-svn-id: svn://svn.chromium.org/blink/trunk@168451 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Transparency layers were implemented before composited layers
were made to be fully sub-pixel aware. Blink r164561 was the
sub-pixel fix for composited layers, which caused them to behave
differently than transparency layers leading to off-by-one
errors. This patch teaches transparency layers about sub-pixel.

BUG=347521

Review URL: https://codereview.chromium.org/180163008

git-svn-id: svn://svn.chromium.org/blink/trunk@168450 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Remove unnecessary textDirection parameter from the min/maxLogicalWidth
methods and computePreferredLogicalWidths and instead use the resolved
text directionality.

BUG=333004
R=dglazkov@chromium.org

Review URL: https://codereview.chromium.org/183013005

git-svn-id: svn://svn.chromium.org/blink/trunk@168449 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The message passed to the method is a result of JSON.stringify and may contain noncharacter unicode code points (http://www.unicode.org/faq/private_use.html#noncharacters). Since we know that the message is a JSON string we can use \uXXXX escape sequences for bad symbols. The function escapes not only noncharacters which produces valid output and allows to keep implementation simple.

BUG=347899
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/178473027

git-svn-id: svn://svn.chromium.org/blink/trunk@168448 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=348993
R=pfeldman@chromium.org

Review URL: https://codereview.chromium.org/184313003

git-svn-id: svn://svn.chromium.org/blink/trunk@168447 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The rebaseline-json results are returned as a JSON object
with |return_code| and optional error |output| fields.

R=eseidel,dglazkov@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/183383008

git-svn-id: svn://svn.chromium.org/blink/trunk@168446 bbb929c8-8fbe-4397-9dbb-9b2b20218538