- 21 Nov, 2017 40 commits
-
-
Nicolas Dossou-gbete authored
Simplifies the code path for the Framebust block infobar that was trying to share code with the desktop intrvention UI but ended up being unused. Makes the implementation closer to the one for the Near-OOM intervention. Most importantly, exposes Accept and DeclineIntervention methods for the Framebust Block intervention, that now enables callers to react when the intervention is accepted. Bug: 781890 Change-Id: I845f76bdbddf85f49c8e0fe8548a2e78d2e213b3 Reviewed-on: https://chromium-review.googlesource.com/779521 Commit-Queue: Nicolas Dossou-Gbété <dgn@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#518319}
-
Lei Zhang authored
Rename it to PrintPageInternal() and give it the same method signature as PrintPageInternal() on other platforms. Change both PrintPageInternal() implementations to look more like each other. Change-Id: I087f784eeea8bf1b9dc4e5e0c8b2d1d30572d204 Reviewed-on: https://chromium-review.googlesource.com/780686Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#518318}
-
Rakina Zata Amni authored
window.event should be undefined if an Event's target is in a shadow tree, because it is leaking information from inside the shadow tree. This change will remove window.event support for events targeted to nodes within a V1 shadow tree. Discussion link: https://github.com/whatwg/dom/issues/334 Bug: 779461 Change-Id: I310bc72463369befd693de9321a9949a97e83f5e Reviewed-on: https://chromium-review.googlesource.com/773922 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Takayoshi Kochi <kochi@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#518317}
-
Mehran Mahmoudi authored
This cl fixes a bug that caused the IPH bubble for Contextual Search to appear over the CS panel after screen rotation. Bug: 786492 Change-Id: Ibab38cde282e4e22f01f0dcb6ea035adf98498e0 Reviewed-on: https://chromium-review.googlesource.com/780723Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#518316}
-
Magnus Jedvert authored
The JNI generation script fails to understand enums as inner classes, leading to incorrect signatures for the generated JNI code. Bug: webrtc:8556 Change-Id: Ib088f3a0af1493247c991d5ee39de73da725f5e9 Reviewed-on: https://chromium-review.googlesource.com/779523Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Magnus Jedvert <magjed@chromium.org> Cr-Commit-Position: refs/heads/master@{#518315}
-
Tao Bai authored
Bug: 786420 Change-Id: Ida64aef0ecde9b093dab58bfa097b0779079e3c5 Reviewed-on: https://chromium-review.googlesource.com/780802 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#518314}
-
Daniel Bratell authored
There were two ImageDecodeTaskImpl classes in cc, one for the GPU image handling and one for the Software image handling they were small and slightly different so no reason trying to merge them Instead this renames them so that their names don't clash in jumbo builds where cc files are merged into large translation units. Bug: 786956 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I9e481a969d9a897665855f05a5dedbc86e194eb1 Reviewed-on: https://chromium-review.googlesource.com/779194Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#518313}
-
Andrew Grieve authored
Also updates templates for gradle plugin 3.0 and makes --split-project work again for Chromium codebase. Bug: 620034, webrtc:8547, 786676 Change-Id: I89e937ff8a70cf30f890765b98efa0d331fba77e Reviewed-on: https://chromium-review.googlesource.com/779499 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#518312}
-
Artur Khachatryan authored
Verion 63 is added Bug: Change-Id: I4a4c02193ff5ea10f448e7a6cee2793cacaa66e9 Reviewed-on: https://chromium-review.googlesource.com/780697Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Artur Khachatryan <khachatryan@chromium.org> Cr-Commit-Position: refs/heads/master@{#518311}
-
Luna Lu authored
The feature policy can be inspected via the following methods: allowsFeature(feature) -- whether or not |feature| is allowed on the origin of the document. allowsFeature(feature, origin) -- whether or not |feature| is allowed on the given origin. allowedFeatures() -- a list of features that are enabled on the origin of the document. getAllowlistForFeature(feature) -- a list of explicitly named origins where the given feature is enabled, or {'*'} if the feature is enabled on all origins. For more details, see the design doc at: https://docs.google.com/a/chromium.org/document/d/1wvk3cXkblNnbkMcsKayseK-k0SMGiP9b9fQFgfpqQpc/edit?usp=sharing Bug: 703703 Change-Id: I261f2251791ed18937d06c4eb24abf06676241cc Reviewed-on: https://chromium-review.googlesource.com/686036Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Luna Lu <loonybear@chromium.org> Cr-Commit-Position: refs/heads/master@{#518310}
-
Elly Fong-Jones authored
Bug: 610428 Change-Id: I314556a9c835606acc11b80da480971fe083b93c Reviewed-on: https://chromium-review.googlesource.com/757035Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#518309}
-
Sylvain Defresne authored
Convert PasswordController to directly track the registration with the observed WebState instead of relying on the deprecated code in WebStateObserverBridge. Bug: 775684 Change-Id: I227193a0a4040cff7a823c4e5926a3cad78650e6 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/778900 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#518308}
-
Koji Ishii authored
The size and offset of NGPhysicalTextFragment included the leadings from the 'line-height' property. The size of text boxes are not defined in the spec, but pre-NG InlineTextBox does not include it, and using the same offset and size helps sharing the logic with pre-NG. Bug: 636993 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I6fab82bf16e17da15306c14a04e690460a7f5712 Reviewed-on: https://chromium-review.googlesource.com/781482 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#518307}
-
Sidney San Martín authored
Bug: 783340 Change-Id: I4b34e9d98627f49412bba3251820fa38445c5e63 Reviewed-on: https://chromium-review.googlesource.com/762667Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#518306}
-
Peter Beverloo authored
This will significantly help reduce flakiness in testing (one deflake included in this CL), and is required for migrating Android's intent handling system to the BackgroundTaskScheduler which needs to know when handling of the event has finished. In addition, a hack where the NativeNotificationDisplayService invoked the Close() method on a notification's delegate in order to fire the event for non-persistent Web Notifications has been removed. We can just fire the event from the NotificationMessageFilter instead. BUG=766854, 784951 Change-Id: I57d0a446e6c47281bb7b5e001c449fadddeba571 Reviewed-on: https://chromium-review.googlesource.com/779722 Commit-Queue: Peter Beverloo <peter@chromium.org> Reviewed-by:
Anita Woodruff <awdf@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#518305}
-
Fady Samuel authored
This CL adds some trace events that debug surface sync performance issues and visualize synchronization of surfaces across multiple clients. Bug: 672962 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I87a1f1695bc3536160ca7d8f669bfae81ce200fb Reviewed-on: https://chromium-review.googlesource.com/782062Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#518304}
-
Benjamin C. Wiley Sittler authored
Bug: 661819 Change-Id: Id393c7dca3652884287d328c9aa76a4044b00f85 Reviewed-on: https://chromium-review.googlesource.com/780580Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Benjamin Wiley Sittler <bsittler@chromium.org> Cr-Commit-Position: refs/heads/master@{#518303}
-
angle-deps-roller@chromium.org authored
https://chromium.googlesource.com/angle/angle.git/+log/c7965001b32f..03fd0356b4c9 $ git log c7965001b..03fd0356b --date=short --no-merges --format='%ad %ae %s' 2017-11-20 jmadill D3D11: Push index range computation deeper. Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=fjhenigman@chromium.org Change-Id: Idc0816363d6f460832d652a4a295dd83b96adb5d Reviewed-on: https://chromium-review.googlesource.com/781241Reviewed-by:
angle-deps-roller . <angle-deps-roller@chromium.org> Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#518302}
-
Dmitry Gozman authored
To be used in WebViewImpl and WebFrameWidgetImpl, which currently implement it almost identically. This will also allow to call ComputeAbsoluteBounds from core/, reducing dependencies from core/ to core/exported. Bug: 629721 Change-Id: I6ad23dba7af2126d85f8a300deefb467d1dcd185 Reviewed-on: https://chromium-review.googlesource.com/779863Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#518301}
-
Daniel Bratell authored
Our JNI code generator generated a lot of Init(...) methods which collided in jumbo builds. This patch adds a class name prefix to them, and all other JNI methods, so that they have locally unique names. TBR=erikchen@chromium.org,fgorski@chromium.org,sergeyu@chromium.org,dtrainor@chromium.org,rouslan@chromium.org,vakh@chromium.org,rogerta@chromium.org,holte@chromium.org,bajones@chromium.org Bug: 779013 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.linux:linux_site_isolation;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I86b6ac83c8e0a3507bd1d0efc48d625c12b4bb2b Reviewed-on: https://chromium-review.googlesource.com/765973 Commit-Queue: Daniel Bratell <bratell@opera.com> Reviewed-by:
Daniel Bratell <bratell@opera.com> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#518300}
-
Hidehiko Abe authored
BUG=739118 TEST=Ran bots. Change-Id: Ic4c81c914974b8d860cc65bcbc6e5cc67695f3fe Reviewed-on: https://chromium-review.googlesource.com/768618Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#518299}
-
Yixin Wang authored
Flip recent QUIC flags https://chromium-review.googlesource.com/c/chromium/src/+/780809 Make some QuicConnection interfaces public. Turn on ACK decimation (ACKD, AKDU) for QUIC to backend which doesn't run any production traffic yet. Merge internal change: 175889473 https://chromium-review.googlesource.com/c/780583/ Add smoothed rtt to QUIC metrics reported through Quartc. //gfe/quic/quartc reports the rtt alongside bandwidth estimate. Quartc connection periodically scrapes QUIC stats and reports them to the brain. The brain adds QUIC stats to the Quartc metrics structure, which is exported through the api. The Quartc brain also shares QUIC's rtt stat through the NetworkBrainMessage. Changes the Metrics structure returned by the Quartc API to split out QUIC metrics as described in this doc: https://docs.google.com/document/d/11ltkz_-hGGpx0PcteR61zptrBDZ3tMvAWjrqj-XRnNo/edit# This is the first bit of metrics improvement. Fields for media streams will be added next to "quic" as described there. n/a (only changes code used for Quartc) TAG_CHANGE_OK=quartc has not been deployed WANT_LGTM=kirpichov Merge internal change: 175600126 R=rch@chromium.org https: //chromium-review.googlesource.com/c/780268/ Change-Id: I94ae180bd21ac5da93621c63d2ee2265d820addf Reviewed-on: https://chromium-review.googlesource.com/780811Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Yixin Wang <wangyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#518298}
-
Mathieu Perreault authored
Was using hardcoded locale. Bug: None Test: existing Change-Id: I9a86d2acccd0821c7e734661df2c95953f043951 Reviewed-on: https://chromium-review.googlesource.com/781404Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#518297}
-
Eugene Ostroukhov authored
Bug: 783113 Change-Id: I8fa7f12d8908615ea9b5bdc0bc3baba646ccec04 Reviewed-on: https://chromium-review.googlesource.com/778047 Commit-Queue: Eugene Ostroukhov <eostroukhov@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#518296}
-
Rintaro Kuroiwa authored
- C++ version of the CdmProxy interface. Bug: 785563 Change-Id: I64ca5f478c19505361eb7f7eedde3f5c208db488 Reviewed-on: https://chromium-review.googlesource.com/773567 Commit-Queue: Rintaro Kuroiwa <rkuroiwa@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#518295}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/202be3957d95..ed1023db0eb8 $ git log 202be3957..ed1023db0 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I660131e50f90463ee04ddd62292b7858525a8b03 Reviewed-on: https://chromium-review.googlesource.com/781366Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#518294}
-
Tibor Goldschwendt authored
Bug: 773256 Change-Id: I0991b5c525420384ec422d23ae7b9f6af35e7787 Reviewed-on: https://chromium-review.googlesource.com/782159Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#518293}
-
Christopher Grant authored
The testapp window now has the proper aspect ratio, initially and after resizing the window. BUG= Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ie83f6fc769da7c44d9e9b140743645532d8f3192 Reviewed-on: https://chromium-review.googlesource.com/782061 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#518292}
-
Randy Smith authored
Bug: 785420 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I84bf1a42081c4890f8641a56a9cdb87404e25f67 Reviewed-on: https://chromium-review.googlesource.com/772938Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Randy Smith <rdsmith@chromium.org> Cr-Commit-Position: refs/heads/master@{#518291}
-
Bence Béky authored
|last_activity_time_| is used to determine if a PING should be sent out on an HTTP/2 connection. The relevant measurement for this is the time of the last read. If |last_activity_time_| is also updated on writes, then it is possible that a connection times out but SpdySession is not sending any PING frames to check for this for a very long time. This CL removes the |last_activity_time_| update from SpdySession::DoWriteComplete(), and renames |last_activity_time_| to |last_read_time_| to better express its function. Bug: 784975 Change-Id: I821cc5145f44557dd3f694833314336bb21f9608 Reviewed-on: https://chromium-review.googlesource.com/779740Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#518290}
-
Emircan Uysaler authored
This is a followup to https://webrtc-review.googlesource.com/c/src/+/21130. Since we have alpha containers for WebRTC now, we no longer need to drop the alpha planes before sending captured frames. BUG=webrtc:7671 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ida2ad85770ba42889582fccffc1e52ec2c100057 Reviewed-on: https://chromium-review.googlesource.com/768308 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Cr-Commit-Position: refs/heads/master@{#518289}
-
danakj authored
Instead of TextureMailbox, which it converts, it can take a TransferableResource directly. This leaves TextureMailbox as only used for Gpu-backed CopyOutputResults. Code that uses that as an input for ui::Layer does the conversion itself for now. R=piman@chromium.org TBR=reveman@chromium.org Bug: 769423 Change-Id: Id4ab7462d7f7c98dd834f746605e520be23696e7 Reviewed-on: https://chromium-review.googlesource.com/780241Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#518288}
-
jdoerrie authored
This change replaces remaining usages of base::Value::GetType() with base::Value::type() and removes the deprecated method entirely. Bug: 646113 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I412454d05f56d94125a76e06a09990e2d6a424e9 Reviewed-on: https://chromium-review.googlesource.com/718458Reviewed-by:
Brett Wilson <brettw@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#518287}
-
Evan Stade authored
Remove a lot of utf conversions. Bug: none Change-Id: I6275609fd29da15aa10d6c1f38bb8fc9af4e0239 Reviewed-on: https://chromium-review.googlesource.com/780375 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#518286}
-
Jonathan authored
PreferencesTest.MultiProfiles is flaking both on ChromeOS as well as with mash. This change disables the test everywhere until the flake can be resolved. This also reverts having the test filtered out for mash. TBR=jamescook@chromium.org TEST=PreferencesTest,MultiProfiles Bug: 787050 Change-Id: Iaa651e1dd23b836f6d8354fbe9e9d2834f855e0b Reviewed-on: https://chromium-review.googlesource.com/782041Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#518285}
-
Sylvain Defresne authored
Convert FormInputAccessoryViewController to directly track the registration with the observed WebState instead of relying on the deprecated code in WebStateObserverBridge. Bug: 775684 Change-Id: Ic880d84c8e0ede5ec1abe06336a47eeee36e05f7 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/778980Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#518284}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/cd23cae9..c11c947e Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Ifa9b818c5fdc0d5b46c58374746adf4980f7e0d4 Reviewed-on: https://chromium-review.googlesource.com/781402Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#518283}
-
Jonathan authored
Enable more oopif tests on viz_content_browsertests. First on the FYI to check for flakes TBR=kylechar@chromium.org TEST=viz_content_browsertests Bug: 760181 Change-Id: Ib8ce31aee9a93910a0fe0023b920ef15f057c0ea Reviewed-on: https://chromium-review.googlesource.com/781405Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#518282}
-
Christian Dullweber authored
Add an empty method for consent recording to define the api. Bug: 781765 Change-Id: I36663814a004ad07015218797683f78519606e37 Reviewed-on: https://chromium-review.googlesource.com/781500Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#518281}
-
Elly Fong-Jones authored
This change: 1) Corrects an insidious bug where TreeView::InternalNode::GetMaxWidth would pass the InternalNode* as the node instead of the model node, which would cause crashes at call sites when attempting to cast it back to the model node type and use it. This avoided the type system's notice because InternalNode is a subclass of ui::TreeModelNode. Ow. 2) Computes the foreground bounds properly for a node whose icon is hidden, so that the selection foreground is drawn only where the text is. 3) Repaints the entire node's bounds when repainting a node, not just its background, since if the node is being repainted, its bounds may also have changed - e.g., if it had its icon shown before and hidden now. In that case, simply repainting inside the new bounds is not sufficient, because the old bounds may have been greater. Bug: 610428 Change-Id: I0bce687b80248601259aa243d38230b615a8974c Reviewed-on: https://chromium-review.googlesource.com/756857Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#518280}
-