GitLab

This reverts commit 10306935.

Reason for revert: Undoing speculative revert
The CL was not the culprit

Original change's description:
> Revert "Files app: Select My files when there are no volumes"
> 
> This reverts commit 6f65bd26.
> 
> Reason for revert: Speculative revert
> Suspected of breaking browser_tests, ebui_polymer2_browser_tests, single_process_mash_browser_tests and viz_browser_tests
> on Linux ChromiumOS MSan
> 
> Note: resolved conflicts with ES6 refactoring, therefore running tests...
> 
> Bug: 896219
> 
> Original change's description:
> > Files app: Select My files when there are no volumes
> >
> > Make Files app select "My files" when there are no available volumes,
> > this to allow Files app to behave properly when volumes subsequently
> > become available.
> >
> > Change DirectoryModel.onVolumeInfoListUpdated_ method to check for
> > non-null |displayRoot| before trying to change to |displayRoot|. This
> > fixes the error "Cannot read property 'getParent' of null" when Drive
> > volume becomes available before the (default) Downloads volume/root.
> >
> > Change FakeDriveFs to unbind the two mojo bindings if they're bound, so
> > DriveFsTestVolume can re-mount itself.
> >
> > Changes since revert:
> > 1. Add a new function |getVolumesCount| to return the number of volumes
> > available in the background page.
> > 2. Add the new function above to wait for background page to have all
> > volumes before un-mounting and wait it to unmount all volumes.
> > 3. Change some logs from error to warn because errors are expected and
> > handled when initializing volumes that are unmounting/unmounted in the
> > backend.
> > 4. Change selector used to click on Drive to actually wait for
> > "My Drive" to be available.
> > 5. A bit of more info in some logs around volume initialization.
> >
> > Test: browser_tests --gtest_filter="*/fileDisplayWithoutVolumesThenMount*"
> > Bug: 893161, 884967, 894799
> > Change-Id: I7dcb340991750e9e79a9963990b614c6d7275890
> > Reviewed-on: https://chromium-review.googlesource.com/c/1278619
> > Reviewed-by: Noel Gordon <noel@chromium.org>
> > Reviewed-by: Sam McNally <sammc@chromium.org>
> > Commit-Queue: Luciano Pacheco <lucmult@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#600282}
> 
> TBR=noel@chromium.org,sammc@chromium.org,lucmult@chromium.org
> 
> Change-Id: Ifaadea8b49cffc6deb70b429a42bab39d4a3d52b
> Bug: 893161, 884967, 894799
> Reviewed-on: https://chromium-review.googlesource.com/c/1286146
> Commit-Queue: Christos Froussios <cfroussios@chromium.org>
> Reviewed-by: Christos Froussios <cfroussios@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600376}

TBR=noel@chromium.org,sammc@chromium.org,cfroussios@chromium.org,lucmult@chromium.org

Change-Id: I388a94fe12c7d40ac7ea779353c3b220bd5b5952
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 896219, 893161, 884967, 894799
Reviewed-on: https://chromium-review.googlesource.com/c/1286853Reviewed-by: Christos Froussios <cfroussios@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600429}

Bug: 885244,893396
Change-Id: I4ab6c6890af83483514edd41f1e7d2aeb38e4a4a
Reviewed-on: https://chromium-review.googlesource.com/c/1286814Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600428}

The button itself was implemented by http://crrev.com/c2cff202 and this
patch implementes the implementation to show the settings page.

Bug: 864964
Test: manual
Change-Id: Iabe8ab1c20b66ee8b2f6f3161a9587f195236c70
Reviewed-on: https://chromium-review.googlesource.com/c/1258667
Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org>
Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600427}

This CL sorts returned devices from most-recently-updated to
least-recently-updated. This increases the likelihood that users who go
through multi-device setup will set up the correct device, since usually
the most-recently-updated the device is the one that users want to set.

Bug: 870133
Change-Id: I954f3bde8ccb62c1f796ec62e8f12af65012e528
Reviewed-on: https://chromium-review.googlesource.com/c/1285769Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600426}

Bug: 889968
Change-Id: I12721e9cbe57b6967f662888ba400c2ee4076590
Reviewed-on: https://chromium-review.googlesource.com/c/1259962
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600425}

Extracts the NTP tiles into UIView subclasses that can be used outside
of the NTP-related collection views.

Bug: none
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I534e54f5bdf23592d43baa035a14327563ee7751
Reviewed-on: https://chromium-review.googlesource.com/c/1278985Reviewed-by: Mark Cogan <marq@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600424}

TBR=rouslan@chromium.org
BUG=894011

Change-Id: Ieb61e2077df2faf9d2054a9a0da87d354a59a7b9
Reviewed-on: https://chromium-review.googlesource.com/c/1286881Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600423}

Despite existing undefs, windowsx.h macros cause troubles with
some jumbo builds. We can add more undefs, or we can change
approach to this, a windowsx_shim.h that solves the same
problem at one place instead of many.

The macros that have caused the most problems are IsMaximized,
IsMinimized and IsRestored which are common names to use in
code that manages windows.

Change-Id: Ib5f429aaeca4c35962c17a9973274e486b510c2f
Reviewed-on: https://chromium-review.googlesource.com/c/1280429Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#600422}

EnsureComputedStyle() is for forcing a ComputedStyle on display:none
elements and should only be called when style is clean. Use
GetComputedStyle() instead. I'm not even sure if GetComputedStyle() can
ever be null here.

Bug: 895894
Change-Id: I4e5bc12a52464ec74a9d9d5e85d4f9900ce9ef4f
Reviewed-on: https://chromium-review.googlesource.com/c/1286137Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600421}

It's a bit redundant to have a helper class to simply observe
the app and intent helper connections.

BUG=b:111367421
TEST=Bluetooth works

Change-Id: Ice714e43331c7590f8c08fd8ddaa59fbc31ec3e0
Reviewed-on: https://chromium-review.googlesource.com/c/1285087Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Yury Khmel <khmel@chromium.org>
Commit-Queue: Qiyu Hu <qiyuh@google.com>
Cr-Commit-Position: refs/heads/master@{#600420}

https://android.googlesource.com/platform/external/perfetto.git/+log/5146376782a1..383ad4fa29d6


git log 5146376782a1..383ad4fa29d6 --date=short --no-merges --format='%ad %ae %s'
2018-10-17 hjd@google.com Merge "perfetto-ui: Add border to bottom of pinned tracks"


Created with:
  gclient setdep -r src/third_party/perfetto@383ad4fa29d6

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: I735bfc9044d5b626833ac8301598bd2c436ad26c
Reviewed-on: https://chromium-review.googlesource.com/c/1286695Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600419}

The file void_callback.h has never existed but there was
a VoidCallback.h in third_party/WebKit until February this year
when it was deleted in a cleanup.

This might have triggered isolate step errors on trybots.

Bug: 778580

Change-Id: I659c7ec456a8c21a274d1743d701061c798c7ace
Reviewed-on: https://chromium-review.googlesource.com/c/1286811Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#600418}

Bug: 896249
Change-Id: Ie4b516c8d8d338b82b0c6b4232999b8d314ee3d4
Reviewed-on: https://chromium-review.googlesource.com/c/1286773Reviewed-by: Majid Valipour <majidvp@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600417}

This will be used to migrate AuthService to the Identity service, which
currently relies on OAuth2TokenService::StartRequestWithContext() for that.

Also, add a new unit tests to use the new constructor passing an unmodified
testing SharedURLLoaderFactory instead of relying on the production one.

Bug: 883655
Change-Id: Ib891b33dbe3ab3aa83e4456d9cabed4f6b26c4f4
Reviewed-on: https://chromium-review.googlesource.com/c/1280553
Commit-Queue: Mario Sanchez Prada <mario@igalia.com>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600416}

For many fullscreen cases, the rest of the renderpass quads are solid
black quads. In that case, we can turn off the primary plane, and not
having to scan out an full screen of black pixels saves a good deal of
power. In other cases, we can crop down the primary plane down to the
content rectangle (youtube channel logo, for example) and save power.

Averaging battery draw measurement over about a minute of play back
for a fullscreen youtube video, power savings for soraka is around
500mW (6.5W to 6.0W) and 300mW for kevin (4.4W to 4.1W), when we
turn off the primary plane.

Change-Id: I7946d7acab334bffdf2bb49a1d9c424cf46fc610
Reviewed-on: https://chromium-review.googlesource.com/c/1045256Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Dongseong Hwang <dongseong.hwang@intel.com>
Commit-Queue: Kristian H. Kristensen <hoegsberg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600415}

Using wpt-import in Chromium 6aadaadb.

Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26353

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

NOAUTOREVERT=true
TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Change-Id: I4e2c8fdb1c7055d82b6e21b5084684e7c2460a29
Reviewed-on: https://chromium-review.googlesource.com/c/1286690
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600414}

Bug: 896201
Change-Id: I107f2ec40f1bd0ed2e33799afb4f33707caa86f4
Reviewed-on: https://chromium-review.googlesource.com/c/1286654
Commit-Queue: Peter Conn <peconn@chromium.org>
Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600413}

This CL addresses the remaining issues with Android touch selection
handles. First, it removes the manual scaling done by the child frame
client for the device scale factor; apparently this is now handled by
the point-transform functions. Second, it makes sure the child frame's
handles update during pinch just like the main frame's handles do.

Because a child frame's handles are not locked to a surface like the
main frame's handles, there is a small amount of jitter/lag when
pinching or scrolling the main-frame, but not enough to impair
functionality.

Note this CL also resolves the issues for desktop handles not updating
after pinch as well.

Bug: 809122
Change-Id: I120386c3d7a0d87dacc655e83b07e0cfeaf4920a
Reviewed-on: https://chromium-review.googlesource.com/c/1259945
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600412}

Change-Id: Ia414bb22cb304d3701dd7c3191376ffe05651088
Reviewed-on: https://chromium-review.googlesource.com/c/1286869Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600411}

That class didn't work with networking running out-of-process. Convert similar to r571184.

Bug: 881976
Change-Id: If38e590e58ba6fb86921e606b87b1eb603e4a128
Reviewed-on: https://chromium-review.googlesource.com/c/1279960Reviewed-by: Yury Khmel <khmel@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600410}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/15255d3e71b1..ce15ef5cc47b


Created with:
  gclient setdep -r src-internal@ce15ef5cc47b

The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:895495
TBR=mmoss@chromium.org

Change-Id: Ic3d274c3e9081e1266dabb3d857e5c59318b15f2
Reviewed-on: https://chromium-review.googlesource.com/c/1286051Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600409}

Users of Chromevox may need to touch explore the webpage, and for
things to remain consistent, we should disable hiding top-chrome
with gesture scrolls as long as Chromevox is enabled.

BUG=857331
TEST=Added a new browser test.

Change-Id: Ic70ebcad475ea7885ea3b6bd826b9b1f08f03e1b
Reviewed-on: https://chromium-review.googlesource.com/c/1284289Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600408}

This should make mojofying MidiHost and MidiMessageFilter easier.

Bug: 582328
Change-Id: I4dfcdb990cd938a63ec99f238020bc6ba325350f
Reviewed-on: https://chromium-review.googlesource.com/c/1244601Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Adithya Srinivasan <adithyas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600407}

This is a reland of bb70008e

Original change's description:
> [Autofill Assistant] Add ShowProgressBar action.
> 
> Screenshot: https://screenshot.googleplex.com/chZ1byvKBqa.png
> 
> Bug: 806868
> Change-Id: Ib7714b1b554d030c461614bcd51cc30156cac594
> Reviewed-on: https://chromium-review.googlesource.com/c/1278808
> Reviewed-by: Theresa <twellington@chromium.org>
> Reviewed-by: Ganggui Tang <gogerald@chromium.org>
> Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#600015}

Bug: 806868
Change-Id: Ieb4d6c6305a155985fb3eabf80763d6d2e1b491d
Reviewed-on: https://chromium-review.googlesource.com/c/1284929Reviewed-by: Theresa <twellington@chromium.org>
Reviewed-by: Ganggui Tang <gogerald@chromium.org>
Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600406}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/a63809a3..db22e96f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I570b3d36e3e84c8108986433655972ed6466ca21
Reviewed-on: https://chromium-review.googlesource.com/c/1286439Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600405}

R=eae@chromium.org

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I8fa58c33fc9fab68edac7c8159254bfd8389560f
Reviewed-on: https://chromium-review.googlesource.com/c/1285313
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600404}

ios12-beta-simulator
ios12-sdk-device
ios12-sdk-simulator

Bug: 895976
Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I48d0050afbe589bf5b2a9d02a4987f7bc244eb15
Reviewed-on: https://chromium-review.googlesource.com/c/1284732Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600403}

This is a reland of 01e91776 with a fix
for crbug/895206.

Original change's description:
> [bundles] Add getter for whether build is a bundle, activate O split fix
>
> Add BundleUtils class, which has a method to check whether current build
> is a bundle. Use that getter to activate split APK - WebView workaround
> for Android O.
>
> Bug: 889954
> Change-Id: I443584edf8bd55a6c7e2b5d0664dc943466159d4
> Reviewed-on: https://chromium-review.googlesource.com/c/1261969
> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
> Reviewed-by: Richard Coles <torne@chromium.org>
> Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#599509}

TBR=torne@chromium.org

Bug: 889954
Change-Id: If7cd717029bd8243d19ec212361e505340c3ce2d
Reviewed-on: https://chromium-review.googlesource.com/c/1286420Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600402}

This CL creates a feature experiment that removes blocking worker pools
from the task scheduler. Tasks with MayBlock trait are instead posted to
the usual foreground/background pool, giving us better control over scheduling.

Note: ScopedBlockingCall is used to add extra workers to the pool when a task is
blocking. In this CL, we take advantage of this behavior to make sure enough
workers are running on the CPU.

Bug: 874080
Change-Id: I7889a941f82203388c259b0d96073eb5ddf3de69
Reviewed-on: https://chromium-review.googlesource.com/c/1249836
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Robert Kaplow (sloooow) <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600401}

https://skia.googlesource.com/skia.git/+log/0b8fcbcfa3d5..7bae65d0070c


git log 0b8fcbcfa3d5..7bae65d0070c --date=short --no-merges --format='%ad %ae %s'
2018-10-17 caryclark@skia.org fix bookmaker
2018-10-17 kjlubick@google.com Revert "Re-enable NVPR on flutter."
2018-10-17 bsalomon@google.com Some cleanup of GrSwizzle
2018-10-17 brianosman@google.com Revert "Remove SK_LEGACY_XFORM_CANVAS_IN_PICTURE_IMAGES"
2018-10-17 kjlubick@google.com [canvaskit] POC working on Node.js
2018-10-17 caryclark@skia.org remove pathop template


Created with:
  gclient setdep -r src/third_party/skia@7bae65d0070c

The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
TBR=egdaniel@chromium.org

Change-Id: I38da00e4418437853b657d55691144f102792120
Reviewed-on: https://chromium-review.googlesource.com/c/1286271Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600400}

TBR=smut

Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs
Change-Id: I2cabb859e83add6f24525bf8bde46cd9516a0c1a
Reviewed-on: https://chromium-review.googlesource.com/c/1286729
Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org>
Reviewed-by: iOS Autoroller <ios-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600399}

The flag was added more than 5 years ago in
https://chromium.googlesource.com/chromium/src/+/8338eeabe776455a934ccf099cac7bd87fa57588

But current clang does not enable the warning by default.
ref: http://llvm.org/viewvc/llvm-project?view=revision&revision=150055

Change-Id: I7580d77954f2a9cdef047af6b181d35ee6721a9e
Reviewed-on: https://chromium-review.googlesource.com/c/1286609
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600398}

https://android.googlesource.com/platform/external/perfetto.git/+log/91f54792a979..5146376782a1


git log 91f54792a979..5146376782a1 --date=short --no-merges --format='%ad %ae %s'
2018-10-17 hjd@google.com Merge "perfetto-ui: Fix doubled tracks when reloading from permalinks"
2018-10-17 hjd@google.com Merge "perfetto-ui: Record page improvements"


Created with:
  gclient setdep -r src/third_party/perfetto@5146376782a1

The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=perfetto-bugs@google.com

Change-Id: Ide01097024bcabaac41c851f5fc1b8633c34d729
Reviewed-on: https://chromium-review.googlesource.com/c/1286473Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600397}

Bug: 891908
Change-Id: I56c0feb3b4a92232a93271f8097fc56e5703e1b6
Reviewed-on: https://chromium-review.googlesource.com/c/1286292Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600396}

Add test variants to ensure that various storage types are deleted
via the browsing data remover code in Incognito sessions.

Bug: 876659
Change-Id: Iad59adf8e7b07e2261257f2fbbfb43b3e31c5851
Reviewed-on: https://chromium-review.googlesource.com/c/1285071Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Joshua Bell <jsbell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600395}

This makes it easier to attach state to an individual event being processed.

BUG=891489
TEST=covered by tests

Change-Id: I50f70567d195c60187c9c8e8a2a68255c4c47f08
Reviewed-on: https://chromium-review.googlesource.com/c/1282031Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600394}

This CL is adding a metric to collect metric on the fallback fonts issue.

Slow-reports show that many bad cases (99th percentile) of different
heartbeat metrics are affected by:

  gfx::GetFallbackFonts(gfx::Font const &)
  gfx::RenderTextHarfBuzz::ShapeRuns(std::basic_string<wchar_t,std::char_traits<wchar_t>,std::allocator<wchar_t> > const &,gfx::internal::TextRunHarfBuzz::FontParams const &,std::vector<gfx::internal::TextRunHarfBuzz *,std::allocator<gfx::internal::TextRunHarfBuzz *> >)
  gfx::RenderTextHarfBuzz::ItemizeAndShapeText(std::basic_string<wchar_t,std::char_traits<wchar_t>,std::allocator<wchar_t> > const &,gfx::internal::TextRunList *)
  gfx::RenderTextHarfBuzz::EnsureLayoutRunList()

This UMA metric will help us to estimate the size of the population
affected by this scenario.

R=fdoray@chromium.org, holte@chromium.org, ccameron@chromium.org

Bug: 894459
Change-Id: Ic0d1fac1f69a329bf11544f49e34c91635046331
Reviewed-on: https://chromium-review.googlesource.com/c/1281227Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Reviewed-by: ccameron <ccameron@chromium.org>
Commit-Queue: Etienne Bergeron <etienneb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600393}

This CL uses ScopedBlockingCall to mark blocking calls in /chrome/browser/extensions/api.

This CL was created by replacing calls to AssertBlockingAllowed()
with instantiations of ScopedBlockingCall(MAY_BLOCK).
I kindly ask the reviewer to make sure of the following:
  - ScopedBlockingCall is instantiated in a scope with minimal CPU usage.
    If this is not the case, ScopedBlockingCall should be instantiated
    closer to the blocking call. See scoped_blocking_call.h for more
    info. Please let me know when/where the blocking call happens if this needs
    to be changed.
  - Parameter |blocking_type| matches expectation:
      MAY_BLOCK: The call might block (e.g. file I/O that might hit in memory cache).
      WILL_BLOCK: The call will definitely block (e.g. cache already checked and now pinging
        server synchronously).
    See BlockingType for more info. While I assumed MAY_BLOCK by default, that might
    not be the best fit if we know that this callsite is guaranteed to block.
  - The ScopedBlockingCall's scope covers the entirety of the blocking operation
    previously asserted against by the AssertBlockingAllowed().

This CL was uploaded by git cl split.

R=tbarzic@chromium.org

Bug: 874080
Change-Id: I2d289daff2684837a6be032e5ca1e5acf37ad3cf
Reviewed-on: https://chromium-review.googlesource.com/c/1194105
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600392}

https://webrtc.googlesource.com/src.git/+log/4744e5b896a5..5a464d3ee56a


git log 4744e5b896a5..5a464d3ee56a --date=short --no-merges --format='%ad %ae %s'
2018-10-17 danilchap@webrtc.org Add resolution to generic frame descriptor extension


Created with:
  gclient setdep -r src/third_party/webrtc@5a464d3ee56a

The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng

BUG=chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I289152f6b317197a530715de3ffab0fccb01a998
Reviewed-on: https://chromium-review.googlesource.com/c/1286215Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#600391}

This resolves a 7-year-old TODO in sync_prefs.h :)

Bug: none
Change-Id: I5d337ee116e8fbce60758b0c23fdd70be19a8d60
Reviewed-on: https://chromium-review.googlesource.com/c/1286417
Commit-Queue: Marc Treib <treib@chromium.org>
Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Cr-Commit-Position: refs/heads/master@{#600390}