- 19 Oct, 2017 40 commits
-
-
Yoland Yan authored
Bug: 640116 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I58306d25a385a75275bb06d1c2bea45160823b17 Reviewed-on: https://chromium-review.googlesource.com/722072Reviewed-by:
Yash Malik <ymalik@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Yoland Yan <yolandyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#510106}
-
John Heroy authored
This change ensures that the ARC user preference for SMS Connect is false if the feature flag is disabled, and the user-set preference (default: true) when the feature flag is enabled. Bug: 718617 Change-Id: I8389cf0082b29c3356d760acf44c83d8b8cf0848 Reviewed-on: https://chromium-review.googlesource.com/726322Reviewed-by:
David Jacobo <djacobo@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: John Heroy <jheroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#510105}
-
Xianzhu Wang authored
The test was broken because of changed layer tree dump format. Updated according to the current format and composited scrolling behavior. Bug: 639427 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Icc051f653baca28de6e4c4094525bd4efd4eb2de Reviewed-on: https://chromium-review.googlesource.com/726974Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#510104}
-
tzik authored
WTF::RefPtr used to have a scoped_refptr, but RefPtr is an alias of scoped_refptr now. This updates the member access in the pretty printer to fix the WTF::String printing. Also, this CL drops OwnPtr and RefPtr pretty printer that are no longer needed. Bug: 763844 Change-Id: Ifb9418d6f5487a4ebc97c2c7b6c0b563746299a7 Reviewed-on: https://chromium-review.googlesource.com/727781Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#510103}
-
Yi Gu authored
We do not need the feature any more since the experiment of not compositing small scrollers is done. See crbug.com/684631. Bug: 775643 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I9f0d6c82ffd4d3813630b74ed20f4d44d7fd166f Reviewed-on: https://chromium-review.googlesource.com/723982Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#510102}
-
Eugene But authored
On iOS 11 WKWebView does not repaint after crash and reload. Recreating web view fixes the issue. It seems like the problem is not reproducible if web view scroll view remain in the default position, but it's impossible to check if web view was scrolled once the renderer has crashed. Recreating web view should not have visible performance implications, so it will be more reliable to purge it unconditionally if renderer has crashed. Bug: 770914 Change-Id: I84feede9e54e4371aaf36b47db0fc9878e7518a9 Reviewed-on: https://chromium-review.googlesource.com/727401 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#510101}
-
Sylvain Defresne authored
Bug: 760556 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5a892956e3b3247d1c01d42f1c6a04bb4a9ec8b1 Reviewed-on: https://chromium-review.googlesource.com/727023Reviewed-by:
Rohit Rao (ping after 24h) <rohitrao@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#510100}
-
Sylvain Defresne authored
Inspecting the code revealed that ContextualSearchController -panel property was never set, and that the delegate passed to initializer was always a mock with no method mocked. It follows that _panelView, _searchResultView and _headerView are always nil, and the delegate method always returned default value and were doing nothing. Remove all code that can be proved to be dead based on those observation and the fact that calling a method on nil received does nothing and return the default value for the method selector. Bug: 775332 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I9fbd18c97e1f19f91384bb54d3102e2509f4ccb0 Reviewed-on: https://chromium-review.googlesource.com/727472Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#510099}
-
Ahmed Fakhry authored
The spec suggests showing a broken image icon when and <img> element has an alt text attribute but no src attribute. To avoid this, we set the alt text only when we set the src of the img element. BUG=773985 TEST=manual Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I3884e736a8a7b0e3fa40ea483882d20916a81a00 Reviewed-on: https://chromium-review.googlesource.com/727107Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#510098}
-
Olivier Robin authored
IsLabelValid checks if an inferred label is valid or not. A valid label does not contain only special characters. Special characters are " *:-()\u2013" as defined in FormOrFieldsetsToFormData in form_autofill_util.cc. Bug: 762970 Change-Id: Id44b9efc2500de638c54336ac589c68127d33be9 Reviewed-on: https://chromium-review.googlesource.com/722699 Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#510097}
-
John Budorick authored
Bug: 775895 Change-Id: I1c1c59425bea8a8690b8e8706a4e0c7ce96033bf Reviewed-on: https://chromium-review.googlesource.com/727196Reviewed-by:
Yoland Yan <yolandyan@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#510096}
-
Mattias Nissler authored
This is so translators know the term TPM should not be translated. BUG=b:67662440 TEST=None Change-Id: I8b41f440866db2a5a53a310d41cf4d63360bb979 Reviewed-on: https://chromium-review.googlesource.com/720806Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Mattias Nissler <mnissler@chromium.org> Cr-Commit-Position: refs/heads/master@{#510095}
-
Ella Ge authored
Use float coordinates conversion and remove truncation in render host. This CL doesn't expose the fractions to the web because of truncation in later stages in event pipeline. Bug: 456625 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: I30803bf5eab3b0fbe71abef6eaaf16a468770f15 Reviewed-on: https://chromium-review.googlesource.com/692175 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#510094}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/6fb802e2b2e3..0341f160befa $ git log 6fb802e2b..0341f160b --date=short --no-merges --format='%ad %ae %s' 2017-10-18 mtklein replace gInited with SkOnce Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=benjaminwagner@chromium.org Change-Id: Ie7fd1b983ecb29a6145c7ab5d489dce05de231b1 Reviewed-on: https://chromium-review.googlesource.com/728201Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#510093}
-
Jonathon Kereliuk authored
No functionality change, but commands are ordered as they appear in spec followed by the commands only in the JSON wire protocol, then the ChromeDriver only commands Bug: Change-Id: Ib0dbd5775cf91979603e66a0bcb3669a7d4cca51 Reviewed-on: https://chromium-review.googlesource.com/717026 Commit-Queue: Jonathon Kereliuk <kereliuk@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#510092}
-
Maxim Kolosovskiy authored
In case of long username, the beginning of value should be visible. Bug: 770055 Change-Id: I09423d0131e7198de69211a020e38eaff2b7c503 Reviewed-on: https://chromium-review.googlesource.com/728099Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#510091}
-
Dan Elphick authored
Pass through the Abort message to the DownloadService for any outstanding downloads matching the given job_unique_id. Update abort unit tests to verify that the download successful messages do not get delivered. Change-Id: I600a3f102047939d7189dc6d30e9ca88eedf4c04 Bug: 758562 Reviewed-on: https://chromium-review.googlesource.com/723321Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
John Mellor <johnme@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#510090}
-
Olivier Robin authored
It is based on the logic in string16 InferLabelFromValueAttr(const WebFormControlElement& element) in chromium/src/components/autofill/content/renderer/form_autofill_util.cc. Bug: 762970 Change-Id: I5f0c2963111289cf5f043415176624644c58938b Reviewed-on: https://chromium-review.googlesource.com/721699Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#510089}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/117c48291cbf..bd83b914c352 $ git log 117c48291..bd83b914c --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I893e6fa091b27d5437f703590c07f50a4e5a7367 Reviewed-on: https://chromium-review.googlesource.com/728200Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#510088}
-
kylechar authored
With --enable-viz the host portion of the renderer cannot access FrameSinkManagerImpl or create CompositorFrameSinkSupports. Update so that viz doesn't immediately crash. The --enable-viz flag should work for basic websites on Linux desktop Chrome now. OOPIF and PDF Viewer are not implemented however. Bug: 770833, 732903 Change-Id: I373e02a221361b362f0eb35cc91d7d1a6b7c73a5 Reviewed-on: https://chromium-review.googlesource.com/724222 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#510087}
-
Jonathan Metzman authored
Bug: 776125 Change-Id: I4f5e788dccd9aca77ad58c45db75027f5288a629 Reviewed-on: https://chromium-review.googlesource.com/727075 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#510086}
-
Elly Fong-Jones authored
This change: 1) Migrates the existing long title strings to corresponding message strings 2) Adds new short title strings 3) Adds titlecase variants for titles that did not previously have them Bug: 700196 Change-Id: I2f1373fabeeb4e9ad946374c2f00a3fe46904ccf Reviewed-on: https://chromium-review.googlesource.com/723939 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Adrienne Porter Felt <felt@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Cr-Commit-Position: refs/heads/master@{#510085}
-
Marja Hölttä authored
- Add modules. - Misc additions to the dictionary (based on the coverage report). - Pass the command line flags to V8 (for debugging purposes). Bug: Change-Id: Ic0777906cbfd86f1c551df33b7af95e0a5a26b0f Reviewed-on: https://chromium-review.googlesource.com/727806Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Commit-Queue: Marja Hölttä <marja@chromium.org> Cr-Commit-Position: refs/heads/master@{#510084}
-
Gauthier Ambard authored
The content of the toolbar needs to respect the safe area. This CL fixes the content displayed outside of the safe area by creating a contentView respecting the safe area boundaries. The content is added to this view instead of the ToolbarView. This also makes the back menu dropdown to be displayed inside the safe area. It also dismisses it during device rotation. Bug: 765304, 776340, 764877 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia4f5b8499644b0b406a94a723bde1a6d80928cd0 Reviewed-on: https://chromium-review.googlesource.com/727890 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao (ping after 24h) <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#510083}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/b9501ea73c6c..2713d6d5f30d $ git log b9501ea73..2713d6d5f --date=short --no-merges --format='%ad %ae %s' 2017-10-19 perezju [Telemetry] Log output from commands sent to TsProxy Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ic95fe55ccdd85c97bf7b59b0f63c79bb0d98bd76 Reviewed-on: https://chromium-review.googlesource.com/726827 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#510082}
-
Daniel Vogelheim authored
This mirrors the existing Blink feature flag, in order to support runtime experiments with this feature. Bug: 557466 Change-Id: Ifa74a5ac15b35474bda14abca9aea40755f48c5c Reviewed-on: https://chromium-review.googlesource.com/642966 Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#510081}
-
Gauthier Ambard authored
The pages returning a 404 http status should not be displayed as Most Visited tiles on the NTP. This CL fixes it by checking the status code. Bug: 773792 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5381a36bc66b675acc4bc3a9b2fa703dc8d6f0ee Reviewed-on: https://chromium-review.googlesource.com/725294 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Rohit Rao (ping after 24h) <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#510080}
-
Olivier Robin authored
Add a timer to let the CRWCertVerificationController finish tasks. This is a workaround crbug.com/776330. Bug: Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ide3f3b38a1e981db9b2c42a053e1caaae13c1348 Reviewed-on: https://chromium-review.googlesource.com/728100Reviewed-by:
Eric Noyau <noyau@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#510079}
-
tzik authored
scoped_refptr is allowed in Blink now, and WTF::RefPtr is an alias of scoped_refptr for migration. This CL inlines the alias to the RefPtr users in core/loader to remove RefPtr. Bug: 763844 Change-Id: Ifc46f2984639ab3f6a9d5ea3c248e28b10f65f71 Reviewed-on: https://chromium-review.googlesource.com/727501Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#510078}
-
Miguel Casas-Sanchez authored
This CL adds sanity checks in the creation of gfx::ColorSpace from a monitor's EDID. The checks are: making sure that the primaries are correctly located relative to each other, and that the area covered by the triangle of primaries is not too small. This CL also adds a wacky EDID to the drm_util_unittest.cc, which primaries can be seen painted on a CIE chromaticity diagram in [1], and uses it to test the new sanity checks. The "sanity checks" are implemented at the drm_util level because technically speaking the EDID parsing succeeds. [1] https://i.imgur.com/JYk2rVG.png (or https://imgur.com/a/F7Bvo) Bug: 771345 Change-Id: Ia7c85f409383f340cc9deb4633d2a9bd8085ccab Reviewed-on: https://chromium-review.googlesource.com/723164 Commit-Queue: Miguel Casas <mcasas@chromium.org> Reviewed-by:
Stéphane Marchesin <marcheu@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#510077}
-
kylechar authored
The VizProcessTransportFactory is a replacement for GpuProcessTransportFactory for viz mode. In this mode the display compositor runs in the viz process instead of browser process. The --enable-viz flag won't work yet since there are changes required in content/browser/renderer_host that still need to land. TBR: mpearson@chromium.org Bug: 770833, 732900 Change-Id: I0aaf9ef369366838e2335447358fd6dfaaa5bf0a Reviewed-on: https://chromium-review.googlesource.com/703274 Commit-Queue: kylechar <kylechar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#510076}
-
tzik authored
scoped_refptr is allowed in Blink now, and WTF::RefPtr is an alias of scoped_refptr for migration. This CL inlines the alias to the RefPtr users in core/html to remove RefPtr. Bug: 763844 Change-Id: I66a4c246afce9800028427adef60f4a6e9cd429d Reviewed-on: https://chromium-review.googlesource.com/727601Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#510075}
-
Egor Pasko authored
Reason: flaky TBR=zea@chromium.org Bug: 776251 Change-Id: I82c27e2a9586fb9560a03ed9d2f823020c7a55e0 Reviewed-on: https://chromium-review.googlesource.com/728220Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#510074}
-
Ella Ge authored
In this CL, we change reset mouse states in mouse move to not do MouseReleaseEventUpdateStates, but only ClearDragHeuristicState. The reason is: 1. click_count_ & click_element_ are set from WebMouseEvent on mousePress. It won't be incorrect even if we do not receive the MouseUp. 2. On Mac(with software like BBT that trap events), event queue might got incorrect: a MouseMove with no button down is received&handled before MouseUp. Therefore click event will not fire since we did the InvalidateClick() on MouseMove. This fix won't break crbug.com/527582 Bug: 763642 Change-Id: Ic278412281ba177a23b1a5fffeaa62ae123cc71d Reviewed-on: https://chromium-review.googlesource.com/726962 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#510073}
-
Ella Ge authored
latency_info.source_event_type for fake KeyUp event should be OTHER instead of KEYPRESS. Bug: 772505 Change-Id: Ie43e31426e345f427f0eeb9863fbd0449c1c67dc Reviewed-on: https://chromium-review.googlesource.com/727370Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Ella Ge <eirage@chromium.org> Cr-Commit-Position: refs/heads/master@{#510072}
-
Peter E Conn authored
In the current ChromeTabbedActivity to FullscreenActivity transition we detach the Tab from the CTA then launch the FA which reattaches the Tab. Since Activity creation takes time, the user gets a glimpse of a second Tab before the FA opens with the fullscreen Tab. Here we change the flow so the Tab is only detached and reattached once the FA has started. Bug: 757878, 758116 Change-Id: I8cd4afe80ff053ae2bf0bc89454a286429330440 Reviewed-on: https://chromium-review.googlesource.com/632686 Commit-Queue: Peter Conn <peconn@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#510071}
-
Fabio Tirelo authored
This should be called when a cleanup ends in a reboot required state and the Settings page is not the current active tab. Bug: 770749 Change-Id: I3e81cc52e4973b767ce375647331dc51ae925d69 Reviewed-on: https://chromium-review.googlesource.com/695754 Commit-Queue: Fabio Tirelo <ftirelo@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Chris Sharp <csharp@chromium.org> Reviewed-by:
Ali Tofigh <alito@chromium.org> Cr-Commit-Position: refs/heads/master@{#510070}
-
Gauthier Ambard authored
When the NTP will appear, the layout needs to be invalidated. It ensures that the insets for the Most Visited section are correct when the device is rotated while another screen (e.g. settings) is presented in front of the NTP. Bug: 771149 Change-Id: If8c926fbb0e5cca860b31c4ccc7b672fe49b9e80 Reviewed-on: https://chromium-review.googlesource.com/726082Reviewed-by:
Jean-François Geyelin <jif@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#510069}
-
Henrik Kjellander authored
TBR=dpranke@chromium.org Bug: webrtc:8363 Change-Id: I4dd6d686e901fa0b050cc0e0d15e1c89a357891b Reviewed-on: https://chromium-review.googlesource.com/706790Reviewed-by:
Henrik Kjellander <kjellander@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Commit-Queue: Henrik Kjellander <kjellander@chromium.org> Cr-Commit-Position: refs/heads/master@{#510068}
-
Blake O'Hare authored
I removed the test parameter a while back but didn't see this comment. Bug: Change-Id: Ib916240cf10ca0f8b589e8aa9d1b32a4a4a03889 Reviewed-on: https://chromium-review.googlesource.com/727820Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Commit-Queue: Blake O'Hare <blakeo@chromium.org> Cr-Commit-Position: refs/heads/master@{#510067}
-