GitLab

(taking over samli's patch).

Review URL: https://codereview.chromium.org/1840533002

Cr-Commit-Position: refs/heads/master@{#383796}

This brings the bookmarks widget into the Material era. The widget now
shows a list of bookmarks that resembles the bookmarks UI in Chrome.

BUG=593587

Review URL: https://codereview.chromium.org/1780893005

Cr-Commit-Position: refs/heads/master@{#383795}

Resource::size() and Resource::overheadSize() can be changed if
|m_resourceRequest|'s URL is changed, and this might corrupt MemoryCache's LRU
lists due to inconsistency between Resource::size() and the LRU list that the
Resource belongs to.

This CL makes Resource::overheadSize() to be constant after Resource's
construction to avoid this due to |m_resourceRequest|'s URL modifications
introduced by https://codereview.chromium.org/1757633005 and any potential
modifications.

BUG=594644

Review URL: https://codereview.chromium.org/1837873003

Cr-Commit-Position: refs/heads/master@{#383794}

Use the common formatting for conditionals instead of something custom in a
block of code I'm about to touch for something else.  No behavior change.

BUG=none

Review URL: https://codereview.chromium.org/1842863002

Cr-Commit-Position: refs/heads/master@{#383793}

Visual rects must match painted output, and frames are painted at rounded-int
offsets.

BUG=594516

Review URL: https://codereview.chromium.org/1834263002

Cr-Commit-Position: refs/heads/master@{#383792}

This patch fixes a bug where nested clip paths (drawn as a mask) would
use the LayoutSVGResourceClipper as the display item client id. This
would crash when multiple elements referenced the same nested clip paths
because the LayoutSVGResourceClipper display item client would be
referenced multiple times.

This patch wraps clip path masks in a single display item.

BUG=598416

Review URL: https://codereview.chromium.org/1838983002

Cr-Commit-Position: refs/heads/master@{#383791}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/b99869a2ffea..018cee950ffa

$ git log b99869a2f..018cee950 --date=short --no-merges --format='%ad %ae %s'

TBR=catapult-sheriff@chromium.org

Review URL: https://codereview.chromium.org/1838253002

Cr-Commit-Position: refs/heads/master@{#383790}

https://codereview.chromium.org/1833193002 added the //printing
dependency to //content/test:content_unittests, but when doing a Debug
build, linking content_unittests fails because it tries to reference the
SkDocument::CreatePDF function, which doesn't exists on platforms that
don't enable printing.

BUG= internal b/27859637
TEST= build content_unittests

Review URL: https://codereview.chromium.org/1842473002

Cr-Commit-Position: refs/heads/master@{#383789}

Depending on the value of the login_authentication_behavior device policy, users
can be given the option to skip the GAIA Minute Maid screen and go directly to
the login screen of the SAML-based enrollment enterprise domain IdP.

Screenshots:
SAML Interstitial Page: https://drive.google.com/open?id=0B6G_-uQnf1_LYlQ2THNuXzlORFk
On Next pressed: https://drive.google.com/open?id=0B6G_-uQnf1_LVm0zaHBYWHg0Tm8
On Signin with different account clicked: https://drive.google.com/open?id=0B6G_-uQnf1_Lc2d3S01kaUQ3Ylk

BUG=498896,583724

Review URL: https://codereview.chromium.org/1831523003

Cr-Commit-Position: refs/heads/master@{#383788}

This CL will separate sending mouse transition events
from pointer events (with type=mouse) transitions as they might belong
to different node anyway. This allows us more separation
of mouse event and pointer events.

BUG=587955

Review URL: https://codereview.chromium.org/1809603003

Cr-Commit-Position: refs/heads/master@{#383787}

https://chromium.googlesource.com/skia.git/+log/ffe54004b92f..6e26205cece9

$ git log ffe54004b..6e26205ce --date=short --no-merges --format='%ad %ae %s'
2016-03-29 halcanary SkPDF: skia_pdf_less_compression - for debugging only

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/1843633003

Cr-Commit-Position: refs/heads/master@{#383786}

It's not used, no need to carry the maintenance burden.

BUG=280282

Review URL: https://codereview.chromium.org/1837833004

Cr-Commit-Position: refs/heads/master@{#383785}

WebView needs to allow all of the OS supported codecs since it
is a system level feature. This forces all the containers that
Chrome does not support onto the MediaPlayer path.

Adds a non-exhaustive WebView test to ensure that 3gp media can be
played. I've run the test locally w/ and w/o the unified media
pipeline enabled.

BUG=none
TEST=new test.

Review URL: https://codereview.chromium.org/1824143004

Cr-Commit-Position: refs/heads/master@{#383784}

LocalFrame has a public contentLayoutObject() method that returns a
LayoutView*. This needs to go away eventually. To ease migration, I've
added a contentLayoutItem() method next to it that returns a
LayoutViewItem. I fixed once reference in VisualViewport to call
contentLayoutItem() instead of contentLayoutObject() (to access a method
that already exists in LayoutViewItem, so no new API methods required).
I also simplified some code in FrameView that had been working around
the fact that LocalFrame didn't offer a method that returned a
LayoutViewItem.

There are no functional changes.

BUG=499321

Review URL: https://codereview.chromium.org/1843603002

Cr-Commit-Position: refs/heads/master@{#383783}

Fix a broken HTML tag, and add a note about future extensions to the API.

BUG=514343

Review URL: https://codereview.chromium.org/1838073003

Cr-Commit-Position: refs/heads/master@{#383782}

Previously, we used "imagebitmap". Firefox uses "bitmaprenderer". This
changes makes the two interoperable.  This will be relfected in the
spec which is WIP.

BUG=597767

Review URL: https://codereview.chromium.org/1826383002

Cr-Commit-Position: refs/heads/master@{#383781}

At this moment, transfer an ImageBitmap works fine with an ImageBitmap
created with the default options. Now that we have options of flipY and
premultiplyAlpha, we should make sure that the transfer logic works.

To verify that, we create an ImageBitmap with flipY=true and premultiplyAlpha
=false, we transfer this ImageBitmap to the worker thread and worker
transfer it back to the main thread. Now on the main thread, the ImageBitmap
should have the same pixel data as the originally created one.

The tricky part here is that when transferring an ImageBitmap to worker,
we are actually pass a StaticBitmapImage which is stored internally in
the ImageBitmap. Since StaticBitmapImage doesn't have info about whether
it is premultiplied alpha or not, we will lose this info. To make sure
the transferring logic is correct, we add a member m_isPremultiplied to
StaticBitmapImage, and ImageBitmap keeps track of this member.

A layout test is added to make sure that the ImageBitmap's pixel data
survives the round trip from main<-->worker thread.

Review URL: https://codereview.chromium.org/1797313002

Cr-Commit-Position: refs/heads/master@{#383780}

BUG=598721
TEST=unit tests + manual testing

Review URL: https://codereview.chromium.org/1840093002

Cr-Commit-Position: refs/heads/master@{#383779}

R=stevenjb@chromium.org
BUG=598515

Review URL: https://codereview.chromium.org/1832393003

Cr-Commit-Position: refs/heads/master@{#383778}

BUG=598037

Review URL: https://codereview.chromium.org/1836573002

Cr-Commit-Position: refs/heads/master@{#383777}

The crash does not reproduce on TOT.

BUG=590747
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq;tryserver.chromium.perf:linux_perf_cq

Review URL: https://codereview.chromium.org/1822293002

Cr-Commit-Position: refs/heads/master@{#383776}

BUG=597985

Review URL: https://codereview.chromium.org/1839003004

Cr-Commit-Position: refs/heads/master@{#383775}

DumpInfo uses time_t, so it should directly include header that
declares it.

BUG=None
TEST=Asan desktop build.

Review URL: https://codereview.chromium.org/1843703002

Cr-Commit-Position: refs/heads/master@{#383774}

While fixing gn component mini_installer I omitted a comma in a list of
file names. The bogus file name this created was not noticed at build
time. This change requires that every file name or pattern in the list
of globs must expand to at least one DLL, thus making a missing comma
a build-time error.

See this URL for the missing comma that almost got commited:
crrev.com/1835993002/diff2/20001:40001/chrome/tools/build/win/create_installer_archive.py

BUG=596885

Review URL: https://codereview.chromium.org/1837943002

Cr-Commit-Position: refs/heads/master@{#383773}

JavaScript chrome.chooseDesktopMedia.

BUG=557222

Review URL: https://codereview.chromium.org/1825633002

Cr-Commit-Position: refs/heads/master@{#383772}

WebRTC 12119:12143

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/df760cd..ce55976

TBR=
BUG=

Review URL: https://codereview.chromium.org/1840133002

Cr-Commit-Position: refs/heads/master@{#383771}

This change starts by covering functionality of:
* OfflinePagesTabObserver, and
* OfflinePagesConnectivityListener
with unit tests using junit. Next, the functionality of both classes is
merged into OPTabObserver. In order to make some of the code
more testable and mockable, it uses:
* a helper class to access tab methods,
* extracts some calls to external objects into one-liner functions

BUG=594252,583436
R=petewil@chromium.org

Review URL: https://codereview.chromium.org/1822853002

Cr-Commit-Position: refs/heads/master@{#383770}

R=jshin@chromium.org
BUG=445616

Review URL: https://codereview.chromium.org/1816173004

Cr-Commit-Position: refs/heads/master@{#383769}

TBR=nednguyen@google.com
BUG=598705

Review URL: https://codereview.chromium.org/1836233003

Cr-Commit-Position: refs/heads/master@{#383768}

As discussed on blink-core-owners-discuss@chromium.org

Review URL: https://codereview.chromium.org/1838223002

Cr-Commit-Position: refs/heads/master@{#383767}

BUG=598120

Review URL: https://codereview.chromium.org/1843643002

Cr-Commit-Position: refs/heads/master@{#383766}

The VC++ compiler and linker default to catching their crashes using
structure exception handling. They then print out a helpful message.
This helpful message is rarely enough information to let us diagnose
what went wrong. crrev.com/1816333002 added /fastfail to the linker
command line and this adds /d2FastFail to the compiler command line,
for gyp and gn.

These options are undocumented and unsupported but very handy -
the linker /fastfail option was crucial in tracking down a linker
crash.

Review URL: https://codereview.chromium.org/1834413002

Cr-Commit-Position: refs/heads/master@{#383765}

Currently it was kept disabled behind a command switch --oobe-bootstrapping-slave.

BUG=597039

Review URL: https://codereview.chromium.org/1829453002

Cr-Commit-Position: refs/heads/master@{#383764}

R=rch@chromium.org
BUG=576998

Review URL: https://codereview.chromium.org/1833093002

Cr-Commit-Position: refs/heads/master@{#383763}

At UsbChooserDialogAndroid::Select, when guid is found in the for loop,
the function should return, no need to continue the for loop.

BUG=591735

Review URL: https://codereview.chromium.org/1838233002

Cr-Commit-Position: refs/heads/master@{#383762}

ScreenWin along with other Screen related objects is not really about graphics.
As a result, this goes to a new home called ui/display to hold things related to
the screen and display.

BUG=597105

Committed: https://crrev.com/b8bc8fd634f70395451f8f559fa129ca049c991c
Cr-Commit-Position: refs/heads/master@{#383500}

Review URL: https://codereview.chromium.org/1825723002

Cr-Commit-Position: refs/heads/master@{#383761}

https://chromium.googlesource.com/skia.git/+log/e577693b3be0..ffe54004b92f

$ git log e577693b3..ffe54004b --date=short --no-merges --format='%ad %ae %s'
2016-03-29 halcanary SkPDF: milestone in metadata, also SkMilestone.h
2016-03-29 halcanary Style bikeshed - remove extraneous whitespace

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/1842803002

Cr-Commit-Position: refs/heads/master@{#383760}

BUG=540491

Review URL: https://codereview.chromium.org/1835063002

Cr-Commit-Position: refs/heads/master@{#383759}

Revert of [Android] Switch instrumentation tests to platform mode. (RELAND) (patchset #2 id:20001 of https://codereview.chromium.org/1836883002/ )

Reason for revert:
broke mojo on Android GN: https://build.chromium.org/p/chromium.linux/builders/Android%20GN/builds/33530

Original issue's description:
> [Android] Switch instrumentation tests to platform mode. (RELAND)
>
> This is a reland of https://codereview.chromium.org/1387933005/
>
> BUG=428729
>
> Committed: https://crrev.com/a46e07369fc36afae9fab7506640eb76ff9b925a
> Cr-Commit-Position: refs/heads/master@{#383729}

TBR=mikecase@chromium.org,rnephew@chromium.org,bpastene@chromium.org,martiniss@chromium.org,yfriedman@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=428729

Review URL: https://codereview.chromium.org/1843713002

Cr-Commit-Position: refs/heads/master@{#383758}

This produces this kind of log files:

[
  {
    "INFO": "integration_test.pyc:Started server on port 60390"
  },
  {
    "INFO": "process.pyc:Starting chromedriver"
  },
  {
    "INFO": "process.pyc:Starting chrome"
  },
  {
    "INFO": "integration_test.pyc:Navigating to Kasko debug URL"
  },
  {
    "INFO": "integration_test.pyc:Waiting for Kasko report"
  },
  {
    "INFO": "kasko_integration_test.py:Test passed successfully!"
  }
]

Review URL: https://codereview.chromium.org/1834773002

Cr-Commit-Position: refs/heads/master@{#383757}