- 14 Feb, 2018 40 commits
-
-
Yuke Liao authored
This reverts commit 3adf99c6. Reason for revert: This CL is causing a hang on base_unittests on iOS internal device bots, and the tests consistently hang on RunLoopDelegateTest.NestableTasksDontRunInDefaultNestedLoops test. Original change's description: > Make interactive tests have unlimited timeout on Windows. > > This upgrades --interactive to a test-launcher-scope switch (necessarily > renaming it to --test-launcher-interactive) and treats it as a timeout > specifier. For browser UI tests on Windows, this means the parent process will > now get an (effectively) unlimited timeout and not just the child process, so > the test won't terminate early. > > BUG=none > TEST=none > > Change-Id: I56b02ba30ad0df6617b0f1f95d9986724c5035a0 > Reviewed-on: https://chromium-review.googlesource.com/909920 > Commit-Queue: Peter Kasting <pkasting@chromium.org> > Reviewed-by: Gabriel Charette <gab@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Trent Apted <tapted@chromium.org> > Cr-Commit-Position: refs/heads/master@{#536634} TBR=sky@chromium.org,pkasting@chromium.org,gab@chromium.org,tapted@chromium.org Change-Id: I75837514518ee8ac3fd846151c4dc1385ebf385c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/919741Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#536780}
-
Daniel Cheng authored
Also fixes a small typo in the NoDestructor documentation. Change-Id: I87c1b1bcd383fd9644e03e2092f9456528e03860 Reviewed-on: https://chromium-review.googlesource.com/900342 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#536779}
-
bsheedy authored
This was reverted due to the tests breaking on debug builds. This should be fixed with crrev.com/c/914860. Original description: Adds the VR browser tests to win7_chromium_rel_ng now that there is enough capacity to run them on changes that affect VR. Bug: 780668 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I79bab14433da47464b58115ff61c893a7cbe29fa Reviewed-on: https://chromium-review.googlesource.com/916842 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#536778}
-
Qiang Xu authored
TBR=reveman@chromium.org Bug: 783310 Test: compiles & bots Change-Id: Idafe69d46e1aec8ed2123c08e10652468797b54a Reviewed-on: https://chromium-review.googlesource.com/917333Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Qiang Xu <warx@google.com> Cr-Commit-Position: refs/heads/master@{#536777}
-
Kyle Horimoto authored
This class generates CryptAuthClient objects via the IdentityManager service. This will be used to fetch synced CryptAuth data in the DeviceSync API. Bug: 752273 Change-Id: I8378ea9c66eb52b2e6f061de3efea8619fed679a Reviewed-on: https://chromium-review.googlesource.com/907631 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#536776}
-
James Cook authored
Change the filter file from a whitelist to a blacklist. The blacklist has been in use on the Mojo FYI bots for some time and the test suite seems stable. This adds ~8000 tests to the bot. This is part of go/mustash. We run browser_tests --mash on the linux-chromeos bots to test out-of-process ash sysui. Bug: 678687 Test: mash_browser_tests Change-Id: I784990cb1ee4d6241961ca9744248fdbc912a231 Reviewed-on: https://chromium-review.googlesource.com/895906 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#536775}
-
Alec Douglas authored
The testEnterExitFullscreenWithControlsButton test in VideoFullscreenOrientationLockTest attempts to click on the fullscreen button in the video controls panel via hardcoded offsets from the bounds of the video element. These offsets assume there are no other buttons placed to the right of the fullscreen button, but in some circumstances the cast button will appear and cause the test to fail when the fullscreen button is not where the test expects it to be. This commit ensures that the test video never shows the cast button in the controls panel. Note: The download button does not need to be disabled because the media src is detected as being a local file and this causes the download button to not be shown. BUG=None TEST=Every test class that uses video-player.html: FullscreenVideoTest, VideoFullscreenOrientationLockTest, VideoFullscreenOrientationLockChromeTest, FullscreenActivityTest Change-Id: Ia14b8e515f0ea6510bfa54fce0fa2f809d4a22b1 Reviewed-on: https://chromium-review.googlesource.com/915017Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#536774}
-
erikchen authored
Bug: 810748 Change-Id: Ida3b064c694eccd248b37bf3ade9dcbc6978d890 Reviewed-on: https://chromium-review.googlesource.com/919462Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#536773}
-
Greg Kraynov authored
If developer installs goma to location different from $HOME/goma, GOMA_DIR should be set as per official goma docs. Change-Id: I35d952a837f6f734ef9d45e415d5a49596f88b58 Reviewed-on: https://chromium-review.googlesource.com/918681 Commit-Queue: Greg Kraynov <kraynov@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#536772}
-
Koji Ishii authored
Following bot results are included. 3755 3756 3 lines were removed and 16 lines were deflaked by consecutive results since 3710. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ie70aa38086dc44e0a4aefa3b524312f05dad65ef Reviewed-on: https://chromium-review.googlesource.com/919442 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#536771}
-
yiyix authored
DrawOcclusion can be enabled with both flags --enable-draw-occlusion and --enable-features=DrawOcclusion. This cl unifies the two existing flags, so the it can only be enabled with --enable-features=DrawOcclusion. Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ib6deef4da8bdbd31fa62380c8bd6de2a97851d12 Reviewed-on: https://chromium-review.googlesource.com/917664Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#536770}
-
https://skia.googlesource.com/skia.git/+log/5b6fa82ee12b..a7c569d111f4 $ git log 5b6fa82ee..a7c569d11 --date=short --no-merges --format='%ad %ae %s' 2018-02-14 caryclark PremulAlphaRoundTrip_Gpu on AndroidOne 2018-02-14 benjaminwagner Bots only need Include dir from the Win Vulkan SDK. 2018-02-13 csmartdalton ccpr: Tessellate fans for very large and/or simple paths 2018-02-14 robertphillips Use a lazy proxy in OnFlushCallbackTest to fulfill some old TODOs Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: I765589433dd3c4f975fc28cc7d5134679d21157e Reviewed-on: https://chromium-review.googlesource.com/919501 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#536769}
-
Vladimir Levin authored
This patch replaces the heap allocated members of the PrePaintTreeWalk context with value members, and instead of creating these contexts on the stack, instead uses a vector storage that gets passed around as recursion happens. There are some subtleties with using this approach (I added comments for those). In local testing on a micro benchmark (not included here), this shows about ~10% improvement on the prepaint tree walk when everything is invalidated via SetSubtreeNeedsPaintPropertyUpdate. One thing that is important is that contexts can store references to its parent contexts, both top level PrePaintTreeWalkContext and PaintInvalidatorContext. However since a vector may reallocate, it will invalidate these parent references. For the former (PrePaintTreeWalkContext), we simply have an accessor that uses an index to look up the context in the context storage. Similar thing is done for PaintInvalidatorContext. However, in the latter, because it's implemented and accessed in different files, we instead put in a ParentContextAccessor which hides the underlying access to the context storage on the PrePaintTreeWalk object. R=chrishtr@chromium.org Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id69fae9db5ef76d64342cf3082d81762ee18dd15 Reviewed-on: https://chromium-review.googlesource.com/910085 Commit-Queue: vmpstr <vmpstr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#536768}
-
Daniel Cheng authored
WebInputEvent's timestamp will change to a base::TimeTicks in a followup CL, so the test timestamp's type will change as well. Normally, this would be easy: the followup patch would simply change the type of kTimeStampForTesting to base::TimeTicks. However, changing the type means that kTimeStampForTesting is considered ODR-used when passed as a direct argument to EXPECT_EQ, and thus requires a definition. Pre-C++17, this definition must be out-of-line. However, that means WebInputEvent is no longer a header-only class, which means all consumers of this header must link against Blink itself. This is undesirable, since WebInputEvent is also used from the browser process, which should not link against Blink. To workaround all of this, change it to a helper function which is inline in the header and won't suffer from the ODR-use issues with googletest. TBR=jam@chromium.org Bug: 763980 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ic6f3b31f2abf747af70f7c96d9f44a5151265582 Reviewed-on: https://chromium-review.googlesource.com/917335 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#536767}
-
Robert Iannucci authored
This will prevent tests sensitive to cold vpython startup time from timing out. Bug: 804174 Change-Id: Ieaf6e0d94fa668fd26481fe3efcaf6d0e968864d Reviewed-on: https://chromium-review.googlesource.com/917802Reviewed-by:
Daniel Jacques <dnj@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Robbie Iannucci <iannucci@chromium.org> Cr-Commit-Position: refs/heads/master@{#536766}
-
Elly Fong-Jones authored
This change: 1) Adds a HEAVY_UNDERLINE text style 2) Has RenderText apply it for compositions, instead of UNDERLINE 3) Has RenderTextHarfBuzz and RenderTextMac draw HEAVY_UNDERLINE properly Bug: 612675 Change-Id: I08f997dfb1edee1ea29d8c828302d7a24418975b Reviewed-on: https://chromium-review.googlesource.com/905125Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#536765}
-
Andrey Pronin authored
For Chromium builds, instead of triggering tpm ownership on boot, rely on it being triggered after the first login (as it was before CL:688763). after booting, (b) the tpm is owned after logging in. Bug: 799664 Test: clear the owner, reboot, verify that (a) the tpm is not owned Change-Id: I991333e0f049c998dc126827dc141419bf1c3503 Reviewed-on: https://chromium-review.googlesource.com/917537Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Andrey Pronin <apronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#536764}
-
Joy Ming authored
This CL switches the implementation of the DownloadLocationDialog from AlertDialog to ModalDialogManager. Bug: 792775 Change-Id: Ida60fb9cd55f9b2e07a918bfb90e79468552de6d Reviewed-on: https://chromium-review.googlesource.com/915105 Commit-Queue: Joy Ming <jming@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#536763}
-
https://webrtc.googlesource.com/src.git/+log/d377f041944f..13735821487e $ git log d377f0419..137358214 --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ia050aa14d6548dbe53381eb5df233125f06dad0d Reviewed-on: https://chromium-review.googlesource.com/919252 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#536762}
-
Kyle Horimoto authored
This class fetches access tokens for the current user using the IdentityManager service. This will be used to fetch synced CryptAuth data in the DeviceSync API. Bug: 752273 Change-Id: I3978c7438a78f54800db3bb5b9f5e9221c9104d6 Reviewed-on: https://chromium-review.googlesource.com/906969Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#536761}
-
Steve Kobes authored
Bug: 811073 Change-Id: Id357417202933651460086559f34238b363142c7 Reviewed-on: https://chromium-review.googlesource.com/919258Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#536760}
-
Stefan Zager authored
The line removed in this CL was added in: https://chromium-review.googlesource.com/c/chromium/src/+/914864 That CL was to fix a crash, but the crash only occurs when root layer scrolling is enabled. The call to ScrollAnchor::Dispose from LocalFrameView::Dispose was added just for completeness, but does not affect the original crash. This new crash suggests that LocalFrameView may still process scroll events after Dispose() has been called. Which is strange and horrible, but probably not worth fully investigating at this point. Instead, just remove the call to scroll_anchor_.Dispose() and wait for root layer scrolling to make the surrounding code obsolete. BUG=812023 R=skobes@chromium.org,bokan@chromium.org Change-Id: I0715ab5a76e2fee6b4f378fc470d816b851bfa44 Reviewed-on: https://chromium-review.googlesource.com/919396Reviewed-by:
Steve Kobes <skobes@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#536759}
-
James Cook authored
It's a mojo mini-app. It's only used with mash, which only runs on Chrome OS. Move it to the Chrome OS UI directory. NOPRESUBMIT=true Bug: none Test: bots Change-Id: I8da161c8ec4c95ab284d4b0e5248b6fff5a04406 Reviewed-on: https://chromium-review.googlesource.com/917208 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#536758}
-
Eugene But authored
Old name was presumably used to match was_within_same_page IPC, but SameDocument name better reflects the the type of the navigation (navigation did not change the document object). This change will make naming more consistent with the rest of Chromium code. Bug: 695189 Change-Id: If70aa7b7b315773a496db08fc2b7878465b5c5b4 Reviewed-on: https://chromium-review.googlesource.com/912104Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#536757}
-
Elly Fong-Jones authored
There's a subtle lifetime issue exposed by this test. See the linked bug for more details. Bug: 810139 Change-Id: If04cc1573c7983ab62627770ea96c7a5ef6a56cb Reviewed-on: https://chromium-review.googlesource.com/919463Reviewed-by:
Leonard Grey <lgrey@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#536756}
-
Nicolas Pena authored
This CL changes MemoryInfo so that, when the heap statistics are calculated, the values for totalJSHeapSize and usedJSHeapSize are not used if the number of pages is greater than 1. Bug: 807651 Change-Id: I99bc52e0e2cb8e17c797fdb3868110fc409ad00e Reviewed-on: https://chromium-review.googlesource.com/904972Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#536755}
-
James Cook authored
Now that we have //ash/components we're trying to clean up //ui to get it back to its original state of being low-level UI libraries. This code was written during the Athena days (when we were trying to avoid using ash). It is only used inside //ash, so move it there. Bug: none Test: ash_unittests, ui_chromeos_unittests Change-Id: I2484d2d54a8ad99b855719c968708c3008ba52a0 Reviewed-on: https://chromium-review.googlesource.com/917439Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#536754}
-
Robert Liao authored
The ExtensionPopup resizes its view dynamically after it can be anchored and shown. This change adds child resize support to BubbleAnchorHelper to accommodate that scenario. Move is brought along for free. BUG=728174 Change-Id: I7ca12b92da339263ca5558254d2bbb0595a57b4c Reviewed-on: https://chromium-review.googlesource.com/915010 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#536753}
-
https://pdfium.googlesource.com/pdfium.git/+log/d8d6f55140bd..785d126bd57a $ git log d8d6f5514..785d126bd --date=short --no-merges --format='%ad %ae %s' 2018-02-14 npm Roll pdfium/third_party/freetype/src/ 036bdc0c9..4a03f1744 (2 commits) 2018-02-14 dsinclair Set node to owning element 2018-02-14 dsinclair Cleanup some CXFA_Node flags and methods. 2018-02-14 dsinclair Cleanup CXFA_Node::SetFlag Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I92d59d95ae32ccbd9c7c656ba3f724acf3f64673 Reviewed-on: https://chromium-review.googlesource.com/919383 Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#536752}
-
edchin authored
This CL adds an experiment flag for Tab Grid, and simply uses the flag to show a blank tab grid when enabled. Bug: 804496 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I9d24d64c77cba8889f2c699763d610617263b9cc Reviewed-on: https://chromium-review.googlesource.com/917427 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#536751}
-
Kyle Horimoto authored
Now, it is a pure virtual class with a test double. This is in preparation for using it in the MultiDevice service. Bug: 752273 Change-Id: I01f79a0361ec71e51a30dc3a56b28555dc594712 Reviewed-on: https://chromium-review.googlesource.com/910118Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#536750}
-
liberato@chromium.org authored
Already seems to time out 100% of the time, and similar tests in TestExpectations are marked as crash. So, adding that to this one as well. TBR=dom-dev@chromium.org Bug: 811993 Change-Id: I4451212e7e4263ed3c843c4860ce1834ebd0079b Reviewed-on: https://chromium-review.googlesource.com/917222 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#536749}
-
wutao authored
This cl allows client to set custom_frame_view color. Changes: 1. Add OnWindowPropertyChanged to CustomFrameViewAshWindowStateDelegate. 2. Client can set custom_frame_view color by setting window property aura::client::kTopViewColor. Bug: 811159, 768932 Test: CustomFrameViewAshTest.KTopViewColor and manually test color update. Change-Id: Ic2306c399b0d4cda88ffb0f96c48a15e3e6f430b Reviewed-on: https://chromium-review.googlesource.com/912518 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Mitsuru Oshima (In Tokyo) <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#536748}
-
https://skia.googlesource.com/skia.git/+log/0ee866dac78b..5b6fa82ee12b $ git log 0ee866dac..5b6fa82ee --date=short --no-merges --format='%ad %ae %s' 2018-02-14 brianosman Respect FPArgs local matrix when picking a filtering mode in image shader 2018-02-14 kjlubick Trim down Emscripten SDK asset size 2018-02-13 benjaminwagner Do not copy vulkan-1.dll to Win bots. Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=caryclark@chromium.org Change-Id: Ic820b07dd5bccf43afc4b742a8302d9ae60bcdf2 Reviewed-on: https://chromium-review.googlesource.com/919254Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#536747}
-
Koji Ishii authored
Following bot results are included. 3740 3742 3746 3749 3750 3753 1 lines were removed and 21 lines were deflaked by consecutive results since 3699. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I934d43db60e15dd176db569fc9793b79d5cc4e7e Reviewed-on: https://chromium-review.googlesource.com/917721 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#536746}
-
edchin authored
Crash is caused by the previousPanelIndex being out-of-bounds into the panels array. This CL ensures that previousPanelIndex is kept up-to-date when any panels are removed so that it is not out-of-bounds. Bug: 805530 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Id193a85585510c50e9bb92680f0782fee7e34d1a Reviewed-on: https://chromium-review.googlesource.com/916943Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#536745}
-
Hajime Hoshi authored
This is part of efforts to replace default timer task runners with other appropriate task runners in the renderer. Bug: 624694, 804694 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Id745eed43a86ce079fd870586ce6169b928ba1dd Reviewed-on: https://chromium-review.googlesource.com/917884Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org> Cr-Commit-Position: refs/heads/master@{#536744}
-
Danyao Wang authored
When switching to an evicted tab, WKBasedNavigationManager loads restore_session.html to restore back/forward history. This load should not be counted as a new page load by TabUsageRecorder. This fixes TabUsageRecorderTestCase/testEvictedTabReloadBackground. Bug: 807428 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If194acd0de633bc170f221d8a960514995425bce Reviewed-on: https://chromium-review.googlesource.com/917524Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#536743}
-
Isha Bobra authored
This CL is a followup on the following CL: https://chromium-review.googlesource.com/736043 The above CL returns the deepest child of web view on ACTION_PREVIOUS_HTML_ELEMENT if can_wrap_to_last_element flag in OneShotAccessibilityTreeSearch is set to true. This CL sets that flag for Android. Assuming a web view is in between native elements, the following order will be followed for a11y focus: Native elements -> web view container -> inside web view container -> native elements. So web view container will always be focused only in the above order. Bug: 661793 Change-Id: I62dbcb143ed5a152172dc7cde9355f4b7eed79e1 Reviewed-on: https://chromium-review.googlesource.com/884302Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#536742}
-
Vadym Doroshenko authored
CL https://chromium-review.googlesource.com/c/chromium/src/+/823238/ introduces processing messages from IFrames. Function CRWWebController:respondToMessage: userIsInteracting:originURL:isMainFrame: incorrectly processes case when no handler for message form IFrames. Which leads to using |handler|, when |handler| = nil. This CL fixes that. Bug: 801485 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I661754b83e2e09a4a907634d15f50e62a315c343 Reviewed-on: https://chromium-review.googlesource.com/916604 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#536741}
-