- 03 Jan, 2019 40 commits
-
-
Jamie Madill authored
This should help prevent flaky tests from landing in the tree. Also includes a minor cleanup where the test suite keys in the entries for ANGLE tests are sorted alphabetically. Bug: angleproject:3029 Change-Id: I19420d3f716d44ded44db39b185aa947c06110f4 Reviewed-on: https://chromium-review.googlesource.com/c/1394795Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#619750}
-
Philip Rogers authored
When deciding whether an overflow clip paint property node is needed, we previously checked if the visual overflow extended beyond the overflow clip rect. This would miss cases when the visual overflow was empty (e.g., descendants with width: 0) but the content was still scrollable. This patch adds a check for layout overflow. While in the area, the condition for visual overflow has been refactored to make the self-painting PaintLayer case a little clearer. The early-out for PaintLayer descendants is required for correctness. Bug: 918675 Change-Id: I41fe5fd71a957f196b5b8095965d4e361e535196 Reviewed-on: https://chromium-review.googlesource.com/c/1393885Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#619749}
-
Leonard Grey authored
One might ask: why do even have this lever? I agree, so I filed https://crbug.com/918911 Bug: 918194 Change-Id: I0ea816a50d840e71bc6f8c5684877c8353cb0c11 Reviewed-on: https://chromium-review.googlesource.com/c/1394734Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#619748}
-
Becca Hughes authored
This is a reland of 858e896d Original change's description: > [Audio Focus] Restrict browser group to CrOS > > Restrict browser audio focus grouping to Chrome OS. > > BUG=915501 > > Change-Id: I702952cca7a388e78c201531866307797d25b277 > Reviewed-on: https://chromium-review.googlesource.com/c/1379918 > Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> > Commit-Queue: Becca Hughes <beccahughes@chromium.org> > Cr-Commit-Position: refs/heads/master@{#617800} Bug: 915501 Change-Id: Ideb9814a6d4ff7e9faedc66efa6d2073adec818d Reviewed-on: https://chromium-review.googlesource.com/c/1386107Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#619747}
-
Tommy Steimel authored
The test is also failing on Retina builds: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/WebKit%20Mac10.13%20(retina)/8631 Bug: 917970 Change-Id: I3de376948ec19cfc4a83c58dd28b5bde04fd3f95 Reviewed-on: https://chromium-review.googlesource.com/c/1394868 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#619746}
-
Brandon Jones authored
Updated to the newer types described by the latest WebXR Device API spec updates. Bug: 915050 Change-Id: I14f07f922ff2eee046664bd9a6ecf1cf4e954312 Reviewed-on: https://chromium-review.googlesource.com/c/1377711 Commit-Queue: Brandon Jones <bajones@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#619745}
-
Mathieu Perreault authored
Bug: None Change-Id: I2770684d47147b0a267214b1c5e55eea1438907f Reviewed-on: https://chromium-review.googlesource.com/c/1394391Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#619744}
-
Piotr Bialecki authored
This flag will be set appropriately depending on the context for which the manifest is generated (bundle vs APK). This CL maintains current behavior. Change-Id: I543e09d07e2bea4769e2d4a71663b10b140c01c6 Reviewed-on: https://chromium-review.googlesource.com/c/1394864 Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#619743}
-
Chromium WPT Sync authored
Using wpt-import in Chromium eaf82f71. With Chromium commits locally applied on WPT: 1c633d48 "Snap the snapped_dest_rect for backgrounds" 1061788d "Reland "Add quota usage details tests for all other storage backends."" e9314f41 "Fix resource-timing.html document.domain test" bcd3934d "Add a test for ServiceWorker and AppCache interaction with claim()" 71e2c3fd "Invalidate the graphics layer subtree on stacking change of descendant PaintLayer." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: Ide9e164909bb1a695b32f8650351d574591478c8 Reviewed-on: https://chromium-review.googlesource.com/c/1394399Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619742}
-
Doug Turner authored
Bug: 897312 Change-Id: I3f156092b1d5687fce06ef05b2f6cf4db1d9ba32 Reviewed-on: https://chromium-review.googlesource.com/c/1388809 Commit-Queue: Doug Turner <dougt@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#619741}
-
Sergey Ulanov authored
Previously PlatformExit() was called before WebContents is destroyed. On Fuchsia PlatformExit destroys the Screen sigleton, but WebContents was trying to use it while destroying the window. With this change WebContents is destroyed before the Screen. Bug: 778467 Change-Id: I3200e9339771b001c9b8b4fe0e311b1ef42d8d01 Reviewed-on: https://chromium-review.googlesource.com/c/1389026Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#619740}
-
Marcin Wiacek authored
This is part of changes which put as goal removing redundant ChromeAnimation API by moving everything into CompositorAnimator. Public doc with proposal: https://docs.google.com/document/d/1VL5ntE7vn267IFjE4Zke0GkhVVTHz1bEP672Apj_E2k/edit This concrete patch is migrating StackLayoutBase. BUG=890643 Change-Id: I66668b9373c54fc9573de8d797990b6e291f2b54 Reviewed-on: https://chromium-review.googlesource.com/c/1376851Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> Cr-Commit-Position: refs/heads/master@{#619739}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c63ddb2a3f9a..3f2b9aad4a05 git log c63ddb2a3f9a..3f2b9aad4a05 --date=short --no-merges --format='%ad %ae %s' 2019-01-03 srte@webrtc.org Moves logged event structs to separate header. 2019-01-03 yinwa@webrtc.org Bugfix: Activate pushback on every sent packet. 2019-01-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 86bff8b8..adf0af4d (619523:619625) 2019-01-03 hta@webrtc.org Add an observer API for DTLSTransport events. 2019-01-03 minyue@webrtc.org Use ordered data structure for supported frame lengths in ANA. 2019-01-03 nisse@webrtc.org Convert peerconnection_client to use VcmCapturer 2019-01-03 nisse@webrtc.org Update unityplugin to use VcmCapturer. 2019-01-02 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision d189a954..86bff8b8 (619409:619523) Created with: gclient setdep -r src/third_party/webrtc@3f2b9aad4a05 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:907849,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I9eb6c6869d7c551064e241d794ecd60715e660b0 Reviewed-on: https://chromium-review.googlesource.com/c/1394686Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619738}
-
Becca Hughes authored
Notifies the mojo observer from content::MediaSessionImpl when the supported actions change. BUG=892771 Change-Id: Iea1edf130b415d44ab9f32f7b6506d53f4558280 Reviewed-on: https://chromium-review.googlesource.com/c/1379917Reviewed-by:
-
Peter Kasting authored
Bug: 331924, 603562, 626761, 837219 Change-Id: If2695993d98dc00168c367c3c171b99a96eb7bc5 Reviewed-on: https://chromium-review.googlesource.com/c/1351809 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#619736}
-
Danyao Wang authored
Change-Id: I8f2cfb66099a3bf8bd03f3407ed763067a465f01 Reviewed-on: https://chromium-review.googlesource.com/c/1394883 Commit-Queue: Danyao Wang <danyao@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#619735}
-
chromium-autoroll authored
The AutoRoll server is located here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Idb57ebf1ea2981b717cb9712ad86dda8c7ed0c3b Reviewed-on: https://chromium-review.googlesource.com/c/1394797Reviewed-by:
-
Xianzhu Wang authored
This is a reland of crrev.com/618316 which was reverted in crrev.com/619326 because of performance regression. This patch changed the condition in PrePaintTreeWalk::WalkTree() from if (root_frame_view.GetLayoutView()->Layer()->NeedsRepaint()) to if (needs_invalidate_chrome_client_). needs_invalidate_chrome_client_ is set by PaintInvalidator. The problem of previous code was that NeedsRepaint() is always true if the document doesn't update lifecycle to paint which is the case for the subdocument of SVGImage, causing infinite invalidation of the chrome client. Original change's description: > Revert "[CompositeAfterPaint] Invalidate chrome client when needed" > > This reverts commit 29021ede. > > Reason for revert: Suspect performance regression > > Bug: 918276 > > Original change's description: > > [CompositeAfterPaint] Invalidate chrome client when needed > > > > For pre-CompositeAfterPaint, we call InvalidateChromeClient() > > when an object is invalidated in a view referenced from a plugin or > > an svg-image. > > > > Now let the path also work for CompositeAfterPaint. > > > > This fixes several web plugin tests for CompositeAfterPaint. > > > > Bug: 524134 > > Change-Id: Ia4c3ccba4632ddcdfdfdfec299fb7a68440a1419 > > Reviewed-on: https://chromium-review.googlesource.com/c/1385112 > > Reviewed-by: Philip Rogers <pdr@chromium.org> > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#618316} > > TBR=wangxianzhu@chromium.org,pdr@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: 524134 > Change-Id: I9b4f67a74732919ba23acc00fd501d45baa498e6 > Reviewed-on: https://chromium-review.googlesource.com/c/1392439 > Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org> > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#619326} Bug: 918276, 524134 Change-Id: Ifad1c2eb8bdddcceea26a286c3309665f6d94c1a Reviewed-on: https://chromium-review.googlesource.com/c/1393558Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#619733}
-
Lindsay Pasricha authored
Creating 2 prototype tests using EG2 with the smoke_egtest suite. The plan for migrating to EG2 is outlined at go/chrome-eg2-migration. - Added the earl_grey2:all_tests as a build target - Added the ios/chrome/test/earl_grey2 directory with BUILD and gni files - Added the prototype smoke_test suite with 2 test cases - Added the chrome_earl_grey_edo .h/mm files for the EDO helpers - Tweaked and reorganized ios/third_party/earl_grey2/ BUILD and gni files. Bug: 906201 Change-Id: I6521af6403ac9e4b320cba25f390be88522a0678 Reviewed-on: https://chromium-review.googlesource.com/c/1352532 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#619732}
-
Raul Tambre authored
Bug: 766891 Change-Id: Ib8cf38fb63d9494f21462ab55ce361775b107322 Reviewed-on: https://chromium-review.googlesource.com/c/1390003Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/eb333167..b4e2270d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I218b75e19cb3322712e550ee9a9f13d96b545637 Reviewed-on: https://chromium-review.googlesource.com/c/1394789Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#619730}
-
liberato@chromium.org authored
This CL adds SupportedVideoDecoderConfig to match the mojom struct. It also adds a struct traits for them, and converts the existing mojo code to use the media:: rather than the mojom:: version. This will make it easier for {D3D11, MediaCodec}VideoDecoder to return their media::SupportedVideoDecoderConfigs, since they cannot use mojo directly. Bug: 918029 Change-Id: Id0403ccadaa1b3fbbb310f01fd9b3a7bebc92ba7 Reviewed-on: https://chromium-review.googlesource.com/c/1392350 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:Dan Sanders <sandersd@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#619729}
-
Tim Zheng authored
To set a Crostini app scaled is to set the property in the Crostini app registry so that when the app launches it'll use low display density. BUG=chromium:839242 TEST=unit test included in this CL Change-Id: I1428a49cce918930f8b5d4083fbc9ba208e8b101 Reviewed-on: https://chromium-review.googlesource.com/c/1393547 Commit-Queue: Tim Zheng <timzheng@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Cr-Commit-Position: refs/heads/master@{#619728}
-
Manu Cornet authored
Shelf items used to be aligned directly after the launcher button, so it made sense to include everything within bounds where tooltips should not hide to avoid hiccups. However, now that we show centered shelf items, this means that a tooltip can be shown all over a possibly quite large amount of white space between the launcher button and the first shelf item. 1) It is very strange to show a tooltip over such a potentially large piece of shelf. 2) On the other hand, when it does happen that the first shelf item is close to the launcher button, not showing a tooltip in the space between them does mean a slight stutter when hovering from one to the next. The drawbacks of 1) clearly outweigh the ones of 2), so this change hides tooltips between the launcher button and the first shelf item. Bug: 896524 Change-Id: I06e666ba0296881f87c2cf3ce5972b38d638c3f7 Reviewed-on: https://chromium-review.googlesource.com/c/1393889 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#619727}
-
Tomasz Wiszkowski authored
Overlooked in crrev/c/1393888 Bug: 918877, 918335 Change-Id: I4c4f0274eefd0b23d449390699f673e061653b48 Reviewed-on: https://chromium-review.googlesource.com/c/1394784 Commit-Queue: Tomasz Wiszkowski <ender@google.com> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#619726}
-
Tommy Steimel authored
Example failure: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.13%20Tests%20%28dbg%29/7897 Bug: 918905 Change-Id: I3ab6874fb5380d8f369e03f3d0837edff8eacbeb Reviewed-on: https://chromium-review.googlesource.com/c/1394799Reviewed-by:
-
Elly Fong-Jones authored
The existing code used FocusedBorderColor, which happened to be equal to ProminentButtonColor on non-Mac and close enough on Mac that nobody noticed the disparity. Mojave changed the color that underlies FocusedBorderColor, which made checkboxes start drawing very faintly. Bug: 918673 Change-Id: If73a4607bb5857e4b61d67cfd7e9f58ebd341021 Reviewed-on: https://chromium-review.googlesource.com/c/1394434Reviewed-by:
Michael Wasserman <msw@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#619724}
-
Tarun Bansal authored
Metrics review doc: http://shortn/_GsufFKsadl Change-Id: Iffd9002ed43586608d4c224602d8405911956a64 Bug: 893923 Reviewed-on: https://chromium-review.googlesource.com/c/1387554Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#619723}
-
Esmael El-Moslimany authored
Bug: 862839 Change-Id: I3499e9c6abe18c0ffb23a4ed3598320edf757570 Reviewed-on: https://chromium-review.googlesource.com/c/1392063 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Cr-Commit-Position: refs/heads/master@{#619722}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/9f36c8bb721d..241644a5a398 git log 9f36c8bb721d..241644a5a398 --date=short --no-merges --format='%ad %ae %s' 2019-01-03 stevenperron@google.com Have replace load size handle extact with no index. (#2261) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@241644a5a398 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I5c00330ca5e6233f070b39959cc0e748a5f927c7 Reviewed-on: https://chromium-review.googlesource.com/c/1394689Reviewed-by:
-
Justin Cohen authored
Nobody appears to use this and it will be removed in the future. Change-Id: I3caadee3e4f4cec2a2f0d9e4d8717f9b1a16afe6 Reviewed-on: https://chromium-review.googlesource.com/c/1394704 Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#619720}
-
Charlie Andrews authored
TBR=nyquist@chromium.org Bug: 918874 Change-Id: I45eaab1c4f4ba92d6a90f2826b92fa3c3eb37774 Reviewed-on: https://chromium-review.googlesource.com/c/1394823Reviewed-by:
Charlie Andrews <charliea@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#619719}
-
Steven Bennetts authored
For header file moves in src/chrome: TBR=sky@chromium.org Bug: 918682 Change-Id: I2cc795ada277560503aa4183075a94825d876c54 Reviewed-on: https://chromium-review.googlesource.com/c/1394003Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
-
John Chen authored
This is a reland of 70ffd447 Original change was reverted due to test flakiness on Mac, caused by: * Pause time often goes above the upper limit of 300 ms, sometime more than double the limit. * Occasionally the first event is missing. The following changes are made to improve test reliability: * Remove the check of an upper limit for the pause time. With the wide range of actual pause time, there appears to be no feasible upper limit to use. * The first significant event is now pointer down instead of key down, to ensure that the target element receives focus. The previous dependence on autofocus attribute appears to be unreliable. * Change mouse button from 1 (middle) to 0 (left), as the middle mouse button triggers paste on some platforms. (It was a typo.) Original change's description: > [ChromeDriver] Handle pauses in Perform Actions > > W3C spec allows the app to specify pauses within Perform Actions command > (https://w3c.github.io/webdriver/#dfn-dispatch-actions). Updating > ChromeDriver to handle these pauses. > > Bug: chromedriver:1897 > Change-Id: I533179f4a9f2216bfacf0f4fdb539c8f898bed07 > Reviewed-on: https://chromium-review.googlesource.com/c/1392281 > Commit-Queue: John Chen <johnchen@chromium.org> > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#619506} Bug: chromedriver:1897 Change-Id: I38122bdc01965345421429b1d2f45374395b0cc7 Reviewed-on: https://chromium-review.googlesource.com/c/1394786Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#619717}
-
Paul Irish authored
Change-Id: I8005904bdc042ad4ac709edcc371256a075cde1b Reviewed-on: https://chromium-review.googlesource.com/c/1393427Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Paul Irish <paulirish@chromium.org> Cr-Commit-Position: refs/heads/master@{#619716}
-
Sergey Ulanov authored
zircon.ethernet was renamed to fuchsia.hardware.ethernet last week, but zircon/ethernet/cpp/fidl.h was still included in network_interfaces_fuchsia.cc. TBR=wez@chromium.org Bug: 918797 Change-Id: I83409d7b5aeb06599a5b89f6400a09704b498fd6 Reviewed-on: https://chromium-review.googlesource.com/c/1394169Reviewed-by:
Wez <wez@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#619715}
-
Max Moroz authored
TEST=tools/code_coverage/coverage_test.py Bug: 869451 Change-Id: I29423a45d6542e358e7157bc6af7f9208969a436 Reviewed-on: https://chromium-review.googlesource.com/c/1394594 Commit-Queue: Max Moroz <mmoroz@chromium.org> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#619714}
-
Rayan Kanso authored
Use consistent annotation style in content/browser/background_fetch/... Style guide: https://google.github.io/styleguide/cppguide.html#Function_Argument_Comments Style used: /* param_name= */ $prvalue Done using the following regex swap + some manual fixes for outliers: - ([^\s{\(]+)\s/\*\s([\w\_]+)\s\*/ - /* $2= */ $1 Change-Id: Id68329cad6ae520f84e9f3ecb6c31f4a39480e36 Reviewed-on: https://chromium-review.googlesource.com/c/1388149 Commit-Queue: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#619713}
-
Matt Simmons authored
R=asvitkine@chromium.org, yusufo@chromium.org Bug: 916818 Change-Id: Ie703332daf193dec69b3bff5c0686f84886422dc Reviewed-on: https://chromium-review.googlesource.com/c/1393453 Commit-Queue: Matt Simmons <mattsimmons@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Cr-Commit-Position: refs/heads/master@{#619712}
-
Joshua Peraza authored
Overview: This CL disables Breakpad for Chrome, Content Shell, WebView, and Chromecast on Android and replaces it with Crashpad. When a crash signal is received, the browser forks+execs a Crashpad handler process either for itself or on behalf of a crashing child to create a crash dump. components/crash/ - Remove CrashDumpManager. Minidump creation is handled entirely by Crashpad. - Remove OnChildStart from ChildExitObserver as it is no longer necessary. - ChildExitObserver observers CrashHandlerHost to be notified when child processes receive crash signals. - De-duplicate calls to ChildExitObserver::Client::OnChildExit when NOTIFICATION_RENDER_PROCESS_{CLOSED, TERMINATED} are both sent. components/minidump_uploader/ - Uploaders expect crash reports to already be MIME encoded since Breakpad was doing that in a signal handler call-back. CrashFileManager now automatically calls into native code to do the encoding and write to a directory of crash reports whenever it checks for reports without logcats. chrome/app/*.{cc,h} chrome/browser/*.cc content/shell/app/*.{cc,h} content/shell/browser/*.cc - Initialize Crashpad instead of Breakpad, with minor cleanup and adjustment for changes to CrashDumpObserver. chrome/browser/metrics/oom/out_of_memory_reporter_unittest.cc - Simulate crashes/exits with NOTIFICATION_RENDER_PROCESS_{CREATED, CLOSED} and signals sent to ChildExitObserver instead of a crash dump. android_webview/ - AwBrowserTerminator now observes child process crashes via ChildExitObserver rather than its own pipe. - Crashpad always produces minidumps, and not microdumps. - Disabling Crashpad is not yet supported. chromecast/ - There are now two directories that crash report uploaders should be aware of: "Crashpad" contains a database of raw minidumps produced by Crashpad, and "Crash Reports" contains MIME encoded minidumps. MIME encoding is performed by a CrashReportMimeWriter in CastCrashUploader.java:checkForCrashDumps(). TBR=yfriedman@chromium.org,peter@chromium.org,isherman@chromium.org,jam@chromium.org,wnwen@chromium.org,torne@chromium.org,halliwell@chromium.org,tobiasjs@chromium.org,rsesek@chromium.org,sanfin@chromium.org,jperaza@chromium.org,mark@chromium.org Bug: crashpad:30 Change-Id: Ib1b0fe085272a7e1e4a91462add50e41eecad746 Cq-Include-Trybots: master.tryserver.chromium.android:android_compile_x64_dbg;master.tryserver.chromium.android:android_compile_x86_dbg Reviewed-on: https://chromium-review.googlesource.com/c/1388654 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by:Mark Mentovai <mark@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#619711}
-
