GitLab

Whenever we are animating a property that affects the font, we must
avoid the base computed style optimization. This is because the base
style may contain em, ex (etc) units which needs to resolve against
the font.

Hence, set a flag when a font-affecting animation is applied.

Bug: 437689
Change-Id: I8bd950a1df9c8e100c4ca2b7318b0389a2acfad0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109694
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752498}

This CL converts resource_dirs to sources for android_resources in
BUILD.gn files in components and ui.

Details:
https://crbug.com/1026378
https://groups.google.com/a/chromium.org/forum/#!msg/chromium-dev/KAFsfaoq7y4/OC4v5sb9BQAJ

Bug: 1062263
Change-Id: I50542a81d1fa7f08e4664334a87353bfc389982e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115551Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752497}

This cl enables PaymentHandlerEnableDelegationsTest tests after removing
"PaymentRequestTestRule.ENABLE_EXPERIMENTAL_WEB_PLATFORM_FEATURES"

I tried reproducing the flakes locally by copying trybot's gn args and
running tests 100 times on a Nexus 5, and Pixel 3, I couldn't reproduce
any flakes.

Looking at the stack trace of some of the crashes(see the
link below) I suspected that the crash might be related to one of the
experimental service worker features enabled by the experimental web
platform features.
https://bugs.chromium.org/p/chromium/issues/detail?id=1054103#c7

Change-Id: I7b74752034f6540aff25df4a1f0e3cdb9366086b
Bug: 1054103
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115875Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752496}

As a part of the sign-in architecture migration we are moving logic
for presenting the sign-in promo out of a custom view controller and
into a utility class.

Logging from this custom view controller will be added subsequently
to a specialized UpgradeSigninLogger class.

Bug: 971989
Change-Id: I83aeb58ccaaff75d833015597e3ec2cb8992721d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107552
Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752495}

These tests were previously using the fake permission manager which
always grants permissions. Now we can use the real permission manager,
and the fake permission manager can be removed.

Fixes a strict mode violation in permission dialogs (similar to fixes
from https://crrev.com/c/2108603).

Bug: 1025625, 1025609
Change-Id: I8b756c61ee213151e53d68a375ffa4d3f8fd7643
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111061
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752494}

While here, also replace an LOG(INFO) with a DLOG(INFO) on Windows
for a LOG(INFO) that had a TODO to switch to DLOG once crbug.com/730068
is fixed (which it now is).

Other than that, no behavior change.

Bug: 730068,346399
Change-Id: Ifa5cef7e27f3fc2f45ac30fe2769eeb6c44b5d5a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113738
Auto-Submit: Nico Weber <thakis@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752493}

Bug: 926234
Change-Id: I453092f47dd059a48ed1579bcb63d700739909eb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042217
Commit-Queue: Joshua Pawlicki <waffles@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752492}

Change-Id: I1b1f1cf0daf1a7f3eb468a9c2ab5f6c6652b5ab5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116132
Commit-Queue: Dana Fried <dfried@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752491}

Currently, PageInfo embeds function pointers in a ChooserUIInfo struct
that map from a Profile to the appropriate ChooserContextBase instance
that is associated with the Profile. However, this organization blocks
componentization of PageInfo.

This CL instead has PageInfo obtain the ChooserContextBase instance to
use for a given ChooserUiInfo via the delegate; the Chrome delegate
impl has access to the Profile and can key off the ContentSettingsType
param in the ChooserUiInfo object to determine the appropriate
ChooserContextBase instance to fetch. External clients of the prior
ChooserUIInfo functionality all have access to a PageInfo instance,
hence, they are ported to this model as well via PageInfo exposing the
necessary API publicly.

Bug: 1052375
Change-Id: Ic6750e5504fb7b2ea23dc6b3cff64542d44b6084
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111171
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752490}

This framework is now unused.

Bug: 496955
Change-Id: I025cb6281f4251d1ea92e99bcb33b59ef50dcc5b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115691Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752489}

Milestone M82 is being abandoned, so the beta bucket is entirely
removed.

Change-Id: I4e99bfc8c925c492fb1fa818c6e08e37eb0d3b93
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108906
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752488}

TBR=govind@chromium.org

Change-Id: Ic7be7779376b6c8d421135f99052d7cc8c2b6477
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115692Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752487}

This is no longer needed with data reduction proxy being turned off.

This removes the logic for
(i) Adding/removing proxy-specific pre-cache and post-cache headers
(ii) Remembering redirect loops within proxy delegate and disabling
custom proxy on redirect loops.
(iii) Use of alternate proxies for http:// requests (this was a
hack to enable use of QUIC for custom proxies for http:// requests).
(iv) Remembering the last N custom proxy configurations
in proxy delegate.

Change-Id: I4ee0cca48c1d581e026738964cb9e7a27f57a92e
Bug: 1048736
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101318
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752486}

kCGColorSpaceITUR_2020_HLG expects values in the range of [0, 12], while
the rest of the pipeline expects values in the range of [0, 1].

Bug: 1061723
Change-Id: Ia46b3cde31515c7026607bc2a6e8e4b981ab9abc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110674
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752485}

Following on conversation from patch 2087403 that discusses the use
of nullability annotations in Chrome. Add a presubmit check that
ensures stricter rules on the use of Nullability in Obj-C as defined
by https://github.com/google/styleguide/blob/gh-pages/objcguide.md#nullability.

Change-Id: I57d92ad1551815f609e8bc7fc7ddc29202b05c22
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111181
Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
Reviewed-by: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752484}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/d423d43a0f50..7fa2d5f5ff44

git log d423d43a0f50..7fa2d5f5ff44 --date=short --first-parent --format='%ad %ae %s'
2020-03-23 ahassani@chromium.org xbuddy/build_util.py: Remove it
2020-03-22 vapier@chromium.org portage_util: drop binutils test hardcode
2020-03-21 vapier@chromium.org virtualenv_wrapper: convert all users to python3 only
2020-03-21 vapier@chromium.org portage_util: respect RESTRICT=test for cros_workon ebuilds
2020-03-20 vapier@chromium.org cros_sdk: convert to python3 only
2020-03-20 vapier@chromium.org cros_extract_deps/cros_workon: convert to python3 only
2020-03-20 vapier@chromium.org portage_util: add VDB_PATH constant for /var/db/pkg
2020-03-20 vapier@chromium.org cli deploy/flash: convert to python3 only
2020-03-20 vapier@chromium.org gerrit: fix some actions after rewrite
2020-03-20 gbiv@google.com generate_board_object_listing: support multiple package versions
2020-03-20 engeg@google.com chromite: add chromeos-base/chrome-icu to OTHER_CHROME_PACKAGES

Created with:
  gclient setdep -r src/third_party/chromite@7fa2d5f5ff44

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:chromeos-kevin-rel
Bug: None
Tbr: chrome-os-gardeners@google.com
Change-Id: I247bf7e3b6a63bbe8309a658a562c5e8a212a6c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115507Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#752483}

This change implements the delegate for the geolocation permission
context in WebLayer. In addition, it adds necessary functionality to
request Android permissions if necessary.

Still needs to be done:
- Remove FakePermissionManager which is currently being used in
  geolocation instrumentation tests.
- Make prefs persistent. Right now you have to re-allow geolocation
  permission on every restart.

Bug: 1025625, 1025609
Change-Id: I97dca79f0e1ecaa45bea1df89d126a9a244f368e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2110519
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752482}

The method names are now capitalized.

Change-Id: Id9abdd66faa17b2f9d04c491509d6e234ffa50f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113445Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Wan-Teh Chang <wtc@google.com>
Cr-Commit-Position: refs/heads/master@{#752481}

This documents the Chromium standards for .icns files, and commits the
tools to use to create them. (For reference, check out
https://crbug.com/576173 wherein these restrictions were discovered.)

Note also that many of these tools are from https://crbug.com/846451#c10
which Mark used to create our current set of icons.

Bug: 846451
Change-Id: I0030e9f883a1c068ef425ee0139b14da112e97d4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2101316
Commit-Queue: Avi Drissman <avi@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752480}

Remove code that is never executed.

Change-Id: Ife77329b7a911f2beae96b67c0efac582e54266d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115653
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Auto-Submit: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Robbie Gibson <rkgibson@google.com>
Cr-Commit-Position: refs/heads/master@{#752479}

Now that all PerformanceManagerImpl's public methods are static, there
is no need to external callers to directly retrieve the instance
pointer. The function must still exist to implement
CallOnGraphAndReplyWithResult() in the header file.

With this change, it's possible to get rid of
g_performance_manager_from_any_sequence, which was replaced with a
boolean value so that IsAvailable() can still be implemented.

In addition, some comments to public methods were reworded so that
they are consistent and up-to-date.

Bug: 1013127
Change-Id: Id3b355347e4bdf6924ccbf3e0ff940987c9f46a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108092
Commit-Queue: Patrick Monette <pmonette@chromium.org>
Reviewed-by: Sigurður Ásgeirsson <siggi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752478}

TBR=dvadym

Bug: 1063723
Change-Id: I3f94f4763e1bb6f2bc785d1c922c7652435c8e5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115474Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Reviewed-by: Vadym Doroshenko <dvadym@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752477}

In order to solve difficult problems such as crbug.com/552085,
interpolations must be applied using the same cascade as where the
MatchResult was analyzed. This means we'll skip applying the
interpolation if an !important declaration exists for the same
property.

This CL:

 - Moves the MatchResult out of ElementRuleCollector. MatchResult must
   now be passed to ApplyAnimatedStandardProperties, hence it must
   outlive ElementRuleCollector.
 - Lifts the on-stack StyleCascade up to StyleForElement, such that it
   can be used in both ApplyBaseComputedStyle and ApplyAnimated-
   StandardProperties.
 - Sets as flag on StyleResolverState when an interpolation effect is
   skipped during Apply. This means something was !important, and we
   can't use the base-computed-style optimization.
 - Clears the base-computed-style if the above flag is set.
 - Due to how the base computed style optimizations works when DCHECK
   is on, it was necessary to add Reset functions to StyleCascade and
   MatchResult (see explanation near MaybeResetCascade).

This is a web-facing change: !important declarations will now override
declarations in the animation origin. WPT for this was apparently non-
existent, so this CLs adds a few tests (that also pass in Firefox).

Bug: 552085, 985049
Change-Id: I538f73936e96e1bd974e0855b081e99bf947e6a2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2064248
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752476}

This code path was never triggered (see isInImmersiveMode impl) and the newer immersive mode from last year uses the same mechanism as Aura.

Bug: 1063417
Change-Id: I723f4a58a55b0cb9abac1c6c6df2e2b0ec477f29
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112931Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752475}

To facilitate testing of multi-window features and interactions, this
CL adds a "New Window" menu item on iPad devices compiled under
Debug with multi-window enabled.

Change-Id: I41e9483848631e250fb6e4b8c32e10b59653f960
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115612Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Mark Cogan <marq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752474}

This reverts commit 389d6f8d.

Reason for revert: still flaky on Windows
https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVySAsSBUZsYWtlIj1jaHJvbWl1bUBibGlua193ZWJfdGVzdHNAZXh0ZXJuYWwvd3B0L2Nvb2tpZXMvcGF0aC9tYXRjaC5odG1sDA

Original change's description:
> Delete flaky expectation for external/wpt/cookies/path/match.html
> 
> The test does not seem to be flaky recently.
> 
> TBR=smcgruer
> 
> Fixed: 986477
> Change-Id: Ic09e0466315be8d39d7acfe406be5e6bfd29525a
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113511
> Reviewed-by: Robert Ma <robertma@chromium.org>
> Commit-Queue: Robert Ma <robertma@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#752213}

TBR=smcgruer@chromium.org,robertma@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Change-Id: I13eebe4b4b95843d4dad1ad2706e71f5e599f96e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115871Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752473}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8cb91971a35b..aa550dd6d8b8


Created with:
  gclient setdep -r src-internal@aa550dd6d8b8

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1056962
Tbr: jbudorick@google.com
Change-Id: I699f872309a01ded8863371c93f7a7a1b061a33a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115503Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#752472}

This reverts commit e9f81dc4.

Reason for revert: https://bugs.chromium.org/p/chromium/issues/detail?id=1063845

Original change's description:
> Switch Win Exp bot to 26.20.100.7870
>
> Switches the GPU Win10 Intel experimental bot to trigger tests on
> machins with driver 26.20.100.7870 to test the stability.
>
> TBR=ynovikov@chromium.org
>
> Bug: 1053803
> Change-Id: I3fa8467656312288add0658a3e4b7dfb9c5ac2d8
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111470
> Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
> Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
> Commit-Queue: Yuly Novikov <ynovikov@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#751911}

TBR=ynovikov@chromium.org,bsheedy@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1053803,1063845
Change-Id: I1550fb41247be307defaa184c5bdd4be80a75ab6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115458
Commit-Queue: Peng Huang <penghuang@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752471}

https://skia.googlesource.com/skia.git/+log/59e7496d4e83..cad8fba253af

git log 59e7496d4e83..cad8fba253af --date=short --first-parent --format='%ad %ae %s'
2020-03-23 robertphillips@google.com Make GrFillRRectOp a GrMeshDrawOp
2020-03-23 bsalomon@google.com Specialize scale+translate transforms for explicitly sampled FPs.
2020-03-23 mtklein@google.com remove dither TODO
2020-03-23 mtklein@google.com smarter SkColorInfo::isOpaque()
2020-03-23 borenet@google.com [infra] Fix lottie-ci bots to use the correct asset name
2020-03-23 kjlubick@google.com Fix matrix scoping issue in sample

Created with:
  gclient setdep -r src/third_party/skia@cad8fba253af

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC robertphillips@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: robertphillips@google.com
Change-Id: I06e5bf736c3d90be54d9baedd928ab969d9338ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115509Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#752470}

This makes the emitted .csv much easier on the eyes and is better
suited for importing into spreadsheets etc.

Bug: 973801
Change-Id: Ic67ba5d251558830e1c27b59c3b3f69e962b7dc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115693Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Asanka Herath <asanka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752469}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/bc540552..079cda55

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I39513d1533fede2af0f53ffd8536f60f9019609e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115750Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#752468}

This metric is needed to make sure list accounts works well. This CL
extend the lifetime of the histogram to never expire.

Bug: 1059816
Change-Id: I15a257d54fa85a0c64649474e0cb979c8af91475
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115515Reviewed-by: Alex Ilin <alexilin@chromium.org>
Commit-Queue: Monica Basta <msalama@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752467}

External Android apps may use mayLaunchURL() API to notify
the default browser of the next likely navigation. This API
may be used by the external app to notify browser of the set
of URLs that user may navigate to next.

This CL plumbs that information to the navigation predictor keyed
service. Note that this information is currently not used
in any way (except for recording a local histogram).

Change-Id: I93bfe53a0f15116563021fa45768f9ca459f06d2
Bug: 1014210
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928035
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Benoit L <lizeb@chromium.org>
Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Sophie Chang <sophiechang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752466}

This is to make it easier to identify if there are new commits to be
merged from the Feed git repo.

Change-Id: I7e50b766f04070b33166cd2326ae390fbc5e2dac
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108916Reviewed-by: Dan H <harringtond@chromium.org>
Commit-Queue: Dan H <harringtond@chromium.org>
Auto-Submit: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752465}

Refactors a test DistillabilityObserver for use in multiple
browsertests.

Adds DCHECK and adjusts tests to use an observer so as not
to hit the DCHECK.

Bug: 1061928
Change-Id: I152d2be5adab1da96cebae5cf2654a5fc8e82e35
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2112581
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752464}

This CL:
- Forward declares dependencies in AssistantViewDelegate instead of
  directly including in the header
- Exposes AssistantAlarmTimerModel in AssistantViewDelegate
- Removes the Assistant standalone UI skew of AssistantMainStage that
  somehow escaped deletion

This CL is a prequel to:
https://chromium-review.googlesource.com/c/chromium/src/+/2109823

Bug: b:149570650
Change-Id: Ia636a4d553d012fc153b1bddddc75ec0ecec6285
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2109829Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#752463}

Various tests in AndroidViewIntegrationTest have been flaky for some
time; analyzing failing test logs shows that the WebView renderer is
being shut down while the test is waiting for a callback to occur, many
seconds before the callback timeout is reached. This suggests the
AwContents is becoming unreachable earlier than expected and being GCed.

The Java language spec explicitly permits optimisations which shorten
the lifetime of stack variables - since in many of these tests the only
reference to the AwTestContainerView or AwContents is a stack reference
which is never accessed after loading the initial content, it's entirely
possible for this class of optimisation to break the test.

Store the AwTestContainerView in an instance variable on the test class
instead to prevent this, and ensure its lifetime matches the test class
- this optimisation is not permitted for heap references.

Bug: 949391
Bug: 1058304
Change-Id: Ie6865f6dd7219f5a2d75c914e805d3989f930573
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2113411Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752462}

This CL removes the Android specific Bundle from the startup calls,
replacing it with our own implementation of a parameters class.

Bug: b/151821740
Change-Id: I7a1dd7cbd48cd331af9ed5d4186b0c3d2792ed8f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108504Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Reviewed-by: Mathias Carlen <mcarlen@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Sandro Maggi <sandromaggi@google.com>
Cr-Commit-Position: refs/heads/master@{#752461}

On Chromium CI, this occasionally dips above 6s and times out. Looks
like its just a bit slow, not hanging entirely, so giving it more time
to finish seems ok.

Bug: 1042453
Change-Id: I716cf62e0e83eaecb61be1cbfa1921fe6a6ba860
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115555
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752460}

We are currently toggling the "mobile layout theme" without notifying
Blink that platform colors may have changed. This means that
ComputedStyles produced by the mobile layout theme ended up in the
matched properties cache, which in turn means that device emulated
styles can leak into into the real page when devtools is closed.

To fix this, call Page::PlatformColorsChanged when the mobile theme is
turned on or off.

Bug: 1061875
Change-Id: Ibee9751d0837bc056ffe41272ec496b390e4c8db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105377
Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#752459}