- 15 Oct, 2018 40 commits
-
-
Matthew Cary authored
The bugs below suggest that under thinLTO, the system health orderfile regresses memory, as well as performance (the latter probably even without thinLTO). This CL reverts back to the simpler orderfile. Bug: 758566,893981,894827 Change-Id: I93c898dd7c8d55311ac3aed08815c610573c49c2 Reviewed-on: https://chromium-review.googlesource.com/c/1277804Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#599592}
-
Henrik Grunell authored
Example log line: AudioService: AudioStreams=enabled, OutOfProcess=enabled, LaunchOnStartup=enabled, Sandbox=enabled, ApmInAudioService=enabled Bug: 888971 Change-Id: I17cb7b1acafa7ff41c5fe9de67ed176c9008c7a7 Reviewed-on: https://chromium-review.googlesource.com/c/1278752Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Commit-Queue: Henrik Grunell <grunell@chromium.org> Cr-Commit-Position: refs/heads/master@{#599591}
-
Yutaka Hirano authored
It's now not used. Bug: 875153 Change-Id: Ia7d42f503617563c1d4e82c9eaa0c67aae36baa1 Reviewed-on: https://chromium-review.googlesource.com/c/1275487Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#599590}
-
Adam Rice authored
When blink::BodyBuffer::StartLoading failed , the ScriptPromiseResolver was left unresolved, resulting in a DCHECK when it was destroyed. Resolve it explicitly in this case, to avoid the DCHECK and retain the invariant. BUG=893015 Change-Id: Ib437986c6dc0d8b40e8ed0040f8796387d94feb6 Reviewed-on: https://chromium-review.googlesource.com/c/1278613Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#599589}
-
Florent Castelli authored
TBR=nednguyen@google.com Bug: 895238 Change-Id: Ice423436c23c47a4334edf0928afe143c211286c No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/1280242Reviewed-by:
Florent Castelli <orphis@chromium.org> Commit-Queue: Florent Castelli <orphis@chromium.org> Cr-Commit-Position: refs/heads/master@{#599588}
-
Kenichi Ishibashi authored
Before this CL we recorded worker ready time just after getting a mojo pointer to the controller service worker, but getting the mojo pointer doesn't guarantee that the controller service worker is actually running. This means that the recorded timing didn't capture worker startup delay. To have more accurate timing, use |dispatch_event_time| of ServiceWorkerFetchEventTiming as worker ready time. |dispatch_event_time| is recorded just before dispatching a fetch event so this is reasonable. Cq-Include-Trybots: luci.chromium.try:linux_mojo Bug: 877972 Change-Id: Ifb8e905095794770dd8a4973e1e0d569ccfde00e Reviewed-on: https://chromium-review.googlesource.com/c/1278459 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#599587}
-
BUG=762641 TBR=achuith@google.com Change-Id: I20f03272b5b8fffca13ebaafac94237c2668ef51 Reviewed-on: https://chromium-review.googlesource.com/c/1280144 Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599586}
-
Roman Sorokin authored
BUG=chromium:887577,chromium:875480 Change-Id: I0579e0694e1e4f7c9ed3f1988f623b2558a36e40 Reviewed-on: https://chromium-review.googlesource.com/c/1278167Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Roman Sorokin <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#599585}
-
Max Rebuschatis authored
Bug: 837834 Change-Id: I7d3b81b0ae2290e58d18a623dc0f573afe83d955 Reviewed-on: https://chromium-review.googlesource.com/c/1197225Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Max Rebuschatis <lincolnfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#599584}
-
Tetsui Ohkubo authored
This CL implements stacking notification counter at the top that shows number of hidden notifications above the visible area. NewUnifiedMessageCenterView will replace UnifiedMessageCenterView. It's behind a flag: --enable-features=NewMessageListView TEST=NewUnifiedMessageCenterViewTest BUG=769219 Change-Id: I829c75ae4642c7cf0d7408defe3d59c1a68977a2 Reviewed-on: https://chromium-review.googlesource.com/c/1278690Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#599583}
-
Takashi Sakamoto authored
BUG=888904 Change-Id: I5e8b2d3d3e2d0975cc5713fdae4b85969308a906 Reviewed-on: https://chromium-review.googlesource.com/c/1264435Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#599582}
-
Darren Shen authored
This reverts commit a643a13e. Reason for revert: <INSERT REASONING HERE> Original change's description: > [VK] Hide the virtual keyboard when we enter window overview mode. > > When we enter window overview mode (e.g. by dragging the top of an app), > we need to hide the virtual keyboard because: > > 1) It blocks the overview mode UI for no reason. > 2) The previews of windows have blank space at the bottom because that's > where the keyboard is. > > Bug: 893856 > Change-Id: I4f79f6bf603fd074a62b7ba29366ec5af18bbab2 > Reviewed-on: https://chromium-review.googlesource.com/c/1278565 > Commit-Queue: Darren Shen <shend@chromium.org> > Reviewed-by: James Cook <jamescook@chromium.org> > Reviewed-by: Xiaoqian Dai <xdai@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599561} TBR=jamescook@chromium.org,xdai@chromium.org,shend@chromium.org Change-Id: Ie5ff6ccd70f24b40ba861c08de1467f87f7fcd62 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 893856 Reviewed-on: https://chromium-review.googlesource.com/c/1280093Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#599581}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e99cee81..b8de6fec Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Binary-Size: autoroller Change-Id: Ib9034fdf308773f720c8d730ad239845a93f4daf Reviewed-on: https://chromium-review.googlesource.com/c/1279961Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599580}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2b20c6f0282d..ce051618ed0f Created with: gclient setdep -r src-internal@ce051618ed0f The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I74734ac8304f52666d6ffee16779e10b41bded09 Reviewed-on: https://chromium-review.googlesource.com/c/1280104Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599579}
-
rhalavati@chromium.org authored
Removal of user data from Android Media and WebRTC notifications is enabled. Bug: 629887 Change-Id: Iafda3010a7b0079e7220be2fbca0d67522a75407 Reviewed-on: https://chromium-review.googlesource.com/c/1278626Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#599578}
-
tzik authored
This CL contains IWYU fixes and an ADL elimination in order to maintain base::Optional replaceable with std::optional. color_helpers.cc and navigation_url_loader.h used to depend on the indirect include directives around base/optional.h, that will be unavailable on the C++17 mode build. In render_widget_unittest.cc, a base::Bind name is pulled by base::Optional on the parameter type of HandleCallback, which will be unavailable after base::Optional is replaced with std::optional. Tbr: dtrainor@chromium.org Change-Id: I132b02da61484f72020e9f7fb5b12c8a21a22d37 Reviewed-on: https://chromium-review.googlesource.com/c/1280063 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#599577}
-
Sergei Datsenko authored
Those have absolutely no need to be forward-declared and it just makes navigating through the file a pain. BUG=chromium:883637 Change-Id: I13b671d077e8a778ca79ceb33272c757cea427a0 Reviewed-on: https://chromium-review.googlesource.com/c/1280089Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sergei Datsenko <dats@chromium.org> Cr-Commit-Position: refs/heads/master@{#599576}
-
Kent Tamura authored
* Document::sequential_focus_navigation_starting_point_ count be a disconnected Range if a shadow tree including a focused element is disconnected. Introduce Range::FixupRemovedNodeAcrossShadowBoundary() to keep connected nodes in the Range. * Range::FirstNode() can be a ShadowRoot if a focused element in it is disconnected. We use FlatTreeTraversal instead of ElementTraversal to find a neighbor element. Bug: 705786 Change-Id: I51986133fd2ce01fe14a96d19c0ab4e477667feb Reviewed-on: https://chromium-review.googlesource.com/c/1278408 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#599575}
-
Zhuoyu Qian authored
The parameter |scope| is unused, remove it. The member |scope_| of ServiceWorkerProcessManagerTest is unused, remove it also. BUG= Change-Id: I32dbdc1502ff6b8b121ca4d1f09cec325d1b9cd9 Reviewed-on: https://chromium-review.googlesource.com/c/1278453 Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/76988a8c5288..03da150665d9 git log 76988a8c5288..03da150665d9 --date=short --no-merges --format='%ad %ae %s' 2018-10-15 tandrii@chromium.org git cl: delete Rietveld support for tryjobs. 2018-10-15 tandrii@chromium.org git cl: start deleting Rietveld support. 2018-10-15 tandrii@chromium.org git cl: find which reviewers and ccs are OK for Gerrit before upload. Created with: gclient setdep -r src/third_party/depot_tools@03da150665d9 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:770408,chromium:770408,chromium:877717 TBR=agable@chromium.org Change-Id: Ifec259dcabd7bbfc452b6add83110b2d377dd29f Reviewed-on: https://chromium-review.googlesource.com/c/1280103Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#599573}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=gbiv@chromium.org Change-Id: I819f92cbfa8a272e5161bedc95a2cfc0f78a7063 Reviewed-on: https://chromium-review.googlesource.com/c/1280105Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/681692726fc0..646d917d3c71 git log 681692726fc0..646d917d3c71 --date=short --no-merges --format='%ad %ae %s' 2018-10-15 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-10-15 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@646d917d3c71 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=egdaniel@chromium.org Change-Id: I411ca0c376ef6d52873afc59dc2a5457452da816 Reviewed-on: https://chromium-review.googlesource.com/c/1280102Reviewed-by:
-
Hiroshi Ichikawa authored
Looks like the macro is deprecated per the comment at the bottom of the file. Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: If7763f67d427d03c150ec10b28a3d570ceef0f67 Reviewed-on: https://chromium-review.googlesource.com/c/1272758Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#599570}
-
Takashi Sakamoto authored
BUG=888904 Change-Id: I82f7cc310b32a18df79dd46756d685aee03f0276 Reviewed-on: https://chromium-review.googlesource.com/c/1272935Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#599569}
-
Naoki Fukino authored
We have been showing the notification after successful ext4 migration. This notification is getting less useful since most users have already migrated to ext4, and we hear several feedback reports that the notification was shown at unexpected timing. Let's remove the notification as a simple fix and a clean-up. (Removing the notification was approved by PM.) Bug: 894707 Test: Manually confirmed that the notification was not shown after migration on Kevin. Change-Id: Ide3237a57a127974eed6f1619fc5e096f911f72a Reviewed-on: https://chromium-review.googlesource.com/c/1278666 Commit-Queue: Naoki Fukino <fukino@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#599568}
-
Anand K. Mistry authored
BUILD.gn rules already exclude the zip_archiver from being built and packaged if NaCl is disabled. BUG=841518 Change-Id: Ib4f1a7e204c91fd17fb3c9edb6b5618075ef9f9c Reviewed-on: https://chromium-review.googlesource.com/c/1279176Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#599567}
-
Noel Gordon authored
Convert this test to a testharness test. With CL:823582 this test does not crash, and does crash prior to that change. Note: this test uses shadomDOM V0 registerElement and createShadowRoot since the crash does not reproduce when using shadowDOM V1 methods. Bug: 789094, 804047 Change-Id: Ia65c2f75b805ed99a7401d5b64110601f917a5d7 Reviewed-on: https://chromium-review.googlesource.com/c/1278456Reviewed-by:
Hayato Ito <hayato@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#599566}
-
Takashi Sakamoto authored
BUG=888904 Change-Id: I65002e69cc3dba6acb061bcc4853d10ede1cbe68 Reviewed-on: https://chromium-review.googlesource.com/c/1272958Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Takashi Sakamoto <tasak@google.com> Cr-Commit-Position: refs/heads/master@{#599565}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/dd78844442fe..76988a8c5288 git log dd78844442fe..76988a8c5288 --date=short --no-merges --format='%ad %ae %s' 2018-10-15 tandrii@chromium.org git cl: compute reviewers and ccs before pushing change to Gerrit. Created with: gclient setdep -r src/third_party/depot_tools@76988a8c5288 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:877717 TBR=agable@chromium.org Change-Id: Ia5c90f260a9239b90bd2f366c0bdd0c66eabfc53 Reviewed-on: https://chromium-review.googlesource.com/c/1279283Reviewed-by:
-
Fergal Daly authored
This is the agreed name for this attribute. Bug: 805271 Change-Id: I806c8933d90e98d2e132b7b260f8544563b1f94d Reviewed-on: https://chromium-review.googlesource.com/c/1278620Reviewed-by:
Fergal Daly <fergal@chromium.org> Reviewed-by:
-
Rakina Zata Amni authored
In some cases such as multiple frame webpages, idle task might never execute or take a noticably long time to execute. This might lead to incorrect number of find-in-page result and not highlighting matches because the scoping is never trigerred. This CL adds a deadline to scoping idle tasks to ensure all scoping happens in a timely manner. Bug: 890622,893465 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I8ec998d4c2f42377361c1f7b95c1497a80368ef6 Reviewed-on: https://chromium-review.googlesource.com/c/1270196 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
-
Darren Shen authored
When we enter window overview mode (e.g. by dragging the top of an app), we need to hide the virtual keyboard because: 1) It blocks the overview mode UI for no reason. 2) The previews of windows have blank space at the bottom because that's where the keyboard is. Bug: 893856 Change-Id: I4f79f6bf603fd074a62b7ba29366ec5af18bbab2 Reviewed-on: https://chromium-review.googlesource.com/c/1278565 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#599561}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/697d4bdafa2b..2b20c6f0282d Created with: gclient setdep -r src-internal@2b20c6f0282d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ib00679b4c903bd02023cbd5fbe3be9b14f6f7fc9 Reviewed-on: https://chromium-review.googlesource.com/c/1279281Reviewed-by:
-
David Staessens authored
This change removes the "Mesa Gallium driver" from the blacklist in the vaapi JPEG decoder. TEST=ran VDA tests on Grunt Bug: 828119 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I1100cbebcc7f2a2eca3c6109fa120db764543a95 Reviewed-on: https://chromium-review.googlesource.com/c/1256462 Commit-Queue: David Staessens <dstaessens@chromium.org> Reviewed-by:
Pawel Osciak <posciak@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#599559}
-
Renee Wright authored
Bug: 894665 Change-Id: Ie894955b7f5095c19135385437392d8c12dc3223 Reviewed-on: https://chromium-review.googlesource.com/c/1278428 Commit-Queue: Renée Wright <rjwright@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=govind@chromium.org Change-Id: I67abe9bb58b68b07a46a61a2850fe08329656d1c Reviewed-on: https://chromium-review.googlesource.com/c/1280049Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#599557}
-
Patti authored
This reverts commit 2bd206ee. Reason for revert: This patch may be the culprit behind cc_unittest TreeSynchronizerTest.SynchronizeScrollTreeScrollOffsetMap failing on Linux ChromiumOS MSan Tests [20 out of the last 20 builds have failed] and Linux MSan Tests [21 out of the last 21 builds have failed]. Reverting to try and fix. Original change's description: > BrowserControlsState updates CC and commits to Blink > > The linked bug is a result of the fact that we send and handle browser > controls state updates on both the main and compositor threads. When a > non-animated hide is followed by a animated hide, we start an animation > on the compositor thread but immediately hide the top controls on the > main thread. When we commit the browser controls delta, the controls > hide but the animation continues to play so the next frame re-shows the > controls. Additional updates may stop the animation so we'd see the > controls in a half-way hidden state. > > Currently, UpdateBrowserControlsState sends animated commands to be > handled by CC (since Blink doesn't know how to animate), but because of > https://crbug.com/754346, non-animated commands are sent to Blink. When > the browser process sends a series of interweaved commands to the render > this leads the the clamping bug discussed above. > > This CL fixes this issue by making the compositor-side the real source- > of-truth and pushing the changes to Blink. Both CC and Blink must be > made aware of the browser controls constraints, since scrolls may be > handled by either. However, we now always inform CC first and let it > push the differences to Blink. This happens as part of > ApplyViewportChanges during a commit. > > Bug: 861618 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel > Change-Id: I6cb6a6480804fff05e6aee65166bf0d303fb677d > Reviewed-on: https://chromium-review.googlesource.com/c/1205797 > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Reviewed-by: enne <enne@chromium.org> > Reviewed-by: Alex Moshchuk <alexmos@chromium.org> > Commit-Queue: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599523} TBR=bokan@chromium.org,chrishtr@chromium.org,enne@chromium.org,alexmos@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 861618 Change-Id: I6738ee1fb616e2b06b5a466546a8f47bcaeb7d79 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Reviewed-on: https://chromium-review.googlesource.com/c/1278460Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Patti <patricialor@chromium.org> Cr-Commit-Position: refs/heads/master@{#599556}
-
Victor Vasiliev authored
This was temporary measure to debug the source of internal errors, and it was never ported into google3 copy of QUIC. R=rch@chromium.org Change-Id: I1b1d94d21b3a8dbb4f8ff1cd276bd801126d64bd Reviewed-on: https://chromium-review.googlesource.com/c/1277929Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Victor Vasiliev <vasilvv@chromium.org> Cr-Commit-Position: refs/heads/master@{#599555}
-
John Z Wu authored
This is necessary to receive updates from the sync server. Bug: 867548 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I72d0f260d376a16337ddeb1c7a94e7a45508c04a Reviewed-on: https://chromium-review.googlesource.com/c/1277984Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Commit-Queue: John Wu <jzw@chromium.org> Cr-Commit-Position: refs/heads/master@{#599554}
-
Xianzhu Wang authored
The original functions dumpChildFrameScrollPositions(), dumpChildFramesAsText() and dumpChildFramesAsMarkup() did almost the same thing while each had its own applicable condition. Combine them to simplify API and prevent wrong usages. This is a pre-cleanup of making pixel tests not dump text by default (https://chromium-review.googlesource.com/c/chromium/src/+/1277654). Bug: 703899 Change-Id: I41adff013a512e6e247b3c12080a71dd3a8ac99f Reviewed-on: https://chromium-review.googlesource.com/c/1278057 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#599553}
-
