GitLab

- Now records "EnableSync" responses
- Now records "SignoutPrimary" correctly during Dice migration

Bug: 736310
Change-Id: I5b4e8e60ecaab18cac2454986f5849565529976a
Reviewed-on: https://chromium-review.googlesource.com/891220Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532823}

This shorcut will select or unselet all items.

Bug: 792897
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I9d0854c6e8bee90c947c741fc0ac4d14acd28e9d
Reviewed-on: https://chromium-review.googlesource.com/885692Reviewed-by: calamity <calamity@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532822}

We had a bug that createElementNS() ignored prefixes.
New behavior matches to the specification and Firefox.

* Document-createElementNS.html:
  Fix a copypasta error.

* ScriptCustomElementDefinition::CreateElementSync:
  Implement Step 6.1.10.

* Document::createElementNS:
  Fix an argument of definition lookup.

* CustomElement::CreateUndefinedElement:
  Use Document::CreateRawElement(), which sets prefixes correctly,
  instead of HTMLElementFactory::createHTMLElement().

* ustomElementDefinition::CreateElementAsync:
  Use Document::CreateRawElement(), which sets prefixes correctly,
  instead of HTMLElementFactory::createRawHTMLElement().

Bug: 806639
Change-Id: I74b431d4475d7cf84f65ab0ff1b24773cbc64079
Reviewed-on: https://chromium-review.googlesource.com/892802Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532821}

This fixes the following error in jumbo builds:

/../../third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationDelegateTest.cpp:51:46: error: unknown class name 'Test'; did you mean '::testing::Test'?
class ScreenOrientationDelegateTest : public testing::Test {
                                             ^~~~~~~~~~~~~
                                             ::testing::Test

Followup after https://chromium-review.googlesource.com/c/chromium/src/+/848735

TBR=haraken@chromium.org

Bug: 678545
Change-Id: Ide6d0c6c0c7b8f1d45acad9aeca1e7998e5fa94e
Reviewed-on: https://chromium-review.googlesource.com/891959Reviewed-by: Mostyn Bramley-Moore <mostynb@vewd.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Cr-Commit-Position: refs/heads/master@{#532820}

We're rolling out this feature. The feature flag is enabled by default
at ToT.

Bug: 705400
Change-Id: Iccaa68d13a6d1989870bdb596f231b30cb4d7f00
Reviewed-on: https://chromium-review.googlesource.com/892189Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532819}

This CL was uploaded by git cl split.

R=vabr@chromium.org

Bug: 177475
Change-Id: I9f5deffdff32fbb2b733a3d3b8110638bac04bbb
Reviewed-on: https://chromium-review.googlesource.com/891779Reviewed-by: Vaclav Brozek <vabr@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532818}

This patch contains
1. Test added to verify [TreatNullAs=EmptyString] behavior of |mediaText|
   attribute of MediaList.
2. Update MediaList |mediaText| IDL attribute to match the specification.
   https://drafts.csswg.org/cssom/#the-medialist-interface

Bug:

Change-Id: I6cf9380390113e3ec8f37c796b0f6fd68e2de6c8
Reviewed-on: https://chromium-review.googlesource.com/892718
Commit-Queue: Bhagirathi Satpathy <bhagirathi.s@samsung.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532817}

When the inline reply row is appering right after a "REPLY" button is clicked, the row is light gray first, and change to blue like ink drop.

Bug=803757

Change-Id: Ie2e482be0de5edae2ff581c84c755545cd3beaf5
Reviewed-on: https://chromium-review.googlesource.com/890979
Commit-Queue: Megumi Hattori <megumihattori@google.com>
Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532816}

https://chromium.googlesource.com/angle/angle.git/+log/e4741fd0f2bc..5dd4ad896bcb

$ git log e4741fd0f..5dd4ad896 --date=short --no-merges --format='%ad %ae %s'
2018-01-29 jmadill Vulkan: Add a perf test for the Pipeline cache.
2018-01-25 oetuaho Resubmit: Use ImmutableString for HLSL texture references
2018-01-29 oetuaho Only return symbol from TSymbolTable::find

Created with:
  roll-dep src/third_party/angle


The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=jmadill@chromium.org

Change-Id: Ibcca7649679b317324dc3a5d22c1aa07545e86ac
Reviewed-on: https://chromium-review.googlesource.com/892367
Commit-Queue: angle-deps-roller . <angle-deps-roller@chromium.org>
Reviewed-by: angle-deps-roller . <angle-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532815}

R=horo

Bug: 780435
Change-Id: Ie8ae9cf8dca55f122a7b4a984ca0a96035b0099f
Reviewed-on: https://chromium-review.googlesource.com/892683Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532814}

Intent to implement and ship:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/o9Pnen-jNcI

Bug: 534245
Change-Id: Iac7c42c1f284f5022ce2043acccafc05ff7c8e9c
Reviewed-on: https://chromium-review.googlesource.com/883064Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Shanmuga Pandi <shanmuga.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#532813}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/10835cef..cbd2275f

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Ic9ba6a2a79bb613bec2eebaa32fa52f3b8347886
Reviewed-on: https://chromium-review.googlesource.com/892639Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532812}

The different states of the export flow are implemented as separate dialog instances
which replace each other.

Mocks:
https://docs.google.com/presentation/d/1nIm5OmaOnb85ZAwMZPSVqHT0vkFbsRYZhOzbmznWU_c/edit#slide=id.g289b1efcd8_0_4

Bug: 789561
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: Id25af371164196ee8fffec723f080be2320e5b22
Reviewed-on: https://chromium-review.googlesource.com/800611Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Christos Froussios <cfroussios@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532811}

The OverrideState enum is converted in this CL to plain integers and
@IntDef for efficiency. More context on the associated bug.

Bug: 806315
Change-Id: Ie7b5d777394ca77c9f9447d8db33754bcf9f7017
Reviewed-on: https://chromium-review.googlesource.com/889738Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Vaclav Brozek <vabr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532810}

Nullable<T> is bindings-specific and does not seem to offer any advantage
over WTF::Optional<T> and its //base counterpart, which are more widely used
and maintained.

Using Optional<T> with a garbage-collected type remains forbidden, but using
it with a GC container type such as HeapVector is OK.

Most of the changes in this CL are fairly mechanical: replace includes and
adjust to API differences (.value() instead of .Get(), WTF::nullopt instead
of nullptr etc). Everything should remain the same in terms of
functionality.

Bug: 798464
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I988f7cb4a941439cb9a6ab0d2c3bc26c78e59f00
Reviewed-on: https://chromium-review.googlesource.com/891178
Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532809}

Move the screen_orientation_dispatcher from //content/renderer/ to //blink.

After the moving, the screen_orienation_dispatcher actually acts as a delegate
of ScreenOrientationControllerImpl, it holds a
device::mojom::blink::ScreenOrientationAssociatedPtr by which to send lock
or unlock requests to browser process. So in blink, we rename it as
ScreenOrientationDelegate.

After the moving, the WebScreenOrientationClient interface has no reason to
exist anymore, so we delete it. The layout-test needs to be migrated from
using WebScreenOrientationClient to mojo. So in MockScreenOrientationClient,
we provide a fake mojo implementation of ScreenOrientation and override the
AssociatedInterfaceProvider in frame level.

The unittest of original screen_orientation_dispatcher is moved to
webkit_unit_test. Some other unittests which have dependencies on the removed
WebScreenOrientationClient are also fixed.

BUG=678545

Change-Id: If02f7661d53bbba83e368182f0e10f04b89c5fbe
Reviewed-on: https://chromium-review.googlesource.com/848735
Commit-Queue: Ke He <ke.he@intel.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Mounir Lamouri (slow) <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532808}

TBR=mlamouri@chromium.org
NOTRY=true

Bug: 807191
Change-Id: Id8f1e5332bd01dba73b4823b4a3a4cdc88d8d31c
Reviewed-on: https://chromium-review.googlesource.com/892605Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532807}

- Avoid tracing elements directly from WTF::Vector and WTF::Deque
  when the backing store is allocated out-of-line.
- Avoid MarkNoTrace optimization breaking the tracing/marking
  abstraction.

Bug: chromium:802273
Change-Id: Icfb5deed3479d4a7dec85c82930b464bdfe16b0e
Reviewed-on: https://chromium-review.googlesource.com/886484
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532806}

Using wpt-import in Chromium 1443f409.
With Chromium commits locally applied on WPT:
9f32e9c0 "S13nServiceWorker: Add tests for network fallback for navigations with request bodies"
b72e8903 "service worker: Deflake fetch-event.https.html."


Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/11286

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

TBR=leon.han@intel.com

No-Export: true
Change-Id: I4b5fd2f5e673384750197952922804f64607039f
Reviewed-on: https://chromium-review.googlesource.com/892638
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532805}

TBR=schenney@chromium.org

Bug: 807159
Change-Id: Id49b4c6e72e8a7226f27c4577195131da699cc36
Reviewed-on: https://chromium-review.googlesource.com/892588Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Commit-Queue: Makoto Shimazu <shimazu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532804}

If the first argument of createElement() is a pre-defined QualifiedName,
CreateRawElement() is less expensive.

This CL should not have user-visible behavior changes.

Bug: 806641
Change-Id: I80c96306031e83e1124882fcde456d54f762529f
Reviewed-on: https://chromium-review.googlesource.com/892601Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532803}

This is necessary for compatibility with Clang's CFI and
whole-program devirtualization features. For more information, see:
https://clang.llvm.org/docs/LTOVisibility.html

Normally, declarations of COM classes receive public LTO visibility
via the uuid attribute. However, our re-declarations of the PStore
classes do not specify a uuid, so we need to mark them up explicitly.

Bug: 507755
Change-Id: I6c2a5f4f75bea23bfe7d0c38c799cf4d7a5467a4
Reviewed-on: https://chromium-review.googlesource.com/892123Reviewed-by: Scott Graham <scottmg@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532802}

This, together with cl 892292, unblocks moving url_loader_test.cc to services/network.

Bug: 753658
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: Iba9cc4f07e2f8a4d2c6617c4c69bd1c74e03ab65
Reviewed-on: https://chromium-review.googlesource.com/892698Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532801}

Add should_skip_path(path) to audit-non-blink-usage.py and use it in
PRESUBMIT.py and main().

Change-Id: I0117d96e1ba237058c2d9182e5df8db3bbfe1778
Reviewed-on: https://chromium-review.googlesource.com/892191Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532800}

After the hooks being simplified it doesn't make sense to have them in the class.

BUG=803276

Change-Id: I201f8edb6638ef5b9de97ca05b2b16c8e2fcd3c0
Reviewed-on: https://chromium-review.googlesource.com/891551
Commit-Queue: Alexei Filippov <alph@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532799}

It is not recommended and being deprecated.

R=jochen@chromium.org

Bug: v8:7288
Change-Id: Ie03de13d3c69f73e08ea45ba968ab4f5aa3e566c
Reviewed-on: https://chromium-review.googlesource.com/891227Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Yang Guo <yangguo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532798}

Our WebSQL implementation does not currently call sqlite3_initalize()
[1], and instead rely on SQLITE's auto-initialization. The rest of
Chromium uses SQLite via //sql/connection.cc, which explicitly
initializes SQLite to avoid a race condition. This CL switches WebSQL to
explicit sqlite initialization, removing this special case and opening
the way for the SQLITE_OMIT_AUTOINIT [2] compile time option.

In the interest of reducing IPC latency, our WebSQL implementation
embeds SQLite directly in renderer processes, which are sandboxed and
don't have direct filesystem access. In order to make this work, we have
custom VFS implementations (SQLiteFileSystem{Posix,Win}.cpp). In these
cases, we implement xCurrentTime() [3] by delegating to SQLite's VFS
implementations. However, xCurrentTime() has been deprecated in favor of
xCurrentTimeInt64(). When SQLite is compiled with SQLITE_OMIT_DEPRECATED [4],
xCurrentTime() is null, resulting in crashes. This CL upgrades our
custom VFS implementations to API version 2, by wrapping
xCurrentTimeInt64() instead of wrapping xCurrentTime().

[1] https://www.sqlite.org/c3ref/initialize.html
[2] https://www.sqlite.org/compile.html#omit_autoinit
[3] https://www.sqlite.org/c3ref/vfs.html
[4] https://www.sqlite.org/compile.html#omit_deprecated

Bug: 807093
Change-Id: I9775854fd289f30285b589abf44c165715d85841
Reviewed-on: https://chromium-review.googlesource.com/892092Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532797}

Use a test expectation for the standard test env rather than in the
virtual test for IncrementalShadowDOM.

Bug: 660265, 776656
Change-Id: I6b2d3b1dcf0ebcb94c5e592d6255d0dc8ee95469
Reviewed-on: https://chromium-review.googlesource.com/892680
Commit-Queue: Hayato Ito <hayato@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532796}

Make Geolocation use WeakInterfacePtr, which is the class to use
so that mojo interface handles do not need to be manually closed
on Execution context destruction.

WeakInterfacePtr are the new hotness, they do that automatically
on Execution context destruction.

No new tests, no change in behavior, covered by existing tests.

Bug: 800641
Change-Id: Icf5347c012c735b03676d2537cae4473f03fc568
Reviewed-on: https://chromium-review.googlesource.com/880246
Commit-Queue: Austin Tankiang <austinct@google.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532795}

This CL separate the general functions for getting needed information
from MtpStorageInfo to storage_monitor::StorageInfo and add the
|id| and |location| test back.

BUG=769630

Change-Id: I1d77c1e4ea9471e04706ac9e94778e8bea771a94
Reviewed-on: https://chromium-review.googlesource.com/880487
Commit-Queue: Donna Wu <donna.wu@intel.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532794}

It's helpful for logging.
This CL won't affect production.

Change-Id: I9f35d75799ce060ceef34e173967c0881930504d
Reviewed-on: https://chromium-review.googlesource.com/892579Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532793}

This CL contains the following refactorings.

1) The preprocessor defines ("compile-time options" in the SQLite
   documentation [1]) used to build the SQLite library bundled with Chromium
   are extracted in a "chromium_sqlite3_compile_options" configuration.

2) The "chromium_sqlite3_compile_options" configuration is injected into
   all the targets that depend on //third_party/sqlite (when using
   Chromium's bundled SQLite library), so sqlite.h is parsed with the
   same preprocessor defines used to compile the library. This will
   become important when we start disabling the SQLite features we don't
   use.

3) The SQLite shell is compiled with the same preprocessor defines and
   disabled warnings as the SQLite library. The shell is only built on
   Linux for the purpose of debugging SQLite issues, and does not ship
   with Chrome.

4) The configuration used when we rely on the system's SQLite library
   (so the SQLite bundled with Chromium is not built) is renamed from
   "sqlite_config" to "system_sqlite_config".

[1] https://www.sqlite.org/compile.html

Bug: 807093
Change-Id: Ibf495ef3c4635a9b40c35e9998694293899d10d9
Reviewed-on: https://chromium-review.googlesource.com/892096Reviewed-by: Chris Mumford <cmumford@chromium.org>
Commit-Queue: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532792}

Following bot results are included.
3384 3387 3388 3392

2 lines were removed and 28 lines were deflaked by consecutive results
since 3356.

TBR=eae@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I62bdd22e9e92bc46d58dc74daba3cd74959bcc01
Reviewed-on: https://chromium-review.googlesource.com/892192
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532791}

Bug: 787949
Change-Id: I19ff9ce7f046eb177403d5e9350833e1932b98a1
Reviewed-on: https://chromium-review.googlesource.com/884421Reviewed-by: Buck Krasic <ckrasic@chromium.org>
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532790}

This reverts commit a324bac1.

Reason for revert: Causes various performance regressions and at least one memory regression, see bugs listed below.

Original change's description:
> Add UKM metrics for rendering timing measurements
>
> UKM review: https://docs.google.com/document/d/1Cpe5kLi3tVshH3evoJVUVDjOw7le-f8jFwBjEk2uadY/edit
>
> Bug: 783383
> Change-Id: Ib684e9e07322e27633b33576c688fa699fada81e
> Reviewed-on: https://chromium-review.googlesource.com/812154
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Reviewed-by: Chris Harrelson <chrishtr@chromium.org>
> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#532051}

TBR=cbiesinger@chromium.org,asvitkine@chromium.org,chrishtr@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 783383,807121,806814,806810,806808,806806,806795,806801,806809,806812,806830,806829,806805,806796
Change-Id: I33e40eb337bb0b1daea4be753878d7218342942f
Reviewed-on: https://chromium-review.googlesource.com/892482
Commit-Queue: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532789}

Now the tree looks like this:
 Box (block-flow children-inline) offset:0,34 size:600x72
    LineBox offset:31,0 size:568x18
      Box (children-inline)(self paint) offset:0,-1 size:367x19
        Text offset:0,1 size:337x17 start: 30 end: 83
      Text offset:377,0 size:191x17 start: 1 end: 30
    LineBox offset:24,18 size:575x18
      Box (children-inline)(self paint) offset:0,-1 size:575x19
        Text offset:0,1 size:200x17 start: 144 end: 171
        Text offset:200,1 size:375x17 start: 84 end: 144
    LineBox offset:21,36 size:578x18

Useful when debugging painting.

Bug: 635619
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I0901841736b7bbad9534a3ecbcc187c9b968d15c
Reviewed-on: https://chromium-review.googlesource.com/892103
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532788}

This CL resolves wrongly placed locks at 3 different objects.

* Observation

Mutex M6756: HTMLMediaElement::provide_input_lock (Mutex)
Mutex M9163: MediaElementAudioSourceHandler::process_lock_ (Mutex)
Mutex M9987: WebAudioSourceProviderImpl::sink_lock_ (base::Lock)

These 3 locks have a cyclic reference:
M9163 => M6756 => M9987 => M9163

* Scenario

1. Entry point: MediaElementAudioSourceNode::Create() from
   BaseAudioContext's factory method
2. HTMLMediaElement::SetAudioSourceNode()
   M9163 locked
3. HTMLMediaElement::AudioSourceProviderImpl::SetClient()
   M6756 locked
4. WebAudioSourceProviderImpl::SetClient()
   M9987 locked
5. HTMLMediaElement::AudioClientImpl::SetFormat()
6. MediaElementAudioSourceNode::SetFormat()
7. MediaElementAudioSourceHandler::SetFormat()
   Acquiring M9163 fails because it is already held at step 2.

* Attempted Solution in this CL

HTMLMediaElement::SetAudioSourceNode() does not have to lock the
MediaElementAudioSource node - because the source node and the
handlers are locked locally in SetFormat() method.

* Suppressed Error

The patch fixes the lock-order-inversion, but it shows another
TSAN suppression case:
---
ThreadSanitizer: Matched 3 suppressions (pid=85351):
1 race:tzset_internal
2 deadlock:dbus::Bus::ShutdownAndBlock
---

Note that this error is labled as a |won't fix|:
https://cs.chromium.org/chromium/src/build/sanitizers/tsan_suppressions.cc?l=220

  case instead.

Bug: 786739
Test: CF repro tool cannot reproduce, showing one of TSAN suppression
Change-Id: I8d9f6fe549562e39f7212f80aa2dea6c9527922e
Reviewed-on: https://chromium-review.googlesource.com/879242Reviewed-by: Raymond Toy <rtoy@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Mounir Lamouri (slow) <mlamouri@chromium.org>
Commit-Queue: Hongchan Choi <hongchan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532787}

PositionInGraphicsLayerBacking uses a boolean argument |selection_start| to compute
a selection bound.
This patch refactors the function by removing the argument and splitting
the function into StartPositionInGraphicsLayerBacking and
EndPositionInGraphicsLayerBacking for code health.

Bug: 789870
Change-Id: I09b08afaef179cedd00d6d9b6bbd47cb5cd222bb
Reviewed-on: https://chromium-review.googlesource.com/892193Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532786}

Change-Id: I12c2ce5551bcd2630af75ac9e9f6e15758c3a7e6
Reviewed-on: https://chromium-review.googlesource.com/889639
Commit-Queue: Ryan Hamilton <rch@chromium.org>
Reviewed-by: Buck Krasic <ckrasic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532785}

This CL removes a reference from CachedMetadataHandlerImpl to
Resource, and instead captures necessary data from Resource
when CachedMetadataHandlerImpl is created, i.e. when a response
is received.

This is to make CachedMetadataHandler and Resource independent,
so that CachedMetadataHandler can be used even when the
corresponding Resource is garbage-collected or revalidated,
for Issue 783124.

This CL causes a behavior change in CachedMetadataHandler::Encoding():
Previously, it returned the final encoding that reflected the
encoding detection by the response body.
After this CL, it returns the encoding at the time of
ResponseReceived() that doesn't reflect the encoding detection
(by UTF BOMs in the case of scripts).
This shouldn't affect the correctness, because if the encoding at
the time of ResponseReceived() is the same, then the final encoding
should be also the same (provided the response content is the same).

This might cause different Encoding()s are returned for the same
final encoding and thus affect memory/performance, but this is
expected to be quite rare because UTF BOMs are quite rare.

Bug: 784875, 783124
Change-Id: I0b72fafc54537fae93c90d1abf3bddf4e094add8
Reviewed-on: https://chromium-review.googlesource.com/791494
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532784}