- 28 Oct, 2020 40 commits
-
-
Frank Tang authored
https://chromium.googlesource.com/chromium/deps/icu.git/+log/d3c1cdc3..c7c91f82 c7c91f8 Update IANA to tz 2020d by Frank Tang TBR=jshin@chromium.org Bug: 1143059 Change-Id: I0a464b5be7b9fe69a8a1acde7d297bee740a9e76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504633 Commit-Queue: Frank Tang <ftang@chromium.org> Reviewed-by:
Frank Tang <ftang@chromium.org> Cr-Commit-Position: refs/heads/master@{#821855}
-
Michael Hansen authored
This adds a "pulse" animation to the high-visibility receive page, which gives a visual indication that the device is actively waiting to receive shares from other devices. Screenshot: https://screenshot.googleplex.com/3wpVaUZyn57BL8x.png Spec: https://carbon.googleplex.com/cros-ux/pages/nearby-share/motion Bug: b:163147651 Change-Id: I035d78c42cfe1a27e38bf34a39e7083d9038c4a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503827 Commit-Queue: Michael Hansen <hansenmichael@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#821854}
-
Zhenyao Mo authored
BUG=1060785,1077725 TEST=bots R=rafael.cintron@microsoft.com Change-Id: I2e169acc0f138f635c5c1238065d29cb0a4f8ceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505599 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Commit-Queue: Rafael Cintron <rafael.cintron@microsoft.com> Reviewed-by:
Rafael Cintron <rafael.cintron@microsoft.com> Auto-Submit: Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#821853}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I89d6ef71e62f307f6de4c3eabc5d4a055f0c1e84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506073Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#821852}
-
Joshua Pawlicki authored
This is a reland of 31c7133d The change from the first patch set is to reinstate the call to Uninstall. Original change's description: > Updater: Implement candidate self-uninstall. > > Bug: 1098934 > Change-Id: I226fc7201e04dfbf1722399434e3900cedc35120 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2487940 > Commit-Queue: Joshua Pawlicki <waffles@chromium.org> > Reviewed-by: Sorin Jianu <sorin@chromium.org> > Auto-Submit: Joshua Pawlicki <waffles@chromium.org> > Cr-Commit-Position: refs/heads/master@{#821372} Bug: 1098934 Change-Id: I5affeb8ef8a2ba447e33a9d4efc1059184fef58c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505459 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#821851}
-
Danan S authored
These calls allow the guest content to save its state (represented as an opaque Uint8Array of data) in such a way that it survives content reloads. This is needed because the flow redirects through GAIA, which triggers the content reload which wipes out the flow's state. This method is simpler than previous methods used to maintain state across page reloads and doesn't require extra network round-trips because the state is saved and retrieved locally via postMessage calls to the WebUI. Bug: 1136979 Change-Id: Ic1d3c1dbbf0d253f3e856365c0fafa64b8f55066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498960 Commit-Queue: Dan S <danan@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#821850}
-
Sylvain Defresne authored
App built for "catalyst" environment are regular macOS app (linked with some support libraries). Update the build rules to generate a macOS app bundle when environment is "catalyst". Update the codesign.py and write_framework_modulemap.py script to use the correct bundle structure. Bug: 1138425 Change-Id: I135068a92101b755f588ca25ae9420660ea4a66c Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498527 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#821849}
-
Tanya Gupta authored
Bug: 1142520 Change-Id: I44b67c40a585a9c6438dfd47e8cb91e0d75bba82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2498834 Commit-Queue: Tanya Gupta <tgupta@chromium.org> Reviewed-by:
Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#821848}
-
Ken Rockot authored
Today, service processes self-terminate as soon as they detect peer closure on their main service pipe. This is detected on the IO thread and results in the immediate scheduling of a main-thread task to terminate the process. Meanwhile, service instances themselves also watch for peer closure on the same pipe and are notified on whichever thread runs the service (IO or main thread). This triggers immediate destruction of the service instance. Because there is no ordering guarantee between the two independent signal handlers, the net result is that during clean shutdown of a service process, the service instance's destructor may not run, or may run after shutdown has already started. This can be problematic if the service continues to operate and perform tasks that depend on a now-partially-shut-down process environment like the task scheduler. As a separate but related issue, the pipe-watching logic has been watching for peer closure when it should really be watching for an unreadable state (i.e., peer closure AND empty inbound queue). This means that service termination could race with messages still on the pipe unless developers are careful to synchronize their browser-side Remote's teardown against some kind of ack message from the service. This change does a bunch of stuff all at once to solve these problems: - Modifies ContentClient ServiceFactory APIs so that they populate a shared instance (two shared instances really, one for IO, one for main thread) rather than having embedders provide their own instance. - Gives UtilityThreadImpl and its internal (IO-thread-bound) ServiceBinderImpl their own ServiceFactory instances with clearly-defined ownership and lifetime. - Removes independent pipe watching logic from ServiceBinderImpl, instead having it track service instance lifetimes from both ServiceFactory instances. - Modifies ServiceFactory's pipe watching logic to watch for an unreadable pipe rather than for peer closure. The net result is that service processes which are cleanly shut down, meaning they neither crashed nor were reaped during full browser process shutdown, will always run their service's destructor before initiating shutdown. Bug: 1135957 Change-Id: I16adbd7c98b4eb4333a92cd338643d4d5a9f2d6f Tbr: caseq@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503346 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#821847}
-
Peter Kotwicz authored
BUG=1142501 Change-Id: I42170e8cdb660ae35275ea688b0c758de72b9fb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504269Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#821846}
-
Kramer Ge authored
When WaylandSurfaceGpu is unregistered, its task_runner is also expected to be forgotten. There are crashes caused by not finding the task_runner. This CL adds a check if the task_runner is unregistered and avoid posting to non-existent task_runners. Change-Id: I1b7d64a5b469e365d5d87ecc5f2332e74d2faf15 Bug: 1139518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502954Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#821845}
-
Maks Orlovich authored
...by converting it into a WPT test that runs on a different hostname Bug: 1076138 Change-Id: I2e687685ea32a4c742383900cd0b871dcc5b9c37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2475934 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#821844}
-
Donn Denman authored
Disables a set of tests that are failing on M87 on Android. This CL landed on Master and was merged to M87, but it was flawed. This fixes the flaw and relands on Master. We plan to merge into M87 and revert on Master (since it has been addressed on Master). BUG=1137967 Change-Id: I66eabb97c167822c2652b7c89c606377fb08b5d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503844 Auto-Submit: Donn Denman <donnd@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#821843}
-
Javier Ernesto Flores Robles authored
- Add extension strings - Generate localizable.strings files for the extension - Add translation expectations and resource ids - Add screenshots Bug: 1138717 Change-Id: I443a367af96cad05dfa32ab6d94ca17c1f4c9524 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504635 Commit-Queue: Javier Flores <javierrobles@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#821842}
-
Dave Tapuska authored
This message which is only sent on windows and ash. Looking back on the history (http://crrev.com/30f75e61) when this message was added it was intended to hide auto complete popups. Being that we dismiss select popups on focus changes and size changes I believe this method is not needed anymore. BUG=1051648 Change-Id: I463da85c9916c2140e4093447df1aacefc75b9c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493282 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#821841}
-
Stephen McGruer authored
This rolls up to sha 178d0b3f04a Bug: None Change-Id: Ib9d3628b514e46f8710ee9a49550dd381ef57206 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506114Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#821840}
-
Dave Tapuska authored
DidDetach wasn't getting called and there was no receiver for the message anymore. So all of this code is dead. Remove it. BUG=993189,533069 Change-Id: I71b712fd0f21a89ab60cd1c509afbb6e02604a23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505126Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#821839}
-
Takumi Fujimoto authored
Sample failure: https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests/56470 TBR=jdoerrie@chromium.org Bug: 1143312 Change-Id: Ice856557d80337fae79ad41e6a3b06630d3d1e3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506209Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#821838}
-
Christopher Cameron authored
The capture system is built around the assumption that the VideoCaptureBufferPool allocates buffers and manages their lifetime. This does not match the behavior on macOS where the macOS capture APIs manage buffer pools (via a CVPixelBufferPool). Prior to this change, these "external" buffers were not tracked by the VideoCaptureBufferPool beyond having an id assigned for them. They were never "reused" -- every new frame was treated as though it was a new buffer. This was problematic because it caused these buffers to be opened and closed as they propagated through three processes (the capture, renderer, and GPU process), burning lots of CPU. In fact, the underlying IOSurfaces are indeed reused in the CVPixelBufferPool. This patch enables VideoCaptureBufferPool to exploit the IOSurface reuse done by the CVPixelBufferPool. It uses GpuMemoryBufferTrackerMac to track the externally-provided buffers. When a new IOSurface is presented in VideoCaptureDeviceClient::OnIncomingCapturedExternalBuffer, the function VideoCaptureBufferPoolImpl::ReserveIdForExternalBuffer uses the new IsSameGpuMemoryBuffer function to determine if we are already tracking the GpuMemoryBuffer. Of note is that VideoCaptureBufferPoolImpl::ReserveIdForExternalBuffer uses LRU order to discard old buffers (which matches the CVPixelBufferPool usage pattern), while the other function that does this, VideoCaptureBufferPoolImpl::ReserveForProducerInternal, finds the largest buffer to discard. To prevent the CVPixelBufferPool from reclaiming the IOSurface before the consumer is done with it, add a OnHeldByConsumersChanged function which calls IOSurfaceIncrementUseCount (via gfx::ScopedInUseIOSurface) to signal to the CVPixelBufferPool that the IOSurface can't be reclaimed yet. This involves some refactoring of the VideoCaptureBufferTracker class. Prior to this patch, the IOSurface's in use count was being updated by the ScopedAccessPermission argument provided to the VideoCaptureDeviceClient::OnIncomingCapturedExternalBuffer function. Just drop that ScopedAccessPermission on the floor for now -- it will be cleaned up in a follow-on patch (this one is already big). Update tests to test this. Bug: 1125879 Change-Id: I9eaf6dd47126103b094f54bf23a3f28cf2318d62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2493089Reviewed-by:
Markus Handell <handellm@google.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#821837}
-
Henrique Nakashima authored
This makes it possible to know what revision a graph corresponds to, so that users know how old the graph they are viewing is and makes it possible to track regressions. Bug: 1115268 Change-Id: Iedceabe885d90b14bb639e810dcaa75f48be844a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353292Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#821836}
-
Chong Gu authored
Fix recipe issue with the CQ builder: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8865185421221209248/+/steps/Incorrect_or_missing_bot_configuration/0/logs/details/0 Bug: 1135171 Change-Id: I01fc7650a5b3012cfc8bb042244319f52a87204b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505971 Auto-Submit: Chong Gu <chonggu@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#821835}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/71f12666647b..541601602ee9 2020-10-28 bungeman@google.com Roll freetype 0a3d2bb99b45b72e1d45..40c5681ab92e7db1 2020-10-28 tdenniston@google.com Improve var-width miter joins 2020-10-28 egdaniel@google.com Revert "In Vk don't set dynamic blend constant on Pipeline if we don't use it." 2020-10-28 johnstiles@google.com Add `reportLeaks` method to GrMemoryPool. 2020-10-28 michaelludwig@google.com Fix clip shader coverage combining with geometry processor coverage If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jcgregorio@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jcgregorio@google.com Change-Id: I971d0508eeb4ae3e2b804b4bdfacd73bc4f1a743 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506095Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821834}
-
Ian Struiksma authored
Several tests are timing out on win10-blink-rel that don't on previous Win10 version (moving from 1703 to 1909). These tests pass on the longer 1200 timeout on win10 test builder. Also, adding failure expectation for media/track/track-cue-rendering-vertical.html Bug: 1142023,1143005 Change-Id: Ifd19bff72b84438b7e015909885af67ded4fb2d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503842 Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#821833}
-
Yicheng Li authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/763dc305cc96..9e8d3a2d7e05 $ git log 763dc305c..9e8d3a2d7 --date=short --no-merges --format='%ad %ae %s' 2020-10-20 yichengli system_api: Add request_id parameter for WebAuthn requests Created with: roll-dep src/third_party/cros_system_api Change-Id: Ie36c7bb7cfe35f1d63041020ad3cc3b96c168a33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503319 Commit-Queue: Yicheng Li <yichengli@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Auto-Submit: Yicheng Li <yichengli@chromium.org> Cr-Commit-Position: refs/heads/master@{#821832}
-
Gavin Williams authored
Add browser proxy to give Scanning UI access to ScanningHandler functions. Bug: 1059779 Change-Id: Iad0f72305ae315c3079393ff077c784ec9b8f101 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497427 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#821831}
-
Matt Menard authored
Enables print server scaling support where print server may be selected individually when more than 16 print servers are available via policy. Relevant Design Docs: go/cros-print-server-scaling and go/cros-print-servers-backend Bug: b:168650771 Change-Id: I16c10f4e80504e1c0b0cfda8ce93af5b724e917d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499164 Commit-Queue: Matt Menard <mattme@google.com> Reviewed-by:
Brian Malcolm <bmalcolm@chromium.org> Cr-Commit-Position: refs/heads/master@{#821830}
-
David Black authored
The background is composed of an opaque white circle with a drop shadow. The next CL will implement painting of the actual contents representing the associated holding space item. Screenshot: https://screenshot.googleplex.com/KDyRTn7ALwdy8U2 Bug: 1142572 Change-Id: I9bd8ea71e9977487bd59df69ce78d79015192146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503321 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#821829}
-
rbpotter authored
With the update of OS settings to generate_grd, this method is no longer used. Bug: 1132403 Change-Id: Id06f6249b05bebcc72eb22b417d0334bc4d5a708 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505936Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#821828}
-
Chromium WPT Sync authored
Using wpt-import in Chromium bc42696a. With Chromium commits locally applied on WPT: 2b985496 "Add webgl2 tests for WebXR" 0c2d7260 "[scroll-animations] Handle changes to selector(#id) references" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-payments-fyi-rel Change-Id: I5b5741b0088f9e9dbf952889330a219529b89a35 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505455Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821827}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3f40a48d..3542c2cb Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibda221d2f77fc4e60b1a0657ecfa9b646deb42fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505930Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#821826}
-
Dave Tapuska authored
These metrics expired in M81 and they'd need to be re-implemented in blink with RenderWidget's removal. Since they aren't used it is easier to remove them. BUG=1037221,1097816 Change-Id: I2879ce11795b090a4244838579167e61f7d34daf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500248Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#821825}
-
adoneria authored
Fix broken Windows Deterministic builder issue that caused revert crrev.com/c/2502022. Change test cases to use typ.TestCase instead of unittest.TestCase. Bug: 1141577 Change-Id: I79d6c93dd15c2e3e727c5368a97142d5572c1c51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503396Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Anjali Doneria <adoneria@google.com> Cr-Commit-Position: refs/heads/master@{#821824}
-
dpapad authored
This is in preparation of removing <include src="assert.js"> and flattenhtml="true" from js/util.js and js/cr/ui/array_data_model.js, which in turn is necessary to auto-generate grd entries for ui/webui/resources/js/cr/ui/. Bug: 1143194 Change-Id: I128845c864e439cbf262f343cfa77153916d8dfd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504740 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#821823}
-
Ilia Samsonov authored
New baseline are from: https://test-results.appspot.com/data/layout_results/mac-arm64-rel-tests/530/blink_web_tests/layout-test-results/results.html Bug: 1130741 Change-Id: I6d5f2bcb820717b6f6053125cfffe5d9e49963d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2491982Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#821822}
-
Side Yilmaz authored
This CL adds null check for mTabSwitcherModeToolbar to IncognitoTabModelObserver callback not to cause NPE. In addition to that, this CL introduces |maybeInitializeOnIncognitoTabsExistenceChanged| and |maybeInitializeIncognitoTabModelObserver| functions to perform initialization in both |setTabModelSelector| and |initializeTabSwitcherToolbar| functions. Bug: 1142547 Change-Id: Ib539d70e06b4ebe86464867409e0a736dd7bd4ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2502373 Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#821821}
-
Xinghui Lu authored
One major refactoring in this CL is removing FeedbackCollector's dependency on ScreenshotTask, because ScreenshotTask is not modularizable at the moment. Replace the takeScreenshot parameter in the init function with a ScreenshotSource object(the interface of ScreenshotTask), so FeedbackCollector doesn't need to construct a ScreenshotTask itself. Some outstanding blockers for further modularization: * DataReductionProxyFeedbackSource, blocked on DataReductionProxySettings. * HelpAndFeedbackLauncherImpl, blocked on AppHooks. * ScreenshotTask, blocked on ChromeActivity. * connectivity_checker.cc, blocked on circular dependency of chrome/browser/profiles. Bug: 1117343 Change-Id: I93dd06b4146ad57d53c0cdc082d8ff0c9a32cdc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2478108Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#821820}
-
Mikel Astiz authored
This patch migrates the helper libraries to avoid using the concept of a 'seed', which was hard to grasp, and instead migrates tests to more directly use keywords. Change-Id: Ibcdae092baade651daca059850ac31f276f47564 Bug: None Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495461Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#821819}
-
David Tseng authored
Strategy: - manually edit the Eslinter rule: third_party/node/node_modules/eslint/lib/rules/eqeqeq.js to allow for auto fixing; this was intentionally disabled upstream. - run tools/web_dev_style/eslint.py --fix and git cl format --js on the directory R=akihiroota@chromium.org, josiahk@chromium.org Test: assumed automated test coverage Change-Id: I97913d8d198e2fe049eeeb52473a8c58aebcd94b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503851Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#821818}
-
Ben Pastene authored
This is the first in a series of changes to make all ToT linux CQ builders builderfull. crrev.com/i/3351753 allocates the machines for this builder, so this shouldn't be submitted before that. Bug: 1140727 Change-Id: I976f419b4be7249534b210e05151694734acbe96 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2503391Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#821817}
-
Rushan Suleymanov authored
The DCHECK could be violated during a sync incremental update when remote updates have entities having different sync ids and the same GUIDs. This is a temporary measure until it is guaranteed that GUIDs are unique across all bookmarks. Bug: 1142790 Change-Id: Ic1279eee89290f4245f5e7f76528e888ff0dec39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506030Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#821816}
-