- 15 Oct, 2019 40 commits
-
-
Rohit Agarwal authored
Chrome didn't warn the users about open incognito windows that would be lost during the update. Added a general warning in the settings and a personailzed warning, indicating the count of open incognito windows in the Relaunch Chrome dialog. Bug: 810989 Change-Id: Ibd6bf11024e94b0490964f3cdf2236d10c14d998 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1814924Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Cr-Commit-Position: refs/heads/master@{#706010}
-
Avery Musbach authored
The present CL is similar to [1]. The rationale in the commit message of [1] does not apply to the current plan for multi-display split view, but similar code changes seem reasonable anyway. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1726310 Bug: 970013 Change-Id: I1a1572d89c2d25ac60b9ac25dc37edce7b74fce8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1856890 Commit-Queue: Avery Musbach <amusbach@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#706009}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/61d3d4b0bd55..ba97f6065ed1 git log 61d3d4b0bd55..ba97f6065ed1 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 chrishall@google.com Trivial: Removing gendered pronouns from watchlists.py. Created with: gclient setdep -r src/third_party/depot_tools@ba97f6065ed1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:879943 Change-Id: Icd118e802cc33046b5e36f3ef73130c45b717d40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862628Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#706008}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/d3b93d4c73b8..260e87e6956a git log d3b93d4c73b8..260e87e6956a --date=short --no-merges --format='%ad %ae %s' 2019-10-15 wbbradley@chromium.org shellcheck: look inside the chroot first for shellcheck Created with: gclient setdep -r src/third_party/chromite@260e87e6956a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I521acfbcce01fcc8c3ef77b6151d56c600405985 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862627Reviewed-by:
-
Clemens Arbesser authored
This CL fixes issues for users of autofill assistant who have disabled their autofill addresses. Prior to this CL, credit card validation logic relied on the personal data manager to retrieve the corresponding billing addresses. Now, this is decoupled such that billing address and credit card are treated independently by autofill assistant. This allows users to ad-hoc fill the user form (with newly created credit cards and billing addresses). Bug: b/142630213 Change-Id: I3edbdac9dfc8efbda5a40d5f5868f642bcf459c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859775 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#706006}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f22c57ddcc8c..df18296f9844 git log f22c57ddcc8c..df18296f9844 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 brianosman@google.com Add accessors to get/set SkParticleEffect fields Created with: gclient setdep -r src/third_party/skia@df18296f9844 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=csmartdalton@google.com Bug: None Change-Id: I46a1247c9a3c264b7593c3148cdf97dfa8133dca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863143Reviewed-by:
-
Raul Tambre authored
itervalues() has been removed in Python 3 in favour of values(). They're functionally equivalent, but values() is slightly slower in Python 2. In this case there shouldn't be a difference because sys.modules is usually pretty small. Example backtrace: Traceback (most recent call last): File "../../tools/licenses.py", line 809, in <module> sys.exit(main()) File "../../tools/licenses.py", line 791, in main if not GenerateCredits(args.file_template, args.entry_template, File "../../tools/licenses.py", line 717, in GenerateCredits build_utils.WriteDepfile(depfile, output_file, File "C:\Google\chromium\src\build/android/gyp\util\build_utils.py", line 563, in WriteDepfile inputs = _ComputePythonDependencies() + inputs File "C:\Google\chromium\src\build/android/gyp\util\build_utils.py", line 514, in _ComputePythonDependencies module_paths = (m.__file__ for m in sys.modules.itervalues() AttributeError: 'dict' object has no attribute 'itervalues' Bug: 941669 Change-Id: I3a5e1602f3dda99ea97f328811d941de73cb76eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857124 Auto-Submit: Raul Tambre <raul@tambre.ee> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#706004}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/cc3b617bc9f8..b9fad2fbcc49 git log cc3b617bc9f8..b9fad2fbcc49 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 perezju@chromium.org [Telemetry] Make results.AddValue API private Created with: gclient setdep -r src/third_party/catapult@b9fad2fbcc49 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC oysteine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=oysteine@google.com Bug: chromium:999484 Change-Id: I738ac1d124bb25ab0b61cd5574f059617832bd5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863140Reviewed-by:
-
Robert Liao authored
Convert PlatformSensorReaderWin32's EventListener And Related Tests to use Microsoft::WRL::RuntimeClass Instead of IUnknownImpl BUG=1014283 Change-Id: I916d449e9bd6922eadd77a2ddbaa83a2a1a0eec1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860986 Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#706002}
-
Friedrich Horschig authored
Non-functional change. This CL moves the URL formatting into the mediator which separates the logic from the view binder. Bug: 957532 Change-Id: I172f20f00ab3e9fa998c82bd8c41ef8159cf08d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857129 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#706001}
-
Michael Lippautz authored
Change-Id: Ie060c1a6e9cac18c8366e89235961917f0e4b146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862927 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#706000}
-
Vadym Doroshenko authored
There are 2 more fields are required for username first flow. Bug: 959776 Change-Id: I02b336ec078e46f48a6bbed86f29ed5bb8d9f288 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859959 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
-
Corentin Wallez authored
https://dawn.googlesource.com/dawn.git/+log/1093c4de2cfa..c57b1802088a $ git log 1093c4de2..c57b18020 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 cwallez Add dawnGetProcAddress. 2019-10-15 cwallez Split the libdawn target in components with a single purpose. Created with: roll-dep src/third_party/dawn BUG=dawn:22 Change-Id: Ibc6a154143d98e2c9a5d770e766388e43d05b5ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863013Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#705998}
-
Pâris MEULEMAN authored
This removes unused includes from signin_manager_android.cc to primary_account_manager and primary_account_mutator. Including the DEPS exception for primary_account_manager which is internal to identity_manager. Bug: 934688 Change-Id: I85a84245d0bb3e12bf4746f603d0051926b6a430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862445 Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Auto-Submit: Pâris Meuleman <pmeuleman@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#705997}
-
Arthur Hemery authored
Currently kBackForwardCacheNoTimeEviction overrides specific setup in the BackForwardCacheTest suite, where we want to preserve the previous behavior. Explicitly override it at construction time. Change-Id: I39cc378f2cc03bd798ef4306db6eeecfd8abc72b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859790Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#705996}
-
Peter Boström authored
Uses a pill-shape generator for SearchResultSuggestionChipView. This replaces a custom InkDropMask for the same shape and overriding the focus ring's path inside OnBoundsChanged. Bug: chromium:1007546 Change-Id: I229ad7529ad4d593f32b39cfe3fda948332eb32d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861046 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#705995}
-
Kai Ninomiya authored
This reverts commit f061988f. Reason for revert: Failures on webgl(2)_conformance_gl_passthrough_tests on Mac FYI bots Original change's description: > WebGL: Don't expose ARB_texture_rectangle on Mac passthrough > > Uses the new DisableExtension functionality from > https://chromium-review.googlesource.com/c/angle/angle/+/1838418 > to prevent ARB_texture_rectangle from being exposed to WebGL shaders. > > Bug: angleproject:3770 > Change-Id: I106785757235f3f1748d74ddf25dac9384caa281 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842223 > Reviewed-by: Kenneth Russell <kbr@chromium.org> > Commit-Queue: James Darpinian <jdarpinian@chromium.org> > Cr-Commit-Position: refs/heads/master@{#705802} TBR=kbr@chromium.org,jdarpinian@chromium.org Change-Id: I924e7a306fbb91feb914973b9a3a24b857d738e4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: angleproject:3770 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863155Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#705994}
-
minch authored
See video before change: https://drive.google.com/file/d/0B5I0jFeLxqIiUlg2aXRrdGFIV0d0ZzhZYng4Y3VJQVJ1OXow/view?usp=sharing The affordance is assumed to be 64dips above the touch point,but the distance seems much further than expected. See video after change: https://drive.google.com/file/d/0B5I0jFeLxqIicGNacUIzUThxUHZ3SHV0RVBlWFpzdUNtb2h3/view?usp=sharing Bug: 1002733 Change-Id: I4d5638a3c964fe45a52402f75c9ad21ba62a9bea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859690 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
-
minch authored
Bug: 1002733 Change-Id: I97b7ba270f2df51c0a433d3ba0320e33ef3dc94b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861019Reviewed-by:
-
Jinho Bang authored
Reason for revert: Use of the GPUProgrammablePassEncoder and GPURenderEncoderBase interfaces aren't installing the function templates properly. According to the spec[1], the first identifier of `includes` statement MUST reference a `interface`. It means that a `interface mixin` cannot include the other `interface mixin`. In this case, even though GPURenderEncoderBase is `interface mixin`, it includes GPUProgrammablePassEncoder which is `interface mixin`. Solution: The problem should be fixed in spec side[2] and make final interfaces include the mixins directly as follows: GPURenderBundleEncoder includes GPUProgrammablePassEncoder; GPURenderPassEncoder includes GPUProgrammablePassEncoder; Original change's description: > WebGPU: Add GPUProgrammablePassEncoder interface > > This is a spec match-up with[1] > > [1] https://github.com/gpuweb/gpuweb/pull/459 > > Bug: 877147 > Change-Id: I080324cbb083160ae84aa109623e311f24a875cb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1845132 > Reviewed-by: Corentin Wallez <cwallez@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Commit-Queue: Jinho Bang <jinho.bang@samsung.com> > Cr-Commit-Position: refs/heads/master@{#704061} [1] https://heycam.github.io/webidl/#includes-statement [2] https://github.com/gpuweb/gpuweb/pull/470 Bug: 1013649 Change-Id: Iaeb1ac69b0f1f7a779c341e7a92f6b29e28d3880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857846 Commit-Queue: Jinho Bang <jinho.bang@samsung.com> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#705991}
-
Collin Baker authored
This migrates callers to GetTabAlertStatesForContents(), which returns all the applicable TabAlertStates, or none at all. This also removes TabAlertState::NONE since this function will return an empty list instead. Use cases that needed TabAlertState::NONE are replaced with base::Optional<TabAlertState>. Bug: 1004983 Change-Id: I477e029c470f780abd82947ea803357634fd2a8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1817187 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#705990}
-
Tao Bai authored
Bug: 1006418 Change-Id: I9485ecf2586ef1527bc3dbc664ce6603cfb95570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838687Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#705989}
-
Alex Turner authored
If the split cache is enabled, do not attempt to call DoomMainEntryForUrl if the network_isolation_key (NIK) is unpopulated. This previously would occur for requests in HttpCacheLookupManager, but the cache is bypassed for these requests, making the call unnecessary. When the call was made, a DCHECK was hit in GenerateCacheKey given the empty NIK. Bug: 1014077 Change-Id: I566d021d50ea7200d8d99702e382c7db932dfe44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860312Reviewed-by:
Shivani Sharma <shivanisha@chromium.org> Commit-Queue: Alex Turner <alexmt@chromium.org> Cr-Commit-Position: refs/heads/master@{#705988}
-
Makoto Shimazu authored
This CL converts base::Bind to BindOnce or BindRepeating, and also changes relevant base::Callbacks or base::Closures to appropriate types. This CL is split from https://crrev.com/c/1831621. This CL was uploaded by git cl split. R=skyostil@chromium.org Bug: 1007760 Change-Id: I2cc2eb477f0ade0df21c17e967065768537af950 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1849547 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
-
Evan Stade authored
Use it to remove NotificationService usage from DriveIntegrationService (others to follow). See code comments for usage notes. Bug: 268984 Change-Id: I64f153def34e5d08bc3b247ed0b865037d18af69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1853024 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#705986}
-
Alex Turner authored
Cross-origin prefetching is not currently supported when the split cache is enabled. This breaks the SignedExchangePrefetchBrowserTest/ SignedExchangePrefetchBrowserTest.PrefetchMainResourceSXG_CrossOrigin/0 test. We thus bypass the failing checks if split cache is enabled. Bug: 1009607 Change-Id: Iede3c1a2f71e3e4472fb5b91724a984898d5b4e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1838333Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Reviewed-by:
-
danakj authored
RIP PageProperties, we wanted you to work out. R=avi@chromium.org Bug: 419087 Change-Id: I0e38a3aff5c38d742412be1323bc13161abc11b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857159 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#705984}
-
Sebastien Marchand authored
This protection should only apply to the proactive discarding scenario. Change-Id: I081422d406dce2eef2a9e56f03bce50c7038a14d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857042Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#705983}
-
Friedrich Horschig authored
This CL introduces a RecyclerView and prepares the list of credentials to display more generic items (like the upcoming header element). Bug: 1012219 Change-Id: I20b8361b2a139e89a493c5292f86b7bcece1c920 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1857127 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
-
Chris Harrelson authored
Bug: 650768 Change-Id: I729e848121638b23f4d13971f48a5962827f7abf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861035Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium b7a40213. With Chromium commits locally applied on WPT: 2f7c5562 "Fetch Metadata: Split `sec-fetch-dest` out from other headers' tests." d52a9d07 "Port IndexedDB Blob Web Tests to web-platform-tests." 6386d9d8 "Update service_worker_unregister_and_register()" f399b336 "Fetch Metadata: Add a test for `<embed>` navigated after loading." 0583f458 "Fetch Metadata: split up `document` destination." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools kenneth.r.christiansen@intel.com, rijubrata.bhaumik@intel.com: external/wpt/web-nfc NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I536a3ef3e2a05cfb6d8748a68708aa31388867e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862576Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#705980}
-
Richard Knoll authored
Right clicking on a link should only show the "Send link" option, even when there is selected text. We only want to show the "Copy to" option when regular text is right clicked. Bug: 1014054 Change-Id: I0c75b8b54de7259884c75edb4ff9709b4381c413 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1860336Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
-
Sergey Poromov authored
|is_enterprise_reporting_| is always set to 'true' and is redundant. DeviceStatusCollector is used only for enterprise reporting, consumer (child) reporting is extracted to ChildStatusCollector, so it's safe to remove this flag for simplicity and ensure that DeviceStatusCollector is initialized only for enterprise reporting. Test: Run trybots. Change-Id: I87509316e5d3c46fa186b8d322b69e3dadba7a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862679 Commit-Queue: Sergey Poromov <poromov@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#705978}
-
henrika authored
Bug: 1014443 Change-Id: I3ab6f06669484e6c76573cd671f09f10d6e29401 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862682Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Henrik Andreasson <henrika@chromium.org> Cr-Commit-Position: refs/heads/master@{#705977}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast TBR=cr-fuchsia+bot@chromium.org Change-Id: Ib4b45fca6ae1401697c9cd427e987a0f9d6376d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862697Reviewed-by:
-
Peter Boström authored
Replaces OnBoundsChanged override for ColorPickerElementView. Bug: chromium:1007546 Change-Id: Iefe2e8f035cfbe83778ebd05df562ca5aaf33c47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1859586 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/8718afb283b7..ac0a4cbbd850 git log 8718afb283b7..ac0a4cbbd850 --date=short --no-merges --format='%ad %ae %s' 2019-10-15 nisse@webrtc.org Reland "Fix GetStats bytesSent/Received, wireup headerBytesSent/Received" 2019-10-15 philipel@webrtc.org Updated VideoStreamEncoder to destroy encoder_queue_ before encoder_switch_experiment_. 2019-10-15 sprang@webrtc.org Revert "RtpRtcp modules and below: Make media, RTX and FEC SSRCs const" Created with: gclient setdep -r src/third_party/webrtc@ac0a4cbbd850 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:none Change-Id: I7f40da734ca52ec7e8e244237b80ff24ad3557db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1862620Reviewed-by:
-
Peter Boström authored
Removes updates to the highlight path done on every Layout() call. Bug: chromium:1007546 Change-Id: Ia179a182c39ada394e1076eae25f374922a1d2b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861125 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Peter Boström authored
Replaces OnBoundsChanged override which resulted in a lot of path generation (per-tab + frame) while opening new tabs or resizing the window. Also removes a ::GetInkDropMask() override which just generated the same path. Bug: chromium:1007546 Change-Id: I0131f9a589c1525e2c0eacd61c9fcd9f6ac05948 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861016 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Peter Boström authored
Replaces probably a significant amount of path updates in ::OnBoundsChanged override (which this change also removes). This might reduce some jank in the tab strip while opening tabs or resizing windows, though it's unclear whether it amounts to a significant chunk of work as a fraction of total work here. Bug: chromium:1007546 Change-Id: I5aab0ce9cfcaeea2bec80f994d0586e588ff977e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1861044 Auto-Submit: Peter Boström <pbos@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
