- 05 Feb, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/166b478fa620..9b350d45696f Created with: gclient setdep -r src-internal@9b350d45696f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I87c709b4373311fd7e56e17da2103703bc431e51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038126Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738521}
-
Robbie Gibson authored
Omnibox NTP Zero-Prefix Suggestions use the RemoteSuggestionsService to actually get their suggestions. The corresponding factory currently doesn't exist on iOS, so this CL creates it. Bug: 1048193 Change-Id: I7ad14129a954e96225adc9d6b000087165ce5859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035964 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#738520}
-
Mihai Sardarescu authored
This reverts commit fcca6197. Reason for revert: Required downstream fix was submitted. Original change's description: > Revert "[iOS] Enable Earl Grey 1 and 2 tests for ClearSyncedData feature." > > This reverts commit 3edb7dbb. > > Reason for revert: consistently fails on downstream bots. > > Original change's description: > > [iOS] Enable Earl Grey 1 and 2 tests for ClearSyncedData feature. > > > > Previously the test case testSignOutAndClearDataFromNonManagedAccountClearsData() was disabled due to a misuse of the ScopedFeatureList flag, which should only be used for unit tests. This meant that the flag was not set correctly in the tests. > > > > The change uses the AppLaunchManager to enable the experimental flag on Earl Grey 2 and the flag within the Earl Grey 1 JSON setup. > > > > Bug: 1045981 > > Change-Id: I3160477a5230d24617168800a5cabacb4b8fd672 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023835 > > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > > Reviewed-by: Ben Pastene <bpastene@chromium.org> > > Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#737283} > > TBR=sdefresne@chromium.org,bpastene@chromium.org,fernandex@chromium.org > > Change-Id: I58ffda870f5d63c9b23fb9fb40903d14b2fd9ead > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1045981 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032120 > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#737316} TBR=sdefresne@chromium.org,bpastene@chromium.org,fernandex@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1045981 Change-Id: I861b7342e2407bc972e6d794ec2ad85a4cd73019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037993Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#738519}
-
Alex Clarke authored
Unlike WebView it looks like VariationsService is a better fit than a custom java fetcher since we expect to have network permissions. Note without backend changes this patch should be a NOP since no trials currently target WebLayer as a platform. WebLayerFieldTrials is a stub and as such it doesn't currently support WebLayer specific trials. AFAIK this doesn't prevent a trial's config specifying WebLayer only. The variations service itself has plenty of tests but there doesn't seem to be any tests for the equivalent hookup code in Chrome/WebView. Bug: 1025612 Change-Id: Ib7dfe64455a323cfafd160b2612f148872e0fa25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028770 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Auto-Submit: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#738518}
-
Tanmoy Mollik authored
Crashes in chrome canary might be because SyncErrorInfoBar is passed null WebContent on launch from the active tab. Bug: 1048300 Change-Id: I2042b020e9b82c4fc10b876a3b83aed1de22fb57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035986Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#738517}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/a9624b4d5d0b..9e52bc0d0c1d git log a9624b4d5d0b..9e52bc0d0c1d --date=short --first-parent --format='%ad %ae %s' 2020-02-04 bclayton@google.com utils/vscode: LSP - Support OpExtInst (#3140) 2020-02-04 kubak@google.com Fix typos in opt's help. Update environment version. (#3170) 2020-02-04 stevenperron@google.com Start SPIRV-Tools v2020.2 2020-02-04 stevenperron@google.com Finalize SPIRV-Tools v2020.1 2020-02-04 stevenperron@google.com Update CHANGES 2020-02-04 afdx@google.com spirv-fuzz: Fuzzer pass to add composite types (#3171) 2020-02-04 afdx@google.com Update script that checks copyright years. (#3173) 2020-02-04 afdx@google.com spirv-fuzz: Disallow copying of null and undefined pointers (#3172) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@9e52bc0d0c1d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,cnorthrop@google.com Change-Id: I3431737acb0df5ec530bc78909bfe7016c53b91c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038123Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#738516}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f764fc02e94c..ec816af6e720 git log f764fc02e94c..ec816af6e720 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src 807f14657a25..b932cf53f769 (3 commits) 2020-02-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 41a7302e9c62..8e8e1d0dd729 (4 commits) 2020-02-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src e85fe4c3cc9f..ab47cacfd3b3 (1 commits) 2020-02-05 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 7a2d408dea60..9e52bc0d0c1d (11 commits) Created with: gclient setdep -r src/third_party/angle@ec816af6e720 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cnorthrop@google.com Change-Id: I0cffa53427ea5e34685d21ff858636ce71a54b55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038178Reviewed-by:
-
Boris Sazonov authored
Replace ChromeSigninController in ChromeBackupAgent with IdentityManager.GetPrimaryAccountInfo(). This is safe to do, because the native side is already loaded - the same method accesses JNI methods above. Bug: 1046412 Change-Id: Icfa1522bf0f8ec552d6211dd4dad4b12e7f74d6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025468Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Alice Wang <aliceywang@chromium.org> Commit-Queue: Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#738514}
-
Luciano Pacheco authored
Table header move padding to the label so clicking in the padding area activates the click event in the label to sort the column. Change the cursor to pointer in the column header to indicate that it has an action (sorting the column). Reset the table header font-weight because it's already using Robot Medium which is already the right weight. Fix the border radius for the file row thumbnail so it shows perfectly rounded. Reset the padding top in the file row because in the current spec the text doesn't need the additional padding to align with the icon [1]. [1] - https://cs.chromium.org/chromium/src/ui/file_manager/file_manager/foreground/css/common.css?l=343&rcl=80e9555e489ff4a6743f2d8f99dafdbaccc7397f Bug: 992821 Change-Id: I06b1b6e5c842162f6b1a3ea027932869704995a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033059 Commit-Queue: Noel Gordon <noel@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#738513}
-
Sean Harrison authored
Add: PRIVACY_SITE_SETTINGS_ALL PRIVACY_SITE_SETTINGS_AR PRIVACY_SITE_SETTINGS_VR These were missed in a previous CL and hits a DCHECK Add corresponding test to site_settings_page_test.js Merge all tests into one to remove flakiness, testing each logging call in a separate test was taking too long and causing sporadic timeouts resulting in flakiness. Now all logging checks are done by navigating around a single test instance and resetting proxy state, speed up removes all flakiness and was significant enough to allow the merging of all 4 split test suites without timeout concerns. Bug: 1046488, 1048858 Change-Id: I074e2581d3489e179adfdc187e7165284ccc2685 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027447 Commit-Queue: Sean Harrison <harrisonsean@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#738512}
-
Takuto Ikuta authored
This is to take crrev.com/c/2036856 crrev.com/c/2036854 Bug: 984869 Change-Id: Iaa623376bfde92ae0620fd20362dd122764a8746 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037189 Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#738511}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/540662253ea3..b82ed734e767 git log 540662253ea3..b82ed734e767 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 johnkslang@users.noreply.github.com Merge pull request #2077 from kainino0x/configurable-target-pr Created with: gclient setdep -r src/third_party/glslang/src@b82ed734e767 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: radial-bots+chrome-roll@google.com,cnorthrop@google.com Change-Id: I93714bfe94cf2595049bb607463f9aa013b14b8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038128Reviewed-by:
-
Mikel Astiz authored
Regular flakes reported on Linux and Windows. Change-Id: I8d3e0d6b67c64cddc8e9ade632496a82cd4ca7a9 Bug: 1049014 TBR=rhalavati@chromium.org Change-Id: Id3dbc106fd8b45dad7a868039f7a261b16642a7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036186Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#738509}
-
Alice Wang authored
This CL added a test for the signin choose account flow with secondary account. Bug: 1045046 Change-Id: I43b195857521ec9dd90ab6ed4913fb3f24ffcdee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2020967Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
-
Mikel Astiz authored
This reverts commit 97e6c2b3. Reason for revert: suspect of causing unit test failures on msan builds: https://ci.chromium.org/p/chromium/builders/ci/Linux%20ChromiumOS%20MSan%20Tests Original change's description: > Enables the upgrade of Crostini container from Settings. > > We restart vm when upgrading, if it wasn't running already. > > Bug: 1024693 > Change-Id: I00e093f7bbf83eb04a6adb4029a4612e99950ae4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026559 > Reviewed-by: Kyle Horimoto <khorimoto@chromium.org> > Reviewed-by: David Munro <davidmunro@google.com> > Commit-Queue: Nicholas Verne <nverne@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738422} TBR=khorimoto@chromium.org,nverne@chromium.org,hollingum@google.com,davidmunro@google.com Change-Id: I41e8d20c971ac1392e998cc2d791a3053b7fa8e2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1024693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036189Reviewed-by:
-
Yutaka Hirano authored
It was introduced to discard the response body for prefetch, but the response body (including the cached metadata) is filtered in the browser process (see content::PrefetchURLLoader) so we don't need to do that in content/renderer. Bug: 860403 Change-Id: I97d1feb2bc47727004484d53afcaa27f22ebf41a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037291 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#738506}
-
Eric Willigers authored
HostedAppBrowserController static methods SetAppPrefsForWebContents and ClearAppPrefsForWebContents move out to become standalone methods in web_app_launch_utils.h/cc They are now also called by WebAppBrowserController and WebAppLaunchManager. The test PWAMixedContentBrowserTest, MixedContentInPWA now passes with the DesktopPWAsUnifiedUiController flag enabled. The test previously failed as SetAppPrefsForWebContents was not called when the DesktopPWAsUnifiedUiController flag and the DesktopPWAsUnifiedUiController flag were used. TBR=benwells@chromium.org Bug: 1034361 Change-Id: Id388122efa147ae8ae4ee26ba87a3c7c5101e5ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035819 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#738505}
-
Maksim Moskvitin authored
Updated histograms are still useful for investigation of not completed Nigori migration to keystore. mamir@ no longer working on related things and removed from the owners. Bug: 1036875 Change-Id: I89ac124cd883f2e4c70458409f2e03b2d7a47e66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036179Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#738504}
-
Marc Grimme authored
This reverts commit de47b200. Validates if the previously failing test are stable now to be reverted back once more. R=marcgrimme Bug: 1000694 Change-Id: I34806a0dd921ee90f4e8be7a83ee6c4cf27270a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035975Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Marc Grimme <marcgrimme@chromium.org> Cr-Commit-Position: refs/heads/master@{#738503}
-
Huanzhong Huang authored
Bug: 1045348 Change-Id: I5ed06d330074e72c79bf31f49a9216e380322549 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024890Reviewed-by:
Wei Li <weili@chromium.org> Commit-Queue: Huanzhong Huang <huanzhong@chromium.org> Cr-Commit-Position: refs/heads/master@{#738502}
-
David Jean authored
Popover now needs a sourceView or sourceRect. Bug: 1023619 Change-Id: Ifcc65cf83c9afb26080c9baeb22dd9030b06ec9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036065 Commit-Queue: David Jean <djean@chromium.org> Auto-Submit: David Jean <djean@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#738501}
-
Simon Zünd authored
This should prevent flakiness even further once asynchronous source mapping lands. R=petermarshall@chromium.org Bug: chromium:1032016 Change-Id: I65797584b8ab539d61421e06928cb4b6780823ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037991 Commit-Queue: Simon Zünd <szuend@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Auto-Submit: Simon Zünd <szuend@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#738500}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e22c450dfeb2..0335e6749943 git log e22c450dfeb2..0335e6749943 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 szuend@chromium.org Prepare DebuggerPlugin for source map asyncification Created with: gclient setdep -r src/third_party/devtools-frontend/src@0335e6749943 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1032016 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia9bd06fdd8a63f6d92616fdc6842bc67eebe7b1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038124Reviewed-by:
-
Anand K. Mistry authored
Functions which take an SmbUrl should also return an SmbUrl instead of std::string. This allows strong typing to be maintained, and helps avoid conversions between SmbUrl and std::string. Bug: 939235 Change-Id: If52ccc58d3bff62902179c1c9999fbf8bff64964 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035827Reviewed-by:
Austin Tankiang <austinct@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#738498}
-
Mikel Astiz authored
This reverts commit a98ef426. Reason for revert: causes failures in ChromeVoxBackgroundTest, see crbug.com/1049012. Bug: 1049012 Original change's description: > Change the anonymous block in LayoutMenuList to a shadow element > > Enable rendering of the shadow element of <select>, and remove anonymous > block in LayoutMenuList. > > * HTMLOptionElement::ParseAttribute(): > Update the shadow element content on option[label] change. > > * HTMLSelectElement::UpdateFromElement(): > Fold LayoutMenuList::UpdateFromElement() into here. If option_style_ > and InnerElemnet's style are inconsistent, update InnerElement's > style. > > * HTMLSelectElement::UpdateMenuListLabel() > Move the code in LayoutMenuList::UpdateInnerStyle() here. > Also, kick TextChanged ax notification which LayoutText::ForceSetText > did. > > * MenuListInnerElement::CustomStyleForLayoutObject(): > Set "display: block" > Add custom style which the anonymous block used. > > * layout_menu_list.{h,cc}: > Remove a lot of code. > > * ax_layout_object_test.cc: > Add tests to check if AXLayoutObject::StringValue() respects to > text-transform and -webkit-text-security. > > * web_tests/accessibility/notification-listeners.html: > Remove TextChanged notification expectation. After this CL, <select> > won't notify TextChanged in this test scenario. The text is changed > before creating LayoutObject and AXLayoutObject. > > > > Bug: 1040828 > Change-Id: Ia0c19f0897ab2d1461e457c83adceda2c0739f9f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024250 > Reviewed-by: Koji Ishii <kojii@chromium.org> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Commit-Queue: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738416} TBR=yosin@chromium.org,tkent@chromium.org,kojii@chromium.org Change-Id: I804ec3898b907ff79531dbc6390c99e24b66965f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1040828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036187 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Mikel Astiz authored
This reverts commit 882f5709. Reason for revert: dependency in order to revert crrev.com/c/2024250. Bug: 1049012 Original change's description: > Remove GetText(), ClientPaddingLeft(), and ClientPaddingRight() of LayoutMenuList > > Fold them into their callsites. > This CL has no behavior changes. > > Bug: 1040828 > Change-Id: Iac6c8c1e061993534e7f7ed45d60139ec9cd63e3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038196 > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Commit-Queue: Kent Tamura <tkent@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738490} TBR=yosin@chromium.org,tkent@chromium.org,kojii@chromium.org Change-Id: I76d98f6f0ce474ca2cd64b94f8d3b36cb0878b71 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1040828 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037992Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/6c9b1fd6663e..bc3307c395e2 git log 6c9b1fd6663e..bc3307c395e2 --date=short --first-parent --format='%ad %ae %s' 2020-02-05 csmartdalton@google.com Don't do clear or round rect optimizations when a rect has stencil Created with: gclient setdep -r src/third_party/skia@bc3307c395e2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: scroggo@google.com Change-Id: Ic0d40bfb754ed34ca6717680d9b172fbbc205504 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038177Reviewed-by:
-
Friedrich Horschig authored
With this CL, the manual filling UI listens to the bottom sheet controller and suppresses any keyboard accessory or accessory sheet as soon as a BottomSheet of any kind is opened. This solution has the following constraints: * _Any_ bottomsheet will suppress the filling UI, always. * If the bottomsheet is closed, the filling UI will require another interaction (an opened keyboard, focusing a field, rotation) to reopen the filling UI. * The autofill dropdown is not affected in any way. Only if the keyboard accessory V2 is active (i.e. flag \#autofill-keyboard-accessory-view), the popup will be replaced by chips in the suppressed accessory. Launch of V2 has an uncertain target as of this writing. Bug: 1033849 Change-Id: I55fffa1bb7dd62a08af95705085c4884d38d9877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036103 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#738494}
-
Morten Stenshorne authored
Hit-testing should never enter a child that establishes a self-painting layer. Also added a couple of local variables to make it slightly easier to read. Change-Id: I2854cb1b677f8eb164befe1577e7de2740735538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036104Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#738493}
-
Fergal Daly authored
Change-Id: I4c97da02e2106e2214e4a978f4c5a037365ebee4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035551Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#738492}
-
Rachel Sugrono authored
Add a test that tab-index key focus works correctly (only the elements inside the delete-confirm-dialog are tab-indexable). Elements outside of the delete-confirm-dialog should not be tab-indexable. Bug: 803259 Change-Id: I70f22dbd25220589157ade74016a7939aef03509 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035476 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
-
Kent Tamura authored
Fold them into their callsites. This CL has no behavior changes. Bug: 1040828 Change-Id: Iac6c8c1e061993534e7f7ed45d60139ec9cd63e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038196Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#738490}
-
Eric Willigers authored
Two mixed content (http+https) desktop PWA tests have been ported to no longer have any dependency on Extensions code, so they are ready to run with BMO, when WebAppLaunchManager is complete. See https://chromium-review.googlesource.com/c/chromium/src/+/2035819/ for remaining work. Bug: 1026080 Change-Id: Ibcd690e44cc1949d352e16a11af5084a0abd2127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038195Reviewed-by:
-
Yoshifumi Inoue authored
This patch gets rid of unused functions in ElementInnerText for improving code health. Change-Id: I61692011375770b2c263c9a82499d7d02c340ca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037304 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#738488}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/be70f94fa57b..166b478fa620 Created with: gclient setdep -r src-internal@166b478fa620 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ieef89875ec85eac093f47cbbd5852694a84e4dca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038119Reviewed-by:
-
Chris Hall authored
R=aboxhall,dmazzoni Change-Id: I82c4687fd9923bf2669248419c7ed8616f1a7406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2010227 Commit-Queue: Chris Hall <chrishall@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#738486}
-
Kent Tamura authored
Bug: 924929 Change-Id: I29afe6b8e36c1101d81a3f2c02171662907f4057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035482Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Xiaocheng Hu authored
There's a CSSParserContext ctor that allows implicit conversion from a |const CSSParserContext*| to |const CSSParserContext&|, where the latter is actually a new object constructed on stack with different member values. So this patch stops the conversion. Change-Id: Ibf98e8b0012122d2fc42e3fc4b4b38e8fe9b797a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2037854Reviewed-by:
-
Clemens Backes authored
This should have been included in https://crrev.com/c/2030951 already. I missed that both "android_webview" and "ios" were missing. The set of "android", "android_webview" and "ios" hopefully covers all mobile platforms. R=bcwhite@chromium.org Bug: 1040061, 1040030 Change-Id: I8aa87b15c849be9d62c88df0a9f7eb7615eb6ec4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036056Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Clemens Backes <clemensb@chromium.org> Cr-Commit-Position: refs/heads/master@{#738483}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/25cf469a112f..6c9b1fd6663e git log 25cf469a112f..6c9b1fd6663e --date=short --first-parent --format='%ad %ae %s' 2020-02-05 jvanverth@google.com Update Viewer docs for Android and iOS. 2020-02-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 41a7302e9c62..8e8e1d0dd729 (4 commits) 2020-02-05 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 aa6dd50de0c5..58fc8b11cf3a (7 commits) 2020-02-05 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-04 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). 2020-02-04 egdaniel@google.com Make sure we invalidate mapped memory from vk transfer buffers before reading. 2020-02-04 tdenniston@google.com Revert "Initial checkin of GM verifier framework" 2020-02-04 tdenniston@google.com Initial checkin of GM verifier framework 2020-02-04 jvanverth@google.com Update iOS build instructions. Created with: gclient setdep -r src/third_party/skia@6c9b1fd6663e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: scroggo@google.com Change-Id: Ieeaf17a5514f142e6a145bc025f9fba4512d2265 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2038118Reviewed-by:
-
