GitLab

BUG=391005

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282740

Review URL: https://codereview.chromium.org/372243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284060 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Adding a router class to handle messages that expect responses. (https://codereview.chromium.org/371603003/)

Reason for revert:
This appears to have broken mojotest_instrumentation_tests with the errors like the ones listed below.

http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/20270

C   52.086s Main  [FAIL] org.chromium.mojo.bindings.ConnectorTest#testErrors:
C   52.086s Main  java.lang.NoClassDefFoundError: java.util.Objects
C   52.086s Main  	at org.chromium.mojo.bindings.MessageHeader.equals(MessageHeader.java:189)
C   52.086s Main  	at org.chromium.mojo.bindings.MessageWithHeader.<init>(MessageWithHeader.java:29)
C   52.086s Main  	at org.chromium.mojo.bindings.MessageWithHeader.<init>(MessageWithHeader.java:39)
C   52.086s Main  	at org.chromium.mojo.bindings.BindingsTestUtils.newRandomMessageWithHeader(BindingsTestUtils.java:85)
C   52.086s Main  	at org.chromium.mojo.bindings.ConnectorTest.setUp(ConnectorTest.java:53)
C   52.086s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:191)
C   52.086s Main  	at android.test.AndroidTestRunner.runTest(AndroidTestRunner.java:176)
C   52.086s Main  	at android.test.InstrumentationTestRunner.onStart(InstrumentationTestRunner.java:554)
C   52.086s Main  	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:1701)

C   52.091s Main  [CRASH] org.chromium.mojo.bindings.RouterTest#testReceivingViaRouterWithResponse:
C   52.091s Main  Native crash: Segmentation fault

Original issue's description:
> Adding a router class to handle messages that expect responses.
> 
> This also introduce the notion of message header to allow routing.
> 
> R=rmcilroy@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283767

TBR=qsr
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/392223004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284059 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a test which checks that the flag introduced in https://codereview.chromium.org/353493002/ is interpreted correctly by the SupervisedUserService's implementation of ManagementPolicy::Provider.

BUG=390520

Review URL: https://codereview.chromium.org/401643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284058 0039d316-1c4b-4281-b951-d872f2087c98

Wrapping them silenty breaks the referenced resources. This was broken in https://codereview.chromium.org/384023002/.

dcommitting to bypass the presubmit hooks which refuse the long lines.

BUG=385113
R=pam@chromium.org

Review URL: https://codereview.chromium.org/400653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284057 0039d316-1c4b-4281-b951-d872f2087c98

The database was only used to import a PKCS#12 file. By changing to separate key (PKCS#8 format) and cert (X509 in PEM encoding), only dependencies on the lower level RSAPrivateKey, X509Certificate and PK11_* NSS functions are required.
Note this removes at the same time a call to the deprecated NSSCertDatabase::GetInstance().

Also
- fixes multi profile cases of the unit test and the CA matching (the latter is now identical to all other platforms).
- fixes a bug in the matching of client certs from software slots, because of reused cert database names
- gets rid of the error output that occurred during the PKCS12 import because the file contained also a CA cert:
  [ERROR:nsPKCS12Blob.cpp(219)] Could not grab a handle to the certificate in the slot from the corresponding PKCS#12 DER certificate.

BUG=210525, 329735,315285

Review URL: https://codereview.chromium.org/394013005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284056 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284055 0039d316-1c4b-4281-b951-d872f2087c98

Changes:
- Hook up the default v8::Platform implementation to pdfium

BUG=none
TBR=jam@chromium.org

Review URL: https://codereview.chromium.org/399473005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284054 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394788
TEST=manually tested

Review URL: https://codereview.chromium.org/400703002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284053 0039d316-1c4b-4281-b951-d872f2087c98

Previously the gallery checks the sequence number to find out whether the update
for canvas size is needed or not.  The sequence number is incremented when
variables that affect canvas size are updated. But sometimes, the
canvas size goes to be out of sync.

BUG=245926
TEST=manually

Review URL: https://codereview.chromium.org/399383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284052 0039d316-1c4b-4281-b951-d872f2087c98

After this change, sync tasks are erased only when it completes or SyncClient gives up.
This change is preparation for implementing a mechanism to allow CopyOperation to wait for a specific sync task to complete.

In EntryUpdatePerformer:
Add a new error code FILE_ERROR_PARENT_NEEDS_TO_BE_SYNCED.
Return the new error code when the sync task cannot be completed because of the lack of the parent resource ID.

In SyncClient:
Add a new task state SUSPENDED to allow tasks to be in an inactive state.
Add a new member |context| to SyncTask to make it possible to change the context without erasing the task.
OnTaskComplete() takes almost all responsibilities to handle errors. OnFetchFileComplete() and OnUpdateCompleter() are now almost empty or removed.
Handle the new error code FILE_ERROR_PARENT_NEEDS_TO_BE_SYNCED in OnTaskComplete().

BUG=384213
TEST=unit_tests

Review URL: https://codereview.chromium.org/391343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284051 0039d316-1c4b-4281-b951-d872f2087c98

This change:
- allows for proper docking testing (including toolbox);
- removes all test friends from DevToolsWindow;
- unifies testing approach to use load callback instead of notifications;
- adds simple toolbox tests.

BUG=393566

Review URL: https://codereview.chromium.org/395783002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284050 0039d316-1c4b-4281-b951-d872f2087c98

Prepare declarativeContent API for new script injection feature. Added Javascript types and functions, as well as C++ ContentAction that currently does nothing.

BUG=377978

Review URL: https://codereview.chromium.org/344433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284049 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284048 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=178410:178417&mode=html
TBR=abarth@chromium.org,johnme@chromium.org,eseidel@chromium.org
BUG=

Review URL: https://codereview.chromium.org/397373005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284047 0039d316-1c4b-4281-b951-d872f2087c98

The default platform no longer exists.

BUG=none
TBR=dcarney@chromium.org

Review URL: https://codereview.chromium.org/406503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284046 0039d316-1c4b-4281-b951-d872f2087c98

BUG=391795
TBR=gab

Review URL: https://codereview.chromium.org/375613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284045 0039d316-1c4b-4281-b951-d872f2087c98

chrome_browser_desktop_linux_sources variable is defined in both
chrome_browser.gypi and chrome_browser_ui.gypi. If we keep the same
name the lists will be merged in gyp builds, resulting the same list
compiling twice for both browser and browser_ui targets.

Review URL: https://codereview.chromium.org/403503003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284044 0039d316-1c4b-4281-b951-d872f2087c98

This makes debugging and stacks in Release builds much more accurate
(locals, arguments, information about inlining, etc.). The drawback is
somewhat larger .pdb files. Here's the sizes for the top 10 pdbs:

With /d2Zi+
-----------
07/17/2014  09:52 PM       280,408,064 content_unittests.exe.pdb
07/17/2014  09:47 PM       477,401,088 blink_web.dll.pdb
07/17/2014  09:50 PM       506,949,632 content.dll.pdb
07/17/2014  10:01 PM       955,576,320 sync_performance_tests.exe.pdb
07/17/2014  09:59 PM       955,912,192 performance_browser_tests.exe.pdb
07/17/2014  10:04 PM       965,382,144 sync_integration_tests.exe.pdb
07/17/2014  09:59 PM       987,688,960 chrome.dll.pdb
07/17/2014  10:03 PM     1,228,763,136 interactive_ui_tests.exe.pdb
07/17/2014  10:05 PM     1,398,632,448 browser_tests.exe.pdb
07/17/2014  10:07 PM     1,569,222,656 unit_tests.exe.pdb

Without
-------

07/17/2014  10:44 PM       238,104,576 content_unittests.exe.pdb
07/17/2014  10:39 PM       399,175,680 blink_web.dll.pdb
07/17/2014  10:44 PM       439,767,040 content.dll.pdb
07/17/2014  10:57 PM       837,832,704 sync_performance_tests.exe.pdb
07/17/2014  10:51 PM       838,119,424 performance_browser_tests.exe.pdb
07/17/2014  10:57 PM       846,286,848 sync_integration_tests.exe.pdb
07/17/2014  10:51 PM       864,194,560 chrome.dll.pdb
07/17/2014  10:58 PM     1,071,509,504 interactive_ui_tests.exe.pdb
07/17/2014  10:58 PM     1,219,203,072 browser_tests.exe.pdb
07/17/2014  10:58 PM     1,351,118,848 unit_tests.exe.pdb

So there is appreciable growth (~15%). The limit is currently 4G, so it
seems worth turning on for now, and if we must disable it later, we can.

R=wfh@chromium.org
BUG=350018,388264

Review URL: https://codereview.chromium.org/399843007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284043 0039d316-1c4b-4281-b951-d872f2087c98

Recent change (crrev.com/398263002) broke the slide show mode and we cannot
enter the slide show mode from the mosaic view due. The CL adds null check to
fix it.

BUG=245926
TEST=manually

Review URL: https://codereview.chromium.org/403733002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284042 0039d316-1c4b-4281-b951-d872f2087c98

Correct comment, and change ptr argument to const ref in
CacheNewServerConfig.

Merge internal change: 70794754
https://codereview.chromium.org/398643003/


Allow QUIC clients to accept STK/SCFG updates on an existing connection.

Merge internal change: 70794017
https://codereview.chromium.org/393953011/


To be used in internal change: 70123647 when processing a mid-connection
update of SCFG/STK.

QUIC: Factor out updating cached server config into a new method.

Merge internal change: 70736560
https://codereview.chromium.org/398623003/


Adding logging to quic for tracegraf

This should not change behavior. set_logging_visitor is only used in a
test and will be done in a followup CL.

Adding logging to quic in a protobuf that will be used by tracegraf (not
yet used in production).

Merge internal change: 70735705
https://codereview.chromium.org/398683002/


Reduce the scope of a spurious WARNING log when processing strike
register errors to something that truly shouldn't happen.  Also change
log level to DFATAL.

Merge internal change: 70716413
https://codereview.chromium.org/391283003/


Enable Kathleen Nichols min rtt algorithm with a 1 minute window in
QUIC's BBRTcpSender.

Merge internal change: 70683520
https://codereview.chromium.org/394023005/


Moving the work currently done in the QuicSession constructor to
Initialize().

This is worthwhile because currently it's possible for virtual functions
to be called from under the stack of the QuicSession constructor, which
is confusing and annoying to debug.  Example: if a bad config (without
SetDefaults called) is passed to the quic server session, it calls
SetFromConfig which calls SetIdleNetworkTimeout which calls
CheckForTimeout which can technically call SendConnectionClose which
calls CloseConnection which calls visitor->OnConnectionClosed() on the
session, which still doesn't have a good vtable.

As it turns out, this puts the internal server in an inconsistent state
which causes all sorts of other annoying to debug things.  This can be
solved by never giving an invalid config (heh) or, say, not doing a ton
of complicated work in a constructor in the first place.

This hopefully will also make some unit testing earlier as you don't
have to do quite as much work in test classes.

Moving work from the QuicSession constructor to InitializeSession()

Merge internal change: 70661792
https://codereview.chromium.org/393953009/


Change QUIC's pacing sender to send at 1.25x the estimated bandwidth
during congestion avoidance, instead of 2x.

Merge internal change: 70658053
https://codereview.chromium.org/393943004/


Populate FasterExtraStats for QUIC requests
if --faster_stats_extra_logging != 0

Merge internal change: 70419510
https://codereview.chromium.org/396533003/


Fix a newly introduced bug in QUIC's PacingSender where burst_tokens_
would never be set back to 10 after the initialization, because
OnCongestionEvent is never called with bytes_in_flight of 0.

Merge internal change: 70371419
https://codereview.chromium.org/397513002/

R=rch@chromium.org

Review URL: https://codereview.chromium.org/391383002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284041 0039d316-1c4b-4281-b951-d872f2087c98

NavigatorContentUtils is stable feature. So, we don't need to keep this command line flag.

BUG=343941

Review URL: https://codereview.chromium.org/400613002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284040 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none

Review URL: https://codereview.chromium.org/390083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284039 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Add WorkerThread based methods for start/stop of worker threads. (https://codereview.chromium.org/393283003/)

Reason for revert:
Breaking blink bots.

Original issue's description:
> Add WorkerThread based methods for start/stop of worker threads.
> 
> This patch adds notification methods for start/stop of worker threads which accept a WorkerThread parameter. This is needed in order to move the worker threads in blink to use WebThread instead of its own version.
> It also adds support for shared timer to WebThreadImpl.
> 
> BUG=301515
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=284008

TBR=jochen@chromium.org,sigbjornf@opera.com
NOTREECHECKS=true
NOTRY=true
BUG=301515

Review URL: https://codereview.chromium.org/404753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284038 0039d316-1c4b-4281-b951-d872f2087c98

This was originally part of https://codereview.chromium.org/384023002/, but was taken out because Rietveld choked on the binary file moves. (Which it is still doing here, so I have to dcommit this one.)

BUG=385113
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/405433004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284036 0039d316-1c4b-4281-b951-d872f2087c98

I'm moving events parameter from the results of Timeline.stop command to Timeline.stopped event.

BUG=394780

Review URL: https://codereview.chromium.org/399943002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284035 0039d316-1c4b-4281-b951-d872f2087c98

A common usage of InterfacePtr is:
(1) Create a new InterfacePtr instance.
(2) BindToProxy() is called to bind the interface pointer to an implementation.
(3) Immediately, the message pipe handle underneath the interface pointer is detached and sent over another message pipe.

In step (2), currently we do all the setup work for the interface pointer: construct Router and Connector instance, post task to start watching the message pipe handle, etc. All the work is thrown away at step (3).

With this CL, the proxy setup work won't be done until actual read/write is needed.

BUG=394883
TEST=None

Review URL: https://codereview.chromium.org/400043004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284034 0039d316-1c4b-4281-b951-d872f2087c98

 * Add the keyboard handler to modify the viewport's offset values.

 * Make the viewport class generate CSS transform expressions including the
   offset value.

BUG=245926
TEST=manually
R=mtomasz@chromium.org

Review URL: https://codereview.chromium.org/398283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284033 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Migrate accessibility from RenderView to RenderFrame. (https://codereview.chromium.org/273423004/)

Reason for revert:
Speculative revert to fix XP bots.

XP bots started crashing http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/32011 and http://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%282%29/builds/34677

This CL is the most suspicious in the range. If it doesn't fix the bots, I'll unrevert it.

Original issue's description:
> Migrate accessibility from RenderView to RenderFrame and RVH to RFH.
> 
> In preparation for out-of-process iframes, move almost all accessibility
> functionality from RenderView to RenderFrame, and from RVHI and RWHI
> to RFHI.
> 
> In addition, the accessibility mode is moved to WebContents, and changing
> the mode triggers changing it on all frames.
> 
> BUG=368298
> R=jam@chromium.org, kenrb@chromium.org, nick@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283994

TBR=dmazzoni@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/407493002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284032 0039d316-1c4b-4281-b951-d872f2087c98

Introduce ContainerParams to control the container's behavior

Next Steps:
* Add explicit z-order priority and add check to catch violation.
* Refactor init process and add unit test


BUG=394121
TEST=This depends on the app_shell's initialization. I'll work on refactoring so that test/shell/main uses the same initialization process and add test.

Review URL: https://codereview.chromium.org/404563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284031 0039d316-1c4b-4281-b951-d872f2087c98

BUG=394655
TEST=manually
R=fukino@chromium.org

Review URL: https://codereview.chromium.org/403723002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284030 0039d316-1c4b-4281-b951-d872f2087c98

It currently generates invalid code, see
http://llvm.org/bugs/show_bug.cgi?id=20354

BUG=none

Review URL: https://codereview.chromium.org/393193003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284029 0039d316-1c4b-4281-b951-d872f2087c98

BUG=349211
TEST=Existing tests pass.

Review URL: https://codereview.chromium.org/398163004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284028 0039d316-1c4b-4281-b951-d872f2087c98

Its last client disappeared in https://codereview.chromium.org/373643002/

BUG=none

Review URL: https://codereview.chromium.org/395403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284027 0039d316-1c4b-4281-b951-d872f2087c98

This allows an app to determine whether a window created with
"transparent_background" will work as expected.

This also allows the app to detect when "transparent_background" might
stop working, e.g. when Windows changes from Aero to Classic.

This also fixes the bug where "transparent_background" windows
created in Classic render as black rectangles.

BUG=260810

Review URL: https://codereview.chromium.org/375183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284026 0039d316-1c4b-4281-b951-d872f2087c98

BUG=303491

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=283225

Review URL: https://codereview.chromium.org/392533002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284025 0039d316-1c4b-4281-b951-d872f2087c98

This makes things much more clearer and in order with the rest of
strings/grit targets.

BUG=323025
TEST=None
R=tony@chromium.org,lcwu@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/398873004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284024 0039d316-1c4b-4281-b951-d872f2087c98

The AdvancedMockContext previously did not override registerComponentCallbacks
and unregisterComponentCallbacks. The implementation of these methods in
Context calls getApplicationContext before delegating the call to it, and since
AdvancedMockContext returns |this| in getApplicationContext, this leads to a
loop.

This CL adds overrides for these two methods that make the calls to the base
context instead, which will typically either be a MockContext or the target
context being instrumented.

BUG=394464

Review URL: https://codereview.chromium.org/404553005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284023 0039d316-1c4b-4281-b951-d872f2087c98

It's only implemented and used if NSS (or later OpenSSL) provide the
certificate information. The check was checking against use_openssl rather than
use_openssl_certs.

BUG=394959

Review URL: https://codereview.chromium.org/399143005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284022 0039d316-1c4b-4281-b951-d872f2087c98

In Yosemite, the fullscreen button replaces the zoom button. We no longer need
to swizzle the method that returns the origin of the fullscreen button.

BUG=388772

Review URL: https://codereview.chromium.org/402753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284021 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@284020 0039d316-1c4b-4281-b951-d872f2087c98