- 10 Nov, 2017 40 commits
-
-
shinyak authored
I've converted CrWinGomaGCEStaging to CrWinClexeGomaGCEStaging, and CrWin7Goma(clbr) to CrWinClexeGoma. So, CrWinGomaGCEStaging and CrWin7Goma(clbr) are not necessary any more. Let me remove them. Bug: 777705 Change-Id: Icf23e23d01a4d1f7c4d0f96d0fef99aa5f4680c6 Reviewed-on: https://chromium-review.googlesource.com/760099Reviewed-by:
Fumitoshi Ukai <ukai@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Shinya Kawanaka <shinyak@chromium.org> Cr-Commit-Position: refs/heads/master@{#515429}
-
Fumitoshi Ukai authored
GomaCanaryiOS matches with chromium.mac/ios-device with clobber: true, user_goma_canary: true % diff -u chromium.mac/ios-device.json chromium.fyi/GomaCanaryiOS.json --- chromium.mac/ios-device.json 2017-11-10 10:51:06.406179023 +0900 +++ chromium.fyi/GomaCanaryiOS.json 2017-11-10 10:50:47.689907892 +0900 @@ -1,8 +1,7 @@ { "comments": [ - "Builder for 32-bit devices.", - "Build is performed with gn+ninja.", - "If modified, please change chromium.fyi/GomaCanaryiOS.json too." + "Goma canary builder for iOS.", + "It is chromium.mac/ios-device.json + use_goma_canary, clobber." ], "xcode version": "9.0", "gn_args": [ @@ -22,5 +21,7 @@ "explain": true, "sdk": "iphoneos11.0", "tests": [ - ] + ], + "clobber": true, + "use_goma_canary": true } Bug: 740416 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4f98630eec51455cf28538e0f4c9e85261111e83 Reviewed-on: https://chromium-review.googlesource.com/759703 Commit-Queue: Fumitoshi Ukai <ukai@chromium.org> Reviewed-by:Shinya Kawanaka <shinyak@chromium.org> Reviewed-by:
smut <smut@google.com> Cr-Commit-Position: refs/heads/master@{#515428}
-
Evan Stade authored
Adds NotificationType and (partial) RichNotificationData. Now you can see progress bars in download item notifications on Chrome OS when using --enable-features=NativeNotifications Bug: 578868 Change-Id: I781c10387479ed921f0a7b4efce262b18f04844f Reviewed-on: https://chromium-review.googlesource.com/755317Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#515427}
-
Eddy Mead authored
This may allow us to speed up compilation by removing includes of ComputedStyle in some places. Gist diff: https://gist.github.com/wilddamon/56eb08d2493db7d67bed9c7fa728ed1f/revisions ComputedStyleBase by itself: https://www.diffchecker.com/lR5pzim1 StyleBuilderFunctions by itself https://www.diffchecker.com/B3XLnnLr Bug: 763306 Change-Id: Ie302c6a3aab4a75cc8fe9385b2dea8c053b22f2a Reviewed-on: https://chromium-review.googlesource.com/714896 Commit-Queue: meade_UTC10 <meade@chromium.org> Reviewed-by:
Bugs Nash <bugsnash@chromium.org> Cr-Commit-Position: refs/heads/master@{#515426}
-
Benjamin C. Wiley Sittler authored
This also fixes the IgnorableCodePoint test to use inputs which have nontrivial ISO-2022-JP shift states; previously this test did not actually ensure correct behavior when non-ASCII characters representable in ISO-2022-JP and non-ASCII characters not representable in ISO-2022-JP occur in sequence. This also adds WPT coverage. Prior to this fix, encoder state was not respected, leading to incorrect interpretation of the replacements and sometimes following bytes too, depending on whether the replacement lengths were even or odd, and on whether the active state of the ISO-2022-JP G0 character set was one-byte or two-byte. An example, with results transcribed in Unicode for readability: Input: ABC~¤•★星
🌟 星★•¤~XYZ Old output: Bytes: ABC~¤•␛$B!z@1🌟@1!z•¤␛(B~XYZ Meaning: ABC~¤•★星Γ渦祁卦酸院惕８臆胸Γ蔚柑~XYZ New output: Bytes: ABC~¤•␛$B!z@1␛(B🌟␛$B@1!z␛(B•¤~XYZ Meaning: ABC~¤•★星🌟星★•¤~XYZ Bug: 782565 Change-Id: If2a7b76b99ce77cbec433af5384ed5c4d2e3c581 Reviewed-on: https://chromium-review.googlesource.com/758405 Commit-Queue: Benjamin Wiley Sittler <bsittler@chromium.org> Reviewed-by:Jungshik Shin <jungshik@google.com> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#515425}
-
dpapad authored
FocusOutlineManager previously deferred updating the focus-outline-visible CSS class until a 'focus' event was received. This does not work in Shadow DOM, since 'focus' events do not reach the top level document element. Updating focus-outline-visible CSS class when a mouse or keyboard event occurs fixes the issue. Note: This slightly changes the behavior of FocusOutlineManager when 1) an element is focused by keyboard 2) while the element is focused the user clicks on it. Before, the focus outline would remain visible (introduced at crrev.com/22521002/). After, clicking on an element that already shows the outline will remove the outline. Bug: 772571,781459 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ie233c212fd17724ca8a43e46eb51398612644331 Reviewed-on: https://chromium-review.googlesource.com/749887 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#515424}
-
Xianzhu Wang authored
The code for these logs is compiled when DCHECK is on. The logs can be controlled using the --vmodule command line. Sample usage: out/Debug/content_shell --vmodule="*/paint/*=2,*/graphics/*=3" Details of modules and levels: - Module "*/paint/*" (matching core/paint and platform/graphics/paint) =1: paint property trees =2: =1 plus paint layer trees paint controller debug data without paint records (also for "*/graphics/*") =3: =2 plus (debug build only) paint controller debug data with paint records (also for "*/graphics/*") (debug build only) layout trees - Module "*/graphics/*" (matching platform/graphics) =2: graphics layer trees (spv1*) or composited layers (spv175+) with less verbosity =3: =2 trees with full verbosity and paint controller debug data as described in "*/paint/*" Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I71039a295d699f42d3a8e3ddcabd1ef05ce5af67 Reviewed-on: https://chromium-review.googlesource.com/754997 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#515423}
-
Misha Efimov authored
Bug: 775564 Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ia042509d3686d501f2b459c1fe03956422b5af4a Reviewed-on: https://chromium-review.googlesource.com/760487 Commit-Queue: Misha Efimov <mef@chromium.org> Reviewed-by:
-
Qiang Xu authored
changes: - Move accessibility_types.h to ash/public/cpp/ since it is used in both ash/ and chrome/. - Move kMagnificationScaleFactor to ash::MagnificationController. Majorly done by tools/git/move_source_file.py Bug: 618070 Test: still compiles Change-Id: Id8e641cc34d22395d12755df3ef372eb53187254 Reviewed-on: https://chromium-review.googlesource.com/761337 Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Reviewed-by:
-
Johann authored
Update scripts and build files for avx512 but disable it by default. Windows support is incomplete. Change-Id: I2a1b52651f205a88100302262f5d6aba540a3754 Reviewed-on: https://chromium-review.googlesource.com/758802 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by:
James Zern <jzern@google.com> Reviewed-by:
Tom Finegan <tomfinegan@chromium.org> Cr-Commit-Position: refs/heads/master@{#515420}
-
Evan Stade authored
It's not clear why this is necessary (a race during shutdown?), but it matches the precautions taken by the code previous to d0e4089e Bug: 783104 Change-Id: I0e837b789d43c48f38f062c72bd1d22f19d06d0b Reviewed-on: https://chromium-review.googlesource.com/762116Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#515419}
-
Hidehiko Abe authored
There was no guarantee between data read completion on a blocking thread and the D-Bus reply. If D-Bus reply is earlier than the data read, the data would be lost. This CL fixes it by waiting both data read completion and D-Bus reply. BUG=776310 TEST=Ran documentscan_AppTestWithFakeLorgnette on DUT. Change-Id: If887acf77b9451e52021d06d27f90852f961285f Reviewed-on: https://chromium-review.googlesource.com/754149Reviewed-by:
Dan Erat <derat@chromium.org> Commit-Queue: Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#515418}
-
Lei Zhang authored
Change-Id: Ie5526d13b4126f317e269b32f3aed06aa04b6428 Reviewed-on: https://chromium-review.googlesource.com/758887Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#515417}
-
Evan Stade authored
Bug: 783018 Change-Id: I782d8caafa7d4dcc4cc5ecb8816d64136b75ae09 Reviewed-on: https://chromium-review.googlesource.com/759617Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#515416}
-
Jochen Eisinger authored
R=mkwst@chromium.org BUG=762486 Change-Id: Idcde7a59825da89ed89b3408bfd6b78d2fe25885 Reviewed-on: https://chromium-review.googlesource.com/755133Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#515415}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/0d8766c84c80..22499b0969ac $ git log 0d8766c84..22499b096 --date=short --no-merges --format='%ad %ae %s' 2017-11-09 bungeman Update mirror-dev for *-dev:amd64 packages. 2017-11-09 herb Revert "Gauss filter calculation" 2017-11-09 reed Revert "Revert "Remove MakeForLocalSpace since picture image is sufficient"" 2017-11-09 brianosman Include target CS in SkColorSpaceXformCanvas' image info 2017-11-09 caryclark replace some points with vectors to clarify documentation 2017-11-09 jvanverth Move ms meter from the title bar to the display 2017-11-09 egdaniel Dynamically load the vulkan library in our test tools 2017-11-09 ethannicholas renamed GrPrimitiveEdgeType / GrProcessorEdgeType to GrClipEdgeType 2017-11-09 halcanary SkTypeface_win_dw, SkTypeface_Mac: set NotEmbeddable_FontFlag 2017-11-09 angle-deps-roller Roll skia/third_party/externals/angle2/ 661fc487d..9e888a46f (2 commits) 2017-11-03 herb Gauss filter calculation 2017-11-09 angle-deps-roller Roll skia/third_party/externals/angle2/ 73dcc60c8..661fc487d (1 commit) 2017-11-09 kjlubick Use validating buffer for skpath 2017-11-09 reed Revert "Remove MakeForLocalSpace since picture image is sufficient" 2017-11-09 mtklein remove SkFixedMul_arm() 2017-11-09 bungeman Update doc and example for SkPaint::FontMetrics. 2017-11-09 benjaminwagner Guard VFPv3 ASM with an ifdef. 2017-11-09 ahaas [v8-platform] Store the platform in a unique_ptr 2017-11-09 angle-deps-roller Roll skia/third_party/externals/angle2/ 70b715c9b..73dcc60c8 (3 commits) Created with: roll-dep src/third_party/skia BUG=772651,781164 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=egdaniel@chromium.org Change-Id: I2244a33b3cab5564b38e5fb69ae58a5ad87e6f35 Reviewed-on: https://chromium-review.googlesource.com/762400Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#515414}
-
Darren Shen authored
This patch: - Moves CSSURLImageValue tests to a subfolder containing all the other CSSStylevalue subclasses. - Adds the appropriate meta and link tags. - Clean up the test code a bit. - Remove redundant unit tests Note: Following the WPT guidelines, our test structure closely follows the spec structure. Therefore, serialization and normalization of URL image values will be done in a separate file as it is a separate section in the spec. Spec: https://drafts.css-houdini.org/css-typed-om-1/#imagevalue-objects WPT Guidelines: http://web-platform-tests.org/writing-tests/general-guidelines.html There's one failing test where we are not throwing an error when the URL is invalid. Also, we should be resetting attributes back to null if there was an error loading the resource. Bug: 774887 Change-Id: Ieb1df73e538d6343fc8e8d05569981349aa90118 Reviewed-on: https://chromium-review.googlesource.com/759704Reviewed-by:
meade_UTC10 <meade@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#515413}
-
Bo Liu authored
Now that O SDK is upstreamed. Change-Id: I06f58795cfa85dd818eb096a54781f77faba316e Reviewed-on: https://chromium-review.googlesource.com/762063Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#515412}
-
Yixin Wang authored
Bug: Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I3d94af5e54d4a989a216d79895deb9cd651f7717 Reviewed-on: https://chromium-review.googlesource.com/761339Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Yixin Wang <wangyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#515411}
-
Leo Zhang authored
Add a new languages prefs page under "Settings" and create an experiment to protect the feature until it's launched. Tested locally, screenshots: https://screenshot.googleplex.com/FroXGdSY26V https://screenshot.googleplex.com/m3ym9gvsysg Bug: 783049 Change-Id: I6e99d8833392e0df9e7c35ce0f52bd46fd31e69a Reviewed-on: https://chromium-review.googlesource.com/760081Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#515410}
-
Jialiu Lin authored
Make the finch param in fieldtrial_tsting_config consistent with google3 config. ../chrome/finch/studies/GaiaPasswordReuseCanDev.json Bug: Change-Id: I46d30a4d6361137ad777c9c0691ccd201a0c6a09 Reviewed-on: https://chromium-review.googlesource.com/762357Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Jialiu Lin <jialiul@chromium.org> Cr-Commit-Position: refs/heads/master@{#515409}
-
Hitoshi Yoshida authored
In bindings layer, we did not take care of [SecureContext] extended attribute on contexts and static attributes (i.e. on-interface properties) of partial interfaces. This CL makes those interface members accessible only if the context is secure. Bug: 779938, 782121 Change-Id: Iff5a5b85ce8d9b4bd20871298b93b60c054246ba Reviewed-on: https://chromium-review.googlesource.com/758278Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#515408}
-
Jinyoung Hur authored
This CL add the following UMA: 1. If password is selected by user when importing Firefox profiles. 2. How many passwords are imported from Firefox. R=isherman@chromium.org, vabr@chromium.org Bug: 776664 Change-Id: Ife7b1079502d4c4f0ebd2fb473bceb5feec7ddbc Reviewed-on: https://chromium-review.googlesource.com/744061 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#515407}
-
Mike Dougherty authored
Captive portal detection may take a very long time in which case the SSL error interstitial will be shown to the user instead of waiting to determine the captive portal state. Bug: 754378 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I31c982f581d4b1cb8b86dfb39c722955f6769cd6 Reviewed-on: https://chromium-review.googlesource.com/759169 Commit-Queue: Mike Dougherty <michaeldo@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#515406}
-
Miguel Casas-Sanchez authored
This CL extends |kDcQLookup| and |kAcQLookup| for 10-bit VP9 formats (they are also reformatted to suit the definition on the Spec [1] -- hence the "clang format off". The tables are moved to the anonymous namespace at the top of the file. This CL also adds a new ivf file and extends vp9_parser_unittest.cc (Vp9ParserTest) accordingly. libva (via vaapi_* files) is the only client that supports VP9.2 and only supports 10 bits per component formats, so there's no point in supporting 12 bits per component now (see https://github.com/01org/libva/issues/137). Method Vp9Parser::SetupSegmentationDequant() is changed to return a boolean which is false if e.g. the VP9 has an unsupported bit depth. ToT has only a DLOG_IF(ERROR...). [1] https://www.webmproject.org/vp9/#draft-vp9-bitstream-and-decoding-process-specification Bug: 778093 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I4179c2849160f8486252e48b8e648ab78eff92e0 Reviewed-on: https://chromium-review.googlesource.com/740762Reviewed-by:
Fredrik Hubinette <hubbe@chromium.org> Reviewed-by:
Kuang-che Wu <kcwu@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#515405}
-
Scott Violet authored
This makes mojo.fyi.mus.browser_tests.filter match that of the one used on the main waterfall (mus.browser_tests.filter) and enables some WebView tests that now pass locally. BUG=755328 TEST=test only change TBR=msw@chromium.org Change-Id: I65addd8e67d11d392a762f55ff110019bf88a6ed Reviewed-on: https://chromium-review.googlesource.com/762102 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
-
Victor Costan authored
Release notes for the new version: https://sqlite.org/releaselog/3_21_0.html Patch 0003 (Modify default VFS to support WebDatabase) was updated to reflect conflicts introduced by the following commits: * https://www.sqlite.org/src/info/3075cfa07489eaf1 * https://www.sqlite.org/src/info/1a7e0b61c8a6bdd3 The patch was updated to reflect the rename of pUnused to pPreallocatedUnused and an extra assert added. Both changes were in src/os_unix.c. Patch 0004 (Virtual table supporting recovery of corrupted databases) was updated to reflect the addition of new compile-time flags to main.mk. Patch 0005 (Custom shell.c helpers to load Chromium's ICU data) was updated to reflect conflicts introduced by https://www.sqlite.org/src/info/36acc0a97fdcc6f5 which replaced src/shell.c with src/shell.c.in, which is used to generate src/shell.c via Tcl. The change in the build process also introduced conflicts in main.mk. Patch 0009 (Fix _CRT_RAND_S conflict in sqliteInt.h) was removed completely. It is no longer necessary, because https://www.sqlite.org/src/info/3a2793aa65727cbb removed the use of _CRT_RAND_S in src/sqliteInt.h. Patches 0012 and 0013 were removed, because they were backports for upstream changes that fixed clusterfuzz issues. Upgrading removed the need for backports altogether. The new SQLite release allows ATTACH and DETACH to be used inside transactions, so sql/connection_unittest.cc was updated to reflect the new behavior. The test for attaching databases was broken into two tests, covering the behavior with and without a transaction. The former test (covering the behavior with a transaction) has separate implementations for iOS, where we use the system SQLite, which might be old, and every other platform, where we ship our own SQLite version. Bug: 780626, 701522 Change-Id: I7a8378cb317966388ebe9903d9e61162d3b3d3c9 Reviewed-on: https://chromium-review.googlesource.com/754522Reviewed-by:
Chris Mumford <cmumford@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#515403}
-
Alex Moshchuk authored
This is a followup to the fix in r513607, which disallowed reusing processes for which IsSuitableHost() returns false. MayReuseHost() is used (i.e., is false) in two cases today: (1) for the subframe process in --top-document-isolation, and (2) for prerender processes. It seems desirable to also prevent SiteProcessCountTracker from reusing these processes in those cases. This would prevent isolated origin subframes and ServiceWorkers from reusing the TDI or prerender processes. Bug: 780661, 780089 Change-Id: I56981716bb7cdc53c5ae8a664cacaffbc178fff9 Reviewed-on: https://chromium-review.googlesource.com/754269Reviewed-by:
Charlie Reis <creis@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#515402}
-
Mathieu Perreault authored
Previously, flag value could not be read from the renderer. Switching to base::Feature makes this possible. Note: team should move more features to common/autofill_features instead of browser/autofill_experiments. Bug: None Test: Manual Change-Id: I16d4a58802be4f36e77d6505770e7463d04037bf Reviewed-on: https://chromium-review.googlesource.com/760666Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#515401}
-
Chris Hamilton authored
This creates the "allow-third-party-modules" flag, and plumbs it into the sandbox to disable the BINARY_SIGNATURE process mitigation when specified. It also adds this flag to the list of bad flags. In the future this CL will also be integrated with the third party blocking logic in chrome_elf. BUG=757454 Change-Id: I38199c295d4957795ff9c1302889115af5a8222a Reviewed-on: https://chromium-review.googlesource.com/751298Reviewed-by:
Penny MacNeil <pennymac@chromium.org> Reviewed-by:
-
Peter Boström authored
These strings used to be referenced by chrome/browser/chromeos/dbus but the printer service provider that used them is no longer present and the strings are no longer referenced. Bug: chromium:783396 Change-Id: I440abd89c19688b0e4f2496e3d439695da684751 Reviewed-on: https://chromium-review.googlesource.com/762180Reviewed-by:
-
Alexey Kozyatinskiy authored
R=chenwilliam@chromium.org TBR=dgozman@chromium.org Bug: chromium:667560 Change-Id: I4bfd9da5a595af7dd042df4c789490c2a5138474 Reviewed-on: https://chromium-review.googlesource.com/760670Reviewed-by:
Will Chen <chenwilliam@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#515398}
-
Gabriel Charette authored
Migrate MessageLoop::ScopedNestableTaskAllower to RunLoop::Type::kNestableTasksAllowed in /content/renderer/pepper This pass focuses on ML::SNTA in same scope as an anonymous RunLoop().Run() Scripted via a small tweak of https://bugs.chromium.org/p/chromium/issues/detail?id=781352#c1 which focused on RunLoops with a variable name. The script should have replaced a MessageLoop::ScopedNestableTaskAllower in the same scope as a RunLoop with a RunLoop of Type::kNestableTasksAllowed. If there was a comment above the MessageLoop::ScopedNestableTaskAllower, it should have been moved alongside the augmented RunLoop. Please CQ if LGTY This CL was uploaded by git cl split. R=raymes@chromium.org Bug: 781352 Change-Id: I1e5c95734c96387029b4a5818fe21c0dbc0d581c Reviewed-on: https://chromium-review.googlesource.com/758881 Commit-Queue: Raymes Khoury <raymes@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#515397}
-
Gregory Chatzinoff authored
This CL enables canonical URL sharing by default. This way, a Finch configuration is not needed unless the kill switch is required. Bug: none Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I0cfd53eac3f62c006d55242d8a05fe5ee575ecb8 Reviewed-on: https://chromium-review.googlesource.com/761766Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#515396}
-
Ned Nguyen authored
This reverts commit 2bb93107. Reason for revert: Bug:783503 Original change's description: > Add kooora loading stories which represent RTL languages web sites > > This CL also tries out the new story name format <user intent>:<site cateogory>:<site name>:<year recorded> > > Bug: chromium:774577 > Change-Id: I2ba1dfa7311e70bfbaa1d6f2cf26f53ca70d9a20 > Reviewed-on: https://chromium-review.googlesource.com/723134 > Commit-Queue: Ned Nguyen <nednguyen@google.com> > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > Cr-Commit-Position: refs/heads/master@{#515322} TBR=perezju@chromium.org,nednguyen@google.com Change-Id: I0fa582406176559a599f83622796852be53c63bb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:774577 Reviewed-on: https://chromium-review.googlesource.com/762123Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#515395}
-
Kevin Marshall authored
Additionally add "net_unittests" test job to the trybot recipe. Bug: 780652 Change-Id: I1baaecac057d7784166710baa52608f6272e659f Reviewed-on: https://chromium-review.googlesource.com/761763 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
- paint/invalidation/flexbox/repaint-opacity-change-expected.html Previously this test changed opacity from 1 to 0.5 then to 1 in the same document cycle and expected full invalidation which didn't happen for SPv175+ because there was no actual opacity change. Now let the test change opacity from 0.5 to 1. - paint/invalidation/invalidate-descendants-when-receiving-paint-layer.html Previously there was no visual change, and no raster invalidation in SPv175+. Now give the objects background to make them visible. - paint/invalidation/media-audio-no-spurious-repaints.html The previous script detecting raster invalidation on VIDEO didn't work for SPv175+ because the VIDEO object itself paints nothing. Now detect raster invalidation of the thumb. Also rebaselined several tests with different but valid result for SPv175. Bug: 771643 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ic7d4e89d6308086861f905d97598f8a2077c8fd0 Reviewed-on: https://chromium-review.googlesource.com/760671Reviewed-by:
Tien-Ren Chen <trchen@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#515393}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/675513b96a7a..7501b1c3d110 $ git log 675513b96..7501b1c3d --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I62dd8b96f7b385e0b911c60ee48a3a2926a96e46 Reviewed-on: https://chromium-review.googlesource.com/761896Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#515392}
-
Javier Fernandez authored
We are changing how we compute the grid area's size of positioned items, trying to make the logic as independent as possible of the grid container's direction. The new way of placing absolute positioned elements in their grid area is based on the previously computed area's size. This provide a mechanism to place an item in its area respecting the offsets derived from the Content Alignment CSS properties and, which is more important, ignoring the grid container's direction. Additionally, we use the already implemented alignment logic that's used for regular grid items. This patch provides almost full alignment capabilities for positioned objects, with the exception of 'stretch'. It's worth mentioning that some of the test cases using vertical-rl writing mode will fail because of the bug 779105. Bug: 603423, 777978 Change-Id: I8fb121418795244d13589d603007c70f58e1f2df Reviewed-on: https://chromium-review.googlesource.com/672423Reviewed-by:
Manuel Rego Casasnovas <rego@igalia.com> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#515391}
-
Han Leon authored
Before this CL, after updated ServiceWorkerContainer#controller, ServiceWorkerProviderContext still holds an extra ServiceWorkerHandleReference retaining a reference to the corresponding ServiceWorkerHandle in the browser process. This is unnecessary because this extra ServiceWorkerHandleReference is only used to provide the controller service worker version id, so this CL just passes it to the ServiceWorkerContainer, to make the ownership transfer process clearer. This CL removes one usage to ServiceWorkerHandleReference::Create() to enable us to eliminate ServiceWorkerHandleReference class later using blink::mojom::ServiceWorkerObjectInfoPtr directly. BUG=772713 Change-Id: I6657826355aa367604e5986751562dc413cc343e Reviewed-on: https://chromium-review.googlesource.com/756818 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#515390}
-
