GitLab

BUG=None
R=xiyuan@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/167413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251492 0039d316-1c4b-4281-b951-d872f2087c98

BUG=144496,286542

Review URL: https://codereview.chromium.org/165263006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251491 0039d316-1c4b-4281-b951-d872f2087c98

 Factor out KeyHoldDetector.

BUG=343277
TEST=SpokenFeedbackTogglerTest

Review URL: https://codereview.chromium.org/164823005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251490 0039d316-1c4b-4281-b951-d872f2087c98

BUG=343239

Review URL: https://codereview.chromium.org/166283002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251489 0039d316-1c4b-4281-b951-d872f2087c98

This adds a new UMA histogram, "Download.FeedbackDialogEnabled." The histogram tells us how the user responded to the opt-in reporting dialog (enabled = true, disabled = false).

BUG=312533

Review URL: https://codereview.chromium.org/163433012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251488 0039d316-1c4b-4281-b951-d872f2087c98

[Hotword] Updating the helper extension to listen to the speech reset message from the main extension.

BUG=325439, 289023
TBR=jhawkins@chromium.org

Review URL: https://codereview.chromium.org/164313005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251487 0039d316-1c4b-4281-b951-d872f2087c98

In builds where DCHECKs are compiled in (e.g. developer
builds and Chrome Canaries), the DCHECK_EQ() in the
histogram macro was expanding to a lot of generated
machine code.

This CL moves that DCHECK() to a function instead, so that the
code is not duplicated in every call site. The function call is
wrapped behind a DCHECK_IS_ON() conditional, so that it will
still be omitted if DCHECKs are not compiled into the build.

Makes my Chromium release build smaller by over 1MB,
measuring size of Chromium Framework.

Before size: 146547380
After size:  145400692

BUG=343946
TEST=No functional changes.

Review URL: https://codereview.chromium.org/167343002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251486 0039d316-1c4b-4281-b951-d872f2087c98

Currently a system is considered to be supported in three cases:
 1. ~/.chrome-remote-desktop-session file exists.
 2. ~/.config/chrome-remote-desktop directory exists.
 3. DISTRIB_ID=Ubuntu is set in /etc/lsb-release

BUG=149744
R=lambroslambrou@chromium.org

Review URL: https://codereview.chromium.org/159753008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251485 0039d316-1c4b-4281-b951-d872f2087c98

The controller now does a lot more updating/clobbering/fiddling of the view when the model changes (i.e. all the stuff right after view_->ModelChanged()). This means we can afford to do a lot less in AutofillDialogViews::ModelChanged.

Although I'm not sure of the root cause of the crash in the bug, this will also have the side effect of fixing the crash because ModelChanged is part of the stack.

Also, as a further precaution, don't de-ref a possibly NULL |instrument| (even though it does seem like it should definitely be non-NULL).

BUG=343595

Review URL: https://codereview.chromium.org/164543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251484 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
NOTRY=true
NOTREECHECKS=true
R=yfriedman@chromium.org

Review URL: https://codereview.chromium.org/163613013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251481 0039d316-1c4b-4281-b951-d872f2087c98

Didn't account for test's usage of PrivateKey.
BUG=341500

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251476 0039d316-1c4b-4281-b951-d872f2087c98

Broke tests: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/18614/steps/unit_tests/logs/stdio#failure4

> Migrate old Shortcuts DB data to conform to new type values
> 
> All new suggestion types will be a Google Search URL with https. In some cases,
> url may contain additional identifying parameter.
> 
> BUG=339270
> TBR=brettw@chromium.org
> 
> Review URL: https://codereview.chromium.org/134853004

TBR=skanuj@chromium.org

Review URL: https://codereview.chromium.org/163613012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251473 0039d316-1c4b-4281-b951-d872f2087c98

Pulling this out into a separate class lets it be reused by SingleThreadProxy.

BUG=329552

Review URL: https://codereview.chromium.org/154163005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251471 0039d316-1c4b-4281-b951-d872f2087c98

latter.

BUG=344097
TBR=yoz@chromium.org

Review URL: https://codereview.chromium.org/168153002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251470 0039d316-1c4b-4281-b951-d872f2087c98

BUG=343669, 343617
TEST=none
R=ddorwin@chromium.org

Review URL: https://codereview.chromium.org/163433004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251469 0039d316-1c4b-4281-b951-d872f2087c98

In this case add 10 layers. This roughly describes a complex chromeos
desktop environment I hope.

On an N4:
*RESULT occlusion_tracker_time: unoccluded_content_rect_fully_occluded= 13.10741901397705 us
*RESULT occlusion_tracker_time: unoccluded_content_rect_10_opaque_layers= 27.276884078979492 us

R=enne@chromium.org, enne
BUG=

Review URL: https://codereview.chromium.org/165413002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251466 0039d316-1c4b-4281-b951-d872f2087c98

Previously, only galleries of type scan results where added, now any gallery that has media file counts and the app doesn't have permission to is displayed.

BUG=161119

Review URL: https://codereview.chromium.org/148063006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251465 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/158113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251464 0039d316-1c4b-4281-b951-d872f2087c98

Some build envs don't understand OVERRIDE without that header.

Review URL: https://codereview.chromium.org/165693003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251463 0039d316-1c4b-4281-b951-d872f2087c98

Just tweaking the backoff constants to better reflect what to do in case of
server error. Future patches will introduce alternative policies for different
kinds of errors.

BUG=284553

Review URL: https://codereview.chromium.org/164183008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251462 0039d316-1c4b-4281-b951-d872f2087c98

This CL does a number of things:
1) Extracts an AndroidKeyStore interface which specifies the API needed by the
native OpenSSL engine from an AndroidKeyStore. Also changes from using
PrivateKey to AndroidPrivateKey to provide a layer of indirection needed for a
remote PrivateKey
2) Renames the previous AndroidKeyStore to AndroidKeyStoreLocalImpl as it's
used for interacting with an in-process Android KeyStore
3) Provides a new class AndroidKeyStoreRemoteImpl and corresponding
IAndroidKeyStoreRemote.aidl that together specify the interface and interaction
with a remote process managing an Android KeyStore
4) Alters the PKCS11-based authentication flow to only use out a remote Android
KeyStore
5) Adds a new method to the previous AndroidKeyStore interface to facilitate
clean up of remote keys

BUG=341500
CONTRIBUTOR=ppi@chromium.org
R=bulach@chromium.org, klobag@chromium.org
TBR=rsleevi
NOTRY=true

Review URL: https://codereview.chromium.org/166143002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251461 0039d316-1c4b-4281-b951-d872f2087c98

The line endings were introduced at r251144

BUG=none
TBR=scottmg@chromium.org, cpu@chromium.org

Review URL: https://codereview.chromium.org/168063002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251460 0039d316-1c4b-4281-b951-d872f2087c98

The setuid sandbox waits on its one child and then dies
afterwards.

When receiving SIGABRT, instead of dumping core, simply exit the
process. There is no interesting information to be gathered from
knowing that the process is inside waitid(2), one should look at
the child process instead.

This patch is in hope to reduce red herrings.

BUG=334345
TBR=jorgelo
NOTRY=true

Review URL: https://codereview.chromium.org/167583002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251459 0039d316-1c4b-4281-b951-d872f2087c98

When there is more than 1 core in the system, request extra temp files
and use LLC's StreamInitWithSplit rpc to enable module splitting.
If the RPC fails, fall back to StreamInitWithOverrides.

Add a private Pepper interface to get the cpu count rather than
duplicating base::SysInfo in the plugin.

TEST=browser_tests --gtest_filter=NaClBrowserTstPnacl.*
BUG= https://code.google.com/p/nativeclient/issues/detail?id=3777
R=jschuh@chromium.org, jvoung@chromium.org, teravest@chromium.org

Review URL: https://codereview.chromium.org/165433003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251458 0039d316-1c4b-4281-b951-d872f2087c98

BUG=143230

Review URL: https://codereview.chromium.org/150943006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251457 0039d316-1c4b-4281-b951-d872f2087c98

Follow up of crrev.com/151813002.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/164493005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251456 0039d316-1c4b-4281-b951-d872f2087c98

This CL partially reverts r242570 and r243346.

The functionality added in those patches has been removed while some refactoring part
has been kept because those make sense and also because some code came later would have
to be moved otherwise.

The suspend/resume fullscreen video logic does not work well when the browser
activity is destroyed when it is in the background. Unfortunately I could not
find a way to make it work for that case yet so it's better remove it.

BUG=323697

Review URL: https://codereview.chromium.org/157783004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251455 0039d316-1c4b-4281-b951-d872f2087c98

This shouldn't be happening, but we got some crash reports suggesting it
does. Unable to repo locally so this stat will verify it does occur and
then can be used to verify our fixes actually fix it.

TBR=asvitkine@chromium.org
BUG=329023

Review URL: https://codereview.chromium.org/166953002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251454 0039d316-1c4b-4281-b951-d872f2087c98

That way we can easily change the size later. Security says 64 may be overkill.

BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251306

R=danakj@chromium.org

Review URL: https://codereview.chromium.org/138763009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251453 0039d316-1c4b-4281-b951-d872f2087c98

BUG=330631
R=frankf@chromium.org

Review URL: https://codereview.chromium.org/167643002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251452 0039d316-1c4b-4281-b951-d872f2087c98

- easier to read
- safer since gpu::Mailbox is constant size and checked in the ParamTraits

BUG=None

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251207

R=danakj@chromium.org, jschuh@chromium.org

Review URL: https://codereview.chromium.org/148003006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251451 0039d316-1c4b-4281-b951-d872f2087c98

Unit-tests cover HTTP case of a response received before post completes,
and websocket case of a CLOSE frame with SPDY FIN set (client should
still send a websocket CLOSE).

Also rename SpdyStream::IsIdleTemporaryRename() back to IsIdle().

TEST=Also tested with Fedor's test case from the ticket.
BUG=330860

Review URL: https://codereview.chromium.org/129543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251450 0039d316-1c4b-4281-b951-d872f2087c98

This will allow the script to be used with files in directories other than tools/metrics/histograms. Furthermore, print the relative path of the histograms.xml file actually used to avoid
confusion.

BUG=None

Review URL: https://codereview.chromium.org/163473008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251449 0039d316-1c4b-4281-b951-d872f2087c98

This helps to avoid confusion when wrench menu zoom affects DevTools instead
of the page.

BUG=343816

Review URL: https://codereview.chromium.org/165213006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251448 0039d316-1c4b-4281-b951-d872f2087c98

BUG=343311

Review URL: https://codereview.chromium.org/161933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251447 0039d316-1c4b-4281-b951-d872f2087c98

The old version parses the main.html file to get the list of JS files
to verify. Since we're moving to auto-generate this file, we can safely get
the Js files from the same gypi since that's the same source being used
to generate the HTML file.

This also adds the WCS sandbox files to the list of JS files being checked --
they were not being checked as part of the old target because they are not
used in the main.html file.

BUG=
R=jamiewalch@chromium.org

Review URL: https://codereview.chromium.org/163953011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251446 0039d316-1c4b-4281-b951-d872f2087c98

This CL introduces a level of indirection around ProfileOAuth2TokenService
(ProfileOAuth2TokenServiceWrapper) to eliminate PO2TS being a BCKS. The only
purpose of the wrapper class is to glue a PO2TS instance to a Profile; the
wrapper has no public API. In particular, PO2TSFactory still vends PO2TS
instances.

BUG=334187
TBR=jochen

Review URL: https://codereview.chromium.org/148513010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251444 0039d316-1c4b-4281-b951-d872f2087c98

Since the UI thread is the audio thread on OSX, we should be careful
about what we execute during startup.  Device enumeration and creation
of the device listener can be expensive, so don't do them until the
first stream is created.

BUG=288759
TEST=none

Review URL: https://codereview.chromium.org/154543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251443 0039d316-1c4b-4281-b951-d872f2087c98

All new suggestion types will be a Google Search URL with https. In some cases,
url may contain additional identifying parameter.

BUG=339270
TBR=brettw@chromium.org

Review URL: https://codereview.chromium.org/134853004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251442 0039d316-1c4b-4281-b951-d872f2087c98

We use the swap-buffers for normalizing in benchmarks, so this is the only trace labelled for now.

TBR=nduca
BUG=342635
NOTRY=true

Review URL: https://codereview.chromium.org/148613014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251441 0039d316-1c4b-4281-b951-d872f2087c98