GitLab

BUG=internal b/38263595
TEST=cast_base_unittests

Review-Url: https://codereview.chromium.org/2896673002
Cr-Commit-Position: refs/heads/master@{#473392}

There's a non-trivial overhead for the machinery to run posted tasks in
a given run loop mode. Only observe modes known to be run for a particular
thread.

BUG=640466, 724076

Review-Url: https://codereview.chromium.org/2889293002
Cr-Commit-Position: refs/heads/master@{#473391}

This Cl moves the imports of polymer.html to the top of the file so that
polymer.html is imported before other files. This is an exception to the
normal alphabetical order of imports. A blank line is added under this
first import to visually separate it from the rest of the imports, since
it's special.

This ensures that custom elements can be configured according to
polymer_config.js, which has to be loaded before any Polymer code.

(code health)
BUG=None
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2893063002
Cr-Commit-Position: refs/heads/master@{#473390}

With various changes coming to the Google local NTP, it'll be useful to
be able to differentiate it from the non-Google local NTP.

(Also, take over ownership of the histogram from people who don't work
in this area anymore.)

BUG=583292

Review-Url: https://codereview.chromium.org/2897523004
Cr-Commit-Position: refs/heads/master@{#473389}

Specifically, the automatic nature of Hands-Off Enrollment leads to
the DUT performing an update check after reboot which interferes
with autoupdate_EndToEndTest. This CL fixes that issue.
It does so by instructing the UpdateScreen to skip checking for updates
if both of the following conditions hold:
1. The previous update check initiated by the UpdateScreen did not result
in an update.
2. This previous update check occurred during the last hour.

BUG=chromium:710716
TEST=unit test

Review-Url: https://codereview.chromium.org/2894783003
Cr-Commit-Position: refs/heads/master@{#473388}

The usage of BrowserThread::FILE is deprecated in favor of the
post_task.h API.

BUG=689520

Review-Url: https://codereview.chromium.org/2898523002
Cr-Commit-Position: refs/heads/master@{#473387}

https://swiftshader.googlesource.com/SwiftShader.git/+log/9ed48ba..bf7a814

BUG=716803

TBR=kbr@chromium.org

TEST=bots

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2894253003
Cr-Commit-Position: refs/heads/master@{#473386}

The ExtensionsLoadTestWithLoginScreenApps.CommandLineExtensionsDontLoad
test was failing in mash_browsertests. According to some investigation,
it may be due to the problem not with the test itself, but with the test
suite (see https://crbug.com/716727#c6).

Therefore enabling the test, but with blacklisting it from running in
mash_browsertests.

Bug: 716727
Change-Id: I0860b9efbcfd5a333464a2567273a962d0957a5e
Reviewed-on: https://chromium-review.googlesource.com/503351Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Commit-Queue: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473385}

Revert of Add NTPCondensedLayout to test config. (patchset #3 id:40001 of https://codereview.chromium.org/2885023002/ )

Reason for revert:
crbug/724698

May be causing tests failures of NewTabPageTest. Small cl, so just going to revert.

Original issue's description:
> Add NTPCondensedLayout to test config.
>
> BUG=688291
>
> Review-Url: https://codereview.chromium.org/2885023002
> Cr-Commit-Position: refs/heads/master@{#473225}
> Committed: https://chromium.googlesource.com/chromium/src/+/de26ab98dcd8747564fd3e078db2862a53cb7246

TBR=asvitkine@chromium.org,bauerb@chromium.org,mvanouwerkerk@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=688291

Review-Url: https://codereview.chromium.org/2898533003
Cr-Commit-Position: refs/heads/master@{#473384}

Some stale .pyc files allowed its removal to go unnoticed on
bots and locally for me, it looks like.

This is a partial revert of r473381.

TBR=thestig@chromium.org
BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2900473002 .
Cr-Commit-Position: refs/heads/master@{#473383}

The mir project has been cancelled [1], so Chromium will never need
to support it.

libmirclient has previously interfered with developer builds [2],
leading to a complex hack [3] that placed all global variables in
libprotobuf-lite into their own shared library.

This CL adds a libmirclient.so.9 stub on Linux component builds.
The library will get loaded, but its symbols will never be used by
Chromium directly, or through GDK since only the X11 backend (and
wayland in the future) is whitelisted [4].

[1] https://arstechnica.com/information-technology/2017/04/ubuntu-unity-is-dead-desktop-will-switch-back-to-gnome-next-year/
[2] https://crbug.com/700120
[3] https://codereview.chromium.org/2756543002/
[4] https://cs.chromium.org/chromium/src/chrome/browser/ui/libgtkui/gtk_ui.cc?rcl=50612fa00dfc8e79fe5bc92e2f235eee645739e9&l=434

R=pkasting@chromium.org
BUG=700120

Review-Url: https://codereview.chromium.org/2885223002
Cr-Commit-Position: refs/heads/master@{#473382}

R=dpranke@chromium.org,sadrul@chromium.org,fukino@chromium.org
BUG=585553
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2887253006
Cr-Commit-Position: refs/heads/master@{#473381}

The scale factor can change even if the image itself doesn't change,
so the variables need to be updated before that early-out.

BUG=654631
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2888783002
Cr-Commit-Position: refs/heads/master@{#473380}

There is no point trying to take special actions on browser shutdown
aside from what is necessary to create isolation between test runs. This
change removes the UsbService's Shutdown method and removes the separate
shutdown logic from DeviceClient implementations. Service shutdown now
happens in the destructor. When running in the production browser we may
choose to even leak the USB and HID services on shutdown since the
process is exiting.

Bug: None
Change-Id: Ice9df8c5d78e486dfe4510227c39d2a74e0313c6
Reviewed-on: https://chromium-review.googlesource.com/508151Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473379}

It was already safe to call it off-sequence as of r472835.

But making it thread-safe is key to enabling use cases like:

  RunLoop run_loop_;
  <post a task binding run_loop_.QuitClosure() to task scheduler>
  run_loop_.Run();

e.g. happens in https://codereview.chromium.org/2881143002/ without this CL

Run() and Quit() are racing in this situation as the posted task may run
at any point after being posted. FYI, RunLoop() already supports being Quit()
prior to being Run() so the race resolving either way is fine, it just needs
to be thread-safe.

BUG=722537

Review-Url: https://codereview.chromium.org/2892993002
Cr-Commit-Position: refs/heads/master@{#473378}

Reland of Add a mock vision-common GMS client target (patchset #1 id:1 of https://codereview.chromium.org/2893093002/ )

Reason for revert:
downstream breakage fixed by adding another mock target downstream

Original issue's description:
> Revert of Add a mock vision-common GMS client target (patchset #1 id:1 of https://codereview.chromium.org/2888283002/ )
>
> Reason for revert:
> broke downstream
>
> Original issue's description:
> > Add a mock vision-common GMS client target
> >
> > Upcoming GMS versions will split the vision client into vision and
> > vision-common. In order to roll downstream, we must add an upstream
> > dependency on vision-common. But upstream is not yet ready to roll, so
> > we add a mock vision-common target to temporarily satisfy the new
> > dependency in upstream builds.
> >
> > BUG=706943
> > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_optional_gpu_tests_rel
> >
> > Review-Url: https://codereview.chromium.org/2888283002
> > Cr-Commit-Position: refs/heads/master@{#473268}
> > Committed: https://chromium.googlesource.com/chromium/src/+/420cf37ad0ddf1c54203a4fdffb68af920503b0e
>
> TBR=agrieve@chromium.org,reillyg@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=706943
>
> Review-Url: https://codereview.chromium.org/2893093002
> Cr-Commit-Position: refs/heads/master@{#473302}
> Committed: https://chromium.googlesource.com/chromium/src/+/9010e14d8fc816219fe22ca57b63a9d1eefef45b

TBR=agrieve@chromium.org,reillyg@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=706943

Review-Url: https://codereview.chromium.org/2892953003
Cr-Commit-Position: refs/heads/master@{#473377}

BUG=723821
TBR=dpranke@chromium.org

Review-Url: https://codereview.chromium.org/2889153007
Cr-Commit-Position: refs/heads/master@{#473376}

NightLightController depends on the PrefService to read and write
user prefs related to NightLight. It uses a PrefChangeRegistrar to
observe changes to those prefs. PrefChangeRegistrar is not expected
to outlive the PrefService, and hence must be destroyed first.

BUG=724231
TEST=Start chrome with --mash and expects to see no crashes
NightLightController when Shell is destroyed.

Review-Url: https://codereview.chromium.org/2892983002
Cr-Commit-Position: refs/heads/master@{#473375}

GraphicsContextCanvas used to use the device clip on the recording
canvas (which is initialized when creating the canvas, and then clipped
by further clips on the base layer) along with a local clip provided
by the user in the constructor.  It was trying its best to try to not
create bitmaps that were too large or to paint more than it should.

However, in current times, GraphicsContextCanvas is only used in
recording mode and the caller knows the entire rect that it needs.
This patch removes the dependency on the implicit canvas device clip
and only makes GraphicsContextCanvas depend on only the clip from
the constructor.

This regressed in https://codereview.chromium.org/2768143002 because
RecordPaintCanvas was unable to use the same internal resetForNextCanvas
function that SkRecorder uses to set the device clip to an arbitrary
rect.  RecordPaintCanvas sets the initial device clip to the
intersection of (0, 0, right, bottom) and the initial clip, in other
words, clamping it to the origin if it extends negatively left or up.
In this particular bug with rtl ui, the recording rect was negative,
and so that clamping made the button rect get clipped out and hidden
if it extended into negative space.

LocalCurrentGraphicsContext now takes the user clip in local space as
it always has, but then provides a device-space rect to
GraphicsContextCanvas which it uses as the size of the bitmap to
create as well as the location to paint that bitmap at the end.
This also simplifies the code and removes half of the callers that
ask about the device clip on PaintCanvas.

This should fix these device clip rect bugs ONCE AND FOR ALL.

See previous related issues here:
    https://chromium-review.googlesource.com/c/469073/
    https://chromium-review.googlesource.com/c/468348/

Bug: 722724
Change-Id: I181d4aff1387b1875a76d476351d4322ca46c4d8
Reviewed-on: https://chromium-review.googlesource.com/508096
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473374}

The current code to do CopyResource helps in some cases, but with 4k
videos it still may flicker black before the first frame. Waiting for
the GPU commands to execute before the commit seems to help.

BUG=654631
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2892123002
Cr-Commit-Position: refs/heads/master@{#473373}

BUG=724256

Review-Url: https://codereview.chromium.org/2892833002
Cr-Commit-Position: refs/heads/master@{#473372}

- Access DisplayItemClient::VisualRect() when a new DisplayItem is
  created, and save it in the new DisplayItem.
- When a cached display item is copied, don't access DisplayItemClient::
  VisualRect() but fetch from the cached DisplayItem.
- Remove DisplayItemList::visual_rects_.
- Save original visual rects (LayoutRect) and apply GraphicsLayer offset
  with EnclosingIntRect() when the display items are added into
  WebDisplayItemList.

Please see the bug for the reason.

BUG=724263
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2894093002
Cr-Commit-Position: refs/heads/master@{#473371}

BUG=593885
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2872023005
Cr-Commit-Position: refs/heads/master@{#473370}

And moves the lookup functions in window_state. I would prefer these
functions  be static functions on WindowState, but that's for another
day.

BUG=722553
TEST=covered by tests
R=msw@chromium.org

Review-Url: https://codereview.chromium.org/2889413002
Cr-Commit-Position: refs/heads/master@{#473369}

BUG=723795

Review-Url: https://codereview.chromium.org/2886243002
Cr-Commit-Position: refs/heads/master@{#473368}

Follow-up to https://codereview.chromium.org/2852923004

Discussion:
https://codereview.chromium.org/2852923004/diff/80001/gpu/command_buffer/service/shader_manager_unittest.cc#newcode248

Bug: 716018
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ib015e1d174500c19865cf51f50e6803fa1997fbd
Reviewed-on: https://chromium-review.googlesource.com/508279
Commit-Queue: Kai Ninomiya <kainino@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473367}

This short-circuits a conditional the way it used to be, avoiding
a bad cast in a unit test.

BUG=721975
TEST=CFI bot goes green.

Review-Url: https://codereview.chromium.org/2887153008
Cr-Commit-Position: refs/heads/master@{#473366}

ToolsMenu now scrolls and the close button is always floating in the corner.

SS:
https://drive.google.com/open?id=0Byo6-Nuda2jgemxMaUlxcUh0TDA

BUG=682880

Review-Url: https://codereview.chromium.org/2887263003
Cr-Commit-Position: refs/heads/master@{#473365}

https://skia.googlesource.com/skia.git/+log/7346a1f3b74e..a40d9c89b766

$ git log 7346a1f3b..a40d9c89b --date=short --no-merges --format='%ad %ae %s'
2017-05-19 msarett Improve test coverage of image decode modes
2017-05-19 reed stage version of vertices
2017-05-19 ethannicholas minor skslc bugfixes
2017-05-19 egdaniel Comment out lcd assert to make GLPrograms test happy
2017-05-19 stephana Remove transitional parts from iOS job names
2017-05-19 egdaniel Fix gpu lcd blending to semi-correctly handle alpha coverage
2017-05-19 msarett Temporarily use default webp encode method for bzl
2017-05-19 kjlubick Update NexusPlayers to O Preview 2

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=egdaniel@chromium.org

Change-Id: Ic3ea72cfe7062f6d5825c652948dbb57514fc984
Reviewed-on: https://chromium-review.googlesource.com/509972Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473364}

This CL:
- decouples white-balance setting from auto white balance (it'll
 be enforced at the Blink level in subsequent patches, so it's lined
 up with UVC platforms, i.e. Linux/CrOs and Win).
- and corrects a color temperature that was wrongly set.

Bug: 724626
Change-Id: I82d3ade5c753b64649ff35bed9fc175370cf932e
Reviewed-on: https://chromium-review.googlesource.com/510028
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473363}

Initial CL: https://codereview.chromium.org/2874413004/

Was reverted because it triggered a DCHECK in the UKMFormLogger.
csashi@ fixed this issue now (see crbug.com/722947).

BUG=718014

Review-Url: https://codereview.chromium.org/2897573003
Cr-Commit-Position: refs/heads/master@{#473362}

With the updated code for dispatching synthesized input events during
telemetry tests (crrev.com/472595), InputRouterClient::DidFlush() and
InputRouter::RequestNotificationWhenFlushed() are no longer needed. So
remove the associated code and tests.

BUG=722921

Review-Url: https://codereview.chromium.org/2893843002
Cr-Commit-Position: refs/heads/master@{#473361}

Even if user has SafeBrowsing Extended Reporting enabled, we want to refrain from sending a hit report when the user is in incognito mode.

BUG=689149

Review-Url: https://codereview.chromium.org/2886043002
Cr-Commit-Position: refs/heads/master@{#473360}

This is in order for the payment request on iOS to use this utility function.

BUG=602666

Review-Url: https://codereview.chromium.org/2888413006
Cr-Commit-Position: refs/heads/master@{#473359}

This CL is part of the Mojo Video Capture work. For the bigger picture,
see [1] CL25.

After this CL, the video capture service can be enabled by starting Chrome with
command-line flag --enable-features=MojoVideoCapture.

Changes in this CL:
* Add a base::Feature kMojoVideoCapture to allow switching the service on and
  off.
* Add a class VideoCaptureProviderSwitcher that can route device capture
  requests to the service's VideoCaptureProvider while routing screen capture
  requests to the InProcessVideoCaptureProvider.
* Hook up the VideoCaptureProviderSwitcher in the factory code in
  MediaStreamManager.
* Register video capture service in the service manager context for the Browser
  process.
* Remove build flag "enable_mojo_video_capture", since we want the service to
  be testable in all builds.
* Forward switches for using fake video capture devices to utility processes.
* Add test cases for exercising the service to VideoCaptureBrowserTest.

BUG=584797
TEST=
  content_browsertests --gtest_filter="VideoCaptureBrowserTest.*"

[1] https://docs.google.com/a/chromium.org/document/d/1Qw7rw1AJy0QHXjha36jZNiEuxsxWslJ_X-zpOhijvI8/edit?usp=sharing

Review-Url: https://codereview.chromium.org/2867213004
Cr-Commit-Position: refs/heads/master@{#473358}

BUG=None

Review-Url: https://codereview.chromium.org/2886083002
Cr-Commit-Position: refs/heads/master@{#473357}

https://pdfium.googlesource.com/pdfium.git/+log/76020fc9751e..92c13a7d495c

$ git log 76020fc97..92c13a7d4 --date=short --no-merges --format='%ad %ae %s'
2017-05-19 tsepez ASAN flags zero-length StringC in GetMapModuleString()
2017-05-19 npm Add test duplicate check in presubmit

Created with:
  roll-dep src/third_party/pdfium


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


TBR=dsinclair@chromium.org

Change-Id: I40779d4316de1b4574336131c1f94b40cac28968
Reviewed-on: https://chromium-review.googlesource.com/509953
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473356}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/16b38d742568..08a6e0ac161d

$ git log 16b38d742..08a6e0ac1 --date=short --no-merges --format='%ad %ae %s'
2017-05-19 thomasanderson Replace sanitizers:deps with exe_and_shlib_deps (catapult)

Created with:
  roll-dep src/third_party/catapult
BUG=723069


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ib279c2ba7fc20fb3c3a3ad57bc62f341333d9f02
Reviewed-on: https://chromium-review.googlesource.com/510009
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#473355}

The rootScroller's LayoutBox should use the view rect for clipping content
as hiding the URL bar will not increase the border box height. This also
requires invalidating compositing when the FrameView is resized (since it
may not result in a layout) or when a new Element is made the global root
scroller.

This patch fixes the issue for non-iframe rootScrollers. A follow-up patch
will make the equivalent change for iframes.

BUG=505516
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2796203002
Cr-Commit-Position: refs/heads/master@{#473354}

If a tab showing the save credit card buble is closed while the bubble
is still visible, the bubble will attempt to update the icon in the
location bar. Because the browser object is no longer available, this
causes a crash.

Note that this doesn't happen in the common case where the user
closes the tab by clicking on the tab close icon (x) because that action
closes the bubble first. But if the user closes the tab via a keyboard
shortcut or a page closes a child tab via javascript, then the crash
occurs.

BUG=694188

Review-Url: https://codereview.chromium.org/2887183005
Cr-Commit-Position: refs/heads/master@{#473353}