GitLab

version of the tested websites.
Some of the tested websites have changed over the last weeks. This cl
updates the password manager python tests so they can support
the new version of websites.
This cl adds also the tests for Twitter.
BUG=404647

Review URL: https://codereview.chromium.org/483763002

Cr-Commit-Position: refs/heads/master@{#291164}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291164 0039d316-1c4b-4281-b951-d872f2087c98

Example flake here:http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/8184/steps/%5Bswarming%5D%20content_browsertests%20%28with%20patch%29/logs/OverscrollNavigationTouchThrottling

BUG=

Review URL: https://codereview.chromium.org/491083002

Cr-Commit-Position: refs/heads/master@{#291163}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291163 0039d316-1c4b-4281-b951-d872f2087c98

When in fullscreen we should give back the fullscreen icon's width to the tabstrip.

Before: https://drive.google.com/open?id=0B1B1Up4p2NRMdXloQ3phSElBeEk&authuser=1
After: https://drive.google.com/open?id=0B1B1Up4p2NRMM2JNRE56aC1uRDA&authuser=1

BUG=403561

Review URL: https://codereview.chromium.org/493803002

Cr-Commit-Position: refs/heads/master@{#291162}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291162 0039d316-1c4b-4281-b951-d872f2087c98

This master CL lands recent SPDY changes through 73573949, extending them
with Chromium-specific updates to constants and enums, protocol negotiation
tokens, and tests.  This CL is intended to be commited but not reviewed, and is
the union of the following changes, which in turn are intended to be reviewed
but not commited.  (Most recent on top, oldest on bottom.)

Fix bug in HTTP/2 frame size limits.  This lands server change 73573949.
https://crrev.com/478903004

Update npn/alpn tokens to HTTP2-draft14.
https://crrev.com/486493003

Add kSpdyMaxControlFrameSize and kControlFrameSizeLimit constants.  This lands
server change 73427537.
https://crrev.com/486873002

Add TODO.  This lands server change 73426819.
https://crrev.com/479313002

Add an extra byte to the length field for HTTP/2 frame headers.  This lands
server change 73424406.
https://crrev.com/479303002

Change order of tests.
https://crrev.com/483863002

Remove reference set and exchange header and static table in HPACK.  This lands
server change 73299534.
https://crrev.com/480573003

Add new settings to SPDY4 for h2-14.  This lands server change 72726557.
https://crrev.com/480183002

Add kHttp2VersionString.  This lands server change 72173526.
https://crrev.com/485813002

HTTP2 draft 13: support unknown frame types and settings types as extensions.
This lands server change 70895882.
https://crrev.com/483843004

Allow unrecognized error codes as part of HTTP/2 extensions.  This lands server
change 70873693.
https://crrev.com/475043002

BUG=400336

Review URL: https://codereview.chromium.org/485833002

Cr-Commit-Position: refs/heads/master@{#291161}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291161 0039d316-1c4b-4281-b951-d872f2087c98

When user removes the last item (folder/page) from 'Other bookmarks' folder,
the folder itself is hidden; hence adding (empty) button is unnecessary. So
just close the folder before hiding it.

TEST=
1) Launch chrome and bookmark a page or folder into 'Other Bookmarks'.
2) Right-click on the bookmarked page/folder in the 'Other Bookmarks' from Bookmark bar.
3) Choose to 'Cut'/'Delete' and observe.
4) (empty) placeholder button should not remain after 'Other bookmarks' folder is hidden.

BUG=257538
R=asvitkine@chromium.org

Review URL: https://codereview.chromium.org/485003002

Cr-Commit-Position: refs/heads/master@{#291160}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291160 0039d316-1c4b-4281-b951-d872f2087c98

Followup to https://codereview.chromium.org/486283002/ which fixed only some of the cases. This CL ensures the bubble is updated also when the profile name is changed due to selecting a different avatar.

BUG=405050

Review URL: https://codereview.chromium.org/497453002

Cr-Commit-Position: refs/heads/master@{#291159}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291159 0039d316-1c4b-4281-b951-d872f2087c98

This CL is premised on the theory that the memory corruption and related
crashes are due to invalid input data being fed into the sessions sync
code.  See the linked bug for more details.

Adds two tests that expose the scenario that is believed to be the cause
of the bug.  If checked in on their own, they would crash during
destruction of the SyncedSessionTracker.

Adds a CHECK to prevent the SyncedSessionsTracker from getting in to
a bad state.  The goal of this CHECK is to ensure that all crashes
caused by misuse of the tracker cause a crash immediately, rather than
corrupting the memory allocator's internal data structures and possibly
causing crashes in unrelated code.  The newly added tests would trigger
this CHECK, if not for the last component of this CL.

Adds a filter for incoming sync_pb::SessionHeader values.  Before acting
on the session, the SessionsSyncManager will now verify that the header
does not contain any duplicate tab IDs.  If verification fails, the
header will be ignored.  This part of the CL allows the new tests to
pass.

BUG=360822

Review URL: https://codereview.chromium.org/495593003

Cr-Commit-Position: refs/heads/master@{#291158}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291158 0039d316-1c4b-4281-b951-d872f2087c98

Adds os_exchange_data_win_unittest.cc to Windows (it was incorrecly excluded before). Fixed a compilation error in that file.

Remove special filtering out in GYP build of base/ime/chromeos/character_composer_unittest.cc and base/ime/input_method_chromeos_unittest.cc since the standard filtering patterns match both of these.

R=sky@chromium.org

Review URL: https://codereview.chromium.org/496473003

Cr-Commit-Position: refs/heads/master@{#291154}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291154 0039d316-1c4b-4281-b951-d872f2087c98

Followup to https://codereview.chromium.org/483703002/

Turns out you can have a profile image, but no profile URL. Handle this case by resolving the image URL against a dummy https URL.

BUG=404671

Review URL: https://codereview.chromium.org/495003003

Cr-Commit-Position: refs/heads/master@{#291153}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291153 0039d316-1c4b-4281-b951-d872f2087c98

casting/sharing is turned on upon user switch

Purpose of this change:

Asks the user with a system modal dialog box if he wants to
turn off screen sharing/screen casting and then switch users
or abort switching users.

BUG=353170
TEST=TrySwitchingUserTest.*

Review URL: https://codereview.chromium.org/496563002

Cr-Commit-Position: refs/heads/master@{#291152}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291152 0039d316-1c4b-4281-b951-d872f2087c98

BUG=405486
R=dbeam@chromium.org

Review URL: https://codereview.chromium.org/489983003

Cr-Commit-Position: refs/heads/master@{#291151}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291151 0039d316-1c4b-4281-b951-d872f2087c98

Remove duplicate reference of content_switches which causes link errors.

Add dependency on theme_resources from apps (it includes the generated file).

R=miket@chromium.org

Review URL: https://codereview.chromium.org/496763002

Cr-Commit-Position: refs/heads/master@{#291150}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291150 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/491103004

Cr-Commit-Position: refs/heads/master@{#291149}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291149 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#291148}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291148 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=180694:180708&mode=html
TBR=dglazkov@chromium.org,wibling@chromium.org
BUG=

Review URL: https://codereview.chromium.org/495013002

Cr-Commit-Position: refs/heads/master@{#291147}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291147 0039d316-1c4b-4281-b951-d872f2087c98

These are regularly flaking on the build bots.  See bug for details.

NOTRY=true
TBR=miu@chromium.org
BUG=406018

Review URL: https://codereview.chromium.org/496053002

Cr-Commit-Position: refs/heads/master@{#291146}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291146 0039d316-1c4b-4281-b951-d872f2087c98

The skia bug suspected to cause this has been fixed.

R=tonyg@chromium.org
BUG=399125

Review URL: https://codereview.chromium.org/491583003

Cr-Commit-Position: refs/heads/master@{#291145}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291145 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
NOTRY=True

Review URL: https://codereview.chromium.org/498473002

Cr-Commit-Position: refs/heads/master@{#291142}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291142 0039d316-1c4b-4281-b951-d872f2087c98

This replaces the whitelisting of all Qualcomm GPUs on
Android 4.4 with whitelisting all Android 4.4 devices
with GL ES version >= 3.0.

BUG=405646

Review URL: https://codereview.chromium.org/468103003

Cr-Commit-Position: refs/heads/master@{#291141}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291141 0039d316-1c4b-4281-b951-d872f2087c98

See
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/5481
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/5503
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/5542

BUG=291249
TBR=jdduke@chromium.org

Review URL: https://codereview.chromium.org/492303005

Cr-Commit-Position: refs/heads/master@{#291139}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291139 0039d316-1c4b-4281-b951-d872f2087c98

Bug=352290

Review URL: https://codereview.chromium.org/486903002

Cr-Commit-Position: refs/heads/master@{#291138}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291138 0039d316-1c4b-4281-b951-d872f2087c98

Cross-origin HTTP auth dialogs are shown over a blank interstitial.
This didn't work nicely with other interstitials, e.g. an HTTPS resource
that triggered a basic HTTP auth dialog would show the SSL warning, and when
the user clicked through the warning, the login interstitial would show
on top of the SSL interstitial, rather than a blank page.
crrev.com/410373003 accidentally fixed that issue. This CL adds tests
for the scenario described above.

BUG=393597
TEST=LoginPromptBrowserTest.LoginInterstitialShouldReplaceExistingInterstitial

Review URL: https://codereview.chromium.org/397453002

Cr-Commit-Position: refs/heads/master@{#291137}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291137 0039d316-1c4b-4281-b951-d872f2087c98

TBR=ckocagil@chromium.org
BUG=406012

Review URL: https://codereview.chromium.org/482493003

Cr-Commit-Position: refs/heads/master@{#291136}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291136 0039d316-1c4b-4281-b951-d872f2087c98

Disable AppWindowInteractiveTest.ESCLeavesFullscreenDOM and AppWindowInteractiveTest.ESCDoesNotLeaveFullscreenWindow as they are flaky on Mac.

TBR=mlamouri@chromium.org
BUG=406009

Review URL: https://codereview.chromium.org/490293002

Cr-Commit-Position: refs/heads/master@{#291135}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291135 0039d316-1c4b-4281-b951-d872f2087c98

profile editor even when raw full name is missing.

BUG=403021

Review URL: https://codereview.chromium.org/450403004

Cr-Commit-Position: refs/heads/master@{#291134}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291134 0039d316-1c4b-4281-b951-d872f2087c98

BUG=352290

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291002

Review URL: https://codereview.chromium.org/481003002

Cr-Commit-Position: refs/heads/master@{#291133}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291133 0039d316-1c4b-4281-b951-d872f2087c98

This function is long and sophisticated. Factor out the code creating
and setting |stream_| and reorganize if-clauses.

Then, this CL adds for_websockets_ checks where it's missing.

R=jgraettinger,rch
BUG=394434

Review URL: https://codereview.chromium.org/443383002

Cr-Commit-Position: refs/heads/master@{#291131}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291131 0039d316-1c4b-4281-b951-d872f2087c98

Shell operations may cause 3rd-party shell extensions to be loaded into the calling process. Isolating them in a utility process protects the browser process from potential instability.

BUG=73098

Review URL: https://codereview.chromium.org/431343002

Cr-Commit-Position: refs/heads/master@{#291128}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291128 0039d316-1c4b-4281-b951-d872f2087c98

BUG=387613
R=nkostylev@chromium.org
TBR=stevenjb@chromium.org

Review URL: https://codereview.chromium.org/495563003

Cr-Commit-Position: refs/heads/master@{#291125}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291125 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#291123}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291123 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/4082d290eea2f70caa82120ff3bc4fbdccbf206c..1f31e7671721a9f2c204a0e1842961f43e7b53ca

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_layout_rel
TBR=caryclark@google.com
BUG=

Review URL: https://codereview.chromium.org/488383003

Cr-Commit-Position: refs/heads/master@{#291122}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291122 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/477193003

Cr-Commit-Position: refs/heads/master@{#291119}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291119 0039d316-1c4b-4281-b951-d872f2087c98

BUG=386454
R=manzagop@chromium.org, newt@chromium.org
TBR=erikwright
TEST=SuggestionsServiceTest

Review URL: https://codereview.chromium.org/473123002

Cr-Commit-Position: refs/heads/master@{#291116}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291116 0039d316-1c4b-4281-b951-d872f2087c98

This channel needs to be made synchronous to safely support sending a
synchronous message from the plugin to the renderer for reporting exit status.
The overall change for that support is available for review at:
  https://codereview.chromium.org/484783002/

This change splits out the channel refactoring to make this easier to review.

BUG=397161
R=dmichael@chromium.org

Review URL: https://codereview.chromium.org/486383002

Cr-Commit-Position: refs/heads/master@{#291113}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291113 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Only build various flash/pnacl/ppapi code when they are enabled. (patchset #7 of https://codereview.chromium.org/471263003/)

Reason for revert:
Suspected of breaking the disable_nacl build.

Original issue's description:
> Only build various flash/pnacl/ppapi code when they are enabled.
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291069

TBR=dyen@chromium.org,viettrungluu@chromium.org,thestig@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/492323002

Cr-Commit-Position: refs/heads/master@{#291112}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291112 0039d316-1c4b-4281-b951-d872f2087c98

The current random base address generation in the Android chromium linker is prone
to error.  It selects an address at random between 0x20000000 and 0x40000000 and
expects that this will be clear.  This is occasionally untrue for ARM, but very
often untrue for MIPS.  As a consequence, RELRO sharing is being turned off more
frequently than it could be.

This change removes the local random address generation code and instead replaces
it with code that speculatively maps a large region, captures the address returned
by mmap, then unmaps and returns the address.  The expectation is that this region
will remain free for use when the time comes for the crazy linker to map the browser
into it.  This generally holds because the time between these two actions is short
and little, if anything, loads or mmaps between them.  Worst case is that RELRO
sharing turns off as at present, but the probability of this happening should now
be much lower.

Note that capturing the address from mmap relies on Android ASLR being active for
mmap.  This is the default device state since ICS.  The revised random browser
load address is only as entropic as Android's ASLR.

BUG=397634

Review URL: https://codereview.chromium.org/470053003

Cr-Commit-Position: refs/heads/master@{#291111}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291111 0039d316-1c4b-4281-b951-d872f2087c98

..as their ASCII codes are used in various layout tests. Mapped to
VKEY_ESCAPE and VKEY_BACK, respectively.

R=tkent@chromium.org
BUG=392517

Review URL: https://codereview.chromium.org/488053002

Cr-Commit-Position: refs/heads/master@{#291110}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291110 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#291108}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291108 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert:
Caused regression in static initializer count:

 # webrtcvideoengine2.cc _GLOBAL__sub_I_webrtcvideoengine2.cc+0x53                                                                                            
  # webrtcvideoengine2.cc _GLOBAL__sub_I_webrtcvideoengine2.cc+0x5a                                                                                            
  # webrtcvideoengine2.cc _GLOBAL__sub_I_webrtcvideoengine2.cc+0x9                                                                                             
  # webrtcvideoengine2.cc __divdi3@plt     

http://build.chromium.org/p/chromium/builders/Linux/builds/52540

Original issue's description:
> Roll webrtc 6905:6948.
> 
> TBR=hclam@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=291082

TBR=hclam@chromium.org,grunell@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/495103003

Cr-Commit-Position: refs/heads/master@{#291106}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291106 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
NOTRY=True

Review URL: https://codereview.chromium.org/493143002

Cr-Commit-Position: refs/heads/master@{#291105}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@291105 0039d316-1c4b-4281-b951-d872f2087c98