GitLab

Removing the variable allow_redirect and calling
DispatchDidFailAccessControlCheck() immediately on each of check
points would be more readable.

Bug: 427429
Change-Id: Ib8d98c274104e2d5d6c65af123502b872a6658d7
Reviewed-on: https://chromium-review.googlesource.com/544646
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490744}

This reverts commit 28dfaa0d.

Reason for revert: This appears fixed in Xcode 9 beta 4.

Original change's description:
> iOS 11 WKWebView load is broken
> 
> In iOS 11, WKWebView has issues (time outs) when loading request if the
> view is not part of the hierarchy. The WKWebView is now added to the
> hierarchy but off screen.
> 
> Bug: 738435, 739390
> Change-Id: Ica8584c30a24a11c04658774bd22a77273a93514
> Reviewed-on: https://chromium-review.googlesource.com/577807
> Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
> Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Reviewed-by: Justin Cohen <justincohen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#488213}

TBR=rohitrao@chromium.org,msarda@chromium.org,justincohen@chromium.org,eugenebut@chromium.org,jlebel@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 738435, 739390
Change-Id: Ic57820325fef5ac86b93b4f02f449b97f0b458e0
Reviewed-on: https://chromium-review.googlesource.com/591671Reviewed-by: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Benoit Zanotti <bzanotti@chromium.org>
Reviewed-by: Jérôme Lebel <jlebel@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490743}

The root cause of https://crbug.com/745771 is that a listener object,
stored in V8AbstractEventListener::listener_, is wrongly collected by
V8 GC.

Listener objects are expected to be wrapper-traced at
DEFINE_TRACE_WRAPPERS(EventTarget) through
DEFINE_TRACE_WRAPPERS(Node) and DEFINE_TRACE_WRAPPERS(ContainerNode),
however, there seems no root object which kicks this path of wrapper-
tracing.

This CL adds a new path of wrapper-tracing from LocalDOMWindow to
Document.  Since LocalDOMWindow is a root object and Document is a
ContainerNode which wrapper-traces all child nodes, this CL makes sure
that all event listeners registered at any part of the document tree
alive.  (If an EventTarget is not attached to the DOM, such a case is
not covered by this CL.)

The fix was confirmed manually with using a test Chrome extension.

Bug: 745771
Change-Id: I7c0d1fb766b78fd4d32ce813662c947ce5f7e819
Reviewed-on: https://chromium-review.googlesource.com/591728Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490742}

This CL adds a static_assert to detect the Bind earlier and to emit an
readable error message.

Bug: 746955
Change-Id: Id8081be63f789c7896a9a4229fe3978a7fdedc41
Reviewed-on: https://chromium-review.googlesource.com/583976Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Taiju Tsuiki <tzik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490741}

This CL has no behavior changes.

Bug: 746157
Change-Id: Ia40822c341d827fccebb3968961205a0dd69a188
Reviewed-on: https://chromium-review.googlesource.com/593369Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490740}

Network traffic annotation of the following file is updated:
components/ntp_snippets/remote/contextual_json_request.cc

Bug: 656607
Change-Id: I3523c3875f83f3fc620984996aebc5da463d20c3
Reviewed-on: https://chromium-review.googlesource.com/589387Reviewed-by: Markus Heintz <markusheintz@chromium.org>
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490739}

This CL,
-Removes BUILD.gn files from components/download/ and
  components/download/content/ directories
-changes components_unittests to depend on
 //components/download/internal:unit_tests and
 //components/download/content/internal:unit_tests directly.

Bug: None
Change-Id: I921594005bae407b1747f50a2a90b3c4cd722fe7
Reviewed-on: https://chromium-review.googlesource.com/554424
Commit-Queue: SUCHIT AGRAWAL <a.suchit@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490738}

When TexImageHelperHTMLVideoElement goes to TexImageImpl path,
it will use video's natural size as the image size. However,
we should use the visible size when uploading video data.

Tested with https://github.com/KhronosGroup/WebGL/pull/2464

BUG=733172

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I2265ade9bb14b5c923af634f54116df678f4c224
Reviewed-on: https://chromium-review.googlesource.com/575365Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Fredrik Hubinette <hubbe@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Jiajia Qin <jiajia.qin@intel.com>
Cr-Commit-Position: refs/heads/master@{#490737}

Bug: 
Change-Id: I44f80c51d5e96816bf937eb46f000c0fdcfe271f
Reviewed-on: https://chromium-review.googlesource.com/591670
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490736}

Removing failure expectation for removed tests

Bug: 745385
Change-Id: Ica5c4b7f925ec2daed2c08b7f888e9cf03a4df82
Reviewed-on: https://chromium-review.googlesource.com/593384Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Commit-Queue: Austin James Ahlstrom <aahlstrom@google.com>
Cr-Commit-Position: refs/heads/master@{#490735}

It's valid to use extended blend modes in PaintFlags, just not on
DrawColor.  Oops.

Bug: 737629
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I0796d31a9688685d58e5efb3a07f5eb5c270184d
Reviewed-on: https://chromium-review.googlesource.com/589815
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: Khushal <khushalsagar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490734}

This CL replaces hard-coded image size in ProfileDataCache with a constructor
parameter and fixes its usages.

Bug: 746519
Change-Id: I1a663d4f9a1d9e6a57a73a3db12701c75ef09219
Reviewed-on: https://chromium-review.googlesource.com/591649Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490733}

This CL fixes SharedMemoryTracker::OnMemoryDump to use resident bytes
instead of virtual mmap-ed size so that memory-infra allocator dumps
will show accurate memory usages of shared memory.

SharedMemoryTarcker::OnMemoryDump will use CountResidentBytesInSharedMemory,
that uses syscalls (e.g. mincore on Linux). Calling those adds 1-2 [ms] in total to
create allocation dumps with one renderer, one browser and one gpu process.
See the document regarding the experiments of performance:
https://docs.google.com/document/d/1pNwUJVarTCZYaBbiZ4LUuRyTGAocCHKicnats20mLSM/edit#

Bug: 713768
Change-Id: Ied163094f9adcf4eba1c109f8ac39a1dae6bb6d3
Reviewed-on: https://chromium-review.googlesource.com/582065
Commit-Queue: Hajime Hoshi <hajimehoshi@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Primiano Tucci <primiano@chromium.org>
Reviewed-by: Siddhartha S <ssid@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490732}

The new class ContextualSuggestionsSource can retrieve contextual
suggestions for a given URL.
For a given contextual suggestion, it can also fetch an image.
Calls are asynchronous.
A ContextualSuggestionsSource will only be created if flag "contextual-suggestions-carousel"
is on.
It is owned by the ContentSuggestionsService.

Bug: 749988
Change-Id: Idce653d611d558f50c1c18bf419fc3c1cf98df49
Reviewed-on: https://chromium-review.googlesource.com/583091
Commit-Queue: Andre Gaschler <gaschler@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490731}

Bug: 428329
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: Ia439ef4ba035d4d8fb038aa0703ea9e6f93e3e89
Reviewed-on: https://chromium-review.googlesource.com/583447Reviewed-by: Egor Pasko <pasko@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490730}

Bug: None
Test: No behavior change
Change-Id: Ib07c4914cb9eada58b32c3e077a717d6bef57556
Reviewed-on: https://chromium-review.googlesource.com/592991Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Commit-Queue: Keigo Oka <oka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490729}

redhat-lsb implies many dependencies and on Fedora or RHEL some of these are
not needed at all (the most obvious one is qt3) and Chrome is usually the one
who pulls them to the system by requiring the whole lsb. Require only
lsb_release from the lsb as that's the only thing that we are using.

Tested by modifying the build system to be able to build Chromium RPM
packages and tested them on recent Fedora 26, RHEL 7 and OpenSUSE Leap
42.2.

BUG=133327

Change-Id: Ic291c3107320a8b195d939c561f677016f2bd1ee
Reviewed-on: https://chromium-review.googlesource.com/591107
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Paweł Hajdan Jr. <phajdan.jr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490728}

Match the mocks for Site Details and use the origin as the title for the Site
Details page.

This patch also strips off default ports, if they are included in the origin.

and verify the text next to the back arrow reads "https://randomsite.blah:324".
Navigate to
verify the text in the same spot reads "https://randomsite.blah".

Bug: 656758
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I2658e7ccbb950a0ce34c83d2e3504c3d8e0b55af
Test: Navigate to
chrome: //settings/content/siteDetails?site=https://randomsite.blah:324/path/blah
chrome: //settings/content/siteDetails?site=https://randomsite.blah:443 and
Reviewed-on: https://chromium-review.googlesource.com/567787
Commit-Queue: Patti <patricialor@chromium.org>
Reviewed-by: Dave Schuyler <dschuyler@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Raymes Khoury <raymes@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490727}

Bug: 740070
Change-Id: Ia51ecfea7c4b78d3328ca102ac8ece824ac1f1e7
Reviewed-on: https://chromium-review.googlesource.com/593381
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490726}

Reupload of https://chromium-review.googlesource.com/c/583971/.
This version excludes the replacement of PassRefPtr with RefPtr
in InterpolationEffect::AddInterpolation, which was causing a
unit test crash on linux_chromium_cfi_rel_ng
(http://crbug.com/749967). This bot is now passing with this
patch, see patch set #5 for results.

This patch
- replaces most uses of PassRefPtr with RefPtr in Source/core
  (excepting cases involving other type conversions)
- changes PassRefPtr to RefPtr in a virtual methods outside of
  Source/core that are overridden by methods changed in this patch

TBR=haraken@chromium.org

Bug: 494719
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I0132fdab61e36d43b7bf57f2074d1d220edb4088
Reviewed-on: https://chromium-review.googlesource.com/592994
Commit-Queue: Bugs Nash <bugsnash@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Eric Willigers <ericwilligers@chromium.org>
Reviewed-by: Yuta Kitamura <yutak@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490725}

Currently GetTickmarks is not implemented in PLSA so the tickmarks are
not getting painted for RLS flow.
Implemented this function now and updated testExpectations.

BUG=711474

Change-Id: I150dfd413d2ae015e7e9e2dad94d1116df049fb3
Reviewed-on: https://chromium-review.googlesource.com/578831Reviewed-by: Steve Kobes <skobes@chromium.org>
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#490724}

This is a reland of 84cd5556
Original change's description:
> Adjust WATCHLISTS rules for tyoshino@
> 
> - Add content_websockets and net_websockets for more WebSockets code
>   coverage
> - Group XHR, sendBeacon, EventSource and Fetch API into blink_fetch_api
> - Add / at the end of directories in blink_loader
> - Remove tyoshino@ from blink_fetch as blink_loader covers it now
> - Add blink_url_api, blink_streams
> 
> Bug: 
> Change-Id: I0fa0b2e22be6d9a4d086217cf664ac6b59db72d0
> Reviewed-on: https://chromium-review.googlesource.com/580010
> Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
> Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#490353}

Change-Id: Ia12824b6637cecc3b73aea8b254d542ff7c0393e
Reviewed-on: https://chromium-review.googlesource.com/591507Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Takeshi Yoshino <tyoshino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490723}

TBR=haraken,jochen
NOTRY=true

Change-Id: I764c7f96d306867c8fd0e1dda4f498bfc1285f87
Reviewed-on: https://chromium-review.googlesource.com/593310Reviewed-by: Sigbjørn Finne <sigbjornf@opera.com>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Sigbjørn Finne <sigbjornf@opera.com>
Cr-Commit-Position: refs/heads/master@{#490722}

This patch prunes a call site of the deprecated function by hoisting the
layout update out from it.

Bug: 698633
Change-Id: I483f06de2e1c3e0c4b99403ca9a4b2a48dae9517
Reviewed-on: https://chromium-review.googlesource.com/593208
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490721}

We'd like to fix the root cause of these failing tests. They are still skipped
because we know they will time out.

This CL has no behavior changes.

NOEXPORT=true
TBR=kochi@chromium.org

Bug: 749492
Change-Id: I4431045838e7ba1252db3a35ca3364fd6cb5e6e9
Reviewed-on: https://chromium-review.googlesource.com/593379
Commit-Queue: Kent Tamura <tkent@chromium.org>
Reviewed-by: Takayoshi Kochi <kochi@chromium.org>
Reviewed-by: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490720}

Exposes a setting and an interface for enabling externally-controlled
BeginFrames in ui::Compositor and adds a command line flag for the
full-pipeline scheduling mode.

Bug: 646774
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I923b5ab66652c65c1384b9fe5075c0a427559fc6
Reviewed-on: https://chromium-review.googlesource.com/558252
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Sunny Sachanandani <sunnyps@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490719}

It's used by no one.

Bug: 748491
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I88c95aca41625d3600c64d1de379a24159c33fd2
Reviewed-on: https://chromium-review.googlesource.com/587701Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Alok Priyadarshi <alokp@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490718}

This patch Mojoifies WebContentSettingsClient used by shared worker.
SharedWorkerContentSettingsProxy is created in browser, and then passed onto 
renderer.
Inside blink, it gets some content settings information from browser 
via mojom::SharedWorkerContentSettingsProxy.

Replaced by SharedWorkerContentSettingsProxy,
EmbeddedSharedWorkerContentSettingsClientProxy was removed.

There are no useful tests for indexeddb or filesystem, so I tested this patch
by hand, Using some .js and called indexeddb.open and webkitRequestFileSystem.
https://crbug.com/113738 is for adding indexeddb tests, and it is still available.

Bug: 739092
Change-Id: I5523b3ba533707416452a56c5f04250a1117ba15
Reviewed-on: https://chromium-review.googlesource.com/562854Reviewed-by: Makoto Shimazu <shimazu@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Commit-Queue: Yuki Yamada <yukiy@google.com>
Cr-Commit-Position: refs/heads/master@{#490717}

This patch deleted the duplicated methods accudentally introdued in
https://chromium-review.googlesource.com/c/578538/ when they were
supposed to be moved from CSSPropertyParser.cpp to
CSSPropertyGridTemplateAreasUtils.cpp but instead they were copied.

Bug: 668012
Change-Id: I3c7b32911fcc8ff64a200f1bdfb06cd17d15fd0a
Reviewed-on: https://chromium-review.googlesource.com/593371Reviewed-by: meade_UTC10 <meade@chromium.org>
Commit-Queue: Bugs Nash <bugsnash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490716}

TBR=ericwilligers@chromium.org

Bug: 750549
Change-Id: If67efe435530c714a3960c928a6e7c5bd71ca40e
Reviewed-on: https://chromium-review.googlesource.com/593376Reviewed-by: meade_UTC10 <meade@chromium.org>
Commit-Queue: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490715}

Bug: 748491
Change-Id: I5e86bf7a56def07546b17362f1e0c71395512b58
Reviewed-on: https://chromium-review.googlesource.com/577470
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Takeshi Yoshino <tyoshino@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Bill Budge <bbudge@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490714}

The original CL added more end-to-end tests. They set a limit of 1 GB as a
"sanity check". On 32-bit Windows, each renderer has ~500MB of committed
memory. Across multiple renderers, this easily exceeds the limit. This reland
updates the "sanity checks" to be 4 GB instead.

> The URLs are obtained by creating a new interface CoordinationUnitIntrospector
> on the resource_coordinator service. The implementation of this interface crawls
> all ProcessCoordinationUnits, and creates a map from pid to hosted URLs by
> looking at associated FrameCoordinationUnits.
>
> The interface for memory_instrumentation is modified slightly to include pid in
> ProcessMemoryDump to allow correlation between the memory dump and the URLs
> obtained from resource_coordinator. In a hypothetical future world where
> memory_instrumentation and resource_coordinator live in the same service, this
> can be removed.
>
> Bug:730783
>
> Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
> Change-Id: Ia1de1af692df4d7d08239db91c9fd14b71a15b70
> Reviewed-on: https://chromium-review.googlesource.com/578482
> Commit-Queue: Erik Chen <erikchen@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Lei Zhang <thestig@chromium.org>
> Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
> Reviewed-by: Oystein Eftevaag <oysteine@chromium.org>
> Reviewed-by: Primiano Tucci <primiano@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#490668}


Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I98d979303b095ee386228ac93d234fe8c8367b3e
Bug: 
TBR: thestig@chromium.org, oysteine@chromium.org, rkaplow@chromium.org, avi@chromium.org, primiano@chromium.org, dcheng@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/592539Reviewed-by: Erik Chen <erikchen@chromium.org>
Commit-Queue: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490713}

It should consult |domain_| to check nullity.

Bug: 748491
Change-Id: I99a37ecc145c873c0ab191d005a1f15b47aeed7a
Reviewed-on: https://chromium-review.googlesource.com/576015Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Takashi Toyoshima <toyoshim@chromium.org>
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490712}

1. Moves:
 - build/scripts/{ => core/css}/css_properties.py

2. Adds several __init__.py files so that core/css is considered
a package, which allows css_properties.py to be imported as a
module by other files,

3. Updates any references to this file with its new path.
4. Fix linter errors.

Bug: 732657
Change-Id: I2c15f79f7143c4d965252fbb7f6af4acdce719f0
Reviewed-on: https://chromium-review.googlesource.com/590828
Commit-Queue: Darren Shen <shend@chromium.org>
Reviewed-by: nainar <nainar@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490711}

Internal pages are deferred to load after other pages.

Bug: 730098
Change-Id: I3b8f2dbbb1d7e2e4d858750432597e882ef60b9f
Reviewed-on: https://chromium-review.googlesource.com/585241
Commit-Queue: Zhen Wang <zhenw@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490710}

Rather than concatenating we use GURL::Resolve() to get an absolute
URL based on the manifest URL and the url_template.

Change-Id: Id74041fcca6f34a898fc8c9794fc0965a1f4ccd8
Reviewed-on: https://chromium-review.googlesource.com/587704
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Reviewed-by: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490709}

The ImageLoader now std::moves the ImageFamily into the callback, rather
than holding onto a reference throughout the duration of the callback.

Fixes a data race in ScheduleCreatePlatformShortcut where the
ImageFamily could not be safely handed off to the other thread (because
the ImageLoader was still holding onto a reference).

Bug: 749342
Change-Id: I1452e47c892660e5fd06e27e3a0582240a5cbcec
Reviewed-on: https://chromium-review.googlesource.com/590338Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Matt Giuca <mgiuca@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490708}

context:
In crbug.com/490597, 2x image is used for HiDPI blur issue. Then there
is a CL "Migrate LauncherSearchResult to use SetBadgeIcon", 
https://codereview.chromium.org/1200543003, which I think it removes
the proper handling of the size of this 2x loading.

changes:
When custom icon is loaded, resize it to proper size.

HiDPI screenshot: https://screenshot.googleplex.com/2rWk8akUx99

Test: tested that it works fine now,
screenshot: https://screenshot.googleplex.com/u9BapUpenhu
Bug: 723021
Change-Id: If18a59e7aaeed48e9a0e88409f8672d057eb986a
Reviewed-on: https://chromium-review.googlesource.com/592415Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Yuki Awano <yawano@chromium.org>
Commit-Queue: Qiang(Joe) Xu <warx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490707}

Bug: 715695
Change-Id: I093262cfefeca6b70eb09c9d94764f4ed4f786c2
Reviewed-on: https://chromium-review.googlesource.com/583632
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Oliver Chang <ochang@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490706}

According to the specification, relative URL of base[href] should be resolved
with document's fallback base URL, not document's URL.

Bug: 739504
Change-Id: I811e8b14d7130873a4ffa6d45a094407f9e8a098
Reviewed-on: https://chromium-review.googlesource.com/590632Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#490705}