GitLab

Enable the RemoveNavigationHistory feature by default as it is launching
in M67.

Bug: 407074
Change-Id: I565db23d988e93b5c1d52a787dedb96be142792a
Reviewed-on: https://chromium-review.googlesource.com/1070150Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561047}

TBR=avi@chromium.org

Bug: 826257
Change-Id: I91ea969e3de8630365a115802ff6ed93901a1d00
Reviewed-on: https://chromium-review.googlesource.com/1066132
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561046}

This CL adds a mutation lock to WebStateList, to prevent observer
callbacks from changing or deleting the WSL while a change to the WSL
is in-flight.

Another approach would have been to make the WebStateList passed back to
observers a const WSL, but in many cases WSL observers already have
another pointer to the WSL which they use for mutations.

The lock implementation is straightforward, using a scoped lock object
to set/unset lock state on the WebStateList. This isn't threadsafe, but
WSL isn't, either. WSL will CHECK in the case of a double-lock, or of
destruction while locked.

Bug: 834263
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I3bf3512cec3297e7580cfc67c71bb12c05bc1cf5
Reviewed-on: https://chromium-review.googlesource.com/1065632
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561045}

The old count wouldn't count RTCPeerConnections allocated when returning
an error saying "too many PeerConnections", but those would be garbage
collected later.

This change fixes that issue.

Tested: Before the fix, a different test failed on the (new) DCHECK.
After the fix, the same test didn't fail.

Bug: 827064
Change-Id: I4765ce7043fd8a4e0c9c54dc1ec403e986ffed77
Reviewed-on: https://chromium-review.googlesource.com/1061176Reviewed-by: Henrik Boström <hbos@chromium.org>
Commit-Queue: Harald Alvestrand <hta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561044}

It appears that PluginPowerSaverBrowserTest.SmallerThanPlayIcon on Mac for Viz
has begun working again. This re-enables it.

TBR=kylechar@chromium.org
TEST=PluginPowerSaverBrowserTest.SmallerThanPlayIcon

Bug: 823276
Change-Id: I6333f40c20da0622cc8bfe45da486922471e8307
Reviewed-on: https://chromium-review.googlesource.com/1069656Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561043}

Adds placeholder text to the omnibox.

Bug: 821814
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I48efe7c94afd4ed929b2020f8c68e4031376fea8
Reviewed-on: https://chromium-review.googlesource.com/1064411
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561042}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/0e4815cd..6e211c1e

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I6884ceb3f067916ad5dd3426c6a93dc512985ba2
Reviewed-on: https://chromium-review.googlesource.com/1070107Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561041}

This moves the NameCallback from the fast path (trace descriptor) to a
slow path in GCInfo. It also allows for implementing naming for the rest
of the DOM.

Bug: chromium:841830
Change-Id: I61e8043855eb673ea173b92627e78df3e7eff0ab
Reviewed-on: https://chromium-review.googlesource.com/1069964
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Ulan Degenbaev <ulan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561040}

Defines the ".ForcedReenrollment" and ".InitialEnrollment" suffixes for
auto enrollment histograms.
AutoEnrollmentClient now supports setting the histogram suffix.

Also adds a new histogram
Enterprise.AutoEnrollmentBucketDownloadTime{.ForcedReenrollment,.InitialEnrollment),
which measures the time required for the
DeviceAutoEnrollment{Request,Response} exchange which actually transfers
the hash bucket.

Bug: 839353
Change-Id: I22c5a4df50a3e760e2301fc1763962cfa646b552
Reviewed-on: https://chromium-review.googlesource.com/1065879
Commit-Queue: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Igor <igorcov@chromium.org>
Reviewed-by: Lutz Justen <ljusten@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561039}

Make FrameScheduler ask PageScheduler for page-level metrics whenever it
needs them (also known as pull-approach).

We need to be careful to call PageScheduler::NotifyFrames each time when
a signal changes. However, this patch eliminated a bunch of incorrect
frame init when a page-level signal wasn't plumbed to a page.

Some signals are still saved in FrameScheduler for tracing purposes only
and renamed accordingly.

R=alexclarke@chromium.org,skyostil@chromium.org

Change-Id: I006713eac119b7619adf858beed3038b9914f274
Reviewed-on: https://chromium-review.googlesource.com/1069269
Commit-Queue: Alexander Timin <altimin@chromium.org>
Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561038}

Fixes bug where the larger MD Refresh 28dp inkdrops overflow into
browser-action insets. The prior code returned 24dp icon areas as it
assumed that MacOS was always using the Cocoa implementation. This now
effectively matches ToolbarButton sizes in views.

Bug: chromium:822069
Change-Id: I27a8b2c36fe0bba57ee698aae940b1b0c472f29f
Reviewed-on: https://chromium-review.googlesource.com/1068179
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Finnur Thorarinsson <finnur@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561037}

The new implementation removes some dead code (instead use DCHECKs) and
avoids unnecessary remappings when no tabbed windows exist (e.g.
multiple custom tabs exist without native data).

Bug: 843554
Change-Id: I595516158cc8e5aafb13346a962bf92f70ea6aad
Reviewed-on: https://chromium-review.googlesource.com/1068674
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561036}

Brings consistency to names and docs and simplifies the code a little and maybe slightly
better performance by compacting these fields everywhere.


Change-Id: Icbdf113a5c586adc1cca432f2e9fe3209ffe937f
Reviewed-on: https://chromium-review.googlesource.com/1059230Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Fergal Daly <fergal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561035}

BUG=762641
TBR=xiaoyinh@google.com

Change-Id: Ie7216f32ffbbb243ed36b06f2ee8d984f32ce76b
Reviewed-on: https://chromium-review.googlesource.com/1069479
Commit-Queue: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Reviewed-by: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561034}

Change-Id: Ib7e84f47bd70ba36e00de7c5e9f75c8e2005c2c6
Reviewed-on: https://chromium-review.googlesource.com/1068183
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Commit-Queue: Olga Sharonova <olka@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561033}

In CalculatePointAndNormalOnPath, compute the accumulated length of the
contours and compare against the passed in (now unmodified) |length|, to
increase the chances of comparing similarly computed length with each
other. |length| is often, directly or indirectly, derived from the
computed length of the Path (i.e using Path::length().)

Bug: 845375
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: Ibda61dd29921f41e0b294edde31ddb21ebbefd08
Reviewed-on: https://chromium-review.googlesource.com/1069071
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Reviewed-by: Florin Malita <fmalita@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561032}

Also updates an improper usage in a BUILD.gn file.

R=dpranke
BUG=None

Change-Id: I2d7d96f29165442e8642991a6db942b17b6c5012
Reviewed-on: https://chromium-review.googlesource.com/1069745Reviewed-by: David Turner <digit@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: David Turner <digit@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561031}

https://skia.googlesource.com/skia.git/+log/7257e22e43a5..4c77e817ab5d

$ git log 7257e22e4..4c77e817a --date=short --no-merges --format='%ad %ae %s'
2018-05-23 angle-skia-autoroll Roll third_party/externals/angle2/ 64ac5d9eb..be7f44fb5 (4 commits)

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=allanmac@chromium.org

Change-Id: Iac8b628bc6e0baaaf54a2075b2b29314e72572bd
Reviewed-on: https://chromium-review.googlesource.com/1069651Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#561030}

This interface contains methods that are needed in UI code. NewPasswordFormManager
will be inherited from it and will be passed to UI in the following CL.

Bug: 831123
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I5cfb51a48c46b891dd317cd2d01ff07109661c2f
Reviewed-on: https://chromium-review.googlesource.com/1042390
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561029}

I was writing a unittest where OpenCache is called with a MemoryLoader.
It kept crashing, and it seems to me that this was due to WriteIndex
running without callbacks. The CacheStorageCacheHandle was going out of
scope, and when a new one was being created by NotifyCacheCreated, there
was a crash due to some WeakPtr ref count internals.

This fix makes sure that the ref count is non-zero until all callbacks
consume the CacheStorageCacheHandle.

Bug: 838908
Change-Id: I610b2cad26d5608bacd18a4daa60edc976093fb4
Reviewed-on: https://chromium-review.googlesource.com/1069350Reviewed-by: Joshua Bell <jsbell@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561028}

This CL adds an effect to make the "New Incognito Tab" row of the tools
menu blink a selected state when the in product help requires it.

TBR=edchin@chromium.org

Bug: 829344
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia677ddb92ab3ae3a3ea9fc0622cc140b1dce4367
Reviewed-on: https://chromium-review.googlesource.com/1068182Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561027}

Upstream dir went away in https://github.com/w3c/web-platform-tests/pull/10870.

No-Try: true
Change-Id: I5e37b453e96feaa4c491283e331ea36c00bba922
Reviewed-on: https://chromium-review.googlesource.com/1068677Reviewed-by: Yoav Weiss <yoav@yoav.ws>
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561026}

Bug: 845075
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I58042d110a399d6c4d6879132292f9d75a99ad9a
Reviewed-on: https://chromium-review.googlesource.com/1070087Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561025}

IdentityProvider is deprecated as a general-purpose means of interacting
with the user's Google accounts. This CL ports ExtensionDownloader
away from it, having it instead take in the OAuth2TokenService directly
as well as a callback that returns the account to use with the webstore.
It also clarifies the lifetime relationship between ExtensionDownloader
and the ProfileOAuth2TokenService/SigninManager instances on which it
depends for authentication.

In the long term ExtensionDownloader will be ported to interact with the
Identity Service for its use case. This CL is an incremental step on the
path that also fills the more near-term goal of eliminating usages of
IdentityProvider.

Bug: 809966, 809927
Change-Id: I6b82cc318bd807d559e1701391ed3e02fcb489aa
Reviewed-on: https://chromium-review.googlesource.com/1051810
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561024}

NGConstraintSpaceBuilder is shortlived and we only have at most one of
them at any given time. Using bitfields just made the code bigger and
harder to maintain, and probably didn't save any memory at all.

Also make it STACK_ALLOCATED.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ia30cd77f3babbffec182443060e12940d4e8e2af
Reviewed-on: https://chromium-review.googlesource.com/1069347Reviewed-by: Christian Biesinger <cbiesinger@chromium.org>
Reviewed-by: Aleks Totic <atotic@chromium.org>
Reviewed-by: Ian Kilpatrick <ikilpatrick@chromium.org>
Commit-Queue: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561023}

This allows SharedWorkerScriptLoaderFactory to use non-NetworkService
factories like for chrome-extension://. It allows loading such URLs
for the main shared worker script. Remaining work is to add plumbing
to Blink so that importScripts() also works.

Bug: 839982
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo
Change-Id: I332ca96c8eef46771ca0ea7f290208642b2f82d0
Reviewed-on: https://chromium-review.googlesource.com/1068900Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561022}

These tests do pass on some bots, e.g. [1], and it's not clear why they
were being excluded. If there's a legitimate reason for them not to run
on Android, let's figure it out and get a bug filed.

Sheriffs: if this causes the tests to start failing on Android bots,
please file a bug with information about the error, put the exclusion
back and reference the bug.

Disable ProtocolParserTest.Reading on Android until it's fixed,
see the third bug.

(The CrOS failure was fixed a few months ago, see crbug.com/795645)

Bug: 842698, 795645, 845816

 [1] https://ci.chromium.org/buildbot/chromium.clang/ToTAndroid/3343

R=thakis@chromium.org

Change-Id: I4c683170508d431864880774543f942cf7446b88
Reviewed-on: https://chromium-review.googlesource.com/1068873
Commit-Queue: Hans Wennborg <hans@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561021}

Bug: 845105
Change-Id: Id7dfb50a2e4b1539dfd92c62a127b29c31e65c16
Reviewed-on: https://chromium-review.googlesource.com/1065778
Commit-Queue: Max Morin <maxmorin@chromium.org>
Reviewed-by: Olga Sharonova <olka@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561020}

https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/40aa75e44dda..f6223168d99e

$ git log 40aa75e44..f6223168d --date=short --no-merges --format='%ad %ae %s'
2018-05-22 nverne Add owner_id to message StartVmRequest
2018-05-21 brunokim Notify ARC on boot that supervision state changed.
2018-05-21 yusukes arc: Remove StartArcInstanceRequest message

Created with:
  roll-dep src/third_party/cros_system_api

Bug: 842561
Change-Id: Id86b391b25cfc46feb2af21e8fa84a75a660c976
Reviewed-on: https://chromium-review.googlesource.com/1070010Reviewed-by: Timothy Loh <timloh@chromium.org>
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561019}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/fdd7e08cde5d..8a1ffe0c9756

$ git log fdd7e08cd..8a1ffe0c9 --date=short --no-merges --format='%ad %ae %s'
2018-05-01 bpastene chrome-sdk: Add board and sdk version as gn args.

Created with:
  roll-dep src/third_party/chromite
BUG=chromium:732531


The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=chrome-os-gardeners@chromium.org

Change-Id: If7a8fea914f24d0f4719d2f44cba84d7a6896c96
Reviewed-on: https://chromium-review.googlesource.com/1069918
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#561018}

This reverts commit f1d5c4b5.

Reason for revert: Still breaking the unittest, not sure to know why it passed the CQ...

Original change's description:
> Re-reland "Add blink effect to the PopupMenu"
> 
> This CL adds an effect to make the "New Incognito Tab" row of the tools
> menu blink a selected state when the in product help requires it.
> 
> TBR=edchin@chromium.org
> 
> Bug: 829344
> Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
> Change-Id: Ic2e6fe63f5e2233f70ffaa0747c332778370132c
> Reviewed-on: https://chromium-review.googlesource.com/1068044
> Commit-Queue: Gauthier Ambard <gambard@chromium.org>
> Reviewed-by: Gauthier Ambard <gambard@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#561006}

TBR=edchin@chromium.org,gambard@chromium.org

Change-Id: Ie70a8341a896ad0270e1f5249cf0154eb0ba607f
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 829344
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Reviewed-on: https://chromium-review.googlesource.com/1070030Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561017}

This method is not used, and removing it is a nice clarification of
the use case of this interface.

TBR=jochen@chromium.org

Bug: 809927
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2ff8915f93612f029172f4b6478b7ea9eb04b9e6
Reviewed-on: https://chromium-review.googlesource.com/1046847
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561016}

We're considering removing some WebRequest API functionalities from
WebSocket to support Network Service. This CL adds histograms to
measure whether such features are actually used.

Bug: 721400
Change-Id: Ia975966291e80233b0c46d9c462c06d4766f8da9
Reviewed-on: https://chromium-review.googlesource.com/1059092
Commit-Queue: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Adam Rice <ricea@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561015}

We need to increment (and decrement) a counter on a per-document basis because call
stack can span across different documents.

BUG 776656, 845770

Change-Id: Ib9e89448217e7e335ba3c32c9775c9aa9c8f28cf
Reviewed-on: https://chromium-review.googlesource.com/1069959Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Hayato Ito <hayato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561014}

This CL restricts the AccountTracker public API to what's actually
used by GCMAccountTracker, its only client. This helps to clarify what
the purpose of AccountTracker is.

The CL also removes an AccountTracker unittest that was calling into a
now-private API. That test checks that a token revocation doesn't
cause any AccountTracker event to fire if the token was never made
available in the first place. That sequence of events (token revocation
being fired by OAuth2TokenService without the token first being made
available) doesn't reflect reality, so there is no purpose in testing
for it.

Change-Id: Ic3085897b87895faa6cf0c3d5d5d9f6520d0c808
Reviewed-on: https://chromium-review.googlesource.com/1046832
Commit-Queue: Colin Blundell <blundell@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561013}

now that it has been rolled out to 100% on Stable.

Bug: 814376
Change-Id: Ib643fcb4cea179ece647b75d07dfd3a92f935e47
Reviewed-on: https://chromium-review.googlesource.com/1069091Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Mugdha Lakhani <nator@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561012}

Since the edit view is not of LocationBarEditView class anymore, it
makes more sense to use the shorter "editView".

Bug: None
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2ab065846d88da69333a74c8cdc9001ccd61adf0
Reviewed-on: https://chromium-review.googlesource.com/1064511
Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561011}

Remove dead code from components/browsing_data.
Add test for output of HistoryCounter.

Bug: 843995
Change-Id: I44361907de445728f4783c2206857684414f8954
Reviewed-on: https://chromium-review.googlesource.com/1064117Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561010}

This CL adds some polish to the popup menu, increasing its max height
and swaping the BrowserActions and CollectionsActions items.

Bug: 845477
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ia7f05c29f0110bedb6f0ede7847ca3e39e420360
Reviewed-on: https://chromium-review.googlesource.com/1069148Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561009}

This patch adds contenteditable attribute to each test in
editing/selection/modify_move/move_* so that failure
doesn't show up in NG.

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I98d54f2a48d23b4186b0a779a97020021e7e972b
Reviewed-on: https://chromium-review.googlesource.com/1070016Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Commit-Queue: Yoichi Osato <yoichio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#561008}