- 23 Mar, 2015 40 commits
-
-
mcasas authored
FileVCD did not specify a Capture Api Type in Linux platforms, hence the check failed down the road. Original description: ----------------------------------------- This CL adds support for V4L2 MPLANE Capture Api. Only supported format is YUV420M triplanar. A new method is added to VideoCaptureDeviceClient, namely OnIncomingCapturedYuvData(...), which forces adding MOCKing here and there, and its own implementation. V4L2 MMAP API works via user mmap()ing a number of buffer allocated by V4L2 capture device. If those buffers are not correctly munmap()ed, bad things (c) happen. In light of this, the manual buffer lifetime management is changed to automatic one. Construction (mmap()ing) of those called BufferTracker is planarity specific (i.e. there's one such ctor in each of BufferTracker{S,M}Plane), while the dtor is generic and the same. ToT class diagram: +------------------------------------+ | VideoCaptureDeviceLinux | | +----------------------+| | <<ref>> -->| V4L2CaptureDelegate || | cnt | (struct Buffer) || | +----------------------+| +------------------------------------+ This CL class scheme: +--------------------------+ | VideoCaptureDeviceLinux | | | | <<ref_cnt>> ---+ | +----------------|---------+ +----------------v-----------+ v4l2_capture_delegate.{cc,h} | +-----------------------+ | | |V4L2CaptureDelegate | | | | (class BufferTracker)| | | +-----------------------+ | +-------^------------------^-+ | | +----|-------+ +--------|--+ v4l2_capture_delegate_multi_plane.{cc,h} | SPlane | | MPlane | | (BTSplane) | | (BTMPlane)| | | +-----------+ +------------+ v4l2_capture_delegate_single_plane.{cc,h} - VCDevice works on the premise that its calls into VCDevice::Client::OnIncomingWhatever() are synchronous. That assumption is respected here. - A bit of cleanup is done in OnIncomingCaptureData(), in what regards rotation/crop/odd sizes. A unit test is subsequently added. - VideoCaptureDeviceFactory labels the devices as Single or Multi Planar. That labeling capture_api_type() needs to ripple through a bunch of files, causing some otherwise uninteresting changes in the patchsets. BUG=441836 TEST= Compile and insmod vivid.ko into a kernel, with options for supporting MPLANE api (multiplanar=2) then capture using patched Chromium. Current vivid does _not_ support any common Mplane format, needs a patch: https://github.com/miguelao/linux/tree/adding_yu12_yv12_nv12_nv21___mplane_formats___with_mods_for_kernel_3_13 that needs to be compiled against ubuntu sources 3.13 etc. For even better coverage, use a normal WebCam and navigate to http://goo.gl/fUcIiP, then open both the MPlane camera mentioned in the previous paragraph and the "normal" webcam (this is,partially, how I try it). TBR= posciak@chromium.org, perkj@chromium.org, magjed@chromium.org, dalecurtis@chromium.org Review URL: https://codereview.chromium.org/1026073002 Cr-Commit-Position: refs/heads/master@{#321856}
-
sigbjornf authored
In testPostUnsupportedWebMessageToApp, avoid invoking postMessage() without any arguments. At least one is required for MessagePort.postMessage(). R=sgurun@chromium.org BUG=339441 Review URL: https://codereview.chromium.org/1003603004 Cr-Commit-Position: refs/heads/master@{#321855}
-
mukai authored
In case SetAllowCharacterBreak(true) is specified but width is not specified yet, nobody can stop gfx::ElideRectangleText() to wrap the text at very narrow width. But when the width is not specified, the ideal lines is expected (so that the label can be layouted based on the size). BUG=469559 R=sky@chromium.org TEST=the new test case covers Review URL: https://codereview.chromium.org/1029593004 Cr-Commit-Position: refs/heads/master@{#321854}
-
kenobi authored
Tags media files that were uploaded via cloud import with a custom Drive property. BUG=469774 Review URL: https://codereview.chromium.org/1032513002 Cr-Commit-Position: refs/heads/master@{#321853}
-
Mark Mentovai authored
d516689641d8 Update crashpad.doxy to Doxygen 1.8.9.1 1e12b471e376 Update mini_chromium to 6c49a5924dea c2502f45c9b2 doc: Add documentation-generating scripts to the Crashpad tree c052c97c7e2c Update crashpad_handler man page to document all options af9e78940e8c Allow man pages to link to each other 4bd97bb6db2a Document CrashpadInfo::set_simple_annotations() 6f4e6aacc885 Add crashpad_database_util and its man page 7fa250c9a238 Roll mini_chromium to 2f02dcc73536 8b4932e56034 Update mini_chromium to 31e989ac0b03 79ae055e50b1 Add Locking calls to file_io.h plus implementations and test 71deedee44d0 doxygen: Prevent the word Thread with a capital T from automatically linking to test::Thread. 0c704745dd65 Followup to https://codereview.chromium.org/1001673002/ 5d0a133ecd66 Tolerate weird cl_kernels modules BUG=386208,390217,415547,427611,466964 R=rsesek@chromium.org Review URL: https://codereview.chromium.org/1032533003 Cr-Commit-Position: refs/heads/master@{#321852}
-
hendrikw authored
This approach keeps the viewport size as a property of the layerimpl, doing this makes sure that the pending and active trees are in sync, because the only way for the size to migrate from the pending to active tree is via a push. Since being in sync is all the matters, we avoid having to reach in from outside of the layer and recreate tilings. BUG=458750 Review URL: https://codereview.chromium.org/1024633002 Cr-Commit-Position: refs/heads/master@{#321851}
-
apacible authored
BUG=464222 Review URL: https://codereview.chromium.org/1028503006 Cr-Commit-Position: refs/heads/master@{#321850}
-
earthdok authored
BUG=462636 R=glider@chromium.org TBR=thakis@chromium.org Review URL: https://codereview.chromium.org/1019573003 Cr-Commit-Position: refs/heads/master@{#321849}
-
eakuefner authored
Certain devices have ARM GPUs that report support of certain WebGL features but fail to actually support them, causing smoothness.maps to fail. This CL adds WebGLLowEndExpectations to skip tests like smoothness.maps on such devices. BUG=464731 R=dtu,kbr@chromium.org,sullivan Review URL: https://codereview.chromium.org/1030693002 Cr-Commit-Position: refs/heads/master@{#321848}
-
jsbell authored
We plan to expose the Cache Storage API independent of Service Worker. Tease the IPC message routing off of Service Worker and Embedded Worker, mirroring the other context-independent storage APIs. With this CL the browser side is independent but the renderer side entry point is still only available to the SW's context. Files have been left in the content/*/service_worker/ directories for now; follow-ups will shorten the names and move them to dedicated directories. BUG=439389 Review URL: https://codereview.chromium.org/992353003 Cr-Commit-Position: refs/heads/master@{#321847}
-
earthdok authored
With use_prebuilt_instrumented_libraries=1 in GYP_DEFINES, binaries are now unpacked from archive and placed into output dir. BUG=462636 TBR=glider@chromium.org, thakis@chromium.org Review URL: https://codereview.chromium.org/1003273006 Cr-Commit-Position: refs/heads/master@{#321846}
-
rouslan authored
BUG=458300 Review URL: https://codereview.chromium.org/1018393002 Cr-Commit-Position: refs/heads/master@{#321845}
-
sergeyu authored
TBR=jamiewalch@chromium.org Review URL: https://codereview.chromium.org/1019183005 Cr-Commit-Position: refs/heads/master@{#321844}
-
mattm authored
Enabling the tests was missed in https://codereview.chromium.org/10970023. BUG=127046 Review URL: https://codereview.chromium.org/1012263002 Cr-Commit-Position: refs/heads/master@{#321843}
-
kkimlabs authored
BUG=NONE Review URL: https://codereview.chromium.org/1022423003 Cr-Commit-Position: refs/heads/master@{#321842}
-
pcc authored
Specifically: - Supply -function-sections flag to the gold plugin when targeting ARM. Without this flag, LTO can produce a .text section that is larger than the maximum call displacement, preventing the linker from relocating calls. - Move the other gold plugin-specific flag to the same place, and add a Mac version. BUG=469376,469377 R=thakis@chromium.org Review URL: https://codereview.chromium.org/1024203004 Cr-Commit-Position: refs/heads/master@{#321841}
-
kundaji authored
The extension was changed to use preferences API rather than direct settings API. This cl updates the test to use the same API. Review URL: https://codereview.chromium.org/1026123002 Cr-Commit-Position: refs/heads/master@{#321840}
-
qyearsley authored
BUG= Review URL: https://codereview.chromium.org/1001033004 Cr-Commit-Position: refs/heads/master@{#321839}
-
benjhayden authored
CL for perf try job: https://codereview.chromium.org/1017683004 BUG=466988 Review URL: https://codereview.chromium.org/1018493004 Cr-Commit-Position: refs/heads/master@{#321838}
-
petewil authored
TBR=tommi@chromium.org BUG=469819 Review URL: https://codereview.chromium.org/1029663002 Cr-Commit-Position: refs/heads/master@{#321837}
-
reveman authored
This allows us to Join the threads when RenderThreadImpl is shutdown. BUG=468785 TEST=cc_unittests Review URL: https://codereview.chromium.org/999173004 Cr-Commit-Position: refs/heads/master@{#321836}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/bda107a..1f99128 TBR=dglazkov@chromium.org,alph@chromium.org Review URL: https://codereview.chromium.org/1025303004 Cr-Commit-Position: refs/heads/master@{#321835}
-
rdevlin.cronin authored
Adjust from using strict equality to >= and <= in order to account for the possibility of ratios and floats more safely. BUG=463905 Review URL: https://codereview.chromium.org/1025303003 Cr-Commit-Position: refs/heads/master@{#321834}
-
newt authored
We were using getDefaultSearchEngineIndex() as an index into the list of TemplateUrls returned by getLocalizedSearchEngines(), which is incorrect, but happens to work most of the time. BUG=469238 Review URL: https://codereview.chromium.org/1024213003 Cr-Commit-Position: refs/heads/master@{#321833}
-
pedrosimonetti authored
Revert of [Contextual Search] Add new assets for promo. (patchset #1 id:1 of https://codereview.chromium.org/978063002/) Reason for revert: We are going to replace multiple PNGs with a single SVG. Original issue's description: > [Contextual Search] Add new assets for promo. > > BUG=441476 > > Committed: https://crrev.com/a8e635214679c50b9010d925d083f8e54b13ba92 > Cr-Commit-Position: refs/heads/master@{#319287} TBR=donnd@chromium.org,dtrainor@chromium.org,mathp@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=441476 Review URL: https://codereview.chromium.org/1030703002 Cr-Commit-Position: refs/heads/master@{#321832}
-
spang authored
This was intended as a fix for some unusual absolute devices that report having mouse buttons (BTN_LEFT, BTN_MIDDLE, BTN_RIGHT), and aren't touchpads or tablets. They are sort of like touchscreens (user interacts directly with screen), and sort of like tablets (absolute cursor positioning), and sort of like mice (left/middle/right buttons). The fact that it wants mouse events rather than touch events makes it incompatible with the touchscreen code, though, so revert this for now. We'll have to do something else to support these "absolute mouse" devices. BUG=456999 TEST=events_unittests Review URL: https://codereview.chromium.org/1014853005 Cr-Commit-Position: refs/heads/master@{#321831}
-
knn authored
BUG=455646 Review URL: https://codereview.chromium.org/1005693005 Cr-Commit-Position: refs/heads/master@{#321830}
-
pcc authored
BUG=469377 R=thakis@chromium.org Review URL: https://codereview.chromium.org/1020363004 Cr-Commit-Position: refs/heads/master@{#321829}
-
miu authored
Revert of De-dupe copy requests for tab capture in DelegatedFrameHost. (patchset #7 id:160001 of https://codereview.chromium.org/986823002/) Reason for revert: Weird frame flickering effect in capture on some systems. https://crbug.com/469345 Original issue's description: > De-dupe copy requests for tab capture in DelegatedFrameHost. > > Tab capture requests copies/readbacks in response to every delegated > frame swap from the renderer. These are executed in a later step, when > the browser is composited. Unfortunately, the browser may not be > composited for every render frame. This means multiple copies/readbacks > may become enqueued, each of which is expensive, and will turn out to be > completely redundant as the results will be identical. This change > detects this scenario, and de-dupes by "aborting" the older frame > subscriber callback. > > BUG=464475 > > Committed: https://crrev.com/ddee0845cc298cbba6f9d8d6ff7fb9e06073f0e8 > Cr-Commit-Position: refs/heads/master@{#319998} TBR=danakj@chromium.org,ccameron@chromium.org,hubbe@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=464475 Review URL: https://codereview.chromium.org/1010803013 Cr-Commit-Position: refs/heads/master@{#321828}
-
vmpstr authored
This patch adds a combined_priority field to tracing which contains the up-to-date combined priority for the tile. I plan on removing the active/pending priorities from traces, since they typically do not provide any useful information (and are likely to be out of date). R=danakj, enne Review URL: https://codereview.chromium.org/1027563003 Cr-Commit-Position: refs/heads/master@{#321827}
-
aurimas authored
FirstRunUtil had mostly to do with Signing in (it is also used by SignInPromoDialog) so it should live under org.chromium.chrome.browser.signin. BUG=428842 Review URL: https://codereview.chromium.org/1000823002 Cr-Commit-Position: refs/heads/master@{#321826}
-
Adam Langley authored
BUG=468992 Cr-Commit-Position: refs/heads/master@{#321825}
-
thakis authored
BUG=none Review URL: https://codereview.chromium.org/1009603006 Cr-Commit-Position: refs/heads/master@{#321824}
-
mcasas authored
BUG=440843 Review URL: https://codereview.chromium.org/1015933004 Cr-Commit-Position: refs/heads/master@{#321823}
-
rdevlin.cronin authored
Add a field trial, currently disabled (i.e., 100% control group) for allowing users to report abuse on extension uninstallation. BUG=441377 Review URL: https://codereview.chromium.org/1025613006 Cr-Commit-Position: refs/heads/master@{#321822}
-
stapelberg authored
This fixes flickering when switching the X11 input focus between non-chrome windows, but having the pointer be above the chrome window (you need to use keyboard shortcuts to switch focus to trigger this). The reason for the flickering is that OnActiveWindowChanged() is called with state ACTIVE, even though the window was not activated. Before my change, the code called OnActiveWindowChanged() even for FocusIn/FocusOut events with mode==NotifyGrab, which is not intended. For details on the events, see: http://tronche.com/gui/x/xlib/events/input-focus/normal-and-grabbed.html Review URL: https://codereview.chromium.org/1027883003 Cr-Commit-Position: refs/heads/master@{#321821}
-
davidben authored
This removes the ability to pass in a custom CookieStore to a URLRequest. It's a small change to net/url_request which then balloons to everything in the project that ever makes a URLRequest. This reverts the rest of https://codereview.chromium.org/188693003 (and then does a whole lot more because URLRequest constructors were unified recently to always require passing in the fourth argument). BUG=457344 Review URL: https://codereview.chromium.org/1003953008 Cr-Commit-Position: refs/heads/master@{#321820}
-
mikecase authored
The default Robolectric testrunner has some behaviors we want to override. By default the Robolectric testrunner will download the Robolectric runtime dependencies from the Maven central reposoitory. In addition, Robolectric won't run at all if the API level in the AndroidManifest isn't officially supported by Robolectric which isn't what we want. BUG=448030 Review URL: https://codereview.chromium.org/942083003 Cr-Commit-Position: refs/heads/master@{#321819}
-
tkent authored
PagePopups used for <input type=date>, <datalist>, etc. should have same input grab behavior as <select> popup. Also, <select> popup is going to be switched to blink::WebPopupTypePage. BUG=346582 Review URL: https://codereview.chromium.org/1028893002 Cr-Commit-Position: refs/heads/master@{#321818}
-
mseaborn authored
This pulls in the following Native Client changes: fc4d498: (dpranke@chromium.org) Fix a stray reference to ${os} in build/toolchain/nacl/BUILD.gn. 5076f66: (mtrofin@chromium.org) Use the newly introduced CMake LLVM option, LLVM_INSTALL_UTILS, to install binaries such as FileCheck, as part of the install target. 97cf946: (hidehiko@chromium.org) Non-SFI mode: Implement clone() syscall wrapper. 8171867: (jvoung@chromium.org) PNaCl: Update Subzero revision in pnacl/COMPONENT_REVISIONS 9e28d08: (jfb@chromium.org) PNaCl: Update LLVM and Clang revisions in pnacl/COMPONENT_REVISIONS cf674f2: (petarj@mips.com) Do not print nan sign for results with undefined nan sign 75c402b: (shinyak@chromium.org) Check object file size before archiving. cc3597c: (hidehiko@chromium.org) Non-SFI mode: Implement {get,set}rlimit() syscall wrappers. Changes: https://chromium.googlesource.com/native_client/src/native_client/+log/cc78fa093218f9a9a5e576002e197e17da379023..cc3597c9c13978079ef85a31d78dc4bf7f18000c BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng,linux_arm_compile,linux_nacl_sdk_build Review URL: https://codereview.chromium.org/1027283002 Cr-Commit-Position: refs/heads/master@{#321817}
-