- 15 Dec, 2017 40 commits
-
-
Ian Vollick authored
Fixes a mistyped number. Bug: None Change-Id: I770e954de312774a05e96ceb7735895d8a1df9c6 Reviewed-on: https://chromium-review.googlesource.com/830889Reviewed-by:
Yash Malik <ymalik@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#524492}
-
David Benjamin authored
To parse some Android structure, CBS will need to grow support for tag numbers above 31. In preparation for that, BoringSSL will need to make the CBS/CBB tag representation not quite match the DER encoded form. See https://boringssl-review.googlesource.com/c/boringssl/+/23304. https://chromium-review.googlesource.com/783254 attempted to prepare for this by leaving net::der::Tag as-is and translating between the two tag representations. But the NormalizeName code takes a Tag and passes it into a CBB function. To avoid needlessly translating things there, this CL takes the opposite tack. It instead defines that net::der::Tag matches the BoringSSL representation. This fixes the NormalizeName test with the BoringSSL change re-landed. It does mean we'll need to replace ParserTest.TagNumbersAboveThirtyUnsupported with ParserTest.TagNumbersAboveThirtySupported concurrently with the BoringSSL roll, but we can manage that one. This CL should be no-op as-is, but will no longer be a no-op when the BoringSSL change is relanded. Bug: Change-Id: I4e8fc1607eb3691733f998a24648f330e65137e6 Reviewed-on: https://chromium-review.googlesource.com/828385Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#524491}
-
Jian Li authored
Bug: 758690 Tbr: ryansturm@chromium.org Change-Id: Ie132c4806e7b59b00e0bc5e0adb72e6631ed3cf9 Reviewed-on: https://chromium-review.googlesource.com/817526 Commit-Queue: Jian Li <jianli@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#524490}
-
Yash Malik authored
Before this CL, target_element in UiInputManager would also be the input caputring element. In this CL, the target_element is always the element behind the ray. This makes the code easier to read and simplifies hover events. The only functional change in this CL is that we send hover events to non-input caputring elements. For example, if we have element 1 and element 2, clicking on element 1 and moving to element 2 will send HoverLeave to element 1 and HoverEnter to element 2. This CL also removed the unused ButtonState::CLICKED Bug: Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I1be4a8f3cf593e6341df0540efcfd0bc5456f217 Reviewed-on: https://chromium-review.googlesource.com/830886Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#524489}
-
James Cook authored
We rely on the implicit copy constructors in a large number of places in the code. However, the existance of ui::Event::Clone() makes people think they have to use that method to copy events -- they don't, if they have an event with a known type. Write out the copy constructors to make that clear. Bug: none Test: existing events_unittests, other existing UI unittests Change-Id: I18cd94bdc1cdec9d91c2987da3dd28356edd8568 Reviewed-on: https://chromium-review.googlesource.com/830674Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#524488}
-
Mehran Mahmoudi authored
This CL fixes an issue that caused the In-Prodcut Help UI for Contextual Search to appear at the bottom of the screen, over the Contextual Search panel in multiwindow mode. Bug: 794732 Change-Id: Ie9e83fe51621cd477502c851899dca7d68c333b0 Reviewed-on: https://chromium-review.googlesource.com/830809Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#524487}
-
Ilya Sherman authored
05dee13e844d fuchsia: Add QEMU and helper script to start/stop instance 169731495268 fuchsia: Make Filesystem.RemoveFile, .RemoveDirectory pass 7662fb087f6c Roll mini_chromium a12ed4a6..20182dd2 344acadfdd36 [Cleanup] Rename UMA_HISTOGRAM_SPARSE_SLOWLY to base::UmaHistogramSparse() 10ff56eee5da Include the appropriate header for BUILD_FUSCHIA R=mark@chromium.org Bug: 773850 Change-Id: I649547ba3809ab836ea5d9da9fd77c9daaeff669 Reviewed-on: https://chromium-review.googlesource.com/830811Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#524486}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/f2d71764a1ec..b5e23eeaae74 $ git log f2d71764a..b5e23eeaa --date=short --no-merges --format='%ad %ae %s' 2017-12-15 rnephew Revert "[Telemetry] Add assertion that story names do not contain spaces." 2017-12-15 rnephew [Telemetry] Add assertion that story names do not contain spaces. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I2cd4c227158d3dadffa0f78eeeb48e791682eff5 Reviewed-on: https://chromium-review.googlesource.com/830813 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524485}
-
Tommy C. Li authored
Previously, there was a duplicate observer that was (apparently?) okay because spinning the current message loop was enough to load th history backend. The TaskScheduler migration requires us to make a different call to ensure that the history backend is loaded. This CL also removes the member observer, because running the TaskScheduler until idle should be sufficient to assert that the history backend has been loaded. Bug: 751031 Change-Id: Iecacecddc3a50be3d54be64fe520fad757aa0275 Reviewed-on: https://chromium-review.googlesource.com/825642Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#524484}
-
David Bokan authored
It looks like between when I reverted my patch in https://crrev.com/777040 and when I originally landed it there's been some changes that meant my revert broke hash navigation. I'm not sure how this worked before but it looks like currently the navigation relies on the fact that at the end of a frame's layout, we called into RootScrollerController::DidUpdateLayout which would recalculate the root scroller and then synchronously recompute style and layout using Document::UpdateStyleAndLayout(). When a page is finished parsing it tries to scroll to the hash in FrameLoader::FinishedParsing. However, if the page is blocked from rendering this will be deferred since we can't layout yet. Normally, when the load event is fired, we'd call Document::ImplicitClose which calls LocalFrameView::UpdateLayout. This causes the scroll to the hash via the above indirect call to Document::UpdateStyleAndLayout but my revert above removed this call. This CL fixes the issue by directly trying to scroll to the hash in ImplicitClose. Bug: 788486 Change-Id: I67f78372380f043bf88fda036bf7c263b17fbca0 Reviewed-on: https://chromium-review.googlesource.com/809093 Commit-Queue: David Bokan <bokan@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#524483}
-
Erik Luo authored
The EmulationAgent can clear the existing geolocation override. In the original implementation, it resets the geoposition_override_ https://codereview.chromium.org/603323004 During a later refactoring, it looks like this line was dropped which led to newly created impls that reused the old override even after it should have been cleared. https://codereview.chromium.org/628773003 Bug: 639344 Change-Id: I0a76aa60b70265fc604fc87d68566ff815878433 Reviewed-on: https://chromium-review.googlesource.com/823276 Commit-Queue: Erik Luo <luoe@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#524482}
-
Bruce Dawson authored
Due to bugs in the Fall Creators Update SDK we can't build Chromium with clang with that SDK. However the debuggers package (windbg and friends) in the "spring" Creators Update SDK can't handle fastlink PDBs reliably. So, this repackages the previous toolchain with the debuggers package from the Fall Creators Update SDK. This makes no difference to the builds, although it does mean that an updated copy of dbghelp.dll will be copied to the build directories. I created this package by manually copying over the new debuggers directory and then running: python package_from_installed.py --repackage=... Bug: 773476 Change-Id: I05b37d518e3700e125eee5bbcb2cbf885d01afc5 Reviewed-on: https://chromium-review.googlesource.com/827629Reviewed-by:
Scott Graham <scottmg@chromium.org> Commit-Queue: Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#524481}
-
Ryan Ki Sing Chung authored
ECDHE ciphers would be required since decrypt is not available. Bug: 794762 Change-Id: Ie855f1026460d1f2ffa62dcdec6870c5525cdd86 Reviewed-on: https://chromium-review.googlesource.com/826324 Commit-Queue: Ryan Chung <ryanchung@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#524480}
-
Matt Reynolds authored
BUG=760104 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I09ef256cc8fd72827800b68925c8d95dc8586324 Reviewed-on: https://chromium-review.googlesource.com/795359 Commit-Queue: Matt Reynolds <mattreynolds@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#524479}
-
Chris Hamilton authored
BUG=727353 Change-Id: I8402fcf4a28753ed75a9edabd7ee1478985312df Reviewed-on: https://chromium-review.googlesource.com/791570 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#524478}
-
Reilly Grant authored
These two session cookies-related tests are flaky when the Network Service is enabled. Bug: 795417 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Idf1195bf51f15851ada6349426af8939a720056a No-Presubmit: true No-Try: true Tbr: jam@chromium.org Reviewed-on: https://chromium-review.googlesource.com/830969Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#524477}
-
Dmitry Gozman authored
Blink can now do it directly, which unblocks moving DevToolsAgent to blink. Bug: 776009 Change-Id: I4b1466005b10dd9969040803a9517e6dff18dc38 Reviewed-on: https://chromium-review.googlesource.com/827551Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#524476}
-
Robert Ma authored
This reverts commit 83f34380. Reason for revert: WOOHOO! It worked as intended :) Original change's description: > TEST: file a bug to staging right after wpt-import starts > > This is a live end-to-end test to ensure Monorail integration and > credential deployment work correctly on bots. This CL will be reverted > once a bug is successfully filed to monorail-staging.appspot.com. > > Bug: 765334, 794715 > Change-Id: I3b9d94116286e8d5c1daf24961af1de5d8b5e63e > Reviewed-on: https://chromium-review.googlesource.com/830193 > Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> > Commit-Queue: Robert Ma <robertma@chromium.org> > Cr-Commit-Position: refs/heads/master@{#524470} TBR=qyearsley@chromium.org,robertma@chromium.org Change-Id: I19ffc37c8d71f31ec4e8ed56066b0d896b0bb301 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 765334, 794715 Reviewed-on: https://chromium-review.googlesource.com/831006Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#524475}
-
Tim Brown authored
Bug: 768027 Change-Id: Idf3e65c743e79b27e189a3ce4cb7f7e675a9fd03 Reviewed-on: https://chromium-review.googlesource.com/830812Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Tim Brown <timbrown@chromium.org> Cr-Commit-Position: refs/heads/master@{#524474}
-
rbpotter authored
Listen for destination events and update UI when destination changes. Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I1c9aff4f5e6fd1d856727064ab76058c30b12125 Reviewed-on: https://chromium-review.googlesource.com/823579 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#524473}
-
danakj authored
The SoftwareRenderer doesn't need to share those bitmaps out of process so it can just make regular SkBitmaps and use those, without depending on ResourceProvider, ResourceIds, SharedBitmapManager, etc to get that done. R=kylechar@chromium.org Bug: 730660, 738190 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: Ie49389776441efe3faddb7ecf364126e5cc44170 Reviewed-on: https://chromium-review.googlesource.com/828081 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#524472}
-
Jonathan authored
We want to make sure that --enable-viz does not break telemetry, so that we can properly collect metrics. This change adds both to the Linux Viz FYI bot. A few known failures are being skipped while we investigate them. TEST=telemetry_perf_unittests telemetry_unittests Bug: 778749 Change-Id: I4862bfd12ca255265d0e67406278cbd41202ac85 Reviewed-on: https://chromium-review.googlesource.com/827031Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#524471}
-
Robert Ma authored
This is a live end-to-end test to ensure Monorail integration and credential deployment work correctly on bots. This CL will be reverted once a bug is successfully filed to monorail-staging.appspot.com. Bug: 765334, 794715 Change-Id: I3b9d94116286e8d5c1daf24961af1de5d8b5e63e Reviewed-on: https://chromium-review.googlesource.com/830193Reviewed-by:
Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#524470}
-
Eero Häkkinen authored
This CL is part of VectorMath code clean up series: [1/4] this CL [2/4] https://chromium-review.googlesource.com/c/824047 [3/4] https://chromium-review.googlesource.com/c/824048 [4/4] https://chromium-review.googlesource.com/c/824049 Bug: 778262 Change-Id: I8d1d5db93b20e2ba14781151efb0ba174c97687d Reviewed-on: https://chromium-review.googlesource.com/824046Reviewed-by:
Raymond Toy <rtoy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com> Cr-Commit-Position: refs/heads/master@{#524469}
-
Xiyuan Xia authored
- Remove code that shows connected Drive apps in launcher; - Update AppListSyncableService to remove sync data for those apps; Bug: 794724 Change-Id: I4e16df1d1e7dc216114174eae21cfac1b0eec189 Reviewed-on: https://chromium-review.googlesource.com/828026Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#524468}
-
David Benjamin authored
A recent BoringSSL change broke this. Add a regression test for it before I try to make the change again. Bug: 789802 Change-Id: Ibe021424fc6b36b2ef71d91b30f523a2cfae1482 Reviewed-on: https://chromium-review.googlesource.com/828381 Commit-Queue: Matt Mueller <mattm@chromium.org> Reviewed-by:
Matt Mueller <mattm@chromium.org> Cr-Commit-Position: refs/heads/master@{#524467}
-
Devlin Cronin authored
An event listener could destroy the context when it's notified (e.g., if it does window.close()). We need to account for this case. Check after each listener is executed whether the context is still valid. Add native bindings-specific unittests and a JS/Native bindings browsertest. Bug: 653596 Change-Id: I47e789800ca90935457781695d3e8c3de7aae317 Reviewed-on: https://chromium-review.googlesource.com/818528Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#524466}
-
Kenneth Russell authored
Raymond is the primary OWNER of platform/audio and needs to be able to approve CLs which change the top-level BUILD.gn. BUG=778262 Change-Id: I9f3b7478e95b34187669371d894c863ff86936f2 Reviewed-on: https://chromium-review.googlesource.com/827609Reviewed-by:
Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#524465}
-
Tim Brown authored
This is after having removed dconf and gconf. Bug: 768027 Change-Id: I8963b75da9b20688b698b658d7d5039fa59ac959 Reviewed-on: https://chromium-review.googlesource.com/827616Reviewed-by:
Evgeniy Stepanov <eugenis@chromium.org> Commit-Queue: Tim Brown <timbrown@chromium.org> Cr-Commit-Position: refs/heads/master@{#524464}
-
Victor Costan authored
This reduces the cognitive load of reasoning about IDBValue ownership, which makes it easier to add complexity to the IndexedDB value wrapping logic. Bug: 719007 Change-Id: I3afe209a4d1d58440fce424bd263e4888ebde503 Reviewed-on: https://chromium-review.googlesource.com/828531Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#524463}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/846f7660e7d5..f2d71764a1ec $ git log 846f7660e..f2d71764a --date=short --no-merges --format='%ad %ae %s' 2017-12-15 simonhatch Dashboard - Increase timeout to 15s for all requests to monorail. 2017-12-15 rnephew [Telemetry] Make it so story expectations do not require a reason. Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I5cc762556c6a00af530512a3133520bbbd9b905c Reviewed-on: https://chromium-review.googlesource.com/830175 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524462}
-
Jonathan Metzman authored
Bug: Change-Id: Ica0408b417f3ac56c1e90989a28d998735e7fc04 Reviewed-on: https://chromium-review.googlesource.com/830806Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#524461}
-
Dmitry Gozman authored
This is to test grounds with UI.Fragment and custom elements v1. Bug: none Change-Id: I62c3867ee8da84c867d432e49bd049757ea502fa Reviewed-on: https://chromium-review.googlesource.com/826306 Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Lushnikov <lushnikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#524460}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/d92073b75627..667fa571db51 $ git log d92073b75..667fa571d --date=short --no-merges --format='%ad %ae %s' 2017-12-15 hnakashima Validate base color space of Indexed color spaces. 2017-12-15 hnakashima Validate shading pattern's ColorSpace. It cannot be a Pattern CS. Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I85043b9fd2a697d9e39521560c165cdd1e510b2f Reviewed-on: https://chromium-review.googlesource.com/829987 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#524459}
-
Xianzhu Wang authored
Extend PaintLayerPainter::AdjustForPaintOffsetTranslation() which adjusted paint_dirty_rect based on PaintOffsetTranslation to AdjustForPaintProperties() which (if needed) maps paint_dirty_rect from the root layer to the current layer dealing with more cases: - The existing PaintOffsetTranslation handling; - Fixed layer whose transform state may escape the root layer's transform state; - Scroll offsets. This fixes most of the failures of spv175+rls. Bug: 793675 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I400c9da7d215132247c1b4e631be692070fdb655 Reviewed-on: https://chromium-review.googlesource.com/827671 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#524458}
-
Deepti Gandluri authored
When SetProtection is used for wasm memory, it can fail if not enough memory is available when growing. Fix to return the result of system calls. As coordination in needed between V8/Gin - this change adds a new SetProtection method with a boolean return, subsequent changes in V8/Chromium will swap this out to be the default SetProtection method. Bug: 775047 Change-Id: I9f55d156c8317be8c012de60940d1698db439c86 Reviewed-on: https://chromium-review.googlesource.com/753429Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Adam Klein <adamk@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#524457}
-
Brett Wilson authored
Transitions another set of callers to use the new unique_ptr version of SetLayoutManager. The only nontrivial changes are in tri_view.cc where the existing initialization did not with well with the new pattern. The constants in PasswordGenerationPopupController were given storage because not having storage was causing errors passing through std::make_unique which passes by &&. Change-Id: Id51f1a888b7148169629aabae523530fb03b3890 Reviewed-on: https://chromium-review.googlesource.com/827668 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#524456}
-
Aleks Totic authored
NGOutOfFlowLayoutPart used to have a single containing block, and it was defined by a NGOOFLP member variables. With inline containing blocks, we have multiple containing blocks, defined by ContainingBlockInfo. This CL moves definition of default containing block out of multiple member variables into single ContainingBlockInfo. Bug: 635619 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I69dd499cb69c7e6fc56971e85882cd7e6241f99c Reviewed-on: https://chromium-review.googlesource.com/829888Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#524455}
-
rnephew authored
Bug: 781409 Change-Id: I70d28e9f43a4747f19666fbfa9f3bb18ac1d22d7 Reviewed-on: https://chromium-review.googlesource.com/830256Reviewed-by:
Ned Nguyen <nednguyen@google.com> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Commit-Queue: rnephew <rnephew@chromium.org> Cr-Commit-Position: refs/heads/master@{#524454}
-
Jonathan Metzman authored
https://chromium.googlesource.com/chromium/llvm-project/compiler-rt/lib/fuzzer.git/+log/a00e8070bea6..ba2c1cd6f87a $ git log a00e8070b..ba2c1cd6f --date=short --no-merges --format='%ad %ae %s' 2017-12-13 morehouse [libFuzzer] Add dummy call of LLVMFuzzerTestOneInput to afl_driver. 2017-12-12 kcc [libFuzzer] change the strategy for -experimental_len_control to grow max_len slower 2017-12-09 kcc [libFuzzer] even less aggressive step function for stack depth. Also don't use asan in one test to speed it up 2017-12-09 kcc [libFuzzer] make the stack depth signal less agressive, otherwise we are sometimes exploding the corpus size. This still needs more analysis and tuning 2017-12-08 morehouse [libFuzzer] Add support for Fuchsia OS. 2017-12-08 kcc [libFuzzer] honor -use_counters, sligntly change the meaning of -experimental_len_control, call UpdateFeatureFrequency only if instructed by the flag 2017-12-06 kcc [libFuzzer] Decrease stack usage in unit tests 2017-12-06 kcc [libFuzzer] fix a minor regression in printing 2017-12-05 morehouse [libFuzzer] Make redirects happen in proper sequence. 2017-12-04 morehouse [libFuzzer] Remove const from ignoreRemainingArgs return value. 2017-12-04 morehouse [libFuzzer] Remove FuzzerCommand.cpp from build sources. 2017-12-04 morehouse [libFuzzer] Encapsulate commands in a class. 2017-12-01 kcc [libFuzzer] add a flag -malloc_limit_mb 2017-12-01 kcc [libFuzzer] remove stale flags; NFC 2017-12-01 kcc [libFuzzer] add an experimental search heuristic flag -reduce_depth 2017-11-28 delcypher [LibFuzzer] Improve comments on `CounterToFeature()` function. 2017-11-17 vitalybuka [fuzzer] Initialize PcDescr buffer before calling __sanitizer_symbolize_pc 2017-11-15 kcc libfuzzer: Fix file listing on some filesystems 2017-11-15 kcc [libFuzzer] respect max_len during merge Created with: roll-dep src/third_party/libFuzzer/src Bug: 539572 Change-Id: I8dd43d49dea0441595e9e04f1ddb61950333f896 Reviewed-on: https://chromium-review.googlesource.com/828408 Commit-Queue: Abhishek Arya <inferno@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Cr-Commit-Position: refs/heads/master@{#524453}
-