GitLab

BUG=none

Review-Url: https://codereview.chromium.org/2609893003
Cr-Commit-Position: refs/heads/master@{#441447}

https://pdfium.googlesource.com/pdfium.git/+log/fff400a5df03..6745f96fab41

$ git log fff400a5d..6745f96fa --date=short --no-merges --format='%ad %ae %s'
2017-01-04 tsepez Remove CFX_ArrayTemplate, use unique_ptr in fpdfsdk/pdfwindow

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

TBR=dsinclair@chromium.org

Review-Url: https://codereview.chromium.org/2612833002
Cr-Commit-Position: refs/heads/master@{#441446}

This mode is always enabled now, so we can remove the code for handling
when it is disabled.  This CL starts with the easy cases in tests.

BUG=236848
TEST=Tests still pass.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2616673002
Cr-Commit-Position: refs/heads/master@{#441445}

BUG=579229

Review-Url: https://codereview.chromium.org/2602553003
Cr-Commit-Position: refs/heads/master@{#441444}

Adds a java Surface to render into for devices that don't support async reprojection.

BUG=674233

Review-Url: https://codereview.chromium.org/2616583002
Cr-Commit-Position: refs/heads/master@{#441443}

Test converted to use testharness and new Audit.

The expected result file is also removed.

BUG=675987
TEST=realtimeanalyser-fft-sizing.html

Review-Url: https://codereview.chromium.org/2603483002
Cr-Commit-Position: refs/heads/master@{#441442}

with elevation values instead.

This is necessary to allow different windows of the same UI or WM window
type to specify different shadow appearances. This also makes more
sense in that active windows aren't the only ones to get big shadows.

Concretely, this is a requirement for updating Toast shadows.

BUG=608852,676223
TBR=reveman@chromium.org

Review-Url: https://codereview.chromium.org/2596743002
Cr-Commit-Position: refs/heads/master@{#441441}

1. Remove TimePeriod-related methods from BDR and its tests. Explanation:

TimePeriod represents the deletion options provided in the Chrome UI, and
is used in communication between Chrome UI and BDR, and thus there is no
reason for content/ to know about it. In fact, if BDR was moved to content/
while still containing TimePeriod-related methods, we would have to introduce
a new build target in components/ to make TimePeriod usable in all three of
chrome/, ios/, and content/.

2. Remove the TimeRange class from BDR entirely. Explanation:

TimeRange is a class inside BDR which would move to content/ together with it.
The UI needs a way to convert TimePeriod to TimeRange. Such a conversion cannot
live in content/ (which doesn't know about TimePeriod) nor components/ (which
wouldn't know about TimeRange). It could be detached from BDR to a separate
file in chrome/.

However, the update cost of detaching it to a separate file is the same as
breaking it into a pair of base::Time arguments. Here are reasons why the latter
is better:
-> It reduces the complexity of keeping two confusingly similar TimePeriod and
TimeRange classes
-> Consistency - basically all data storage backends, and also the BDRDelegate,
have an interface with two base::Time arguments rather than base::TimeRange
-> It can be argued that this definition does not logically belong to BDR;
if anyone, it should be base/time/ who defines a class representing
a base::Time interval class

3. Replace Profile with BrowserContext inside BDR (as that's the content/
equivalent).

4. Split the REMOVE_DOWNLOADS section to two parts. The first part (download
history deletion) stays in content/, the second part (download path reset) moves
to the embedder.

5. Add a comment explaining that the |may_delete_history| variable must be honored
in content/ (while deleting download history), but must be provided by the embedder
(from policy or supervised users) through ContentBrowserClient. This is not possible
to fix while BDR is still in chrome/, as chrome/ cannot depend on
ChromeContentBrowserClient.

TBR=jochen@chromium.org
BUG=668114

Review-Url: https://codereview.chromium.org/2578723002
Cr-Commit-Position: refs/heads/master@{#441440}

The positioning of the menu promo in MD History was accidentally broken
in crrev.com/439710 when the layout of the left section of the toolbar
was changed.

BUG=677902
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2609933003
Cr-Commit-Position: refs/heads/master@{#441439}

Revert of Use TaskScheduler instead of WorkerPool in gbm_surfaceless.cc. (patchset #2 id:20001 of https://codereview.chromium.org/2609733002/ )

Reason for revert:
Causes the UI to crash on peach_pit and multiple HWTest failures on the PFQ and the informational builder. See BUG=678296.

Original issue's description:
> Use TaskScheduler instead of WorkerPool in gbm_surfaceless.cc.
>
> The following traits are used:
>
> Priority: Inherited (default)
>   The priority is inherited from the calling context (i.e. TaskTraits
>   are initialized with the priority of the current task).
>
> Shutdown behavior: CONTINUE_ON_SHUTDOWN
>   Tasks posted with this mode which have not started executing before
>   shutdown is initiated will never run. Tasks with this mode running at
>   shutdown will be ignored (the worker will not be joined).
>
>   Note: Tasks that were previously posted to base::WorkerPool should
>   use this shutdown behavior because this is how base::WorkerPool
>   handles all its tasks.
>
> May Block:
>   Tasks posted with MayBlock() may block. This includes but is not
>   limited to tasks that wait on synchronous file I/O operations:
>   read or write a file from disk, interact with a pipe or a socket,
>   rename or delete a file, enumerate files in a directory, etc. This
>   trait isn't required for the mere use of locks.
>
> BUG=659191
>
> Committed: https://crrev.com/0127fd25bd985f1f5f87c0a7c060d3159142086a
> Cr-Commit-Position: refs/heads/master@{#441139}

TBR=dnicoara@chromium.org,fdoray@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=659191

Review-Url: https://codereview.chromium.org/2612853002
Cr-Commit-Position: refs/heads/master@{#441438}

Also, run clang-format to fix up styling.

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2592143002
Cr-Commit-Position: refs/heads/master@{#441437}

The following traits are used:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

  Note: Tasks that were previously posted to base::WorkerPool should
  use this shutdown behavior because this is how base::WorkerPool
  handles all its tasks.

May Block:
  Tasks posted with MayBlock() may block. This includes but is not
  limited to tasks that wait on synchronous file I/O operations:
  read or write a file from disk, interact with a pipe or a socket,
  rename or delete a file, enumerate files in a directory, etc. This
  trait isn't required for the mere use of locks.

BUG=659191

Review-Url: https://codereview.chromium.org/2603163002
Cr-Commit-Position: refs/heads/master@{#441436}

BUG=554289

Review-Url: https://codereview.chromium.org/2606293002
Cr-Commit-Position: refs/heads/master@{#441435}

BUG= internal b/32244773

Review-Url: https://codereview.chromium.org/2429963002
Cr-Commit-Position: refs/heads/master@{#441434}

All current Qualcomm GPUs are affected by a bug where program binaries
don't cache transform feedback varyings. Work around this by avoiding
the use of the in-memory and disk program caches when the transform
feedback varyings are non-empty.

BUG=658074
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2615573002
Cr-Commit-Position: refs/heads/master@{#441433}

The copy constructor breaks DisplayItemClient aliveness checking.
We could fix the copy constructor but it looks better not to support
the copy constructor.
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2611923002
Cr-Commit-Position: refs/heads/master@{#441432}

BUG=678276

Review-Url: https://codereview.chromium.org/2610923002
Cr-Commit-Position: refs/heads/master@{#441431}

BUG=636977

Review-Url: https://codereview.chromium.org/2610803003
Cr-Commit-Position: refs/heads/master@{#441430}

This CL adds a few more methods that cause name collisions when Blink
is rewritten to match Chromium style. In addition, it removes the hash
method from the blacklist.

BUG=582312, 677166

Review-Url: https://codereview.chromium.org/2608423003
Cr-Commit-Position: refs/heads/master@{#441429}

The following traits are used:

Priority: Inherited (default)
  The priority is inherited from the calling context (i.e. TaskTraits
  are initialized with the priority of the current task).

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

  Note: Tasks that were previously posted to base::WorkerPool should
  use this shutdown behavior because this is how base::WorkerPool
  handles all its tasks.

May Block:
  Tasks posted with MayBlock() may block. This includes but is not
  limited to tasks that wait on synchronous file I/O operations:
  read or write a file from disk, interact with a pipe or a socket,
  rename or delete a file, enumerate files in a directory, etc. This
  trait isn't required for the mere use of locks.

BUG=659191

Review-Url: https://codereview.chromium.org/2611473002
Cr-Commit-Position: refs/heads/master@{#441428}

This CL adds a non-zero default bitrate for VEAEncoder. When given 0 bitrate,
Media Foundation H264 HW encoder does not output any results.

BUG=676421
TEST= Tested https://rawgit.com/Miguelao/demos/master/mediarecorder.html
H264 on Mac and Win.

Review-Url: https://codereview.chromium.org/2611843002
Cr-Commit-Position: refs/heads/master@{#441427}

The following traits are used:

Priority: BACKGROUND
  User won't notice if this task takes an arbitrarily long time
  to complete.

Shutdown behavior: CONTINUE_ON_SHUTDOWN
  Tasks posted with this mode which have not started executing before
  shutdown is initiated will never run. Tasks with this mode running at
  shutdown will be ignored (the worker will not be joined).

  Note: Tasks that were previously posted to base::WorkerPool should
  use this shutdown behavior because this is how base::WorkerPool
  handles all its tasks.

May Block:
  Tasks posted with MayBlock() may block. This includes but is not
  limited to tasks that wait on synchronous file I/O operations:
  read or write a file from disk, interact with a pipe or a socket,
  rename or delete a file, enumerate files in a directory, etc. This
  trait isn't required for the mere use of locks.

BUG=659191

Review-Url: https://codereview.chromium.org/2611463002
Cr-Commit-Position: refs/heads/master@{#441426}

This avoids accidental layering violations, by enforcing use of
GCMDriver::GetInstanceIDHandlerInternal (which is commented as "These
methods must only be used by the InstanceID system") to get access to
InstanceIDHandlers.

BUG=none

Review-Url: https://codereview.chromium.org/2610933002
Cr-Commit-Position: refs/heads/master@{#441425}

BUG=671805
R=dpranke@chromium.org,qyearsley@chromium.org

Review-Url: https://codereview.chromium.org/2591933002
Cr-Commit-Position: refs/heads/master@{#441424}

In particular:
* Fix conversion of UNIX file name "/////file" and "////" as a UNIX
  path.  Both of these were broken, due to the same bug.
* Remove a DCHECK that would trigger on "//" as a file name. It's a
  valid UNIX path, if not a file name, and can still be passed through
  the file name conversion code.  Since there's no code to prevent
  that from happening, and the conversion code handles "/", the DCHECK
  made no sense.

BUG=675111

Review-Url: https://codereview.chromium.org/2610973002
Cr-Commit-Position: refs/heads/master@{#441423}

Cr-Commit-Position: refs/heads/master@{#441422}

There are a number of privacy-sensitive checks that we make using this
function. In order to ensure that the URLs really belong to Google, add
a check that TLD has been registered by Google.

BUG=665624

Review-Url: https://codereview.chromium.org/2498113003
Cr-Commit-Position: refs/heads/master@{#441421}

As a part of presubmit, if an OWNERS file is modified or added the
following checks will be performed:

- Ensure that at most one line starts with `# COMPONENT: ` exists in the
  file.
- Ensure that at most one line starts with `# TEAM: ` exists in the
  file, and that it contains exactly one email address.

R=stgao@chromium.org,dpranke@chromium.org,phajdan.jr@chromium.org
BUG=667954

Review-Url: https://codereview.chromium.org/2601773004
Cr-Commit-Position: refs/heads/master@{#441420}

FRE was made to lazily load the libraries, but it attempts
to access the AccountManagerHelper before it has been
fully initialized.  To avoid this, use ChromeBrowserInitializer
to the pre native initialization early, which will call into:
ProcessInitializationHandler#handlePreNativeInitialization, which
does AccountManagerHelper.initializeAccountManagerHelper.

BUG=

Review-Url: https://codereview.chromium.org/2610173002
Cr-Commit-Position: refs/heads/master@{#441419}

The omnibox append button's normal (un-highlighted) image is correctly
reversed for RTL languages, but the imaged displayed when the button is
tapped is not.

BUG=678085

Review-Url: https://codereview.chromium.org/2606353004
Cr-Commit-Position: refs/heads/master@{#441418}

The old test checked the hit test results for individual tabs.  This assumed
that hitboxes for partly-occluded stacked tabs would themselves be partly
occluded, and basically verified that this occlusion made sense.

We changed this in r411197.  Now, individual tab hitboxes are the full size of
the tab, and instead tab occlusion is handled by functions like
FindTabForEvent(), which check tabs in the correct order.

The new test simply iterates across the tabstrip at three vertical positions,
checking what every pixel hits, and making sure the order (in tab model indexes)
of what's hit is:

-1 0 1 2 3 -1

I dunno that this is a very robust test, but I don't think we really had
anything else testing event handling for stacked tabs at all, so it seemed
better than deleting the test entirely.

BUG=575327
TEST=none

Review-Url: https://codereview.chromium.org/2593273002
Cr-Commit-Position: refs/heads/master@{#441417}

https://chromium.googlesource.com/external/github.com/google/compact_enc_det.git/+log/e57cdc44bd54..368a9cc09ad8

$ git log e57cdc44b..368a9cc09 --date=short --no-merges --format='%ad %ae %s'
2016-12-29 brucedawson Save 908,288 bytes by deleting 'const' three times

TBR=jinsukkim@chromium.org

BUG=677351,629332

Review-Url: https://codereview.chromium.org/2617463003
Cr-Commit-Position: refs/heads/master@{#441416}

TBR=dfalcantara,benwells
BUG=678210

Review-Url: https://codereview.chromium.org/2610913002
Cr-Commit-Position: refs/heads/master@{#441415}

BUG=

Review-Url: https://codereview.chromium.org/2613643002
Cr-Commit-Position: refs/heads/master@{#441414}

I only looked for calls to "bounds().origin()".  We could probably change a lot
more spots by fixing places that call both x() and y().

BUG=none
TEST=none

Review-Url: https://codereview.chromium.org/2595163002
Cr-Commit-Position: refs/heads/master@{#441413}

TBR=binji
BUG=676063

Review-Url: https://codereview.chromium.org/2612803002
Cr-Commit-Position: refs/heads/master@{#441412}

BUG=671816
TEST=TriView.SetMinHeight

Review-Url: https://codereview.chromium.org/2605513002
Cr-Commit-Position: refs/heads/master@{#441411}

It's impractical to merge them, so instead, allow overriding them.

Tested manually on Windows.

BUG=675582
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2617453002
Cr-Commit-Position: refs/heads/master@{#441410}

This should fix the http/tests/misc/resource-timing-sizes-tags.html layout test.
The other test http/tests/inspector/resource-har-conversion.html needs an expectation
change to allow the custom header which is passed for PlzNavigate. Will do that in a later
patchset.

Changes on this patch are to implement the GetTotalReceivedBytes() override for the StreamURLRequestJob class

BUG=673745

Review-Url: https://codereview.chromium.org/2612683002
Cr-Commit-Position: refs/heads/master@{#441409}

NOTRY=true
TBR=groby@chromium.org
BUG=678300

Review-Url: https://codereview.chromium.org/2611723003
Cr-Commit-Position: refs/heads/master@{#441408}