- 13 Jul, 2018 40 commits
-
-
Dan Zhang authored
Existing crashes are not use-after-free. The CHECK's haven't been triggered so far. Merge internal changelist: 204339592 R=zhongyi@chromium.org Change-Id: I2b0549aafff5f639a3a86803aef364dc8c4e059c Bug: 664200 Change-Id: I2b0549aafff5f639a3a86803aef364dc8c4e059c Reviewed-on: https://chromium-review.googlesource.com/1135871 Commit-Queue: Dan Zhang <danzh@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#575074}
-
Nicolas Capens authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/6a990f8..8fb6f6a BUG=861882 TEST=bots CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I5a89accaec0bd01697ca9c4f0e4a6ac62de23e54 Reviewed-on: https://chromium-review.googlesource.com/1136867Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Abhishek Arya <inferno@chromium.org> Commit-Queue: Nicolas Capens <capn@chromium.org> Cr-Commit-Position: refs/heads/master@{#575073}
-
Xiaohui Chen authored
Bug: b:79879196 Test: locally build and run Change-Id: I299b82477c2ce153e5639426343be946757c3460 Reviewed-on: https://chromium-review.googlesource.com/1132118Reviewed-by:
Muyuan Li <muyuanli@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#575072}
-
Tommy Steimel authored
This CL adds a MediaLauncherActivity.MediaType histogram to track the type of media the user opens with the MediaLauncherActivity (audio/image/video). Bug: 861954 Change-Id: I28cc0a379ad2bc70d34f2d2f5751c3eb2ebbda45 Reviewed-on: https://chromium-review.googlesource.com/1135522Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#575071}
-
Bill Orr authored
This is similar to a change made for Oculus devices. OpenVR is initialized when we have a magic window session, and can only be used on the UI thread, or it can be initialized on the render-loop thread, and we will only use it on that thread. Gamepad data is now updated per-frame by the render loop, with data passed over to the gamepad fetcher and read in its polling thread. BUG=820288, 793364 Change-Id: I543487f823f7ac08e9b0f01889d227f455d0482c Reviewed-on: https://chromium-review.googlesource.com/1136056 Commit-Queue: Bill Orr <billorr@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#575070}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ed1205ae20b2..a80a012456a9 git log ed1205ae20b2..a80a012456a9 --date=short --no-merges --format='%ad %ae %s' 2018-07-13 timliang@google.com Revert "implemented metal gpu backend texture upload testing" 2018-07-13 weiliangc@chromium.org Reland: Check for ANGLE's implementation of texture_rectangle 2018-07-13 swiftshader-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/swiftshader 6a6692214c26..8fb6f6a129f5 (1 commits) 2018-07-13 fmalita@chromium.org [skottie] Make stroke width optional 2018-07-13 timliang@google.com implemented metal gpu backend texture upload testing 2018-07-13 ethannicholas@google.com Fixed SPIR-V geometry shaders 2018-07-13 ziadb@google.com SkAR Java: Animation support 2018-07-13 ethannicholas@google.com fixed SPIR-V matrix operations Created with: gclient setdep -r src/third_party/skia@a80a012456a9 The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=robertphillips@chromium.org Change-Id: Id572c54e9699536fe4be44f65da75295c4613a11 Reviewed-on: https://chromium-review.googlesource.com/1136913Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575069}
-
bsheedy authored
Enables the VR instrumentation tests on Oreo Phone Tester. Change-Id: Ie5d863c8bac56eb62b8db619c8ef4e8925afeef7 Reviewed-on: https://chromium-review.googlesource.com/1136806Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#575068}
-
Francois Doray authored
This method the last time at which the state of a LifecycleUnit changed. It will be used to determine if a LifeycleUnit has been unfrozen long enough and should be frozen again. Bug: 775644 Change-Id: I2ba04b9ed4085767e67108cd46901d876efc2217 Reviewed-on: https://chromium-review.googlesource.com/1134029 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#575067}
-
Scott Chen authored
Bug: 860274 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ic80b484b6611f960c8fc3a68c39b17795c4c75b3 Reviewed-on: https://chromium-review.googlesource.com/1132321Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#575066}
-
Eric Orth authored
Primarily an interface-only change. Only change past the interface level of the stack was to internally pass rawer information rather than use RequestInfo as that struct is specific to the old Resolve API. Only handles the basic case for now (HostPortPair input without any significant options), but additional funtionality will be added in subsequent changes. Copy and convert all the unittests that can be implemented using the new method with its current basic functionality. If we ever convert all usage to the new method and delete the old, we'll be able to cleanly delete all the old tests. Design doc: https://docs.google.com/document/d/1NmADJX00oRe9TxFCJTWl8ofdfyR22pbKT8-5Ad5lBsU Bug: 821021 Cq-Include-Trybots: luci.chromium.try:linux_mojo;master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I4fe454761e2930d6f235e8e505b689f8917fdeed Reviewed-on: https://chromium-review.googlesource.com/1099427 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#575065}
-
Sebastien Marchand authored
Don't enable the "StaggeredBackgroundTabOpening*" features in this experiment, they are independent now. Bug: 829933 Change-Id: Ie30c540974773cc7f9dc53f764766f05aa0e1d14 Reviewed-on: https://chromium-review.googlesource.com/1136652Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#575064}
-
Min Chen authored
Bug: 847587 Change-Id: I4f274158d78f8935339c42bbe15b21dbd4a72736 Reviewed-on: https://chromium-review.googlesource.com/1130464 Commit-Queue: Min Chen <minch@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#575063}
-
Samuel Huang authored
This is a code movement CL with minimal changes. Details: - Add obj_analyzer.py: New home for BulkObjectFilenalyzer, along with helper functions. Also inherits main() from nm.py for testing. - Add string_extract.py: New home for {LookupElfRodataInfo(), ReadFileChunks(), and ResolveStringPieces()}. Add top-level comments. - nm.py: Have content moved to the new files. Also, exposing RunNmOnIntermediates(), to be called from obj_analyzer.py. - Update archive.py and console.py to adapt to new code locations. Bug: 723798 Change-Id: I1d1670f04549a416f06de1da03c1a2b03c378461 Reviewed-on: https://chromium-review.googlesource.com/1136943 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#575062}
-
perfetto-chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/0b17b7db7523..a9c02104635b git log 0b17b7db7523..a9c02104635b --date=short --no-merges --format='%ad %ae %s' 2018-07-13 dproy@google.com Merge "Move node_modules install to install-build-deps" 2018-07-13 dproy@google.com Move node_modules install to install-build-deps Created with: gclient setdep -r src/third_party/perfetto@a9c02104635b The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I392ce06446d9ccf7db5ecab0c5b0597c53411734 Reviewed-on: https://chromium-review.googlesource.com/1136737 Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575061}
-
Lily Houghton authored
Per https://codereview.chromium.org/2460653003/ ENABLE_MDSN has been migrated from a #define to a buildflag; however, there are two instances of it in PrivetNotificationService that have not been changed yet. This CL fixes those. Bug: 863508 Change-Id: I273afb99ced733012ce58dcfa061d18faa8508de Reviewed-on: https://chromium-review.googlesource.com/1136864Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> Cr-Commit-Position: refs/heads/master@{#575060}
-
chrome://proximity_authJeremy Klein authored
This is needed because multidevice_setup now depends on DeviceSync. I also needed to add base/time because DeviceSync needs it. R=khorimoto@google.com Bug: none Change-Id: I53c9ea62f5e2c4ed90ac8c51221c1d64980fbca9 Reviewed-on: https://chromium-review.googlesource.com/1135949Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#575059}
-
Yuwei Huang authored
Per discussion in the a11y meeting on May 30, this CL re-introduces a 10s timeout for touch triggered FAB so that people using screen reader can easily get back from the FAB to the web content. Bug: 829613 Change-Id: I727d78967f6fb7780eaaaa40e5f5e9cf59b58613 Reviewed-on: https://chromium-review.googlesource.com/1132340 Commit-Queue: Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#575058}
-
src-internal-chromium-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d464e6a80005..5e752946b94c Created with: gclient setdep -r src-internal@5e752946b94c The AutoRoll server is located here: https://src-internal-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I8b6d86982a32a8d16523ec52b563742a1b72e6e8 Reviewed-on: https://chromium-review.googlesource.com/1136740Reviewed-by:
src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: src-internal-chromium-autoroll <src-internal-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575057}
-
Emily Stark authored
This will allow us to see whether the recurrent interstitial message affects CTR for CT errors specifically (rather than lumping them in with Symantec distrust errors, which can also trigger the recurrent error message). Bug: 839969 Change-Id: I04764573c6f225ab25c61fb268983f02f38fdc3f Reviewed-on: https://chromium-review.googlesource.com/1136717Reviewed-by:
Christopher Thompson <cthomp@chromium.org> Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#575056}
-
Peter Kasting authored
This moves the padding outside the NTB into the NTB, allowing more consistent positioning. Bug: 851044 Test: Open two tabs. The leftmost tab's left curve should taper out to the very corner of the toolbar, not 8 DIP later. Change-Id: I01487e3c416a24b8387bf67c2b1a3e0817125cd9 Reviewed-on: https://chromium-review.googlesource.com/1135965 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#575055}
-
Emily Stark authored
Bug: 839969 Change-Id: I07ad560f50aa25a10a5a9fb55ebdd525d0fa6e84 Reviewed-on: https://chromium-review.googlesource.com/1136711Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#575054}
-
Ramya Nagarajan authored
If this is not set, the #ntp-contents height is inherited, which applies from the "top" location specified in .non-google-page, but using the size of the overall NTP content area (at 100%), resulting in an unnecessary scrollbar. The chosen height corresponds to MV tile height for a single row, but also works for a row of icons, and works well on small screens (like Pixelbook), as well as high-res screens. Bug: 855834 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I8b342e066c8ddcb51b51e9f03a85e9181a001020 Reviewed-on: https://chromium-review.googlesource.com/1136860 Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#575053}
-
Michael Thiessen authored
Bug: 863533 Change-Id: If0579797b75f45308c50ddbf55ac19f007b7e12f Reviewed-on: https://chromium-review.googlesource.com/1136907Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#575052}
-
Tommy Steimel authored
This CL modifies the overlay play button ShouldCausePlayPause function to take CSS and Document zoom into account. This fixes a bug where a zoomed video had an incorrect hitbox for the overlay play button. Bug: 862063 Change-Id: I3f51454618e5c455bba62b4b019701d67fd8886c Reviewed-on: https://chromium-review.googlesource.com/1135663Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#575051}
-
Peter Kasting authored
This was only used for the new tab button, but the new tab button now reports the relevant size as its preferred size. So we can use that directly everywhere. This will make it easier to add padding around the new tab button, because the button can report a larger size to other callers without having to keep the layout size in sync with a padding value local to new_tab_button.cc. Bug: none Change-Id: Id513c23ba458857032b05ed8e266387d9e1f1f55 Reviewed-on: https://chromium-review.googlesource.com/1135764 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#575050}
-
liberato@chromium.org authored
Since we haven't used ContentVideoView for video playback since ~M64, this CL removes it. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I3f9b005bf2b4c7e8d3dd1b1250e42c0089cc1092 Reviewed-on: https://chromium-review.googlesource.com/1112741 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Simeon Anfinrud <sanfin@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#575049}
-
Mike Reed authored
Bug: 863042 Change-Id: Ibde119026dfc6d7a4ba470cc836a834b9a4e5d2f Reviewed-on: https://chromium-review.googlesource.com/1135592 Commit-Queue: Mike Reed <reed@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#575048}
-
Sidney San Martín authored
Two changes: - Make all Views windows layer backed (they mostly were already). - Use _titlebarHeight to hide the titlebar for app windows. _hidingTitlebar resulted in the top corners not being clipped (as if the window were a sheet). Bug: 863264, 862672 Change-Id: I9647afdcba464cc17b88cc2d752bf273a0f6ab89 Reviewed-on: https://chromium-review.googlesource.com/1136520 Commit-Queue: Sidney San Martín <sdy@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#575047}
-
Stefan Zager authored
This is only necessary to eliminate a presubmit error about the use of the banned method Time::ToInternalValue. No functional change. BUG=752327 R=chrishtr@chromium.org,vmpstr@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Id0ecab92b4605da1c25398a539be7dc87a250547 Reviewed-on: https://chromium-review.googlesource.com/1135988Reviewed-by:
vmpstr <vmpstr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#575046}
-
Scott Violet authored
Having a NOTREACHED here is problematic for two reasons: . A bad client could trigger the NOTREACHED by setting a random value. . Because the registry is a separate pipe then that to the WindowService it is entirely possible for the property to be set on the window before the property has been set in the registry. BUG=863520 TEST=none TBR=estade@chromium.org Change-Id: I08b047e871c39d46cfcd548b078df6af9e334032 Reviewed-on: https://chromium-review.googlesource.com/1136937Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#575045}
-
Kenneth Russell authored
Bug: 771792 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_layout_tests_slimming_paint_v2;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I34ffae8b8ff4d1372eedcdc0b6549bd68a521b84 Reviewed-on: https://chromium-review.googlesource.com/1073888Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#575044}
-
Ben Mason authored
Defaults to target_name if bundle_name is not specified. Bug: 863115 Change-Id: I37ae90190742305d3f2116f8481017535c6daa42 Reviewed-on: https://chromium-review.googlesource.com/1136461Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#575043}
-
David Dorwin authored
Bug:862741 Change-Id: I181f6ddb1f43b5710e72ab8babad0dbd465e6507 Reviewed-on: https://chromium-review.googlesource.com/1136736Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#575042}
-
Wez authored
Bug: 863166 Change-Id: I024feeb9c3e687632841da11e44222dc1b1f8acb Reviewed-on: https://chromium-review.googlesource.com/1136722 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#575041}
-
Justin Donnelly authored
This reverts commit cf4c67a7. Reason for revert: I believe that this change is responsible for https://crbug.com/862196 ("Text in omnibox completely reset while typing"). Rather than try a speculative fix, I'm going to revert this and we can try to re-land post-branch with an associated fix. Original change's description: > omnibox: reset display url when re-navigating to the current page by clicking a link > > Previously, if navigating a link did not cause a url change (e.g. clicking on the `stackoverflow` > logo on the `stackoverflow.com` homepage reloads the same page), then the display url remained > unchanged. If the user had deleted or edited the url, his changes would remain. Now, the url is > reset. > > Bug: 830491 > Change-Id: I9819fa29ca1d86467a660e0e40ddb149cf210f1d > Reviewed-on: https://chromium-review.googlesource.com/1114337 > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Tommy Li <tommycli@chromium.org> > Commit-Queue: manuk hovanesian <manukh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#571479} TBR=mpearson@chromium.org,thakis@chromium.org,tommycli@chromium.org,manukh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 830491 Change-Id: Ie9a30f656a0e0faabeaf690b865fa49e37e8bc7f Reviewed-on: https://chromium-review.googlesource.com/1134099Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#575040}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/74aa8cb5bd4e..a50a4e11ae0f git log 74aa8cb5bd4e..a50a4e11ae0f --date=short --no-merges --format='%ad %ae %s' 2018-07-13 xixuan@chromium.org SkylabHWTest: Add skylab tag for kicking off/aborting skylab suites. 2018-07-13 dgarrett@google.com InitSDKStage: Remove chroot_replace argument. 2018-07-13 vapier@chromium.org cros_build_lib: drop unused ParseDurationToSeconds Created with: gclient setdep -r src/third_party/chromite@a50a4e11ae0f The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: Ic378d2ad6e274ac668abe024c85d7199cea63c86 Reviewed-on: https://chromium-review.googlesource.com/1136739Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575039}
-
Tibor Goldschwendt authored
If running component updates in a background task we won't instantiate an activity. As a consequence we won't register the VR assets component and never get updates for it in the background. To solve this, register the component in native. The component gets only registered if the user has a Daydream headset paired. Checking this is expensive. Thus, we save whether the component should be registered in user preferences. At Chrome startup (which may happen when running an update task in the background) read this flag and conditionally register the component. Reading the flag took less than 1 ms in my tests. Change-Id: I1e9d0f6caab094307f8f3397c913cc1b7431d8fa Reviewed-on: https://chromium-review.googlesource.com/1132147Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#575038}
-
Robbie McElrath authored
This reverts commit 9b785217. Reason for revert: The tests for this class weren't actually running. https://crrev.com/c/1136864 breaks because of this CL when re-enabling the tests. Original change's description: > Migrate PrivetTrafficDetector to use NetworkConnectionTracker. > > This migrates PrivetTrafficDetector from using > net::NetworkChangeNotifier to content::NetworkConnectionTracker, which > works with the network service enabled. > > Bug: 859134 > Change-Id: I06f2ecbe142bbed9a8772f69ab109b0c0dc32581 > Reviewed-on: https://chromium-review.googlesource.com/1123681 > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574700} TBR=pastarmovj@chromium.org,thestig@chromium.org,rmcelrath@chromium.org Change-Id: I15aeff8eed59935b9640d73e95a638c9ffb35f71 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 859134 Reviewed-on: https://chromium-review.googlesource.com/1136398Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#575037}
-
Francois Doray authored
This is a reland of https://chromium-review.googlesource.com/1133972. The double end session issue was fixed by https://chromium-review.googlesource.com/1136725. This is a no-op cleanup before adding more stuff in TabManager::PerformStateTransitions(). TBR=sebmarchand@chromium.org Bug: 775644 Change-Id: I35a7b3cbb877a26fb41dfce7340bf3a4b2c777b9 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1136792 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#575036}
-
Katie D authored
This addresses a TODO from a preview CL. No functional changes. Change-Id: I21e99b55f285475d8321fea260751be3f18d811b Reviewed-on: https://chromium-review.googlesource.com/1135519Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#575035}
-