- 29 May, 2020 40 commits
-
-
Thomas Lukaszewicz authored
Currently all pending accelerators are registered and unregistered in postorder. This patch changes it so that pending accelerators are registered in preorder and deregistered in postorder. This is an issue as accelerators registered later take priority over accelerators registered earlier. This change gives child views the chance to take priority over parents when registering their accelerators rather than having an ancestor potentially override an accelerator added in the child. Bug: None Change-Id: I06fd3db9dccec3bae61c148b2f18753080246117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219166 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#773198}
-
Wez authored
This is a reland of 4b053da1 Original change's description: > [Fuchsia] Add WebGL MSAA to the allowed list for WebEngine > > Now webgl-antialiasing-mode and webgl-msaa-sample-count can be > specified in WebEngine config. This will allow to control MSAA support > when using WebGL. > > Bug: 766360 > Change-Id: If325bedefb31c1c960868563bcf223ba0bc88999 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220865 > Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: David Reveman <reveman@chromium.org> > Reviewed-by: Wez <wez@chromium.org> > Commit-Queue: Wez <wez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#773101} Bug: 766360 Change-Id: I763044e3419652f2a5682432ad6f04f5718c658d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218780 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#773197}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/f1393e23a22c..461e38761d05 2020-05-29 philipp.hancke@googlemail.com use constants for CN and telephone-event codec names 2020-05-29 dminor@webrtc.org Check that data_ is non-null before memcpy in EnsureCapacityWithHeadroom If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I75b8389ec9875c6e21f5b342491a13c9132c0ff1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222487Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773196}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5a4033aa4fe9..acde602c3a4b 2020-05-29 mathias@chromium.org Add .npmrc to enforce package-lock=true If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibab22f6214c3ce51f46bd0b9fa125a363b8404c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222486Reviewed-by:
-
Sebastien Lalancette authored
UX-requested functionality which allows users to learn more about what they can do with a QR code. When tapping on the "Learn More" button, a popover is shown with the help text. Bug: 1064990 Change-Id: I1cc65f29607089e95c766c518fe0af526061aeb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218705Reviewed-by:
Mark Cogan <marq@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#773194}
-
manuk authored
Launching on mobile pending on Android and iOS stable experiments. Also adds a HQP unit test for scoring with midword matching enabled. Bug: 591981 Change-Id: I31d5632e77035d9d20afa1939ee491a98316ba0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220611 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#773193}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1590710362-da8362c2cf2dc829b7840d09501bff322abdb5d5.profdata to chrome-win32-master-1590753475-bbc6db949b849f1149739200ccf06d1d537d4988.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I4afce8e8fd1cb80cae4df9183c73a41422414b4e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222482Reviewed-by:
-
Tim Volodine authored
PrerenderTest.PrerenderDisabledOnLowEndDevice PrerenderTest.LinkManagerCancelThenAddAgain are flaky on Android Marshmallow 64 bit Tester. BUG=1087876 TBR=tbansal@chromium.org,pasko@chromium.org Change-Id: I6966ceab2088eb4ddfeb76b6898f3a3a3d0aeaee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218784Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#773191}
-
Maksim Ivanov authored
Add sequence checks that prevent incorrect (cross-thread) usage of CloudPolicyClient. Bug: 727645 Change-Id: Ib0a1fc3bb475553b251010ceadbc3072beb6e0b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215819 Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#773190}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/15a98af79295..77a9d35a2289 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC olka@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: olka@google.com Change-Id: I8b7860cc789e25d6a2bd5cae1b25209e4f696cd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222319Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773189}
-
Olga Sharonova authored
TBR=ellyjones@chromium.org Bug: 1087875 Change-Id: I552ee7a358c581829274f8b5e722c76e9f8f0138 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219900Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Olga Sharonova <olka@chromium.org> Cr-Commit-Position: refs/heads/master@{#773188}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ae7ec62515ed..074414fed53e 2020-05-29 westont@google.com Revert "GrClips provided as pointers to GrRTC" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: Ib07da5ba8ffed50e81f940369af183f774d71cba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222485Reviewed-by:
-
sandromaggi authored
This adds a new dropout reason for clicking the back button. Bug: b/152954282 Change-Id: Id84e7d6bcdd0b76640157ba793be37d49ddc4db7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218122 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Marian Fechete <marianfe@google.com> Cr-Commit-Position: refs/heads/master@{#773186}
-
manuk authored
This CL filters duplicate history matches in URLIndexPrivateData::HistoryItemsForTerms used by the HQP. Previously, we relied on the autocomplete controller's deduping which 1) may affect performance since it occured after additional processing of each suggestion (I would guess it's insignificant), and 2) prevented the HQP provider from making full use of it's allocated per-provider-limit. Also update a few HQP unit tests. Bug: 591981 Change-Id: I1c6ce02050ba1b674e3507368c1a095f5a5b0c6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219027 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#773185}
-
Olga Sharonova authored
Some are disabled individually already, but now the rest become flaky. Bunch-disabling quickly TBR=csharrison@chromium.org Bug: 1087775 Change-Id: Ieddbd847eede193be3a974fb1a4d16ccaec3429a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218782Reviewed-by:
-
Yi Gu authored
Previously when scroll-linked animation goes from finished to running we did not add it to pending animations. As a result it never got restarted on the compositor. See crbug.com/1070635 for more details. Bug: 1070635 Change-Id: I1454bfbc75f8ce07dc952645c51fabd3804ef0d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218749Reviewed-by:
Kevin Ellis <kevers@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#773183}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e4f8e19e72e9..4c32bd0b7d6b 2020-05-29 enrico.galli@intel.com D3D12: Silence known debug layer warnings 2020-05-29 cwallez@chromium.org Fix unlinking nullptr error scopes if device init failed 2020-05-29 jiawei.shao@intel.com Add basic supports of storage textures on OpenGL 2020-05-29 cwallez@chromium.org Metal: Fix clearing of subresource mipmaps. 2020-05-29 bryan.bernhart@intel.com Rolling 1 dependencies If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1081998 Tbr: cwallez@google.com Change-Id: I98a8aa6be7e4354975f1bf46dae0d8fd626b5444 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222480Reviewed-by:
-
François Degros authored
Added integration test checking that an error is reported when trying to zip a file with Chrome feature FilesZipNoNaCl enabled. This ensures that the Chrome feature FilesZipNoNaCl (commanded by Chrome flag files-zip-no-nacl) is correctly taken in account by Files App. BUG=912236 TEST=browser_tests --gtest_filter="*CannotZipFile*" Change-Id: I7fa3251cf3bbc4673e6a24b12f89e3de3ecb0c7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222085 Commit-Queue: François Degros <fdegros@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#773181}
-
Victor Hugo Vianna Silva authored
For the case of passwords duplicated in the account and on the device, this CL adds the correct strings in the edit dialog and the removal notification. The text in the edit dialog is also modified to match the updated mocks. Mock for removal notification: https://screenshot.googleplex.com/W7RAXUM8Eeo Mock for edit dialog: https://screenshot.googleplex.com/6SGSG6oNPNv Bug: 1049141 Change-Id: Ib472319eb320811e9f22032d6ee16bcfc0c29b0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218118Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#773180}
-
Mathias Carlen authored
Before this patch the client and server protos were not in sync. The reason why this worked is that the proto messages used had the same fields and the same ids. This patch introduces a proper Result message that also contains the navigation_ended field used to signal to the backend that the prompt action was terminated due to a reload or navigation of the underlying website. Bug: b/152724265 Change-Id: I8247dddc058fda95d5a1948d5b9e5405eceaaa95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215055 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#773179}
-
Chris Sharp authored
Bug: 1018157 Change-Id: I99710f7ec965b7e6a2719a9cbd797934d7d04b3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219464 Commit-Queue: Chris Sharp <csharp@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#773178}
-
Victor Hugo Vianna Silva authored
In crrev.com/c/2202237, PasswordsSection started owning an array of passwords deduplicated across stores, multiStoreSavedPasswords. The original array, savedPasswords was kept around at the time, due to code that aims to optimize updates to the password list. This code relies on having unique identifiers for list elements, which can be easily obtained for the elements of the original array but are not immediate for the deduplicated one. This CL removes the array of non-deduplicated entries, while still keeping the optimized list updates. This is achieved by constructing a combined id from the ids of each duplicate. The remaining array is named savedPasswords, since information about deduplication is already present in the variable type and documentation. Bug: 1049141 Change-Id: Id91d71d7b074801195ae3de7ef46af204be00463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220088 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
-
Nicolás Peña Moreno authored
Intent to Ship: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/1UQqjz1CR-k Bug: 543598 Change-Id: I2f878bdfb2e5390754b89ef7fa61f4213e679003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216652Reviewed-by:
Yoav Weiss <yoavweiss@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#773176}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/b940a7d97b27..f1393e23a22c 2020-05-29 ivoc@webrtc.org Add UMA histogram for actual Android buffer size If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Ie26692def51c45ac35465ca84d3716841b680df8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222483Reviewed-by:
-
Tim Volodine authored
This test started failing recently on Nougat and Oreo Phone Testers. BUG=1087857 TBR=bsheedy@chromium.org,alcooper@chromium.org Change-Id: I4d33d534aafb116d826179e934c9a182a6bc66ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220034Reviewed-by:
-
Nina Satragno authored
Disable ServiceWorkerEagerCacheStorageSetupTest.UpdateOnScriptUrlChange. The test is flaky on all platforms. TBR=shimazu@chromium.org Bug: 1087869 Change-Id: Icce9e9258e6ddc9816c6b4d6e23ea5bd16908b9b No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220839 Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#773173}
-
Yang Guo authored
With a separate repository, we want to make developing DevTools frontend as much decoupled from rest of Chromium as possible. This includes not having to rebuild Chromium for debug mode. Bug: 1087379 Change-Id: Ie42185dcc685f4a08f106286f0d0824dcee60a99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218774Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#773172}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/08d002d6c916..5a4033aa4fe9 2020-05-29 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2b94c420057da8a1467c0f75ae8ce286aa1ebda6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222484Reviewed-by:
-
Shengfa Lin authored
If page.navigate has error text for network related error, we would like to return unknown error status. Bug: chromedriver:3488 Change-Id: Ia7ade877ea5bf43802b8587bc4d8f5687e8a6882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219110 Commit-Queue: Shengfa Lin <shengfa@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#773170}
-
Danan S authored
Bug: 1039601 Change-Id: If65d3d2924fbb91339c8f2b0f278f3bdf8714a68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2221417 Auto-Submit: Dan S <danan@chromium.org> Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#773169}
-
vasilii authored
Before the CL, implementation compared encrypted password values before and after an update in the password store. That may not work on Windows: - old passwords are encrypted with CryptProtectData. That function produces different results if invoked for the same string twice. - Currently we use an encryption key and Chrome utilities instead. That means the value produced with the old and new encryption techniques can't be compared. The old data hasn't been migrated to use the encryption key. The CL compares the raw password values instead. Bug: 1087310 Change-Id: If48a41b1c5d7cad4471c0f8ee48f9e89e22182d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220030 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#773168}
-
Tommy Steimel authored
This CL changes the generated import statement for loadTimeData in strings.m.js to use a scheme-relative URL instead of directly loading form chrome://resources. This allows strings.m.js to function properly on chrome-untrusted:// frames. Bug: 1051835 Change-Id: I01e5f77eb7746370c2d178b1aa0e3dc7e87532af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220480Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#773167}
-
Yuanyao Zhong authored
display::PanelOrientation::kLast is defined as the last element in enum display::PanelOrientation and the value could be equal to last element in enum. Therefore replace DCHECK_LT to DCHECK_LE. Bug: b/77900197 Test: build cast_shell Change-Id: If939e21eb91610e86897a05c7c8d6c5a0c58f532 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219584 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#773166}
-
Rohit Rao authored
This method was deprecated in iOS 13. From the UIKit documentation: "On iOS 7 and later you cannot customize the picker view’s selection indicator. The selection indicator is always shown, so setting this property to NO has no effect." BUG=1086653 Change-Id: Iac7eaf2b887ebf4a7c6a9cb47c4df1b984e7c6c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218816Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590739125-30ac6fa847343d316264eb803765e7acf0a7e6c1.profdata to chrome-mac-master-1590753475-030a2e24f1ea13d43c4c794e813316525ddd3d28.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I3cbbbad3546b96df675d436c1b0591d09b057c78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222481Reviewed-by:
-
Stephen McGruer authored
Bug: None Change-Id: Ib66c86639734a88269c75ecfd08c8c4bbc1396fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220452 Auto-Submit: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#773163}
-
Andrew Grieve authored
Fixes compile error when enable_jdk_library_desugaring=true Bug: 1056751 Change-Id: Idb2d4675cefd37931e9f103f79989697407e5f0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220619Reviewed-by:
Sam Maier <smaier@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#773162}
-
Colin Blundell authored
In WebLayer, navigations coming from the embedder currently get the type TYPED | FROM_ADDRESS_BAR. This type has implications on how intent launching is handled for these navigations: for user-typed navigations, (1) Intents are blocked from launching without a redirect (2) Intents to URLs that the app can handle stay within the app even if (a) there was a redirect and (b) an external app has registered as a default handler for such URLs Fact 2 in particular is problematic for intended production use cases of WebLayer. This CL changes the navigation type for navigations coming from the embedder to be reflective of these use cases: LINK with a user gesture. Setting the navigation params this way ensures that intents will be launched in the cases (1) and (2) described above. Bug: 1087434 Change-Id: Ib43d2ea2cbbfd0352dcde3f5895ac82292b3415f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219892 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#773161}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2a89e8bb. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I914fa38c6e51c607872619bf072148a1b3ac8ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220587Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#773160}
-
Nektarios Paisios authored
Anchor and focus offsets in accessibility selection may refer to children that are ignored but are included in the accessibility tree. We need to translate between ignored and unignored offsets at the platform boundary both when setting as well as when retrieving the selection. AX-Relnotes: Reading the current selection as well as setting the selection using Jaws and NVDA no longer reads the wrong selection or fails to set the selection. R=dmazzoni@chromium.org, aleventhal@chromium.org Bug: 1082814 Change-Id: I4530f3079eaa282d6db9778f7d6af221345841f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2205400 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#773159}
-
