- 13 Jun, 2020 17 commits
-
-
Xiaocheng Hu authored
This reverts commit 5aba5002. Reason for revert: Causing crbug.com/1092431 Let's stop messing up the perf bots while debugging. Original change's description: > Enable full testing of CSSReducedFontLoadingLayoutInvalidations > > This is preparation for enabling finch experiments of the feature on M85 > > Note: though M85 hasn't reached Beta, we'd like to have it covered by > test bots first to catch any breakage. We'd also like it to be tested > by perf bots, since this "feature" is a performance optimization. > > Bug: 441925 > Change-Id: I3ef98ffcfa960381efd034cd1cd63e55fbda4b01 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231269 > Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Reviewed-by: Chris Harrelson <chrishtr@chromium.org> > Cr-Commit-Position: refs/heads/master@{#775847} TBR=asvitkine@chromium.org,chrishtr@chromium.org,xiaochengh@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 441925, 1092431 Change-Id: Ife4aa822dda70d88249306b63e30d3d39df7a560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242383 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#778044}
-
Nick Harper authored
QuicCryptoClientHandshaker checks that signatures aren't empty, so we should never hit this case in production. In case something goes wrong at the upper layer, it's nice to have a belt-and-suspenders approach and since an empty signature is obviously wrong, it should be rejected. Change-Id: Id704bb9b469b6bc831f0a629be1824461617d883 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243835Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: David Schinazi <dschinazi@chromium.org> Auto-Submit: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#778043}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/197a756b..0809f7f8 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I330dbdc56d669ac87146abc5e5bdbfed5cacfde2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240960Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#778042}
-
Fergus Simpson authored
Chromium style requires an out-of-line dtor for complex classes. Bug: b/153422916 Test: CQ Change-Id: I7680362c10ed86c8185f396ae45005b94d229d17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220811 Commit-Queue: Fergus Simpson <afergs@chromium.org> Auto-Submit: Fergus Simpson <afergs@chromium.org> Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Cr-Commit-Position: refs/heads/master@{#778041}
-
Robbie McElrath authored
Site Settings dialogs crash on open with newer versions of the AndroidX fragment library. This is due to them expecting the LayoutInflater returned by the FragmentHostCallback to not have a Factory2 associated with it yet. To get around this, this CL makes FragmentHostCallback's onGetLayoutInflater method clone the Context's LayoutInflater. This CL also prevents onStart from calling dispatchActivityCreated more that once in case the Fragment gets stopped and restarted. Bug: 1085553 Change-Id: I8b392fdd6b6c8231470698e76d90eae07734a818 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244094 Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#778040}
-
Will Cassella authored
Previously, HTMLMediaElement had a 'DisplayMode' enum which was one of { 'kUnknown', 'kPoster', 'kVideo' }. This didn't mesh well with the spec, which only mentions the 'show poster flag' as being true or false. Additionally, the points where this mode was changed were inconsistent with the spec, and resulted in us showing video contents when we should be showing the poster, and makes implementing other features dependent on the state of the 'show poster flag' difficult, such as the cue timeline. This CL removes 'DisplayMode' from HTMLMediaElement (though reintroduces it in a limited form in LayoutVideo), and implements the 'show-poster-flag' in accordance with the spec. This makes the behavior of poster rendering (as detailed in the attached bug) consistent with Firefox and Safari. Bug: 1007241 Change-Id: Iaaf3a10581357443b7889578360852e0a674e68c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222948Reviewed-by:Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#778039}
-
dpapad authored
Previously GestureDetector tests were using custom implementations StubElement, MockTouchEvent and MockWheelEvent. These are unnecessary and can be replaced by the native EventTarget, TouchEvent and WheelEvent respectively. Moreover, the native TouchEvent and WheelEvent instances are more appropriate for testing the prod code, since they exhibit the correct preventDefault()/defaultPrevented behavior, unlike the custom MockTouchEvent and MockWheelEvent. Bug: 1093540 Change-Id: I5e6bfa59c38b61c0ca33f5172a79769f84e09117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242711Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#778038}
-
David Bienvenu authored
CursorManager::SetCursor() won't change the cursor if it thinks the new cursor is the same as the current cursor. Sometimes it doesn't know that the actual cursor has changed (e.g., a east/west resize curor) and Chrome shows a stale cursor until the cursor type changes. This CL makes the cursor manager clear its cached cursor on mouse entry to avoid the stale cursor. Bug: 1044905 Change-Id: Iae8385f5a5f1e89af7ff92ba4437e4b153511441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242044Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1591977558-abdc4af0521917678b079bf82ef4430fa9fc4d9f.profdata to chrome-win64-master-1591991989-3593aca6d8199c7d2e9dcde354f25dff60c64ec1.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I0a626e9d5188b9802eee9166a99f8a0d09353bac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244036 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#778036}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/80d38188db27..f545ce04f48a 2020-06-12 michael.liao@microsoft.com [SourceMap]: Fixing failure in reverseMapTextRange If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1094083 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iefe8938694dbe4df78b0f270daa398452c414f24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244037 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iee4785548c9aba375cb34a67ca32c0391604b7fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244041Reviewed-by:
-
Kenneth Russell authored
This reverts commit 3d5fcb45. Reason for revert: parent CL may have caused win-asan failures per crbug.com/1094214 . Original change's description: > Follow-up: inline a piece of code that did not need precomputed. > > See comment here: > https://chromium-review.googlesource.com/c/chromium/src/+/2239979/2/ui/views/win/hwnd_message_handler.cc#2087 > > Bug: 1088416 > Change-Id: I820d345e8a52eb43c564e40592a6808aa31e8fac > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242234 > Commit-Queue: Dana Fried <dfried@chromium.org> > Reviewed-by: Peter Kasting <pkasting@chromium.org> > Cr-Commit-Position: refs/heads/master@{#777889} TBR=pkasting@chromium.org,dfried@chromium.org Change-Id: I0259f955c53e1d028073e7506871d43939830572 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1088416, 1094214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243837Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#778033}
-
Qiran Gong authored
Add viz::ResourceFormat to handle: GpuChannelMsg_CreateSharedImage, GpuChannelMsg_CreateSharedImageWithData. Add net::EffectiveConnectionType to handle: ViewMsg_UpdateWebPreferences. Add printing::MarginType to handle: PrintHostMsg_ScriptedPrint. Change-Id: I8f0af98fd34384623f9d164fa4b1ebcaa35b6f0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243993 Commit-Queue: Martin Barbella <mbarbella@chromium.org> Reviewed-by:
Martin Barbella <mbarbella@chromium.org> Cr-Commit-Position: refs/heads/master@{#778032}
-
evliu authored
This CL adds support for final/partial recognition results. Whether a recognition result is a final or partial result will affect how it is displayed in the caption bubble UI. Bug: 1093969 Change-Id: Ibe9203bd8bf1aad7e40ab4569d89e95f4133c53f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240898Reviewed-by:
Abigail Klein <abigailbklein@google.com> Reviewed-by:
Matthew Denton <mpdenton@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#778031}
-
Mei Liang authored
This CL polishes the Message card in GTS by the following: 1. Updates Message card to follow the NTP promo card spec. 2. Updates the close animation to have a zoom in then fade out visual effect. Applies this animation to the Tab card as well. Change-Id: I14ff8c3746b9c0bebafd6f3afc7077d337ffbcb9 Bug: 1076538 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240422Reviewed-by:Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#778030}
-
Yi Xu authored
In this CL, I continued to move tests from blink/perf_tests/canvas to perf/page_set/rendering. So that canvas perf tests can be ran with the existing rendering benchmark. In this cl, I moved 11 tests in total. In my next cl, I will finish this refactor. Bug: 1077148 Change-Id: I318e15314e3a087a37718224679b471aa52dbb76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214750Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Yi Xu <yiyix@chromium.org> Cr-Commit-Position: refs/heads/master@{#778029}
-
Nigel Tao authored
We are experimenting with alternative JSON parser implementations (crbug.com/1069271), which can return slightly different error messages and error codes. Several tests, which spell out their expected error message in great detail, will fail (a false negative) with these alternative JSON parsers. This commit winds back how much detail such tests expect. Bug: 1069271 Change-Id: I9ff64333d409c6ff40237bf038327f45c4d9f5f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241098Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#778028}
-
- 12 Jun, 2020 23 commits
-
-
Doug Arnett authored
This is to help us compare language detection support for sub frames to the existing main frame only support. Bug: 1092996 Change-Id: I1334f005df27176135c9232152413e5c33dfa96a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238492Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Doug Arnett <dougarnett@chromium.org> Cr-Commit-Position: refs/heads/master@{#778027}
-
Kelvin Jiang authored
Enable append/set rules to be indexed. Bug: 1081544 Change-Id: Ia309ddb07946711bbf4206eb0cde6036d5727153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236912Reviewed-by:
-
Mitsuru Oshima authored
Bug: 1073685 Change-Id: I6239fac8d8301a34424839c2660116ec0898fb45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244033 Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#778025}
-
Kenneth Russell authored
This reverts commit ceaac935. Reason for revert: continued assertion failures on some phones; see http://crbug.com/1084740#c17 . Original change's description: > [Offline indicator v2] Add field trial testing entry > > Enabling the feature causes some test failures since the bots are > offline and the offline indicator is always visible. For the short term, > we are adding a command-line switch to disable the offline indicator. > > The longer-term plan is to enable the feature for most tests, and only > disable where we have to. > > Bug: 989148, 1091491, 1093085 > Change-Id: I89e7ef93233b4c4cc2bd395ce1309bc14d5dea09 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228367 > Reviewed-by: Steven Holte <holte@chromium.org> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org> > Reviewed-by: Avi Drissman <avi@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Commit-Queue: Sinan Sahin <sinansahin@google.com> > Cr-Commit-Position: refs/heads/master@{#777216} TBR=avi@chromium.org,twellington@chromium.org,holte@chromium.org,bsheedy@chromium.org,sinansahin@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 989148, 1091491, 1093085 Change-Id: I6c22120bbb27ff430f73a40ea28f1bf1a9a7da31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244195Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#778024}
-
evliu authored
This CL adds incognito support to the speech recognition service factory. Bug: 1093978 Change-Id: I71fbc99fcf3ad01448165a09ddd6b77133995570 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241944Reviewed-by:
-
Xiaocheng Hu authored
We have some flaky FontPreloadManager unit tests, which might be due to FontPreloadManager timer fires unexpectedly when the test is slow. As a tentative fix, this patch overrides the timeout to make sure the timer doesn't fire. Bug: 1092556 Change-Id: I87df6af2e881aa7c5184cd2b9522c8c643d6bd2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243358Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#778022}
-
Dominic Farolino authored
This CL addresses crbug.com/1072350 by adding two UseCounters: - One to count requests whose - method != ("GET" || "HEAD") - mode == kNoCors - response is opaque - Another to count requests that meet the same criteria as above, but have experienced at least one redirect. This CL also adds tests to ensure that the UseCounter is counted properly: Tests: - Not enough conditions are met for the UseCounter: - No conditions met: (GET, "cors", basic) - One condition met: (POST, "cors" basic) - One condition met: (GET, "no-cors" basic) - One condition met: (GET, "no-cors", opaqueredirect) - Two condition met: (POST, "no-cors", basic) - Two condition met: (GET, "no-cors", opaque) - All conditions are met: - (POST, "no-cors", opaque): Cross-origin, no redirect - Should count first counter, but not second - (POST, "no-cors", opaque): Cross-origin Redirect involved - Should count both UseCounters R=kinuko@chromium.org, ricea@chromium.org, yhirano@chromium.org Bug: 1072350 Change-Id: I13331a8ca51a9cdd684ddb8b88f3232117426320 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242205 Commit-Queue: Dominic Farolino <dom@chromium.org> Reviewed-by:Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#778021}
-
Ahmed Mehfooz authored
Bug: 1094478 Change-Id: Ib3b85b21bdbf3a20aa08bf8629b80ac2b4e68452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243443Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#778020}
-
Hazem Ashmawy authored
Also subtract one from NumHistograms on the client side in order not to skew it and keep the zero bucket in it representative of no histogram fetched. Fixed: 1093101 Test: bin/run_webview_instrumentation_test_apk -f "*MetricsBridgeServiceTest*" Change-Id: Iea4c0a2d958920ac9cf1308a942b157f3362920d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2237984 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#778019}
-
Vincent Boisselle authored
Bug: 1094108 Change-Id: Ie91978405da956b5cc65bbe0ad0435c96ebee9da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244034 Commit-Queue: Vincent Boisselle <vincb@google.com> Reviewed-by:
Dan H <harringtond@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#778018}
-
Tom Anderson authored
R=sky Bug: 1093715,1093265,1094376 Change-Id: I9ae640e4a9a6b2117ae43d45b6e189270ec06d27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241465 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Nico Weber authored
They're slow to cycle, so use the sharding settings that we already use on the linux asan bots. TBR=aeubanks Bug: 794372 Change-Id: Ibe61c7b9219dabad2f0c6099cf316bec7c094133 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243996Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#778016}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 0d495d2b. With Chromium commits locally applied on WPT: 9c24e63c "Check for first frame in CreateImageBitmap" d2ee98f4 "Move manual offscreen wpt tests to own folder" 458dc853 "WPT: Migrate content-visibility tests to wpt." 84f61c81 "Exclude non relevants reports from the COOP-opener-breakage tests." e106756f "[COOP] Access reporting. Update the test." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I7b5274622e90af3835c4a4936d5dc2e93c7676a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2240961Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#778015}
-
John Abd-El-Malek authored
This allows histogram data to live across browser process crashes/restarts. This is implementing support that was added to Chrome in https://crbug.com/546019. WebView is not enabled until https://crbug.com/1076549 gives us more information on the required disk size. Bug: 1090682, 1025781 Change-Id: I5b74faaeee6e4718c76e3b3d9686caf5f7913675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236060 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#778014}
-
Antonio Gomes authored
... instead of WebMediaStreamTrack. CL also updates the use on all child classes, including: - RTCRtpSenderImpl - FakeRTCRtpSenderImpl - DummyRTCRtpSenderPlatform This is part of the effort to reduce the needless use of public Blink APIs (wrappers) within renderer/modules. BUG=704136 R=guidou@chromium.org Change-Id: I8ff38b45a48df7225f3658dfc7c0296eaa181c3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239929Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#778013}
-
Mitsuru Oshima authored
Bug: 1087917 Change-Id: I8eea45f20be6fe0054547fc8b0624a6a59636295 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2236201Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#778012}
-
Kenneth Russell authored
conformance/textures/webgl_canvas/ tex-2d-rgba-rgba-unsigned_byte.html tex-2d-rgba-rgba-unsigned_short_4_4_4_4.html tex-2d-rgba-rgba-unsigned_short_5_5_5_1.html conformance2/textures/webgl_canvas/ tex-2d-rgb10_a2-rgba-unsigned_int_2_10_10_10_rev.html tex-2d-rgb5_a1-rgba-unsigned_byte.html tex-2d-rgb5_a1-rgba-unsigned_short_5_5_5_1.html tex-2d-rgba16f-rgba-float.html tex-2d-rgba16f-rgba-half_float.html tex-2d-rgba32f-rgba-float.html tex-2d-rgba4-rgba-unsigned_byte.html tex-2d-rgba4-rgba-unsigned_short_4_4_4_4.html tex-2d-rgba8-rgba-unsigned_byte.html are failing due to newly introduced tests. Bug: 1092734 Change-Id: I7d4689bbf53b9985873baa0cc7d1ee94363f4e96 Tbr: shrekshao@google.com Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244112Reviewed-by:Shrek Shao <shrekshao@google.com> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#778011}
-
Owen Min authored
Enterprise.PolicyUpdatePeriod.MachineLevelUser Signin.ForceSigninVerification Signin.AuthenticatedLaunchUserEvent They will now expires in M88. Bug: 1072570, 1072602, 1089514 Change-Id: I31b8a00c4c8f63d6da7a4274ff5efa3522846b85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243599Reviewed-by:
-
John Delaney authored
This CL adds a tentative string for a reload button to the details view, of the heavy ad error page which disables the intervention on the site and reloads the page. This text aligns with the existing quiet webview interstitials. The full implementation of the functionality exists on https://crrev.com/c/2242169 Change-Id: If0bba4a50f9f8c7396c90e3e9fc7061c2ced6b67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2242645Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#778009}
-
David Grogan authored
Previously, if a legacy abspos child of an NG flexbox had a legacy containing block, it could be positioned incorrectly. This CL copies the staticpos logic from legacy flex, with a few minor simplifications. There's little refactoring of legacy to share code. Legacy continues to mostly rely on methods in LayoutFlexibleBox that the new code can't use. I don't want to risk altering legacy's behavior here, especially considering this might be merged to 84. Bug: 845235, 1066859 Change-Id: Ic07ed9e3fe5febe72981b47b0bacbc2b33691c71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222112Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#778008}
-
Sorin Jianu authored
These fixes are for: https://chromium-review.googlesource.com/c/chromium/src/+/2239764 * missing include headers * sorting headers (unit tests are not special) * use braces for multi-line ifs * remove const on return type Bug: 1068797 Change-Id: Ib5d223f82739350ee3981b1281e2a3f296343bcc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244114Reviewed-by:
S. Ganesh <ganesh@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#778007}
-
Scott Graham authored
Not following chromium-dev or most dev in //build any more so there's probably not many changes I'm qualified to review here any more. Change-Id: Ie35015521eb18787c68b401c4ae5700ea3654f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2244039 Auto-Submit: Scott Graham <scottmg@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Scott Graham <scottmg@chromium.org> Cr-Commit-Position: refs/heads/master@{#778006}
-
Jorge Lucangeli Obes authored
The relevant codepath hasn't been used since ~2014 (!!!) and the reporting code was removed in crrev.com/c/1183895. BUG=chromium:1088699 TEST=validate_format, pretty_print. Change-Id: Ifcc98ce794a9def469b1bb29e66955145e93a8ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2243533 Auto-Submit: Jorge Lucangeli Obes <jorgelo@chromium.org> Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
-
