- 09 Sep, 2020 40 commits
-
-
Kurt Catti-Schmidt (SCHMIDT) authored
This change fixes a particular issue where the Javascript "onfocus()" event doesn't fire when accessibility API's call focus() on a specific node when the frame containing that node doesn't currently have focus. Blink's implementation of "onfocus()" in Document::SetFocusedElement has a condition under GetPage()->GetFocusController().IsFocused() to prevent focus from being fired if the page doesn't have focus. This is correct behavior from Javascript's perspective. From the accessibility side, behavior was already added to focus on the document before focusing on a specific node in https://chromium-review.googlesource.com/c/chromium/src/+/1809943 However, when that change calls into RenderFrameHostImpl::AccessibilityViewSetFocus, if the view is a RenderWidgetHostViewChildFrame, nothing will happen, as that method is empty. So this change completes that method with a simple focus implementation. A browser test was added to confirm that the Javascript onfocus event is properly fired. Bug: 1124067 Change-Id: I5a77fcdfba96da45fe548e93c2da8c9a69181066 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2389005 Commit-Queue: Kurt Catti-Schmidt <kschmi@microsoft.com> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#805465}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5fc363ed10fc..149db0ded77e 2020-09-09 andoli@chromium.org [ts] Typecheck css_overview/CSSOverviewUnusedDeclarations.js with TypeScript If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I2bf13cc93941fe419490405ab5363573dd7a5ea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401871Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805464}
-
David Bertoni authored
The ExtensionBrowserTest::ContextType should be used instead of a custom enum. Bug: 1100412 Change-Id: I7871b377cfdb134285b1f2c98b87c268a8779bd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390663Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#805463}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1599651808-76687bf9821b87304e86bb785c30a5b3566b2da2.profdata to chrome-mac-master-1599674142-9f13839562e8523855d1bff685bbea34c58e94a7.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I97bf632d5444f8b782789347e8c0aae5c1a4602e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402039Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805462}
-
Adithya Srinivasan authored
Bug: 1122186 Change-Id: Ie474c061c3d115e9c9370485bf02ee3a1c4131c2 Tbr: ssid@chromium.org No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401514Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#805461}
-
Sebastien Marchand authored
This only affects profiling builds (coverage or PGO) There's already some logic to wait for all the renderer processes to dump their profiling data on shutdown but this doesn't cover the utility processes and they end up corrupting some profile data files. This CL extends the logic that we already use for the renderer and GPU processes to the other childs. Bug: 1071664, 1124774 Change-Id: I64a1fa247226a3521efc6680bb103c15f7b37cc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399819Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#805460}
-
Wenyu Fu authored
1. Move the baseline of the title at the center of the screen; 2. Increase the margin around bottom button group, and made adjust to small screen devices; 3. Center the ToS and UMA components between the title and accept button Bug: 1120842 Change-Id: Ie6ab2f4322d1ffd2e2614987424c636604797c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391268Reviewed-by:
Sky Malice <skym@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#805459}
-
Noah Rose Ledesma authored
This change eliminates a possible reference invalidation. Previously, a pointer to an element in a vector was being dereferenced after erase was called. Bug: 1126351 Change-Id: Icfca65af49a1ddc716915dc16d5e4bb6ea45b149 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401509Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Cr-Commit-Position: refs/heads/master@{#805458}
-
Scott Violet authored
The fixes were merged to earlier versions, so the min version requirement can be updated. BUG=none TEST=test only changes Change-Id: I8a0658d62a1fcfac3825f8c6b93d7ce9f714893e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398894Reviewed-by:
Evan Stade <estade@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#805457}
-
Yann Dago authored
Use end date when deleting browsing data in storage partition Bug: 1103815 Change-Id: I29d3c7d0b55806579470a1fe96d98061a5b50f22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372725Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#805456}
-
David Van Cleve authored
Looks like FindLongString is supposed to be disabled on Mac debug testers but the test name wasn't changed over to the MAYBE_ prefix. Recent flake: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8869619630837658832/+/steps/browser_tests_on__none__GPU_on_Mac_on_Mac-10.13.6/0/logs/Deterministic_failure:_FindInPageControllerTest.FindLongString__status_FAILURE_TIMEOUT_/0 Bug: 1096911 Tbr: justincohen@chromium.org,skhapugin@chromium.org Change-Id: I213df7a630ffb9cdf025b3e80a32c389ba14db78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401868Reviewed-by:
David Van Cleve <davidvc@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#805455}
-
David Black authored
Bug: 1124581 Change-Id: I6dead04514935b1a6f5a9abc9f6e4398991776f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399455 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#805454}
-
Rakib M. Hasan authored
Bug: 1126255 Bug: 1041619 Change-Id: I3699b90e207f560f58c98893665041dba63ea1f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399748Reviewed-by:
Erik Staab <estaab@chromium.org> Reviewed-by:
Rakib Hasan <rmhasan@google.com> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#805453}
-
danakj authored
We allow these directories to work together now and have decided to merge them to simplify understanding the code relationships. Add forwarding headers in content/browser/frame_host/ to make this transition easier. PRESUBMIT and tricum errors are not addressed in this CL as it is just moving code. TBR=avi@chromium.org Bug: 1091083 Change-Id: Id112b1eb4c8de0ac074a593f495dd79f4d02105d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401303 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Auto-Submit: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#805452}
-
David Tseng authored
See go /chromevox-touch-gestures Note that the previous mappings were to previous and next word which are now available via three finger left/right to word and then flick up or down. R=akihiroota@chromium.org Bug: 1124454 Test: browser_tests --gtest_filter=ChromeVox*.SwipeLeftRight2 Change-Id: I82e98a1b6da15dd82d0ff9c55ce98cdedb99aad1 AX-Relnotes: makes ChromeVox two finger swipe left and right perform escape and return respectively. Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386009 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#805451}
-
Chromium WPT Sync authored
Using wpt-import in Chromium dc952b0b. With Chromium commits locally applied on WPT: c07a387a "Make DefinitelyNewFormattingContext return true for SVG foreignObject" eadf7030 "Implement Animation::setTimeline" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: Id849639ce9fa7f652eb9d8768b91f5d8e3b601c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401760Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805450}
-
Pavol Marko authored
Update the Cert Provisioning UI when the state of a certificate provisioning process changes. Rate limit updates to the UI to max 1 update per 2 seconds to avoid flickering / performance issues. Bug: 1081396 Test: unit_tests Change-Id: If539d19885e9e2804dfc9d3f662a58dff8f0be53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377729Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Michael Ershov <miersh@google.com> Commit-Queue: Pavol Marko <pmarko@chromium.org> Cr-Commit-Position: refs/heads/master@{#805449}
-
Donn Denman authored
Removes the special treatment of plain HTTP pages with respect to privacy. These pages were considered privacy-insensitive, but now we treat them the same way as secure HTTPS pages. BUG=1124397 Change-Id: Ic3f5640ffa020e7f4656a78965b6f87662c039a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393526 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Reviewed-by:
Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#805448}
-
Peng Huang authored
Requesting VK_IMAGE_USAGE_STORAGE_BIT has performance penalty with some GPUs, so we just request useful usages. Bug: 1126548,fuchsia:59204 Change-Id: I0f0cc01221f55c4ca4df6974f1002179bfc731a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401330Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#805447}
-
Haiyang Pan authored
There is an issue with root on "user" build. Bug: 1126536 Change-Id: Icac9a9194dc95bd477fe3cf2d3e44e409743f318 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401327 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Yuke Liao <liaoyuke@chromium.org> Commit-Queue: Yuke Liao <liaoyuke@chromium.org> Cr-Commit-Position: refs/heads/master@{#805446}
-
Francois Doray authored
Results from Canary/Dev experiment look good. Enabling in testing config to allow Beta experiment. Unused entries are removed from fieldtrial_testing_config.json to work around crbug.com/1053702. Bug: 1075553 Change-Id: I1bcec218175187b99f6ab0a3ac8008da3125aed6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398977 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#805445}
-
minch authored
Changes: - Update the toggle button in the detailed view while color mode changes. - Other small polish. Bug: 1106012 Change-Id: I72e89861e963bff51062bacd423dd61bb8a366e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393357Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Min Chen <minch@chromium.org> Cr-Commit-Position: refs/heads/master@{#805444}
-
Ravjit Singh Uppal authored
This reverts commit 4aaa9f29. As Flash's deprecation is near, we are resuming per session prompting about the deprecation. Bug: 995969 Change-Id: I76632c2ace65d95fafaaea9224f02586f53c6841 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390656 Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#805443}
-
Raymond Toy authored
Move the date out by 6 months. Bug: 1125837 Change-Id: Ia9569408d28fa5f05b04e9e76e9fe015c277fa2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399004Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#805442}
-
Nico Weber authored
- Mention more platforms at the top - Be better about escaping underscores - Remove some old gyp references - Remove some no-longer-needed explicit clang opt-ins Change-Id: I0e604a12ef67f3ae4d40cb06eac713305bdaf726 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401806Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#805441}
-
Maggie Chen authored
In the function of CopyQuadsToPass(). Bug: 1117235 Change-Id: I437d09841adf1517f0ab05d626fcf1ab4b42fd26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2393239Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: Maggie Chen <magchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#805440}
-
Prakhar authored
Pending build time looks within limits as of now: http://shortn/_knva2rUxM9 Bug: 1024915 Change-Id: Id56079aea1dc93e62d5089641ac58cfc79c2400a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400585Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Erik Staab <estaab@chromium.org> Commit-Queue: Prakhar Asthana <pasthana@google.com> Auto-Submit: Prakhar Asthana <pasthana@google.com> Cr-Commit-Position: refs/heads/master@{#805439}
-
phillis authored
App could be a null pointer if registry profile is being deleted. In this case, we will not attempt to get shortcut info. Bug: 1113276 Change-Id: I0ff77b56d701e54350763c1fbabd4f43a0c85f4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388892Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Phillis Tang <phillis@chromium.org> Cr-Commit-Position: refs/heads/master@{#805438}
-
Avery Musbach authored
The present CL addresses system instability after a display is added (or you end mirror mode) while in tablet split view with empty overview. OverviewSession::OnDisplayAdded calls OverviewController::EndOverview which fails in case of tablet split view with empty overview. Thus, overview stays active, but there is no overview grid for the added display. Then you certainly can get a crash, because a lot of code assumes that when overview is active, there is an overview grid for each display. The present CL ensures that overview will actually end when a display is added. Test: All/SplitViewOverviewSessionTest.ExitAndReenterMirrorModeWithEmptyOverview/? Change-Id: Ib9e359e2b231db0f531f7f1de4af9c5af0b2d408 Fixed: 1124481 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2390964Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#805437}
-
Xianzhu Wang authored
Bug: 1101002 Change-Id: Iaa8538423acb119501092e098a7800ba690c0b89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399822Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#805436}
-
Jimmy Gong authored
There are several observers that have "OnStatusChanged" as a function name. This change updates them to be more specific so that potential listeners can implement the observers without any name conflicts. Bug: 1106937 Change-Id: I111828f2d402b11daf2dca2b27df8f6a59786109 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399130Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jimmy Gong <jimmyxgong@chromium.org> Cr-Commit-Position: refs/heads/master@{#805435}
-
Torne (Richard Coles) authored
Re-enable these to see what errors they report via the newly added logging, since this failure doesn't seem to be reproducible. Bug: 1106472 Bug: 1117289 Change-Id: I70c7341a53a0c79a3edf29588ece4fe7d1a06220 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399523 Auto-Submit: Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#805434}
-
Ahmed Mehfooz authored
Bug: 1110760 Change-Id: I1d1274b724d1c6a7f2e265754d85d7abd11f3116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399829Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Cr-Commit-Position: refs/heads/master@{#805433}
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202009090800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/mluAO-o7A3mN4nCwt4x0R0SnXS6cuF3Fo--glimMpfkC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: If0d13db4cdb52addab3604fe84dcedf135384388 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401601Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805432}
-
Andre Le authored
BUG=1106937,1126208 Change-Id: I7d54f5c4aeb9c6aa3243567e83dbd022e651c4ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388168 Commit-Queue: Andre Le <leandre@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#805431}
-
Adithya Srinivasan authored
Bug: 1120501 Change-Id: Ica8546b86353d86a5001b3d7bad161d8ee0e68f5 Tbr: calamity@chromium.org No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401850Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#805430}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/dc9083e4831f..6acdaf066c12 2020-09-09 mheikal@chromium.org Improve AdbWrapper#is_emulator to use device codename vs serial If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:11249650 Tbr: rmhasan@google.com Change-Id: Ib5d527ddf3bb1c29201d05410e5247a9d6369c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401859Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#805429}
-
Mehran Mahmoudi authored
On Android M and prior versions, a white rect appears on the bottom of the player. This is seemingly caused by using the canvas#setMatrix method. This CL removes this call for identity matrix which fixes this problem for the default scale factor. However, for non-identity matrices, the white rect will still appear. Fixing that requires further investigation. Bug: 1126541 Change-Id: I9c48b3dc90e6fecf450f99059ff8cdf788d94420 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401840Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#805428}
-
ckitagawa authored
This CL fixes a low-volume crash in paint preview code. Where the tab might be null when checking if shown and needs badge. This CL was uploaded by git cl split. Change-Id: I69c03fb298c1d70b13368d6f9056d744231caee2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401321 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Auto-Submit: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#805427}
-
Nate Fischer authored
This renames "repack_whitelist" to "repack_allowlist" and swaps out related code (ex. variables in chrome/ layer). The new term is consistent with "enable_resource_allowlist_generation" and avoids non-inclusive terminology. Bug: 1097644 Test: autoninja -C out/Official monochrome_public_apk (official build) Change-Id: I3e319c8b8bec9ab9df081b0b61ec02683d665af6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399453Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#805426}
-