- 19 Jul, 2018 31 commits
-
-
Maggie Chen authored
Three more cases are added to the Direct Composition Pixel tests. Pixel_DirectComposition_Underlay test is created by adding a black block on top of a video. Pixel_DirectComposition_Nonroot test is created by adding a white gradient blending effect on a video. Pixel_DirectComposition_ComplexOverlays test is created by applying scaleX, scaleY and rotate. The H.264 mp4 video clip FourColors.mp4 used in these tests is created by Maggie Chen. The video frames has 4 color blocks (Yellow, Red, Green, Blue) and it looks like a still image. With this video, the pixel tests can be done by solid color block comparisons. No golden images are needed. Bug:848097 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I95483ba8c96c495b1150c749f1f55243c6a5efa5 Reviewed-on: https://chromium-review.googlesource.com/1136003 Commit-Queue: Maggie Chen <magchen@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#576296}
-
Victor Costan authored
This CL: 1) Extracts StatementID from sql/connection.{h,cc} into its own files sql/statement_id.{h,cc}. 2) Adds tests specifically targeting sql::StatementID. 3) Replaces passing StatementID by const reference with passing by value. 4) Removes the StatementID constructor that takes a name, and updates the call sites to use the source file+line constructor. Bug: 863724 Change-Id: I5bc6e160fe294189d3e9a2baa8f6be61b21c38d2 Reviewed-on: https://chromium-review.googlesource.com/1137915 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#576295}
-
Koji Ishii authored
This patch fixes first-line baseline when the 'overflow' property is other than 'visible'. CSS2 states that: The baseline of an 'inline-block' is the baseline of its last line box in the normal flow, unless it has either no in-flow line boxes or if its 'overflow' property has a computed value other than 'visible', in which case the baseline is the bottom margin edge. https://drafts.csswg.org/css2/visudet.html#propdef-vertical-align This rule should apply only to 'inline-block', but it was incorrectly applied to first-line baseline as well. This patch fixes incorrect alignment in the comment lines of Gerrit code review site. Bug: 636993 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I49ffd8c050f384765c61c5678a431fa74492356d Reviewed-on: https://chromium-review.googlesource.com/1140336Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#576294}
-
Jiajia Qin authored
With this change, all webgl/webgl2 APIs can be run on webgl2-compute context for passthrough command buffer. Bug: 859249 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ia3c5febb7f5cbeb16d560ee05362c4746f97d5d6 Reviewed-on: https://chromium-review.googlesource.com/1141434Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Jiajia Qin <jiajia.qin@intel.com> Cr-Commit-Position: refs/heads/master@{#576293}
-
Hiroshi Ichikawa authored
Bug: 862537 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic60262906f269376375738afcf3067ee2d93294e Reviewed-on: https://chromium-review.googlesource.com/1139945Reviewed-by:
John Wu <jzw@chromium.org> Commit-Queue: Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#576292}
-
Katie D authored
Reviewed by Chrome OS UI team and OK to land in M69. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I9c614f6113de0ef7dc289f9dc960a4fe9b6a57a8 Reviewed-on: https://chromium-review.googlesource.com/1138646Reviewed-by:
Hector Carmona <hcarmona@chromium.org> Commit-Queue: Katie Dektar <katie@chromium.org> Cr-Commit-Position: refs/heads/master@{#576291}
-
Tommy C. Li authored
Currently we rely on test-only code to render tabs opened in the background. This CL updates RenderWidgetHostViewMac to not rely on test-only code and does an Aura-analogous operation to render background tabs. It also makes the Mac version of WasUnOccluded contain all the meat of the Aura version. Bug: 856617 Change-Id: Id9f05f627cbadb542772a200f2608787f05a63b7 Reviewed-on: https://chromium-review.googlesource.com/1117762 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#576290}
-
Xiaocheng Hu authored
The layout has unclear test flow, as it uses a big test function with different branches with different assertions for all test cases. As a result, the expectations for the test cases are unclear. This patch removes all branching from the test flow, so that it becomes clear what we expect on each test case. It also reveals that LayoutNG has different behavior and should be marked failure here. Bug: 755750 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I7d1a22a5805cc7ad031bf3c7bc24f0b822a3a0da Reviewed-on: https://chromium-review.googlesource.com/1142573 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#576289}
-
Ken Rockot authored
Associated endpoints have been getting error handler invocations synchronously whenever their corresponding master interface endpoint is closed. This is bad for reasons explained in the linked bug. Fix! Bug: 864731 Change-Id: If4a7d205ab42be5ee43926be619e77ad0ab15d68 Reviewed-on: https://chromium-review.googlesource.com/1141078Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#576288}
-
Tiger Oakes authored
OWNERS files can reference other OWNERS files rather than duplicating their content. If a COMPONENT is not found in an OWNERS file, the reference is followed to try to find a COMPONENT. Bug: 860303 Change-Id: Ia676156a4a3945c85409dd93f5ee9f407faa94a8 Reviewed-on: https://chromium-review.googlesource.com/1134093Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#576287}
-
Henrik Boström authored
This implements creating, updating and surfacing transceivers from the content layer. This is in preparation for the blink layer to implement its part, but split up for the sake of reviewability. For the big picture, see: https://chromium-review.googlesource.com/c/chromium/src/+/1138615 Because the blink layer is needed to surface the transceivers to JavaScript, and because the codepaths are tested by LayoutTests, the new code in this CL is not yet exercised or tested, as is ensured by NOTREACHED(). Follow-up CLs will exercise the code in this CL. This CL updates the following operations in RTCPeerConnectionHandler to support both Plan B and Unified Plan once the new codepaths are unlocked: - AddTrack() - RemoveTrack() - SetLocalDescription() - SetRemoteDescription() The only operation missing in AddTransceiver(), to be added separately. Bug: 777617 Change-Id: I225cf1d903e95e488599d6735b09a57aa2b279bb Reviewed-on: https://chromium-review.googlesource.com/1141952 Commit-Queue: Henrik Boström <hbos@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#576286}
-
Kenneth Russell authored
This was missed in the last set of renamings. Bug: 863070 Change-Id: I9a44bef5c26a4862c8622a0be0e9d79aad478679 Tbr: jbudorick@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1142612Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#576285}
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/302bb847d356..f9afc77f283e git log 302bb847d356..f9afc77f283e --date=short --no-merges --format='%ad %ae %s' 2018-07-18 ehmaldonado@chromium.org Reland "gclient_scm: Use cherry-picking instead of rebasing." Created with: gclient setdep -r src/third_party/depot_tools@f9afc77f283e The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:850812 TBR=agable@chromium.org Change-Id: I6d5d0c1a1ff3ade569d72e9e2145ecac58db7e30 Reviewed-on: https://chromium-review.googlesource.com/1142020Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576284}
-
Sam McNally authored
QuickOffice uses beforeunload events. When running inside a mime handler, these beforeunload event handlers are ignored. Add a beforeunload event handler to PluginDocument when a plugin requires it. This event handler is controlled over a mojo interface, exposed to the mime handler as chrome.mimeHandlerPrivate.setShowBeforeUnloadDialog(). Bug: 819761 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: Ieb61cf98ce2bf719fc128499f8d0e57d8fe7ad33 Reviewed-on: https://chromium-review.googlesource.com/1139946 Commit-Queue: Sam McNally <sammc@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#576283}
-
Xing Liu authored
This CL propagates URL chain and response headers for in memory download backend that is used in incognito mode for background fetch. Bug: 863949 Change-Id: I07baff393111aaa2bd2ce2ef9965a78d299be125 Reviewed-on: https://chromium-review.googlesource.com/1142466Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#576282}
-
Fady Samuel authored
RenderWidgetHostViewBase::GetLocalSurfaceId passed the viz::LocalSurfaceId by value. LocalSurfaceId is large and so copying it around is expensive. This CL returns a const ref of LocalSurfaceId instead to reduce copying. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: Ic775202ef5572676e056bd41419edbaefb7e44da Bug: 672962 Change-Id: Ic775202ef5572676e056bd41419edbaefb7e44da Reviewed-on: https://chromium-review.googlesource.com/1141990Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#576281}
-
Allen Bauer authored
animations using and derived from LinearAnimation. This allows for easier testing and tuning of the many animations throughout the code. By setting a scale factor, animations can be sped up or slowed down. This allows for them to be better observed to ensure the intermediate states for transitions, movements, and fades look good. Bug: None Change-Id: Ia2350e71bf6f3bac3fae26351418a95d2452f415 Reviewed-on: https://chromium-review.googlesource.com/1138820 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#576280}
-
Kenneth Russell authored
This reverts commit 775612b8. Reason for revert: caused all Windows debug bots to fail almost all tests. Only one example: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29/70380 Original change's description: > [scheduler] Add task type and queue type to tracing. > > R=skyostil@chromium.org > > Change-Id: Id0aea377558e876c8178e82eb3a170f678c415cc > Reviewed-on: https://chromium-review.googlesource.com/1140717 > Commit-Queue: Alexander Timin <altimin@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#576201} TBR=skyostil@chromium.org,altimin@chromium.org Change-Id: I56291cf103d5626c963c2661c4cdca7c29d74476 No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/1142173Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#576279}
-
Robbie McElrath authored
This is a reland of 9b785217 with test fixes. The failing unit tests weren't being run when I first landed this, but were enabled afterwards and started breaking, so I rolled back. Specifically, I PostTask'd (un)registering with the NetworkConnectionTracker to the right threads, and added a PrivetTrafficDetector::Stop method to clean up the registration and call it from PrivetNotificationService. Original change's description: > Migrate PrivetTrafficDetector to use NetworkConnectionTracker. > > This migrates PrivetTrafficDetector from using > net::NetworkChangeNotifier to content::NetworkConnectionTracker, which > works with the network service enabled. > > Bug: 859134 > Change-Id: I06f2ecbe142bbed9a8772f69ab109b0c0dc32581 > Reviewed-on: https://chromium-review.googlesource.com/1123681 > Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org> > Reviewed-by: Lei Zhang <thestig@chromium.org> > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Cr-Commit-Position: refs/heads/master@{#574700} Bug: 859134 Change-Id: I19bc5bf0abdbd41cfbd3da1c0881f122adca6c2b Reviewed-on: https://chromium-review.googlesource.com/1137411Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#576278}
-
Alex Moshchuk authored
Bug: 865206 Change-Id: Id94f5a610b31a5e63c494030a792fe168583d95d Tbr: rsorokin@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1142702Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#576277}
-
Luke Halliwell authored
I noticed this used by mistake in a couple CLs recently. The define isn't set in gn, misleadingly makes people think their code is tested on cast_shell bot. TBR=slan@chromium.org Bug: None Test: None Change-Id: Ie4b16ca4b1bb565fe8d45598f7cc0601277907d9 Reviewed-on: https://chromium-review.googlesource.com/1139214 Commit-Queue: Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Cr-Commit-Position: refs/heads/master@{#576276}
-
Fady Samuel authored
RenderWidgetHostViewBase::GetFrameSinkId passed the viz::FrameSinkId by value and was not a const method. This CL returns a const ref of FrameSinkId and makes GetFrameSinkId a const method so it can be accessed even if the caller has a const pointer or reference to the RenderWidgetHostViewBase object. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I5142a75f21a1c0396ba868bf66699a2fb85a2c33 Bug: 672962 Reviewed-on: https://chromium-review.googlesource.com/1141985 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#576275}
-
Daniel Murphy authored
R=pwnall@chromium.org Bug: 857464 Change-Id: I58218cf3f4831842f5fddaca480523e5c9169f35 Reviewed-on: https://chromium-review.googlesource.com/1142474 Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#576274}
-
Orin Jaworski authored
Weather answers with °F will have TOP_ALIGNED text ranges, and this CL detects them to raise the text, improving readability. Bug: 864798 Change-Id: I3a2dff9fc0e28283bdeaaa2413d261d076737a8f Reviewed-on: https://chromium-review.googlesource.com/1142385Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#576273}
-
Xu Xing authored
BUG=NONE Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I4626621916085e01fec25150da5ea1fba9cd63a8 Reviewed-on: https://chromium-review.googlesource.com/1139579Reviewed-by:
Eric Karl <ericrk@chromium.org> Commit-Queue: Xing Xu <xing.xu@intel.com> Cr-Commit-Position: refs/heads/master@{#576272}
-
Ryan Tseng authored
These have migrated to luci Except for heartbeat, which has been deleted. Bug: 790703, 790614 Change-Id: Ida1e02c3b1671471a07bfa8f11bda407f0a0d7a6 Reviewed-on: https://chromium-review.googlesource.com/1142615Reviewed-by:
Vadim Shtayura <vadimsh@chromium.org> Reviewed-by:
Jao-ke Chin-Lee <jchinlee@chromium.org> Reviewed-by:
Marc-Antoine Ruel <maruel@chromium.org> Commit-Queue: Ryan Tseng <hinoka@chromium.org> Cr-Commit-Position: refs/heads/master@{#576271}
-
wutao authored
This patch adds an about flag for continue reading. Bug: 843839 Test: manual. Change-Id: Icb0856b54936f7cf1a507abc80441260b4956fa5 Reviewed-on: https://chromium-review.googlesource.com/1140525 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#576270}
-
Christian Fremerey authored
This CL is part of a series, see Design Doc at https://docs.google.com/document/d/1ihGDZloUGdDpZ5XfmiI3AcqsSxOP9kOe5GxXOTqpHW4/edit?usp=sharing Test: capture_unittests --gtest_filter=VideoCaptureDeviceFactoryLinuxTest Bug: 768887 Change-Id: I91c8f3ccd30663532437a62410a2f8bc6536308e Reviewed-on: https://chromium-review.googlesource.com/1123655 Commit-Queue: Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#576269}
-
Raymond Toy authored
Measure the output of the destination to determine if the output is audible or not. Also keep track of the total duration of when audible output was played. Bug: 855069 Change-Id: Icec9aa3d3b853bb5b4b9287ce9350d2e16cd383e Reviewed-on: https://chromium-review.googlesource.com/1102664 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#576268}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 09223a46. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/21541 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources kpaulhamus@chromium.org: external/wpt/webauthn panicker@chromium.org, tdresser@chromium.org: external/wpt/paint-timing TBR=foolip No-Export: true Change-Id: I42d16bad7549e3d5c73860342a9cfb557033932b Reviewed-on: https://chromium-review.googlesource.com/1142436 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#576267}
-
Yue Li authored
- Add separate flag (kActivityControlAccepted) to determine opt-in flow completion. This flag will also be used to control opt-out mode UI. - Remove runtime opt-in(when "Enable" button pressed and when Assistant key pressed). Assistant should be in opt-out mode in these cases. - No longer disable Assistant if user decline the activity control in opt-in flow. - Enable Hotword by default. Bug: b/111569973 Test: Manual Test Change-Id: I11c018b3149fe21b5d6dde4a410ea422f8391e3d Reviewed-on: https://chromium-review.googlesource.com/1141346Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#576266}
-
- 18 Jul, 2018 9 commits
-
-
Zhongyi Shi authored
QUIC Connection Migration: clean up the code before disabling connection migration before handshake. This change also changes to use session's netlog instead of separate netlog to log connection migration event if connection migration will be aborted early. Bug: 790547 Change-Id: I7a53bc315953fd57bfad3d0d249f90b200844051 Reviewed-on: https://chromium-review.googlesource.com/1141177 Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#576265}
-
Peter Kvitek authored
Change-Id: Id112e69693cf40f3e1dc2980a690ac4e5153d8d4 Reviewed-on: https://chromium-review.googlesource.com/1135765 Commit-Queue: Peter Kvitek <kvitekp@chromium.org> Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Cr-Commit-Position: refs/heads/master@{#576264}
-
Shubhie Panicker authored
Now freezing of loading should be triggered by the master flag: StopInBackground, and doesn't need its own flag. Bug: 775761 Change-Id: I1d899fb63b9ac6d6bb032a5d065437ebd47eb200 Reviewed-on: https://chromium-review.googlesource.com/1140905 Commit-Queue: Shubhie Panicker <panicker@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#576263}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/30688fb1c434..f22b4e2f6682 git log 30688fb1c434..f22b4e2f6682 --date=short --no-merges --format='%ad %ae %s' 2018-07-18 hnakashima@chromium.org Use casts to deduplicate implementation of const/non-const methods. 2018-07-18 hnakashima@chromium.org Fix skia_paths build. Created with: gclient setdep -r src/third_party/pdfium@f22b4e2f6682 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I7903d1431cc219136b5a5379b40815faf4dca2a5 Reviewed-on: https://chromium-review.googlesource.com/1142326Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576262}
-
Roberto Carrillo authored
R=hinoka,vadimsh Change-Id: I14bd0fdb4b2960d28d906dc83bcc89ed5a3d2213 Reviewed-on: https://chromium-review.googlesource.com/1142605Reviewed-by:
Ryan Tseng <hinoka@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#576261}
-
Evan Stade authored
- don't toggle visibility of back button and window icon, which only exist for non-tabbed windows. Those windows hide the entire header in overview and don't need to explicitly hide individual components. - get rid of the settings window icon workaround that prevented setting the window icon on settings windows (designed to preserve the override from SettingsWindowObserver). All window icon logic is located in BrowserView. Bug: 854704 Change-Id: I84106b7a4a1f8f78c8fc76a9be682422d41c9a45 Reviewed-on: https://chromium-review.googlesource.com/1140520 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#576260}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/799e075abeea..639bc9086732 git log 799e075abeea..639bc9086732 --date=short --no-merges --format='%ad %ae %s' 2018-07-18 jmadill@chromium.org Vulkan: Pass Renderer to FramebufferVk init. 2018-07-18 tobine@google.com Roll Vulkan repos fwd as of 7/17 2018-07-18 jmadill@chromium.org Vulkan: Fix size_t warning in TextureVk. 2018-07-18 geofflang@chromium.org Vulkan: Support multiple depth stencil formats for backbuffers. Created with: gclient setdep -r src/third_party/angle@639bc9086732 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I6dd778f3ba650958f38fcb93e1ba7674309fcf01 Reviewed-on: https://chromium-review.googlesource.com/1142265Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576259}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/941ac6857d71..26d6aff1b57b git log 941ac6857d71..26d6aff1b57b --date=short --no-merges --format='%ad %ae %s' 2018-07-18 dtu@chromium.org [pinpoint] Add `android-pixel2-perf` config. 2018-07-18 nednguyen@google.com Remove stray debug print in page_test_results.py Created with: gclient setdep -r src/third_party/catapult@26d6aff1b57b The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:860091 TBR=sullivan@chromium.org Change-Id: I3c3c08e18bde2a25e9565965cea0a9e4bac8e734 Reviewed-on: https://chromium-review.googlesource.com/1142012Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#576258}
-
Joshua Peraza authored
CrashDumpObserver is used to observe information about child process exits, including non-crashes, so ChildExitObserver more accurately reflects what this class does. Also move ChildExitObserver and ChildProcessCrashObserver to the crash_reporter namespace as part of the move away from breakpad. TBR=sanfin@chromium.org Bug: crashpad:30 Change-Id: Ib480af7fbf800afd63beccee90bbee01f9ec7610 Reviewed-on: https://chromium-review.googlesource.com/1138727 Commit-Queue: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Siddhartha S <ssid@chromium.org> Cr-Commit-Position: refs/heads/master@{#576257}
-