- 03 Apr, 2020 40 commits
-
-
Reilly Grant authored
As pointed out in [1] the style guide recommends against out parameters. This change rewrites most of the helper functions in UsbServiceWin to return their value directly, using an empty string or nullopt as a sentinel for failure. [1]: https://chromium-review.googlesource.com/c/chromium/src/+/2132532 Bug: 637404 Change-Id: I54b4b807fae95f9ff93e9a02546e2748cf00b9f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135129 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#756347}
-
Wez authored
Allow media playback in CastComponents to be controlled by the owning Agent. Bug: 879317 Change-Id: I6a744faa0b236f3a856d5c4aa0b9f0846f6970ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130546 Commit-Queue: Wez <wez@chromium.org> Auto-Submit: Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#756346}
-
Becca Hughes authored
Add a histogram that records the size of the database in KB. BUG=1024362 Change-Id: I4fac8d7184b0c9e2c53554df0175512c0266a1d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125269 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#756345}
-
Adam Langley authored
This shouldn't break the release builder because the native code will still be constant across release modes. BUG=1002262 Change-Id: I86db7fd5cc23c791012ac68afad2806ef35d44bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135872 Commit-Queue: Martin Kreichgauer <martinkr@google.com> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#756344}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e4aa679c5945..390ef29999bc git log e4aa679c5945..390ef29999bc --date=short --first-parent --format='%ad %ae %s' 2020-04-03 courtneygo@google.com Enable blob cache when debugging 2020-04-03 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-validation-layers/src 499f6df688c9..9a283ae3457f (7 commits) Created with: gclient setdep -r src/third_party/angle@390ef29999bc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I8a2fc930db65ac3dd2c8097fd04e91fe22e7b285 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135801Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756343}
-
Evan Stade authored
MediaStreamDevicesController is moved from Chrome into //components/webrtc. There's a new delegate class MediaStreamDeviceEnumerator which removes the dependency on MediaCaptureDevicesDispatcher, and some Chrome-specific responsibilities are moved to PermissionBubbleMediaAccessHandler. The only interesting part of Chrome's MediaStreamDevicePermissionContext is policy handling code, which is not important for WebLayer, so it's not moved or copied. Some code for re-prompting for Android permissions is moved to the new android_permissions_util.cc, and some is moved to PermissionsClient. This is used by geolocation as well, so it obviates the need for a couple methods on the geolocation context delegate. Unlike Clank, which shows a system notification when streaming, WebLayer does not indicate when the microphone or camera is in use. TODO: tests TODO: show indication when streaming, if desired Bug: 1025622 Change-Id: Idf6c4a066ff75b581fe6df98c8b29dac9bfcc16b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121426 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#756342}
-
danakj authored
In order to incrementally split content/shell/renderer/web_test out of content_shell_lib, into web_test_renderer, we must split apart web_test_support. content_shell_lib must depend on the browser-side code in web_test_support, so we move that to web_test_support_browser. Then the dependency on web_test_support_renderer needs only be in the web_test_renderer target. Without this change, any dependency on content_shell_lib would also include web_test_support_renderer, but not web_test_renderer, which causes a build failure due to: 1) Circular includes between web_test_support_renderer and web_test_renderer 2) So web_test_renderer -> web_test_support_renderer 3) But web_test_support_renderer -/-> web_test_renderer 4) This means depending on web_test_support_renderer without going through web_test_renderer does not link. R=avi@chromium.org Bug: 866140 Change-Id: If3ae301f44bd2057fb196f39e7947607bb3da60f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134858 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#756341}
-
Anastasiia Nikolaienko authored
Bug: 1054798 Change-Id: I85aa420e6ef5f23cecaf1a8e8d035ee924d3ccac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134142Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#756340}
-
Andrew Grieve authored
Also fixes ability to run commands on apks not through wrapper scripts (must have broken a while ago). Tested with: build/android/apk_operations.py print-certs --apk-path AndroidWebview.apk --full-cert Bug: 1065270 Change-Id: I7aa047fd3570c46c1fde4f6f9e8de1895f10bae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135335 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#756339}
-
Tao Bai authored
Bounds are transformed to Android's coordinates with scroll offset. Bug: 1064420 Change-Id: I8149e45a4de72f660a52466b7f1ca0505266f3b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133239Reviewed-by:
Changwan Ryu <changwan@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Tao Bai <michaelbai@chromium.org> Cr-Commit-Position: refs/heads/master@{#756338}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f5a94cc6837a..79679990ff54 git log f5a94cc6837a..79679990ff54 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 rslawik@google.com Merge "Create linux.system_info probe reporting CpuInfo" 2020-04-03 eseckler@google.com service: Remove some DCHECKs on writer {un,}registration (part 2). 2020-04-03 eseckler@google.com service: Remove some DCHECKs on writer {un,}registration. Created with: gclient setdep -r src/third_party/perfetto@79679990ff54 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1067609 Tbr: perfetto-bugs@google.com Change-Id: I64954a1ecab133bc10f3f8a1a5ea09b89c2960b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135986Reviewed-by:
-
Owen Min authored
Disable the test as it's flaky a lot on WebKit Linux Leak. Bug: 1067650 Tbr: jarhar@chromium.org Change-Id: I7e97202eda9b35669151426530fea9accf33b704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134775 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Owen Min <zmin@chromium.org> Reviewed-by:
Joey Arhar <jarhar@chromium.org> Cr-Commit-Position: refs/heads/master@{#756336}
-
Etienne Bergeron authored
This is a step forward to remove the waitable event. This CL is removing the Waitable event member and reducing its scope only to the destructor (where it is used). R=gab@chromium.org Bug: 1065004 Change-Id: I7a813c09a52ccd428c64631bd81fc8a5d710c880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132766Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#756335}
-
Alice Wang authored
This CL migrates the usage of AccountManagerFacadeProvider.overrideAccountManagerFacadeForTests to AccountManagerFacadeProvider.setInstanceForTests. Bug: 1063866 Change-Id: I089ae89158cfdfac92638c5a718a9faf2a53b9d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129527Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#756334}
-
Regan Hsu authored
* Moved the <iron-list> into the dropdown slot instead of being the slot because of margin and padding issues (<iron-list> secretly has hidden rows it 'hides'). * Stylize colors and edges to bridge search bar and dropdown more neatly * Decrease length of search bar to specified 480px * Extra padding within icons inside the cr_toolbar_search_field will be added in another CL. * |Narrow| interaction changes will be made in another CL. Mocks: https://carbon.googleplex.com/cros-ux/pages/search-bar/style Screenshots: https://screenshot.googleplex.com/6b8WsKBROdD (no focus) https://screenshot.googleplex.com/v7gu6fR3WLA (focused) https://screenshot.googleplex.com/EOG12tdPRrE (results) https://screenshot.googleplex.com/LeG0pbmy6n8 (results narrow) Bug: 1056909 Change-Id: I3931e3dd812ae2f627d6e5349de2141ddda7d2af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131466Reviewed-by:
-
Wez authored
This is a reland of https://chromium-review.googlesource.com/c/chromium/src/+/2094989 which broke the official builders' archive generation step due to a missing dependency on each package's archive-manifest generation target, which is what actually creates the ids.txt file. Migrate the cr_package_fuchsia() rule to use the SDK-provided fuchsia_component() and fuchsia_package() rules internally. Bug: 1050703, 1067614, fuchsia:49479 Change-Id: I14c69a4567bbd954c90cd46c2fd9197ebfdee11e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134299 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
-
Mario Sanchez Prada authored
Migrate this test out of third_party/blink/web_tests/css3/filters and into the WPT-specific directory, adding links to the relevant specs and a test assertion describing its purpose. Bug: 1063749 Change-Id: I1d4b9e365ef56f8abfb0fd49c7f60598d11eb41e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133935 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#756331}
-
Garrett Beaty authored
Bug: 1067678 Change-Id: Ic632391275198d08c1a6929b242b5c5304a9c2bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134849 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#756330}
-
James Cook authored
The behavior is similar to settings-sync-account-control. The default state is a green circle. The appearance changes depending on the type of error. Screenshot: https://screenshot.googleplex.com/Vsq6ea1fCc1 Bug: 1057200 Test: added to browser_tests Change-Id: I4c1d122b7faa4a31addb8ae354637508a14b3dc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135373Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#756329}
-
Ahmed authored
This limits users from entering text either by typing or by pasting text that is beyond a max of 300-char length. BUG=1067418 TEST=Manually, added a new test. Change-Id: I3e4e5d9cba52be98fef3486c0fa5297ad9afb324 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129229Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#756328}
-
Nnamdi Theodore Johnson-Kanu authored
Before this CL some os and browser routes had the same name. This was a bit confusing. If some c++ code called the route '/privacy', it is not clear if this url is a chrome or browser subpage. A distinction needed to be made. This CL renames OS specific route PRIVACY, which is shared with browser routes to a more distinguishable name OS_PRIVACY. Allowing this bug(990169) to be unblocked. Bug: 990169 Change-Id: Id9454a84d849e2a0472e21920a032ec9c0dca361 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124233 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
-
Kevin McNee authored
Portals are embedded and cannot be interacted with by the user, so it's not useful to present a security interstitial to the user. We now use the same error page that would be used for subframes. Bug: 963522 Change-Id: I750053ec4775901266555b105a50c684e8739f7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111065Reviewed-by:
Lucas Gadani <lfg@chromium.org> Reviewed-by:
Edward Jung (EMEA) <edwardjung@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#756326}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/76336cdd0411..2af328044cf7 git log 76336cdd0411..2af328044cf7 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 mathias@chromium.org Count WTF-8 byte size without encoding Created with: gclient setdep -r src/third_party/devtools-frontend/src@2af328044cf7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1024721 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id30480d796ab99ddc36e1ac366c3db927a21a45a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135603Reviewed-by:
-
Ken MacKay authored
Bug: internal b/151990838 Change-Id: I3b852cb23f5320f69c75a9ffbdd8cdc58fecff2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134195 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#756324}
-
Peng Huang authored
Bug: None Change-Id: I722c93d7c69d23f343eee025ee06764dd068c01c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135811 Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#756323}
-
Garrett Beaty authored
Change-Id: I33f82f7b93f9815c625cf6223492d2ebc66ea254 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134193Reviewed-by:
-
Lei Zhang authored
They were added in https://crrev.com/569750 but never used. Bug: 809982 Change-Id: Idbc94dd315b487f19d4b2634c8c1936a94b38f20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134912Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#756321}
-
Peter Kotwicz authored
This CL: - Removes the remaining methods in WebApkActivity. - Introduces BrowserServicesIntentDataProvider#getActivityType() BUG=1059580 Change-Id: Ic54d36b27bc6ca8ee3f4f83419b41f53ff6ab3da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121444 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Glenn Hartmann <hartmanng@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#756320}
-
Joe DeBlasio authored
This CL adds the new target embedding parameter for Safety Tips to the field trial testing config. This is a new feature that is only ever disabled by variations right now, so nothing user-visible is changing. The parameter was added in crrev.com/c/2119374 . Change-Id: Ie233c128d814a4048d5b89aca73fb637fda492ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134951 Auto-Submit: Joe DeBlasio <jdeblasio@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#756319}
-
Salvador Guerrero authored
This CL adds DownloadService, StrikeService, TabStateDatabase and VideoDecodeStatsDB to the LevelDBClients suffix list so they can report histograms on their operations. Change-Id: Iaa10c4137fc7484019217bb9507e1d5f22cbb63e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135168Reviewed-by:
-
Garrett Beaty authored
The CI builders that some of the waterfall try builders mirror were not correctly set up to be branched and have been moved from //buckets/ci.star to //versioned/trunk/buckets/ci.star. The CI builders that some of the waterfall try builders mirror were not included in the main console and have been added. The main console included a number of builders that are not mirrors of any waterfall try builders, presumably due to the now-removed requirement that the subwaterfall categories in the main console match the subwaterfall console. Change-Id: I2185fb00756c85d93ee64ed3f9926f2fcfec21ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134696 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
-
Finnur Thorarinsson authored
This changelist also refactors the FileEnumWorkerTask to facilitate easier testing. Functions createImageCursor and shouldShowCameraTile were added so that that behavior could be overridden during testing. Also, onCancelled was added so that the test would get notified when the thread has to be shut down due to an Exception being thrown (otherwise the Roboelectric test just hangs). Bug: 656015 Change-Id: Ie601a84c6e8028a57720ddaf9802eecd194c4f4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127708 Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
-
Daniel Libby authored
These three locations in code all have a DisableCompositingQueryAsserts disabler in order to query some compositing state. However, none of these operations are necessary in CompositeAfterPaint. In PaintLayer destructor, we won't have a composited layer mapping to clear in CAP. Enforce callers of ClearCompositedLayerMapping to have ensured that HasCompositedLayerMapping is true, clean up an unnecessary CAP check and more tightly scope the DisableCompositingQueryAssert to this function. PaintLayer::StyleDidChange queries compositing state to determine whether or not to call SetNeedsCompositingInputsUpdate. That method is a no-op in CAP. PaintLayer::DirtyStackingContextZOrderLists queries compositing state in order to mark the AncestorStackingContext's CompositedLayerMapping as needing a graphics layer update, which also is not needed in CAP. Bug: 1007989 Change-Id: I552b348a3bc4d6da196eaad90b05e25a6b470c97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129090 Commit-Queue: Daniel Libby <dlibby@microsoft.com> Reviewed-by:
-
Ian Wells authored
This is a reland of b84a396f Original change's description: > Add InterestFeedV2 feature flag > > If enabled, the v2 feed stream loading task is kicked off when the NTP > or start surface is created. Not currently user-visible; this is > happening silently while the existing feed is created and shown. > > The binary size increase is mainly due to generated proto code that was > added previously but has not been linked until now. We are generating > the sources with "option optimize_for = LITE_RUNTIME;" which matches the > existing feed library and provides an acceptable speed/size tradeoff. > > Once the v2 feed component is fully launched, we can begin removing the > existing feed library. For a recent measurement of the binary size we > would eliminate by removing the existing feed library, see this CL: > https://chromium-review.googlesource.com/c/chromium/src/+/1829821. > > Binary-Size: The increase is temporary (see above). > Bug: 1044139 > Change-Id: Ic596d28e03300ad617f98f0b725cdf5ed1b0b986 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132648 > Reviewed-by: Dan H <harringtond@chromium.org> > Commit-Queue: Ian Wells <iwells@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756004} Binary-Size: Temporary. See the original CL description. Bug: 1044139 Change-Id: I820a43891b7db4e0b335a51e51fe452fe325f44c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134936 Commit-Queue: Ian Wells <iwells@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#756314}
-
Leszek Swirski authored
Adds a feature flag for enabling off-thread finalization of V8 streaming compilation tasks. This feature should reduce main-thread script compilation time. Bug: 1011762 Change-Id: I64bb986e07dae8d68dc61269e69096c368b1aac8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135629 Auto-Submit: Leszek Swirski <leszeks@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#756313}
-
Ahmed authored
DeskMiniView was changed from a Button to a generic View, but the actual button now is DeskPreviewView. The a11y node data should be initialized first by the button, before we add the extra attributes. Also announce the desk name if the miniview is selected. BUG=1067392c TEST=Manually Change-Id: I1646e0aeff95f089a9f2252532b09f2c7acdcb3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134920Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#756312}
-
Peter Kasting authored
* Replace WidgetDelegate inheritance with composition. * Make window_ private. * Null |window_| automatically (via the WidgetDelegate) when it closes. * Replace manual Layout() override with FillLayout. * Slightly less random declaration order. Bug: none Change-Id: I9179f6d581d6b90d50c324aa81fccdbf200570fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135533Reviewed-by:
Thomas Lukaszewicz <tluk@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#756311}
-
Peter Kasting authored
A service factory may check the guest/incognito bits to determine which context to use. If these bits aren't set correctly before the various context-keyed services are created, the result could be the wrong service, no service, etc. Without this, apps::LaunchServiceFactory cannot be registered properly on startup. (Fixing that will happen separately.) Bug: none Change-Id: I75d545066e382a10ff3b5f7aff2db59fa7a6e4c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135204 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#756310}
-
Connor Clark authored
Change-Id: Ie9559c780d2b87365bb2b69c2111507e2da87bf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134503Reviewed-by:
Paul Irish <paulirish@chromium.org> Commit-Queue: Connor Clark <cjamcl@chromium.org> Cr-Commit-Position: refs/heads/master@{#756309}
-
Wenbin Zhang authored
Stop uploading perf data to perf dashboard on linux fyi. This is part of moving the upload workflow to the new VM. Bug: chromium:1045256 Change-Id: Ifb09b5ff12a56254c18edf41038f3952f03518ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132961 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#756308}
-
