- 01 Dec, 2017 40 commits
-
-
Luis Hector Chavez authored
This change adds arc::WaitForInstanceReady(), so that tests that manually invoke SetInstance() can wait until the instance has been fully connected in a safe, race-free way. Bug: 782895 Test: git cl try Change-Id: I4480ab78401bb145ba99fa60a1417b2c8c6af94d Reviewed-on: https://chromium-review.googlesource.com/802191 Commit-Queue: Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#521044}
-
Joy Ming authored
There was a bug that it was not possible to cancel a notification after the download was paused. This is because in API < 21, calling stopForeground(false) would make the notification continue to be classified as on-going and therefore undismissable, which is what was happening in the pause case. This CL fixes this problem by inducing a flicker that dissociates the notification from the foreground service in the case that the Android version is API < 21. Bug: 788080 Change-Id: I9c8776d245425b0fe78aaccf7e75fcfb6e57f039 Reviewed-on: https://chromium-review.googlesource.com/802078Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Joy Ming <jming@chromium.org> Cr-Commit-Position: refs/heads/master@{#521043}
-
Philip Rogers authored
This test now matches the non-RLS expectations except for extra scrolling layers. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls Change-Id: I7eef36da8f1d7bbf04d1c9a3c0e9f6010579b814 Reviewed-on: https://chromium-review.googlesource.com/804204 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#521042}
-
Patrick Monette authored
Bug: 624061 Change-Id: I743121dc676720fd92bae8e27a9c1d7e305e54f9 Reviewed-on: https://chromium-review.googlesource.com/755523 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#521041}
-
David Trainor authored
BUG=773403 Change-Id: Ie6eb72cb6b83321c3ca2094645bab8340879da9d Reviewed-on: https://chromium-review.googlesource.com/798217Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#521040}
-
Andrew Grieve authored
Should have no change in behavior. Explicitly generating the IDs on the root node makes it clear at what point they are generated, and from what tree state. It also makes it clear that IDs are assigned only once. Before this change, there was a cache to ensure IDs were generated only once, but it's not great to rely on a cache for semantics. Change-Id: I24898c740709231e14e28dbd39e32d45945ddcec Reviewed-on: https://chromium-review.googlesource.com/803754 Commit-Queue: agrieve <agrieve@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521039}
-
Mathieu Perreault authored
Bug: 789711 Change-Id: Iae6bc67ba67f8f9e492bd065a8d75903b7cf92a9 Reviewed-on: https://chromium-review.googlesource.com/801457 Commit-Queue: Mathieu Perreault <mathp@chromium.org> Reviewed-by:
Roger McFarlane <rogerm@chromium.org> Cr-Commit-Position: refs/heads/master@{#521038}
-
Philip Rogers authored
This patch adds platform-specific expectations to this passing test. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls Change-Id: I985ce12ac1aafa21eaefa7836422e051df3e07f4 Reviewed-on: https://chromium-review.googlesource.com/803659 Commit-Queue: Philip Rogers <pdr@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#521037}
-
Michael Spang authored
Add a tracing agent and matching service so that tracing on Cast devices can collect kernel traces. The implementation is based on the CrOS tracing agent and debugd service. This is very barebones at the moment (service only depends on //base) to keep the size down. We don't have dbus, although we might be able to use mojo to manage the socket. BUG=786091 Change-Id: I76157157506628004d812db3f452a486b2962845 Reviewed-on: https://chromium-review.googlesource.com/775557Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Alex Sakhartchouk <alexst@chromium.org> Commit-Queue: Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#521036}
-
Erik Luo authored
Migrate the easily migratable tests in styles-1. Bug: 667560 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I1e73e502bbd637585d7cc34eaebac73a5cf21094 Reviewed-on: https://chromium-review.googlesource.com/802542Reviewed-by:
Will Chen <chenwilliam@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#521035}
-
John Abd-El-Malek authored
This was originally added in 440645 using a resource throttle. Since resource throttles don't work with the network service (as net runs out of process), instead do this in the same ContentBrowserClient callback which is used to add extra headers for prerendering requests. Also convert a few prefetch tests for this to use the new URLLoaderInterceptor so that they pass with the network service. Bug: 769401 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I993912ff991dda33c0fb58ae8e38f88fd16ee4ac Reviewed-on: https://chromium-review.googlesource.com/802996Reviewed-by:
Egor Pasko <pasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#521034}
-
Gheorghe Comanici authored
Bug: 697624, 787940 Change-Id: I13768958722eef31361336b504efe9e93b84c054 Reviewed-on: https://chromium-review.googlesource.com/798192Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Gheorghe Comanici <gcomanici@chromium.org> Cr-Commit-Position: refs/heads/master@{#521033}
-
Jonathan authored
Newly added SitePerProcessInternalsBrowserTest doesn't work under Viz. So I'm disabling it on the FYI bots which run viz_content_browsertests TBR=kylechar@chromium.org TEST=SitePerProcessInternalsBrowserTest Bug: 760181 Change-Id: I714080f41f7f5c45811348c8da0a28631c272a35 Reviewed-on: https://chromium-review.googlesource.com/803801Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#521032}
-
Mike Lawther authored
After an email thread to community@ it was decided to be specific about who is intended to abide by the code of conduct. Change-Id: I3efc1b8a569effd8cbd1b964d9b247fea5ce5a80 Reviewed-on: https://chromium-review.googlesource.com/799710Reviewed-by:
Rachel Blum <groby@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Brett Wilson <brettw@chromium.org> Commit-Queue: Mike Lawther <mikelawther@chromium.org> Cr-Commit-Position: refs/heads/master@{#521031}
-
Christopher Cameron authored
GpuSurfaceTracker has been removed from all other desktop platforms (in crrev.com/389975) and is not used on Mac. Remove it. Include Mac in GPU_SURFACE_HANDLE_IS_ACCELERATED_WINDOW with other desktop platforms. Define gfx::AcceleratedWidget to be uint64_t instead of NSView*. It never actually was NSView*, but was rather a sequence number used to look up a ui::AcceleratedWidgetMac. Fix a number of locations that were dangerously mixing NSView* and gfx::AcceleratedWidget (now that they are incompatible types, this is a compile error). Bug: 772576 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I29212236627c512ed6a7fe55a8cf3e613e4e593a Reviewed-on: https://chromium-review.googlesource.com/792295 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521030}
-
Sadrul Habib Chowdhury authored
If mus is not hosting viz, then it does not need to provide the connector to ozone. BUG=786453 Change-Id: I6053ca45f7338c3fa2a08ea27845f7da33117b03 Reviewed-on: https://chromium-review.googlesource.com/803838Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#521029}
-
mrefaat authored
The library Motion Animator for Objective-C is a new dependency of the Material Components for iOS. Library description: This library provides APIs that turn Motion Interchange motion specifications into animations. Bug: 785248 Change-Id: I22cbe863f6887c1098d3d33d481dc8788ef0d121 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/801978Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Louis Romero <lpromero@chromium.org> Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Cr-Commit-Position: refs/heads/master@{#521028}
-
edchin authored
Bug: 790925 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I088f7463061937cf9925284f5270568485ee0278 Reviewed-on: https://chromium-review.googlesource.com/802761 Commit-Queue: edchin <edchin@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#521027}
-
David Tseng authored
Currently, line ranges use a slightly different output path when they - have start/end on the same node - cover the node's text i.e. are not index -1 (node index) This change makes it so that we don't consider the range less than a node or use the |subNode| output path if the range surrounds the entire node's text. Test: navigate by lines (Search+up/down) over checkboxes. Output should be the same as Search+Left/Right. chromevox_tests --gtest_filter=Background*.* cover caret navigation and ensuring they still work. Bug: 784693 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I0404e11e326116e21afc2c9131a2ceeedf21e37c Reviewed-on: https://chromium-review.googlesource.com/798370Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#521026}
-
Chris Watkins authored
See the bugs and cxx post for justification and details: https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8 This change was done using clang-tidy as described here: https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md In some cases the the tool leaves behind a string of commas where it replaced a member initializer list (https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with: git diff --name-only | \ xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/' BUG=778959,778957 This CL was uploaded by git cl split. R=birenroy@chromium.org Change-Id: If7a88154bf5c630dee56754cc5f800979328d7a3 Reviewed-on: https://chromium-review.googlesource.com/799593Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#521025}
-
Avi Drissman authored
BUG=789515 TBR=alexis.menard@intel.com Change-Id: Ic5ad0bc6247ec7548887962f6d204b63da150fc6 Reviewed-on: https://chromium-review.googlesource.com/803855 Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#521024}
-
Qiang Xu authored
changes: Before operating HandleMoveWindowToDisplay, check if active window is in window cycle list. If not, no-op. Bug: 786633 Test: emulator tests and added test coverage Change-Id: I0fe06b4cac375f413b7edb4726a4a4d35536c59e Reviewed-on: https://chromium-review.googlesource.com/792512 Commit-Queue: Qiang(Joe) Xu <warx@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#521023}
-
Alice Boxhall authored
See https://chromium-review.googlesource.com/c/chromium/src/+/668309 TBR=pfeldman Bug: 514674 Change-Id: I9fae947065b657e4ae3ff8e3cb0c5b8633208b91 Reviewed-on: https://chromium-review.googlesource.com/802663 Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#521022}
-
Bret Sepulveda authored
When a LabelButton changes its label from a longer to a shorter string it would not decrease in size. This patch removes that code and cleans up the tests and related code. Bug: 790808 Change-Id: I6fce4b3ecf3335c2a9d31bc2a3ac73e18f1e92a8 Reviewed-on: https://chromium-review.googlesource.com/798323 Commit-Queue: Bret Sepulveda <bsep@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#521021}
-
Hiroshige Hayashizaki authored
No longer used after https://chromium-review.googlesource.com/801665. To make upcoming refactoring easy. Bug: 788828 Change-Id: Ie5ac6409c3d1c7ee113c90cff834a5ae6be53537 Reviewed-on: https://chromium-review.googlesource.com/786890 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521020}
-
Aga Wronska authored
Fetch information about all devices from OS in the DiskMountManager. Ignore virtual block devices. Split disk changes callback into separate callbacks for auto mountable and fixed storage disks, so clients that are only interested in auto mountable devices do not need to do additional filtering. Bug: 420633 Change-Id: I3380c1a0ff49d7167760633cc3ed30d151170a08 Reviewed-on: https://chromium-review.googlesource.com/756273 Commit-Queue: Aga Wronska <agawronska@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#521019}
-
Maxim Kolosovskiy authored
Bug: 699530 Change-Id: I6325ed2be5868d519c5b0d0cb720d09e7b80da4d Reviewed-on: https://chromium-review.googlesource.com/759792 Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521018}
-
Yoshifumi Inoue authored
This patch makes |LayoutInline::LinesBoundingBox()| to work with LayoutNG by utilizing |NGInlineFragmentIterator| to collect box fragments associated to |LayoutInline|. This patch also changes |ShouldCreateBoxFragment()| to return |true| for producing box fragements for plain SPAN to avoid using "culled inline box", which is collected by traversing descendants of layout tree. Note: Exclude master.tryserver.chromium.linux:linux_layout_tests_layout_ng Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ia71db55d551a8ee8e5e36019ab94e7fb18479198 Reviewed-on: https://chromium-review.googlesource.com/768599 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#521017}
-
Chromium WPT Sync authored
Using wpt-import in Chromium dabac34e. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/6555 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hta@chromium.org: external/wpt/webrtc jsbell@chromium.org: external/wpt/resources mkwst@chromium.org, andypaicu@chromium.org: external/wpt/content-security-policy TBR=qyearsley No-Export: true Change-Id: I6f3b9d5038ac5bf49a87c119a402e62bcfe2a84c Reviewed-on: https://chromium-review.googlesource.com/803116 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521016}
-
sczs authored
Adds a Toolbar Button that will be used to contract the toolbar/omnibox. The contract button is only shown when the Toolbar is expanded. A simple animation is used. Currently the button has no functionality, that will be added in a follow up CL. Screenshot: https://drive.google.com/open?id=1UIiS-Y1JTKwuU7lrQACtDK8RL1g10_7K Bug: 790763 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Icf2d7e3b866c2f87f7346556f41328ba19044bfd Reviewed-on: https://chromium-review.googlesource.com/802831 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#521015}
-
Christos Froussios authored
We now have a general implementation for dedicated TaskRunners for OSCrypt's backends. The custom threading implementation for KeyStorageKeyring can be removed and replaced with the general one. Bug: 782851 Change-Id: I61b0df8568504d4160bbcce7301e99fbdb86609a Reviewed-on: https://chromium-review.googlesource.com/804094Reviewed-by:
Vaclav Brozek <vabr@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#521014}
-
Xing Liu authored
Currently it's flaky on Android, other platforms seem fine. Disable for now for further investigation. Bug: 786626 Change-Id: I1399f8212ab3a6c58959032313301b6f8d4a3714 Reviewed-on: https://chromium-review.googlesource.com/804134Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#521013}
-
Tom Anderson authored
BUG=787223 R=dpranke@chromium.org Change-Id: I1c3aada842bba899c20d5e2c1b0dceb818f118d2 Reviewed-on: https://chromium-review.googlesource.com/784093Reviewed-by:
Brett Wilson <brettw@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#521012}
-
rbpotter authored
Also add a test to verify, and only show rasterize checkbox on non- Windows/Mac. Bug: 773928 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I430f138db14cbe2e456023ba93292ddbd5c49dbe Reviewed-on: https://chromium-review.googlesource.com/802356 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#521011}
-
rbpotter authored
All observers of print job notifications have this notification commented with don't care, and don't do anything with it. Remove. Bug: None Change-Id: Ia669135a311ad1fc3090bb7de974c4a0718a4d0a Reviewed-on: https://chromium-review.googlesource.com/802755Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#521010}
-
Nathan Bruer authored
Overrides will now change projects before the navigation happens allowing it to rewrite requests when navigating cross-origin. R=caseq,lushnikov,einbinder BUG=754371 Change-Id: I0201a2a714c06bc7d4babb59e6d02b51c8e1f5e3 Reviewed-on: https://chromium-review.googlesource.com/799682Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Blaise Bruer <allada@chromium.org> Cr-Commit-Position: refs/heads/master@{#521009}
-
Greg Thompson authored
This reverts commit a75a06d7. Reason for revert: DCHECK in WebServiceWorkerRegistrationImpl::OnConnectionError being hit on Windows debug interactive_ui_tests; see https://crbug.com/790935. Original change's description: > [ServiceWorker] Detach lifetime of SWRegistrationObjectHost from SWProviderHost > > This is a follow-up of > https://chromium-review.googlesource.com/c/chromium/src/+/773452. > > After this CL: > - SWRegistrationObjectHost lifetime is strongly bound on its binding > set, and independent with SWProviderHost lifetime. > - the mapping in SWProviderHost does not own SWRegistrationObjectHosts > anymore and has only one functionality: reuse registration object > host per registration id. > - The complex lifetime management of WebSWRegistrationImpl brought by > https://chromium-review.googlesource.com/c/chromium/src/+/732998 > becomes simpler, there is only one destruction scenario now: > Blink GC removes all references to |this|, |this| closes > SWRegistrationObjectHost Mojo connection causing the > content::SWRegistrationObjectHost in the browser process destroys > (closes SWRegistrationObject Mojo connection), then |this| is > deleted by the error connection handler. > > BUG=758151 > > Change-Id: I21c0f0eef7e93f723e2a37ec02f1c43bf84385bf > Reviewed-on: https://chromium-review.googlesource.com/778360 > Commit-Queue: Han Leon <leon.han@intel.com> > Reviewed-by: Matt Falkenhagen <falken@chromium.org> > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#520479} TBR=falken@chromium.org,kinuko@chromium.org,rockot@chromium.org,yzshen@chromium.org,shimazu@chromium.org,leon.han@intel.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 758151 Change-Id: I843abecbab693cae6484477cfadcf0d98e12b4ad Reviewed-on: https://chromium-review.googlesource.com/803516Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#521008}
-
Min Qin authored
There is no reason for this class to be RefCountedThreadSafe. All the posted tasks doesn't needs to be member functions. And the scoped_refptr could get deleted after DownloadManager is destroyed. This causes flakiness shown in https://chromium-swarm.appspot.com/task?id=39ca6d4e03fa4210&refresh=10&show_raw=1 Also switched to use RunLoop as QuitWhenIdleClosure() is deprecated. BUG=754679 Change-Id: I7eb5084b4f623929e2553487c6eec34352e72c98 Reviewed-on: https://chromium-review.googlesource.com/794832 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#521007}
-
Klaus Weidner authored
Add a wrapper around SlidingAverage that uses TimeDelta instead of integer microseconds, and use that for timing calculations in VrShellGl. Get the nominal vsync interval based on the display refresh rate in AndroidVSyncHelper and use that instead of the last interval in timing heuristics, this avoids glitches when the last interval is a >1x multiple of the expected interval due to dropped frames. Bug: Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id8fa9c46560f6aed80aa6457f98aee63d0c4706e Reviewed-on: https://chromium-review.googlesource.com/797236Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Klaus Weidner <klausw@chromium.org> Cr-Commit-Position: refs/heads/master@{#521006}
-
Chris Watkins authored
See the bugs and cxx post for justification and details: https://groups.google.com/a/chromium.org/forum/#!topic/cxx/RkOHzIK6Tq8 This change was done using clang-tidy as described here: https://chromium.googlesource.com/chromium/src/+/lkcr/docs/clang_tidy.md In some cases the the tool leaves behind a string of commas where it replaced a member initializer list (https://bugs.llvm.org/show_bug.cgi?id=35051). They were cleaned up with: git diff --name-only | \ xargs sed -E -i 's/(^\s*|\)\s*):[ ,]*= default/\1 = default/' BUG=778959,778957 This CL was uploaded by git cl split. R=rch@chromium.org Change-Id: Ia760b6366e6434d821476c23999963ddc5553a36 Reviewed-on: https://chromium-review.googlesource.com/799533Reviewed-by:
Bence Béky <bnc@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#521005}
-