- 01 Jul, 2020 40 commits
-
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: Ib61cf9be8fbc09fabd8765b8177c1b34d84494be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276565Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784329}
-
Miyoung Shin authored
This CL fixes nullptr access in prerender::PrerenderObserverList::RemoveObserverForFrame since RenderFrame is destroyed first before ChromePluginPlaceholder dtor that removes an observer for RenderFrame is called. Fuzzer report: https://clusterfuzz.com/testcase-detail/4966404840816640 Bug: 1099851, 1100030, 1100780 Change-Id: Id0db5a3c6d3fc9018a120d7ad0b0d3125d875302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2272179Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#784328}
-
Lei Zhang authored
Take the name suggestion from several reviewers while converting base::DeleteFile(path, true) calls. Tbr: blundell@chromium.org,jamiewalch@chromium.org,jkarlin@chromium.org,kinuko@chromium.org,reillyg@chromium.org,sdefresne@chromium.org,xdai@chromium.org Bug: 1009837 Change-Id: Ie0a3bbe7bae4844f4f29a4ffd63fd032128e599d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274676 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#784327}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/14453b7a67ac..2d6b37bbda59 2020-07-01 pcc@google.com Start reserving x18 by default on Android targets. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I895eb3d1f2fdd1771ca4cfb15c8aae7b07a7f677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276630Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784326}
-
Jan Krcal authored
This CL is a refactoring before a minor update of the design of the profile menu. This CL brings no behavioral change. This change is needed because in the new design, the layout of the profile name heading and the layout of the identity info are more intertwined and thus it is opportune to set them in one function. Bug: 1099286 Change-Id: Iad6f03bd3ff7fa1e17cc1cb61b2d76c952c1394f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274626 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#784325}
-
Owen Rodley authored
Bug: 1094768 Change-Id: Ibcfa475f90241ab7d9da654b0b14d8f2c1bcd451 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274379 Commit-Queue: Owen Rodley <orodley@chromium.org> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Owen Rodley <orodley@chromium.org> Cr-Commit-Position: refs/heads/master@{#784324}
-
Ian Kilpatrick authored
The logic introduced for CalculateChildAvailableSize was designed to have the correct value for an element with: "<div style="position: relative; left: 50%; top: 50%;></div>" E.g. the percentage based left/top would resolve against the available size. However this broke text alignment within anonymous-blocks which require the child-available-size to be based on the actual inline-size. This patch uses the actual inline-size in the inline direction, but keeps the logic for block direction. This will mean that for postiion:relative calculations we'll use the Percentage inline-size, and Available block-size for resolving percentages. Bug: 1100203 Change-Id: I83c5281c5de9f9fd40f1bfed54e627dff5bb0600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274359Reviewed-by:
David Grogan <dgrogan@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#784323}
-
Noel Gordon authored
Encapsulate the drag hover time in a helper dragTargetHoverTime_. Keep the 2000ms default. But make it shorter when window.IN_TEST, to reduce drag drop integration test times by the difference (1500ms) if they do check that drag hovering over a directory-tree tab makes the file-list navigate (change directory) after the hover time out. Covered by existing tests: transfer.{DragAndDrop,DragAndHover} Bug: 1002394 Change-Id: I6a1c3f61c43a602d362271acb5dd031d66058b1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275569 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#784322}
-
Kent Tamura authored
This CL reduce the estimated pre-processed size of parkable_string.h by 1.2MB. This CL moves DiskDataAllocator::Metadata out to its own header file, and removes mojo dependency from parkable_string.h. This CL has no behavior changes. Bug: 242216 Change-Id: I6f3278ef7cb3c9ceaf1776d14efb527fa34adfe9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275566 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#784321}
-
Anand K Mistry authored
The function is unused. Bug: None Change-Id: Iacc20257e5636af4b38644ec7ab8c099d0310975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275925 Commit-Queue: Anand K Mistry <amistry@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Anand K Mistry <amistry@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#784320}
-
Joey Scarr authored
I've left the section about sheriffing philosophy, since that's also useful for non-sheriffs. Bug: 1095911 Change-Id: I9e97cc1951e5cc96fe9aa8ccc42e14c875f0f0b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274481 Commit-Queue: Joey Scarr <jsca@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#784319}
-
Giovanni Ortuño Urquidi authored
We do this by changing three things: 1. Set `composite` to `true`. From Typescript docs: ``` The composite option enforces certain constraints which make it possible for build tools to quickly determine if a project has been built yet. ``` This results in the TypeScript compiler generating two new files for each mojom target: - Declaration files (.d.ts) which in the Mojo case describes the exported Mojo interface. - tsBuildInfo files (.tsbuildinfo) which store incremental compilation information as a part of composite projects which enables faster building of larger TypeScript codebases. 2. Adding `references` to tsconfigs, to tell the compile that a target depends on other targets. 3. Adding `/// <reference>` to non-es-modules files, to tell the compiler which files that file references. Somewhat surprisingly adding `references` to the tsconfig was not enough. This results in: 1. Each mojom target getting compiled only once, independent of how many other targets depend on it. 2. The compiler complaining if we forget to add a mojom target to `references` and if we forget to add `/// <reference>`s for files in non-es-modules files. 3. When compiling a mojom target, the compiler only attempts to compile the specific target i.e. it doesn't try to compile its dependencies. It's up to ninja to trigger the compilation of dependencies. If a dependent target hasn't been compiled yet, the compiler will throw an error. This ensures that we don't accidentally forget dependencies in our generated bindings. The upside of this, is that compilation order is controlled by gn and ninja. The downside is that we need to run an instance of the compiler for each target and we don't get to take advantage of the --build flag, which changes the compiler to act more like an orchestrator than a simple compiler. Bug: 1002798 Change-Id: I831aaaa9a0f159d6e90b9ec698ba5cc1f7653c4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274387Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#784318}
-
Kent Tamura authored
This CL reduces the estimated pre-processed size of local_frame_view.h by 1.0MB. This CL has no behavior changes. Bug: 242216 Change-Id: I95bc2d99b955b922f28356789da4702d31128ec5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275977 Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#784317}
-
Noel Gordon authored
Use "directory" instead of "folder". Elaborate the Crostini comment re: it is actually a fake entry. However, the reason why we need to change immediately to its directory when it is a fake entry is not explained, and is potentially no longer relevant now Crostini is controlled by an enable flag looking at CL:2264086 No change in behavior, no new tests. Bug: 1002394 Change-Id: Ida7177b052f6fcb8db47e6181ffc4c5d708604c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275280Reviewed-by:
Alex Danilo <adanilo@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#784316}
-
Noel Gordon authored
Remove a stray extra line. Add some in canPasteOrDrop_ to end the code squishing competition and instead promote code readability. No change in behavior, no new tests. Tbr: (mr-no-nbn) adanilo Bug: 1002394 Change-Id: I038646234385c7b0dd73b72752f8c5a160e70877 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275161 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Auto-Submit: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#784315}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3f5d1ca9a8eb..9e100526c3df 2020-07-01 dberris@chromium.org sched: Show the queue in job results If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:981429 Tbr: wenbinzhang@google.com Change-Id: Iff5e096042bebac0ddac66f83451f851d619170d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276626Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784314}
-
Ella Ge authored
All usage has been updated to base::Bind{Once,Repeating} and base::{Once,Repeating}Callback respectively. Fix: 1007641 Change-Id: Ieb7aaacdfa2df52a51092cc332e09951db3c3758 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275103 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#784313}
-
Melissa Zhang authored
This CL adds a temporary button to the toolbar that will be used to trigger the sharesheet during development. Bug: 1097623 Change-Id: Icb9029fbd508e6e358bd82381886dbd7b6050cae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2262400Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Melissa Zhang <melzhang@chromium.org> Cr-Commit-Position: refs/heads/master@{#784312}
-
Robert Sesek authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: I3292ad8d76e9b25e56f01f52db8c3fc9aedf3a76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276660 Auto-Submit: Robert Sesek <rsesek@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#784311}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I7d5df44976ba63862d848176cc4eed2d90c19d9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277481Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784310}
-
Ella Ge authored
All usage has been updated to base::Bind{Once,Repeating} and base::{Once,Repeating}Callback respectively. Fix: 1007638 Change-Id: I31ee3da38efebdd5cf402d3faa79d42dd2bed095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275471 Commit-Queue: Ella Ge <eirage@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#784309}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I04c835a7e5557782e5b3e77fe6df20b061943196 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277408Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784308}
-
Haiyang Pan authored
Bug: 1098927 Change-Id: Ibd209ea32d8c47e115499c20741ef4dc9e851924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277051 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#784307}
-
Rachel Carpenter authored
CIPD package: https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/Uu11Q1wqNSVwkH2IvVt8kSs867Nu-6mf0O9kxpQfckAC Release notes: http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202006240800_RC01.html Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Change-Id: I1ca4c636d0049e09fc0c7517d7817862a838c19e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277364Reviewed-by:
Patti <patricialor@chromium.org> Commit-Queue: Rachel Carpenter <carpenterr@chromium.org> Cr-Commit-Position: refs/heads/master@{#784306}
-
Kyle Milka authored
Refactor SendTabToSelfNotificationReceiver out of NotificationManager. Bug: 1090917 Change-Id: I8cd10e739af093dc35138a8ac4478d4f251ce639 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261174 Commit-Queue: Kyle Milka <kmilka@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#784305}
-
Robert Sesek authored
GN recently added support for Apple frameworks to link, rather than overloading the libs lists. This pulls .frameworks out of the libs lists, so that GN can stop supporting .frameworks in libs in the future. Bug: 1052560 Change-Id: I88e2c0191af5e52e86b4a27e0caba52bd960e66a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276761 Auto-Submit: Robert Sesek <rsesek@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#784304}
-
Koji Ishii authored
This patch changes the iterator of |PostLayoutChildren| to eliminate fragments for destroyed or moved |LayoutObject|. The root cause is probably pre-paint with dirty tree, and this patch does not address that, but makes fragment traversal safer. This patch is speculative. Bug: 1099863 Change-Id: Ia78d55cc43a50f54f4b547ae8febc025770ac004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275944Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#784303}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fe7e74b3a786..77d7d5ea92ca 2020-07-01 mtklein@google.com with sanitizers, JIT but ignore it 2020-06-30 fmalita@chromium.org [skottie] Fix wipe effects for images If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC ethannicholas@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ethannicholas@google.com Change-Id: Ifa647b7fc0203e90de7c9e4cb01cf16228af6f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277270Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784302}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/d0779351..c3dc5798 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I4835fc7b5ba8acf937d47dd794db01c54ffb3161 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277240Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784301}
-
Gyuyoung Kim authored
FrameToken can be available in RenderFrameImpl. So, we don't need to get it from browser through Mojo method. This CL removes the method and related tests, then just return the frame token through the media::RoutingTokenCallback. - RenderFrameImplTest.TestOverlayRoutingTokenSendsLater - RenderFrameImplTest.TestOverlayRoutingTokenSendsNow Bug: 1093917 Change-Id: I52cb4b09f497062cff3279d788bf8c1bce517dc1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269986Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#784300}
-
dpapad authored
Fixed: 1100429 Change-Id: I100e069dc5dc249647f7ed5697d8e36bbce932af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276762 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#784299}
-
Alexey Baskakov authored
This mimics the missing logic from ExtensionAppsBase::Launch() method specified for bookmark apps. Note: We should not do RecordAppWindowLaunch because web_app_launch_manager_->OpenApplication() does it. Bug: 1062885 Change-Id: Ie5a444692b9de98087db899a73a139950cd537f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277367Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#784298}
-
Koji Ishii authored
This patch changes to associate floating |LayoutObject|s to |NGFragmentItem| using |FirstInlineFragmentItemIndex|. The index is used for many purposes, but one of them is to mark destroyed or moved |LayoutObject| in |NGFragmentItem|. Because floating objects are stored in |NGFragmentItem|, they need to be indexed to mark correctly. Also changes |LayoutBlockFlow:: SetShouldDoFullPaintInvalidationForFirstLine| to skip items for destroyed or moved |LayoutObject| because it may be called on dirty tree. Bug: 1100900 Change-Id: If35bf2c77b9a46a9ba598e6785926f6b0e1c5455 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275373 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#784297}
-
Xida Chen authored
This CL converts base::Closure to base::RepeatingClosure in banners/ folder. This is a code health CL, no behavior change. Bug: 1007635 Change-Id: I51130356d46394c0a9b57552adf879628d288902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2273459Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#784296}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=pbommana@chromium.org Change-Id: I7ac05ad4e8817a78ca15f868ba9a113b3d457929 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2277443Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784295}
-
Jesse McKenna authored
This change removes the SlowDCTimerInterruptsWin experiment and makes its behavior the default, lowering the raised timer-interrupt frequency to 125 Hz when on battery power. This is expected to result in a ~4% system power savings (per crbug.com/927165). The SlowDCTimerInterruptsWin experiment has been gradually rolled out through the Canary, Dev, Beta, and Stable channels, and has currently been active on 50% of the Stable channel for four weeks. It has shown no regression to its guardrail metric, FirstContentfulPaint.OnBattery. Background: Chrome frequently raises the system's global timer-interrupt frequency in order to increase responsiveness for timers. Windows handles timers by checking whether the timer has finished on a given interval; this is called the 'timer-interrupt frequency'. Increasing the timer-interrupt frequency is done by many programs to increase the granularity at which timers can be set, so waiting processes can be notified more accurately (which in some cases will mean more quickly) when their timers have finished. However, raising the timer-interrupt frequency makes the system consume additional power, so should be done sparingly. Chrome currently sets the following limits for interrupt frequency depending on whether the system is on battery power: Default, not raised: 64 Hz Raised, AC (wall power): 1000 Hz, i.e. kMinTimerIntervalHighResMs = 1 Raised, DC (battery power): 250 Hz, i.e. kMinTimerIntervalLowResMs = 4 This change halves the raised frequency of interrupts when on DC power: Raised, DC (battery power): 125 Hz, i.e. kMinTimerIntervalLowResMs = 8 Bug: 927165 Change-Id: I321599c7ce679671b29804660d5589dc88df6bf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2265402Reviewed-by:
kylechar <kylechar@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Jesse McKenna <jessemckenna@google.com> Cr-Commit-Position: refs/heads/master@{#784294}
-
zhaoyangli authored
This is a reland of 6a309aad Original change's description: > [iOS] Remove all EG1 test targets and related GN components. > > Removed all test targets, EG1 specific test utils in GN files. > Removed gni files to build EG1 targets. > Removed build files in ios/third_party/earl_grey. > > Bug: 1046369 > Change-Id: Iec1d60fa40d10969c4e6e6840f2983b02c3170dc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275353 > Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> > Reviewed-by: Rohit Rao <rohitrao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#784204} Bug: 1046369 Change-Id: I1690dcd79d4848cf042c06cfe2b479ed37b2df17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276682Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Zhaoyang Li <zhaoyangli@chromium.org> Cr-Commit-Position: refs/heads/master@{#784293}
-
Will Cassella authored
This CL revamps the way a VideoDecoder or AudioDecoder is selected to decode a given VideoDecoderConfig or AudioDecoderConfig, respectively. The goal is to first filter and rank available decoders based on their high-level attributes ("IsPlatformDecoder", "SupportsDecryption"), rather than attempting to initialize them in the order they're submitted. The result is that an initial decoder is selected more efficiently, and the decoding system can gracefully transition between platform and non-platform decoders if the config changes mid-stream. The full design doc is available at: go/predicate-based-decoder-selection Bug: 684792 Change-Id: I8660e7315881b2bea44bf52afb4505f979a43728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247331 Commit-Queue: Will Cassella <cassew@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#784292}
-
Yoshifumi Inoue authored
This patch changes dependency graph of |LayoutNGFragmentItem| to make |ScopedLayoutNGForTest()| to work with both LayoutNG and legacy layout for running blink units for legacy layout tree. When we use "implied_by", |LayoutNGEnabled()| is implemented as: static bool LayoutNGEnabled() { if (LayoutNGFragmentItemEnabled()) return true; ... features in "implied_by". return is_layout_ng_enabled_; } Change-Id: Id65a621bc6b041755b7897f9e5698aff26369370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2275952 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#784291}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I03bbba060b79d8597f643dff33c4a5d428232321 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2276686Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#784290}
-