Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 20 Aug, 2014 2 commits
    • dtrainor@chromium.org's avatar
      Fix thumbnail store crashing on loading old files · 0409d5b0
      dtrainor@chromium.org authored 
      - Was loading thumbnails in little endian, but since the files were from java's
output stream they were in big endian.  This was causing all sorts of issues
with old thumbnails.
- Added back ETC1 header and fixed the file format to match the old version.

BUG=398319

Review URL: https://codereview.chromium.org/486093002

Cr-Commit-Position: refs/heads/master@{#290708}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290708 0039d316-1c4b-4281-b951-d872f2087c98
      0409d5b0
    • asvitkine@chromium.org's avatar
      Remove DCHECKs that no longer reflect reality. · b61c9ed8
      asvitkine@chromium.org authored 
      It used to be that CreateEntropyProvider() was only
called once in a process, during the init sequence,
and then never again. So previously, these DCHECKs
could never fire by virtue of the function always
being called once.

Now that this function is called by VariationsService
when simulating new variations seeds, it will be
called multiple times during the process life time.
It's perfectly valid to return an entropy provider
that uses a different entropy source in that context
(e.g. post changing your UMA opt-in setting), since
that's exactly what the simulation code wants (i.e.
it simulates what will happen on a restart).

So simply remove the checks, since their conditions
no longer hold.

BUG=405010

Review URL: https://codereview.chromium.org/492463002

Cr-Commit-Position: refs/heads/master@{#290706}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@290706 0039d316-1c4b-4281-b951-d872f2087c98
      b61c9ed8
  3. 19 Aug, 2014 38 commits