- 08 Dec, 2020 40 commits
-
-
Alice Wang authored
This CL cleans up redundant GoogleActivityController. Bug: 1153038 Change-Id: I7a81ce074648c2830cb539d029784068eeb73ffa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577197 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#834648}
-
sauski authored
Replace the stub functions for conversion measurement on the PrivacySettingsSandbox class with implementations that respect both the privacy sandbox preferences and cookie content settings. Bug: 1152336 Change-Id: I1d7baed13f9830f95f389d26d80629cec17e2988 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569653Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#834647}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/03c2a0ffe52f..e94373d60dc3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC engedy@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: engedy@google.com Change-Id: I8b3596d44255fa22405935cb772e72581023f185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578779Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834646}
-
Hitoshi Yoshida authored
The test failure happens only on BF cache bot. Dropped the flakiness expectation from general TestExpectations to catch actual failures. Bug: 1155125 Change-Id: I0966a5b76962b60e24870640249c65faeec4bdb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576224 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#834645}
-
Richard Knoll authored
This flag will be enabled on M88 Beta to launch the Mute Notifications feature on Desktop platforms. This will prevent potentially sensitive notification content from showing up on full-screen-share recordings. Approved launch bug for Beta: crbug.com/1133886 Bug: 1133886 Change-Id: I4a549738a02d73883c87731e4cef1ce846a30de8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577224Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#834644}
-
sandromaggi authored
This changes the |SelfDeleteFullCardRequester| to respond with adding details to the failure status according to the the result it got from the |FullCardRequest|. The |UseCreditCardAction| does not treat a failed status, but passes it on as the response to the action. Bug: b/174304769 Change-Id: Idcad69cf74eab14a9a59d5b6dc1ea166b230db67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577218 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#834643}
-
Minggang Wang authored
URLLoaderClientImpl is an implementation of network::mojom::URLLoaderClient and used by ResourceDispatcher only to receives messages from a single URLLoader, it couples with the ResourceDispatcher tightly. As part of the OnionSoup project, this patch implements: 1. Moves URLLoaderClientImpl to third_party/blink/public/platform/ and decouples it from the ResourceDispatcher by adding an interface of WebURLLoaderClientObserver. 2. Moves url_loader_client_impl_unittest.cc into blink and decouples it from the dependency of TestRequestPeer by implementing a MockWebURLLoaderClientObserver that mostly inherits the functionality of TestRequestPeer. So, after this patch, the TestRequestPeer will be only used by the unit test of ResourceDispatcher and could be removed with the ResourceDispatcher together eventually. Change-Id: I08793d58623713ee1fc40f9e2395e19ea141f952 Bug: 1110032 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2560678Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Minggang Wang <minggang.wang@intel.com> Cr-Commit-Position: refs/heads/master@{#834642}
-
Keishi Hattori authored
When BackupRefPtr is used for LocalStorageImpl::StorageAreaHolder::area_ptr_, the destruction order of the fields causes a null dereference. ~StorageAreaHolder() ends up calling StorageAreaHolder::PrepareToCommit() which tries to use area_ptr_ without a null check Bug: 1080832 Change-Id: Iff06bbf440eb5a3d26226c85b13b36ac037f1fca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2564932Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Keishi Hattori <keishi@chromium.org> Cr-Commit-Position: refs/heads/master@{#834641}
-
Luciano Pacheco authored
Generate the JS modules for the following elements: * <xf-button> * <xf-circular-progress> * <xf-display-panel> * <xf-panel-item> And their test: files_xf_elements.unittest.m.js. Bug: 1133186 Change-Id: I22c71f6a6e648c4a1b027ef1766eb4df060f9f93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576299 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Jeremie Boulic <jboulic@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#834640}
-
Victor Hugo Vianna Silva authored
The feature has been launched to 100% Stable for over a month [1], so this CL removes the feature toggle. Besides this, some instances of base::RepeatingClosure() in profile_sync_service_unittest.cc are replaced with base::DoNothing(). [1]https://groups.google.com/a/google.com/g/cr-rel-notify/c/_DOaHr_-x10/m/CA_P823xAQAJ https://groups.google.com/a/google.com/g/cr-rel-notify/c/mOOb_eXMgy4/m/aRpz0POPAAAJ https://groups.google.com/a/google.com/g/cr-rel-notify/c/bJ323M0Nrr4/m/jVRaVJWIBAAJ https://groups.google.com/a/google.com/g/cr-rel-notify/c/ad3g3moxG4k/m/n-KJcTuTAAAJ Bug: 1140447 Change-Id: Ifc72d6a35402d72bb5935a3dbc2d838fb5855bcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2489894Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#834639}
-
Heng-Ruey Hsu authored
Simply rename *_halv3 to *_delegate to keep git history. Add an intermediate layer to prepare further refactor to support multiple streams. Bug: b:151047537 Test: Manually Change-Id: Ic2db36b003206972aabd70a5ceafd00e9f8f1c3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351931 Commit-Queue: Heng-ruey Hsu <henryhsu@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Reviewed-by:
Wei Lee <wtlee@chromium.org> Auto-Submit: Heng-ruey Hsu <henryhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#834638}
-
sauski authored
Fixes an issue where the mouse interactions with the toggle buttons under a settings-collapse-radio-button which has been disabled by poliy do not work. Bug: 1156264 Change-Id: Ifac3bd2767378b9f05ad95586ec4a46ea262a561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577225Reviewed-by:
Rainhard Findling <rainhard@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#834637}
-
Daniel Vogelheim authored
Fix-it week: Fix failing WPT test. Change-Id: I3bf43d39f19bc9b690bb943185e7ddb8961699da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574951Reviewed-by:
Yifan Luo <lyf@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#834636}
-
Daniel Vogelheim authored
Fix-It week: The test passes, but will then report an error in the test harness, because the string chosen for the example test is not actually a valid script. If we simply return "0" - which is valid JS - the bug disappears. (The test doesn't care about the script anyhow, only about whether it's accepted as input ot not.) Change-Id: Ie36c27965494f71b796176d3818aefd41b3067ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574953Reviewed-by:
-
Side Yilmaz authored
This CL passes the correct profile in LayerTitleCache by accessing profile with tab#isIncognito boolean. Bug: 1048632 Change-Id: I9555f637a890ea5052ac044667d953d221d0f84a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2567226Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#834634}
-
Balazs Engedy authored
This reverts commit 09825450. Reason for revert: `generate_build_files` failure on `Cast Audio Linux` builder: ERROR at //ui/gfx/linux/BUILD.gn:8:1: Assertion failed. assert(use_x11 || ozone_platform_drm || ozone_platform_wayland || ^----- See //media/gpu/chromeos/BUILD.gn:92:5: which caused the file to be included. "//ui/gfx/linux:drm", ^------------------- Original change's description: > media/platform_vf_utils: Handle null GMB factory. > > This CL handles a null GpuMemoryBufferFactory in > AllocateGpuMemoryBufferHandle() so that the caller is not obligated to > pass a valid factory. This is in preparation for follow-ups CLs to > remove the need for video encode accelerators to have access to a > GpuMemoryBufferFactory. > > When the GpuMemoryBufferFactory is null, we just use the render node > directly to allocate a native buffer object and then we wrap it into a > GpuMemoryBufferHandle. > > So, why do we still keep the option to have a non-null > GpuMemoryBufferFactory? This is because that path is still useful in the > decoding case: when a buffer is created with the GpuMemoryBufferFactory, > the corresponding NativePixmap is cached [1]; eventually, a SharedImage > needs to be created and to do so we pass the GpuMemoryBufferHandle > obtained from the factory [2]; when the SharedImage system needs to > create the GLImage for the buffer, it passes the handle to the > factory [3] which in turn uses it to look up the cached > NativePixmap [4]. This saves us from going through a gbm_bo_import() > (which also implies a thread hop to the DRM thread). > > So, in conclusion, for buffers that need to be displayed later, it's > still better to use the GMB factory owned by the GpuServiceImpl. For > encoders this is not the case. > > [1] https://source.chromium.org/chromium/chromium/src/+/master:gpu/ipc/service/gpu_memory_buffer_factory_native_pixmap.cc;l=319;drc=d81c5852498699fe3cd812e78d31c77c28e29281 > [2] https://source.chromium.org/chromium/chromium/src/+/master:media/gpu/chromeos/mailbox_video_frame_converter.cc;l=355-359;drc=d81c5852498699fe3cd812e78d31c77c28e29281 > [3] https://source.chromium.org/chromium/chromium/src/+/master:gpu/command_buffer/service/shared_image_backing_gl_texture.cc;l=355-356;drc=d81c5852498699fe3cd812e78d31c77c28e29281 > [4] https://source.chromium.org/chromium/chromium/src/+/master:gpu/ipc/service/gpu_memory_buffer_factory_native_pixmap.cc;l=164-172;drc=d81c5852498699fe3cd812e78d31c77c28e29281 > > Bug: b:173167846 > Test: video.EncodeAccel.h264_720p_nv12_dmabuf on elm > Change-Id: I7b730eb843da7503c61bffe30dce7a5ce51dec60 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2568937 > Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org> > Reviewed-by: Miguel Casas <mcasas@chromium.org> > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#834608} TBR=mcasas@chromium.org,hiroh@chromium.org,andrescj@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Ibaf9e8a6e473a3b566ee9d5dd45b25a5f5283c14 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b:173167846 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578836Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2d4ece529113..7843c257dbae 2020-12-08 tvanderlippe@chromium.org Upgrade third_party/marked to 1.2.5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5d9c8cb370d91797d70b3265a11e784701dc0386 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578777Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834632}
-
Yu Su authored
Add UKM logging for Lens chip shown and action: - record Lens chip shown event in the context menu metric "ContextMenuAndroid.Shown" - record Lens chip action in the context menu metric "ContextMenuAndroid.Selected" with an action id ShopWithGoogleLensChip Add an UMA histogram for Lens Prime errors: - The histogram is used to record errors occurred in Lens Prime session processing. https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/3412247 - The error codes are integer constants defined by the Lens SDK. Change-Id: Ibfa4134ee2d29b1d010654c7762bc820eb528ad4 Bug: b/166648354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2551256 Commit-Queue: Yu Su <yusuyoutube@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ben Goldberger <benwgold@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Sinan Sahin <sinansahin@google.com> Cr-Commit-Position: refs/heads/master@{#834631}
-
Nohemi Fernandez authored
Currently the SigninPromoViewMode uses implicit naming scheme cold/warm to represent the sign-in state. With the addition of a sync promo it becomes necessary to be more precise with the state of accounts on the device that will be represented in this enum. Bug: 1151289 Change-Id: I88e7e940ce8248c4b6f3d6e03c916f6ed5866df9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574737Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#834630}
-
Camillo Bruni authored
Delay calling into V8 for detected the topmost script. Crossing the API and getting a stack trace can be avoided in many case. This has a measurable impact on Speedometer. Bug: 808503 Change-Id: I6ed1b8734056ecb2efd55cf83f1d7a3302690f52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571091Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Camillo Bruni <cbruni@chromium.org> Cr-Commit-Position: refs/heads/master@{#834629}
-
Morten Stenshorne authored
TBR=ikilpatrick@chromium.org Bug: 1156312 Change-Id: I1885dfb7c9b437bc78f80b0b833388981a4a75e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577467Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#834628}
-
Jérémie Boulic authored
Update modules generation script: - Fix detection of duplicate dependencies - Update class export condition: export class if the class is used in another JS file - Fix clang-format off/on Bug: 1133186 Change-Id: Icb5b38f8d57ca69912397b489b8e49dd23e1b8b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575303Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#834627}
-
David Jean authored
TBR=stkhapugin@chromium.org Bug: 1156541 Change-Id: Ic0d27facc25b67778ace7c21d3cd5c4adcaf74da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577681Reviewed-by:
David Jean <djean@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Auto-Submit: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#834626}
-
Victor Costan authored
make_heap is linear in the size of the input, not logarithmic. Change-Id: I88a7c78bfdae4c7dfd09efa433febc6ffdd2d9a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577034Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#834625}
-
Keishi Hattori authored
Bug: 1080832 Change-Id: Ifb7f704416ec9e993f1c180a3a72a76b7ffb2452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578417Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#834624}
-
James Vecore authored
This is a mechanical change to move the nearby-progress Polymer component from being chrome://nearby (Poylmer3) only to being shared with chrome://os-settings (Polymer2/3). This necessary for Nearby Share's launch despite Polymer2 being phased out (the conversion won't be complete in time for M-89 launch). Bug: 1156035 Change-Id: Iff63927d43215dbcab4325c5794c792fed1550df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575947 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#834623}
-
Luciano Pacheco authored
Bug: 1133186 Change-Id: Ifc81fa000fa91a69e8eed2450b9d8fbe4c61dd7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576859 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
-
Anastasiia N authored
Add a 'Don't remind me again' checkbox to the welcome page. Screenshot: http://screen/7mZimAEabQv5agq.png Bug: 1144114 Change-Id: Ib0f5cb1b429d84da982fd239c0afb0ff933d010d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2549764Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#834621}
-
Jesse McKenna authored
This change makes PWA-launcher update work for BMO web apps. Currently, PWA launchers are updated by iterating over the ExtensionRegistry and filtering to bookmark extensions. Since M85, BMO is the default, meaning web apps are no longer bookmark apps and have their own registry: the AppRegistrar. With this change, PWA-launcher update iterates over apps in the AppRegistrar. Bug: 1137573 Change-Id: If30e665eb7999e4e7145fa66bbda31eb98631fb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514079 Commit-Queue: Jesse McKenna <jessemckenna@google.com> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#834620}
-
Wolfgang Beyer authored
frontend CL: https://crrev.com/c/2519702 tests disabled in: https://crrev.com/c/2552595 Bug: chromium:1140540, chromium:1140481 Change-Id: Ifed10e8668a8634c88fc9a0b854cf804bb892bc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2553549 Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#834619}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1607385573-20176c861cfdd390234dbdfc41d000ee505c292a.profdata to chrome-mac-master-1607407031-63b5db867e1f1fedbce39b6034a36fb366360e89.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ie9a8ccd0f09b3c28db28751f5db93b8c6127cb51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578657Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/2b3b0f567d42..2d4ece529113 2020-12-08 yoichio@chromium.org Protocol update If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1152290 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia6a102077508dc7b3076f0d71cbcdf2bdfa3ed53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578656Reviewed-by:
-
James Vecore authored
This is a mechanical change to move the nearby-device Polymer component from being chrome://nearby (Poylmer3) only to being shared with chrome://os-settings (Polymer2/3). This necessary for Nearby Share's launch despite Polymer2 being phased out (the conversion won't be complete in time for M-89 launch). Bug: 1156035 Change-Id: Ib19d6db0b0a53a55eea5e2899880e2592cfb810f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575944 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
-
Wei Lee authored
We should: 1. When calling window operations from tests, we should be able to wait for the operation done 2. If calling window.maximize() while the window is already maximized, trigger the callback immediately. Same for other operations. 3. For devices under tablet mode, since no change will happen when calling restore() while the window is maximized, handle it more properly. Bug: b/172780736 Test: tast run [DUT] camera.CCAUIRecordVideo.swa Change-Id: I91f47e98c5857eb59775045849233d7541d2c603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574117Reviewed-by:
Inker Kuo <inker@chromium.org> Commit-Queue: Wei Lee <wtlee@chromium.org> Auto-Submit: Wei Lee <wtlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#834615}
-
Luciano Pacheco authored
Bug: 1133186 Change-Id: Icf9d3a1594affa6647544910241c989d86477b6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576858 Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Raphael Kubo da Costa authored
Those tests were disabled in commit 46327ef9 ("Temporarily disable web tests that use the legacy Protocol global") but were never enabled again. Adapt to changes that have happened in devtools-frontend and Chromium since then: * Rename Protocol to ProtocolClient <https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2107558> * Update expectations and trim error messages in report-protocol-errors.js <https://chromium-review.googlesource.com/c/chromium/src/+/2254707> screen-orientation-override.js was kept in TestExpectations because it is still timing out due to other setDeviceMetricsOverride()-related changes. Bug: 1011811 Change-Id: I7f0847827dd4ff28bcb646df684039accf7b56f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575117 Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#834613}
-
Nektarios Paisios authored
Workaround for bug in NGInlineOffsetMappingBuilder whereby it does not assign mapping units to empty LayoutText objects When using legacy layout, NGInlineOffsetMappingBuilder computes the text offset mappings fon demand and caches them in the layout object's rare data. However, due to a bug in that computation, empty LayoutText objects are not given a corresponding OffsetMappingUnit in the list of offset mappings causing a crash. This workaround ignores such objects for now, returning the best possible value, until NGInlineOffsetMappingBuilder is fixed to handle this situation. AX-Relnotes: n/a. R=dmazzoni@chromium.org, aleventhal@chromium.org Bug: 1149171 Change-Id: I7a59f924cf94d0b40ca47cbe2be402b3fe68addd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578098 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#834612}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607385573-c353d00fc8fe8bd6d284b3c59bd857ed5fa10770.profdata to chrome-linux-master-1607407031-3aa7c176f7320c5baa78db92893fe31481ff0a44.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I550aad8707e50b2a9d90b72f1b29c152bf95782b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578477Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com Change-Id: If7f5897b69d02f15ab9a32eb075f9804c648916a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577015Reviewed-by:
-
James Vecore authored
This is a mostly mechanical change to move the nearby-device-icon Polymer component from being chrome://nearby (Poylmer3) only to being shared with chrome://os-settings (Polymer2/3). This necessary for Nearby Share's launch despite Polymer2 being phased out (the conversion won't be complete in time for M-89 launch). A Few other small changes were necessary: - Fixed a copy/paste issue with resource_path_rewrites - Make the nearby_share/shared folder CrOS only. There was still a lingering referenced to the closure compiler targets that were not CrOS only. - Refactored browser test to not use the mojo interfaces from a const expression (necessary for Polymer2). - Copied icons from icons to the existing shared icon set (old icons will be cleaned up in a follow up CL. Bug: 1156035 Change-Id: Ic913ca66e814097524ebf29fd7eb0c89aad82d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571804 Commit-Queue: James Vecore <vecore@google.com> Reviewed-by:
-
