GitLab

TBR=sky@chromium.org

BUG=

Review URL: https://codereview.chromium.org/460863002

Cr-Commit-Position: refs/heads/master@{#288987}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288987 0039d316-1c4b-4281-b951-d872f2087c98

CL 435583003 adds usage of std::numeric_limits without including the
required header "limits" header.  Let's fix that.

BUG=398712
NOTRY=true

Review URL: https://codereview.chromium.org/454413002

Cr-Commit-Position: refs/heads/master@{#288986}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288986 0039d316-1c4b-4281-b951-d872f2087c98

BUG=402319
TEST=manually and run browser_tests gtest_filter=*FileManager*

Review URL: https://codereview.chromium.org/458103002

Cr-Commit-Position: refs/heads/master@{#288985}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288985 0039d316-1c4b-4281-b951-d872f2087c98

This CL removes V8DOMWindowShell.createContext.IsolatedWorld
and V8DOMWindowShell.createContext.MainWorld.
They are already dead.

Review URL: https://codereview.chromium.org/461523002

Cr-Commit-Position: refs/heads/master@{#288984}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288984 0039d316-1c4b-4281-b951-d872f2087c98

Rename transparentBackground -> alphaEnabled (per the spec).

Add app.window.alphaEnabled permission to control which apps are allowed to use alphaEnabled when creating windows.

Add browsertests to verify that the API is only available when permission had been granted and Beta channel or newer.

Add a whitelist (only used in Stable) for this API that defaults to the same set of apps as for app.window.shape.

BUG=260810

Review URL: https://codereview.chromium.org/190533006

Cr-Commit-Position: refs/heads/master@{#288983}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288983 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/463743002

Cr-Commit-Position: refs/heads/master@{#288982}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288982 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#288981}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288981 0039d316-1c4b-4281-b951-d872f2087c98

This roll contains following change:

r1960: Guard against configurations without 'xcode_settings'
r1961: Pull in relevant targets when using xcode-ninja
r1962: Currently I've special cased gyp* file modifications higher...
r1963: Style changes for analyzer
r1964: Provide a way to suppress implicit MIDL generation rules for actions

TBR=scottmg@chromium.org
BUG=321462

Review URL: https://codereview.chromium.org/467483002

Cr-Commit-Position: refs/heads/master@{#288980}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288980 0039d316-1c4b-4281-b951-d872f2087c98

ComponentExtensionIMEManager::FindEngineEntry() only needs to find for extension.

BUG=402222
TEST=Verified on linux_chromeos.

Review URL: https://codereview.chromium.org/457943002

Cr-Commit-Position: refs/heads/master@{#288979}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288979 0039d316-1c4b-4281-b951-d872f2087c98

We always pass false to it, so we will never load the common resources.

The benefit of doing this is that it allow us to remove a call to LoadCommonResources(), which we are trying to remove.

BUG=176960
TEST=None
R=tony@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/451283002

Cr-Commit-Position: refs/heads/master@{#288978}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288978 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a DisplayType property to app list SearchResult properties
which will be used to determine where the results should be displayed
in the experimental app list.

BUG=349727

Review URL: https://codereview.chromium.org/455323003

Cr-Commit-Position: refs/heads/master@{#288976}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288976 0039d316-1c4b-4281-b951-d872f2087c98

AppListTestViewDelegate::CreateCustomPageWebViews now returns a vector
of views, not a single view. AppListViewDelegate is now able to generate
multiple custom launcher pages which will all be inserted into the
launcher (but currently only ever produces a single one, from the
--custom-launcher-page switch).

BUG=399131

Review URL: https://codereview.chromium.org/441873004

Cr-Commit-Position: refs/heads/master@{#288975}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288975 0039d316-1c4b-4281-b951-d872f2087c98

Previously, nothing would happen. Now there is a transition, everything slides away to the bottom of the screen and the rest is loaded.

BUG=402017
TEST=manual
R=huangs@chromium.org, pedrosimonetti@chromium.org

Review URL: https://codereview.chromium.org/456833003

Cr-Commit-Position: refs/heads/master@{#288974}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288974 0039d316-1c4b-4281-b951-d872f2087c98

Remove redundant calls to canPaste() in PastePopupMenu. Inhibit calls to show
PastePopupMenu if clipboard is empty. Removed unwanted layout attributes to
fix the greying of the PastePopupMenu when diplayed beside the insertion
handler.

BUG=400705

Review URL: https://codereview.chromium.org/449033002

Cr-Commit-Position: refs/heads/master@{#288973}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288973 0039d316-1c4b-4281-b951-d872f2087c98

BUG=368049

Review URL: https://codereview.chromium.org/465673002

Cr-Commit-Position: refs/heads/master@{#288972}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288972 0039d316-1c4b-4281-b951-d872f2087c98

Now that this is done, we don't need to leave the class files laying
around anymore. So don't.

Review URL: https://codereview.chromium.org/458653002

Cr-Commit-Position: refs/heads/master@{#288971}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288971 0039d316-1c4b-4281-b951-d872f2087c98

This is to clarify why we should not be dispatching synthetic mouse exit events on
Windows.

BUG=394672
R=sky

Review URL: https://codereview.chromium.org/454053004

Cr-Commit-Position: refs/heads/master@{#288970}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288970 0039d316-1c4b-4281-b951-d872f2087c98

and send the option value via Preferences to the renderer.

BUG=399580

Review URL: https://codereview.chromium.org/431323003

Cr-Commit-Position: refs/heads/master@{#288969}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288969 0039d316-1c4b-4281-b951-d872f2087c98

Use PictureLayer instead of ContentLayer, and stop explicitly setting
impl-side painting as false for tests.

BUG=401492

Review URL: https://codereview.chromium.org/458153002

Cr-Commit-Position: refs/heads/master@{#288968}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288968 0039d316-1c4b-4281-b951-d872f2087c98

If the connection was dropped (network error or similar), the session
was not being cleaned up straight away. Instead, the cleanup was
delayed until the next time Java tried to connect, by which time it
had already popped open the progress dialog. This raised an
incorrect disconnection notification that closed the progress
dialog.

This CL ensures that disconnection causes an immediate notification to
Java, and the state is kept consistent between Java and C++ code.

BUG=395301

Review URL: https://codereview.chromium.org/407403002

Cr-Commit-Position: refs/heads/master@{#288967}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288967 0039d316-1c4b-4281-b951-d872f2087c98

I couldn't bring myself to add another #ifdef to
view_event_test_base.cc, so this splits out the platform-specific stuff
and paves the way to get interactive_ui_tests compiling on MacViews.

This is done by adding a ViewEventTestPlatFormPart interface, which is
implemented for (views platforms): chromeos, ash, and mac.

There was also code for a non-ash aura platform, but all build
configurations that would have used it are broken, so it's just rot and
is removed.

BUG=399191

Review URL: https://codereview.chromium.org/443553003

Cr-Commit-Position: refs/heads/master@{#288966}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288966 0039d316-1c4b-4281-b951-d872f2087c98

This updates to the following revision: aedf1212d667 2014-08-05 11:00 -0400

It includes changes from revision 131f3403a484 (2014-06-12 07:56 -0400) to
revision aedf1212d667 (2014-08-05 11:00 -0400), listed at
http://hg.mozilla.org/mozilla-central/log/aedf1212d667/netwerk/dns/effective_tld_names.dat

R=pkasting@chromium.org
BUG=37436

Review URL: https://codereview.chromium.org/460833002

Cr-Commit-Position: refs/heads/master@{#288965}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288965 0039d316-1c4b-4281-b951-d872f2087c98

ExtensionUpdater likes to create and destroy ExtensionDownloader
instances as needed. This is fine, but it means duplicating efforts
any time new dependencies need to be injected into ExtensionDownloader,
because then they also need to be injected into ExtensionUpdater.

This CL adds a factory callback to ExtensionUpdater's constructor
so that ExtensionUpdater creators can opaquely inform the instance
about how it should construct new ExtensionDownloaders.

This also reverts the change to ExtensionDownloader's constructor
which took an (optionally NULL) IdentityProvider; this can now
instead be attached to new ExtensionDownloader instances by the
factory responsible for their construction via the
SetWebstoreIdentityProvider method. ExtensionService
provides an example of this.

BUG=398671

Review URL: https://codereview.chromium.org/456063002

Cr-Commit-Position: refs/heads/master@{#288964}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288964 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#288963}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288963 0039d316-1c4b-4281-b951-d872f2087c98

TBR=zerny@chromium.org

Review URL: https://codereview.chromium.org/462903003

Cr-Commit-Position: refs/heads/master@{#288962}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288962 0039d316-1c4b-4281-b951-d872f2087c98

BUG=308347

Review URL: https://codereview.chromium.org/464683002

Cr-Commit-Position: refs/heads/master@{#288961}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288961 0039d316-1c4b-4281-b951-d872f2087c98

This was removed by r288412 but daisy chooses an incorrect
scale factor if missing.

BUG=402518
R=oshima@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/465783002

Cr-Commit-Position: refs/heads/master@{#288959}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288959 0039d316-1c4b-4281-b951-d872f2087c98

To remove chrome/ dependency from AutocompleteResult

BUG=388504
TEST=components_unittest --gtest_filter="ShouldHideTopVerbatimTest.*"

Review URL: https://codereview.chromium.org/450663002

Cr-Commit-Position: refs/heads/master@{#288958}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288958 0039d316-1c4b-4281-b951-d872f2087c98

This is just a skeleton of the extension and doesn't have any functionality.

Can't use the existing hotword_helper since this has a hard dependency
on a shared module (which doesn't yet exist).

BUG=397019

Review URL: https://codereview.chromium.org/423083002

Cr-Commit-Position: refs/heads/master@{#288956}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288956 0039d316-1c4b-4281-b951-d872f2087c98

R=wtc@chromium.org,rsleevi@chromium.org,mmenke@chromium.org

BUG=398967

Review URL: https://codereview.chromium.org/446623004

Cr-Commit-Position: refs/heads/master@{#288955}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288955 0039d316-1c4b-4281-b951-d872f2087c98

The datatype logic may be operating unders assumptions that break when
the type is stopped from under it, possibly triggering crashes.

BUG=402595

Review URL: https://codereview.chromium.org/462863002

Cr-Commit-Position: refs/heads/master@{#288954}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288954 0039d316-1c4b-4281-b951-d872f2087c98

BUG=334407

Review URL: https://codereview.chromium.org/461773002

Cr-Commit-Position: refs/heads/master@{#288953}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288953 0039d316-1c4b-4281-b951-d872f2087c98

BUG=350234
R=sky@chromium.org

Review URL: https://codereview.chromium.org/455393002

Cr-Commit-Position: refs/heads/master@{#288952}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288952 0039d316-1c4b-4281-b951-d872f2087c98

Sync: Add a SyncTypePreferenceProvider interface to specify sync types to enable. The PSS evaluates these.
For now, this is used by the SupervisedUserService to specify data types that must always be enabled.

BUG=395105

Review URL: https://codereview.chromium.org/428143002

Cr-Commit-Position: refs/heads/master@{#288951}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288951 0039d316-1c4b-4281-b951-d872f2087c98

BUG=402118

Review URL: https://codereview.chromium.org/453203002

Cr-Commit-Position: refs/heads/master@{#288950}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288950 0039d316-1c4b-4281-b951-d872f2087c98

The thread watcher appears to be kicking on when we're trying to
remove a handle. Not sure why. This converts some DCHECKs to CHECKs
and fixes handling of the deadline. I suspect none of this will help,
but it's worth a shot.

BUG=399769
TEST=none
R=darin@chromium.org

Review URL: https://codereview.chromium.org/454433003

Cr-Commit-Position: refs/heads/master@{#288949}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288949 0039d316-1c4b-4281-b951-d872f2087c98

Add UMA to track how many users open the app info dialog.

BUG=395501

Review URL: https://codereview.chromium.org/424943002

Cr-Commit-Position: refs/heads/master@{#288948}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288948 0039d316-1c4b-4281-b951-d872f2087c98

Revert of [DevTools] Make DevTools clients talk directly to DevToolsAgentHost instead of using DevToolsManage… (https://codereview.chromium.org/449043002/)

Reason for revert:
https://code.google.com/p/chromium/issues/detail?id=402835

Original issue's description:
> [DevTools] Make DevTools clients talk directly to DevToolsAgentHost instead of using DevToolsManager.
> 
> Previously, client used methods on DevToolsManager passing |this| to most of them.
> Instead, it should hold a scoped_refptr to inspected DevToolsAgentHost and talk
> to it directly. This creates a single clean entry point for the client, and allows
> in the future to handle browser-wide protocol messages and debug multiple hosts at once.
> 
> BUG=401073
> TBR=kalman@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=288452

TBR=jam@chromium.org,kalman@chromium.org,dgozman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=401073

Review URL: https://codereview.chromium.org/467653002

Cr-Commit-Position: refs/heads/master@{#288946}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288946 0039d316-1c4b-4281-b951-d872f2087c98

Cr-Commit-Position: refs/heads/master@{#288945}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288945 0039d316-1c4b-4281-b951-d872f2087c98

https://skia.googlesource.com/skia/+log/6b143b080820c34c9c0f80e5c682939e9ee3879d..ea13afff6e46d8a969611cdd56c996bfb05a27c1

One test, virtual/gpu/fast/canvas/canvas-createImageBitmap-colorClamping.html , has been marked as NeedsManualRebaseline with Blink r180027.

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_layout_rel
TBR=bsalomon@google.com
NOTRY=True
BUG=

Review URL: https://codereview.chromium.org/466533002

Cr-Commit-Position: refs/heads/master@{#288944}
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@288944 0039d316-1c4b-4281-b951-d872f2087c98