GitLab

An AcceleratedVideoDecoder is a video decoder that requires support from an
external accelerator (typically a hardware accelerator) to partially
offload the decode process after parsing stream headers, and performing
reference frame and state management.

In this design, the hardware-independent decoder implementation interfaces
with a HW-specific Accelerator to offload last stages of the decode process.

Add the interface for AcceleratedVideoDecoder, decoders for VP8 and H264,
V4L2-specific Accelerators for VP8 and H264 and a common accelerator/client
class for V4L2.

TEST=vdatest VP8/H264, mp4 local video playback, apprtc decode
BUG=chrome-os-partner:33728

Review URL: https://codereview.chromium.org/833063003

Cr-Commit-Position: refs/heads/master@{#311448}

BUG=448688
TBR=rtenneti@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/832583004

Cr-Commit-Position: refs/heads/master@{#311447}

The crash was happening because the wrong constructor of scoped_nsobject,
because the template parameter did not exactly match the declaration.
The automatic conversion to pointer was used, and the crash happened
because the object was not retained.
With the new code, the copy constructor is used instead, as was intended.

Review URL: https://codereview.chromium.org/793463004

Cr-Commit-Position: refs/heads/master@{#311446}

Revert of Update V8 to version 4.2.1 (based on cf09a5a1912e0b1ba3dd92e4e67358618736f6aa). (patchset #1 id:1 of https://codereview.chromium.org/847343002/)

Reason for revert:
Speculative revert due to build failure on Win8 GN debug builder http://build.chromium.org/p/chromium.win/builders/Win8%20GN%20%28dbg%29/builds/2984

Original issue's description:
> Update V8 to version 4.2.1 (based on cf09a5a1912e0b1ba3dd92e4e67358618736f6aa).
>
> TBR=machenbach@chromium.org
>
> Committed: https://crrev.com/63aed1cdc517914528cbbe744b1ae89ba8dbdee6
> Cr-Commit-Position: refs/heads/master@{#311438}

TBR=machenbach@chromium.org,v8-autoroll@chromium.org
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/852753002

Cr-Commit-Position: refs/heads/master@{#311445}

BUG=335778
TEST=build and run media_unittests --gtest_filter=JpegParserTest.*
R=posciak@chromium.org, wuchengli@chromium.org

Review URL: https://codereview.chromium.org/748023002

Cr-Commit-Position: refs/heads/master@{#311444}

During migration to newest versions use_additional_auth column
should be removed form logins database. Since sqllite syntax doesn't
support column dropping, so we create new database without this column
and copy data there.

BUG=423716
R=gcasto@chromium.org

Review URL: https://codereview.chromium.org/818443004

Cr-Commit-Position: refs/heads/master@{#311443}

ScriptClientMap actually contains provider clients, not script clients.

BUG=n/a
TEST=compile

Review URL: https://codereview.chromium.org/854543002

Cr-Commit-Position: refs/heads/master@{#311442}

Add sdefresne as temporary OWNERS of favicon & favicon_base
for the duration of the componentization effort of favicon.

Add OWNERS file to //components/favicon_base with the same
OWNERS as //components/favicon since this component is there
to help split functionality shared by history and favicon
components.

Remove blundell@ as temporary OWNERS of //components/favicon*
since he is already OWNERS of //components.

BUG=359513

Review URL: https://codereview.chromium.org/821903003

Cr-Commit-Position: refs/heads/master@{#311441}

This is a preparation for defining some methods in an ios-specific
.cc file.

BUG=426870
R=sky@chromium.org

Review URL: https://codereview.chromium.org/848903002

Cr-Commit-Position: refs/heads/master@{#311440}

BUG=442514

Review URL: https://codereview.chromium.org/847083002

Cr-Commit-Position: refs/heads/master@{#311439}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/847343002

Cr-Commit-Position: refs/heads/master@{#311438}

Move select_favicon_frames_unittest.cc into the favicon_base
with the code that it is testing.

Add the unit_test to the components_unittests, including when
using gn build system.

BUG=359513

Review URL: https://codereview.chromium.org/851693003

Cr-Commit-Position: refs/heads/master@{#311437}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b0f21fa..24e6399

TBR=zmo@chromium.org,yutak@chromium.org

Review URL: https://codereview.chromium.org/852733003

Cr-Commit-Position: refs/heads/master@{#311436}

BUG=442514
R=sky@chromium.org

Review URL: https://codereview.chromium.org/828633002

Cr-Commit-Position: refs/heads/master@{#311435}

BUG=387064

Review URL: https://codereview.chromium.org/815643004

Cr-Commit-Position: refs/heads/master@{#311434}

As TilingSetEvictionQueue creation has been moved to
EvictionTilePriorityQueue, the TilingSetEvictionQueue default
constructor is not used any more but is dead code and can thus be
removed.

R=danakj, vmpstr

Review URL: https://codereview.chromium.org/852553002

Cr-Commit-Position: refs/heads/master@{#311433}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/63121f0..26a00de

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/812283006

Cr-Commit-Position: refs/heads/master@{#311432}

Please see https://groups.google.com/a/chromium.org/d/msg/chromium-dev/ZYL1fHRIy6I/Qh9ic5YrEq8J
for context.

BUG=none
R=thestig@chromium.org

Review URL: https://codereview.chromium.org/833243009

Cr-Commit-Position: refs/heads/master@{#311431}

BUG=439515
TEST=none

Review URL: https://codereview.chromium.org/838463005

Cr-Commit-Position: refs/heads/master@{#311430}

Review URL: https://codereview.chromium.org/828853004

Cr-Commit-Position: refs/heads/master@{#311429}

- Prefix the error messages to indicate the operation
that failed (particularly helps when the error occurs
in a promise chain)
- Add more details to the error messages.

Example improvements:

Before: "URL too long"
After: "Failed to register a ServiceWorker: The
provided scriptURL or scope is too long."

Before: "The scope must be under the directory of the
script URL."
After: "Failed to register a ServiceWorker:
The path of the provided scope ('http://localhost:9898/mysecretpath')
is not under the directory of the provided scriptURL
('http://localhost:9898/resources/empty-worker.js')."

BUG=436928

Review URL: https://codereview.chromium.org/813673005

Cr-Commit-Position: refs/heads/master@{#311428}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/8f672cd..b0f21fa

TBR=hayato@chromium.org,zmo@chromium.org

Review URL: https://codereview.chromium.org/849033002

Cr-Commit-Position: refs/heads/master@{#311427}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/812c028..63121f0

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/812653004

Cr-Commit-Position: refs/heads/master@{#311426}

Cr-Commit-Position: refs/heads/master@{#311425}

Revert of Relanding this with font test fixes for gdi. (patchset #7 id:120001 of https://codereview.chromium.org/853553002/)

Reason for revert:
still fails on XP

https://build.chromium.org/p/chromium.win/builders/XP%20Tests%20%281%29/builds/34996/steps/gfx_unittests/logs/DeriveFontWithHeight

Original issue's description:
> Relanding this with font test fixes for gdi.
>
> Get all font unittests running with DirectWrite on Windows 7+
>
> Fixes as per below:-
> 1. Remove the addition of the fLeading value when calculating the height for the font
>    with DirectWrite. fAscent + fDescent is the height of the font and adding the fLeading
>    value to it returns the spacing between lines which is not what we are looking for.
>
> 2. The FontListTest.Fonts_GetHeight_GetBaseline unittest has a condition which basically validates
>    whether the difference between the font height and the baseline is different for Arial and Symbol
>    fonts. This fails for DirectWrite and fails for GDI with font sizes like 50, etc. Replaced this check
>    with a check for the font heights are different.
>
> 3. Reworked the PlatformFontWinTest.DeriveFontWithHeight test to ensure it passes for DirectWrite and GDI.
>
> 4. Ensure that the PlatformFontWin::DeriveFontWithHeight function honors the minimum font size constraint
>    in all cases.
>
> BUG=442010
> R=msw
>
> Committed: https://crrev.com/3e05f41653bf36cce40718d8295ce2293218dab6
> Cr-Commit-Position: refs/heads/master@{#311388}

TBR=msw@chromium.org,ananta@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=442010

Review URL: https://codereview.chromium.org/847283003

Cr-Commit-Position: refs/heads/master@{#311424}

Previously we used the center of the bounding box, but this can cause problems if the center of the bounding box is outside the element.

This CL also changes the behavior of the GetElementLocationOnceScrolledIntoView command in the same way.

BUG=

Review URL: https://codereview.chromium.org/848483002

Cr-Commit-Position: refs/heads/master@{#311423}

As the completion callback is called externally it should be cleared first, to
avoid possible double cancellation.

TEST=None
BUG=None

Review URL: https://codereview.chromium.org/838023003

Cr-Commit-Position: refs/heads/master@{#311422}

1. Adds null check when keymap is failed to load. 2. Moves xkb_rule_names construction into worker thread to fix crash problem.

BUG=447415, 444121

Review URL: https://codereview.chromium.org/848833002

Cr-Commit-Position: refs/heads/master@{#311421}

Blink is about to make use of blink_resources.grd for the inline resources of user agent stylesheets.
This removes the dependency upon using make-file-arrays.py which embeds these resources as strings.
See part 1, 2 and 3.

Also the .rodata section of libblink_web (in component build mode) is reduced by ~33kb.

In this CL, the html viewer would implement the loadResource() method and use the DataPack to
load the required resources. The resources are generated from blink_resources.grd which has been
added as the deps.

Part 1: https://codereview.chromium.org/436843004/
Part 2: https://codereview.chromium.org/422023008
Part 3: https://codereview.chromium.org/573553002

BUG=312586

Review URL: https://codereview.chromium.org/827223002

Cr-Commit-Position: refs/heads/master@{#311420}

BUG=chromedriver:1016
NOTRY=true
TBR=stgao@chromium.org

Review URL: https://codereview.chromium.org/811653005

Cr-Commit-Position: refs/heads/master@{#311419}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/9ffdc0b..8f672cd

TBR=hayato@chromium.org,zmo@chromium.org

Review URL: https://codereview.chromium.org/851903002

Cr-Commit-Position: refs/heads/master@{#311418}

Revert of Use SuppressFBWarnings to suppress findbugs warnings (patchset #12 id:290001 of https://codereview.chromium.org/793203002/)

Reason for revert:
This is consistently causing bot failures, starting with https://build.chromium.org/p/chromium.linux/builders/Android%20Builder%20%28dbg%29/builds/72002

Original issue's description:
> Use SuppressFBWarnings to suppress findbugs warnings
>
> This has several benefits:
> Makes the warning obvious at the place of the problem
> Makes suppressing the warnings the same as suppressing compiler and lint warnings
> Makes supporting findbugs as part of the build easier
>
> TBR=rmcilroy, mef, boliu
>
> BUG=431826
>
> Committed: https://crrev.com/e0237aaa82e64439e6186f7723d4b8ceff308b9d
> Cr-Commit-Position: refs/heads/master@{#311402}

TBR=aurimas@chromium.org,newt@chromium.org,tedchoc@chromium.org,mef@chromium.org,rmcilroy@chromium.org,boliu@chromium.org,cjhopman@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=431826

Review URL: https://codereview.chromium.org/797403005

Cr-Commit-Position: refs/heads/master@{#311417}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/31b52b7..812c028

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/853603003

Cr-Commit-Position: refs/heads/master@{#311416}

BUG=447734

Review URL: https://codereview.chromium.org/807723004

Cr-Commit-Position: refs/heads/master@{#311415}

This change resolves a critical issue where two different clocks' values
were being mixed in computations involving TimeTicks for ~32% of users
on Windows. The solution is to force the use of a single clock for
TimeTicks::Now() and HighResNow(). In other words, we're moving towards
a world where the TimeTicks type should guarantee all time values are on
the same timeline.

New behavior: On systems where QPC is reliable AND efficient, Now() will
simply use the QPC clock. This is consistent with how Now() behaves on
the Mac and POSIX platforms. However, if QPC is working but is
inefficient, Now() will use the low-res clock. Finally, like before, if
the QPC is not working on the current system, Now() will use the low-res
clock.

NowFromSystemTraceTime() will always use the QPC clock if it is
working, just as before, and regardless of whether it is expensive to
use. This is to ensure tracing data remains useful. When QPC uses either
HPET or ACPI PM as a clock source, online literature suggests clock
sampling will be ~20 to ~40 times as costly (about 1.2 to 2.4us per
call).

Note: From discussion with stakeholders, there is a concern this change
will increase latency and jitter in the compositor pipeline on the
affected Windows machines. Future changes will take alternate approaches
to resolve these problems.

Note 2: This change minimizes TimeTicks API changes, in favor of future
clean-up changes.

BUG=396384,435931,439656

Review URL: https://codereview.chromium.org/797893003

Cr-Commit-Position: refs/heads/master@{#311414}

This will allow mojo, which uses located KeyboardCode values, to distinguish numpad digits from top-row digits.

BUG=444048
R=wez@chromium.org

Review URL: https://codereview.chromium.org/808793005

Cr-Commit-Position: refs/heads/master@{#311413}

R=mmenke
BUG=446900

Review URL: https://codereview.chromium.org/837223007

Cr-Commit-Position: refs/heads/master@{#311412}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/55561f5..9ffdc0b

TBR=hayato@chromium.org,zmo@chromium.org

Review URL: https://codereview.chromium.org/852713002

Cr-Commit-Position: refs/heads/master@{#311411}

BUG=448214

Review URL: https://codereview.chromium.org/847193003

Cr-Commit-Position: refs/heads/master@{#311410}

R=toyoshim
NOTRY=true
BUG=none

Review URL: https://codereview.chromium.org/838113003

Cr-Commit-Position: refs/heads/master@{#311409}