- 03 Apr, 2020 40 commits
-
-
Wez authored
This reverts commit e2eb7388. Reason for revert: Broke test_runner.py to not be able to run without the --system-log-file parameter being set. Original change's description: > [fuchsia] Collect Fuchsia system logs from Chrome-Fuchsia tests. > > The Fuchsia system logs contain more detailed information than the Fuchsia kernel logs. > > Currently only Fuchsia kernel logs are collected. The kernel logs are: > - written to the swarming task output log along with the actual test output > - optionally written to a "system_log" file in the test isolate output > > This CL will: > - optionally write the Fuchsia system log to a "log_listener_log" in the test isolate output > > The Fuchsia system log will be written if the kernel log is written. > > The Fuchsia system log is written to "log_listener_log". The name "log_listener_log" was used because the Fuchsia kernel log contents are already saved in "system_log". > > Bug: 1042512 > Change-Id: I900b5dfe9f6587f1901c19612060b979fae4da99 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130679 > Reviewed-by: Kevin Marshall <kmarshall@chromium.org> > Commit-Queue: Stephen Roe <steveroe@google.com> > Cr-Commit-Position: refs/heads/master@{#756118} TBR=wez@chromium.org,kmarshall@chromium.org,steveroe@google.com Change-Id: I40d0b3030a86856717d53434ac58d7f85dce6fb0 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1042512 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135686Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#756217}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: I063d45ca3749e68751daa6d38f7e38080b333872 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131971 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#756216}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: I78750537502c62f10f65bbfcab318bd8413cd3e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134755Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Cr-Commit-Position: refs/heads/master@{#756215}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Ia11cace00c6bfe2348cc5b1d60fd0c8b4411df68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134184Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium d2104e4a. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 2688e49a "De-flake two lazyload WPT tests." 8fa00285 "[webauthn] Fix resident key credentials.get() WPT" edb8adb1 "Implement and ship RTCRtpSendParameters.degradationPreference" 2fb88bb8 "Use integer coordinates for Actions.pointerMove." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Id3c05a605d49adc640a5fec80fd9274552e83526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134147Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756213}
-
Vasilii Sukhanov authored
- PasswordGeneration.PresaveConflict - PasswordManager.PresavedUpdateUIDismissalReason Fixed: 1066049,1066047 Change-Id: Iec0ad530e0ea0463860bff0186160af5cf46507e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134226Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#756212}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2da86adf0fb8..b5109d9f9628 git log 2da86adf0fb8..b5109d9f9628 --date=short --first-parent --format='%ad %ae %s' 2020-04-03 primiano@google.com Add ObservableEvent to wait for all data source started Created with: gclient setdep -r src/third_party/perfetto@b5109d9f9628 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:141917389,chromium:150960749 Tbr: perfetto-bugs@google.com Change-Id: I5b1c48993c074d1e34bccc992dd35f760d085ced Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135588Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756211}
-
Koji Ishii authored
This patch creates the association cache from |LayoutObject| to |NGFragmentItem|. Querying all fragments from |LayoutObject| is often used in post-layout/pre-paint/paint and is known to be very performance sensitive. This patch creates the cache in the similar way as legacy and |NGPaintFragment|, using the same storage. Bug: 982194 Change-Id: I66e32eb5ae41ee6f9e7966029cf4c9c13054c94b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2117558 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#756210}
-
Hiroshi Ichikawa authored
//tools has its own custom styling configuration to use 2-space indent: https://source.chromium.org/chromium/chromium/src/+/master:tools/.style.yapf?originalUrl=https:%2F%2Fcs.chromium.org%2F So it is expected that this CL converts the file to use 2-space indent even though it's not compatible with the latest style guide. Change-Id: I5fd40493eba702f5ffcc5aa932841a509554c665 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132649 Auto-Submit: Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
David Jean <djean@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#756209}
-
Marc Treib authored
The following histograms are extended to M85: InstanceID.GeneratedNewID FCMInvalidations.ResetClientIDStatus GCM.IgnoredWriteResult.AddInstanceIDData GCM.IgnoredWriteResult.RemoveInstanceIDData GCM.IgnoredWriteResult.SetLastTokenFetchTime The following histogram is marked obsolete: GCM.GetInstanceIDData.ClientStarted Details are on the linked bugs. Bug: 1066035, 1066038, 1066036, 1066091 Change-Id: Ib220204619a304fa209931f8be0fd1035217b2af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132221Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#756208}
-
Christos Froussios authored
This reverts commit 468b6b18. Reason for revert: Suspected of breaking multiple wayland test suits. See bug. Bug: 1067568 Original change's description: > ozone/wayland: allow to run Wayland without mojo. > > Even though we set require_mojo to true in the PlatformProperties, > in certain scenarios Ozone might be initialized without mojo, but in > a single process mode (for example, unittests, ozone_demo). > > In this case, we should instantiate a direct connection between > buffer managers without mojo. I could use base::TaskEnvironment, but > it will require too much changes to how different tests are initialized. > > For example, binding an interface and sending a mojo call requires a > a task runner handle (installed in WaylandBufferManagerGpu). And > that fails with compositor_unittests - some tests create > TaskEnvironment, and some don't. > > Initializing the TaskEnvironment in CompositorTestSuite won't help, > because (as I said) some tests do that. This results in crashing when > tls delegate is set. > > Bug: 1067156 > Change-Id: If3236f9604c692b4ed6efc5dbaf9cc67ce36d62e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128111 > Reviewed-by: Robert Kroeger <rjkroege@chromium.org> > Commit-Queue: Maksim Sisov <msisov@igalia.com> > Cr-Commit-Position: refs/heads/master@{#756173} TBR=rjkroege@chromium.org,msisov@igalia.com Change-Id: Iec818f93fa783b533fd217cd0dd0afce2684075b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1067156 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134145Reviewed-by:
Christos Froussios <cfroussios@chromium.org> Commit-Queue: Christos Froussios <cfroussios@chromium.org> Cr-Commit-Position: refs/heads/master@{#756207}
-
nancy authored
This is a reland of 527adae2 TBR=xiyuan@chromium.org TBR=sky@chromium.org TBR=dominickn@chromium.org Original change's description: > Replace LaunchService's OpenApplication with AppService interface. > > LaunchService will be removed in the follow up CL:2116156 > > BUG=1061843 > > Change-Id: Ifdf73b4ce7bd1cc090a1e1f17c65cf3e36f242dc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132009 > Commit-Queue: Nancy Wang <nancylingwang@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756163} Bug: 1061843 Change-Id: I8c024d86d3e15b2d0702d3c0f4ed76c21d100779 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134090Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#756206}
-
Mirko Bonadei authored
WebRTC is adding a new test binary to run audio only tests. Bug: webrtc:11251 Change-Id: I837a2868755f7d3cfeeb16542f6ed55096207a30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134295Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#756205}
-
Yuki Shiino authored
Supports [NamedConstructor] in the new bindings generator. Bug: 839389 Change-Id: I8924c2d1419300819987d0cd53f47a35f5fc33a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134087 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#756204}
-
Anders Hartvoll Ruud authored
This CL adds support for 'revert' in the parser, behind a flag. Using the keyword doesn't do anything yet. It temporarily behaves like "unset" for both regular declarations and keyframes. Bug: 579788 Change-Id: I0882b41ff6f5c162be8ac1d1cd203ad4ec84c60f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130249 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#756203}
-
Hirokazu Honda authored
This is a reland of 1343d831 The original CL is reverted as breaking vda test fails on hana. The issue is mainly due to V4L2(S)VDA code. So I submit the original CL as-is and separately land a VDA fix CL, crrev.com/c/2131968. Original change's description: > media/gpu/V4L2IP: Reconfigure V4L2 queues on the first Process() > > The client of ImageProcessor feeds ImageProcessor VideoFrame in > import mode. The underlying buffer of the fed VideoFrame can have > a different stride and size from the expectation of > ImageProcessor. The difference is critical in V4L2ImageProcessor. > It is necessary to reconfigure the v4l2 image processor driver by > VIDIOC_S_FMT with the stride and height of the fed VideoFrame. > > Bug: 1033799 > Test: ip_test --gtest_filter=NV12* on kukui > Change-Id: I73050718f6a95a1eaa3d9c7a60eeea1bc791f04e > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2097857 > Commit-Queue: Hirokazu Honda <hiroh@chromium.org> > Reviewed-by: Alexandre Courbot <acourbot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#754835} Bug: 1033799 Change-Id: I7d74e66f6c543009a65dde9d7af14b38c3089aa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132556 Auto-Submit: Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Reviewed-by:
Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#756202}
-
Kent Tamura authored
This CL has no user-visible behavior changes, but might have performance impact. Note that LayoutNG ratio computed by these counters is 83.7% on nytimes.com. Bug: 1067527 Change-Id: I73cda07e55e9c9a7d8cef580ebf59fda10b61d1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134031Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#756201}
-
Michael van Ouwerkerk authored
Bug: 1049127 Change-Id: Id69705557d009e2fe6dbebce15470b68a9339745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134131 Auto-Submit: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#756200}
-
Philipp Hancke authored
based on a more modern variant chrome/test/data/webrtc/webrtc-simulcast.html BUG=921041 Change-Id: I6068dada500cccecdcdb4d8df851a55725d0e5ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050303Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#756199}
-
Javier Ernesto Flores Robles authored
Bug: 1045454 Change-Id: I44d39828843e817e82f20afe4abc1558b92a1e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134252 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Javier Ernesto Flores Robles authored
Use ivars inside the property getters. Create lazy init for |reauthenticationModule|. Bug: 1045455 Change-Id: I9c7d77712e6bde22c9b079beec328ec015352691 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134828 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Auto-Submit: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
-
Hitoshi Yoshida authored
Add enumerations newly added in IDL files but their generated files are not added in GN lists. Bug: 839389 Change-Id: I07916de1312f533d1d44cea78e3ec83749e30b5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134182 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#756196}
-
Benoit Lize authored
FontResource holds onto the encoded and decoded versions of the font. However the encoded version is never accessed after it has been decoded, and the decoded version is never discarded. This means that we are holding on the SharedBuffer without a need for it. Fonts are almost always compressed, with a ~3x compression ratio typical. From local benchmarking, encoded fonts are commonly ~500kiB on popular news websites. This CL discards the fonts after they've been decoded. Change-Id: Ic72009431084cdd1e30fcd69ba1ec59788c0cede Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134291Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#756195}
-
Jacobo Aragunde Pérez authored
Per Mojo docs (//mojo/public/cpp/bindings/README.md#Enums), kMaxValue shares the value of the highest enumerator of the enum. In this case, it shares the value of kWindow, that means kWindow is not being dealt with in that switch statement. Bug: None Change-Id: I44a14426772b4b0e3e804e891cf2197a96650088 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132159Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Jacobo Aragunde Pérez <jaragunde@igalia.com> Cr-Commit-Position: refs/heads/master@{#756194}
-
Nicholas Verne authored
These tests cover the correct behavior on app launch. Bug: 1024693 Change-Id: I9808e7492e696f8fea89bf5c7eba49439c9fc5aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135091 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#756193}
-
Mathias Carlen authored
Before this patch, the backend url logic was in the android client and not directly available to the extension code. Since switching backends is useful during development and testing scenarios, this patch moves the command line switches to a shared file. The default URL can be in the service impl and does not need to be part of the client interface. The patch also cleans up the use of the api keys, which don't need to be handled in chrome, only the installation channel needs to be part of the Client interface. Bug: b/143736397 Change-Id: I30caeffc226e6936d43e0000d897f9bfbf53d9c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129549 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#756192}
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Iaae3dbd46bc56a2e6b0c0f2d7ed2588dddcb014d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132080 Commit-Queue: Minoru Chikamune <chikamune@chromium.org> Reviewed-by:
-
Anastasiia Nikolaienko authored
Show kite icon in Account Manager for child users instead of info icon. Screenshot: http://screen/FNcYnvQJFwC Bug: 1054798 Change-Id: Ic8f99fe4dcffd2766f43dc96fe2c48bff03103fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132143 Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#756190}
-
Yuki Shiino authored
V8 doesn't allow to specify v8::SideEffectType::kHasNoSideEffect even when there is no setter and the property is v8::ReadOnly. Fixes the flag. Bug: 839389 Change-Id: I579dffaa243f709e090747e29d513564b9c830f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134746Reviewed-by:
-
Miyoung Shin authored
This CL uses CheckedNumeric to avoid UBSAN issue of the integer overflow when calculating rect coordinates in ChromeClientImpl::ViewportToScreen. Fuzzer report: https://clusterfuzz.com/testcase-detail/4895093060861952 Bug: 1067114 Change-Id: Ibe0b4f353d06885024b915afedf22c125ee595d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134178Reviewed-by:
-
Minoru Chikamune authored
No behavior change. This CL reduces potential risks of use-after-free bugs. Bug: 1049056 Change-Id: Ib58dec4de1c128074264e0d530071bd3a7cd5179 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132889Reviewed-by:
-
Nancy Wang authored
This reverts commit 527adae2. findit revert something badly, so I have to revert it. Reason for revert: <INSERT REASONING HERE> Original change's description: > Replace LaunchService's OpenApplication with AppService interface. > > LaunchService will be removed in the follow up CL:2116156 > > BUG=1061843 > > Change-Id: Ifdf73b4ce7bd1cc090a1e1f17c65cf3e36f242dc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132009 > Commit-Queue: Nancy Wang <nancylingwang@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756163} TBR=xiyuan@chromium.org,sky@chromium.org,dominickn@chromium.org,nancylingwang@chromium.org Change-Id: I4c03bd10ac96dfb74687715999bd5ec0d45bb749 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1061843 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134033Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c3968223894a..fca03eaabd52 Created with: gclient setdep -r src-internal@fca03eaabd52 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I6b30191177cdfce469b8f71c13a51cb7958561de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135450Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#756185}
-
Findit authored
This reverts commit d07c4196. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 756170 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2QwN2M0MTk2Mjc0YWI5YzViNzgxOWNlYTM4MmNkYWFmZTk5ZTNkY2MM Sample Failed Build: https://ci.chromium.org/b/8884060269631959536 Sample Failed Step: compile Original change's description: > Remove launch service. > > BUG=1061843 > > Change-Id: I12efd2899403cb9cc5e9dafc04300a7156342ed9 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2116156 > Commit-Queue: Nancy Wang <nancylingwang@chromium.org> > Reviewed-by: Nancy Wang <nancylingwang@chromium.org> > Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> > Reviewed-by: Eric Willigers <ericwilligers@chromium.org> > Reviewed-by: Dominick Ng <dominickn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#756170} No-Presubmit: true No-Tree-Checks: true No-Try: true BUG=1061843 Change-Id: I413bad145ac3740f868bc94f43db3256666cfedb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2135529 Cr-Commit-Position: refs/heads/master@{#756184}
-
Colin Blundell authored
This CL adds another test of WebLayer's external intent launching: When the user clicks a link to navigate to a page that then launches an intent without a user gesture (e.g., via onLoad()), the intent is launched. This case differs from that of the user navigating to said page directly via typing; once Weblayer incorporates //chrome's TabRedirectHandler the latter will be blocked by policy, but the former (the behavior being tested in this CL) is supported by Chrome and should be supported by WebLayer as well. Bug: 1031465 Change-Id: I58e1fc7bbde9fc6235606523f06797a7877bb108 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132385 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#756183}
-
Eric Willigers authored
When a user-installed PWA was newly synced to a Chromebook, and the PWA was opened, we were defaulting to showing minimal-ui controls even if the manifest specified display: standalone. We now fetch the display mode from the manifest during sync. Bug: 1067504 Change-Id: I1189da9cdf05a1fc581ba19e90b67e020e83e1cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134089 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#756182}
-
Bartek Nowierski authored
Change-Id: I9a7af00fdce8e670590d71cfac1577d9961a4baf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134180 Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Nancy Wang authored
This reverts commit c544f756. I have fixed it, don't revert! Reason for revert: <INSERT REASONING HERE> Change-Id: Iecfa4fe3ccf77242f103cd201fc69dffec7bb7c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133999Reviewed-by:
-
Bartek Nowierski authored
Change-Id: Ie37e7fdcd1e9c586fbc9276a5b9874cd98d46a0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2126969 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
-
Kent Tamura authored
This CL has no behavior changes. Bug: 690036 Change-Id: I8ca4936b9b9fc841199b3762146bcd9233fc34c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134751 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
