- 06 Dec, 2017 40 commits
-
-
mrefaat authored
1- Updates WKSystemCookieStore so it can use wkcookiestore only from the main thread. 2- Update the CookieCreationTimeManager to only be used on IO thread (aside from creation on Main thread) Bug: 779106,759229 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ifa0f9e5bb2d2c33c488759467dc8a25403f6e0ed Reviewed-on: https://chromium-review.googlesource.com/809531 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#521954}
-
Gregory Chatzinoff authored
Bug: 778051 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: If5aea1c4412721a7b1bc549a3d14f52bd3de73bb Reviewed-on: https://chromium-review.googlesource.com/809783Reviewed-by:
edchin <edchin@chromium.org> Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#521953}
-
Victor Miura authored
- Remove ProduceTextureCHROMIUM from GLES2Interface. Change all call sites to use ProduceTextureDirectCHROMIUM. - Remove <target> from ProduceTextureDirectCHROMIUM. - Remove <target> from CreateAndConsumeTextureCHROMIUM. BUG=757607 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ic50059a0db3edfaeb51690645bce096f4f64228e Reviewed-on: https://chromium-review.googlesource.com/780807 Commit-Queue: Victor Miura <vmiura@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
David Reveman <reveman@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#521952}
-
Tarun Bansal authored
If the fetch of the warmup URL (aka probe URL) fails, the corresponding proxy is disabled, and the config is reloaded. A future CL will add retries -- If the fetch of the probe URL due to network flakiness fails, then the probe will be retried (up to 3 times) on the same proxy. Bug: 760294 Change-Id: Ib255f8178ef106f5e2882ad3dc32bde143c40a90 Reviewed-on: https://chromium-review.googlesource.com/807592Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#521951}
-
Scott Violet authored
I had the locations wrong. The root is reset to the local, not the local to the root. Not sure why some tests passed with the other way. BUG=792214 TEST=none Change-Id: I9a0a29c0c412d9c097d1c7df64312e1693328998 Reviewed-on: https://chromium-review.googlesource.com/810009Reviewed-by:
Elliot Glaysher <erg@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#521950}
-
Gregory Chatzinoff authored
Ensure that the Incognito Bubble presentation is deferred until after the feature engagement tracker is initialized, just as the New Tab Bubble is deferred. Bug: 778395 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I33c86953665211a7cfafc8e27349892d01e43b80 Reviewed-on: https://chromium-review.googlesource.com/809848Reviewed-by:
-
depot-tools-roller@chromium.org authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/873be6fd45b7..9c02a833e207 $ git log 873be6fd4..9c02a833e --date=short --no-merges --format='%ad %ae %s' 2017-12-05 iannucci [led] Update led to the latest version Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=phajdan.jr@chromium.org Change-Id: I17e83345022764597a95370ce248e63d210d34fa Reviewed-on: https://chromium-review.googlesource.com/809960Reviewed-by:
depot-tools-roller . <depot-tools-roller@chromium.org> Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521948}
-
Benjamin C. Wiley Sittler authored
The CGIs were previously the only way to test Unicode filenames in file uploads, but introduced noticeable test slowdowns, especially on Win32. This also removes the test bifurcation previously added to avoid occasional Win32 timeouts due to Win32 CGI slowness: https://chromium.googlesource.com/chromium/src/+/78383443fce02079cbbec26f911abea2ca70dc5b TBR= Bug: 661819 Change-Id: Iab3295f665bdfe4c51688f4fa42162505f36a929 Reviewed-on: https://chromium-review.googlesource.com/802554 Commit-Queue: Marc-Antoine Ruel <maruel@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#521947}
-
Lei Zhang authored
The method does not need access to a PrivetURLFetcher pointer. Change-Id: I94d42334cdfab47131bc29e8de5b090a0634f120 Reviewed-on: https://chromium-review.googlesource.com/804670 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#521946}
-
Gregory Chatzinoff authored
This reverts commit 15a3e07e. Reason for revert: Still failing on bots. Original change's description: > Reenable testBadgedReadingListFeatureShouldShow. > > Reenable this test since flake seems to have been fixed on FYI bots. > > Bug: 789943 > Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs > Change-Id: I184607d3fc25206409c0786d81583c49a9f8471a > Reviewed-on: https://chromium-review.googlesource.com/807166 > Reviewed-by: edchin <edchin@chromium.org> > Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521764} TBR=edchin@chromium.org,gchatz@chromium.org Change-Id: Ia4838fc7a683aaeb54eebbf1c4432f0baeb55b09 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 789943 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Reviewed-on: https://chromium-review.googlesource.com/809857Reviewed-by:
Gregory Chatzinoff <gchatz@chromium.org> Commit-Queue: Gregory Chatzinoff <gchatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#521945}
-
James Zern authored
removes rescaler, auto-filter (-af) support and makes WebPPictureCopy, WebPPictureIsView, WebPPictureView, WebPPictureCrop, and WebPPictureRescale noops. Bug: 789665 Change-Id: I222feb7dce9b41093acebf1d3381dcedf9922e7d Reviewed-on: https://chromium-review.googlesource.com/797771Reviewed-by:
Urvang Joshi <urvang@chromium.org> Commit-Queue: James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#521944}
-
Yi Gu authored
This metric is no longer needed as we have detailed metrics for tracking main thread scrolling. Bug: Change-Id: Idcb10e071c121d192148c2a05075c52c87d3b32e Reviewed-on: https://chromium-review.googlesource.com/809087Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#521943}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/09fc536c66c6..a9cf2fa54a33 $ git log 09fc536c6..a9cf2fa54 --date=short --no-merges --format='%ad %ae %s' 2017-12-05 martiniss Emit artifacts from story runner Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ia2fee95f0bb00fa9117da6c2ed8058bce41eab14 Reviewed-on: https://chromium-review.googlesource.com/809957 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521942}
-
Sasha Bermeister authored
This doesn't change any content of the file. To create this patch, I: 1. Used a script to generate markdown from the HTML 2. Cleaned up differences by hand 3. Formatted and wrapped to 80 chars 4. Added 'DO' and 'DONT' in front of code blocks where the red/green colouring was lost (and the difference is important) Change-Id: Ib16c404ce5cf8f4e0d434e35886037dafbcc63a5 Reviewed-on: https://chromium-review.googlesource.com/802843 Commit-Queue: Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521941}
-
Steven Holte authored
Bug: 754889 Change-Id: I7dd1233e282fab6a3e00c40526e5c69b54637726 Reviewed-on: https://chromium-review.googlesource.com/806925 Commit-Queue: Steven Holte <holte@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Cr-Commit-Position: refs/heads/master@{#521940}
-
Michael Spang authored
Tracing can generate large output files (over 50M) especially if system tracing is enabled, and are very compressible. Add an option to compress them using the same machinery that chrome://tracing uses. This also uses less /tmp space to store the stream. Storing large files in /tmp was causing problems for chromecast, as space is /tmp is very limited. BUG=791708 Change-Id: Icbaac91cccb825a305431569bf6f42011d3cfbea Reviewed-on: https://chromium-review.googlesource.com/807384 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#521939}
-
Min Qin authored
This logic is currently implemented in ResourceDisaptcherHostDelegate, which doesn't work with network service. This CL moves the logic to ContentBrowserClient, so the function can be invoked by both legacy and network service path. A new DownloadTest is added to test this. BUG=715630 Change-Id: I488858e16ef7d54e82405432b0d4efc9c2ca31eb Reviewed-on: https://chromium-review.googlesource.com/806737 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#521938}
-
David Trainor authored
Add the ability to share and delete items through a new three dot menu on all download items in download home. Bug: 777630 Change-Id: Icd8f19e2d4630ab4e96d21e7c02021fa30690046 Reviewed-on: https://chromium-review.googlesource.com/802138 Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#521937}
-
Darren Shen authored
The new spec made attributes of CSSVariableReferenceValue mutable. This also allows us to simplify the test helper to create CSSVariableReferenceValues. Spec: https://drafts.css-houdini.org/css-typed-om-1/#cssvariablereferencevalue Bug: 545318 Change-Id: I9f7571e7b50b646423e4a6dc44cfb6c95c3fc5dd Reviewed-on: https://chromium-review.googlesource.com/802664 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
Renée Wright <rjwright@chromium.org> Cr-Commit-Position: refs/heads/master@{#521936}
-
Xianzhu Wang authored
IFrames can have border-radius applying to the contents. Now generate InnerBorderRadiusClip property node for such IFrames. Bug: 765985 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I42587e4c046728e15a19097c25466e229b6c6da8 Reviewed-on: https://chromium-review.googlesource.com/807335 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#521935}
-
Matthew Braithwaite authored
This allows the Relying Party to request that a token's attestation certificate be replaced with a randomly-generated certificate. The default behavior is unchanged. BUG=780299 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I98d6a94399ac1896b6893c8c080f874d66b818b3 Reviewed-on: https://chromium-review.googlesource.com/804978Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Matt Braithwaite <mab@google.com> Cr-Commit-Position: refs/heads/master@{#521934}
-
Sadrul Habib Chowdhury authored
Like single-process mode, chrome uses x11 from multiple threads in --mus mode too (the window-server thread, and the viz thread). So always initialize ozone-x11 in multi-thread mode. It would be possible to introduce a new flag in InitParams for this mode, but considering this is only used for development purposes on developer workstation, just init multi-thread mode unconditionally. BUG=786453, 791619 Change-Id: I930fc325ef1a52f531a419f660d31f55af03d1c6 Reviewed-on: https://chromium-review.googlesource.com/809943Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#521933}
-
Vincent Scheib authored
TBR: scheib@chromium.org Change-Id: I467adbf5ff9304eea15f8c597565ce84384fbc18 Reviewed-on: https://chromium-review.googlesource.com/810058Reviewed-by:
Vincent Scheib <scheib@chromium.org> Commit-Queue: Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#521932}
-
Lei Zhang authored
Also label related methods and some others as "ForTest". Change-Id: Ibbe204423d9da05ae244993168c12166b1a0568a Reviewed-on: https://chromium-review.googlesource.com/804669 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/c45271e053c8..6eda94d78313 $ git log c45271e05..6eda94d78 --date=short --no-merges --format='%ad %ae %s' 2017-12-05 thestig Replace uses of bsearch(). 2017-12-05 thestig Replace bsearch() in FPDFAPI_CIDFromCharCode(). Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I75e1ad25efe8734a0e96b73dccfa3268f765962e Reviewed-on: https://chromium-review.googlesource.com/809768 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521930}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/7af7216b..ee13fe4b Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I0f22175c61de70e41f207fa63454f373ef78ea4d Reviewed-on: https://chromium-review.googlesource.com/809911Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#521929}
-
Ojan Vafai authored
This reverts commit a9783e12. Reason for revert: Broke webkit_unit_tests All/SnapCoordinatorTest.OverflowedSnapPositionCalculation/1 All/SnapCoordinatorTest.OverflowedSnapPositionCalculation/0 All/SnapCoordinatorTest.EndAlignmentCalculation/1 All/SnapCoordinatorTest.CenterAlignmentCalculation/0 All/SnapCoordinatorTest.CenterAlignmentCalculation/1 All/SnapCoordinatorTest.EndAlignmentCalculation/0 All/SnapCoordinatorTest.StartAlignmentCalculation/0 All/SnapCoordinatorTest.StartAlignmentCalculation/1 All/SnapCoordinatorTest.NegativeMarginStartAlignmentCalculation/1 All/SnapCoordinatorTest.NegativeMarginStartAlignmentCalculation/0 All/SnapCoordinatorTest.AsymmetricalCenterAlignmentCalculation/1 All/SnapCoordinatorTest.AsymmetricalCenterAlignmentCalculation/0 https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Android%20%28Nexus4%29/builds/72004 Original change's description: > Snap at GestureScrollEnd on main thread. > > As the first step of ScrollSnapPoints, this patch implements it on main > thread at GestureScrollEnd. It introduces necessary data structures: > SnapAreaData and SnapContainerData, updates the data after style change > and layout, implements a naive algorithm to select snap points at > intended-end-position, adds unit-tests for logic and adds sim-tests for > behavior. > > Bug: 778257 > Change-Id: I307d51254bd9ab9b7a42b0614d181adac662fa47 > Reviewed-on: https://chromium-review.googlesource.com/756887 > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Reviewed-by: Darren Shen <shend@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Reviewed-by: Majid Valipour <majidvp@chromium.org> > Commit-Queue: Sandra Sun <sunyunjia@chromium.org> > Cr-Commit-Position: refs/heads/master@{#521840} TBR=bokan@chromium.org,jbroman@chromium.org,majidvp@chromium.org,sunyunjia@chromium.org,shend@chromium.org Change-Id: I172b350063d66006a3974919f67c7d4f4f0a980d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 778257 Reviewed-on: https://chromium-review.googlesource.com/809313Reviewed-by:
Ojan Vafai <ojan@chromium.org> Commit-Queue: Ojan Vafai <ojan@chromium.org> Cr-Commit-Position: refs/heads/master@{#521928}
-
Alice Boxhall authored
Bug: 791906,791902 Change-Id: I4a4ccb4afd70b4888a14455f56eea3ba739add77 Reviewed-on: https://chromium-review.googlesource.com/809810Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#521927}
-
Hiroshige Hayashizaki authored
- It is better to do nothing when context document/frame is null. - Preparation for removing ExecuteScriptResult. kShouldFireNone is no longer used, and will be removed in https://chromium-review.googlesource.com/791473. Bug: 788828, 686281 Change-Id: I2327e9065c9a07da0ea3658bb1d31765cbcb537f Reviewed-on: https://chromium-review.googlesource.com/791450 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#521926}
-
liberato@chromium.org authored
Bug: 775577 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I99dc244ceb3905fd55c948398a7991a5a019e669 Reviewed-on: https://chromium-review.googlesource.com/806734Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#521925}
-
Vincent Scheib authored
Moves ability to create the //device/bluetooth/public/interfaces Adapter to chrome/browser/ui/webui/bluetooth_internals/bluetooth_internals_handler.cc instead of chrome/browser/chrome_content_browser_client.cc //chrome/browser/ui/webui/bluetooth_internals target created to allow visibility of //device/bluetooth/public/interfaces:deprecated_experimental_interfaces to be restricted precisely to the single allowed client. Numerous build files adjusted as needed to enforce that visibility restriction and clearly document that the interfaces are only intended to be used by bluetooth-internals. Bug: 746132 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Idcaa51d1ed4fb818bd3d8ae617e41a28eabfcb44 Reviewed-on: https://chromium-review.googlesource.com/775782Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Commit-Queue: Vincent Scheib <scheib@chromium.org> Cr-Commit-Position: refs/heads/master@{#521924}
-
Toni Barzic authored
Extracts code that deals with calling powerd SetBacklightsForcedOff method from PowerButtonDisplayController to a separate class that can handle multiple concurrent requests to set backlights off (by keeping track of the active set backlights forced off requests). While currently only PowerButtonDisplayController uses SetBackligthsForcedOff, it's planned to add similar ability to lock screen note launching code in a follow-up (the idea is to force backlights off if the lock screen app is launched while the display is turned off, until the app launch is done). Goal of BacklightsForcedOffSetter is to prevent these two classes from conflicting with each other - it will ensure backlights are forced off as long as at least one backlights forced off request is active. Backlights can be forced off using BacklightsForcedOffSetter::ForceBacklightsOff, which returns ScopedBacklightsForcedOff unique ptr - to stop backlights forced off request, callers should just reset the returned unique ptr. BUG=767711 TEST=Press power button, verify display is turned off. Press power button again - display is turned on. Change-Id: Ie47f546edb51659bb82ba4618b069569a2d188c6 Reviewed-on: https://chromium-review.googlesource.com/758963 Commit-Queue: Toni Barzic <tbarzic@chromium.org> Reviewed-by:Dan Erat <derat@chromium.org> Reviewed-by:
Qiang(Joe) Xu <warx@chromium.org> Cr-Commit-Position: refs/heads/master@{#521923}
-
Kyle Horimoto authored
This change makes it possible to return RemoteDevice objects synchronously instead of requiring an IPC call to create them. This change is needed to support [1], since that CL requires that a BluetoothDevice object be used immediately (i.e., synchronously), requiring that a RemoteDevice object is also available synchronously. This CL also moves ownership of TetherHostFetcher from TetherComponent to TetherService, ensuring that RemoteDevice objects necessary for TetherComponent are generated before the component is started up. [1] https://chromium-review.googlesource.com/c/chromium/src/+/738467 Bug: 777610, 672263 Change-Id: I3c74af3cb8964d32e3bd30298849af1e2477c77a Reviewed-on: https://chromium-review.googlesource.com/804395 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Jeremy Klein <jlklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#521922}
-
Marti Wong authored
2 egtest2 are added: 1. testWhenCurrentFolderDeletedInBackground: test when the navigating folder of Bookmarks is deleted in background, empty background is shown with context bar buttons disabled. 2. testBookmarksURLDisabled: test chrome://bookmarks is disabled. Bug: 782551 Change-Id: I1e0f4cc4960aca3094e673e812d040ec231d497c Reviewed-on: https://chromium-review.googlesource.com/807410Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Marti Wong <martiw@chromium.org> Cr-Commit-Position: refs/heads/master@{#521921}
-
Dave Schuyler authored
This CL adds a test for retrying the load of an extension that had errors. Both a retry that fails and a retry that succeeds are tested. This is a follow-up for CL 798123. Bug: 789751 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I161f35127d5c37769d6c5e577c2e7d6689dbb482 Reviewed-on: https://chromium-review.googlesource.com/807448 Commit-Queue: Dave Schuyler <dschuyler@chromium.org> Reviewed-by:
-
Sasha Bermeister authored
Remove outstanding_requests_ from QuotaDispatcherHost and associated subclasses to address TODO. These subclasses existed to carry the request_id around. Now that the request_id has been removed from the QuotaDispatcherHost system, these subclasses are no longer needed. Also change the design of QuotaDispatcherHost slightly; instead of creating a separate object to hold all the request parameters, curry the parameters into the various async callbacks. Bug: 781643 Change-Id: Ia85ed5a8f6e75a424767faa632e0f1f831a32ddf Reviewed-on: https://chromium-review.googlesource.com/799573Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Sasha Morrissey <sashab@chromium.org> Cr-Commit-Position: refs/heads/master@{#521919}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/a3e9271ec41d..f9af55641a6d $ git log a3e9271ec..f9af55641 --date=short --no-merges --format='%ad %ae %s' 2017-12-05 angle-deps-roller Roll skia/third_party/externals/angle2/ f5be5bafa..12a18ad35 (10 commits) 2017-12-05 kjlubick Don't set min frequency for Android devices Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=rmistry@chromium.org Change-Id: I0b682fa7acd4cdb0ba05cd7efad3c393a04e4387 Reviewed-on: https://chromium-review.googlesource.com/809923Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#521918}
-
Lukasz Anforowicz authored
This CL ensures that blink::FrameTree::Find(const AtomicString& name) only looks for a match in the current set of related browsing contexts (represented in the browser by content::BrowsingInstance). This CL means that window.open's behavior won't change just because a renderer process happens to host multiple unrelated browsing contexts (possible for example after reusing a renderer process because of hitting the process limit). This CL consists of 3 parts: - New browser tests. - RenderFrameHostManagerTest.ProcessReuseVsBrowsingInstance for verifying browsing instance boundaries when the renderer processes get reused. - ExtensionFunctionalTest.FindingUnrelatedExtensionFramesFromAboutBlank for verifying that extensions can still lookup unrelated frames from the same extension. - Having blink::Page maintain a set of related pages. - Page::next_related_page_ and Page::prev_related_page_ form a circular, double-linked list of related pages. - Page::CreateOrdinary takes a new |opener| parameter and treats the new page and the |opener| as related and puts them on the same list. - |opener| is propagated from content::RenderViewImpl, through blink::WebViewImpl into blink::Page. - Falling back to blink embedder when blink::FrameTree::Find finds no frame with the given name. - The fallback is needed to preserve the old behavior for extensions. - The fallback goes through blink::LocalFrameClient, blink::WebFrameClient / content::RenderFrameImpl, content::ContentRendererClient / ::ChromeContentRendererClient, ::ChromeExtensionsRendererClient and finally is implemented by extensions::ExtensionFrameHelper. - Currently the fallback iterates through all same-origin frames in the given process, but requires that the |relative_to_frame| is an extension frame. In the future we might want to restrict piercing of browsing instances to specific scenarios where it is needed (e.g. restrict it to background pages / contents only?). I've tested this CL via: (all tests below pass before and after the CL, except for ProcessReuseVsBrowsingInstance which is fixed by this CL) - New tests: - RenderFrameHostManagerTest.ProcessReuseVsBrowsingInstance (web -> web shouldn't violate browsing instance) - ExtensionFunctionalTest.FindingUnrelatedExtensionFramesFromAboutBlank (extension/about:blank -> extension can violate browsing instance) - Existing tests: - ExtensionApiTest.WindowsCreate_WithOpener and _NoOpener (chrome.windows.create stays in the same browsing instance depending on the setSelfAsOpener parameter) - AppBackgroundPageApiTest.Basic (hosted app -> background page can violate browsing instance; tests handling of mapping of web urls [full url, not just origin] to extensions) - Manual testing: - Hangouts Chrome *extension* continues to work (sufficient to validate that sign-in works). Tested with version 2017.1019.418.1. Bug: 718489 Test: See above. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Tbr: tommycli@chromium.org Change-Id: Icdc9ec7bef0e35b59e04fb12385045f22db80c3a Reviewed-on: https://chromium-review.googlesource.com/764487 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:Lei Zhang <thestig@chromium.org> Reviewed-by:
Matthew Wolenetz <wolenetz@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#521917}
-
liberato@chromium.org authored
Bug: Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I5979881b8b9c05ca99f88531fc6e565feeee0c13 Reviewed-on: https://chromium-review.googlesource.com/804687 Commit-Queue: Frank Liberato <liberato@chromium.org> Reviewed-by:
-
Donn Denman authored
Updates the config to match our full launch group for Smart Selection on Chrome for Android. BUG=770767 Change-Id: I80a04f3b66342eba17c17c8b66cda9b25d7b278b Reviewed-on: https://chromium-review.googlesource.com/809850 Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#521915}
-
