- 17 Dec, 2019 40 commits
-
-
Xida Chen authored
This CL makes off-thread paint worklet work with OOP-R. OOP-R serialize an PaintOp and stores the serialized buffer in a shared memory. GPU then reads the memory and de-serialize it. For off-thread paint worklet, we are producing a DrawImageRectOp. Note that this DrawImageRectOp is different than a normal one. It is a DrawImageRectOp that contains a DrawRecord that contains multiple PaintOps in it. So this CL adds a special code path to serialize it, for paint worklet DrawImageRectOp only. The way to serialize it is to iterate over all the PaintOps inside the DrawRecord. In this way, we do not need to change anything on the GPU de-serialize code. We also changed the layout tests. We changed some tests, now using fillRect instead of strokeRect. The problem with strokeRect is that using GPU rasterization could easily result in subpixel difference on different platforms. Using fillRect will avoid that. Bug: 1020238 Change-Id: Ie0aadfe217e462547cc16a273d09ec8a64f055a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1957012Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#725554}
-
sandromaggi authored
Bug: NONE Change-Id: I64d6dd4d6f66a6248ac55bd0d8de058d4cf63a7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971914Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#725553}
-
John Budorick authored
They are big and seemingly don't need to be on the device. Change-Id: I837ff70b725c5acff31ae27e40f50b9332f54dd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971053Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#725552}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a0a6e29dda17..4c9c7b71c881 git log a0a6e29dda17..4c9c7b71c881 --date=short --first-parent --format='%ad %ae %s' 2019-12-17 aerotwist@chromium.org Adds test for measuredScrollbarWidth 2019-12-17 aerotwist@chromium.org Updates Karma paths 2019-12-17 janscheffler@chromium.org Add "copy as Node.js fetch" option to network log Created with: gclient setdep -r src/third_party/devtools-frontend/src@4c9c7b71c881 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1009443 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I3a7dcd7bca33f2c65b57c735b79869cc5bb04b71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971771Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#725551}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/9699b3de8952..6120ddc42548 git log 9699b3de8952..6120ddc42548 --date=short --first-parent --format='%ad %ae %s' 2019-12-17 khokhlov@google.com Merge "trace_processor: Add smoke test for storage_minimal" 2019-12-17 lalitm@google.com Merge "trace_processor: add filter benchmarks and refactor existing" 2019-12-17 khokhlov@google.com Merge "trace_processor: Introduce Desctructible base class for trackers" Created with: gclient setdep -r src/third_party/perfetto@6120ddc42548 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I3a5f9ff8326fa0cfddfa306dd6faa6c8694c55b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971469Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#725550}
-
Finnur Thorarinsson authored
Removes the blue play icon from the bottom right of the thumbnails and replaces it with a white (partially transparent) play icon in the top right corner. The small play control is also visible in the top right corner of full-screen versions of the photos, but that will be replaced in favor of a larger play icon in the middle (another CL). Bug: 895776, 656015 Change-Id: I26609da3b3f867d2cc40b404423349857c28bac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967454Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#725549}
-
Mario Sanchez Prada authored
This CL migrates code to the new BrowserInterfaceBroker class. This allows retrieving the remote implementation in the browser process without relying on the InterfaceProvider API. Bug: 936482, 1002647 Change-Id: Ib8c5141ae28a0789df2a327d9d2305722edeeead Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1953110 Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#725548}
-
Andrew Grieve authored
The icon already exists in chrome/android/java/res_chromium. Bug: 935982 Change-Id: Ic8ff13f6162306a4173ddc019326b4c1e88e52f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968254 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#725547}
-
Robbie Gibson authored
Usually, if the text in the pasteboard looks like a URL, the |.URL| property returns non-nil even if the initial copy itself didn't identify the text as a URL. Unfortunately, this sometimes doesn't happen. The bug specifically calls out syncing between macOS and the iOS simulator, but it could also happen with Universal Clipboard (this was not checked and is pure speculation). To fix this, we can just fallback to checking whether the string forms a URL via NSURL. Bug: 1033935 Change-Id: I9aa8fe2cf14676158e0e38cfc95947a09dfd7c1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967326 Commit-Queue: Robbie Gibson <rkgibson@google.com> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#725546}
-
Mark Cogan authored
This CL factors out the tab insertion logic from TabModel into a Browser agent. In order to do this, it also: - Creates the BrowserUserData infrastructure. - Creates an AttachBrowserAgents() helper. These are direct analogs to WebStateUserData and AttachTabHelpers(). These TabModel methods are removed: -insertWebStateWithURL:referrer:transition:opener:openedByDOM:atIndex:inBackground: -insertWebStateWithLoadParams:opener:openedByDOM:atIndex:inBackground: -insertOpenByDOMWebStateWithOpener: The first of these was a convenience wrapper for the second (it used the first three parameters to construct the LoadParams: argument for the wrapped method). It was mostly used in tests (which now use a separate helper), and the one non-test callsite (in BVC) just creates the LoadParams explicitly. The other two methods are replaced by: TabInsertionBrowserAgent::InsertWebState TabInsertionBrowserAgent::InsertWebStateOpenedByDOM Callsites generally grab the TabInsertionBrowserAgent from a nearby Browser. Only TabGridAdaptor needed to have plumbing added for this (in the TabSwitcher protocol). The bulk of the changed lines come from (a) moving more than half of TabModel's unit tests into TabInsertionBrowserAgentTest, and (b) updating the ObjC method calls (again, mostly in tests) to use the new C++ calls. Change-Id: I1aaeebab0cba49801269d6531faba16086563f93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969890Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#725545}
-
sandromaggi authored
Replace with an outline. Before: https://screenshot.googleplex.com/PnFmKLuFPW1 After: https://screenshot.googleplex.com/ORVetK2DF3J After Dark: https://screenshot.googleplex.com/DApXkzEwt40 Bug: b/146413939 Change-Id: If56e36ac357f8101c44a45a9f68bfba1196094c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970561Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#725544}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/cbeabd969bbe..6bad705d9b6c git log cbeabd969bbe..6bad705d9b6c --date=short --first-parent --format='%ad %ae %s' 2019-12-17 robertphillips@google.com Additional DDL fix Created with: gclient setdep -r src/third_party/skia@6bad705d9b6c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: Iaff92780797ed805b981ab4f8ab6bd5c9b0deef2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971467Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#725543}
-
Andrew Grieve authored
This broke in 29c97e18. It's hard to notice because supersize diffs don't consider symbols to be changed when only their source directory changes. Bug: 1034651 Change-Id: I06ff5ab9bbc3362b3e945800eaad5d6b0f516b14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968255 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#725542}
-
Alice Wang authored
This CL inlines the static method IdentityServicesProvider.getSigninManager. Presubmit is deactived as it requires to replace the use of SharedPreferences which is not related to this CL. Bug: 1032542 Change-Id: I1eeb344c2ea1973f2c33b3858fbb739ed8d0aa44 No-Presubmit: true Change-Id: I1eeb344c2ea1973f2c33b3858fbb739ed8d0aa44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967236 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#725541}
-
Kevin Bailey authored
The SearchSuggestionParser was bailing on an empty string, but later DCHECKing that the string wasn't all white-space. This CL changes the logic to also bail on an all white-space string. Bug: 1018522 Change-Id: Ib091586bd20089e1bdbe411f66debbe0a1f58c66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966524Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#725540}
-
Maria Kazinova authored
autocomplete parameter Change-Id: If6f6a5220f10a379e5a81c54fbf85447012b7802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969571 Commit-Queue: Maria Kazinova <kazinova@google.com> Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#725539}
-
Elly Fong-Jones authored
It is flaky everywhere, especially on chromeos. Bug: 1034972 Change-Id: I6a3ca405cf6633119cef82c66c50c4648aed048f Tbr: thestig@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969985Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#725538}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: I92651f8115d07648fde6ed0fb4c64a31feb08d36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971772Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#725537}
-
Ken Rockot authored
This covers removal of deprecated base::Bind, base::Callback, base::Closure, base::Passed across services/network/ and services/preferences/. Bug: 1007831 Change-Id: I185099d08eadc960f34fc8dfb8bda2e7051abb56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1968969Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#725536}
-
Rune Lillesveen authored
Tests should no longer time out. TBR=obrufau@igalia.com Bug: 1034846 Change-Id: I66de46a238562a7e031ef6e7c3a3b40a87a8c0fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970313Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Oriol Brufau <obrufau@igalia.com> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Auto-Submit: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#725535}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/00a1bcb441d6..9b540cb5534f git log 00a1bcb441d6..9b540cb5534f --date=short --first-parent --format='%ad %ae %s' 2019-12-17 ilnik@webrtc.org Correctly process disabled streams in FrameEncodeMetadataWriter Created with: gclient setdep -r src/third_party/webrtc@9b540cb5534f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I082aec8b301df186140669f998e10f13daf1690e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971468Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#725534}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/fbbfeb700295..24c49ddde89c git log fbbfeb700295..24c49ddde89c --date=short --first-parent --format='%ad %ae %s' 2019-12-17 sugoi@google.com R11G11B10F support Created with: gclient setdep -r src/third_party/swiftshader@24c49ddde89c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ie0610157513cb5c55e4761c9a2e5f5f2edfd5a70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971465Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#725533}
-
Clemens Arbesser authored
This fixes an issue where the test was failing in some runs due to elements not being visible on the screen. For now, checking the effective visibility seems to work. In integration tests (which this is not), we should instead scroll to the elements instead. Bug: 1030217 Bug: b/146414854 Change-Id: Ia5222f5b66e30580d69dfa104287e207aa9d3ccc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970176 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#725532}
-
Yann Dago authored
Bug: 1009162 Change-Id: I2eb0819e55257184b0b81467827dc7e145a47234 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1969970Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#725531}
-
Vasilii Sukhanov authored
TBR=asvitkine@chromium.org Bug: 986298 Change-Id: Ia1540bd7e110c06388c059afe81e65fc1fdf922e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970174 Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#725530}
-
Anders Hartvoll Ruud authored
Some properties cascade separately, but use the same storage location on ComputedStyle. For example, -webkit-writing-mode and writing-mode, or css-logical properties and their physical counterparts. Such situations can not be resolved cascade-time (at least not always), hence we need a way to solve this apply-time. There is currently a mechanism for dealing with writing-mode and zoom: StyleCascade::Filter. The same mechanism can be used for css-logical properties, however, since it would mean maintaining a large switch by hand, this CL generates code for it instead. Any property which has some other property map to it, is called a "slot". Slots are marked as such in css_properties.json5 ('is_slot'), and properties also specify which slots they map to ('slots'). See StyleCascade::Resolver::SetSlot for a more detailed explanation. Note that this CL adds support for mapping a property to more than one slot, which is currently unused, but necessary for supporting -webkit-border-image in the future. BUG=947004,985043 Change-Id: I22f75e32efa41dafbc2f5aaf4fafa0f7b1a53191 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967321 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#725529}
-
Muhamed Parić authored
Test: unit_tests --gtest-filter="PluginVmImageManagerDriveTest.*" Bug: 1001463 Change-Id: Ibf89a1b339c75c9f3b61140b69763058251f9256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1967080 Commit-Queue: Muhamed Parić <muhamedp@google.com> Reviewed-by:
Alex Oldemeier <aoldemeier@chromium.org> Cr-Commit-Position: refs/heads/master@{#725528}
-
Weiliang Chen authored
This CL moves the overlay promotion logic that used to be in OverlayCandidateList onto OverlayProcessorAndroid. For Android pre-SurfaceControl code path, we keep track of promotion hints for resources. It was kept on OverlayCandidateList, and it makes implementation of OverlayCandidateList complicated. OverlayProcessorAndroid now implements CheckOverlaySupport, which helps keeping track of the promotion hints. This is CL 13/? of overlay processor refactor. R=rjkroege Bug: 963597 Change-Id: Ia4ff00e1a1f92687505b8ec985ddceec004683b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1961082 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#725527}
-
Andreas Haas authored
This CL changes the length field of TypedFlexibleArrayBufferView from unsigned to size_t. The reason is that internally TypedFlexibleArrayBufferView already operates on size_t and currently uses a checked_cast to convert to size_t. To avoid potential renderer crashes I adjusted now ValidateUniformParameters to check the size of the incoming TypedFlexibleArrayBufferView and throw an exception if it is too big. Background: we prepare ArrayBuffers to be bigger than 4GB. Therefore we changed the size field to size_t. Now we are changing all uses of ByteLength to be able to deal with size_t, either by accepting a size_t, or by throwing an exception if the size is too big. R=kbr@chromium.org Bug: chromium:1008840 Change-Id: Iaaacc3672931d11df285876f042cce084c9976c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1963803 Commit-Queue: Andreas Haas <ahaas@chromium.org> Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#725526}
-
Weiliang Chen authored
After we have split OverlayProcessor into subclasses that is implemented by different platform, move Android pre-SurfaceControl only code to OverlayProcessorAndroid. This is CL 12/? of overlay processor refactor. R=rjkroege Bug: 963597 Change-Id: I162c4a66eabb4674eff7dd2b0e337d18d9ee0153 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960072 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#725525}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/a2aa7738b96d..a0a6e29dda17 git log a2aa7738b96d..a0a6e29dda17 --date=short --first-parent --format='%ad %ae %s' 2019-12-17 mathias@chromium.org Add AUTHORS file and presubmit check Created with: gclient setdep -r src/third_party/devtools-frontend/src@a0a6e29dda17 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I35f208c704d638c2a64eedfcffc8bb420b22e529 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971466Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#725524}
-
Weiliang Chen authored
Add an OverlayProcessorStub class that provides empty implementation to OverlayProcessorInterface. This could be used on platforms that don't support overlay. For example linux platforms that doesn't use Ozone don't have overlay. This is CL 11/? of overlay processor refactor. R=rjkroege Bug: 963597 Change-Id: I7be11ad4ac9aa860bb579ae01f4b7d23d68c9ac2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960866 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#725523}
-
Weiliang Chen authored
Merge the last OverlayCandidateValidatorSurfaceControl class's functionalities into an OverlayProcessorSurfaceControl class, which is a subclass of OverlayProcessorUsingStrategy. This is used for Android SurfaceControl. This is the last of the OverlayCandidateValidator. Delete remaining OverlayCandidateValidator code. This is CL 10/? of overlay processor refactor. R=rjkroege Bug: 963597 Change-Id: I48d660894f41127332f2719ca57805e5df8aa231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1960717 Commit-Queue: weiliangc <weiliangc@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#725522}
-
Ian Kilpatrick authored
We already have logic for this case, but we were unconditionally missing the cache inside of: NGConstraintSpace::MaySkipLayout ... which was bad. The existing logic was: https://source.chromium.org/chromium/chromium/src/+/master:third_party/blink/renderer/core/layout/ng/ng_layout_utils.cc;l=231;drc=121fca518bce891ce834bb325d600f1e99dd972a?originalUrl=https:%2F%2Fcs.chromium.org%2F Bug: 845235 Change-Id: Ibd34ae655d8ec67c2de2fc777b98b4b7bad42b83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1966385Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#725521}
-
Chromium WPT Sync authored
Using wpt-import in Chromium f247162c. With Chromium commits locally applied on WPT: c15c1083 "Add test that datachannels close when connection does." ba9444b7 "html: reflection.js adds test cases of unicode comparisons for 's'." fadf6027 "[css-pseudo] Recalculate viewport units in ::marker" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I3a414980d4cf981681c0f319466b5281d9028054 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971590Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#725520}
-
Tim van der Lippe authored
It should use a let-assignment instead of a var. Change-Id: I6430076cb4a0e8a88e57b497877efb3b1e04ffd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970215 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Peter Marshall <petermarshall@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#725519}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1bcd9c3c16c5..9699b3de8952 git log 1bcd9c3c16c5..9699b3de8952 --date=short --first-parent --format='%ad %ae %s' 2019-12-17 lalitm@google.com Merge "Update doc in gpu related proto" Created with: gclient setdep -r src/third_party/perfetto@9699b3de8952 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ifc000a7cbb812e49d32e3ddddc65a3a750f5b0b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971463Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#725518}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fcd6bfb5..3e618bf6 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Ibb86042b83698c22f9c2c8eec761f9f86c5cf09d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971670Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#725517}
-
Arthur Hemery authored
We added COOP parsing and it makes sense to have COEP parsed in the network service as well, for security and consistency reasons. Change-Id: I5cef31934572dd1fab7774488a29085a20fe3e39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926504Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Pâris Meuleman <pmeuleman@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#725516}
-
Xiang Ji authored
Bug: 35021 Change-Id: I228444d8b81d34fa6071fcb3a55facdbeda694f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1970763 Auto-Submit: Xiang Ji <jxiang@google.com> Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#725515}
-