- 17 Oct, 2018 40 commits
-
-
John Williams authored
Bug: 893311 Change-Id: I5479bf30aad7801234144b475ebed6f975760afc Reviewed-on: https://chromium-review.googlesource.com/c/1281878Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/master@{#600565}
-
Xi Han authored
The crash is caused by the callback UIStringOverrider::OverrideUIString() in ApplyUIStringOverrides() is called before resource bundle is initialized. In this CL, we checks whether the resource bundle has been initialized or not. If not, we cache the UI strings to be override in a map owned by the VariationsFieldTrialCreator, and override these UI strings once the full browser starts. Bug: 893707 Change-Id: Ia23bc46a5e13a20ab784ff48d565ce1438a6aa0b Reviewed-on: https://chromium-review.googlesource.com/c/1274001 Commit-Queue: Xi Han <hanxi@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#600564}
-
Alex Newcomer authored
Menu bounds do not fit new wider options if the menu options are added after the menu is initially drawn, and the width of the new options exceeds {screen_width - original_menu_origin.x}. This makes wide menu options unusable in some cases because the menu does not widen to accommodate the new items. Regression started: r573978 Test case: 1. Show a website with link[1] on the far right side of the screen: https://www.google.com/chromebook/ 2. Right click to show a menu on one of the links in the toolbar. The menu should be wide enough to show all contents of the menu. [1]Step 1 must have a link as the source of the menu because links use arc::OpenWithMenu, which can add wider ("Open with ...") options to a context menu. These options are added after the menu is drawn because we show the menu before arc calls back with the new menu options. Test: MenuControllerTest.GrowingMenuMovesLaterallyNotVertically Bug: 882662 Change-Id: Ic848fdb545bbdd05f874041bf1044adb7bd1d094 Reviewed-on: https://chromium-review.googlesource.com/c/1262397 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#600563}
-
Scott Graham authored
Also, don't import * from fidl to avoid pylint complaining on Gerrit. With a couple tweaks to avoid 80col being exceeded for presubmit. No intended functionality change (and the generated fidl.js is unchanged). Bug: 883496 Change-Id: If4335f92d7630dd4b543dc686d2baf6aca5d2b6e Reviewed-on: https://chromium-review.googlesource.com/c/1258087 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#600562}
-
John Williams authored
Bug: 892797 Change-Id: I6aee5aafb1f68f6eabc37adab8fd91b5ea11cd29 Reviewed-on: https://chromium-review.googlesource.com/c/1278139 Commit-Queue: John Williams <jrw@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#600561}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/b407163ef346..9aa14a38f434 git log b407163ef346..9aa14a38f434 --date=short --no-merges --format='%ad %ae %s' 2018-10-17 33432579+alan-baker@users.noreply.github.com OpGroupDecorate may not target OpDecorationGroup (#1977) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@9aa14a38f434 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ib751dc48816ccf7d9ce33a79a31b917d4d975967 Reviewed-on: https://chromium-review.googlesource.com/c/1286114Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600560}
-
Kehuang Li authored
In an earlier CL, AEC3 configs are gathered from a JSON string and passed to APM. But will still need to parse two non-AEC3 configs, i.e., pre-amplifier and AGC gains. Bug: 892611 Test: Add new unit tests for the new function and passed all unit tests. Change-Id: Ib52c12d6db18bc8842b64350d1ed8f226758828e Reviewed-on: https://chromium-review.googlesource.com/c/1281913 Commit-Queue: Kehuang Li <kehuangli@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#600559}
-
Wez authored
We use some unsafe FDIO-internal APIs to implement asynchronous waits on file-descriptors. These APIs have been renamed, and the next SDK roll will remove the old names. Change-Id: I234931903c579c1ae1b46f082d4e526e65b05714 Reviewed-on: https://chromium-review.googlesource.com/c/1285515 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Fabrice de Gans-Riberi <fdegans@chromium.org> Cr-Commit-Position: refs/heads/master@{#600558}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/78bcd2bec371..3a482179dedb git log 78bcd2bec371..3a482179dedb --date=short --no-merges --format='%ad %ae %s' 2018-10-17 syoussefi@chromium.org Vulkan: Implement glFlush 2018-10-17 syoussefi@chromium.org Vulkan: Use a specialized macro for wrapped vulkan calls 2018-10-17 syoussefi@chromium.org Roll clang and other chromium deps 2018-10-17 tikuta@chromium.org Remove unused lambda capture Created with: gclient setdep -r src/third_party/angle@3a482179dedb The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:none,chromium:681136 TBR=geofflang@chromium.org Change-Id: I35923d6afed0109c6fe771342aa988e6aa5fcaec Reviewed-on: https://chromium-review.googlesource.com/c/1287013Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cb047393e8c6..594ad5fdcb7b Created with: gclient setdep -r src-internal@594ad5fdcb7b The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I91ad74b5705258c5f28165dce691f56b23b0de90 Reviewed-on: https://chromium-review.googlesource.com/c/1286631Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600556}
-
Marina Ciocea authored
Audio sandbox policy currently allows ftruncate syscall; adding ftruncate64 used on x86 systems. This fix solves browser_tests failures on 32 bit Linux bots. With ftruncate64 blocked, IPC between audio process and renderer was failing leading to audio render errors. Bug: 890850 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I6b09429c018468e0eb037498514df048fe79d520 Reviewed-on: https://chromium-review.googlesource.com/c/1282407 Commit-Queue: Marina Ciocea <marinaciocea@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#600555}
-
Xiaoqian Dai authored
Bug: 895649 Change-Id: I4f4f94639ef7d4a68b37163451afc5eb1dcc77ec Reviewed-on: https://chromium-review.googlesource.com/c/1285086 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#600554}
-
Kenneth Russell authored
The WebGL context attempts to optimize dirty notifications to the canvas and compositor, but the logic was fragile if the compositor skips a frame due to policy decisions. There were two almost-redundant state variables governing this. Remove animation_frame_in_progress_, and reuse marked_canvas_dirty_ for its purpose, clearing marked_canvas_dirty_ in FinalizeFrame. Verified with the test case from the bug and switching spaces 30 times on macOS Mojave. Bug: 895423 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I456194746a1d20f4f2874b13c6cf6ba54dcf4ea1 Reviewed-on: https://chromium-review.googlesource.com/c/1281963Reviewed-by:
Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#600553}
-
Xiaoqian Dai authored
Also disable other windows hide/show animation when tab-dragging process starts/ends. Bug: 888173 Change-Id: Iee22d20832cefd61ad7ebdea30b5a65e75b9f204 Reviewed-on: https://chromium-review.googlesource.com/c/1282162 Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Reviewed-by:
-
Fabrice de Gans-Riberi authored
C++ Compare operators need to follow a strict weak ordering requirement. The implementation used in SymbolMap::Populate didn't meet this requirement. Bug: 893369 Change-Id: Id1b7e4e7c46feb3bf2098ff810656d1d003aef8c Tested: Flakiness is gone. Reviewed-on: https://chromium-review.googlesource.com/c/1286763 Commit-Queue: Fabrice de Gans-Riberi <fdegans@chromium.org> Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#600551}
-
Garrett Beaty authored
Change-Id: I208be8bfb845218d88608a877405bd8b6c192066 Reviewed-on: https://chromium-review.googlesource.com/c/1287095Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#600550}
-
Josh Karlin authored
Ad scripts loaded in ad contexts can be detected by the context alone. Reserve tracking individual scripts to non-ad contexts. Bug: 894080 Change-Id: I90ec62e7e816fc83540f0daa232b105d03eb1553 Reviewed-on: https://chromium-review.googlesource.com/c/1276785 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#600549}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/e92aae6b3612..0f3d2a60105b git log e92aae6b3612..0f3d2a60105b --date=short --no-merges --format='%ad %ae %s' 2018-10-17 kjlubick@google.com Add new Codec fuzzers to FuzzMain 2018-10-17 rmistry@google.com Fix CT documentation 2018-10-17 brianosman@google.com Reland "Remove ancient support for kUnknown_SkColorType in SkBitmapDevice" Created with: gclient setdep -r src/third_party/skia@0f3d2a60105b The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=egdaniel@chromium.org Change-Id: I4d5f3ad3d55033e8d1046b108c489996c8692c5f Reviewed-on: https://chromium-review.googlesource.com/c/1286117Reviewed-by:
-
Josh Karlin authored
This is a cleanup CL. All we're using in the stack is the bool value, so we can remove the struct. Bug: 894505 Change-Id: Id7511420e860c21a1dc84ce5329942eb3bfeb90f Reviewed-on: https://chromium-review.googlesource.com/c/1276686 Commit-Queue: Josh Karlin <jkarlin@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#600547}
-
iOS Autoroller authored
TBR=smut Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I7a7d48866cdd35834ffc0c10d0a9147d39555c9c Reviewed-on: https://chromium-review.googlesource.com/c/1287050 Commit-Queue: iOS Autoroller <ios-autoroller@chromium.org> Reviewed-by:
iOS Autoroller <ios-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#600546}
-
Orin Jaworski authored
This CL adds another experimental omnibox Pedal to restart Chrome, intended to help the user update Chrome. Bug: 893183 Change-Id: I3371f053044bae6dd9fe0c46a63a6b394695201c Reviewed-on: https://chromium-review.googlesource.com/c/1281162 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#600545}
-
Livvie Lin authored
U+0909 (उ) and U+0993 (ও) look similar to the number 3. Thic cl adds these two characters to the mapping to 3 when determining whether to fall back to punycode when displaying URLs. Bug: 895885 Change-Id: I233127570c8e34e791ef5663c1ece9207d6c7bda Reviewed-on: https://chromium-review.googlesource.com/c/1287031Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#600544}
-
John Budorick authored
This is a reland of afe32c4a Original landed in crrev.com/c/1284752. Original change's description: > Build chrome_apk on the chromium.perf android builders. > > Requires crrev.com/c/1283629 > > Bug: 817842 > Change-Id: I9bda31e2b98d58cb514e1ba79c0d4a5457a566a2 > Reviewed-on: https://chromium-review.googlesource.com/c/1284752 > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > Reviewed-by: Ned Nguyen <nednguyen@google.com> > Commit-Queue: John Budorick <jbudorick@chromium.org> > Cr-Commit-Position: refs/heads/master@{#600499} TBR=nednguyen@google.com,perezju@chormium.org Bug: 817842 Change-Id: I83c0913573789452c9a92c32896978f30a2838c3 Reviewed-on: https://chromium-review.googlesource.com/c/1286754Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#600543}
-
Christopher Cameron authored
Replace the pretend menus created in the app shim (which never actually appeared correctly) with real menus. Share the chrome::MainMenuBuilder code for PWAs and the browser app. To MenuItemBuilder: - add a disable() function which allows PWA mode to skip many menu items - change the string_format_1 to take a base::string16 instead of the id for the string (because we have no id for the current PWA) Update the menu building functions to make the PWA menus identical to the existing PWA menus created in the browser process by AppShimMenuController. Make AppShimDelegate expose NSUserInterfaceValidations (matching AppDelegate), but do not hook anything up yet. Bug: 895139 Change-Id: I0393048b3a29d2ab0bee14cab802694d296b4058 Reviewed-on: https://chromium-review.googlesource.com/c/1278916 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
-
Mike Reed authored
May require (slight) rebaselining, as the legacy code may differ from the raster pipeline precision. Change-Id: I54878dfa59e2dd6c5a7eb6ff9c5f278ec6eff726 Reviewed-on: https://chromium-review.googlesource.com/c/1280790 Commit-Queue: Mike Reed <reed@chromium.org> Reviewed-by:
Mike Klein <mtklein@chromium.org> Reviewed-by:
Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#600541}
-
Malay Keshav authored
This patch moves the SkottieWrapper from ui/gfx to cc/paint. This is the next step in moving the rasterization of skottie to worker threads. Bug: 890224 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I2b5f47b60a11bfbc495bb260ad6003ced85d6fad Component: cc, paint, gfx, views Reviewed-on: https://chromium-review.googlesource.com/c/1285091Reviewed-by:
Khushal <khushalsagar@chromium.org> Commit-Queue: Malay Keshav <malaykeshav@chromium.org> Cr-Commit-Position: refs/heads/master@{#600540}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/23e331fe..bad9daf2 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I0506ad53dff467abe34e671669305e746d96ac2e Reviewed-on: https://chromium-review.googlesource.com/c/1286283Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#600539}
-
Fredrik Söderquist authored
This is only called from test-code, and thus is dead in practice. Replace uses in test-code with the the Changed() method. Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I9cdf92314140e65c30bc2a901d34345bf128392d Reviewed-on: https://chromium-review.googlesource.com/c/1286813Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#600538}
-
Scott Graham authored
Implements vector and string decoding for responses and fixes/tests struct-in-struct. Bug: 883496 Change-Id: I9d518103fb28b93802a487765f5fefb65ef01ea1 Reviewed-on: https://chromium-review.googlesource.com/c/1246958 Commit-Queue: Scott Graham <scottmg@chromium.org> Reviewed-by:
-
Brian Salomon authored
Bug: skia:8471 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8c3656331e0a3e1b7666167a63984091dfec306e Reviewed-on: https://chromium-review.googlesource.com/c/1283553Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#600536}
-
Danyao Wang authored
Bug: 893154 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;luci.chromium.try:ios-simulator-full-configs Change-Id: I8af1dc06fe5fe531235a0545bdca933b9e70e6ce Reviewed-on: https://chromium-review.googlesource.com/c/1284911 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#600535}
-
Justin DeWitt authored
This reverts commit 76a90fd9. Reason for revert: <INSERT REASONING HERE> Original change's description: > kFaviconsPerCategoryImage compilation fix for Jumbo builds > > Fix for error during creating chrome_public_apk: > > In file included from gen/chrome/browser/browser_jumbo_17.cc:42: > ./../../chrome/browser/android/explore_sites/image_helper.cc:22:11: error: redefinition of 'kFaviconsPerCategoryImage' > const int kFaviconsPerCategoryImage = 4; > ^ > ./../../chrome/browser/android/explore_sites/explore_sites_service_impl.cc:27:11: note: previous definition is here > const int kFaviconsPerCategoryImage = 4; > ^ > 1 error generated. > > Example compilation settings: > > target_os="android" > target_cpu="arm" > enable_nacl=false > symbol_level=0 > remove_webcore_debug_symbols=true > is_debug=false > dcheck_always_on=false > is_component_build=false > use_jumbo_build=true > > BUG=895593 > > Change-Id: Ic9eaae0239fd4ab53a357df7dff2143b0cc921c4 > Reviewed-on: https://chromium-review.googlesource.com/c/1285056 > Reviewed-by: Cathy Li <chili@chromium.org> > Commit-Queue: Marcin Wiącek <marcin@mwiacek.com> > Cr-Commit-Position: refs/heads/master@{#600459} TBR=dewittj@chromium.org,dimich@chromium.org,chili@chromium.org,marcin@mwiacek.com,freedjm@chromium.org Change-Id: Ia4b4969a8036063a1a44f843f3fbddc044eb6dae No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 895593 Reviewed-on: https://chromium-review.googlesource.com/c/1287094Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Commit-Queue: Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#600534}
-
Misha Efimov authored
The cr_cronet.py script got broken by https://chromium-review.googlesource.com/c/chromium/src/+/1273824. This change fixes it. Bug: 786559 Cq-Include-Trybots: luci.chromium.try:ios-simulator-cronet;master.tryserver.chromium.android:android_cronet_tester Change-Id: Ic71a1eee5041a27bfe51d706e7d16a4d83c6ee7e Reviewed-on: https://chromium-review.googlesource.com/c/1286739Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Misha Efimov <mef@chromium.org> Cr-Commit-Position: refs/heads/master@{#600533}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b273e0cd217d..519565187c85 git log b273e0cd217d..519565187c85 --date=short --no-merges --format='%ad %ae %s' 2018-10-17 benjhayden@chromium.org Revert "Migrate trace_viewer.gypi to gni" 2018-10-17 nednguyen@google.com Add support for --repeat flag in typ 2018-10-17 chiniforooshan@chromium.org aura: filter out frames not submitted from browser 2018-10-17 benjhayden@chromium.org Migrate trace_viewer.gypi to gni Created with: gclient setdep -r src/third_party/catapult@519565187c85 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:895699,chromium:894261,chromium:883894,chromium:895699 TBR=sullivan@chromium.org Change-Id: I42ab97661d390f5ea0e56de3f6196dd4ac19a925 Reviewed-on: https://chromium-review.googlesource.com/c/1286751Reviewed-by:
-
Oriol Brufau authored
Bug 850000 added standard logical properties and aliased prefixed ones to them. The prefixed properties are still used in various places, but the standard ones should be used instead. This patch replaces all the uses in /third_party/blink Spec: https://drafts.csswg.org/css-logical/#box BUG=862141 Change-Id: I4d50faa5071ce735931488990d6c2275e57932f7 Reviewed-on: https://chromium-review.googlesource.com/c/1163785Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#600531}
-
Kelvin Jiang authored
Add an install warning for the case when an extension requests optional host permissions that are already covered by required host permissions. This is a follow-up to 1265118. Bug: 859959 Change-Id: Idf639b89016ac72a4df5406d290baa177e83a0e4 Reviewed-on: https://chromium-review.googlesource.com/c/1274054 Commit-Queue: Kelvin Jiang <kelvinjiang@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#600530}
-
Sunny Sachanandani authored
Before this change, we were using DirectCompositionSurfaceWin on most newer systems, but it's not needed unless hardware overlays are supported. The disable_direct_composition workaround increases crash rates because it's applied before GLSurfaceEGL decides to use direct composition with ANGLE native EGL surfaces. This change moves all direct composition logic from GLSurfaceEGL to DirectCompositionSurfaceWin, and removes use of direct composition with ANGLE surfaces. Bug: 894675 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I2e9c7c8a7ff36fe7b24868544c03aad0e0b7dad6 Reviewed-on: https://chromium-review.googlesource.com/c/1278529 Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
-
Mustafa Emre Acer authored
IdnSpoofChecker incorrectly assumed that a skeleton string shouldn't contain any dots. This isn't true, skeletons of some characters such as Extended Arabic-Indic Digit Zero (۰) is indeed a dot. Remove this assumption and add a test case. Bug: 877045 Change-Id: I6e73c4d2b850f614b8a685f5068d9cd1028f1b24 Reviewed-on: https://chromium-review.googlesource.com/c/1284058Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#600528}
-
Ben Pastene authored
This is a reland of 7f0c13c7 We've bumped capacity in both the builder pool and tester pool. Hopefully that'll be enough! Original change's description: > Move telemetry_unittests from cros VM fyi bot to CQ bot. > > Bug: 876494 > Change-Id: Icfa8631e1278745a50e439d78b4373fb1f0f1f3a > Reviewed-on: https://chromium-review.googlesource.com/c/1281230 > Reviewed-by: Achuith Bhandarkar <achuith@chromium.org> > Commit-Queue: Ben Pastene <bpastene@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599851} Bug: 876494 Change-Id: Id83dc5f3e0063c130ce7b80b8a72e28b9f72bd83 Reviewed-on: https://chromium-review.googlesource.com/c/1286900Reviewed-by:
-
Tommy C. Li authored
Trims the userinfo (username and password), path, query and ref. iOS already does this. This just reuses the same URL formatting logic on other platforms. We should rename the URLFormatter flag in a followup CL for consistency. This does not get all the text interactions perfect. For example, pressing the right arrow key on the elided URL will place the cursor at the end of the host, not the end of the full URL. It's not 100% clear what the right text interactions are yet, but this is a first step towards experimenting with these issues. Bug: 895940 Change-Id: I959c4e33cc28022110db247eeb6e8c38b9fcb672 Reviewed-on: https://chromium-review.googlesource.com/c/1284053Reviewed-by:
-
