- 10 May, 2019 18 commits
-
-
Nigel Tao authored
These variables have type "AppListSyncableService*" but were named "app_service". More recently, there is now a separate concept called "the App Service": https://chromium.googlesource.com/chromium/src/+/HEAD/chrome/services/app_service/README.md Upcoming commits will integrate chrome/browser/ui/ash code with the App Service. To avoid confusion, we first rename these "app_service" variables to "syncable_service". Change-Id: Idd69ac61d3dee9570ecc8ed368b5fa255e547821 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600927Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nigel Tao <nigeltao@chromium.org> Cr-Commit-Position: refs/heads/master@{#658362}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/cb68382c9842..f86c9af41fc7 Created with: gclient setdep -r src-internal@f86c9af41fc7 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=dvadym@google.com,noel@google.com,jbroman@google.com,xialinyan@google.com Change-Id: Ib3db5114371100abd8b11e774cb1280c072f92f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603750Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658361}
-
Dan Zhang authored
https://quiche.googlesource.com/quiche.git/+log/ff86db3f4a3d..7eef071bd3d6 $ git log ff86db3f4..7eef071bd --date=short --no-merges --format='%ad %ae %s' 2019-05-09 quiche-dev Change SendOrQueueMessage to take a QuicMemSliceSpan. 2019-05-09 fayang gfe-relnote: In QUIC, factor out ProcessVersionLabel and ValidateIetfConnectionIdLength functions. No functional change expected, not protected. 2019-05-09 fayang gfe-relnote: In QUIC, stop setting and restoring framer's version in QuicDispatcher::StatelesslyTerminateConnection as terminator now have its own framer. Not protected as this is no-op change. 2019-05-09 ianswett Re-enable QuicConnectionTest::AckNeedsRetransmittableFrames when multiple packet number spaces are used by setting the encryption level. 2019-05-09 danzh gfe-relnote: n/a(code clean up) Clean up #include in quic proof_source and proof_verifier. 2019-05-08 renjietang Allow QuicStream constructor to take parameter on static-ness when constructing from PendingStream. 2019-05-08 dschinazi Make QUIC server set fixed bit in version negotiation packets 2019-05-08 bnc Fix QpackRoundTripFuzzer when cookies are split along '\0'. 2019-05-08 renjietang Add APIs to allow sessions to read stream types from pending stream. 2019-05-08 nharper gfe-relnote: Remove client-side support for Channel ID from QUIC. Not flag protected. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src R=rch@chromium.org Change-Id: I5b14616ed27a9a5294825a9646e1e0ec338b2b16 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603184Reviewed-by:
Steve Anton <steveanton@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Dan Zhang <danzh@chromium.org> Cr-Commit-Position: refs/heads/master@{#658360}
-
Maggie Cai authored
Currently the storage data is send to and from the web ui using int, however when the size gets over 2GB, it will overflow and crash the browser. This CL convert the data into double and adds unit test for large storage data. BUG=960726,943735 Change-Id: I085410fdd3da1674a0b44d1a445927b015219f47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602234Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#658359}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/77f9a12a3f08..4585cc846e0f git log 77f9a12a3f08..4585cc846e0f --date=short --no-merges --format='%ad %ae %s' 2019-05-09 fmayer@google.com Merge "Add CHANGELOG for heapprofd." Created with: gclient setdep -r src/third_party/perfetto@4585cc846e0f The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I5b8738b12467264d3683487757c50b431fd6560d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603749Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#658358}
-
Scott Violet authored
ui/views/mus is going away, which means remote-view is about to be removed. BUG=958241 TEST=covered by tests Change-Id: I7e82de5838e7c98fb161d2aa9c4620f0b6d917f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603743Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#658357}
-
Nigel Tao authored
Before this commit, all AppListSyncableServiceTest.* unit tests pass with AppServiceAsh disabled, but fail with it enabled. After this commit, all AppListSyncableServiceTest.* unit tests pass, with AppServiceAsh disabled or enabled. The App Service listens for extensions being installed, not just added. Also remove some test EXPECT's that were checking a transient state, which are implementation details. That transient state was no longer reached, once RunUntilIdle calls were added to keep App Service's Mojo IPCs moving along. BUG=826982 Change-Id: I1e14f3a87316003309641c3a86d59dfb666bb8dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1593886Reviewed-by:
-
David Staessens authored
This CL adds support for resolution switching test videos to the new video decoder tests. This only requires adding a trivial implemention for the DismissPictureBuffer function. TEST=ran new VDA tests on eve BUG=934065 Change-Id: Ibf31098852f863cae30396a9a969150465ae3982 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1583024Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#658355}
-
Lucas Tenório authored
This flow is triggered at the end of the OOBE/Login for supervised accounts. It will show a series of pages that will be fetched from families.google.com and displayed in a webview. This flow will be triggered from a custom WebUI in the future, so we also add a common mojo interface that can be used in both WebUIs. For more context about this flow, see the documents linked in the bug. Added as reviewers: - sky@ for chrome/app/BUILD.gn - alemate@ for chromeos/login - stevenjb@ for chromeos/supervision - kerrnel for mojom and chrome/app/*_manifest.cc Bug: 958995 Change-Id: I8dc11d6a1d9c645cbaaeac18013d81f73f9add31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599924Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Reviewed-by:
-
Andrew Grieve authored
SequenceTaskRunner no longer require lifetime checks. Bug: 877963 Change-Id: I6d779e47b4ded24f38f6a9c29aaddda102a13bbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602152Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#658353}
-
Tommy C. Li authored
Update the comment to reflect that fact that this flag is already launched on Desktop and under development on Android. Bug: NONE Change-Id: I6ba24f9db7533597c36cf7cf52ee3aff3d30195e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603828Reviewed-by:
Orin Jaworski <orinj@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#658352}
-
Steven Bennetts authored
The mismatch was causing the internet details dialog to fail to load when DCHECK is enabled. This also updates the networking_private.js exports which was rather out of date. Bug: 957123 Change-Id: Ib42d4cc37fa4ea75ce917be0959d64b3d6daba7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603494Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#658351}
-
Kyle Horimoto authored
This makes it clear that this property applies only to Tether networks and should not be confused with DeviceState::operator_name(), which is the name of the carrier used for Cellular networks. Change-Id: I1c9398e24961aa8a569a07ea3970678b4c5b0408 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603746 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
-
Jonathan Metzman authored
Bug: 960422 Change-Id: Id239f4a5dbe49882864c405fb092b615f8b7cf5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1602875 Commit-Queue: Jonathan Metzman <metzman@chromium.org> Auto-Submit: Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Max Moroz <mmoroz@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#658349}
-
Jinsuk Kim authored
Replaces a default chrome icon with favicon for the pages being opened on Ephemeral Tab. Didn't chose to use FaviconHelper.java to avoid unnecessary conversion from SkBitmap -> JavaBitmap -> SkBitmap. Bug: 929727 Change-Id: Ide1698470b052b2914dd490a0d40ce175989c651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601015Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#658348}
-
Christopher Grant authored
When enabled, this change will package the VR native library in the VR DFM. Also, introduce a .gni that computes whether native libraries in modules is enabled as a whole (not VR specific). Bug: 921663 Change-Id: Iacf09c46393daf924059217b3c7b335822cedef6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601535 Commit-Queue: Christopher Grant <cjgrant@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#658347}
-
Karan Bhatia authored
This CL adds metrics to record which response headers are added, removed and modified using the Web Request API. Also, the existing histograms Extensions.WebRequest.SetCookieResponseHeaderChanged and Extensions.WebRequest.SetCookieResponseHeaderRemoved, which are already expired; are marked obsolete and their tests re-purposed for the new histograms. BUG=953956, 904568, 827582 Change-Id: I9da081df1732d577476168d1ee1855fccfe8c198 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591491 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#658346}
-
Dale Curtis authored
This reverts commit c2f89e17. Reason for revert: Broke waterfall. == '.webm' is invalid. Original change's description: > Switch to using vp9-lossless for VideoEncodeAccelerator test files. > > These raw files were large and are slowing down the fuzzer process; > this saves 13,416,948 bytes. I've confirmed via MD5 hashes that > the decode path and the yuv path generate the same output data. > > BUG=960139 > TEST=verify MD5 hashes between compressed and uncompressed variables. > R=hiroh, inferno > > Change-Id: If5140a2d1c98cb0f973adff1a10cdb5c4c36cd55 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595430 > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Hirokazu Honda <hiroh@chromium.org> > Cr-Commit-Position: refs/heads/master@{#658340} TBR=dalecurtis@chromium.org,inferno@chromium.org,hiroh@chromium.org Change-Id: Icd24426ea2d51fc487f10b932f2cd3cca9618468 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 960139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604053Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#658345}
-
- 09 May, 2019 22 commits
-
-
Daniel Cheng authored
Bug: 958675 Change-Id: Ica6b5bab7849f227567d8016354a39383533799f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595585 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#658344}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/5cf297dfa77c..dce7a4bc30c0 git log 5cf297dfa77c..dce7a4bc30c0 --date=short --no-merges --format='%ad %ae %s' 2019-05-09 dneto@google.com Roll glslang, spirv-tools, spirv-headers, spirv-cross (#614) Created with: gclient setdep -r src/third_party/shaderc/src@dce7a4bc30c0 The AutoRoll server is located here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com Change-Id: I555c27cb351a9cb46327963bcd8383ce434a9879 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603785Reviewed-by:
-
Daniel Rubery authored
The mitigation previously in place for https://crbug.com/919709 isn't sufficient in preventing long-tail ZIP analysis from taking a long time. So this CL lowers the size limit for detailed ZIP unpacking. We will roll this out by a Component Update, then restore to the old limit for M75. Bug: 959628 Change-Id: Iae254bfc8cd78aac977f9751c3664407ac6282b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599877Reviewed-by:
-
Charlene Yan authored
SitePerProcessInternalsHitTestBrowserTest.NestedLocalNonFastScrollableDivCoordsAreLoca TBR=wjmaclean@chromium.org Bug: 961135 Change-Id: I55775c6d772a1ef19a71b0a78a25410e1b2c6ec9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603771Reviewed-by:
Charlene Yan <cyan@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#658341}
-
Dale Curtis authored
These raw files were large and are slowing down the fuzzer process; this saves 13,416,948 bytes. I've confirmed via MD5 hashes that the decode path and the yuv path generate the same output data. BUG=960139 TEST=verify MD5 hashes between compressed and uncompressed variables. R=hiroh, inferno Change-Id: If5140a2d1c98cb0f973adff1a10cdb5c4c36cd55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595430 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
Matt Wolenetz authored
Previously, only 'audio/mp4' would report support for opus codec in Chromium MSE. This change adds support for opus codec in 'video/mp4' mime to Chromium. For example, MediaSource.IsTypeSupported('video/mp4; codecs="opus"') now returns true with this change. Also adds a couple opus-in-mp4 and -in-webm IsTypeSupported test cases to the interop wpt suite, though the particular test file is currently marked [ failure pass ] in Blink TestExpectations due to those tests containing a mix of proprietary and non-proprietary codecs such that bots running without all the necessary codec support will fail the test. I've filed https://crbug.com/961443 to track improving MSE IsTypeSupported test coverage at least in Chromium. BUG=649438 Change-Id: I7c47b6c2566432be9627394f5ff30e0a43888300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603527Reviewed-by:Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#658339}
-
Erik Jensen authored
The gRPC directory API use chromoting.directory instead of chromoting, and FTL signaling requires an additional scope. Change-Id: Ifbe3fe32fc30bbd94b71cac46810ebbfd77160cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603769 Commit-Queue: Erik Jensen <rkjnsn@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#658338}
-
Danyao Wang authored
This patch redacts recipient, organization, phone and address line from the shipping address before returning it for onshippingaddresschange. The goal is to minimize the personal information returned to merchant website before user fully commits to the payment transaction. Spec: https://w3c.github.io/payment-request/#shipping-address-changed-algorithm Intent to ship and implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/69dw-4Myc_A Chrome Status entry: https://chromestatus.com/features/5653566570102784 This patch lands the feature behind the #enable-web-payments-experimental-features flag so developers can start testing in M76, with the intention to ship in M77. Bug: 821771 Change-Id: I2cda43615844b1533310dfe54903cbefeafc7980 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600720 Commit-Queue: Danyao Wang <danyao@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#658337}
-
Robert Ogden authored
Offline Page's init on Android is making this flaky. This changes the test to pass a null browser context so that doesn't happen. Bug: 960773 Change-Id: Ife6b78321bd72ada6c4ed7b9c70e12472fb2e5f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603842Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#658336}
-
Noel Gordon authored
This reverts commit d80f755b. Reason for revert: Waterfall linux-chromeos-rel build failed: https://ci.chromium.org/p/chromium/builders/ci/linux-chromeos-rel/24116 Failing tests: EnrollmentLocalPolicyServerBase.ManualEnrollment EnrollmentLocalPolicyServerBase.ManualEnrollmentWithDeviceAttributes EnrollmentLocalPolicyServerBase.ManualEnrollmentWithMultipleLicenses Original change's description: > DeviceStateMixin: Update local state and support for setting policy > > Taking over rsorokin's patch at CL:1578742, given that he is OOO. > > DeviceStateMixin now initialized device state values in local > state during setup. > > Add support for setting device policy and device local account policies > in in-memory fake session manager client, in a way similar to > UserPolicyMixin. Later this functionality can be moved to a separate > mixin, which might make sense if/when we add functionality for setting > up policy served by local test policy server to this mixin (this should > already be possible using LocalPolicyTestServerMixin). > > Uses AutoLaunchedKioskTest as an example of new usage. > > Also fixes a number of tests to wirk with the new device state setup. > > Bug: 952855 > Change-Id: I1c0314a51581137d0f5a0907a09a4ef5b0bccda3 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600857 > Reviewed-by: Denis Kuznetsov <antrim@chromium.org> > Reviewed-by: Alexander Alekseev <alemate@chromium.org> > Commit-Queue: Toni Baržić <tbarzic@chromium.org> > Cr-Commit-Position: refs/heads/master@{#658297} TBR=tbarzic@chromium.org,antrim@chromium.org,alemate@chromium.org Change-Id: I73316a1dab02d817c16209a46c5a662682901269 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 952855 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604383Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#658335}
-
Luum Habtemariam authored
DDoc: go/cups-plugin Adds flag to condition above printing pipeline on. Will be used to condition the CupsProxyService startup. Bug: chromium:495409 Test: build unit_tests & run CheckHistograms + EveryFlagHasMetadata Change-Id: Id4b75ceca33a9930992e1732537621cbc154a64b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601835Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Commit-Queue: Luum Habtemariam <luum@chromium.org> Cr-Commit-Position: refs/heads/master@{#658334}
-
Evan Stade authored
Bug: 958230 Change-Id: I544e7557cfaa0f93d23df2a40a3136a6c3232d53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597973 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
-
Stefan Zager authored
BUG=914844,941495 Change-Id: I8ab2eb17b308440dd4d29c231526e03d1d66fd56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601685Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Stefan Zager <szager@chromium.org> Cr-Commit-Position: refs/heads/master@{#658332}
-
Hazem Ashmawy authored
Pass crash key-value pairs info from native while writing crash reports as MIME minidumps to CrashFileManager in order to be used later by WebView to show them in WebView Crash UI. R=tobiasjs@chromium.org Bug: 958340 Change-Id: Ib594c0429b3721bb8ee1d5a806fcab094d108842 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591635 Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Auto-Submit: Hazem Ashmawy <hazems@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#658331}
-
Nicolás Peña Moreno authored
Bug: 823744 Change-Id: I5a18e0650366001efd78055b529c36489e87ebfb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600340 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Timothy Dresser <tdresser@chromium.org> Cr-Commit-Position: refs/heads/master@{#658330}
-
Ben Wells authored
These test a dialog which shows info about an app, including the size of the app. When run in a test the app doesn't exist. The size calculation still runs, however, and ends up calculaing the size of the working directory, which can be really slow. This change skips calculating the size if the app doesn't have a path. Bug: 953964 Change-Id: Ie7ec878bfd26f2ac9c53bde3fa1c7c0327f0198c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1594384 Commit-Queue: Ben Wells <benwells@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Cr-Commit-Position: refs/heads/master@{#658329}
-
Darwin Huang authored
Change-Id: I9576f5f8191a42d518b984966cb745bc4b97d6f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600861 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#658328}
-
Chris Palmer authored
Bug: 959978 Change-Id: Icb31f4706eb527f03e697a5cd285422413a592c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603485Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#658327}
-
Jun Cai authored
This CL implements the permission prompt for Bluetooth scanning API on desktop: 1. Implements a permission prompt suggested on the design doc. The message at the top of the prompt calls out that the user is being asked the permission for a site to receive nearby Bluetooth advertisement packets. The prompt lists device name for found nearby Bluetooth devices. 2. Adds a ShowBluetoothScanningPrompt method to the WebContentsDelegate interface which launches a permission prompt displaying the nearby Bluetooth devices. I uploaded some screenshots of the permission prompt in the issue link. Design doc: https://docs.google.com/document/d/18Rqg1HRGeDngPv60DAGoMnIwRB-Zjh5gOWmANmH8lTo/edit Bug: 953075 Change-Id: I2924e177f927cf3411fe00f4df180e206341d731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1589267 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#658326}
-
Owen Min authored
Register local_state for CloudPolicyEnabled policy. Reigster local_state for lastUploadTimestamp Bug: 956237 Change-Id: I567607568e66cb2f1b9d7dfc87d134a3a0e90260 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1590645 Commit-Queue: Owen Min <zmin@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#658325}
-
Scott Violet authored
This is all dead code. BUG=960503 TEST=covered by tests Change-Id: I2fe889b5f75bf73e63ceadc8f01a89d9d284ee50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603883Reviewed-by:
-
Yue Li authored
Currently the dialog is blocking the other overview mode windows. Hide it for now to fix the issue. Bug: b/131186127, 942714 Test: Manual Test Change-Id: I470b4f334cc5126f8a32a3880e7d54533a47a81e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603770Reviewed-by:
-
