GitLab

BUG=498683

Review URL: https://codereview.chromium.org/1175033002

Cr-Commit-Position: refs/heads/master@{#333798}

Review URL: https://codereview.chromium.org/1152553011

Cr-Commit-Position: refs/heads/master@{#333797}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/587f4ec..1ba4dff

TBR=yurys@chromium.org,dglazkov@chromium.org

Review URL: https://codereview.chromium.org/1174083003

Cr-Commit-Position: refs/heads/master@{#333796}

BUG=None
TBR=tedchoc@chromium.org

Review URL: https://codereview.chromium.org/1174823002

Cr-Commit-Position: refs/heads/master@{#333795}

Introduce a ScopedExtensionDialogAutoConfirm to use in place of the
ExtensionUninstallDialog::ScopedAutoConfirm and the unscoped
ExtensionInstallPrompt::g_auto_confirm_for_testing. Also use this in the
management api instead of it's g_auto_confirm_for_testing.

TBRs for small mechanical changes.
TBR=atwilson@chromium.org (c/b/policy)
TBR=pkasting@chromium.org (c/b/infobars)

Review URL: https://codereview.chromium.org/1148323007

Cr-Commit-Position: refs/heads/master@{#333794}

There were two things causing flake:
. The bounds of the root asynchronously changes.
. Similarly the metrics are asynchronously available.
As tests expect certain things to happen in a certain order these were
causing problems.
As we don't care about these cases I've ignored tracking them. This
makes the test cleanly pass now.

I also added --repeat-count to the apptest_runner.

BUG=497920
TEST=test only change
R=msw@chromium.org

Review URL: https://codereview.chromium.org/1174993002

Cr-Commit-Position: refs/heads/master@{#333793}

Android likes to hold onto Activities while Chrome is in the foreground.
Send the user home before closing everything.

BUG=451453

Review URL: https://codereview.chromium.org/1176043002

Cr-Commit-Position: refs/heads/master@{#333792}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/83ca628..523beb7

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/1177753004

Cr-Commit-Position: refs/heads/master@{#333791}

This is to unthrottle plugins that start small but then are resized by Javascript to be large.

Notably it fixes the weatherspark.com use case. (Resize your browser window to be 1270x760 ish to test)

BUG=489376

Review URL: https://codereview.chromium.org/1124173008

Cr-Commit-Position: refs/heads/master@{#333790}

Fixes: "Error in event handler for extensionViewInternal.onLoadCommit: TypeError: Cannot read property 'onLoadCommit' of undefined"

Review URL: https://codereview.chromium.org/1169803006

Cr-Commit-Position: refs/heads/master@{#333789}

TBR=cylee@chromium.org
TBR=nednguyen@chromium.org

BUG=498950

Review URL: https://codereview.chromium.org/1172443004

Cr-Commit-Position: refs/heads/master@{#333788}

Builds were failing with:

  ERROR at //build/config/compiler/BUILD.gn:116:11: Undefined identifier
        if (visual_studio_version == "2013") {
            ^--------------------

BUG=82385, 440500

Review URL: https://codereview.chromium.org/1178603002

Cr-Commit-Position: refs/heads/master@{#333787}

This adds an owners file that matches java_staging.

BUG=None

Review URL: https://codereview.chromium.org/1181443002

Cr-Commit-Position: refs/heads/master@{#333786}

BUG=493695

Review URL: https://codereview.chromium.org/1177453003

Cr-Commit-Position: refs/heads/master@{#333785}

Revert of Change focus status according to the change of window focus (patchset #5 id:80001 of https://codereview.chromium.org/1164033002/)

Reason for revert:
This CL caused http://crbug.com/498631.

Original issue's description:
> Change focus status according to the change of window focus
>
> On Android, View's focus status isn't changed when window focus is lost.
> So we should update ContentViewCore's focus status according to the
> change of window focus.
>
> BUG=495547
>
> Committed: https://crrev.com/98d5087ecd03ed36ec2e161102b71dad97a92b4c
> Cr-Commit-Position: refs/heads/master@{#333446}

TBR=jdduke@chromium.org,tedchoc@chromium.org,boliu@chromium.org,ajith.v@samsung.com
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=495547

Review URL: https://codereview.chromium.org/1177483003

Cr-Commit-Position: refs/heads/master@{#333784}

The CacheStorage classes shouldn't store raw pointers to
URLRequestContext. Use the getter class instead. This is part of a
cleanup to ensure that URLRequests are canceled before
URLRequestContext is deleted.

BUG=498563

Review URL: https://codereview.chromium.org/1174943004

Cr-Commit-Position: refs/heads/master@{#333783}

This patch implements a way to register callbacks for when a GuestView is destroyed in GuestViewManager.

This new callback system is used to do some memory cleanup in WebViewGuest when each view is destroyed, instead of only when the embedder is destroyed.

BUG=355360

Review URL: https://codereview.chromium.org/1143333008

Cr-Commit-Position: refs/heads/master@{#333782}

Enable longpress drag selection and smart selection by default on
Android platforms more recent than L, for both Chrome and WebView.

BUG=466749,451255

Review URL: https://codereview.chromium.org/1175703002

Cr-Commit-Position: refs/heads/master@{#333781}

The internal logic for cursor iteration in Continue()
needs to handle four cases: "next", "nextunique", "prev",
"prevunique". This was handled in a single function with a
single loop and hairy `if (forwards) {} else {}` and `if
(unique) {}` clauses, which made understanding and
extending it difficult.

This CL splits the function into two cases: ContinueNext()
for "next"/"nextunique" cursors and ContinuePrevious() for
"prev"/"prevunique" cursors, which greatly simplifies the
logic for each.

The "prevunique" case is particularly complex, since the
spec requires that the first duplicate (in index order) is
returned rather than the last (the one encountered first
when iterating backwards). This was previously done by
iterating further then reversing, all within the same
loop. Now, this case is handled by a subsequent loop.

BUG=497454
R=cmumford@chromium.org

Review URL: https://codereview.chromium.org/1170833004

Cr-Commit-Position: refs/heads/master@{#333780}

BUG=475182

Review URL: https://codereview.chromium.org/1174653002

Cr-Commit-Position: refs/heads/master@{#333779}

$ git log 3b950126e..ba08c21a0 --date=short --format='%ad %ae %s'
2015-06-08 reillyg system_api: Add constant for permission_broker's OpenPath method.
2015-06-09 zqiu Add IPConfig properties for IPv6 delegated prefix
2015-05-20 ejcaruso service_constants: add CancelBatterySaverMode method to powerd

BUG=496469

Review URL: https://codereview.chromium.org/1172143006

Cr-Commit-Position: refs/heads/master@{#333778}

BUG=497898

Review URL: https://codereview.chromium.org/1167353002

Cr-Commit-Position: refs/heads/master@{#333777}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/30d24a9..587f4ec

TBR=yurys@chromium.org,dglazkov@chromium.org

Review URL: https://codereview.chromium.org/1172363003

Cr-Commit-Position: refs/heads/master@{#333776}

Recent changes to IME ( https://codereview.chromium.org/1155013005 )
mean we need to initialize IME.

BUG=none
TEST=none
R=erg@chromium.org

Review URL: https://codereview.chromium.org/1177783002

Cr-Commit-Position: refs/heads/master@{#333775}

This help the conversion from page_set to story_set easier.

BUG=439512
CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:mac_perf_bisect;tryserver.chromium.perf:win_perf_bisect;tryserver.chromium.perf:android_nexus5_perf_bisect

Review URL: https://codereview.chromium.org/1176733003

Cr-Commit-Position: refs/heads/master@{#333774}

This adds proper handling of cases where the GPU service returns
an invalid handle. This can happen if the GPU process crashed while
there was an allocation request in-flight or if the GPU service is
simply misbehaving.

BUG=486922

Review URL: https://codereview.chromium.org/1166213003

Cr-Commit-Position: refs/heads/master@{#333773}

BUG=492452

Review URL: https://codereview.chromium.org/1154063003

Cr-Commit-Position: refs/heads/master@{#333772}

This CL adds INITIALIZING, CONNECTING, FAILED and CANCELED states to the host-side IT2Me
connection set-up. It has the following components:

* BufferedSignalStrategy: A new class to wrap an underlying SignalStrategy so that messages
  can be logged before the XMPP connection is established. Doing otherwise would slow down
  connections unnecessarily, but a consequence is that we aren't guaranteed that the new
  messages will actually be logged; still it's better than the previous situation.
* Support for host-side logging in LogToServer.
* Minimal refactoring to make the code that reads the local host version publicly callable.

Note that some of this code, in particular the BufferedSignalStrategy class should go away
if we implement logging using XHRs.

BUG=497876

Review URL: https://codereview.chromium.org/1176693002

Cr-Commit-Position: refs/heads/master@{#333771}

BUG=486265

Review URL: https://codereview.chromium.org/1149083013

Cr-Commit-Position: refs/heads/master@{#333770}

Make sure that subzero can also handle various pexes with a
bad header. Test with a tiny fake .pexe (already had
that test case) and a larger realistic nonfinalized pexe.

The nonfinalized pexe requires streaming multiple chunks
and so is able to tickle an error-reporting race condition
(use-after-free) + possible deadlock. I tried it on subzero
from last week and was able to tickle the crash.
It should no longer tickle that bug this week unless
there's a regression.

The tiny version runs pretty quickly, but otherwise had
not been crashing before. It merely returned an imprecise
error message ("Some error occurred"), which should
now be fixed too.

BUG= https://code.google.com/p/nativeclient/issues/detail?id=4163

CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:linux_chromium_dbg_32_ng

Review URL: https://codereview.chromium.org/1157213005

Cr-Commit-Position: refs/heads/master@{#333769}

The test runner clears application data before each test it runs, as well as
after it has run all tests. However, some suites drop useful files in the
application data directory. This provides a mechanism for retrieving those
files from the device.

BUG=489713

Review URL: https://codereview.chromium.org/1165623003

Cr-Commit-Position: refs/heads/master@{#333768}

https://chromium.googlesource.com/angle/angle.git/+log/39fcf26..e754fb8

BUG=436191

TEST=bots

Review URL: https://codereview.chromium.org/1174063003

Cr-Commit-Position: refs/heads/master@{#333767}

The ALSA-based CMA backend doesn't support that functionality yet.

BUG=internal b/19544200

Review URL: https://codereview.chromium.org/1175843002

Cr-Commit-Position: refs/heads/master@{#333766}

Revert of Make sure multi chracter codepoints are deleted correctly (patchset #6 id:100001 of https://codereview.chromium.org/1165793007/)

Reason for revert:
Failing Android Tests (dbg) builder: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/28499

The newly added test seems to be flaky.

Original issue's description:
> Make sure multi chracter codepoints are deleted correctly
>
> deleteSurroundingText() only deletes one character even for multi-character
> codepoint.
>
> On the blink side, we have InputMethodController::extendSelectionAndDelete()
> to make sure selection and deletion respect Unicode boundaries. However,
> AdapterInputConnection keeps track of selection region separately, and this
> value is incorrectly updated.
>
> On top of adding a new test for this case, it extends
> waitAndVerifyEditorCallback to also check the outbound calls to
> InputMethodManager.
>
> The above extension found that testEnterKeyEventWhileComposingText fails
> because there is hidden discrepancy between blink implementation and
> what we report to InputMethodManager. So I've added a TODO for that.
>
> BUG=497091
>
> Committed: https://crrev.com/5f6e036312bc4a978768f5b5971eee1a5ec9f272
> Cr-Commit-Position: refs/heads/master@{#333704}

TBR=aelias@chromium.org,aurimas@chromium.org,bcwhite@chromium.org,tedchoc@chromium.org,changwan@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=497091

Review URL: https://codereview.chromium.org/1173083004

Cr-Commit-Position: refs/heads/master@{#333765}

This allows VP9/lossy mode to "top-off" previously encoded imagery to
improve visual quality at the client, by continuing to deliver data even
when nothing has actually changed on the host desktop.

This CL makes several other minor changes:
- Fix the host's --enable-i444 flag, which was broken by refactoring.
- Tweak VP9/lossy mode to more conservative quantization settings.
- Tweak VP9/lossy mode to encode up to two unchanged frames for top-off.
- Update VideoEncoderVerbatim for the new VideoFramePump semantics.
- Update the VideoFrameRecorder & FakeDesktopCapturer.
- Adds simple codec & VideoFramePump unit-tests for the new behaviour.

BUG=134202

Review URL: https://codereview.chromium.org/1150163002

Cr-Commit-Position: refs/heads/master@{#333764}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/f2fe0e0..83ca628

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=djsollen@google.com

Review URL: https://codereview.chromium.org/1175583003

Cr-Commit-Position: refs/heads/master@{#333763}

This is implemented in AppCompat now and our custom implementation
was causing bugs (e.g. the cursor was showing up white).

BUG=497608

Review URL: https://codereview.chromium.org/1169903003

Cr-Commit-Position: refs/heads/master@{#333762}

This CL fixes some issues that came up Video Capture Device unittest, where it tries to capture format that are not supported by the device and makes size assumptions on it-device being daisy in this case-.

- We check the exact size if returned type is equal to the requested type PIXEL_FORMAT_I420.
- If it is some other format, excluding PIXEL_FORMAT_MJPEG, we make the assumption that it is at least 12 BPP.

BUG=482875

Review URL: https://codereview.chromium.org/1176613003

Cr-Commit-Position: refs/heads/master@{#333761}

If handling of NaClProcessMsg_Start fails, we want the NaCl loader
process to exit, otherwise it will potentially hang around uselessly
without being killed.

So change the error handling to exit with fatal errors instead of
returning to the message loop.

nonsfi/nonsfi_listener.cc already uses fatal errors, so no change is
required there.

BUG=496287
TEST=none

Review URL: https://codereview.chromium.org/1179523002

Cr-Commit-Position: refs/heads/master@{#333760}

This change removes the 'view original' link and replaces it with
a button that currently navigates to the original article but will
eventually slide the view out of focus.

The feedback form and close button now span the full width of a page
while content is limited to 800px wide.

BUG=428533

Review URL: https://codereview.chromium.org/1160113004

Cr-Commit-Position: refs/heads/master@{#333759}