- 11 Aug, 2020 40 commits
-
-
Richard Knoll authored
Attachment ids are transferred via wire_format.proto and need to be serialized/deserialized to int64. Also removes virtual methods from the base Attachment class and adds |text_title| to TextAttachment. Bug: 1085067 Change-Id: I39f0820f6682718c88e6b92947ad5a156c0ab294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346807Reviewed-by:
Himanshu Jaju <himanshujaju@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#796857}
-
Shu-yu Guo authored
Bug: v8:7883 Change-Id: Ic91546ea953d66d3742e599ad0a8da778b6363b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346942Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#796856}
-
Elly Fong-Jones authored
Bug: 1115106 Change-Id: I82a797d19e6c70e7983221128f769ffb5596bc71 Tbr: lazyboy@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348695Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#796855}
-
Friedrich Horschig authored
This CL ensures that the referrer is considered in the decision to run the password check. When coming from safety check: use last status, don't run check When coming from anywhere else: run the check when possible. The initial status is not relevant for the decision to run. If it's RUNNING, the call is a noop. If it's IDLE or cancelled, it makes sense to run a new check. If it's any error state, rerunning might show the error was fixed since the last attempt. Reaching a new failure won't take long. Bug: 1109691, 1092444 Change-Id: I573a5f9f0a8861e598541fa38faa2d8bd42adba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348773Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#796854}
-
sczs authored
- Prevents the same FeedVC from being re-added to the VC hierarchy, and if a new FeedVC is set, removes the old one from the VC hierarchy. - Uses KVO to observe of Feed contentSize changes, so we can reload the Collection view and display the Feed. Without this the Feed wouldn't appear after it has been loaded. Credit to adamta@ crrev.com/c/2342580 - Sets a minimum height for the Feed Cell, this way the loading spinner will always be displayed. Bug: 1085419 Change-Id: I9d9ef7978a667a2eddc62c0b8e1aad5300185cc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347372 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#796853}
-
Anastasiia N authored
- Use Chrome OS Account Manager in identity_test_utils instead of calling UpdateCredentials on token service. Account Manager is created in BuildIdentityManagerForTests. - Change FakeProfileOAuth2TokenService to allow passing custom delegate and use ProfileOAuth2TokenServiceDelegateChromeOS instead of fake delegate on Chrome OS. See details: http://doc/1_JHwE0NioyMVBfebGxuN0EjM91JhyDz1-Hi5PBOPtEw Bug: 1068240 Change-Id: I083e806b37cd967ed0759a2e6add13e07bfa68e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2232324Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Commit-Queue: Anastasiia N <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#796852}
-
Kyle Ju authored
Testing Command: python third_party/blink/tools/wpt_export.py --dry-run --credentials <your credentials> --surface-failures-to-gerrit --verbose A Sample Comment: The exported PR, https://github.com/web-platform-tests/wpt/pull/24650, has failed the following check(s) on GitHub: wpt-firefox-nightly-stability (https://github.com/web-platform-tests/wpt/pull/24650/checks?check_run_id=883668859) ... These failures will block the export. They may represent new or existing problems; please take a look at the output and see if it can be fixed. Unresolved failures will be looked at by the Ecosystem-Infra sheriff after this CL has been landed in Chromium; if you need earlier help please contact ecosystem-infra@chromium.org. Gerrit CL SHA: 0e4d176d93a1a70e03720dbeb8142139e0df5871 Patchset Number: 2 Change-Id: I3376a7913c6677ed219717d2a4ddbc065ce83fbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2336542 Commit-Queue: Kyle Ju <kyleju@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#796851}
-
Dave Tapuska authored
The OneShotTimer needs to be destroyed on the main thread. Destroy it during ClearClient. BUG=1112931 Change-Id: I9fb7946947943f7ff2a5bbb19d7ae1af94335b08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347392 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#796850}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/01e0ccdc9b8b..dc4568899168 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I24e32f1e18c446f923ee88a2bc09f0e4fc987693 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348256Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796849}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: I34b051b9e27d8fda1e6443e65c58c232a44b3fb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348199Reviewed-by:
-
Niels Möller authored
This flag (not to be confused with EncoderInfo::is_hardware_accelerated) is no longer used by webrtc. Bug: None Change-Id: I5a0524cced0f6f4a45699d2b8caa0ccfcb98336f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346656 Commit-Queue: Gary Kacmarcik <garykac@chromium.org> Reviewed-by:
Gary Kacmarcik <garykac@chromium.org> Cr-Commit-Position: refs/heads/master@{#796847}
-
Kramer Ge authored
WaylandOverlayManager treats any overlay candidate as eligible for hardware overlay. Overlays and primary plane will be forwarded to wayland server and whether they're picked to be displayed as HW overlay is decided by wayland server. This is 4/? CL for overlay forwarding using wl_subsurface. Bug: 1063865 Change-Id: I63e9e3bca152f5202c0f2c35d26d5f9d3663eecb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321514 Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#796846}
-
nancylingwang authored
The icon callback may outlive ArcAppShortcutSearchResult, so bind the callback to a weak ptr. BUG=1114754 Change-Id: If261827920d5a4780a80695095937a9f7dd59c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348492Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#796845}
-
Lukasz Anforowicz authored
The original fix (r719801) for https://crbug.com/1026474 is undesirable, because it may put an about:blank subframe in a separate BrowsingInstance from its parent. Therefore the current CL partially reverts r719801 and implements an alternative fix for preserving the SiteInstance of about:blank after session restore. The alternative fix is to: 1. Prefer |source_site_instance| (in RFHM::DetermineSiteInstanceForURL) over a site-less |current_instance|. 2. Make sure that |source_site_instance| is created by NavigationRequest constructor in session restore cases requiring initiators (and not just in |is_history_navigation_in_new_child_frame| case). The changes above break the following COOP test: NewPopupCOOP_SameOriginPolicyAndCrossOriginIframeSetsNoopener, because COOP explicitly wants to suppress the opener and doesn't want to use *same-BrowsingInstance* |source_site_instance|. The fix for this is to 3. Make sure that |source_site_instance| is not populated if |opener_suppressed| in WebContentsImpl::CreateNewWindow. The change above means that the following DCHECK in the NavigationRequest's constructor fails: DCHECK(!RequiresSourceSiteInstance() || source_site_instance_) The fix for this is to: 4. Stop requiring |source_site_instance| if the opener was suppressed (see the changes in NavigationRequest::RequiresSourceSiteInstance). Summary of tests relevant to this CL: - MultiOriginSessionRestore - new asserts have been added to require that the subframe is in the same BrowsingInstance as the parent. - NewPopupCOOP_SameOriginPolicyAndCrossOriginIframeSetsNoopener - shows the need to avoid using |source_site_instance| when the opener has been suppressed - IncognitoApiTest - shows that there are scenarios where it is okay to use a cross-BrowsingInstance |source_site_instance| (navigations initiated via extension API should switch BrowsingInstance). - SubframeBlankUrlsAfterRestore - highlights the need to check |browser_initiated_| in RequiresSourceSiteInstance. Bug: 1107269 Change-Id: Ibbdcb6c3a5d309a8fe17991b06f380dffcd225d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327963 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#796844}
-
Zarah Tesfai authored
Purpose: Move UI Logic of retry() in PRImpl to PaymentUIsManager Change: * onRetry() method in PaymentRequestLifecycleObserver * onRetry() implemented in PaymentUIsManager Bug: 1113337 Change-Id: If4692bf3cd3539d5379b108651205ac2fb2345ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339705Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Zarah Tesfai <ztesfai@google.com> Cr-Commit-Position: refs/heads/master@{#796843}
-
arthursonzogni authored
I was suggested the "isolate" argument of ReportCoopAccess could be determined by the DomWindow instance itself: https://chromium-review.googlesource.com/c/chromium/src/+/2339353/4 This patch removes it from the ReportCoopAccess method and updates the callers. Bug: 1090273 Change-Id: I0286f13ea8700c419728f89f706baf71bb0f0642 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346569 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#796842}
-
George Steel authored
Change-Id: I47f6de8275c1b17399671eb069794ad2857fdae8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341827Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: George Steel <gtsteel@chromium.org> Cr-Commit-Position: refs/heads/master@{#796841}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/01e0ccdc9b8b..dc4568899168 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I4111b739c6dda15890f9c1a00a92279ee82de464 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348203Reviewed-by:
-
Dominik Röttsches authored
Contains fix for lack of variable whitespace scaling on Mac when font only uses phantom points + GVAR for whitespace scaling. Tested in HarfBuzz in https://github.com/harfbuzz/harfbuzz/blob/master/test/shaping/data/in-house/tests/variations-space.tests https://chromium.googlesource.com/external/github.com/harfbuzz/harfbuzz.git/+log/cdb7d2b9bc0d..3d164d5883ce $ git log cdb7d2b9b..3d164d588 --date=short --no-merges --format='%ad %ae %s' 2020-08-06 git Use printf instead of echo -n in autogen.sh 2020-08-07 ebrahim [glyf] Optimize retrieval of hmtx/vmtx/gvar 2020-08-07 ebrahim [gvar] minor 2020-07-30 ebrahim Skip hb_shape if buffer object is immutable 2020-08-06 ebrahim [glyf] Clamp advance value result 2020-08-06 ebrahim [gvar] Don't fail on imprefect gvar 2020-08-06 ebrahim [var] Apply variations on empty glyphs 2020-08-06 ebrahim [gvar] minor 2020-08-04 ebrahim [docs] minor on TESTING.md 2020-08-04 ebrahim [docs] meson related updates on install 2020-08-04 ebrahim [meson] minor note 2020-08-03 ebrahim [docs] Update README.python.md with meson 2020-07-30 ebrahim Remove cmake-config support of HarfBuzz 2020-08-02 ebrahim [meson] Pass cpp_eh=none and cpp_rtti=false as default options 2020-08-02 ebrahim [meson] remove useless note about -fvisibility-inlines-hidden 2020-08-02 ebrahim [perf] Enable ttf-parser build just with experimental_api Created with: roll-dep src/third_party/harfbuzz-ng/src R=bashi@chromium.org,behdad@chromium.org,bungeman@chromium.org,drott@chromium.org,eae@chromium.org,jshin@chromium.org,kojii@chromium.org Bug: 1102739 Change-Id: I4ad950f38435bff13e6df38f04234138666143f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342853 Commit-Queue: Dominik Röttsches <drott@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#796839}
-
Elly Fong-Jones authored
Bug: 1115102 Change-Id: Icf7da100c9e82155a152b0556fd7a8ad22c64c89 Tbr: arthursonzogni@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348535Reviewed-by:
-
Morten Stenshorne authored
We'd fail to add column layout results to LayoutBox if a fragmentainer got interrupted by a spanner, which would eventually mess up fragment index calculation in AddColumnResult(), which in turn could make us keep old fragments associated with deleted layout objects. This fixes 4 out of 5 tests that failed because of bug 1105758. Bug: 1105758 Change-Id: If358c296e2d89b1e5491b5578446466ea3f2bb38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346249Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#796837}
-
Elly Fong-Jones authored
Bug: 1113904 Change-Id: I3b63c4fabf03d5eb11a9e8db6a0c748b87bc9886 Tbr: dbertoni@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348693Reviewed-by:
-
Elly Fong-Jones authored
Bug: 1115096 Change-Id: I2ae66d66ec6c13c4fde46a52af6995c10e58953f Tbr: alexmos@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348533Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4e32eae7. With Chromium commits locally applied on WPT: f141259f "COOP access reporting:" b772a8f1 "[Web Payment] Secure payment confirmation Blink parameters." 4e32eae7 "[COOP] Access reporting: More tests for indexed/named getters." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I9207935f650470b9f95b927ac73607f8acc479e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348577Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796834}
-
Corentin Wallez authored
Bug: dawn:22 Change-Id: I57d322b931290bdb922ba8c4d9a28f52f2ae425f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330053 Auto-Submit: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Reviewed-by:
Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#796833}
-
Tim Van Patten authored
Remove phoglund@google.com from the OWNERS list: Address not found Your message wasn't delivered to phoglund@google.com because the address couldn't be found, or is unable to receive mail. Bug: angleproject:4873 Change-Id: I46d76125d01a4c14fe2ee56449861d1f660ccd27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321720 Commit-Queue: Tim Van Patten <timvp@google.com> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#796832}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7e3e7bb35184..d2454323cb6e 2020-08-11 changhaohan@chromium.org TS-componentize Computed tab's style property and style trace elements 2020-08-11 alexrudenko@chromium.org Update CDP 2020-08-11 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-08-11 sigurds@chromium.org Don't show affected CSP resources if there are no affected CSP resources If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1096230,chromium:1106251 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I05c88ae1d4ebd260adc4948e2fdc9383bb0fbf2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348278Reviewed-by:
-
Sebastien Lalancette authored
Updated icons and unit tests. Bug: 1093302 Change-Id: I686d1ff0be31ade4260cb5955f937f01632ddc45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346846 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
-
Aleks Totic authored
TablesNG will support orthogonal writing modes. Reenable the wpt tests. Also, most of these tests already pass in Legacy. Bug: 409155 Change-Id: I7dd701263a2a63639309f7d3ba76726b109ab077 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348202Reviewed-by:
-
Sebastien Lalancette authored
Also added a new Sharing histogram value. Will consolidate into histograms.xml once at the end, with all the other histograms to be added. Bug: 1093302 Change-Id: If45ebd09731301efdfefa3169d7d1af40f6957fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347388 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
-
Elly Fong-Jones authored
Bug: 1074248 Change-Id: I39b3671b635b1152101c766780bc86061674ee74 Tbr: yigu@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347088Reviewed-by:
-
Stepan Khapugin authored
Adds support for scribble in location bar through an indirect interaction that forwards the scribbling into the omnibox. Bug: 1098342 Change-Id: I62dd5baa2085740d6c70d0913d8df1e917ecac77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341632 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#796826}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/109ff207de7d..5edf510941a3 2020-08-11 robertphillips@google.com Add plumbing for access to the flush-time GrSmallPathAtlasMgr 2020-08-11 adlai@google.com Revert "Migrate GrSurfaceContext readPixels to take direct context" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC fmalita@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408 Tbr: fmalita@google.com Change-Id: I9b4124294f4a05ab39b9fb3e563c07e55dbc65ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348201Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ea4f2acc6399..ad052807cdc7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC apotapchuk@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: apotapchuk@google.com Change-Id: I71e9d2d21d6cc1d1e23f95bfa2ce9e59964c6789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347175Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796824}
-
Anatoliy Potapchuk authored
Previously, if a test was a part of a suite, we would not have filtered it out properly using oobe_{positive,negative}.filter files. This cl fixes that TBR=antrim@chromium.org Bug: 1114907 No-Presubmit: true No-Tree-Checks: true No-Try: true Change-Id: Ib6b8adf5be12b7f0e5c7cc599dc049a7ecf748eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346336Reviewed-by:Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#796823}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/dc4568899168..21e5b4554a5f 2020-08-11 fmayer@google.com Merge changes I5ec5382a,I40f4bf4a 2020-08-11 fmayer@google.com Merge "Disable MTE when copying stack." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I07b10519de332bb8eb25ffdc2e755244f1ebca53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348277Reviewed-by:
-
Friedrich Horschig authored
In order to natively delete a credential, the compromised credential on the java-side needs to contain unformatted information about username, origin, sign-on real, and password. Therefore, this CL: * adds the required key attributes * makes the key attributes accessible by making JNI headers available * makes interfaces that pass 7 attributes to construct a credential pass the credential directly instead (minimizes confusion) The actual delete call is only one line in the password_check_manager that triggers the deletion and indirectly updates to the UI once the deletion happened. The deletion promoted two smaller errors which were one-line-fixed: * the mediator never clear old credentials — it just appended new ones * the confirmation dialog triggered twice (once with a null handler) Screenshot of the entire flow in the linked bug. Bug: 1108358, 1092444 Change-Id: I1f1a3f6e73c40c316cb2f711c44236388ff05b4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346345 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#796821}
-
Joe DeBlasio authored
This CL ensures that a given URL is not on the lookalikes / safety tips allowlist before eliding to eTLD+1. At present, the allowlist is very coarse-grained and doesn't disambiguate between what the allowlist entry is there to allowlist against (i.e. which UI treatment shouldn't be applied). A future change will add a bit more nuance. Bug: 1106962 Change-Id: I31eeb921afd5af89c8a1a2b1efc2b91c521eedc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346841Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#796820}
-
Marc Treib authored
Followup to https://crrev.com/c/1989533 Sync supports delaying the engine startup by 10 seconds. This is meant for avoiding contention during browser startup. Before this CL, the 10-second delay would also apply in one other (rare) situation, for no good reason other than some tests depending on this behavior. Two of these tests were recently fixed (in crrev.com/c/2339986), and the one remaining one is fixed in this CL. With that, the delayed startup can now go away! Bug: 1035874 Change-Id: I865d0bc3caac4d8f0712489ccbad526f912ccdce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343036Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#796819}
-
Alice Wang authored
This CL adds a spinner for sign-in in progress page of web sign-in and makes the horizontal divider disappear on the same page according to the UI mock. Screenshot: https://crbug.com/1102784#3 Bug: 1102784 Change-Id: I95cbc474a161c58ba235ddede70405c55e7db3b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345147Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#796818}
-
